Skip to content

[backport cloud/1.54] perf: skip document-wide modal scans while typing (#19057) - #19193

Merged
christian-byrne merged 1 commit into
cloud/1.54from
backport-19057-cloud-154
Sep 28, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
backport-19057-cloud-154

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Target-native backport of #19057. Adapts the production fast path and its unit coverage to the older change-tracker structure; omits main-only performance harness/CI files absent from this release branch.

@vercel

vercel Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 28, 2026 5:05am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 28, 2026 5:05am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 9634674d-c972-46bb-a942-9c8d37633904

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/28/2026, 05:12:41 AM UTC

Links

🎭 Playwright: ✅ 1962 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1941 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 28, 2026
@christian-byrne
christian-byrne merged commit a92b5a6 into cloud/1.54 Sep 28, 2026
86 of 88 checks passed
@christian-byrne
christian-byrne deleted the backport-19057-cloud-154 branch September 28, 2026 05:13
@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #19193   +/-   ##
=============================================
  Coverage              ?   79.09%           
=============================================
  Files                 ?     2027           
  Lines                 ?   113235           
  Branches              ?    34173           
=============================================
  Hits                  ?    89559           
  Misses                ?    23498           
  Partials              ?      178           
Flag Coverage Δ
unit 79.09% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/scripts/changeTracker.ts 80.05% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne removed the request for review from huang47 September 28, 2026 05:41

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — d41fd42a Deployed Sep 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants