Repository navigation
[backport cloud/1.54] perf: skip document-wide modal scans while typing - #19197
christian-byrne wants to merge 1 commit into
Conversation
- skip document-wide modal scans for native text-editing events while preserving modal handling for other inputs - honor store-backed auto-queue mode and cover native editor fast paths - measure composer typing during the workload, with two unmeasured type-and-clear warm-ups and named Playwright phases - close both frame-measurement boundaries and recover cleanly from page closure or bounded rAF timeouts This is the measured optimization following the original harness in [#19051](#19051) and the protocol-compliant warmed baseline in [#19159](#19159). - [Warmed baseline exact-head run](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36371643330): 46/46 localhost and 4/4 cloud performance tests passed; retained `perf-metrics` contains 49 measurements, including two samples for each agent-composer arm. - The current exact-head run compares the same 73-character workload after rebasing onto that warmed baseline. - The durable regression assertion verifies native contenteditable, input, and textarea events do not invoke the document-wide modal scan. - `pnpm vitest run src/scripts/changeTracker.test.ts` — 80 passed - `pnpm vitest run browser_tests/fixtures/helpers/PerformanceHelper.test.ts` — 2 passed - real Chromium immediate-block frame falsifier — 1 passed - `pnpm typecheck:browser` - focused formatting and lint checks - pre-push Knip and changed-file Fallow audit passed Backport targets: core/1.54, cloud/1.54, core/1.55, cloud/1.55. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Superseded by automated backport #19193, which landed after the prerequisite scrolling backport reached this release branch. |
Backports #19057 to
cloud/1.54after the automated cherry-pick conflicted.This preserves the release branch behavior while adding the editor hot-path guard, store-backed auto-queue handling, performance harness, and regression coverage. Release-specific compatibility uses the existing
Comfy.Agent.ThreadIdstorage key.Validation:
git diff --checkpasses