Repository navigation
[backport core/1.55] fix(agent): scroll restored conversation to latest - #19157
Conversation
## Summary Open restored Agent conversations at the true bottom instead of the top or slightly above the latest content. Reported in [Slack](https://comfy-organization.slack.com/archives/C0BDJAKKYR0/p1790395975068629). ## Root cause The transcript watcher ran only after subsequent entry changes and originally scrolled a bottom sentinel once. During hydration, Markdown and panel layout can continue growing after that callback; the strict browser regression reproduced a restored overflowing transcript that remained 28 px above its final bottom. ## Changes - Run follow-to-latest during initial hydration. - Scroll the transcript container directly to its current `scrollHeight`. - Re-follow while transcript content or viewport size changes and follow-latest intent is still active. - Clear follow-latest intent when a real user scroll moves away from the bottom, so later content and resize events do not yank the user down. - Expose a stable test ID for black-box scroll-position coverage. ## Regression proof - The cloud refresh-persistence test creates a genuinely overflowing restored transcript and requires exact `distanceFromBottom: 0`. - Component coverage verifies initial restored scrolling, streaming follow behavior, the jump-to-latest control, and the negative case where resize/content changes do not auto-follow after the user scrolls up. - Focused cloud Playwright: 1 passed. - `ConversationView` Vitest: 6 passed. - Browser and app typechecks, targeted lint, formatting, and diff check pass.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2125 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (9 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 45b2d0773cb1233d817e0ad58b9885ab1ca6177e
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-28T02:51:26.819Z",
"gitSha": "900ad7f26402f87927664d4a3521b51ea2e408ce",
"branch": "backport-19052-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.053000000018,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.434000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.18999999999994,
"heapDeltaBytes": 8055764,
"heapUsedBytes": 75646872,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.314000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 1990.191999999979,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.83,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 340.42699999999996,
"heapDeltaBytes": 9478216,
"heapUsedBytes": 77237740,
"domNodes": -257,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.391000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1740.8810000000017,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.376,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 777.482,
"heapDeltaBytes": 7602944,
"heapUsedBytes": 74936184,
"domNodes": -259,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 160.797,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1755.3009999999176,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.438,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 770.789,
"heapDeltaBytes": 10360648,
"heapUsedBytes": 77967740,
"domNodes": -260,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 159.166,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1716.9570000000363,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.400000000000002,
"layouts": 6,
"layoutDurationMs": 0.9199999999999999,
"taskDurationMs": 256.337,
"heapDeltaBytes": 3002840,
"heapUsedBytes": 70711488,
"domNodes": 78,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.534999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.0099999999684,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.06,
"layouts": 6,
"layoutDurationMs": 0.9249999999999999,
"taskDurationMs": 310.425,
"heapDeltaBytes": 3108584,
"heapUsedBytes": 70649236,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8.976999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 614.9939999999674,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.574999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.07800000000003,
"heapDeltaBytes": 18554680,
"heapUsedBytes": 86092712,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 163.52800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 640.0949999999739,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.373,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.69199999999995,
"heapDeltaBytes": 19018088,
"heapUsedBytes": 86494460,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 168.601,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1214.7339999999645,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 877.8800000000001,
"heapDeltaBytes": 9995780,
"heapUsedBytes": 100392196,
"domNodes": -295,
"jsHeapTotalBytes": 23482368,
"scriptDurationMs": 72.41300000000001,
"eventListeners": -195,
"totalBlockingTimeMs": 592,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1156.3200000000506,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 813.4379999999999,
"heapDeltaBytes": 38537096,
"heapUsedBytes": 106596384,
"domNodes": 0,
"jsHeapTotalBytes": 19820544,
"scriptDurationMs": 65.02799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 551,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 830.016999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.49799999999993,
"heapDeltaBytes": 14629892,
"heapUsedBytes": 91041320,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.271,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.9069999999874,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.40499999999986,
"heapDeltaBytes": 14917548,
"heapUsedBytes": 90269660,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.69300000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 233,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10271.113999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9347.224,
"heapDeltaBytes": 3165592,
"heapUsedBytes": 85014772,
"domNodes": -16,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7706.143,
"eventListeners": 0,
"totalBlockingTimeMs": 1097,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9239.113999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8410.337,
"heapDeltaBytes": -2250344,
"heapUsedBytes": 79899344,
"domNodes": -14,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7176.967000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 861,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10073.038999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9250.545,
"heapDeltaBytes": -12938792,
"heapUsedBytes": 68964388,
"domNodes": -16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7656.817,
"eventListeners": 0,
"totalBlockingTimeMs": 984,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10566.423999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9752.753,
"heapDeltaBytes": -9041732,
"heapUsedBytes": 73218536,
"domNodes": -16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8152.404,
"eventListeners": 0,
"totalBlockingTimeMs": 981,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2039.7279999999682,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.870000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.5309999999999,
"heapDeltaBytes": -5616892,
"heapUsedBytes": 81122756,
"domNodes": -242,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 31.744000000000007,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2023.8369999999577,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.095000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.895,
"heapDeltaBytes": -3592980,
"heapUsedBytes": 83469212,
"domNodes": -241,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 31.590000000000007,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2180.127999999968,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.636000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1595.187,
"heapDeltaBytes": -7385104,
"heapUsedBytes": 80329984,
"domNodes": -244,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 827.1279999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2258.7690000000293,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.376000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1614.4350000000002,
"heapDeltaBytes": -7252552,
"heapUsedBytes": 80599584,
"domNodes": -242,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 846.962,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3476.3429999999858,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.285000000000002,
"layouts": 60,
"layoutDurationMs": 12.648,
"taskDurationMs": 1669.2310000000002,
"heapDeltaBytes": -7649896,
"heapUsedBytes": 74409920,
"domNodes": -249,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 777.771,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3594.7589999999536,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.777999999999995,
"layouts": 60,
"layoutDurationMs": 12.638,
"taskDurationMs": 1709.8360000000002,
"heapDeltaBytes": 9655540,
"heapUsedBytes": 75834508,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 843.034,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 2835.088999999982,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.805999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1730.0850000000003,
"heapDeltaBytes": 22097244,
"heapUsedBytes": 87846440,
"domNodes": 8,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 990.767,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3114.967999999976,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.875000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1940.931,
"heapDeltaBytes": -9285828,
"heapUsedBytes": 81746176,
"domNodes": -227,
"jsHeapTotalBytes": 970752,
"scriptDurationMs": 1001.8620000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2025.890000000004,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.624999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.2560000000001,
"heapDeltaBytes": -4885484,
"heapUsedBytes": 84093840,
"domNodes": -248,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 35.069,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.8600000000279,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.357000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.7080000000001,
"heapDeltaBytes": -7532296,
"heapUsedBytes": 81398620,
"domNodes": -247,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 30.236,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 557.5240000000008,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.338,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.71000000000004,
"heapDeltaBytes": 13810312,
"heapUsedBytes": 83509380,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 143.85,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.9329999999163,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.628,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.12899999999996,
"heapDeltaBytes": 13422348,
"heapUsedBytes": 83603452,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 148.107,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1999.1549999999734,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.119999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.319,
"heapDeltaBytes": -5574116,
"heapUsedBytes": 64573968,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 6.178000000000003,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.0539999999492,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.921000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.187,
"heapDeltaBytes": 9669144,
"heapUsedBytes": 79644492,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.528000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.2460000000115,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.384000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 704.1809999999999,
"heapDeltaBytes": -5671808,
"heapUsedBytes": 64325096,
"domNodes": -273,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 100.464,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.8750000000055,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.309000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 697.577,
"heapDeltaBytes": 4277096,
"heapUsedBytes": 74141188,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 101.282,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.0300000000761,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.526999999999997,
"layouts": 5,
"layoutDurationMs": 12.998,
"taskDurationMs": 871.8919999999999,
"heapDeltaBytes": -6240548,
"heapUsedBytes": 80923984,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 29.761999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 136,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8308.774999999969,
"styleRecalcs": 251,
"styleRecalcDurationMs": 36.879,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5710.181,
"heapDeltaBytes": 20805856,
"heapUsedBytes": 84352200,
"domNodes": -240,
"jsHeapTotalBytes": 192512,
"scriptDurationMs": 2815.248,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8405.358999999975,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.734,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5708.151,
"heapDeltaBytes": 1102284,
"heapUsedBytes": 80734292,
"domNodes": -219,
"jsHeapTotalBytes": 2019328,
"scriptDurationMs": 2832.381,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16720.590999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16246.811000000002,
"heapDeltaBytes": -53081480,
"heapUsedBytes": 184965232,
"domNodes": -8061,
"jsHeapTotalBytes": -15663104,
"scriptDurationMs": 255.301,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16230.539999999906,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15291.430999999999,
"heapDeltaBytes": -61282684,
"heapUsedBytes": 176724844,
"domNodes": -8061,
"jsHeapTotalBytes": -16711680,
"scriptDurationMs": 229.49499999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20421.099999999966,
"styleRecalcs": 167,
"styleRecalcDurationMs": 16.930999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20096.325,
"heapDeltaBytes": -54092568,
"heapUsedBytes": 180793540,
"domNodes": -8061,
"jsHeapTotalBytes": -13492224,
"scriptDurationMs": 871.199,
"eventListeners": -14928,
"totalBlockingTimeMs": 36,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 19614.500000000022,
"styleRecalcs": 158,
"styleRecalcDurationMs": 15.622999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19247.335,
"heapDeltaBytes": -57061392,
"heapUsedBytes": 180812676,
"domNodes": -8061,
"jsHeapTotalBytes": -15925248,
"scriptDurationMs": 880.93,
"eventListeners": -14928,
"totalBlockingTimeMs": 59,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6062.520000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.21700000000004,
"layouts": 20,
"layoutDurationMs": 22.128999999999994,
"taskDurationMs": 5989.415999999999,
"heapDeltaBytes": -62353460,
"heapUsedBytes": 175854752,
"domNodes": -8060,
"jsHeapTotalBytes": 14745600,
"scriptDurationMs": 111.376,
"eventListeners": -14928,
"totalBlockingTimeMs": 381,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4426.009000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.36599999999999,
"layouts": 20,
"layoutDurationMs": 22.00400000000001,
"taskDurationMs": 4336.150000000001,
"heapDeltaBytes": -34291192,
"heapUsedBytes": 191488588,
"domNodes": -8062,
"jsHeapTotalBytes": 8642560,
"scriptDurationMs": 83.10000000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 33,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6246.90099999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5855.167000000001,
"heapDeltaBytes": -19075224,
"heapUsedBytes": 169935304,
"domNodes": 0,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 97.42000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8464.188000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8191.875999999998,
"heapDeltaBytes": -24818960,
"heapUsedBytes": 171752624,
"domNodes": 0,
"jsHeapTotalBytes": -25427968,
"scriptDurationMs": 150.532,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 115.56000000007316,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.105,
"layouts": 3,
"layoutDurationMs": 1.7139999999999997,
"taskDurationMs": 90.32100000000001,
"heapDeltaBytes": 3114344,
"heapUsedBytes": 65103228,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.861,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 450.5020000000286,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.344999999999995,
"layouts": 3,
"layoutDurationMs": 1.529,
"taskDurationMs": 109.385,
"heapDeltaBytes": 4793788,
"heapUsedBytes": 70443968,
"domNodes": 119,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 10.206,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 5 |
| 🟢 Low | 3 |
Panel: 8/8 reviewers contributed findings.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.55 #19157 +/- ##
=============================================
- Coverage 84.65% 84.62% -0.03%
=============================================
Files 2302 2301 -1
Lines 131898 132215 +317
Branches 35624 33819 -1805
=============================================
+ Hits 111657 111889 +232
- Misses 19922 20007 +85
Partials 319 319
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 22 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 10 prior finding(s) across 1 round(s) (9 never answered).
Every reviewer in the matrix failed to contribute — see the panel summary for which cells errored, and the run logs for the underlying cause.
Panel: 0/8 reviewers contributed findings.
Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (error), gemini-3.1-pro:adversarial (error), gpt-5.6-sol-max:adversarial (error), kimi-k3-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error), gemini-3.1-pro:edge-case (error), gpt-5.6-sol-max:edge-case (error), kimi-k3-max:edge-case (error)
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 3 — ledger: 10 prior finding(s) across 1 round(s) (9 never answered).
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 4 |
| 🟢 Low | 3 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 4 — ledger: 20 prior finding(s) across 2 round(s) (18 never answered).
Found 8 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 1 |
| 🟢 Low | 5 |
Panel: 8/8 reviewers contributed findings.
Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment)
Addresses #19155 (comment) Addresses #19155 (comment) Addresses #19157 (comment)
Addresses #19155 (comment) Addresses #19155 (comment) Addresses #19157 (comment)
Addresses #19155 (comment) Addresses #19155 (comment) Addresses #19157 (comment)
Addresses #19155 (comment) Addresses #19155 (comment) Addresses #19157 (comment)
Addresses #19155 (comment) Addresses #19155 (comment) Addresses #19157 (comment)
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment)
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
Backports #19052 to
core/1.55, including the runtime fix, component regressions, and refresh-persistence browser coverage.