Repository navigation
[backport cloud/1.55] fix(agent): scroll restored conversation to latest - #19156
Conversation
## Summary Open restored Agent conversations at the true bottom instead of the top or slightly above the latest content. Reported in [Slack](https://comfy-organization.slack.com/archives/C0BDJAKKYR0/p1790395975068629). ## Root cause The transcript watcher ran only after subsequent entry changes and originally scrolled a bottom sentinel once. During hydration, Markdown and panel layout can continue growing after that callback; the strict browser regression reproduced a restored overflowing transcript that remained 28 px above its final bottom. ## Changes - Run follow-to-latest during initial hydration. - Scroll the transcript container directly to its current `scrollHeight`. - Re-follow while transcript content or viewport size changes and follow-latest intent is still active. - Clear follow-latest intent when a real user scroll moves away from the bottom, so later content and resize events do not yank the user down. - Expose a stable test ID for black-box scroll-position coverage. ## Regression proof - The cloud refresh-persistence test creates a genuinely overflowing restored transcript and requires exact `distanceFromBottom: 0`. - Component coverage verifies initial restored scrolling, streaming follow behavior, the jump-to-latest control, and the negative case where resize/content changes do not auto-follow after the user scrolls up. - Focused cloud Playwright: 1 passed. - `ConversationView` Vitest: 6 passed. - Browser and app typechecks, targeted lint, formatting, and diff check pass.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2119 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (9 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0da750cd15b5e5faf3e4d289e6412ca74c7c678d
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-28T02:52:53.165Z",
"gitSha": "459f0bad6f7e1c3106f2685423d0aa2ba8fe2569",
"branch": "backport-19052-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1992.0999999999935,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.921999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.667,
"heapDeltaBytes": -4883204,
"heapUsedBytes": 57620276,
"domNodes": -262,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.444,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2015.2689999999893,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.678000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.02599999999995,
"heapDeltaBytes": 4646636,
"heapUsedBytes": 72363584,
"domNodes": -262,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.945,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.421000000018,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.814000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 863.1739999999999,
"heapDeltaBytes": 9155452,
"heapUsedBytes": 76837384,
"domNodes": -259,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 175.82399999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1720.9829999999329,
"styleRecalcs": 44,
"styleRecalcDurationMs": 13.852,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 793.142,
"heapDeltaBytes": 11138392,
"heapUsedBytes": 78712856,
"domNodes": -261,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 160.893,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1681.714999999997,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.101,
"layouts": 6,
"layoutDurationMs": 1.1219999999999997,
"taskDurationMs": 329.466,
"heapDeltaBytes": 3037596,
"heapUsedBytes": 70862796,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.174,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.2060000000047,
"styleRecalcs": 33,
"styleRecalcDurationMs": 14.606,
"layouts": 6,
"layoutDurationMs": 1.112,
"taskDurationMs": 325.848,
"heapDeltaBytes": 3129088,
"heapUsedBytes": 70806608,
"domNodes": 80,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.422999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 637.3289999999656,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.302000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.16200000000003,
"heapDeltaBytes": 18960892,
"heapUsedBytes": 86425268,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 165.906,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 633.4400000000642,
"styleRecalcs": 14,
"styleRecalcDurationMs": 10.247000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.024,
"heapDeltaBytes": 18582080,
"heapUsedBytes": 86104576,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 174.88899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1190.5320000000188,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 850.664,
"heapDeltaBytes": 38281904,
"heapUsedBytes": 104619516,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 73.833,
"eventListeners": 0,
"totalBlockingTimeMs": 581,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1230.2290000000085,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 917.447,
"heapDeltaBytes": -16734348,
"heapUsedBytes": 72673008,
"domNodes": -295,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 74.325,
"eventListeners": -195,
"totalBlockingTimeMs": 573,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.0409999999806,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.2860000000002,
"heapDeltaBytes": 14929496,
"heapUsedBytes": 89909004,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 158.134,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.9290000000692,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.5509999999998,
"heapDeltaBytes": 14787036,
"heapUsedBytes": 90337516,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.004,
"eventListeners": 0,
"totalBlockingTimeMs": 233,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11150.78699999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10242.146,
"heapDeltaBytes": 14181192,
"heapUsedBytes": 96087304,
"domNodes": -14,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 8535.609,
"eventListeners": 0,
"totalBlockingTimeMs": 1596,
"frameDurationMs": 18.89333333333343,
"p95FrameDurationMs": 49.89999999999782
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10742.688999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9721.002999999999,
"heapDeltaBytes": -11848392,
"heapUsedBytes": 70592576,
"domNodes": -16,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 8330.466,
"eventListeners": 0,
"totalBlockingTimeMs": 1532,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10084.546000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9299.63,
"heapDeltaBytes": 9501576,
"heapUsedBytes": 91416720,
"domNodes": -14,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 7636.085,
"eventListeners": 0,
"totalBlockingTimeMs": 979,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10888.967999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10058.394,
"heapDeltaBytes": 11707140,
"heapUsedBytes": 93893120,
"domNodes": -12,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8349.885,
"eventListeners": 0,
"totalBlockingTimeMs": 1294,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2018.4059999999704,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.232999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.075,
"heapDeltaBytes": 19718432,
"heapUsedBytes": 83280780,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 41.128,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2028.3029999999371,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.356000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.05500000000006,
"heapDeltaBytes": -3600224,
"heapUsedBytes": 83284180,
"domNodes": -240,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 33.797000000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2275.956000000008,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1655.789,
"heapDeltaBytes": -3156308,
"heapUsedBytes": 84535672,
"domNodes": -242,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 862.459,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2278.6760000000186,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.522999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1640.126,
"heapDeltaBytes": -7731552,
"heapUsedBytes": 80042280,
"domNodes": -247,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 844.6260000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3524.8640000000364,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.827999999999998,
"layouts": 60,
"layoutDurationMs": 13.037,
"taskDurationMs": 1668.2540000000001,
"heapDeltaBytes": 8439812,
"heapUsedBytes": 74218488,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 783.184,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3558.8189999999713,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.985,
"layouts": 60,
"layoutDurationMs": 12.839,
"taskDurationMs": 1716.5499999999997,
"heapDeltaBytes": 10011772,
"heapUsedBytes": 75438352,
"domNodes": -252,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 812.035,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3118.815999999981,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.842999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1959.046,
"heapDeltaBytes": 12608,
"heapUsedBytes": 90808648,
"domNodes": -248,
"jsHeapTotalBytes": -77824,
"scriptDurationMs": 992.838,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3103.915000000029,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.717999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1957.4569999999999,
"heapDeltaBytes": 563232,
"heapUsedBytes": 91174284,
"domNodes": -255,
"jsHeapTotalBytes": 446464,
"scriptDurationMs": 993.011,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2015.9530000000245,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.3149999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.849,
"heapDeltaBytes": -4703560,
"heapUsedBytes": 84177592,
"domNodes": -250,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 30.851000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2006.7890000000261,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.5790000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 521.298,
"heapDeltaBytes": 20140356,
"heapUsedBytes": 84443476,
"domNodes": -254,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.428,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.4980000000055,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.934,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.53400000000005,
"heapDeltaBytes": 13766160,
"heapUsedBytes": 83673052,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 142.187,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 562.5509999999849,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.531999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.24899999999997,
"heapDeltaBytes": 13695344,
"heapUsedBytes": 83594796,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 145.93099999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.8150000000037,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.657000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.593,
"heapDeltaBytes": -14178632,
"heapUsedBytes": 55927660,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.303999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2003.007000000025,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.747000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.63399999999996,
"heapDeltaBytes": -13930596,
"heapUsedBytes": 55961564,
"domNodes": -275,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.8709999999999996,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.5840000000308,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.235,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 728.4269999999999,
"heapDeltaBytes": -7771384,
"heapUsedBytes": 62116768,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 105.323,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.6459999999597,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.924,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 657.9119999999999,
"heapDeltaBytes": -1857668,
"heapUsedBytes": 68100620,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 107.409,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 933.1859999999779,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.528999999999993,
"layouts": 5,
"layoutDurationMs": 13.444,
"taskDurationMs": 703.2400000000001,
"heapDeltaBytes": -6250344,
"heapUsedBytes": 81514148,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 26.467000000000006,
"eventListeners": 2383,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8408.128999999974,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.701,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5803.044,
"heapDeltaBytes": -17845764,
"heapUsedBytes": 69131428,
"domNodes": -217,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 2816.319,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8320.176000000061,
"styleRecalcs": 251,
"styleRecalcDurationMs": 36.446,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5794.173,
"heapDeltaBytes": -6443224,
"heapUsedBytes": 80426296,
"domNodes": -239,
"jsHeapTotalBytes": 1531904,
"scriptDurationMs": 2792.117,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 16816.06400000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16378.104000000001,
"heapDeltaBytes": -63987716,
"heapUsedBytes": 177458924,
"domNodes": -8061,
"jsHeapTotalBytes": -18026496,
"scriptDurationMs": 252.91600000000003,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16994.55899999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16646.17,
"heapDeltaBytes": -70775028,
"heapUsedBytes": 170335820,
"domNodes": -8061,
"jsHeapTotalBytes": -17465344,
"scriptDurationMs": 291.034,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20365.018000000022,
"styleRecalcs": 163,
"styleRecalcDurationMs": 16.10000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20023.951,
"heapDeltaBytes": -38172916,
"heapUsedBytes": 180422672,
"domNodes": -8061,
"jsHeapTotalBytes": -18882560,
"scriptDurationMs": 907.905,
"eventListeners": -14928,
"totalBlockingTimeMs": 45,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20281.28400000003,
"styleRecalcs": 149,
"styleRecalcDurationMs": 16.026999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20098.961,
"heapDeltaBytes": -33976216,
"heapUsedBytes": 191619296,
"domNodes": -8061,
"jsHeapTotalBytes": -18427904,
"scriptDurationMs": 885.807,
"eventListeners": -14928,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6059.830000000034,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.372,
"layouts": 20,
"layoutDurationMs": 23.137000000000004,
"taskDurationMs": 5988.172,
"heapDeltaBytes": -42617480,
"heapUsedBytes": 183172396,
"domNodes": -8061,
"jsHeapTotalBytes": 16506880,
"scriptDurationMs": 108.269,
"eventListeners": -14928,
"totalBlockingTimeMs": 367,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6172.223000000031,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.63699999999999,
"layouts": 20,
"layoutDurationMs": 24.522000000000002,
"taskDurationMs": 6086.960999999999,
"heapDeltaBytes": -48243380,
"heapUsedBytes": 193171636,
"domNodes": -8061,
"jsHeapTotalBytes": 8253440,
"scriptDurationMs": 113.82100000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 513,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8388.126000000057,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8143.636,
"heapDeltaBytes": 4137232,
"heapUsedBytes": 195722088,
"domNodes": 0,
"jsHeapTotalBytes": -27787264,
"scriptDurationMs": 148.208,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8610.220000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8389.247000000001,
"heapDeltaBytes": 95832,
"heapUsedBytes": 190549172,
"domNodes": 0,
"jsHeapTotalBytes": -9175040,
"scriptDurationMs": 131.89000000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 114.88699999995333,
"styleRecalcs": 8,
"styleRecalcDurationMs": 19.82,
"layouts": 3,
"layoutDurationMs": 1.716,
"taskDurationMs": 95.053,
"heapDeltaBytes": 3338196,
"heapUsedBytes": 68630716,
"domNodes": 135,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.425999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 100.84200000005694,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.916,
"layouts": 2,
"layoutDurationMs": 1.056,
"taskDurationMs": 72.774,
"heapDeltaBytes": 2999468,
"heapUsedBytes": 68601616,
"domNodes": 126,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.401000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 9 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 4 |
| 🟢 Low | 3 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 9 prior finding(s) across 1 round(s) (9 never answered).
Every reviewer in the matrix failed to contribute — see the panel summary for which cells errored, and the run logs for the underlying cause.
Panel: 0/8 reviewers contributed findings.
Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (error), gemini-3.1-pro:adversarial (error), gpt-5.6-sol-max:adversarial (error), kimi-k3-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error), gemini-3.1-pro:edge-case (error), gpt-5.6-sol-max:edge-case (error), kimi-k3-max:edge-case (error)
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #19156 +/- ##
=============================================
Coverage ? 80.59%
=============================================
Files ? 2198
Lines ? 117575
Branches ? 33520
=============================================
Hits ? 94756
Misses ? 22473
Partials ? 346
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 3 — ledger: 9 prior finding(s) across 1 round(s) (9 never answered).
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 4 |
| 🟢 Low | 3 |
| ⚪ Nit | 2 |
Panel: 8/8 reviewers contributed findings.
Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment)
Addresses #19155 (comment) Addresses #19155 (comment) Addresses #19157 (comment)
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 4 — ledger: 19 prior finding(s) across 2 round(s) (19 never answered).
Found 9 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 4 |
| 🟢 Low | 4 |
Panel: 8/8 reviewers contributed findings.
Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment) Addresses #19160 (comment)
Backports #19052 to
cloud/1.55, including the runtime fix, component regressions, and refresh-persistence browser coverage.