Skip to content

FE-3048 fix(billing-web): return to the host by closing the checkout tab - #19106

Merged
dante01yoon merged 14 commits into
jaewon/checkout-3ds-failure-copyfrom
jaewon/billing-web-return-close-tab
Sep 29, 2026
Merged

dante01yoon merged 14 commits into
jaewon/checkout-3ds-failure-copyfrom
jaewon/billing-web-return-close-tab

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Sep 27, 2026 •

Copy link
Copy Markdown
Collaborator
  • Linear: FE-3048

Why

Close / "Return to ComfyUI" on billing-web navigated the billing tab to <host>/?billing_result=success&billing_ref=…. The customer ended with two product tabs, the outcome query in the URL, and no confirmation in the tab they came from. The embedded checkout's Close just returns to the app in place.

Root cause

billing-web treated "return to the host" as a navigation. The host opens billing-web in a tab of its own (openHostedBillingTab), so the host's tab is still there. The way back is to close the billing tab. The app also never removed billing_result/billing_ref from its URL.

How

AS IS / TO BE

Live (testcloud)

Live (testcloud) recordings of the whole stack (stack top f02bdd6, embedded vs billing-web, AS IS and TO BE videos and per-step screenshots) are in #19101 under "Live (testcloud) AS IS / TO BE".

TO BE live (f02bdd6): Change plan in the local app (ff:hosted_billing_destination="billing_web", workspace m2-qa-0927-full) opens billing-web on :5174 in a new tab. Pay → "You're all set" → Close. The billing tab closes, the app tab is back in front with a clean URL, and its account menu shows 294,054 credits (147,700 before) with no Resubscribe.

tobe-billing-web-upgrade-success-close-tab-refresh.mp4

After Close, embedded (left) | billing-web (right):

live-after-close

Harness

billing-web e2e harness (mocked Cloud). The checkout tab is opened with window.open from another billing-web tab, which stands in for the product tab. The subscribe succeeds, then Close is clicked. The captions give each open tab's URL afterwards.

AS IS (#19105): the billing tab navigates to the host with billing_result/billing_ref, so there are two tabs.

G-asis

TO BE: the billing tab closes and only the original tab remains.

G-tobe

Stack

PR branch base title
#19097 jaewon/billing-web-remove-plan-grid main FE-3045 refactor(billing-web): drop the billing-web plan grid; hosts own plan selection
A #19098 jaewon/design-system-button-variants #19097 FE-3046 refactor(design-system): move buttonVariants into @comfyorg/design-system
B #19099 jaewon/account-ui-checkout-surfaces A FE-3046 feat(account-ui): shared checkout confirm, saved-method selector, card form and success
C #19100 jaewon/workspace-adopt-account-ui-checkout B FE-3046 refactor(workspace): render the subscription checkout steps from account-ui
D #19101 jaewon/billing-web-shared-checkout C FE-3046 feat(billing-web): render the shared embedded checkout
E #19104 jaewon/billing-web-success-invite D FE-3046 feat(billing-web): invite your team from the checkout success step
F #19105 jaewon/checkout-3ds-failure-copy E FE-3047 fix(account-ui): clear decline toasts once a retry succeeds
G (this PR) jaewon/billing-web-return-close-tab F FE-3048 fix(billing-web): return to the host by closing the checkout tab
H #19115 jaewon/checkout-cta-reachable G FE-3050 fix(account-ui): keep the checkout CTA reachable when notices grow the confirm step
graph LR
  P0[#19097: remove plan grid] --> A[A: design-system buttonVariants]
  A --> B[B: account-ui checkout surfaces]
  B --> C[C: workspace adopts account-ui]
  C --> D[D: billing-web shared checkout]
  D --> E[E: billing-web success invite]
  E --> F[F: stale decline toasts]
  F --> G[G: close the billing tab]
  G --> H[H: reachable checkout CTA]
  style G fill:#f9d71c,stroke:#333,color:#000
Loading

Red first: Back/Close on billing-web navigate the billing tab to the product
instead of closing it, and the app leaves billing_result/billing_ref in the
address bar.
@dante01yoon dante01yoon added the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Sep 27, 2026
@dante01yoon
dante01yoon requested a review from a team as a code owner September 27, 2026 16:56
@dante01yoon dante01yoon added core/1.55 Backport PRs for core 1.55 cloud/1.55 Backport PRs for cloud 1.55 needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch labels Sep 27, 2026
@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/29/2026, 04:49:34 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap
canvas-mouse-sweep: · 59.7 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 92.7 MB heap
dom-widget-order-dense-n200-w200-i120: · 30.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 476ms TBT · 79.9 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 42.9 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 156ms TBT · 76.0 MB heap
extension-clean-combined-draw: · 33.2 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 135ms TBT · 71.7 MB heap
extension-rgthree-prototype-draw: · 35.7 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 137ms TBT · 74.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.1 MB heap
legacy-node-drag: · 59.7 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.9 MB heap
subgraph-mouse-sweep: · 59.7 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.5 MB heap
subgraph-transition-enter: · 50.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 119ms TBT · 90.8 MB heap
viewport-pan-sweep: · 59.9 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.5 MB heap
vue-large-graph-idle: · 38.5 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 177.8 MB heap
vue-large-graph-pan: · 30.3 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 13ms TBT · 169.0 MB heap
vue-node-resize-workload: · 32.9 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 202ms TBT · 196.9 MB heap
vue-zoom-out-idle: · 38.6 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 174.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.5 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.6 MB heap
agent-composer-long-conversation-typing: · 59.6 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 109.8 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 439ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 68.6 MB
canvas-idle: DOM nodes -228
canvas-idle: event listeners -153
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 17ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 772ms
canvas-mouse-sweep: script duration 141ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 71.8 MB
canvas-mouse-sweep: DOM nodes -228
canvas-mouse-sweep: event listeners -164
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 10ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 318ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 77.6 MB
canvas-zoom-sweep: DOM nodes 53
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 407ms
dom-widget-clipping: script duration 145ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 92.7 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 33ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 747ms
dom-widget-order-dense-n200-w200-i120: script duration 56ms
dom-widget-order-dense-n200-w200-i120: TBT 476ms
dom-widget-order-dense-n200-w200-i120: heap used 79.9 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 23ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 391ms
dom-widget-order-sparse-n1000-w20-i120: script duration 125ms
dom-widget-order-sparse-n1000-w20-i120: TBT 156ms
dom-widget-order-sparse-n1000-w20-i120: heap used 76.0 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 30ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 7340ms
extension-clean-combined-draw: script duration 5814ms
extension-clean-combined-draw: TBT 135ms
extension-clean-combined-draw: heap used 71.7 MB
extension-clean-combined-draw: DOM nodes 0
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 28ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 7242ms
extension-rgthree-prototype-draw: script duration 5632ms
extension-rgthree-prototype-draw: TBT 137ms
extension-rgthree-prototype-draw: heap used 74.6 MB
extension-rgthree-prototype-draw: DOM nodes 0
extension-rgthree-prototype-draw: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 547ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.3 MB
large-graph-idle: DOM nodes -228
large-graph-idle: event listeners -153
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1465ms
large-graph-pan: script duration 717ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 78.4 MB
large-graph-pan: DOM nodes -114
large-graph-pan: event listeners -71
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 16ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1565ms
large-graph-zoom: script duration 692ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 73.1 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 1784ms
legacy-node-drag: script duration 880ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 85.7 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 431ms
minimap-idle: script duration 31ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.4 MB
minimap-idle: DOM nodes 0
minimap-idle: event listeners 0
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 6ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 351ms
subgraph-dom-widget-clipping: script duration 130ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 89.7 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 4ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 424ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.9 MB
subgraph-idle: DOM nodes -244
subgraph-idle: event listeners -188
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 16ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 73
subgraph-mouse-sweep: task duration 690ms
subgraph-mouse-sweep: script duration 94ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 71.5 MB
subgraph-mouse-sweep: DOM nodes -244
subgraph-mouse-sweep: event listeners -210
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 24ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 823ms
subgraph-transition-enter: script duration 26ms
subgraph-transition-enter: TBT 119ms
subgraph-transition-enter: heap used 90.8 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 5219ms
viewport-pan-sweep: script duration 2401ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 77.5 MB
viewport-pan-sweep: DOM nodes -228
viewport-pan-sweep: event listeners -153
vue-large-graph-idle: avg frame time 26ms
vue-large-graph-idle: p95 frame time 50ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 13940ms
vue-large-graph-idle: script duration 229ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 177.8 MB
vue-large-graph-idle: DOM nodes -4025
vue-large-graph-idle: event listeners -7462
vue-large-graph-pan: avg frame time 33ms
vue-large-graph-pan: p95 frame time 67ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 129
vue-large-graph-pan: task duration 17061ms
vue-large-graph-pan: script duration 843ms
vue-large-graph-pan: TBT 13ms
vue-large-graph-pan: heap used 169.0 MB
vue-large-graph-pan: DOM nodes -1523
vue-large-graph-pan: event listeners -7458
vue-node-resize-workload: avg frame time 30ms
vue-node-resize-workload: p95 frame time 67ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 69ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5123ms
vue-node-resize-workload: script duration 98ms
vue-node-resize-workload: TBT 202ms
vue-node-resize-workload: heap used 196.9 MB
vue-node-resize-workload: DOM nodes -4025
vue-node-resize-workload: event listeners -7462
vue-zoom-out-idle: avg frame time 26ms
vue-zoom-out-idle: p95 frame time 50ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6954ms
vue-zoom-out-idle: script duration 136ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 174.9 MB
vue-zoom-out-idle: DOM nodes -1523
vue-zoom-out-idle: event listeners -7458
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 4
workflow-execution: style recalc count 15
workflow-execution: task duration 111ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 77.5 MB
workflow-execution: DOM nodes 113
workflow-execution: event listeners 57
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 18ms
agent-composer-empty-conversation-typing: style recalc duration 96ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 78
agent-composer-empty-conversation-typing: task duration 647ms
agent-composer-empty-conversation-typing: script duration 242ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 80.6 MB
agent-composer-empty-conversation-typing: DOM nodes 76
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 22ms
agent-composer-long-conversation-typing: style recalc duration 240ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 78
agent-composer-long-conversation-typing: task duration 1198ms
agent-composer-long-conversation-typing: script duration 382ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 109.8 MB
agent-composer-long-conversation-typing: DOM nodes 76
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-09-29T04:07:30.406Z",
  "gitSha": "7e41f97fc2c0fe3a60597222cf9f01f6121e20fa",
  "branch": "jaewon/billing-web-return-close-tab",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2033.407000000011,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.2050000000000014,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 445.226,
      "heapDeltaBytes": -4848,
      "heapUsedBytes": 79216776,
      "domNodes": -228,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 10.083000000000002,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2024.5120000000725,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.333000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 432.66799999999995,
      "heapDeltaBytes": -33566952,
      "heapUsedBytes": 64555444,
      "domNodes": -228,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 10.395000000000001,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1782.5579999999945,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 16.54,
      "layouts": 12,
      "layoutDurationMs": 4.138,
      "taskDurationMs": 761.0570000000001,
      "heapDeltaBytes": -2602496,
      "heapUsedBytes": 77018940,
      "domNodes": -228,
      "jsHeapTotalBytes": -262144,
      "scriptDurationMs": 134.80999999999997,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66635514018692,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1784.6040000000585,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 17.579,
      "layouts": 12,
      "layoutDurationMs": 4.461,
      "taskDurationMs": 783.4689999999999,
      "heapDeltaBytes": -5995144,
      "heapUsedBytes": 73557992,
      "domNodes": -228,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 146.54,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.82358490566038,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1733.884000000046,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 10.436,
      "layouts": 6,
      "layoutDurationMs": 1.4889999999999999,
      "taskDurationMs": 322.404,
      "heapDeltaBytes": 1504872,
      "heapUsedBytes": 80934264,
      "domNodes": 53,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 13.162999999999998,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1734.2100000000755,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 9.252,
      "layouts": 6,
      "layoutDurationMs": 1.3539999999999996,
      "taskDurationMs": 313.195,
      "heapDeltaBytes": 1808500,
      "heapUsedBytes": 81736808,
      "domNodes": 53,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 11.693000000000001,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 610.5329999999753,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 3.2709999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 402.236,
      "heapDeltaBytes": -1693036,
      "heapUsedBytes": 97048412,
      "domNodes": 0,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 143.30599999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 640.2279999999791,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 3.436999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 412.538,
      "heapDeltaBytes": 18003116,
      "heapUsedBytes": 97458308,
      "domNodes": 0,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 146.812,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665789473684214,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1104.5009999999706,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 754.02,
      "heapDeltaBytes": 6371408,
      "heapUsedBytes": 82364704,
      "domNodes": 0,
      "jsHeapTotalBytes": 4620288,
      "scriptDurationMs": 55.276999999999994,
      "eventListeners": 0,
      "totalBlockingTimeMs": 475,
      "frameDurationMs": 33.333333333333336,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1094.9729999999818,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 740.289,
      "heapDeltaBytes": 9444256,
      "heapUsedBytes": 85233840,
      "domNodes": 0,
      "jsHeapTotalBytes": 4882432,
      "scriptDurationMs": 57.13799999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 476,
      "frameDurationMs": 33.333333333333336,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 794.715999999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 398.7799999999999,
      "heapDeltaBytes": 15829008,
      "heapUsedBytes": 90692308,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 126.75200000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 162,
      "frameDurationMs": 23.529411764705856,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 780.448999999976,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 383.71299999999974,
      "heapDeltaBytes": -17810512,
      "heapUsedBytes": 68588900,
      "domNodes": 0,
      "jsHeapTotalBytes": 528384,
      "scriptDurationMs": 123.832,
      "eventListeners": 0,
      "totalBlockingTimeMs": 150,
      "frameDurationMs": 23.04117647058825,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 8498.167999999965,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7101.5199999999995,
      "heapDeltaBytes": -10703384,
      "heapUsedBytes": 70365544,
      "domNodes": 0,
      "jsHeapTotalBytes": -13369344,
      "scriptDurationMs": 5735.409,
      "eventListeners": 0,
      "totalBlockingTimeMs": 195,
      "frameDurationMs": 32.195454545454545,
      "p95FrameDurationMs": 50.099999999999454
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 8477.133999999978,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7579.116,
      "heapDeltaBytes": -1795216,
      "heapUsedBytes": 80077812,
      "domNodes": 0,
      "jsHeapTotalBytes": -7602176,
      "scriptDurationMs": 5892.735,
      "eventListeners": 0,
      "totalBlockingTimeMs": 75,
      "frameDurationMs": 27.996699669966997,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 8512.606000000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7597.727999999999,
      "heapDeltaBytes": -7918784,
      "heapUsedBytes": 72497700,
      "domNodes": 0,
      "jsHeapTotalBytes": -3407872,
      "scriptDurationMs": 5955.183,
      "eventListeners": 0,
      "totalBlockingTimeMs": 218,
      "frameDurationMs": 28.42675585284281,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 7608.654000000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6885.716,
      "heapDeltaBytes": 3499596,
      "heapUsedBytes": 83927828,
      "domNodes": 0,
      "jsHeapTotalBytes": -15728640,
      "scriptDurationMs": 5309.156,
      "eventListeners": 0,
      "totalBlockingTimeMs": 55,
      "frameDurationMs": 27.635272727272728,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2047.7329999999938,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.907999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 540.9069999999999,
      "heapDeltaBytes": -36994328,
      "heapUsedBytes": 82910268,
      "domNodes": -228,
      "jsHeapTotalBytes": -884736,
      "scriptDurationMs": 34.480999999999995,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2075.07099999998,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 3.0300000000000016,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 553.486,
      "heapDeltaBytes": -36841852,
      "heapUsedBytes": 83418956,
      "domNodes": -228,
      "jsHeapTotalBytes": -98304,
      "scriptDurationMs": 34.053,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66612903225806,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2217.8839999999695,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 10.097,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1429.404,
      "heapDeltaBytes": 18641052,
      "heapUsedBytes": 81864624,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 703.213,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2237.235000000055,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 10.866999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1500.5700000000002,
      "heapDeltaBytes": 20348104,
      "heapUsedBytes": 82504916,
      "domNodes": -228,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 730.059,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66616541353383,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3581.2629999999785,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 12.229000000000001,
      "layouts": 60,
      "layoutDurationMs": 15.520999999999999,
      "taskDurationMs": 1545.6120000000003,
      "heapDeltaBytes": 12573132,
      "heapUsedBytes": 76710740,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 684.2080000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66604651162791,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3664.4400000000132,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 12.632000000000001,
      "layouts": 60,
      "layoutDurationMs": 15.73,
      "taskDurationMs": 1584.4650000000001,
      "heapDeltaBytes": 12603164,
      "heapUsedBytes": 76682428,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 699.576,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666210045662098,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3093.765000000019,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 6.317999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1763.109,
      "heapDeltaBytes": 23752104,
      "heapUsedBytes": 88420268,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 853.484,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.756521739130434,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3078.6520000000337,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 6.085,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1805.8389999999997,
      "heapDeltaBytes": 26746504,
      "heapUsedBytes": 91281004,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 907.062,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.75737704918033,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2017.6820000000362,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 1.930000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 400.607,
      "heapDeltaBytes": 20547968,
      "heapUsedBytes": 84358940,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 32.41100000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2020.552000000066,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 1.0770000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 462.12399999999997,
      "heapDeltaBytes": 20616696,
      "heapUsedBytes": 84267092,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 29.68199999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760327,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 549.4060000000331,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 6.345,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 343.15799999999996,
      "heapDeltaBytes": 12429764,
      "heapUsedBytes": 93847544,
      "domNodes": 0,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 133.135,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 577.7870000000576,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 5.736999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 359.42400000000004,
      "heapDeltaBytes": 12621620,
      "heapUsedBytes": 94174628,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 126.80199999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66571428571429,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2026.3180000000034,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.458000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 430.59499999999997,
      "heapDeltaBytes": -18147220,
      "heapUsedBytes": 62795912,
      "domNodes": -244,
      "jsHeapTotalBytes": -262144,
      "scriptDurationMs": 8.316,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2025.466999999935,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 3.590999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 418.38699999999994,
      "heapDeltaBytes": -16054956,
      "heapUsedBytes": 64982620,
      "domNodes": -244,
      "jsHeapTotalBytes": -262144,
      "scriptDurationMs": 8.581999999999999,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1728.8540000000125,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 15.831999999999999,
      "layouts": 16,
      "layoutDurationMs": 5.401,
      "taskDurationMs": 643.47,
      "heapDeltaBytes": -4226220,
      "heapUsedBytes": 77109480,
      "domNodes": -244,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 91.99799999999999,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384614,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1739.3220000000156,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 16.485,
      "layouts": 16,
      "layoutDurationMs": 5.28,
      "taskDurationMs": 736.7130000000001,
      "heapDeltaBytes": -8877792,
      "heapUsedBytes": 72758440,
      "domNodes": -244,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 95.775,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.82815533980583,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1001.9239999999172,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 24.181,
      "layouts": 5,
      "layoutDurationMs": 9.747000000000002,
      "taskDurationMs": 823.3709999999999,
      "heapDeltaBytes": 21397736,
      "heapUsedBytes": 95213304,
      "domNodes": 13667,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 25.619999999999997,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 119,
      "frameDurationMs": 19.93333333333334,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8374.821999999995,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.769000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5289.846,
      "heapDeltaBytes": -39526340,
      "heapUsedBytes": 79819296,
      "domNodes": -228,
      "jsHeapTotalBytes": 94208,
      "scriptDurationMs": 2429.0000000000005,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665868263473055,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8313.758000000007,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 35.494,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5147.659999999999,
      "heapDeltaBytes": -36937704,
      "heapUsedBytes": 82625204,
      "domNodes": -228,
      "jsHeapTotalBytes": 389120,
      "scriptDurationMs": 2372.6929999999998,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.699397590361446,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14380.72599999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13968.692000000001,
      "heapDeltaBytes": -47094272,
      "heapUsedBytes": 187049700,
      "domNodes": -8050,
      "jsHeapTotalBytes": -15466496,
      "scriptDurationMs": 233.763,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 26.18937728937729,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14466.297000000053,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13911.664999999999,
      "heapDeltaBytes": 6485300,
      "heapUsedBytes": 185761492,
      "domNodes": 0,
      "jsHeapTotalBytes": -17825792,
      "scriptDurationMs": 223.685,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 25.71085409252669,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17268.763000000035,
      "styleRecalcs": 136,
      "styleRecalcDurationMs": 17.630000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17033.949,
      "heapDeltaBytes": 15517912,
      "heapUsedBytes": 188862056,
      "domNodes": 0,
      "jsHeapTotalBytes": -32051200,
      "scriptDurationMs": 827.12,
      "eventListeners": 0,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 33.045315487571706,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17272.223999999936,
      "styleRecalcs": 122,
      "styleRecalcDurationMs": 17.462000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17088.101,
      "heapDeltaBytes": -38623644,
      "heapUsedBytes": 165592524,
      "domNodes": -3045,
      "jsHeapTotalBytes": 6074368,
      "scriptDurationMs": 858.414,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 21,
      "frameDurationMs": 32.9192380952381,
      "p95FrameDurationMs": 66.69999999999891
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5262.207999999987,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 70.56600000000002,
      "layouts": 20,
      "layoutDurationMs": 24.536,
      "taskDurationMs": 5202.086,
      "heapDeltaBytes": 99960,
      "heapUsedBytes": 222139788,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 104.004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 217,
      "frameDurationMs": 31.077647058823533,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5159.633999999983,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 67.58099999999997,
      "layouts": 20,
      "layoutDurationMs": 23.94600000000001,
      "taskDurationMs": 5043.997,
      "heapDeltaBytes": 4077664,
      "heapUsedBytes": 190880996,
      "domNodes": -8049,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 92.60799999999999,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 187,
      "frameDurationMs": 29.692528735632184,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7300.457999999991,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6840.308,
      "heapDeltaBytes": 26749432,
      "heapUsedBytes": 186617384,
      "domNodes": 0,
      "jsHeapTotalBytes": -23068672,
      "scriptDurationMs": 112.83800000000005,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 25.434494773519166,
      "p95FrameDurationMs": 49.900000000001455
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7278.7530000000515,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7066.783000000001,
      "heapDeltaBytes": -22460196,
      "heapUsedBytes": 180256432,
      "domNodes": -3045,
      "jsHeapTotalBytes": 4501504,
      "scriptDurationMs": 159.242,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 26.35306859205776,
      "p95FrameDurationMs": 50
    },
    {
      "name": "workflow-execution",
      "durationMs": 493.05199999992055,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 15.782,
      "layouts": 4,
      "layoutDurationMs": 2.0509999999999997,
      "taskDurationMs": 138.543,
      "heapDeltaBytes": -14195324,
      "heapUsedBytes": 82454596,
      "domNodes": 131,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 10.823,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.668965517241368,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 117.12899999997717,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 9.647999999999998,
      "layouts": 3,
      "layoutDurationMs": 0.9970000000000001,
      "taskDurationMs": 83.91499999999999,
      "heapDeltaBytes": -16752092,
      "heapUsedBytes": 80141332,
      "domNodes": 94,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 6.136999999999999,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 700.6430000000137,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 96.071,
      "layouts": 76,
      "layoutDurationMs": 17.724,
      "taskDurationMs": 648.9469999999999,
      "heapDeltaBytes": 15982972,
      "heapUsedBytes": 83746996,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 245.15,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 694.2680000000792,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 95.616,
      "layouts": 76,
      "layoutDurationMs": 18.439,
      "taskDurationMs": 644.892,
      "heapDeltaBytes": 16157508,
      "heapUsedBytes": 85275948,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 239.646,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66428571428573,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1270.5529999999499,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 243.922,
      "layouts": 76,
      "layoutDurationMs": 22.321,
      "taskDurationMs": 1242.613,
      "heapDeltaBytes": 8776020,
      "heapUsedBytes": 115631252,
      "domNodes": 76,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 399.446,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.881818181818176,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1175.1350000000684,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 237.017,
      "layouts": 76,
      "layoutDurationMs": 21.991,
      "taskDurationMs": 1153.349,
      "heapDeltaBytes": 7858500,
      "heapUsedBytes": 114580440,
      "domNodes": 76,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 364.89,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665753424657538,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52946 80626 65.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1151
src/LGraphNode.ts 70.2% 388
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.1% 330
src/LGraph.ts 78.9% 269
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/app.ts 73.1% 252
src/core/webSessionIdentity.ts 3.4% 224

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 0439551224a718233131c2ea346a8f4e8b7e6a73

Full docs: ADR-DEVEX-LINT-0015

🎭 Playwright: ✅ 2159 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2138 / ❌ 0 / ⚠️ 0 / ⏭️ 9)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 39709675-5da8-4e6d-b19f-aa58b85920a4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 27, 2026
Back, Close and "Return to ComfyUI" navigated the billing tab to the
product, so the customer ended with two product tabs and billing_result in
the URL. The product opens billing in its own tab, so billing-web now closes
itself and falls back to the product's URL only for a tab it could not close
(one opened directly). The product already refreshes billing on return, and
now also strips billing_result/billing_ref from its URL on load.
@codecov

codecov Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/billing-web/src/views/CheckoutView.vue 0.00% 0 Missing and 1 partial ⚠️
@@                        Coverage Diff                        @@
##           jaewon/checkout-3ds-failure-copy   #19106   +/-   ##
=================================================================
  Coverage                             84.23%   84.23%           
=================================================================
  Files                                  3239     3240    +1     
  Lines                                157168   157175    +7     
  Branches                              40893    40900    +7     
=================================================================
+ Hits                                 132386   132398   +12     
+ Misses                                23065    23060    -5     
  Partials                               1717     1717           
Flag Coverage Δ
billing-web-unit 87.08% <75.00%> (+0.03%) ⬆️
unit 81.52% <100.00%> (+<0.01%) ⬆️
website-unit 78.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/billing-web/src/components/HostedSurface.vue 96.15% <100.00%> (+0.15%) ⬆️
apps/billing-web/src/entry/returnToHost.ts 100.00% <100.00%> (ø)
.../src/billing/checkout/CheckoutSubscribeConfirm.vue 100.00% <ø> (ø)
...ccount-ui/src/billing/checkout/CheckoutSuccess.vue 97.05% <100.00%> (ø)
...src/billing/checkout/CheckoutTransitionConfirm.vue 90.20% <100.00%> (ø)
src/composables/useUrlActionLoaders.ts 100.00% <ø> (ø)
...tform/cloud/subscription/utils/paymentReturnUrl.ts 100.00% <100.00%> (ø)
apps/billing-web/src/views/CheckoutView.vue 83.49% <0.00%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

zeus-onl pushed a commit to zeus-onl/ComfyUI_frontend that referenced this pull request Sep 28, 2026
…illing tab (Comfy-Org#19123)

- Linear: FE-3054

## Why

After paying on billing-web and pressing Close, the customer lands back
on the app tab, which must show the new plan and credits the way the
embedded checkout does. In the M2 live QA (local stack top against
testcloud) a Team upgrade 295.4K → 527.5K on billing-web left the app
tab at 295,394 credits until a reload (527,468 after reload). The
embedded checkout updates in place.

## Root cause

`registerRefreshOnReturn`
(`src/platform/workspace/billing/refreshOnReturn.ts`) re-reads status,
balance and capabilities on the first `focus` or visible
`visibilitychange`, then removes its listeners. Any return to the app
tab before the hosted payment finishes (the customer glances back while
3DS loads, or the browser refocuses the tab) spends that single refresh,
so the return after the payment reads nothing. The Stripe portal return
in `useWorkspaceBilling` shares the helper and the same gap.

## How

- The listener stays armed and refreshes on every return until its stop
callback runs (the next hosted open re-arms it, and scope dispose stops
it).
- The `focus` and `visibilitychange` that one return fires together are
coalesced: a return while a refresh is in flight does not start a second
one.
- Tests: the old "is one-shot" case is replaced by "refreshes again on a
later return" and "coalesces one return". Both fail on main.
- CI: red
https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36351321273
(the two new tests fail), green
https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36351874480.

## AS IS / TO BE

Environment: local build of stack top + this PR against testcloud,
Stripe test mode.

**AS IS:** after paying on billing-web and closing the tab, the app kept
295,394 credits until a reload. The app tab had been refocused mid-flow,
which spent the one-shot refresh.


https://github.com/user-attachments/assets/7bb0e7d7-9b89-42e9-8521-330996622f7d

**TO BE:** same glance back at the app tab mid-flow, then cancel on
billing-web; the app updates on return without a reload ("Your
subscription has been canceled", ends on Sep 27, 2027).


https://github.com/user-attachments/assets/f7b025c1-7d4e-4da9-933e-20dbff4530e6

## Plan position

M2 (billing-web checkout in a new tab). Off `main`, independent of the
FE-3046 parity stack (Comfy-Org#19097 → Comfy-Org#19098 → Comfy-Org#19099 → Comfy-Org#19100 → Comfy-Org#19101 →
Comfy-Org#19104 → Comfy-Org#19105 → Comfy-Org#19106 → Comfy-Org#19115); it fixes the host side FE-2618
added.

```mermaid
graph LR
  S[FE-3046 stack Comfy-Org#19097..Comfy-Org#19115] --> Q[M2 live QA]
  R[FE-3054 refresh on every return]:::me --> Q
  classDef me fill:#f9d71c,stroke:Comfy-Org#333,color:#000
```
VoXoXoX pushed a commit to VoXoXoX/ComfyUI_frontend that referenced this pull request Sep 28, 2026
…esign-system (Comfy-Org#19098)

- Linear: FE-3046

**Merge order:** Comfy-Org#19096 (ADR 0034 amendment) merges first. Until it
does, ADR 0034 rule 4 still forbids account-ui from using the design
system, which B does.

## Why

`buttonVariants` lived in `src/components/ui/button/button.variants.ts`,
inside the private root package, so a workspace package could not render
a button with the app's exact classes. PR B (`@comfyorg/account-ui`
checkout surfaces) needs those classes to render the embedded checkout
identically in the cloud app and in billing-web. No visual change.

## How

- `git mv` of `button.variants.ts` into `packages/design-system/src/`,
content unchanged.
- `packages/design-system/package.json`: new export `./button.variants`,
a `files` entry, and `cva` (`catalog:`) as a dependency.
- Every importer in `src/` (Button.vue, Button.stories.ts,
CloudSocialAuthButtons.vue, InlinePromptEditor.vue, and the ten
components that import the `ButtonVariants` type) now reads from
`@comfyorg/design-system/button.variants`. The old path is deleted, no
re-export shim. `apps/website` keeps its own copy.

## Review Focus

The file content is byte-identical (rename only). The only decision is
the entry name `./button.variants`, mirroring `./workspaceAvatar`.

## Stack

| PR | branch | base | title |
|---|---|---|---|
| Comfy-Org#19097 | `jaewon/billing-web-remove-plan-grid` | `main` | `FE-3045
refactor(billing-web): drop the billing-web plan grid; hosts own plan
selection` |
| **A Comfy-Org#19098 (this PR)** | **`jaewon/design-system-button-variants`** |
**Comfy-Org#19097** | **`FE-3046 refactor(design-system): move buttonVariants
into @comfyorg/design-system`** |
| B Comfy-Org#19099 | `jaewon/account-ui-checkout-surfaces` | A | `FE-3046
feat(account-ui): shared checkout confirm, saved-method selector, card
form and success` |
| C Comfy-Org#19100 | `jaewon/workspace-adopt-account-ui-checkout` | B | `FE-3046
refactor(workspace): render the subscription checkout steps from
account-ui` |
| D Comfy-Org#19101 | `jaewon/billing-web-shared-checkout` | C | `FE-3046
feat(billing-web): render the shared embedded checkout` |
| E Comfy-Org#19104 | `jaewon/billing-web-success-invite` | D | `FE-3046
feat(billing-web): invite your team from the checkout success step` |
| F Comfy-Org#19105 | `jaewon/checkout-3ds-failure-copy` | E | `FE-3047
fix(account-ui): clear decline toasts once a retry succeeds` |
| G Comfy-Org#19106 | `jaewon/billing-web-return-close-tab` | F | `FE-3048
fix(billing-web): return to the host by closing the checkout tab` |
| H Comfy-Org#19115 | `jaewon/checkout-cta-reachable` | G | `FE-3050
fix(account-ui): keep the checkout CTA reachable when notices grow the
confirm step` |

```mermaid
graph LR
  P0[Comfy-Org#19097: remove plan grid] --> A[A: design-system buttonVariants]
  A --> B[B: account-ui checkout surfaces]
  B --> C[C: workspace adopts account-ui]
  C --> D[D: billing-web shared checkout]
  D --> E[E: billing-web success invite]
  E --> F[F: stale decline toasts]
  F --> G[G: close the billing tab]
  G --> H[H: reachable checkout CTA]
  style A fill:#f9d71c,stroke:Comfy-Org#333,color:#000
```

## AS IS / TO BE

Rename only, no rendered change, so no screenshots.

| AS IS | TO BE |
| --- | --- |
| `@/components/ui/button/button.variants` |
`@comfyorg/design-system/button.variants` |

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 28, 2026
…tor, card form and success (Comfy-Org#19099)

- Linear: FE-3046

**Merge order:** Comfy-Org#19096 (ADR 0034 amendment) merges first. Until it
does, ADR 0034 rule 4 still forbids account-ui from using the design
system, which B does.

## Why

billing-web is the cloud app's embedded checkout moved to a new tab,
with no UX change (ADR BILLING-WEB-0038, Comfy-Org#19096). Today billing-web
renders a checkout of its own (`EmbeddedCheckout`, `CheckoutPayment`,
`CheckoutSubmit`) that has drifted from the app's: different price
layout, no saved-card selection, different copy. For both to render the
same screens, the app's confirm, price breakdown, saved-card selector,
card form, terms notice and success step have to live where both can
import them. This PR adds them to `@comfyorg/account-ui`. Nothing
renders them yet, so no visual change.

## How

- New entry `@comfyorg/account-ui/billing/checkout`, ported line for
line from the app components. Same markup, same classes, same
conditions:
- `CheckoutSubscribeConfirm` ←
`SubscriptionAddPaymentPreviewWorkspace.vue` (plan header, credits,
total due, discounts, promo code, saved methods, card form, 3DS prompt,
parked-checkout recovery, terms).
- `CheckoutTransitionConfirm` ←
`SubscriptionTransitionPreviewWorkspace.vue` (immediate vs scheduled
change, reactivation banner and threshold checkbox).
- `CheckoutSavedMethods` + `CheckoutSavedMethodSelect` ← the
saved-method row / `SingleSelect` picker (Reka select with the app's
select classes).
- `CheckoutPaymentForm` ← `UnifiedStripePaymentSelector.vue` minus the
app bindings (key, theme and telemetry become props and a `phase`
event).
- `CheckoutSuccess` ← `SubscriptionSuccessWorkspace.vue`, with
`details`/`actions` slots for the app's team invite.
- `CheckoutTermsNote`, `CheckoutPromotionCode`,
`CheckoutPaymentNotices`, `CheckoutVerificationPrompt`: blocks both
confirms repeated. `CheckoutSubscribeSummary`/`CheckoutSubscribeActions`
and `CheckoutReactivationBanner`/`CheckoutTransitionSummary` split the
two confirm templates under the fallow complexity gate; the rendered
markup is the same.
- `checkoutQuote.ts`: the app's `subscriptionQuoteFormatting.ts` +
`planDuration.ts`.
- `@comfyorg/account-ui/billing/catalog` (TS-only entry): the tiers'
prices and monthly credit grants (the numbers in the app's
`TIER_PRICING`). The app's confirm reads the grant from this table
(`TIER_PRICING`), not from the quote's `new_plan.credits_cents`, so
billing-web reads the same table to show the same number; C points the
app at it. A separate entry so non-Vue consumers (the Playwright runner
imports `tierPricing`) never load the components.
- The package has no i18n runtime. Hosts pass a typed `CheckoutCopy`;
interpolated strings are functions, and sentences that wrap an element
(terms links, reactivation amount) keep `{token}`s that the component
splits.
- Hosts pass a resolved `CheckoutPlan` (name, monthly/yearly price,
credits, `pricedByQuote`) instead of the package reading the tier
catalog.
- `selectVariants` moves to `@comfyorg/design-system/select.variants`
(same move as `buttonVariants` in Comfy-Org#19098), so the picker renders the
app's select classes.
- Packaging: `design-system` variants and `tailwind-utils`'s `cn` are
bundled into the published build (dev dependencies). `tailwind-utils` is
not on npm and `design-system` ships TS source, so neither can be a
runtime dependency of a published package. `reka-ui` is a peer. The
rendered classes need the design-system theme and primeicons at runtime,
so `@comfyorg/design-system` and `primeicons` are peers too, and the
package description says to load their CSS and add the package's dist to
the consumer's Tailwind sources. The smoke test imports the new entry in
the typed consumer and treats it as bundler-only, like `billing/stripe`.

### Reactivation renewal date (live testcloud recording)

The reactivation notice and the summary could name different renewal
days for the same quote. On `m2-qa-0925-3ds` the notice said "renew … on
Oct 27" and the summary "Renews … on Oct 25, 2026".
- **Summary:** reads `renewal_at ?? new_plan.period_end`
(`resolveRenewalDate`).
- **Notice:** read `new_plan.period_end` only. When that was absent, it
computed `effective_at` + one period on the client (Sep 27 + 1 month =
Oct 27).
- **Not a server inconsistency:** the server sent one renewal date,
`renewal_at`, which the contract defines as "the next recurring charge
and target-plan period end".
- **Fix:** the notice now reads the same server date as the summary
(`resolveRenewalDate`: `renewal_at`, else the plan's server
`period_end`). The client-side computation is gone. With no server date,
the notice drops its renewal clause through new
`reactivation.withoutRenewalDate` copy, the way the summary drops its
date.
- **Contract:** `renewal_at` is optional in `PreviewSubscribeResponse`
("Optional in the schema for older clients"; "current servers always
return this"). The server should always send it; the client no longer
computes one when it doesn't.
- **Tests:**
  - A new test fails on the old code (Oct 27 vs Oct 25).
- The tests that pinned the client computation (account-ui and the app's
`SubscriptionTransitionPreviewWorkspaceReactivation.test.ts`, in C) are
replaced by a no-renewal-date test.
  - C adds the app's `withoutRenewalDate` strings.

## Review Focus

- The ports are meant to be verbatim. C (the next PR) swaps the app onto
these components and the app's existing component tests (about 2,100
lines across the two confirms and the success step) pass with only stub
names changed. That is the parity check.
- `CheckoutPlan.pricedByQuote` reproduces the app's price rules exactly,
including the odd ones: a tier plan shows the quote's price once one
arrives and `$0` on the success step without one; a team credit stop
always shows its own price.

## Stack

| PR | branch | base | title |
|---|---|---|---|
| Comfy-Org#19097 | `jaewon/billing-web-remove-plan-grid` | `main` | `FE-3045
refactor(billing-web): drop the billing-web plan grid; hosts own plan
selection` |
| A Comfy-Org#19098 | `jaewon/design-system-button-variants` | Comfy-Org#19097 | `FE-3046
refactor(design-system): move buttonVariants into
@comfyorg/design-system` |
| **B (this PR)** | **`jaewon/account-ui-checkout-surfaces`** | **A** |
**`FE-3046 feat(account-ui): shared checkout confirm, saved-method
selector, card form and success`** |
| C Comfy-Org#19100 | `jaewon/workspace-adopt-account-ui-checkout` | B | `FE-3046
refactor(workspace): render the subscription checkout steps from
account-ui` |
| D Comfy-Org#19101 | `jaewon/billing-web-shared-checkout` | C | `FE-3046
feat(billing-web): render the shared embedded checkout` |
| E Comfy-Org#19104 | `jaewon/billing-web-success-invite` | D | `FE-3046
feat(billing-web): invite your team from the checkout success step` |
| F Comfy-Org#19105 | `jaewon/checkout-3ds-failure-copy` | E | `FE-3047
fix(account-ui): clear decline toasts once a retry succeeds` |
| G Comfy-Org#19106 | `jaewon/billing-web-return-close-tab` | F | `FE-3048
fix(billing-web): return to the host by closing the checkout tab` |
| H Comfy-Org#19115 | `jaewon/checkout-cta-reachable` | G | `FE-3050
fix(account-ui): keep the checkout CTA reachable when notices grow the
confirm step` |

```mermaid
graph LR
  P0[Comfy-Org#19097: remove plan grid] --> A[A: design-system buttonVariants]
  A --> B[B: account-ui checkout surfaces]
  B --> C[C: workspace adopts account-ui]
  C --> D[D: billing-web shared checkout]
  D --> E[E: billing-web success invite]
  E --> F[F: stale decline toasts]
  F --> G[G: close the billing tab]
  G --> H[H: reachable checkout CTA]
  style B fill:#f9d71c,stroke:Comfy-Org#333,color:#000
```

## AS IS / TO BE

No rendered change: nothing renders these components in this PR. The
parity screenshots are on C (Comfy-Org#19100, app before/after, pixel-identical)
and D (Comfy-Org#19101, billing-web before/after next to the app).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ksanislo pushed a commit to ksanislo/ComfyUI_frontend that referenced this pull request Sep 29, 2026
…rom account-ui (Comfy-Org#19100)

- Linear: FE-3046

## Why

Comfy-Org#19099 moved the app's checkout steps into `@comfyorg/account-ui`. Until
the app renders those components, the package holds a second copy that
nothing keeps in step. This PR makes the app render them, so the app and
(in D) billing-web share one implementation. No visual change in the
app.

## How

- `SubscriptionAddPaymentPreviewWorkspace.vue`,
`SubscriptionTransitionPreviewWorkspace.vue` and
`SubscriptionSuccessWorkspace.vue` keep their props and events, so their
parents are untouched. Each now renders `CheckoutSubscribeConfirm`,
`CheckoutTransitionConfirm` or `CheckoutSuccess` and binds what only the
app knows:
- copy from vue-i18n (`useCheckoutCopy`), including the `CheckoutPlan`
built from the tier catalog or the team credit stop,
- the Stripe publishable key, the colour-palette theme key and
checkout-journey telemetry (previously in
`UnifiedStripePaymentSelector.vue`),
- subscription status from `useBillingContext` (loaded, cancelled, end
date) for the reactivation banner,
- the team invite block and Send invites action through
`CheckoutSuccess`'s slots.
- Deleted, now in the package: `UnifiedStripePaymentSelector.vue`,
`SubscriptionTermsNote.vue`, `subscriptionQuoteFormatting.ts` and
`planDuration.ts` (plus their tests, which the package's
`checkoutQuote.test.ts` and component tests cover).
`useSubscriptionCheckout` imports `amountDueTodayChanged` from the
package.
- `TIER_PRICING` spreads the shared `TIER_CATALOG` (same numbers) and
keeps its app-only `videoEstimate`.
- `UnifiedStripePaymentSelector.test.ts` becomes
`SubscriptionAddPaymentPreviewWorkspace.stripe.test.ts`: the same key,
copy, theme and telemetry assertions against the binding.

## Review Focus

Parity evidence: the existing component tests for the three steps
(`SubscriptionAddPaymentPreviewWorkspace.test.ts`,
`SubscriptionTransitionPreviewWorkspace*.test.ts`,
`SubscriptionSuccessWorkspace.test.ts`) pass unchanged, apart from
renaming the stubbed children (`UnifiedStripePaymentSelector` →
`CheckoutPaymentForm`, `SingleSelect` → `CheckoutSavedMethodSelect`,
`SubscriptionTermsNote` → `CheckoutTermsNote`).

## Stack

| PR | branch | base | title |
|---|---|---|---|
| Comfy-Org#19097 | `jaewon/billing-web-remove-plan-grid` | `main` | `FE-3045
refactor(billing-web): drop the billing-web plan grid; hosts own plan
selection` |
| A Comfy-Org#19098 | `jaewon/design-system-button-variants` | Comfy-Org#19097 | `FE-3046
refactor(design-system): move buttonVariants into
@comfyorg/design-system` |
| B Comfy-Org#19099 | `jaewon/account-ui-checkout-surfaces` | A | `FE-3046
feat(account-ui): shared checkout confirm, saved-method selector, card
form and success` |
| **C (this PR)** | **`jaewon/workspace-adopt-account-ui-checkout`** |
**B** | **`FE-3046 refactor(workspace): render the subscription checkout
steps from account-ui`** |
| D Comfy-Org#19101 | `jaewon/billing-web-shared-checkout` | C | `FE-3046
feat(billing-web): render the shared embedded checkout` |
| E Comfy-Org#19104 | `jaewon/billing-web-success-invite` | D | `FE-3046
feat(billing-web): invite your team from the checkout success step` |
| F Comfy-Org#19105 | `jaewon/checkout-3ds-failure-copy` | E | `FE-3047
fix(account-ui): clear decline toasts once a retry succeeds` |
| G Comfy-Org#19106 | `jaewon/billing-web-return-close-tab` | F | `FE-3048
fix(billing-web): return to the host by closing the checkout tab` |
| H Comfy-Org#19115 | `jaewon/checkout-cta-reachable` | G | `FE-3050
fix(account-ui): keep the checkout CTA reachable when notices grow the
confirm step` |

```mermaid
graph LR
  P0[Comfy-Org#19097: remove plan grid] --> A[A: design-system buttonVariants]
  A --> B[B: account-ui checkout surfaces]
  B --> C[C: workspace adopts account-ui]
  C --> D[D: billing-web shared checkout]
  D --> E[E: billing-web success invite]
  E --> F[F: stale decline toasts]
  F --> G[G: close the billing tab]
  G --> H[H: reachable checkout CTA]
  style C fill:#f9d71c,stroke:Comfy-Org#333,color:#000
```

## AS IS / TO BE

Each image: **left = AS IS** (app on Comfy-Org#19099, old components), **right =
TO BE** (this PR). Rendered in Storybook (a temporary story, not
committed) with the app components' real props, the checkout dialog's
frame classes, dark theme, 1440x900, and a fake `js.stripe.com` (the
same fake billing-web's e2e uses), so the card element area is blank in
both. Not against a live backend. AS IS and TO BE are pixel-identical
for all four steps (PIL diff: no differing pixels).

**Confirm + card entry (new subscription, no saved method)**

<img width="1448" alt="card"
src="https://github.com/user-attachments/assets/c00c89fb-1eaa-46bd-b335-9bf51e09fff1"
/>

**Confirm + saved-card selector (two saved cards)**

<img width="1448" alt="saved"
src="https://github.com/user-attachments/assets/d2db71b9-2e7f-4e99-bd89-45624e771ce5"
/>

**Plan change (upgrade, no card form)**

<img width="1448" alt="change"
src="https://github.com/user-attachments/assets/740beba9-fbb0-41ac-a2a6-9bb3815665da"
/>

**Success**

<img width="1448" alt="success"
src="https://github.com/user-attachments/assets/42a18550-21fa-41b7-8e7d-c2ebc7349520"
/>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…' into HEAD

# Conflicts:
#	apps/billing-web/src/components/HostedSurface.vue
christian-byrne pushed a commit to christian-byrne/ComfyUI_frontend that referenced this pull request Sep 29, 2026
…-Org#19101)

- Linear: FE-3046

## Why

billing-web is the cloud app's embedded checkout moved to a new tab,
with no UX change (ADR BILLING-WEB-0038, Comfy-Org#19096). Its checkout was a
separate implementation (`EmbeddedCheckout`, `CheckoutPayment`,
`CheckoutSubmit`) with its own layout and copy, no saved-card selection
and no promo code. With the app now rendering
`@comfyorg/account-ui/billing/checkout` (Comfy-Org#19100), billing-web can render
the same steps.

## How

- `CheckoutView.vue` renders the shared steps inside
`CheckoutFrame.vue`, which reproduces the app's checkout dialog box (the
dialog content class from `useSubscriptionDialog` and the embedded-step
classes from `SubscriptionRequiredDialogContentUnified`):
- `new_subscription` quote → `CheckoutSubscribeConfirm` with the card
form, the saved methods from `usePaymentMethods` (default preselected;
Change / Add new payment method swap in the card form) and the promo
code.
- any other transition → `CheckoutTransitionConfirm`, single column, no
card form: the server charges the method on file (the Comfy-Org#18684 rule, now
through the same component as the app). A reactivation the quote or the
server demands shows the app's banner and threshold checkbox.
- success → `CheckoutSuccess` (plan card, credits per month); Close
returns to the product with the outcome.
- Through the payment it behaves like the app: the confirm stays with
the pay button busy and a processing (or "verify your payment") toast; a
verification that fails in the tab shows the confirm's inline notice; a
decline, timeout or refused subscribe shows the app's error toast with
its detail copy and leaves the confirm, and a card already typed, in
place. `CheckoutToast.vue` is that toast.
- Subscribe carries `saved_payment_method_id` for a saved method and
`promotion_code` for an applied promo, next to the existing token, quote
identity, proration and return URL.
- Plan: tier name and monthly credits from
`@comfyorg/account-ui/billing/catalog` (Comfy-Org#19099). A team stop's price and
credits come from the `/billing/plans` stop the link names, through the
same catalog functions as the app's slider and confirm.
- Copy: billing-web's `checkout.*` keys are replaced with the app's
English strings, key for key.
- Page environment: the frame applies what the app's page applies around
the dialog — its dark palette's `--interface-stroke`, `color-scheme:
dark`, and browser defaults for inputs, the select trigger and links
(the app has no Tailwind preflight). `styles.css` sources all of
account-ui's billing components (the Stripe form's layout classes were
missing); `primeicons` and `reka-ui` are added.
- Tests: `CheckoutView.test.ts` rewritten against the shared components
(saved method, Change, promo, reactivation, decline/3DS outcomes, Comfy-Org#18684
cases kept); `e2e/checkout.spec.ts` updated plus a saved-method e2e.
billing-web e2e 29/29 locally.

### billing-web-only UI deleted

- `EmbeddedCheckout`'s split card layout (5/12 summary sidebar, its own
card, muted `h1`, lucide back arrow and close X).
- Plan title `{tier} · {duration}` ("Pro · Monthly"), hero `$28.00` with
"USD per month"/"USD per year", "{amount} billed yearly", "Starting
today".
- "Credits refill every month" showing `credits_cents` as dollars
("$211.00" for 21,100 credits).
- The terms line "By subscribing, you agree to recurring charges until
cancellation." (no links).
- `CheckoutSubmit`'s pay button and its reactivation checkbox on the
card form ("Your subscription was cancelled. I confirm the {amount}
charge to reactivate it."); reactivation now uses the app's banner on
the plan-change confirm.
- Its own Stripe copy ("Choose how you would like to pay.", "The payment
form isn't available right now…", its Alipay note, "Something went
wrong. Please try again.").
- The inline failure paragraph above the pay button.
- The `CheckoutSteps` panel that replaced the checkout while paying and
after a failure ("Review payment", "Payment declined", "Payment could
not be processed", Try again / Use a different payment method / Contact
support).
- The success panel (tinted check circle, "Your plan was updated. A
receipt was sent to your email.", plan line, "Return to {product}" link
button).

### billing-web-only UI kept

- The way back to the host: Close (the dialog's X and the success step's
Close) leaves for the product's return URL instead of closing a dialog.
- "Loading…" while the quote loads, and the quote-refused panel with
Back (the app never opens the confirm without a quote).
- `CheckoutToast`, standing in for the app's toast host (outside the
checkout panel).

### Not closed here (see Review Focus)

- Team plan success: the app's "Invite your team" step lands in E
(Comfy-Org#19104).
- Stripe Payment/Address Element options differ in the live recording
(Google Pay and a full address on billing-web vs card/Alipay/US bank and
name-only in the app). Both hosts now render the same
`StripePaymentForm` with the same options; what remains comes from the
server's `payment_method_configuration_id` and Stripe's per-domain
wallet registration, which need a live backend check.

### Shared with the app, so the hosts can't drift (review fixes)

- **Decline copy:** `declineDetailKey(reason)` in account-core is one
exhaustive switch over the contract's `BillingDeclineReason`. The app's
SDK rail (`topupOperationView.declineDetail`) and billing-web both call
it. Before this, billing-web had its own list that omitted `generic`. A
reason-less decline (account-core defaults it to `generic`) therefore
read "We couldn't update your subscription." on billing-web and "Your
bank declined this payment." in the app. The list also carried 15
strings outside the enum.
- **Processing vs verify toast:** superseded below. The app's rule is
`awaitsHostedAction`, now shared, not `awaitsVerification`.
- **Team hero price:** `mapApiTeamCreditStops` and
`getStopDiscountedMonthlyUsd` move from the app into
`@comfyorg/account-ui/billing/catalog`. The app's pricing table, credit
slider and subscription dialog import them from there, and billing-web's
`teamCheckoutPlan` prices the stop with them instead of `price_cents /
months`.
- Tests: table tests for `declineDetailKey` (all 8 reasons) and
`awaitsVerification`, the moved stop tests, billing-web decline rows for
`generic` / `incorrect_cvc` / `processing_error`, and team
monthly/annual stop prices. The e2e that pinned the old reason-less copy
now expects the app's decline copy.
- Harness: new step P6a2, the server declines with no `decline_reason`.
Rerun on D: 0% copy/element difference on every step except P7T, whose
team invite is E. Rerun on G (top of stack): 0% on all 15 steps.

### Toasts and success frame (live testcloud recording)

- **Why a replica:** billing-web's toast is a measured replica of the
app's PrimeVue Aura toast, because AGENTS.md forbids new PrimeVue usage.
The parity harness compares every toast (size, colors, fonts, icon,
close button, each part's position) and fails on drift.
- **Assistive tech:** every toast is `role="alert"`,
`aria-live="assertive"`, `aria-atomic="true"`, as PrimeVue renders the
app's. The harness compares these too.
- **Anchor:** toasts sit top-right. The app anchors its message toasts
to the graph canvas panel, which billing-web does not have.
- **End date:** the reactivation notice's "set to end on" date now comes
from the billing status's `cancel_at`, the field the app reads, instead
of the quote's `current_plan.period_end`. Harness step P2e gives the two
server values different dates; both hosts show `cancel_at` (Oct 25 vs
the quote's Oct 27).

- **Toast:** `CheckoutToast` was a look-alike: neutral, no close button,
one at a time. It now renders the app's dark Aura PrimeVue toast.
- Styling: the severity tint, 36% border and shadow, `blur(10px)`, and a
28px close button.
- Layout: the two hosts the app uses. The operation toast is a spinner
or prompt beside one line; the message toast is a severity icon, summary
and detail.
- The numbers come from the app's computed styles, captured by the
harness. It is not PrimeVue itself, because AGENTS.md rules out new
PrimeVue use in billing-web.
- **Lifetimes match the app:**
- The progress toast stays while the payment is pending. A closed one
stays closed until the operation's state changes.
  - Errors stay until closed.
- "Subscription updated successfully" shows for 5 s after a subscribe
the server charged for, like the app's SDK rail (`requiredPayment`). A
plan the server activated on the spot gets none.
- **Prompt vs spinner:** the app shows the "Verify your payment" prompt
only when a hosted action page is waiting. An in-page 3DS challenge
keeps the spinner. `awaitsVerification` (adopted in review) also counted
the challenge, and the harness showed it disagreed with the app. The
app's rule is now `awaitsHostedAction` in account-core, used by the
app's `billingSdkStore` and by billing-web.
- **Success frame:** the app pins the success frame only after a new
subscription. After a plan change it uses the dialog's content-sized
box. `CheckoutFrame` gets that `fit` step, so the blank band above "Send
invites" is gone.
- **Harness:** it now captures the toast region and the frame box on
both sides, not just the panel. Toasts are paired by text and compared
on size, colors, fonts, icon, close button and each part's position. New
step P7C covers success after a plan change that took a payment. At the
stack top, all 19 steps show no copy or element difference, the same
toasts with the same measurements, and equal frame boxes.

**Toasts, app (left) vs billing-web (right): progress, decline,
success**

<img width="824" alt="D-toasts"
src="https://github.com/user-attachments/assets/06d04e8e-6aba-46a8-9287-f43d3019844a"
/>

**billing-web progress toast, AS IS | TO BE**

<img width="1092" alt="D-toast-web-asis-tobe"
src="https://github.com/user-attachments/assets/d860df11-e1eb-49e2-ba17-e30efec5723c"
/>

**P7C success after a plan change: billing-web AS IS | TO BE, then app |
billing-web**

<img width="1448" alt="D-frame-web"
src="https://github.com/user-attachments/assets/36c3a98f-591f-48ca-8a58-03a3273ae90f"
/>
<img width="1448" alt="D-frame-appweb"
src="https://github.com/user-attachments/assets/ecd2c4ee-fbbd-48ba-b55c-b0645b0b5662"
/>

### A checkout the server still holds (M2 QA N1)

- On mount the view adopts the operation the billing status names
(`lifecycle.recover()`), the way the app resumes
`pending_billing_op_id`. Before this, opening checkout while an earlier
subscription was pending showed a fresh card form or an enabled confirm.
Pressing it sent nothing and showed "Something went wrong."
- The confirm now gets the app's `action-url`, `authentication-error`
and `parked-checkout-recovery`, and `paying` follows the app's
`isPolling` rule. An operation parked on `awaiting_payment_method`
offers "Complete your payment", and a settling invoice holds the pay
action.
- A subscribe the core refuses with `OPERATION_ALREADY_PENDING` shows
the app's sentence ("A payment you started earlier is still going
through…") instead of the generic failure.
- Tests: view tests for a parked op and a settling-invoice op, both red
without the fix. Harness steps P8a (parked) and P8b (settling invoice)
match the app with 0% copy/element difference.
- Same on both hosts: the core refuses a second subscribe while the
status names a pending one, so on the SDK rail "Complete your payment"
answers with that sentence in the app and in billing-web alike.

**P8a: parked checkout, Cloud app (left) | billing-web (right)**

<img width="1448" alt="D-parked"
src="https://github.com/user-attachments/assets/7316e0da-e4df-4fe9-bf7b-5e8d34754efc"
/>

**P8b: settling invoice, Cloud app (left) | billing-web (right)**

<img width="1448" alt="D-held"
src="https://github.com/user-attachments/assets/1940763e-3f0a-4b91-9c71-c0d175b0c69a"
/>

**P6a2: reason-less decline, Cloud app (left) | billing-web (right)**

<img width="1448" alt="D-no-reason"
src="https://github.com/user-attachments/assets/75d0ed13-bb14-453d-8b73-eda7b23ff754"
/>

## Review Focus

- The two gaps above.

## Stack

| PR | branch | base | title |
|---|---|---|---|
| Comfy-Org#19097 | `jaewon/billing-web-remove-plan-grid` | `main` | `FE-3045
refactor(billing-web): drop the billing-web plan grid; hosts own plan
selection` |
| A Comfy-Org#19098 | `jaewon/design-system-button-variants` | Comfy-Org#19097 | `FE-3046
refactor(design-system): move buttonVariants into
@comfyorg/design-system` |
| B Comfy-Org#19099 | `jaewon/account-ui-checkout-surfaces` | A | `FE-3046
feat(account-ui): shared checkout confirm, saved-method selector, card
form and success` |
| C Comfy-Org#19100 | `jaewon/workspace-adopt-account-ui-checkout` | B | `FE-3046
refactor(workspace): render the subscription checkout steps from
account-ui` |
| **D (this PR)** | **`jaewon/billing-web-shared-checkout`** | **C** |
**`FE-3046 feat(billing-web): render the shared embedded checkout`** |
| E Comfy-Org#19104 | `jaewon/billing-web-success-invite` | D | `FE-3046
feat(billing-web): invite your team from the checkout success step` |
| F Comfy-Org#19105 | `jaewon/checkout-3ds-failure-copy` | E | `FE-3047
fix(account-ui): clear decline toasts once a retry succeeds` |
| G Comfy-Org#19106 | `jaewon/billing-web-return-close-tab` | F | `FE-3048
fix(billing-web): return to the host by closing the checkout tab` |
| H Comfy-Org#19115 | `jaewon/checkout-cta-reachable` | G | `FE-3050
fix(account-ui): keep the checkout CTA reachable when notices grow the
confirm step` |

```mermaid
graph LR
  P0[Comfy-Org#19097: remove plan grid] --> A[A: design-system buttonVariants]
  A --> B[B: account-ui checkout surfaces]
  B --> C[C: workspace adopts account-ui]
  C --> D[D: billing-web shared checkout]
  D --> E[E: billing-web success invite]
  E --> F[F: stale decline toasts]
  F --> G[G: close the billing tab]
  G --> H[H: reachable checkout CTA]
  style D fill:#f9d71c,stroke:Comfy-Org#333,color:#000
```

## AS IS / TO BE

### Live (testcloud) AS IS / TO BE

Real app and real billing-web against testcloud, not the harness. Same
account and plan change on both sides: Team Monthly team_700 → team_1400
($1,295/mo) on a cancelled team workspace, which reactivates it (the
"Confirm your upgrade" path). Both subscriptions were cancelled again
afterwards.

- **AS IS:** `main` ec7764f. Embedded = local app on testcloud with
`ff:hosted_billing_destination="stripe"`. billing-web = testcloud
(`billing_web`) → testbilling. Team Monthly team_700, new subscription.
- **TO BE:** stack top f02bdd6 (H Comfy-Org#19115, includes this PR) for both
surfaces. Local app
(`DEV_SERVER_COMFYUI_URL=https://testcloud.comfy.org/`, testcloud
`pk_test`) and local billing-web on :5174 (`VITE_BILLING_ENV=test`).
Embedded = `ff:hosted_billing_destination="stripe"` on `m2-qa-0925-3ds`
(saved card needs 3DS). billing-web = `"billing_web"` on
`m2-qa-0927-full`, handed off from the app's Change plan; the server's
`billing_web_url` was cleared in the page so the app opens the local
billing-web.

**TO BE video, embedded (left) | billing-web (right).** Plan picked in
the app → confirm → pay → (3DS on the embedded side's saved card) →
"You're all set" with Invite your team → Close. On billing-web, Close
closes the tab and the app shows the new credit balance.


https://github.com/user-attachments/assets/a4a527e4-9a89-4808-8e27-90b143cc9bce

Full-size recordings: embedded
https://github.com/user-attachments/assets/fd8f0ea7-6480-4b54-bb28-afc7fffbfdd6
· billing-web
https://github.com/user-attachments/assets/1da3540f-fcf6-4691-a075-997b07c364f1

**AS IS video, embedded (left) | billing-web (right)** (new
subscription, recorded separately so the timelines do not line up).


https://github.com/user-attachments/assets/b653c5ba-2e82-4bfa-bed5-f151109e580e

**TO BE per step, embedded (left) | billing-web (right)**

1. Plan chosen in the host app (same dialog; billing-web has no plan
picker)

<img width="1400" alt="1-plan-picker-in-host"
src="https://github.com/user-attachments/assets/2b59d096-c13f-4e8f-a96b-9e86ebee4f58"
/>

2. Confirm your upgrade: same notice, summary, discount, total, promo
and CTA

<img width="1400" alt="2-confirm-top"
src="https://github.com/user-attachments/assets/20bbd27d-361c-48d4-8857-ddd6bc71ced3"
/>

3. Confirm scrolled inside its frame: terms line reachable on both

<img width="1400" alt="3-confirm-scrolled-terms"
src="https://github.com/user-attachments/assets/2f3d6e40-6819-4f52-b2f8-b76d829fca1c"
/>

4. Paying: busy CTA and "Processing payment — setting up your
workspace…" toast

<img width="1400" alt="4-processing"
src="https://github.com/user-attachments/assets/f5372838-c85d-4113-aece-019ce940cf40"
/>

5. Embedded only: Stripe 3DS2 test page for the saved card
(billing-web's workspace card did not ask for 3DS)

<img width="700" alt="5-embedded-3ds-challenge"
src="https://github.com/user-attachments/assets/dbd3abe9-3d90-4da5-b398-945e6f9cefb2"
/>

6. You're all set: plan card, 295,400 / month, Invite your team, Send
invites, Close

<img width="1400" alt="6-success"
src="https://github.com/user-attachments/assets/42b820df-b6b8-4748-a768-5969d7474fb4"
/>

7. After Close: embedded dialog closes; billing-web tab closes and the
app shows 294,054 credits with no Resubscribe

<img width="1400" alt="7-after-close"
src="https://github.com/user-attachments/assets/4989f353-1d96-4255-b7a4-cd78a092f86e"
/>

**AS IS per step, embedded (left) | billing-web (right)**

<img width="1400" alt="AS IS P1 confirm"
src="https://github.com/user-attachments/assets/a027af94-3f09-4ed1-8d13-5a561cb7a788"
/>
<img width="1400" alt="AS IS P6 decline 0002"
src="https://github.com/user-attachments/assets/ec0e267a-8255-4460-98a7-5ef466dcbe8b"
/>
<img width="1400" alt="AS IS P7 success"
src="https://github.com/user-attachments/assets/381b0a9b-93fd-42ef-9200-adc39d42b179"
/>
<img width="1400" alt="AS IS P7 return to app"
src="https://github.com/user-attachments/assets/2754cf9e-e300-4a73-8889-76ed5dbab082"
/>

**Differences still visible live (TO BE)**

- Processing toast: the app's is the blue info toast with a close
button; billing-web's `CheckoutToast` is a neutral dark toast without
one.
- Success: the app's dialog fits its content; billing-web's frame keeps
the confirm step's fixed height, so a blank band sits between the email
field and Send invites. The app also shows a "Subscription updated
successfully" toast; billing-web does not.
- Embedded only (pre-existing, N4): a "Couldn't open the payment page —
please allow popups" warning appears during the in-page 3DS challenge.
- Embedded confirm on `m2-qa-0925-3ds`: the notice says it renews on Oct
27, 2026 while the summary says "Renews at $1,295.00 on Oct 25, 2026".
Not compared on billing-web, whose workspace has both dates on Oct 27.

**Not recorded live yet**

- ~~New subscription (card entry, decline 0002, 3DS 3184 complete and
fail).~~ Recorded on billing-web in the live rerun below (workspace
`m2-qa-0927-new`). An embedded new-subscription run on the same build
was not possible: the account has one free workspace, so the embedded
side is covered by the AS IS recording above and the upgrade
side-by-side below.
- Failed 3DS on the upgrade path: not run, because a failed reactivating
upgrade leaves the operation pending and the workspace cannot be
cancelled (N6).

#### Live rerun on stack top 9dab83d (2026-09-27)

**Upgrade, AS IS embedded (left) | TO BE billing-web (right):** Team
147.7K → 295.4K in the app dialog and Team 295.4K → 527.5K on
billing-web, both with 3DS complete; same confirm, 3DS and success
screens.


https://github.com/user-attachments/assets/d4d49d40-27bc-4bbe-8886-99f2df7acd8f

**TO BE billing-web, new Team Monthly subscription:** decline (0002) →
3DS fail (3184) → 3DS complete → "You're all set" with Invite your team
→ Close closes the tab and the app shows the plan.


https://github.com/user-attachments/assets/a4c58e5d-429a-4332-bfa4-e10d8621f082

### Mocked harness

Checkout parity harness (`temp/scripts/checkout-parity`, same fixtures
on both surfaces, fake `js.stripe.com` masking the Stripe elements;
mocked Cloud, not a live backend). Each image: **billing-web AS IS**
(`main` ec7764f) | **billing-web TO BE** (this PR, d24d242) |
**cloud app** (same build). Copy/element diff app vs billing-web TO BE:
none on all 11 steps. Panel pixel diff (app vs TO BE) below; the
non-zero ones are the busy button's spinner frame. The harness's style
notes that remain pair two same-named elements (the two Stripe masks,
the two Close buttons) and are identical in the structure dumps.

**P1-confirm-new-personal** — pixel diff 0%

<img width="1400" alt="P1-confirm-new-personal"
src="https://github.com/user-attachments/assets/062a2b68-9299-4920-b321-0a72b3102918"
/>

**P1T-confirm-new-team** — pixel diff 0%

<img width="1400" alt="P1T-confirm-new-team"
src="https://github.com/user-attachments/assets/786f38b6-5f02-4a43-ad63-6a44cb7465a8"
/>

**P2a-confirm-upgrade-immediate** — pixel diff 0%

<img width="1400" alt="P2a-confirm-upgrade-immediate"
src="https://github.com/user-attachments/assets/f4fc2395-9cc2-4668-b338-52051f84189f"
/>

**P2b-confirm-downgrade-zero-due** — pixel diff 0%

<img width="1400" alt="P2b-confirm-downgrade-zero-due"
src="https://github.com/user-attachments/assets/a4cef7bc-4f04-48e2-b740-85a50ad2b1de"
/>

**P3-saved-card-selector** — pixel diff 0%

<img width="1400" alt="P3-saved-card-selector"
src="https://github.com/user-attachments/assets/f4ef89a3-d681-4db3-9209-2f9e7350dae0"
/>

**P3b-no-saved-cards** — pixel diff 0.000%

<img width="1400" alt="P3b-no-saved-cards"
src="https://github.com/user-attachments/assets/ac51ce04-ea6b-4a06-a706-5092bbd77b5d"
/>

**P4-card-entry** — pixel diff 0.000%

<img width="1400" alt="P4-card-entry"
src="https://github.com/user-attachments/assets/705d93bf-e33c-4376-b357-d4be86f332d3"
/>

**P5-3ds-in-progress** — pixel diff 0.003%

<img width="1400" alt="P5-3ds-in-progress"
src="https://github.com/user-attachments/assets/39f72aaa-28b1-4266-bdd5-b14fe4b6a99b"
/>

**P6a-declined** — pixel diff 0%

<img width="1400" alt="P6a-declined"
src="https://github.com/user-attachments/assets/66ef6af7-c82b-4f76-b5ca-37896d734420"
/>

**P6b-3ds-failed** — pixel diff 0.003%

<img width="1400" alt="P6b-3ds-failed"
src="https://github.com/user-attachments/assets/e18807f0-b0d8-4584-a9fc-86ae86ec26f9"
/>

**P7-success** — pixel diff 0%

<img width="1400" alt="P7-success"
src="https://github.com/user-attachments/assets/ecd05652-cee7-4464-bae9-61da565904c8"
/>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
christian-byrne pushed a commit that referenced this pull request Sep 29, 2026
…tor, card form and success (#19099)

- Linear: FE-3046

**Merge order:** #19096 (ADR 0034 amendment) merges first. Until it
does, ADR 0034 rule 4 still forbids account-ui from using the design
system, which B does.

## Why

billing-web is the cloud app's embedded checkout moved to a new tab,
with no UX change (ADR BILLING-WEB-0038, #19096). Today billing-web
renders a checkout of its own (`EmbeddedCheckout`, `CheckoutPayment`,
`CheckoutSubmit`) that has drifted from the app's: different price
layout, no saved-card selection, different copy. For both to render the
same screens, the app's confirm, price breakdown, saved-card selector,
card form, terms notice and success step have to live where both can
import them. This PR adds them to `@comfyorg/account-ui`. Nothing
renders them yet, so no visual change.

## How

- New entry `@comfyorg/account-ui/billing/checkout`, ported line for
line from the app components. Same markup, same classes, same
conditions:
- `CheckoutSubscribeConfirm` ←
`SubscriptionAddPaymentPreviewWorkspace.vue` (plan header, credits,
total due, discounts, promo code, saved methods, card form, 3DS prompt,
parked-checkout recovery, terms).
- `CheckoutTransitionConfirm` ←
`SubscriptionTransitionPreviewWorkspace.vue` (immediate vs scheduled
change, reactivation banner and threshold checkbox).
- `CheckoutSavedMethods` + `CheckoutSavedMethodSelect` ← the
saved-method row / `SingleSelect` picker (Reka select with the app's
select classes).
- `CheckoutPaymentForm` ← `UnifiedStripePaymentSelector.vue` minus the
app bindings (key, theme and telemetry become props and a `phase`
event).
- `CheckoutSuccess` ← `SubscriptionSuccessWorkspace.vue`, with
`details`/`actions` slots for the app's team invite.
- `CheckoutTermsNote`, `CheckoutPromotionCode`,
`CheckoutPaymentNotices`, `CheckoutVerificationPrompt`: blocks both
confirms repeated. `CheckoutSubscribeSummary`/`CheckoutSubscribeActions`
and `CheckoutReactivationBanner`/`CheckoutTransitionSummary` split the
two confirm templates under the fallow complexity gate; the rendered
markup is the same.
- `checkoutQuote.ts`: the app's `subscriptionQuoteFormatting.ts` +
`planDuration.ts`.
- `@comfyorg/account-ui/billing/catalog` (TS-only entry): the tiers'
prices and monthly credit grants (the numbers in the app's
`TIER_PRICING`). The app's confirm reads the grant from this table
(`TIER_PRICING`), not from the quote's `new_plan.credits_cents`, so
billing-web reads the same table to show the same number; C points the
app at it. A separate entry so non-Vue consumers (the Playwright runner
imports `tierPricing`) never load the components.
- The package has no i18n runtime. Hosts pass a typed `CheckoutCopy`;
interpolated strings are functions, and sentences that wrap an element
(terms links, reactivation amount) keep `{token}`s that the component
splits.
- Hosts pass a resolved `CheckoutPlan` (name, monthly/yearly price,
credits, `pricedByQuote`) instead of the package reading the tier
catalog.
- `selectVariants` moves to `@comfyorg/design-system/select.variants`
(same move as `buttonVariants` in #19098), so the picker renders the
app's select classes.
- Packaging: `design-system` variants and `tailwind-utils`'s `cn` are
bundled into the published build (dev dependencies). `tailwind-utils` is
not on npm and `design-system` ships TS source, so neither can be a
runtime dependency of a published package. `reka-ui` is a peer. The
rendered classes need the design-system theme and primeicons at runtime,
so `@comfyorg/design-system` and `primeicons` are peers too, and the
package description says to load their CSS and add the package's dist to
the consumer's Tailwind sources. The smoke test imports the new entry in
the typed consumer and treats it as bundler-only, like `billing/stripe`.

### Reactivation renewal date (live testcloud recording)

The reactivation notice and the summary could name different renewal
days for the same quote. On `m2-qa-0925-3ds` the notice said "renew … on
Oct 27" and the summary "Renews … on Oct 25, 2026".
- **Summary:** reads `renewal_at ?? new_plan.period_end`
(`resolveRenewalDate`).
- **Notice:** read `new_plan.period_end` only. When that was absent, it
computed `effective_at` + one period on the client (Sep 27 + 1 month =
Oct 27).
- **Not a server inconsistency:** the server sent one renewal date,
`renewal_at`, which the contract defines as "the next recurring charge
and target-plan period end".
- **Fix:** the notice now reads the same server date as the summary
(`resolveRenewalDate`: `renewal_at`, else the plan's server
`period_end`). The client-side computation is gone. With no server date,
the notice drops its renewal clause through new
`reactivation.withoutRenewalDate` copy, the way the summary drops its
date.
- **Contract:** `renewal_at` is optional in `PreviewSubscribeResponse`
("Optional in the schema for older clients"; "current servers always
return this"). The server should always send it; the client no longer
computes one when it doesn't.
- **Tests:**
  - A new test fails on the old code (Oct 27 vs Oct 25).
- The tests that pinned the client computation (account-ui and the app's
`SubscriptionTransitionPreviewWorkspaceReactivation.test.ts`, in C) are
replaced by a no-renewal-date test.
  - C adds the app's `withoutRenewalDate` strings.

## Review Focus

- The ports are meant to be verbatim. C (the next PR) swaps the app onto
these components and the app's existing component tests (about 2,100
lines across the two confirms and the success step) pass with only stub
names changed. That is the parity check.
- `CheckoutPlan.pricedByQuote` reproduces the app's price rules exactly,
including the odd ones: a tier plan shows the quote's price once one
arrives and `$0` on the success step without one; a team credit stop
always shows its own price.

## Stack

| PR | branch | base | title |
|---|---|---|---|
| #19097 | `jaewon/billing-web-remove-plan-grid` | `main` | `FE-3045
refactor(billing-web): drop the billing-web plan grid; hosts own plan
selection` |
| A #19098 | `jaewon/design-system-button-variants` | #19097 | `FE-3046
refactor(design-system): move buttonVariants into
@comfyorg/design-system` |
| **B (this PR)** | **`jaewon/account-ui-checkout-surfaces`** | **A** |
**`FE-3046 feat(account-ui): shared checkout confirm, saved-method
selector, card form and success`** |
| C #19100 | `jaewon/workspace-adopt-account-ui-checkout` | B | `FE-3046
refactor(workspace): render the subscription checkout steps from
account-ui` |
| D #19101 | `jaewon/billing-web-shared-checkout` | C | `FE-3046
feat(billing-web): render the shared embedded checkout` |
| E #19104 | `jaewon/billing-web-success-invite` | D | `FE-3046
feat(billing-web): invite your team from the checkout success step` |
| F #19105 | `jaewon/checkout-3ds-failure-copy` | E | `FE-3047
fix(account-ui): clear decline toasts once a retry succeeds` |
| G #19106 | `jaewon/billing-web-return-close-tab` | F | `FE-3048
fix(billing-web): return to the host by closing the checkout tab` |
| H #19115 | `jaewon/checkout-cta-reachable` | G | `FE-3050
fix(account-ui): keep the checkout CTA reachable when notices grow the
confirm step` |

```mermaid
graph LR
  P0[#19097: remove plan grid] --> A[A: design-system buttonVariants]
  A --> B[B: account-ui checkout surfaces]
  B --> C[C: workspace adopts account-ui]
  C --> D[D: billing-web shared checkout]
  D --> E[E: billing-web success invite]
  E --> F[F: stale decline toasts]
  F --> G[G: close the billing tab]
  G --> H[H: reachable checkout CTA]
  style B fill:#f9d71c,stroke:#333,color:#000
```

## AS IS / TO BE

No rendered change: nothing renders these components in this PR. The
parity screenshots are on C (#19100, app before/after, pixel-identical)
and D (#19101, billing-web before/after next to the app).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
christian-byrne pushed a commit that referenced this pull request Sep 29, 2026
…tor, card form and success (#19099)

- Linear: FE-3046

**Merge order:** #19096 (ADR 0034 amendment) merges first. Until it
does, ADR 0034 rule 4 still forbids account-ui from using the design
system, which B does.

## Why

billing-web is the cloud app's embedded checkout moved to a new tab,
with no UX change (ADR BILLING-WEB-0038, #19096). Today billing-web
renders a checkout of its own (`EmbeddedCheckout`, `CheckoutPayment`,
`CheckoutSubmit`) that has drifted from the app's: different price
layout, no saved-card selection, different copy. For both to render the
same screens, the app's confirm, price breakdown, saved-card selector,
card form, terms notice and success step have to live where both can
import them. This PR adds them to `@comfyorg/account-ui`. Nothing
renders them yet, so no visual change.

## How

- New entry `@comfyorg/account-ui/billing/checkout`, ported line for
line from the app components. Same markup, same classes, same
conditions:
- `CheckoutSubscribeConfirm` ←
`SubscriptionAddPaymentPreviewWorkspace.vue` (plan header, credits,
total due, discounts, promo code, saved methods, card form, 3DS prompt,
parked-checkout recovery, terms).
- `CheckoutTransitionConfirm` ←
`SubscriptionTransitionPreviewWorkspace.vue` (immediate vs scheduled
change, reactivation banner and threshold checkbox).
- `CheckoutSavedMethods` + `CheckoutSavedMethodSelect` ← the
saved-method row / `SingleSelect` picker (Reka select with the app's
select classes).
- `CheckoutPaymentForm` ← `UnifiedStripePaymentSelector.vue` minus the
app bindings (key, theme and telemetry become props and a `phase`
event).
- `CheckoutSuccess` ← `SubscriptionSuccessWorkspace.vue`, with
`details`/`actions` slots for the app's team invite.
- `CheckoutTermsNote`, `CheckoutPromotionCode`,
`CheckoutPaymentNotices`, `CheckoutVerificationPrompt`: blocks both
confirms repeated. `CheckoutSubscribeSummary`/`CheckoutSubscribeActions`
and `CheckoutReactivationBanner`/`CheckoutTransitionSummary` split the
two confirm templates under the fallow complexity gate; the rendered
markup is the same.
- `checkoutQuote.ts`: the app's `subscriptionQuoteFormatting.ts` +
`planDuration.ts`.
- `@comfyorg/account-ui/billing/catalog` (TS-only entry): the tiers'
prices and monthly credit grants (the numbers in the app's
`TIER_PRICING`). The app's confirm reads the grant from this table
(`TIER_PRICING`), not from the quote's `new_plan.credits_cents`, so
billing-web reads the same table to show the same number; C points the
app at it. A separate entry so non-Vue consumers (the Playwright runner
imports `tierPricing`) never load the components.
- The package has no i18n runtime. Hosts pass a typed `CheckoutCopy`;
interpolated strings are functions, and sentences that wrap an element
(terms links, reactivation amount) keep `{token}`s that the component
splits.
- Hosts pass a resolved `CheckoutPlan` (name, monthly/yearly price,
credits, `pricedByQuote`) instead of the package reading the tier
catalog.
- `selectVariants` moves to `@comfyorg/design-system/select.variants`
(same move as `buttonVariants` in #19098), so the picker renders the
app's select classes.
- Packaging: `design-system` variants and `tailwind-utils`'s `cn` are
bundled into the published build (dev dependencies). `tailwind-utils` is
not on npm and `design-system` ships TS source, so neither can be a
runtime dependency of a published package. `reka-ui` is a peer. The
rendered classes need the design-system theme and primeicons at runtime,
so `@comfyorg/design-system` and `primeicons` are peers too, and the
package description says to load their CSS and add the package's dist to
the consumer's Tailwind sources. The smoke test imports the new entry in
the typed consumer and treats it as bundler-only, like `billing/stripe`.

### Reactivation renewal date (live testcloud recording)

The reactivation notice and the summary could name different renewal
days for the same quote. On `m2-qa-0925-3ds` the notice said "renew … on
Oct 27" and the summary "Renews … on Oct 25, 2026".
- **Summary:** reads `renewal_at ?? new_plan.period_end`
(`resolveRenewalDate`).
- **Notice:** read `new_plan.period_end` only. When that was absent, it
computed `effective_at` + one period on the client (Sep 27 + 1 month =
Oct 27).
- **Not a server inconsistency:** the server sent one renewal date,
`renewal_at`, which the contract defines as "the next recurring charge
and target-plan period end".
- **Fix:** the notice now reads the same server date as the summary
(`resolveRenewalDate`: `renewal_at`, else the plan's server
`period_end`). The client-side computation is gone. With no server date,
the notice drops its renewal clause through new
`reactivation.withoutRenewalDate` copy, the way the summary drops its
date.
- **Contract:** `renewal_at` is optional in `PreviewSubscribeResponse`
("Optional in the schema for older clients"; "current servers always
return this"). The server should always send it; the client no longer
computes one when it doesn't.
- **Tests:**
  - A new test fails on the old code (Oct 27 vs Oct 25).
- The tests that pinned the client computation (account-ui and the app's
`SubscriptionTransitionPreviewWorkspaceReactivation.test.ts`, in C) are
replaced by a no-renewal-date test.
  - C adds the app's `withoutRenewalDate` strings.

## Review Focus

- The ports are meant to be verbatim. C (the next PR) swaps the app onto
these components and the app's existing component tests (about 2,100
lines across the two confirms and the success step) pass with only stub
names changed. That is the parity check.
- `CheckoutPlan.pricedByQuote` reproduces the app's price rules exactly,
including the odd ones: a tier plan shows the quote's price once one
arrives and `$0` on the success step without one; a team credit stop
always shows its own price.

## Stack

| PR | branch | base | title |
|---|---|---|---|
| #19097 | `jaewon/billing-web-remove-plan-grid` | `main` | `FE-3045
refactor(billing-web): drop the billing-web plan grid; hosts own plan
selection` |
| A #19098 | `jaewon/design-system-button-variants` | #19097 | `FE-3046
refactor(design-system): move buttonVariants into
@comfyorg/design-system` |
| **B (this PR)** | **`jaewon/account-ui-checkout-surfaces`** | **A** |
**`FE-3046 feat(account-ui): shared checkout confirm, saved-method
selector, card form and success`** |
| C #19100 | `jaewon/workspace-adopt-account-ui-checkout` | B | `FE-3046
refactor(workspace): render the subscription checkout steps from
account-ui` |
| D #19101 | `jaewon/billing-web-shared-checkout` | C | `FE-3046
feat(billing-web): render the shared embedded checkout` |
| E #19104 | `jaewon/billing-web-success-invite` | D | `FE-3046
feat(billing-web): invite your team from the checkout success step` |
| F #19105 | `jaewon/checkout-3ds-failure-copy` | E | `FE-3047
fix(account-ui): clear decline toasts once a retry succeeds` |
| G #19106 | `jaewon/billing-web-return-close-tab` | F | `FE-3048
fix(billing-web): return to the host by closing the checkout tab` |
| H #19115 | `jaewon/checkout-cta-reachable` | G | `FE-3050
fix(account-ui): keep the checkout CTA reachable when notices grow the
confirm step` |

```mermaid
graph LR
  P0[#19097: remove plan grid] --> A[A: design-system buttonVariants]
  A --> B[B: account-ui checkout surfaces]
  B --> C[C: workspace adopts account-ui]
  C --> D[D: billing-web shared checkout]
  D --> E[E: billing-web success invite]
  E --> F[F: stale decline toasts]
  F --> G[G: close the billing tab]
  G --> H[H: reachable checkout CTA]
  style B fill:#f9d71c,stroke:#333,color:#000
```

## AS IS / TO BE

No rendered change: nothing renders these components in this PR. The
parity screenshots are on C (#19100, app before/after, pixel-identical)
and D (#19101, billing-web before/after next to the app).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at exact head 9042e30b665dab8bdba0c0d58697056e6a6e2c62.

Full context for agent readers

The billing tab closes when it was product-opened and falls back to the workspace-bound host URL when it was opened directly. The app strips only the hosted-billing outcome parameters, without treating them as a pending Stripe return. Exact-head checks are settled green and no review thread is unresolved.

… grow the confirm step (#19115)

- Linear: FE-3050

## Why

M2 QA: after a failed 3DS on a reactivating upgrade, the verification
notice pushed "Confirm & reactivate" and the terms below the checkout
frame, with no way to scroll to them. This happened in both the app and
billing-web.

## Root cause

Both hosts pin the narrow confirm and success steps to
`h-[min(740px,85vh|90vh)]` with `overflow-hidden`, so the dialog does
not grow with the Stripe iframe. The shared step inside
(`CheckoutTransitionConfirm`, `CheckoutSubscribeConfirm`,
`CheckoutSuccess`) is `h-full` with nothing that scrolls. Once notices,
the reactivation banner or the invite chips make it taller than the box,
the bottom is clipped.

## How

- `CheckoutTransitionConfirm`, `CheckoutSubscribeConfirm` and
`CheckoutSuccess` (account-ui) scroll inside the box: `min-h-0
overflow-y-auto` on the step root. Both hosts keep their pinned height.
- The wide card-capture split at xl keeps its current layout
(`xl:overflow-visible`). Its payment column already handles the Stripe
iframe there.
- Red-green (billing-web e2e, same component in both hosts):
- Red: `77110aa425`, `billing-web-e2e`
[failed](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36342728733/job/108685901864).
  - Green: `f02bdd6738`.
- The test ("a reactivating upgrade taller than the frame scrolls to its
confirm") uses a 520px-tall viewport and scrolls the wheel over the
confirm, then asserts "Confirm & reactivate" is in view.

## AS IS / TO BE

### Live (testcloud)

Live (testcloud) recordings of the whole stack (stack top f02bdd6,
embedded vs billing-web, AS IS and TO BE videos and per-step
screenshots) are in #19101 under "Live (testcloud) AS IS / TO BE".

TO BE live (f02bdd6), reactivating upgrade. The "Reactivating your
subscription" notice pushes the terms line below the frame; the confirm
now scrolls inside the frame so "Confirm & reactivate" and the terms
line are reachable on both hosts. Embedded (left) | billing-web (right),
top of the step and scrolled:

<img width="1400" alt="live-confirm-top"
src="https://github.com/user-attachments/assets/20bbd27d-361c-48d4-8857-ddd6bc71ced3"
/>
<img width="1400" alt="live-confirm-scrolled"
src="https://github.com/user-attachments/assets/2f3d6e40-6819-4f52-b2f8-b76d829fca1c"
/>

Not run live: the tallest case, a failed 3DS adding its notice under the
reactivation banner. A failed reactivating upgrade leaves the operation
pending and the workspace cannot be cancelled afterwards (QA N6), so it
stays in the harness.

### Harness

This is a parity-harness step with mocked Cloud: P2c, a reactivating
upgrade in a 1440x560 window, with the wheel scrolled over the confirm.
It reproduces the same clipping QA recorded after a failed 3DS: here the
reactivation banner does the growing instead of the verification notice.
The full harness rerun on this branch shows 0% copy/element difference
on all 18 steps, and P2c is 0% between the hosts.

**Cloud app, AS IS | TO BE**

<img width="1448" alt="H-app"
src="https://github.com/user-attachments/assets/33076467-ac1e-4695-942e-75d1f235346a"
/>

**billing-web, AS IS | TO BE**

<img width="1448" alt="H-web"
src="https://github.com/user-attachments/assets/61773efd-fbbd-4fcf-a48c-3a31944076e3"
/>

## Stack

| PR | branch | base | title |
|---|---|---|---|
| #19097 | `jaewon/billing-web-remove-plan-grid` | `main` | `FE-3045
refactor(billing-web): drop the billing-web plan grid; hosts own plan
selection` |
| A #19098 | `jaewon/design-system-button-variants` | #19097 | `FE-3046
refactor(design-system): move buttonVariants into
@comfyorg/design-system` |
| B #19099 | `jaewon/account-ui-checkout-surfaces` | A | `FE-3046
feat(account-ui): shared checkout confirm, saved-method selector, card
form and success` |
| C #19100 | `jaewon/workspace-adopt-account-ui-checkout` | B | `FE-3046
refactor(workspace): render the subscription checkout steps from
account-ui` |
| D #19101 | `jaewon/billing-web-shared-checkout` | C | `FE-3046
feat(billing-web): render the shared embedded checkout` |
| E #19104 | `jaewon/billing-web-success-invite` | D | `FE-3046
feat(billing-web): invite your team from the checkout success step` |
| F #19105 | `jaewon/checkout-3ds-failure-copy` | E | `FE-3047
fix(account-ui): clear decline toasts once a retry succeeds` |
| G #19106 | `jaewon/billing-web-return-close-tab` | F | `FE-3048
fix(billing-web): return to the host by closing the checkout tab` |
| **H (this PR)** | **`jaewon/checkout-cta-reachable`** | **G** |
**`FE-3050 fix(account-ui): keep the checkout CTA reachable when notices
grow the confirm step`** |

```mermaid
graph LR
  P0[#19097: remove plan grid] --> A[A: design-system buttonVariants]
  A --> B[B: account-ui checkout surfaces]
  B --> C[C: workspace adopts account-ui]
  C --> D[D: billing-web shared checkout]
  D --> E[E: billing-web success invite]
  E --> F[F: stale decline toasts]
  F --> G[G: close the billing tab]
  G --> H[H: reachable checkout CTA]
  style H fill:#f9d71c,stroke:#333,color:#000
```
@dante01yoon
dante01yoon merged commit e4b0ff9 into jaewon/checkout-3ds-failure-copy Sep 29, 2026
86 checks passed
@dante01yoon
dante01yoon deleted the jaewon/billing-web-return-close-tab branch September 29, 2026 16:50
dante01yoon added a commit that referenced this pull request Sep 29, 2026
…19105)

- Linear: FE-3047

## Why

In the real run, a failed 3DS challenge (card 3184, then Fail) first
showed "We couldn't complete payment verification. Please try again.". A
toast then replaced it with "Your bank declined this payment. Try
another payment method or contact your bank.". Separately, after one or
more declines, a retry that succeeded left the old decline toasts on
screen over "You're all set".

## Root cause

- **Wrong copy after a failed 3DS: a server-side cause.** The backend
recorded a failed 3DS as a generic decline. It is fixed in BE-17429 /
Comfy-Org/cloud#10828, which records
`payment_intent_authentication_failure`. With that fix, `GET
/api/billing/ops/{id}` returns `decline_reason: authentication_failed`.
The frontend already maps that reason to the verification copy, so it
does not re-derive it. **The live copy depends on BE-17429 deploying.**
- **Stale toasts:** `useSubscriptionCheckout.showSubscribeError` adds a
sticky error toast for each refused attempt. Nothing removed those
toasts when a later attempt succeeded.
- **"Update payment to run" in the top bar:** a different root cause,
left out of this PR. The label is the run button's `paymentRecovery`
state, which comes from the billing status and not from the checkout's
failure copy.

## How

- `useSubscriptionCheckout` remembers the error toasts from its attempts
and removes them when the checkout reaches success.
- Table tests pin the server-reason mapping on every surface.
`decline_reason: authentication_failed` and `authentication_required`
read as "We couldn't complete payment verification. Please try again."
in all four:
  - the shared lifecycle (`account-core` `operationState`),
  - the app's SDK rail (`subscriptionOperationView`),
  - the app's legacy poller (`billingOperationStore`),
  - billing-web (`CheckoutView`).
- There are no lifecycle or poller code changes, so F's diff over E is
the toast cleanup plus tests.
- Red-green for the toast cleanup: failing test in `5f86dba8a0`, fix in
`5982f627c2`.
- Red: [CI Tests Unit, run
36334659973](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36334659973).
- Green: [CI Tests Unit, run
36334977694](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36334977694).
- `08f850f705` removes the client-side override those commits had added,
since the server now sends the reason.

## AS IS / TO BE

### Live (testcloud)

Live (testcloud) recordings of the whole stack (stack top f02bdd6,
embedded vs billing-web, AS IS and TO BE videos and per-step
screenshots) are in #19101 under "Live (testcloud) AS IS / TO BE".

Not recorded live for this PR: a decline followed by a successful retry
needs the card form, which only the new-subscription path shows. No
unsubscribed Stripe-billed workspace is free on the test account
(10-workspace limit, and `parity-emb-0927` holds a pending operation).
The live TO BE upgrade in #19101 settles without a decline, and neither
host shows a stale toast over "You're all set" there.

### Harness

Evidence comes from the parity harness with mocked Cloud, not a live
backend.

**P6c: 3DS fails, then the server settles with `decline_reason:
authentication_failed` (what BE-17429 sends).** Both surfaces show the
verification copy. The left half is the Cloud app and the right half is
billing-web. E shows the same copy, because the mapping already existed.

<img width="1448" alt="F-3ds"
src="https://github.com/user-attachments/assets/108260c7-5a66-424a-8eb5-3b93b04f0571"
/>

**P6d: a saved card is declined, then a retry succeeds.** In the Cloud
app, E (left) keeps the decline toast over "You're all set". F (right)
clears it.

<img width="1448" alt="F-toast"
src="https://github.com/user-attachments/assets/5a173b2e-7f6e-46ad-9d47-3c6323953fda"
/>

P6a, P6b, P7 and P7T are unchanged. P6b has the known 0.003% spinner
frame.

## Stack

| PR | branch | base | title |
|---|---|---|---|
| #19097 | `jaewon/billing-web-remove-plan-grid` | `main` | `FE-3045
refactor(billing-web): drop the billing-web plan grid; hosts own plan
selection` |
| A #19098 | `jaewon/design-system-button-variants` | #19097 | `FE-3046
refactor(design-system): move buttonVariants into
@comfyorg/design-system` |
| B #19099 | `jaewon/account-ui-checkout-surfaces` | A | `FE-3046
feat(account-ui): shared checkout confirm, saved-method selector, card
form and success` |
| C #19100 | `jaewon/workspace-adopt-account-ui-checkout` | B | `FE-3046
refactor(workspace): render the subscription checkout steps from
account-ui` |
| D #19101 | `jaewon/billing-web-shared-checkout` | C | `FE-3046
feat(billing-web): render the shared embedded checkout` |
| E #19104 | `jaewon/billing-web-success-invite` | D | `FE-3046
feat(billing-web): invite your team from the checkout success step` |
| **F (this PR)** | **`jaewon/checkout-3ds-failure-copy`** | **E** |
**`FE-3047 fix(account-ui): clear decline toasts once a retry
succeeds`** |
| G #19106 | `jaewon/billing-web-return-close-tab` | F | `FE-3048
fix(billing-web): return to the host by closing the checkout tab` |
| H #19115 | `jaewon/checkout-cta-reachable` | G | `FE-3050
fix(account-ui): keep the checkout CTA reachable when notices grow the
confirm step` |

```mermaid
graph LR
  P0[#19097: remove plan grid] --> A[A: design-system buttonVariants]
  A --> B[B: account-ui checkout surfaces]
  B --> C[C: workspace adopts account-ui]
  C --> D[D: billing-web shared checkout]
  D --> E[E: billing-web success invite]
  E --> F[F: stale decline toasts]
  F --> G[G: close the billing tab]
  G --> H[H: reachable checkout CTA]
  style F fill:#f9d71c,stroke:#333,color:#000
```
comfy-pr-bot pushed a commit that referenced this pull request Sep 29, 2026
…9099, #19100, #19101, #19104) (#19442)

## Why

Backport of the FE-3046 billing-web shared-checkout stack to
`core/1.55`. The auto-backport bot hit cherry-pick conflicts on each of
these. The 1.55 release needs billing-web to render the same checkout as
the app, including the team invite on success.

## How

### Cherry-picked (in order, `-x`)

| PR | main squash | |
|---|---|---|
| #19098 (A) | | skipped: already on `core/1.55` via #19231 |
| #19099 (B) | | skipped: already on `core/1.55` via #19308 |
| #19100 (C) | `4bfdc8a68c` | render the subscription checkout steps
from account-ui |
| #19101 (D) | `d5cf71ce27` | billing-web renders the shared embedded
checkout |
| #19104 (E) | `592588bdd6` | team invite on the checkout success step
(squash includes #19105, #19106, #19115) |

No other prerequisite was cherry-picked.

### Conflicts and resolutions

- **C, `SubscriptionAddPaymentPreviewWorkspace.stripe.test.ts`**
(renamed from `UnifiedStripePaymentSelector.test.ts`). 1.55 mocks
telemetry with an explicit factory because it lacks #18497; main
automocks it. Took C's file as is.
`src/platform/telemetry/__mocks__/index.ts` exists on 1.55, so the
automock resolves and the test passes.
- **D, `apps/billing-web/src/views/CheckoutView.vue`**. 1.55 has #19305
(backport of #19185, show the server's refusal reason), which main does
not have yet. Kept D's checkout and kept 1.55's `refusal()` on the
subscribe failure and the quote-failure panel. Also used `refusal()` for
D's new promotion-code re-quote failure, as the upstream
`jaewon/checkout-quote-stale-recovery` stack does. Dropped the
now-unused `coded`.
- **E, `apps/billing-web/src/session/billingWebAuth.ts`**
(modify/delete). The file does not exist on 1.55 because the unified web
session work (#18880, #18881) is not backported. Deleted it and applied
E's change to what 1.55 has: `billingWebClient.ts` gains the
`BillingWebClient` type (`BillingClient & { invites }`) and `invites:
createWorkspaceInviteCommands({ transport })` on its single
`createBillingWebClient`.
- **E, `BillingShell.vue`**. Kept 1.55's
`createBillingWebClient(billingWebSessionClient())` and added E's
`provideWorkspaceInvites(client.invites)`.
- **E, `HostedSurface.vue`**. Kept 1.55's `useBillingWebSession` and
added E's `returnToHost` import (the return link now closes the tab,
from #19106).
- **E, `CheckoutView.vue`**. Kept `refusal` as above and took E's
`inviteCopy` and `useWorkspaceInvites()`.
- **E, `useSubscriptionCheckout.ts`**. Kept 1.55's `useEventListener`
import and added E's `watch` and `ToastMessageOptions`. 1.55 does not
use `onScopeDispose`, so it is not imported.
- **E, `useSubscriptionCheckout.test.ts`**. The toast mock gains E's
`remove`. 1.55 has no `removeGroup` usage, so `mockToastRemoveGroup` is
not added.

One extra commit updates a #19305 test case. For a refused subscribe
with `OPERATION_ALREADY_PENDING`, it expected the generic failure copy
because 1.55 had no copy for that code. D adds that copy, so the case
now expects billing-web's own wording, matching the upstream stack.

## Verification

- `pnpm typecheck` (app, account-core, billing-web, account-ui,
billing-contract): pass
- billing-web unit tests: 277/277
- account-ui unit tests: 224/224
- account-core unit tests: 1227/1227
- `src/platform/workspace` + `src/platform/cloud/subscription`: 2320
passed, 1 expected fail
- oxfmt, oxlint and eslint on the changed files: clean

## AS IS / TO BE

Same UI as the original PRs; see the AS IS / TO BE media in #19101 and
#19104.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
comfy-pr-bot pushed a commit that referenced this pull request Sep 29, 2026
…19099, #19100, #19101, #19104) (#19443)

## Why

Backport of the FE-3046 billing-web shared-checkout stack to
`cloud/1.55`. The auto-backport bot hit cherry-pick conflicts on each of
these. The 1.55 release needs billing-web to render the same checkout as
the app, including the team invite on success.

## How

### Cherry-picked (in order, `-x`)

| PR | main squash | |
|---|---|---|
| #19098 (A) | | skipped: already on `cloud/1.55` via #19232 |
| #19099 (B) | | skipped: already on `cloud/1.55` via #19309 |
| #19100 (C) | `4bfdc8a68c` | render the subscription checkout steps
from account-ui |
| #19101 (D) | `d5cf71ce27` | billing-web renders the shared embedded
checkout |
| #19104 (E) | `592588bdd6` | team invite on the checkout success step
(squash includes #19105, #19106, #19115) |

No other prerequisite was cherry-picked.

### Conflicts and resolutions

- **C, `SubscriptionAddPaymentPreviewWorkspace.stripe.test.ts`**
(renamed from `UnifiedStripePaymentSelector.test.ts`). 1.55 mocks
telemetry with an explicit factory because it lacks #18497; main
automocks it. Took C's file as is.
`src/platform/telemetry/__mocks__/index.ts` exists on 1.55, so the
automock resolves and the test passes.
- **D, `apps/billing-web/src/views/CheckoutView.vue`**. 1.55 has #19304
(backport of #19185, show the server's refusal reason), which main does
not have yet. Kept D's checkout and kept 1.55's `refusal()` on the
subscribe failure and the quote-failure panel. Also used `refusal()` for
D's new promotion-code re-quote failure, as the upstream
`jaewon/checkout-quote-stale-recovery` stack does. Dropped the
now-unused `coded`.
- **E, `apps/billing-web/src/session/billingWebAuth.ts`**
(modify/delete). The file does not exist on 1.55 because the unified web
session work (#18880, #18881) is not backported. Deleted it and applied
E's change to what 1.55 has: `billingWebClient.ts` gains the
`BillingWebClient` type (`BillingClient & { invites }`) and `invites:
createWorkspaceInviteCommands({ transport })` on its single
`createBillingWebClient`.
- **E, `BillingShell.vue`**. Kept 1.55's
`createBillingWebClient(billingWebSessionClient())` and added E's
`provideWorkspaceInvites(client.invites)`.
- **E, `HostedSurface.vue`**. Kept 1.55's `useBillingWebSession` and
added E's `returnToHost` import (the return link now closes the tab,
from #19106).
- **E, `CheckoutView.vue`**. Kept `refusal` as above and took E's
`inviteCopy` and `useWorkspaceInvites()`.
- **E, `useSubscriptionCheckout.ts`**. Kept 1.55's `useEventListener`
import and added E's `watch` and `ToastMessageOptions`. 1.55 does not
use `onScopeDispose`, so it is not imported.
- **E, `useSubscriptionCheckout.test.ts`**. The toast mock gains E's
`remove`. 1.55 has no `removeGroup` usage, so `mockToastRemoveGroup` is
not added.

The cloud branch takes the same resolved commits from the core backport;
they applied without further conflicts.

One extra commit updates a #19304 test case. For a refused subscribe
with `OPERATION_ALREADY_PENDING`, it expected the generic failure copy
because 1.55 had no copy for that code. D adds that copy, so the case
now expects billing-web's own wording, matching the upstream stack.

## Verification

- `pnpm typecheck` (app, account-core, billing-web, account-ui,
billing-contract): pass
- billing-web unit tests: 277/277
- account-ui unit tests: 224/224
- account-core unit tests: 1226/1226
- `src/platform/workspace` + `src/platform/cloud/subscription`: 2325
passed, 1 expected fail
- oxfmt, oxlint and eslint on the changed files: clean

## AS IS / TO BE

Same UI as the original PRs; see the AS IS / TO BE media in #19101 and
#19104.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 29, 2026
… step (Comfy-Org#19104)

- Linear: FE-3046

## Why

After a multi-seat (team) subscribe, the cloud app's success step
invites the team (`SubscriptionSuccessWorkspace` + `InviteMembersForm`).
billing-web's success step (Comfy-Org#19101) showed the plan card and Close only.
billing-web is the embedded checkout in a new tab (ADR
BILLING-WEB-0038), so it gets the same step.

## How

- `@comfyorg/account-core/billing`: `createWorkspaceInviteCommands({
transport })` with `listPendingInvites` and `createInvite` (`GET`/`POST
/workspace/invites`, parsed against the generated contract). It runs
over the billing session transport, so invites go to the workspace the
entry link bound — no second client, no hand-rolled fetch.
- `@comfyorg/account-ui/billing/checkout`: `CheckoutTeamSuccess` wraps
`CheckoutSuccess` with the app's invite block: same heading, subtext,
email tags, invalid / already-invited / seat-cap hints, one invite per
address, confirmation message, "Send invites" leading and Close demoted.
The invite rules (`inviteEmails.ts`) move from the app into the package
and the app imports them from there.
- `@comfyorg/design-system/tag.variants`: the tag recipe moves out of
the app, as `buttonVariants`/`selectVariants` did, so the package's
email tags use the app's classes.
- billing-web: the client carries the invite commands; `CheckoutView`
reads seats from billing status on success (and again after invites, as
the app refreshes status) and renders `CheckoutTeamSuccess`. A failed
invite shows the app's "Couldn't send N invites" toast.
- `CheckoutFrame`: the app's browser defaults for inputs and links move
to a base-layer rule, so a utility (the tags input's `text-sm`) still
wins, as it does in the app.

## Review Focus

- The app still renders its own `InviteMembersForm` (also used by the
invite dialog, with telemetry and the app toast). Switching the app to
`CheckoutTeamSuccess` is a follow-up; this PR moves the shared rules,
recipe and client so that step is small.
- CORS for `/api/workspace/invites` from the billing-web origin is not
verified against a live backend (mocked here).

### Checkbox margin (parity)

The app has no Tailwind preflight, so its reactivation checkbox keeps
the browser's margin. `[data-app-defaults]` now reverts that margin too,
which removes a 2px shift in the reactivation notice (harness P2e: 3.4%
to 0.01%).

## Stack

| PR | branch | base | title |
|---|---|---|---|
| Comfy-Org#19097 | `jaewon/billing-web-remove-plan-grid` | `main` | `FE-3045
refactor(billing-web): drop the billing-web plan grid; hosts own plan
selection` |
| A Comfy-Org#19098 | `jaewon/design-system-button-variants` | Comfy-Org#19097 | `FE-3046
refactor(design-system): move buttonVariants into
@comfyorg/design-system` |
| B Comfy-Org#19099 | `jaewon/account-ui-checkout-surfaces` | A | `FE-3046
feat(account-ui): shared checkout confirm, saved-method selector, card
form and success` |
| C Comfy-Org#19100 | `jaewon/workspace-adopt-account-ui-checkout` | B | `FE-3046
refactor(workspace): render the subscription checkout steps from
account-ui` |
| D Comfy-Org#19101 | `jaewon/billing-web-shared-checkout` | C | `FE-3046
feat(billing-web): render the shared embedded checkout` |
| **E (this PR)** | **`jaewon/billing-web-success-invite`** | **D** |
**`FE-3046 feat(billing-web): invite your team from the checkout success
step`** |
| F Comfy-Org#19105 | `jaewon/checkout-3ds-failure-copy` | E | `FE-3047
fix(account-ui): clear decline toasts once a retry succeeds` |
| G Comfy-Org#19106 | `jaewon/billing-web-return-close-tab` | F | `FE-3048
fix(billing-web): return to the host by closing the checkout tab` |
| H Comfy-Org#19115 | `jaewon/checkout-cta-reachable` | G | `FE-3050
fix(account-ui): keep the checkout CTA reachable when notices grow the
confirm step` |

```mermaid
graph LR
  P0[Comfy-Org#19097: remove plan grid] --> A[A: design-system buttonVariants]
  A --> B[B: account-ui checkout surfaces]
  B --> C[C: workspace adopts account-ui]
  C --> D[D: billing-web shared checkout]
  D --> E[E: billing-web success invite]
  E --> F[F: stale decline toasts]
  F --> G[G: close the billing tab]
  G --> H[H: reachable checkout CTA]
  style E fill:#f9d71c,stroke:Comfy-Org#333,color:#000
```

## AS IS / TO BE

### Live (testcloud)

Live (testcloud) recordings of the whole stack (stack top f02bdd6,
embedded vs billing-web, AS IS and TO BE videos and per-step
screenshots) are in Comfy-Org#19101 under "Live (testcloud) AS IS / TO BE".

TO BE live, team reactivating upgrade paid on both hosts: "You're all
set" with Invite your team on the embedded checkout (left) and
billing-web (right).

<img width="1400" alt="live-success-invite"
src="https://github.com/user-attachments/assets/42b820df-b6b8-4748-a768-5969d7474fb4"
/>

### Harness

Checkout parity harness step P7T (new: team subscribe → success; mocked
Cloud, not a live backend). **billing-web AS IS** (Comfy-Org#19101) |
**billing-web TO BE** (this PR) | **cloud app**. TO BE vs app: 0% panel
pixel diff, no copy or element differences. The other 11 steps are
unchanged (all 0% except the busy spinner frame on P5/P6b, 0.003%).

<img width="1558" alt="P7T"
src="https://github.com/user-attachments/assets/2af1e0c9-d5f3-4270-8621-b2fb71cdeff3"
/>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Sep 29, 2026
…e app does (Comfy-Org#19126)

- Linear: FE-3056

## Why

When the server refuses a subscribe because the quote went stale, the
embedded checkout re-quotes and tells the customer "Your quote changed.
Review the updated amount and try again." billing-web instead shows "We
couldn't reach the billing service. Please try again." and keeps the old
quote, so every retry is refused the same way. Seen live on testcloud
with a Team monthly → annual change (`POST /api/billing/subscribe` → 400
`SUBSCRIPTION_QUOTE_STALE`).

## Root cause

`issueSubscribe` in
`packages/account-core/src/core/billing/subscriptionCommands.ts` maps
only `REACTIVATION_CONFIRMATION_REQUIRED`; any other coded 4xx reaches
the host as a generic failure. `CheckoutView.pay` in billing-web has no
branch for a stale quote, so the failure copy is the transport one. The
app's legacy rail handles the code in
`useSubscriptionCheckout.recoverStaleQuote`.

## How

- account-core: `SUBSCRIPTION_QUOTE_STALE` becomes the command code
`QUOTE_STALE`, the same way the reactivation code is mapped.
- billing-web: on `QUOTE_STALE`, re-quote the plan and show the app's
copy ("Your quote changed. Review the updated amount and try again.");
if the re-quote itself fails, show the app's "quote refresh failed"
copy.
- Tests: an account-core case for the mapping and a CheckoutView case
for the re-quote and copy. Both fail before the fix.
- Red: the two new tests fail locally on edd1324 (the CI run for that
commit was cancelled by the fix push); green: CI on 2ca20d8.

The stale quotes themselves come from the server (non-deterministic
`renewal_at` on preview for a monthly → annual change); that was
reported to backend separately.

## AS IS / TO BE

**AS IS:** billing-web monthly → annual shows "We couldn't reach the
billing service" (server 400 `SUBSCRIPTION_QUOTE_STALE`); the same
change in the embedded checkout then goes through.


https://github.com/user-attachments/assets/b31ba7c9-0db0-4a84-a329-804ed28dac4f

**TO BE:** Unit and view tests (CheckoutView re-quotes and shows "Your
quote changed. Review the updated amount and try again."). The stale
quote is intermittent server-side, so a live TO BE capture is pending
the backend fix.

## Stack

| PR | Title |
|---|---|
| Comfy-Org#19097 | FE-3045 drop the billing-web plan grid |
| Comfy-Org#19098 | FE-3046 A buttonVariants into design-system |
| Comfy-Org#19099 | FE-3046 B account-ui checkout surfaces |
| Comfy-Org#19100 | FE-3046 C app renders account-ui checkout |
| Comfy-Org#19101 | FE-3046 D billing-web shared checkout |
| Comfy-Org#19104 | FE-3046 E invite from the success step |
| Comfy-Org#19105 | FE-3047 F clear decline toasts on success |
| Comfy-Org#19106 | FE-3048 G return closes the tab |
| Comfy-Org#19115 | FE-3050 H CTA reachable |
| **this PR** | **FE-3056 I stale quote re-quoted** |

```mermaid
graph LR
  P97[Comfy-Org#19097] --> A[Comfy-Org#19098] --> B[Comfy-Org#19099] --> C[Comfy-Org#19100] --> D[Comfy-Org#19101] --> E[Comfy-Org#19104] --> F[Comfy-Org#19105] --> G[Comfy-Org#19106] --> H[Comfy-Org#19115] --> I[FE-3056]:::me
  classDef me fill:#f9d71c,stroke:#333,color:#000
```

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cloud/1.55 Backport PRs for cloud 1.55 core/1.55 Backport PRs for core 1.55 needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants