Repository navigation
fix(models): name the filter after what it filters by - #19090
mariana953 wants to merge 1 commit into
Conversation
A sheet holding one group hides that group name, so the control is the only place a reader learns what the filter narrows. With more than one group there is no single answer and the generic name is the honest one.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🌐 Website E2ETip All tests passed.
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ec7764faa20087cab1e5f5f28adef2c079e09daf
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19090.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-ozrzth0ug-comfyui.vercel.app Last updated: 2026-09-27T08:56:03Z for |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe workshop filter now displays the sole facet group label when one group is available. It uses the generic localized filter label when there are zero or multiple groups. The menu title, trigger text, and accessible name use this computed label. ChangesWorkshop filter label
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The filter label now reflects the available groups without changing which options users can select. The inspected source shows the label matches the rendered groups, with no material merge risk identified. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19090 +/- ##
==========================================
- Coverage 84.11% 84.09% -0.03%
==========================================
Files 3164 3129 -35
Lines 154834 154058 -776
Branches 40141 39945 -196
==========================================
- Hits 130241 129555 -686
+ Misses 22989 22948 -41
+ Partials 1604 1555 -49
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 36 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Behaviour fixes from reviewing Mar's Hub V2 PRs together. No CSS, layout or copy changes to her design. - Details graph (#19010): zoom and Reset respond to mouse and touch (pointer capture no longer swallows their clicks); zoom scales about the drawing's centre instead of carrying it off-frame; drag follows the pointer in drawing units; phones can scroll the page past the graph; the graph JSON is fetched when Details first opens, not on every page view. - Graph reader (#19009): subgraph nodes are titled with the subgraph's name instead of its UUID; unlinked widget inputs are no longer drawn as sockets; links find their socket by saved index. - Filter chips (#18979): Clear on "Browse all models" keeps you in the full list; removing a chip keeps keyboard focus in the chip row, then returns it to the filter button; tests follow #19090's renamed button. - Run panel (#19005): a request that never ran no longer says it may still be billed or have taken credits. - Drop three translation keys #19029 left unused.
|
Included unmodified in #19255, which lands Mar's Hub V2 PRs together as part of the stack #18988 → #19023 → #19255 → #19256. Review fixes for this area are in #19256. Closing in favour of the stack. Your branch is untouched; for further changes, please open a PR on top of #19256 rather than pushing here. |
…te PRs (#19255) ## Summary Mar's Hub V2, staged as one reviewable phase. This combines the 23 PRs from her [#proj-comfy-hub post](https://comfy-organization.slack.com/archives/C0AEPRS8N74/p1790528696016959), including the latest head of #19004, while preserving her presentation and commit history. Review fixes remain isolated in #19256 above this PR. Design reference (not for review): #17804 · [V2 Hub preview](https://comfy-website-preview-pr-17804.vercel.app/hub/) ## Included **Independent:** #19031 Hub not Models · #18916 search with filter and sort · #18915 shorter workflows banner · #18979 filter chips · #19012 one "browse all" · #19016 shelf stops promising more · #18987 home hub workflows tab · #19025 Apps tab · #19090 filter named after what it filters · #19017 phone video controls · #19011 API tab endpoint · #19014 workflow header **Catalogue cards:** #18921 → #19015 **Workflow page V2:** #19009 → #19004 → #19008 → #19010 → #19029 **Run states:** #19005 → #19006 → #19007 → #19022 ## Integration with current main - Rebases the phase onto current `main`, including the canonical `/models/apps/<slug>/` routes and the separate Apps feature flag. - Keeps Mar's Apps shelf and card presentation while sourcing its entries and links from the canonical app catalogue. - Keeps Apps gated by `workshop-apps-enabled`; Workflows remain gated independently by `workshop-workflows-enabled`. - Keeps Mar's latest #19004 Details cleanup and single template-author attribution while retaining the later interactive graph work in #19008/#19010. - Resolves the combined `/models/` JavaScript budget to 1,820,000 bytes. ## Not included - #19241 (API tab rail): conflicts with #19011 and still needs a design call. - #19227 (draft), #17865 and #18306: not part of the Hub V2 set. ## Verification - Full website unit suite: 9,494 passed, 4 skipped. - Focused post-rebase app/catalogue suite: 98 passed. - Website typecheck: 0 errors. - Commit and push checks: formatting, lint, app/website typechecks, knip and Fallow passed. - `workshop-workflows-enabled` gates the home tab, catalogue tab, direct `?type=` URLs and detail pages without flashing gated content. --------- Co-authored-by: Mariana Martinho <mariana@comfy.org> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: github-actions <github-actions@github.com>
Behaviour fixes from reviewing Mar's Hub V2 PRs together. No CSS, layout or copy changes to her design. - Details graph (#19010): zoom and Reset respond to mouse and touch (pointer capture no longer swallows their clicks); zoom scales about the drawing's centre instead of carrying it off-frame; drag follows the pointer in drawing units; phones can scroll the page past the graph; the graph JSON is fetched when Details first opens, not on every page view. - Graph reader (#19009): subgraph nodes are titled with the subgraph's name instead of its UUID; unlinked widget inputs are no longer drawn as sockets; links find their socket by saved index. - Filter chips (#18979): Clear on "Browse all models" keeps you in the full list; removing a chip keeps keyboard focus in the chip row, then returns it to the filter button; tests follow #19090's renamed button. - Run panel (#19005): a request that never ran no longer says it may still be billed or have taken credits. - Drop three translation keys #19029 left unused.
Summary
A filter sheet holding a single group hides that group's name, so the control that opens it is the only place a reader can learn what the filter narrows. It said
Filter.Replaces #17848, which was opened on 16 September and can no longer be merged:
WorkshopFilterMenu.vuehas since been rewritten on main — the panel moved intoWorkshopFilterPanel.vueandtogglegrew amodelfacet — so that branch conflicts in the one file it changes. This is the same change re-applied to main's shape, in one commit.Changes
filterLabelnames the control after the only group when there is one, and keeps the generic name when there is more than one. On the models half that readsUse cases; on the workflows half, which also filters by model, it staysFilter. The name reaches the trigger, its accessible name, and the sheet's own heading and dialog label, so all four say the same thing.gap-2→gap-3tweak on the catalogue card's text block. It was unrelated to naming the filter, and feat(website): one name and one mark on a catalogue card #18921 now makes that same change as part of the card work.Review Focus
WorkshopFilterMenu.test.tsandWorkshopModelsGrid.test.tsnow open the control by the name a reader sees. They fail on main, where the trigger answers toFilter.Screenshots (if applicable)
Before: a control named
Filterover a sheet whose only group is unnamed. After: the control readsUse caseson the models half, and staysFilteron the workflows half, where two groups make the generic name the honest one.Generated by Claude Code