Skip to content

fix(models): name the filter after what it filters by - #17848

Closed
mariana953 wants to merge 2 commits into
mainfrom
mariana/models-filter-label
Closed

mariana953 wants to merge 2 commits into
mainfrom
mariana/models-filter-label

Conversation

@mariana953

@mariana953 mariana953 commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The catalogue offers one facet, and the sheet hides a lone group's name, so the only label a reader gets is a button reading "Filter", which says nothing about what it filters by.

Changes

  • What: the button, its dialog and their accessible names take the group's own name while there is only one group, and go back to "Filter" as soon as a second one exists. Today that reads "Use cases".
  • The model card gives its title row and its chips row gap-3 instead of gap-2: at the old gap the two read as a single block.

Review Focus

The rule lives next to the groups list it reads, so adding a facet is enough to restore the generic label. Nothing new is translated: the label already exists as workshop.launch.label, in English and Simplified Chinese.

workshop.filter.label is untouched, so the Hub's own filter button keeps saying "Filter".

Tests

WorkshopFilterMenu.test.ts and WorkshopModelsGrid.test.ts find the trigger and the dialog by their accessible name, so they assert the new one; they fail if the label reverts.

The catalogue offers one facet, and the sheet hides a lone group's name,
so a button reading "Filter" was the only label a reader got and it said
nothing about what the filter does. It takes the group's own name while
there is only one, and goes back to "Filter" as soon as there are more.

The card also gives its title and chips a little more room: at the old
gap the two rows read as one block.
@mariana953
mariana953 requested review from a team September 16, 2026 18:20
@vercel

vercel Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 16, 2026 6:30pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-17848.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-25ii5arng-comfyui.vercel.app

Last updated: 2026-09-16T18:32:06Z for afff1c6

@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d49e299e-592b-4adc-915e-da84be92e2f3

📥 Commits

Reviewing files that changed from the base of the PR and between f145df5 and afff1c6.

📒 Files selected for processing (3)
  • apps/website/src/components/workshop/WorkshopFilterMenu.vue
  • apps/website/src/lib/workshop/filter-label.test.ts
  • apps/website/src/lib/workshop/filter-label.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The workshop filter menu now uses the sole facet group label when applicable. Related tests use the updated accessible name. Workshop model cards have increased vertical spacing between information rows.

Changes

Workshop filter labeling

Layer / File(s) Summary
Filter label contract and test coverage
apps/website/src/lib/workshop/filter-label.ts, apps/website/src/lib/workshop/filter-label.test.ts, apps/website/src/components/workshop/WorkshopFilterMenu.vue, apps/website/src/components/workshop/*test.ts
The filter menu derives a facet-specific label for its title, trigger, and dialog when one facet group exists. Tests cover the helper and locate the menu by the "Use cases" name.

Workshop model card spacing

Layer / File(s) Summary
Model card layout spacing
apps/website/src/components/workshop/WorkshopModelCard.vue
The model information container changes its vertical gap from gap-2 to gap-3.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: benjcooley

Merge Risk: ⚪ Minimal · up to afff1

The filter-label and spacing changes are bounded and covered by the updated tests, with no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: naming the filter based on what it filters.
Description check ✅ Passed The description explains the problem, the filter-label behavior, the spacing change, review considerations, translation impact, and test updates. It covers the required template sections; omitted Brea…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed The pull request uses bug-fix language, but all changed files are under apps/website. The custom check explicitly excludes changes exclusively in apps/website, so the missing browser_tests/ cond…
Website End-To-End Regression Coverage ✅ Passed The PR changes website runtime files, but the runtime change is limited to filter label copy and accessible names. The other runtime change is styling-only spacing. The check explicitly excludes text/…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed-file list contains only files under apps/website/src/components/workshop and apps/website/src/lib/workshop. It contains no files under src/lib/litegraph/, src/ecs/, or files related to gra…
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mariana/models-filter-label

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 16, 2026
@codecov

codecov Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #17848      +/-   ##
==========================================
- Coverage   82.60%   82.60%   -0.01%     
==========================================
  Files        2848     2844       -4     
  Lines      142005   141937      -68     
  Branches    36527    36514      -13     
==========================================
- Hits       117308   117240      -68     
  Misses      23489    23489              
  Partials     1208     1208              
Flag Coverage Δ
billing-web ?
website-unit 74.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ite/src/components/workshop/WorkshopFilterMenu.vue 76.19% <100.00%> (+1.19%) ⬆️
...site/src/components/workshop/WorkshopModelCard.vue 97.56% <100.00%> (ø)
apps/website/src/lib/workshop/filter-label.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The catalogue ships one facet group, so the branch that names a filter
with more than one was unreachable from the component and went
uncovered. It is a rule about groups rather than about this menu, so it
moves out with a case for each shape.
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

Closing this in favour of #19090, which is the same change rebuilt on current main and green.

This branch is from 16 September. Since then main rewrote the filter control (WorkshopFilterMenu.vue was split, with WorkshopFilterPanel.vue extracted), so this branch conflicts in that one file. Resolving it would produce exactly what #19090 already contains, so there is nothing here worth carrying over — review #19090 instead.

The branch itself is left in place; nothing else depends on it.


Generated by Claude Code

@mariana953 mariana953 closed this Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant