Repository navigation
fix(models): name the filter after what it filters by - #17848
mariana953 wants to merge 2 commits into
Conversation
The catalogue offers one facet, and the sheet hides a lone group's name, so a button reading "Filter" was the only label a reader got and it said nothing about what the filter does. It takes the group's own name while there is only one, and goes back to "Filter" as soon as there are more. The card also gives its title and chips a little more room: at the old gap the two rows read as one block.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-17848.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-25ii5arng-comfyui.vercel.app Last updated: 2026-09-16T18:32:06Z for |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe workshop filter menu now uses the sole facet group label when applicable. Related tests use the updated accessible name. Workshop model cards have increased vertical spacing between information rows. ChangesWorkshop filter labeling
Workshop model card spacing
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The filter-label and spacing changes are bounded and covered by the updated tests, with no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17848 +/- ##
==========================================
- Coverage 82.60% 82.60% -0.01%
==========================================
Files 2848 2844 -4
Lines 142005 141937 -68
Branches 36527 36514 -13
==========================================
- Hits 117308 117240 -68
Misses 23489 23489
Partials 1208 1208
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
The catalogue ships one facet group, so the branch that names a filter with more than one was unreachable from the component and went uncovered. It is a rule about groups rather than about this menu, so it moves out with a case for each shape.
|
Closing this in favour of #19090, which is the same change rebuilt on current This branch is from 16 September. Since then The branch itself is left in place; nothing else depends on it. Generated by Claude Code |
Summary
The catalogue offers one facet, and the sheet hides a lone group's name, so the only label a reader gets is a button reading "Filter", which says nothing about what it filters by.
Changes
gap-3instead ofgap-2: at the old gap the two read as a single block.Review Focus
The rule lives next to the
groupslist it reads, so adding a facet is enough to restore the generic label. Nothing new is translated: the label already exists asworkshop.launch.label, in English and Simplified Chinese.workshop.filter.labelis untouched, so the Hub's own filter button keeps saying "Filter".Tests
WorkshopFilterMenu.test.tsandWorkshopModelsGrid.test.tsfind the trigger and the dialog by their accessible name, so they assert the new one; they fail if the label reverts.