Repository navigation
[backport core/1.55] fix(agent): omit redundant workflow name in bound run approvals (#19054) - #19086
Conversation
- omit the workflow label when a run approval targets the chat-bound workflow - retain the linked workflow label for cross-workflow and missing-binding cases - preserve the current `shown` lifecycle event added on `main` Replaces #18399 after that fork branch conflicted with `main`. Linear: PM-1307, PM-1316 - `pnpm test:unit src/workbench/extensions/agent/components/agent/message/AgentMessage.test.ts` (23 passed) - `pnpm typecheck` - ESLint and oxfmt on all five changed files - pre-push knip/fallow gate (five-file diff) Justification: The original author is performing a stale-branch recovery for a small, tested UI fix; if no independent approval arrives, merge will use the documented unreviewed-change path after CI is green.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2124 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 86006a8d8549789563ab6e6f9d45ede3dad4239d
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-27T08:11:37.953Z",
"gitSha": "31fd7536bdbeb867790604f939e2e5b29f78f581",
"branch": "backport-19054-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1997.671999999966,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.479000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.602,
"heapDeltaBytes": 8469852,
"heapUsedBytes": 76053644,
"domNodes": -258,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.296999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1999.3670000000066,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.059000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.0919999999999,
"heapDeltaBytes": -8836228,
"heapUsedBytes": 58859332,
"domNodes": -257,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.736,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1709.0910000000008,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.372,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 770.553,
"heapDeltaBytes": -6968652,
"heapUsedBytes": 60425292,
"domNodes": -258,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 152.674,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.8130000000083,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.763000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 777.193,
"heapDeltaBytes": 10115988,
"heapUsedBytes": 77674032,
"domNodes": -261,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 158.514,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1668.6919999999645,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.447000000000001,
"layouts": 6,
"layoutDurationMs": 0.972,
"taskDurationMs": 320.45,
"heapDeltaBytes": 3115152,
"heapUsedBytes": 70669564,
"domNodes": 79,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.96,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.5579999999854,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.831999999999999,
"layouts": 6,
"layoutDurationMs": 0.9029999999999999,
"taskDurationMs": 309.77,
"heapDeltaBytes": 3052948,
"heapUsedBytes": 70714264,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.820000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 625.4190000000222,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.947999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.868,
"heapDeltaBytes": 18915480,
"heapUsedBytes": 86664028,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 170.907,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 576.6390000000001,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.462,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.252,
"heapDeltaBytes": 18860316,
"heapUsedBytes": 86469696,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 164.265,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1226.1680000000297,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 902.1539999999999,
"heapDeltaBytes": -17161496,
"heapUsedBytes": 73146716,
"domNodes": -295,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 68.93999999999998,
"eventListeners": -217,
"totalBlockingTimeMs": 562,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1161.3029999999753,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 819.624,
"heapDeltaBytes": 35269872,
"heapUsedBytes": 105052020,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 68.96,
"eventListeners": 0,
"totalBlockingTimeMs": 556,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.5790000000102,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.526,
"heapDeltaBytes": 14643012,
"heapUsedBytes": 90972852,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.566,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.8170000000346,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.0370000000006,
"heapDeltaBytes": 14838372,
"heapUsedBytes": 90663792,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 154.12300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10902.238000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9916.72,
"heapDeltaBytes": 11356008,
"heapUsedBytes": 93612760,
"domNodes": -14,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 8240.205,
"eventListeners": 0,
"totalBlockingTimeMs": 1322,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10666.885999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9835.866000000002,
"heapDeltaBytes": 12181940,
"heapUsedBytes": 94260608,
"domNodes": -14,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 8197.401,
"eventListeners": 0,
"totalBlockingTimeMs": 1301,
"frameDurationMs": 18.89333333333331,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10361.08200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9506.265,
"heapDeltaBytes": 8577436,
"heapUsedBytes": 85227560,
"domNodes": -12,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 7909.122,
"eventListeners": 0,
"totalBlockingTimeMs": 994,
"frameDurationMs": 18.89333333333337,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10022.785999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9173.877,
"heapDeltaBytes": 10715664,
"heapUsedBytes": 92748848,
"domNodes": -14,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7586.606,
"eventListeners": 0,
"totalBlockingTimeMs": 946,
"frameDurationMs": 18.883333333333333,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "large-graph-idle",
"durationMs": 2031.9520000000466,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.038000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.407,
"heapDeltaBytes": -2620136,
"heapUsedBytes": 84040464,
"domNodes": -242,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 30.505000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2032.1219999999585,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.610000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.4639999999999,
"heapDeltaBytes": -4124060,
"heapUsedBytes": 83002348,
"domNodes": -240,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 36.52799999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2265.0659999999903,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.459000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1507.666,
"heapDeltaBytes": -2727532,
"heapUsedBytes": 84887972,
"domNodes": -242,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 884.1360000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2189.3029999999953,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.707,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1589.879,
"heapDeltaBytes": 15686644,
"heapUsedBytes": 80013492,
"domNodes": -248,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 834.176,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3492.8409999999985,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.777999999999999,
"layouts": 60,
"layoutDurationMs": 12.691,
"taskDurationMs": 1620.9940000000004,
"heapDeltaBytes": 8429328,
"heapUsedBytes": 74492508,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 773.539,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3468.4160000000475,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.687000000000001,
"layouts": 60,
"layoutDurationMs": 12.7,
"taskDurationMs": 1631.1390000000001,
"heapDeltaBytes": 7784236,
"heapUsedBytes": 73899904,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 782.8380000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3085.9520000000202,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.776,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1903.1159999999998,
"heapDeltaBytes": -3837336,
"heapUsedBytes": 86849040,
"domNodes": -253,
"jsHeapTotalBytes": 184320,
"scriptDurationMs": 959.98,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3057.788999999957,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.289000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1900.5100000000002,
"heapDeltaBytes": 20914032,
"heapUsedBytes": 87073360,
"domNodes": 6,
"jsHeapTotalBytes": 2252800,
"scriptDurationMs": 1004.3120000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.6480000000083,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.658999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.0870000000001,
"heapDeltaBytes": -4361264,
"heapUsedBytes": 84153580,
"domNodes": -246,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 30.252000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2041.8260000000146,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.146,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.208,
"heapDeltaBytes": -4493180,
"heapUsedBytes": 84148064,
"domNodes": -241,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 30.993999999999993,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 567.1090000000163,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.547,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.03599999999994,
"heapDeltaBytes": 14040600,
"heapUsedBytes": 83965164,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 139.72199999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 546.4450000000625,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.822,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.8229999999999,
"heapDeltaBytes": 13735876,
"heapUsedBytes": 83898160,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 141.477,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2020.4089999999724,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.498999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.57900000000006,
"heapDeltaBytes": -6540516,
"heapUsedBytes": 62383564,
"domNodes": -274,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.8359999999999985,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.5939999999364,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.418999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.968,
"heapDeltaBytes": 10883700,
"heapUsedBytes": 81014184,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.936000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1702.4190000000203,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.038,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 701.009,
"heapDeltaBytes": -7775400,
"heapUsedBytes": 62139212,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 103.14899999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.6560000000136,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.554999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 705.824,
"heapDeltaBytes": -4100996,
"heapUsedBytes": 59134608,
"domNodes": -277,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 100.58200000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.3229999999949,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.28499999999999,
"layouts": 5,
"layoutDurationMs": 13.228,
"taskDurationMs": 861.4099999999997,
"heapDeltaBytes": -8080308,
"heapUsedBytes": 82443056,
"domNodes": 13667,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 30.112000000000005,
"eventListeners": 2383,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8298.437999999976,
"styleRecalcs": 249,
"styleRecalcDurationMs": 34.187,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5579.215999999999,
"heapDeltaBytes": -6302260,
"heapUsedBytes": 80515704,
"domNodes": -244,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 2742.6719999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8277.445000000058,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.064,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5563.355,
"heapDeltaBytes": -6837868,
"heapUsedBytes": 80171044,
"domNodes": -247,
"jsHeapTotalBytes": -303104,
"scriptDurationMs": 2705.502,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16635.222999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15933.313000000002,
"heapDeltaBytes": -70244316,
"heapUsedBytes": 170786248,
"domNodes": -8061,
"jsHeapTotalBytes": -16977920,
"scriptDurationMs": 248.705,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16524.003000000106,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15793.549,
"heapDeltaBytes": -38223704,
"heapUsedBytes": 182089524,
"domNodes": -8061,
"jsHeapTotalBytes": -17195008,
"scriptDurationMs": 260.925,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20857.53799999998,
"styleRecalcs": 168,
"styleRecalcDurationMs": 17.022999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20431.713,
"heapDeltaBytes": -71349628,
"heapUsedBytes": 169093332,
"domNodes": -8061,
"jsHeapTotalBytes": -18677760,
"scriptDurationMs": 884.923,
"eventListeners": -14928,
"totalBlockingTimeMs": 24,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19837.026000000038,
"styleRecalcs": 168,
"styleRecalcDurationMs": 16.11399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19488.436,
"heapDeltaBytes": -56923600,
"heapUsedBytes": 180845980,
"domNodes": -8061,
"jsHeapTotalBytes": -14876672,
"scriptDurationMs": 864.634,
"eventListeners": -14928,
"totalBlockingTimeMs": 171,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6016.472000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.46700000000001,
"layouts": 20,
"layoutDurationMs": 23.208999999999993,
"taskDurationMs": 5912.764999999999,
"heapDeltaBytes": -48332512,
"heapUsedBytes": 179512196,
"domNodes": -8061,
"jsHeapTotalBytes": 7663616,
"scriptDurationMs": 105.41,
"eventListeners": -14928,
"totalBlockingTimeMs": 488,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6049.219999999991,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.90399999999997,
"layouts": 20,
"layoutDurationMs": 22.347000000000005,
"taskDurationMs": 5906.781,
"heapDeltaBytes": -42592812,
"heapUsedBytes": 195142000,
"domNodes": -8061,
"jsHeapTotalBytes": 13434880,
"scriptDurationMs": 101.45599999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 352,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8364.940000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8151.103999999998,
"heapDeltaBytes": 6389516,
"heapUsedBytes": 190652168,
"domNodes": 0,
"jsHeapTotalBytes": -9961472,
"scriptDurationMs": 127.247,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8298.271999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8039.7119999999995,
"heapDeltaBytes": 1819804,
"heapUsedBytes": 193365764,
"domNodes": -3,
"jsHeapTotalBytes": -9175040,
"scriptDurationMs": 120.133,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 467.94900000008965,
"styleRecalcs": 21,
"styleRecalcDurationMs": 24.132,
"layouts": 5,
"layoutDurationMs": 2.0529999999999995,
"taskDurationMs": 124.83300000000003,
"heapDeltaBytes": 5314392,
"heapUsedBytes": 70823592,
"domNodes": 153,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.870000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 465.7479999999623,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.513,
"layouts": 4,
"layoutDurationMs": 1.693,
"taskDurationMs": 119.66200000000002,
"heapDeltaBytes": 4989240,
"heapUsedBytes": 70496828,
"domNodes": 148,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.264,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.55 #19086 +/- ##
=============================================
+ Coverage 84.60% 84.61% +0.01%
=============================================
Files 2298 2299 +1
Lines 131671 131794 +123
Branches 35560 33707 -1853
=============================================
+ Hits 111403 111523 +120
+ Misses 19954 19952 -2
- Partials 314 319 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified the reduced scope rather than taking the description's word for it — 5 files against #19054's 8 is the kind of gap that is usually a broken backport, and here it is not:
agentReplyDrafts.spec.tsandagentRunApprovalConsent.spec.ts— confirmed absent from both 1.55 branches, so there is nothing to port.AgentPanelRoot.test.ts— #19054's only hunk there is a single-line deletion insidedescribe('AgentPanelRoot run approval telemetry'). That feature has 9 references onmainand 0 on core/1.55 and cloud/1.55, so the describe block does not exist here and the file correctly ends up unchanged.
No conflict markers. All three required checks green.
…nd run approvals (#19054) (#19087) Backport of #19054 to `cloud/1.55`. Same conflict/resolution as #19086 (the core/1.55 backport): `cloud/1.55` also lacks the same unrelated, unbackported pieces that sat as context around #19054's real diff in the merge-commit patch — the two Playwright spec files don't exist here, the `AgentPanelRoot run approval telemetry` test belongs to a separate unbackported telemetry feature, and the import conflict pulled in an unused `onMounted`. Resolved the same way. Net result matches the actual scope of #19054: `RunApprovalCard.vue`, `AgentPanelRoot.vue`, `AgentMessage.test.ts`, `agentBoundWorkflowId.ts` (new), `src/locales/en/main.json`. Verified on this branch: - `pnpm exec vitest run src/workbench/extensions/agent/components/agent/message/AgentMessage.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts` — 281 passed - `pnpm exec vue-tsc --noEmit` — clean - lint-staged (oxfmt/oxlint/eslint/stylelint) via commit hook — clean <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789700733927729?thread_ts=1789700733.927729&cid=C0BGH348Z0C)_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1 --- _Generated by [Claude Code](https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1)_ Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Backport of #19054 to
core/1.55.The automated backport hit conflicts because
core/1.55lacks several unrelated, unbackported pieces that sat as unchanged context around #19054's actual diff in the merge-commit patch:browser_tests/tests/agent/agentReplyDrafts.spec.tsandagentRunApprovalConsent.spec.tsdon't exist oncore/1.55at all (dropped from this backport — not a prerequisite for the runtime fix).AgentPanelRoot run approval telemetrydescribe block (one test) belongs to a separate, unbackported run-approval-telemetry feature (trackAgentRunApprovalShown/trackAgentRunApprovalResolveddon't exist anywhere in this branch's runtime code) — dropped, soAgentPanelRoot.test.tsends up unchanged.RunApprovalCard.vue's import conflict pulled in an unusedonMountedfrom an unrelated unbackported feature — removed it, kept onlyinject/refwhich this fix needs.Net result matches the actual scope of #19054:
RunApprovalCard.vue,AgentPanelRoot.vue,AgentMessage.test.ts,agentBoundWorkflowId.ts(new),src/locales/en/main.json.Verified on this branch:
pnpm exec vitest run src/workbench/extensions/agent/components/agent/message/AgentMessage.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts— 281 passedpnpm exec vue-tsc --noEmit— cleanRequested by Christian Byrne · Slack thread
🤖 Generated with Claude Code
https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1
Generated by Claude Code