Repository navigation
[backport cloud/1.55] fix(agent): omit redundant workflow name in bound run approvals (#19054) - #19087
Conversation
- omit the workflow label when a run approval targets the chat-bound workflow - retain the linked workflow label for cross-workflow and missing-binding cases - preserve the current `shown` lifecycle event added on `main` Replaces #18399 after that fork branch conflicted with `main`. Linear: PM-1307, PM-1316 - `pnpm test:unit src/workbench/extensions/agent/components/agent/message/AgentMessage.test.ts` (23 passed) - `pnpm typecheck` - ESLint and oxfmt on all five changed files - pre-push knip/fallow gate (five-file diff) Justification: The original author is performing a stale-branch recovery for a small, tested UI fix; if no independent approval arrives, merge will use the documented unreviewed-change path after CI is green.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2124 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since efb3ebdae5e9c5084ee218122a756fe26502745a
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-27T08:15:55.234Z",
"gitSha": "8bcf69822bd236a897f9ce1fcea2839178a80cbf",
"branch": "backport-19054-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.8870000000197,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.343,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.63800000000003,
"heapDeltaBytes": 7199568,
"heapUsedBytes": 75024904,
"domNodes": -260,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.700000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2019.8540000000094,
"styleRecalcs": 14,
"styleRecalcDurationMs": 6.555,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 342.25,
"heapDeltaBytes": -2786116,
"heapUsedBytes": 64138596,
"domNodes": -253,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.214999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1689.7010000000137,
"styleRecalcs": 48,
"styleRecalcDurationMs": 13.381,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 608.413,
"heapDeltaBytes": -8956204,
"heapUsedBytes": 59129204,
"domNodes": -256,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 106.663,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1668.9380000000256,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.931,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.987,
"heapDeltaBytes": 13745616,
"heapUsedBytes": 81329992,
"domNodes": -257,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 90.67800000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.5419999999795,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.146999999999998,
"layouts": 6,
"layoutDurationMs": 1.2169999999999999,
"taskDurationMs": 234.196,
"heapDeltaBytes": 3143924,
"heapUsedBytes": 70719184,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.963,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.8159999999934,
"styleRecalcs": 30,
"styleRecalcDurationMs": 9.682000000000002,
"layouts": 6,
"layoutDurationMs": 1.0669999999999997,
"taskDurationMs": 235.31699999999998,
"heapDeltaBytes": 2170284,
"heapUsedBytes": 64741688,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.945,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 523.6489999999776,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.074000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 321.31699999999995,
"heapDeltaBytes": 18919268,
"heapUsedBytes": 86774348,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 112.569,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 503.77400000002126,
"styleRecalcs": 14,
"styleRecalcDurationMs": 6.657000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 321.531,
"heapDeltaBytes": 18942140,
"heapUsedBytes": 86406652,
"domNodes": 23,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 115.101,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 964.3859999999904,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.547,
"heapDeltaBytes": 35424896,
"heapUsedBytes": 101947840,
"domNodes": 0,
"jsHeapTotalBytes": 18247680,
"scriptDurationMs": 43.348,
"eventListeners": 0,
"totalBlockingTimeMs": 363,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 987.4639999999317,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.4450000000002,
"heapDeltaBytes": -17634672,
"heapUsedBytes": 72846840,
"domNodes": -294,
"jsHeapTotalBytes": 18743296,
"scriptDurationMs": 42.088,
"eventListeners": -217,
"totalBlockingTimeMs": 360,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 699.2040000000088,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 292.3060000000004,
"heapDeltaBytes": 14762668,
"heapUsedBytes": 91702624,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 91.13799999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 99,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 700.6329999999252,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 291.75600000000037,
"heapDeltaBytes": 14447604,
"heapUsedBytes": 90218280,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 96.694,
"eventListeners": 0,
"totalBlockingTimeMs": 98,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6561.028999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5670.187,
"heapDeltaBytes": -1772016,
"heapUsedBytes": 81408304,
"domNodes": -4,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 4327.965,
"eventListeners": 0,
"totalBlockingTimeMs": 50,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5934.177000000091,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.12699999999999864,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5047.029,
"heapDeltaBytes": 27367460,
"heapUsedBytes": 101433556,
"domNodes": 2,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 3906.013,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6636.278000000004,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.623000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5774.787,
"heapDeltaBytes": 11309024,
"heapUsedBytes": 93411300,
"domNodes": -14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 4435.647,
"eventListeners": 0,
"totalBlockingTimeMs": 91,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.20000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6243.1759999999485,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06699999999999762,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5444.782999999999,
"heapDeltaBytes": -3667676,
"heapUsedBytes": 70480748,
"domNodes": 2,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 4200.988,
"eventListeners": 0,
"totalBlockingTimeMs": 29,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.20000000000073
},
{
"name": "large-graph-idle",
"durationMs": 2011.191999999994,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.723999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.968,
"heapDeltaBytes": -3938080,
"heapUsedBytes": 83489136,
"domNodes": -240,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 26.607,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.860000000027,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.925,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.9869999999999,
"heapDeltaBytes": -8104288,
"heapUsedBytes": 79817972,
"domNodes": -240,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 28.912999999999993,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2124.1580000000226,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.306000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1106.1190000000001,
"heapDeltaBytes": -6607756,
"heapUsedBytes": 80497864,
"domNodes": -238,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 577.5409999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2126.512000000048,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.181000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1095.076,
"heapDeltaBytes": -13365852,
"heapUsedBytes": 68675532,
"domNodes": -205,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 523.1629999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3145.2239999999847,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.269999999999998,
"layouts": 60,
"layoutDurationMs": 12.043,
"taskDurationMs": 1285.523,
"heapDeltaBytes": -21443964,
"heapUsedBytes": 68470592,
"domNodes": -261,
"jsHeapTotalBytes": 6320128,
"scriptDurationMs": 545.914,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3068.3789999999362,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.788,
"layouts": 60,
"layoutDurationMs": 11.693,
"taskDurationMs": 1186.079,
"heapDeltaBytes": -15872508,
"heapUsedBytes": 73754840,
"domNodes": -240,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 502.66999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2172.3199999999565,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.293,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1394.1779999999999,
"heapDeltaBytes": -9080644,
"heapUsedBytes": 82482884,
"domNodes": -244,
"jsHeapTotalBytes": -77824,
"scriptDurationMs": 657.4749999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2174.1109999999253,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.472000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1203.198,
"heapDeltaBytes": 17532396,
"heapUsedBytes": 83090996,
"domNodes": 12,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 592.583,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2019.5260000000417,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.339,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.553,
"heapDeltaBytes": -8669936,
"heapUsedBytes": 79424216,
"domNodes": -244,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 26.193999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.0430000001106,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.397999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.73599999999993,
"heapDeltaBytes": -7999612,
"heapUsedBytes": 80403788,
"domNodes": -249,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 28.338999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 427.2760000000062,
"styleRecalcs": 50,
"styleRecalcDurationMs": 8.773000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 279.62,
"heapDeltaBytes": 13723828,
"heapUsedBytes": 83614644,
"domNodes": 25,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 94.063,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 415.25000000001455,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.751000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 284.32500000000005,
"heapDeltaBytes": 14049820,
"heapUsedBytes": 83948364,
"domNodes": 23,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 96.374,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1992.9659999999672,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.690999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.36100000000005,
"heapDeltaBytes": -8093072,
"heapUsedBytes": 62137904,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.364999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.706000000022,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.0710000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.82500000000005,
"heapDeltaBytes": -2681208,
"heapUsedBytes": 60597100,
"domNodes": -274,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 6.085999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.0610000000138,
"styleRecalcs": 45,
"styleRecalcDurationMs": 12.18,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.596,
"heapDeltaBytes": -4464548,
"heapUsedBytes": 58732820,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 79.183,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.2600000000994,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.031999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.729,
"heapDeltaBytes": -9935612,
"heapUsedBytes": 60058908,
"domNodes": -274,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 67.44500000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 849.3570000000545,
"styleRecalcs": 17,
"styleRecalcDurationMs": 19.48400000000001,
"layouts": 5,
"layoutDurationMs": 7.616,
"taskDurationMs": 608.089,
"heapDeltaBytes": 21639428,
"heapUsedBytes": 103662968,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 20.163999999999994,
"eventListeners": 2383,
"totalBlockingTimeMs": 92,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8141.542999999956,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.550999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3928.5909999999994,
"heapDeltaBytes": -6292324,
"heapUsedBytes": 80791832,
"domNodes": -211,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 1806.5090000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8170.9959999999455,
"styleRecalcs": 251,
"styleRecalcDurationMs": 32.72299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3527.02,
"heapDeltaBytes": -13357200,
"heapUsedBytes": 68006048,
"domNodes": -235,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 1772.602,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10638.705999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9739.826000000001,
"heapDeltaBytes": -55628432,
"heapUsedBytes": 166116696,
"domNodes": -8063,
"jsHeapTotalBytes": -13701120,
"scriptDurationMs": 147.751,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11505.900999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10639.630000000001,
"heapDeltaBytes": -39047724,
"heapUsedBytes": 182916892,
"domNodes": -8062,
"jsHeapTotalBytes": -6873088,
"scriptDurationMs": 159.805,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13990.98700000002,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.207999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13282.215,
"heapDeltaBytes": -46320200,
"heapUsedBytes": 174271240,
"domNodes": -8062,
"jsHeapTotalBytes": -11862016,
"scriptDurationMs": 657.378,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14032.996000000025,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.278000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13400.286000000002,
"heapDeltaBytes": -60542060,
"heapUsedBytes": 180474696,
"domNodes": -8062,
"jsHeapTotalBytes": -21958656,
"scriptDurationMs": 726.347,
"eventListeners": -14928,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3916.3070000000744,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.867,
"layouts": 20,
"layoutDurationMs": 28.063000000000006,
"taskDurationMs": 3787.637,
"heapDeltaBytes": -44747036,
"heapUsedBytes": 170167100,
"domNodes": -8062,
"jsHeapTotalBytes": 11726848,
"scriptDurationMs": 61.68600000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 95,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3773.8130000000183,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.63900000000001,
"layouts": 20,
"layoutDurationMs": 26.088,
"taskDurationMs": 3607.6730000000002,
"heapDeltaBytes": -32629976,
"heapUsedBytes": 189304896,
"domNodes": -8067,
"jsHeapTotalBytes": 11739136,
"scriptDurationMs": 73.481,
"eventListeners": -14928,
"totalBlockingTimeMs": 96,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5884.128000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5342.102000000001,
"heapDeltaBytes": 7119100,
"heapUsedBytes": 193907116,
"domNodes": 0,
"jsHeapTotalBytes": -22544384,
"scriptDurationMs": 78.60499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5725.397000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5313.727,
"heapDeltaBytes": 9176436,
"heapUsedBytes": 189993196,
"domNodes": 0,
"jsHeapTotalBytes": -22282240,
"scriptDurationMs": 72.08500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 442.00100000000475,
"styleRecalcs": 25,
"styleRecalcDurationMs": 20.101,
"layouts": 4,
"layoutDurationMs": 2.027,
"taskDurationMs": 113.744,
"heapDeltaBytes": 5161096,
"heapUsedBytes": 70623252,
"domNodes": 158,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.629000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 439.27099999996244,
"styleRecalcs": 13,
"styleRecalcDurationMs": 16.072999999999997,
"layouts": 3,
"layoutDurationMs": 1.016,
"taskDurationMs": 93.757,
"heapDeltaBytes": 4789136,
"heapUsedBytes": 70393904,
"domNodes": 121,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.398,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #19087 +/- ##
=============================================
Coverage ? 84.61%
=============================================
Files ? 2299
Lines ? 131871
Branches ? 35628
=============================================
Hits ? 111582
Misses ? 19970
Partials ? 319
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified the reduced scope rather than taking the description's word for it — 5 files against #19054's 8 is the kind of gap that is usually a broken backport, and here it is not:
agentReplyDrafts.spec.tsandagentRunApprovalConsent.spec.ts— confirmed absent from both 1.55 branches, so there is nothing to port.AgentPanelRoot.test.ts— #19054's only hunk there is a single-line deletion insidedescribe('AgentPanelRoot run approval telemetry'). That feature has 9 references onmainand 0 on core/1.55 and cloud/1.55, so the describe block does not exist here and the file correctly ends up unchanged.
No conflict markers. All three required checks green.
Backport of #19054 to
cloud/1.55.Same conflict/resolution as #19086 (the core/1.55 backport):
cloud/1.55also lacks the same unrelated, unbackported pieces that sat as context around #19054's real diff in the merge-commit patch — the two Playwright spec files don't exist here, theAgentPanelRoot run approval telemetrytest belongs to a separate unbackported telemetry feature, and the import conflict pulled in an unusedonMounted. Resolved the same way.Net result matches the actual scope of #19054:
RunApprovalCard.vue,AgentPanelRoot.vue,AgentMessage.test.ts,agentBoundWorkflowId.ts(new),src/locales/en/main.json.Verified on this branch:
pnpm exec vitest run src/workbench/extensions/agent/components/agent/message/AgentMessage.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts— 281 passedpnpm exec vue-tsc --noEmit— cleanRequested by Christian Byrne · Slack thread
🤖 Generated with Claude Code
https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1
Generated by Claude Code