Repository navigation
feat(website): the workflow playground takes the V2 input panel - #19029
mariana953 wants to merge 6 commits into
Conversation
The panel that asks the questions now reads as the V2 design draws it: a headed box beside the output, the fields, and one run control at the bottom of it. The title and hint above the fields, the billing line and the second way out are gone from there; Try in Cloud and the download already sit together on the Details tab, which is where the design puts the ways out. The tabs take the same weight and case as the rest of the page.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌐 Website E2ETip All tests passed.
📦 Bundle Size
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since deec3d7313336ca14b343cb28cc5a13a42a57006
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19029.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-knzyeiofv-comfyui.vercel.app Last updated: 2026-09-27T10:00:28Z for |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe workshop playground receives a revised input and results layout, updated tab styling, and larger run controls. The tests now check for the “Try in Cloud” link on the Workflow tab and its absence from the Playground tab panel. ChangesWorkshop playground
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~12 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The Cloud link and workflow download remain available in the Workflow tab, while the Playground tab has the intended simplified input panel. No concrete merge-blocking regression was found. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## mariana/v2-workflow-graph #19029 +/- ##
=============================================================
- Coverage 84.00% 84.00% -0.01%
=============================================================
Files 3126 3126
Lines 153780 153778 -2
Branches 41754 41753 -1
=============================================================
- Hits 129185 129183 -2
Misses 22997 22997
Partials 1598 1598
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…mariana/v2-workflow-form # Conflicts: # apps/website/e2e/workshop-workflows.spec.ts
The Hub branches in this stack and main's new Cloud API pricing copy each stay under the old 1.81MB ceiling on their own; measured together here the route totals 1,810,629 bytes. The growth sits in chunks the homepage loads as well — site-wide copy rather than catalogue code — and the catalogue's own 900kB delta ceiling is untouched, so a catalogue regression still fails this test.
|
It is not catalogue code. The same test's catalogue-only delta passed, well inside its 900 kB ceiling; what grew are chunks the homepage requests too, i.e. site-wide copy. Apart, this branch's base and today's 49b48a9 raises the whole-route ceiling to 1.82 MB: the same move and the same 10 kB step as #17971 (1.80 → 1.81). The catalogue delta ceiling stays at 900 kB, so catalogue code migrating into a shared chunk still fails this test. If you would rather the ceiling held and the copy paid for itself, the route to it is splitting Generated by Claude Code |
Behaviour fixes from reviewing Mar's Hub V2 PRs together. No CSS, layout or copy changes to her design. - Details graph (#19010): zoom and Reset respond to mouse and touch (pointer capture no longer swallows their clicks); zoom scales about the drawing's centre instead of carrying it off-frame; drag follows the pointer in drawing units; phones can scroll the page past the graph; the graph JSON is fetched when Details first opens, not on every page view. - Graph reader (#19009): subgraph nodes are titled with the subgraph's name instead of its UUID; unlinked widget inputs are no longer drawn as sockets; links find their socket by saved index. - Filter chips (#18979): Clear on "Browse all models" keeps you in the full list; removing a chip keeps keyboard focus in the chip row, then returns it to the filter button; tests follow #19090's renamed button. - Run panel (#19005): a request that never ran no longer says it may still be billed or have taken credits. - Drop three translation keys #19029 left unused.
…te PRs (#19255) ## Summary Mar's Hub V2, staged as one reviewable phase. This combines the 23 PRs from her [#proj-comfy-hub post](https://comfy-organization.slack.com/archives/C0AEPRS8N74/p1790528696016959), including the latest head of #19004, while preserving her presentation and commit history. Review fixes remain isolated in #19256 above this PR. Design reference (not for review): #17804 · [V2 Hub preview](https://comfy-website-preview-pr-17804.vercel.app/hub/) ## Included **Independent:** #19031 Hub not Models · #18916 search with filter and sort · #18915 shorter workflows banner · #18979 filter chips · #19012 one "browse all" · #19016 shelf stops promising more · #18987 home hub workflows tab · #19025 Apps tab · #19090 filter named after what it filters · #19017 phone video controls · #19011 API tab endpoint · #19014 workflow header **Catalogue cards:** #18921 → #19015 **Workflow page V2:** #19009 → #19004 → #19008 → #19010 → #19029 **Run states:** #19005 → #19006 → #19007 → #19022 ## Integration with current main - Rebases the phase onto current `main`, including the canonical `/models/apps/<slug>/` routes and the separate Apps feature flag. - Keeps Mar's Apps shelf and card presentation while sourcing its entries and links from the canonical app catalogue. - Keeps Apps gated by `workshop-apps-enabled`; Workflows remain gated independently by `workshop-workflows-enabled`. - Keeps Mar's latest #19004 Details cleanup and single template-author attribution while retaining the later interactive graph work in #19008/#19010. - Resolves the combined `/models/` JavaScript budget to 1,820,000 bytes. ## Not included - #19241 (API tab rail): conflicts with #19011 and still needs a design call. - #19227 (draft), #17865 and #18306: not part of the Hub V2 set. ## Verification - Full website unit suite: 9,494 passed, 4 skipped. - Focused post-rebase app/catalogue suite: 98 passed. - Website typecheck: 0 errors. - Commit and push checks: formatting, lint, app/website typechecks, knip and Fallow passed. - `workshop-workflows-enabled` gates the home tab, catalogue tab, direct `?type=` URLs and detail pages without flashing gated content. --------- Co-authored-by: Mariana Martinho <mariana@comfy.org> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: github-actions <github-actions@github.com>
Behaviour fixes from reviewing Mar's Hub V2 PRs together. No CSS, layout or copy changes to her design. - Details graph (#19010): zoom and Reset respond to mouse and touch (pointer capture no longer swallows their clicks); zoom scales about the drawing's centre instead of carrying it off-frame; drag follows the pointer in drawing units; phones can scroll the page past the graph; the graph JSON is fetched when Details first opens, not on every page view. - Graph reader (#19009): subgraph nodes are titled with the subgraph's name instead of its UUID; unlinked widget inputs are no longer drawn as sockets; links find their socket by saved index. - Filter chips (#18979): Clear on "Browse all models" keeps you in the full list; removing a chip keeps keyboard focus in the chip row, then returns it to the filter button; tests follow #19090's renamed button. - Run panel (#19005): a request that never ran no longer says it may still be billed or have taken credits. - Drop three translation keys #19029 left unused.
Summary
The input panel on a workflow page now reads the way the V2 design draws it, rather than the way the model page happened to.
Changes
Inputbar, the fields, and one run control pinned at the bottom of it. TheMake it yourstitle and its hint above the fields are gone, and so is the billing line under them.Try in Cloudleaves the form. The ways out —Try in Cloudand the workflow download — already sit together in the Details rail, which is where the design puts them, so keeping a second copy next to Run split the same decision across two tabs.e2e/models-performance.spec.tsraises the/models/whole-route script ceiling from 1.81 MB to 1.82 MB. The route measured 1,810,629 bytes once this branch carried both its base and today'smain; each of those stays under the old ceiling on its own, and the growth is in chunks the homepage loads too — site-wide copy, not catalogue code. The catalogue-only delta ceiling is untouched at 900 kB. Same move and step as test(website): raise models catalogue JS budget to 1.81MB #17971.Review Focus
e2e/workshop-workflows.spec.tsnow asserts theTry in Cloudaddress after opening that tab rather than from the playground, which is where the link now lives.translations.tsper route, which is larger than this PR.mainin this environment.Screenshots (if applicable)
Before, the panel opened with a title and a hint, closed with a billing line, a Run control and a second
Try in Cloud, and stopped where its fields did. After, it is theInputbar, the field, andSign in to runat the bottom of a box the height of the output beside it.