Skip to content

feat(website): the workflow playground takes the V2 input panel - #19029

Closed
mariana953 wants to merge 6 commits into
mariana/v2-workflow-graphfrom
mariana/v2-workflow-form
Closed

mariana953 wants to merge 6 commits into
mariana/v2-workflow-graphfrom
mariana/v2-workflow-form

Conversation

@mariana953

@mariana953 mariana953 commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The input panel on a workflow page now reads the way the V2 design draws it, rather than the way the model page happened to.

Changes

  • What:
    • The panel is a headed box beside the output: an Input bar, the fields, and one run control pinned at the bottom of it. The Make it yours title and its hint above the fields are gone, and so is the billing line under them.
    • Try in Cloud leaves the form. The ways out — Try in Cloud and the workflow download — already sit together in the Details rail, which is where the design puts them, so keeping a second copy next to Run split the same decision across two tabs.
    • The two columns split five to seven and share a height, as the design has them, instead of two to three with the input box ending wherever its fields do.
    • The tabs take the same weight and case as the rest of the page's section headings.
    • The sign-in and run controls are the shared button at its large size, so the one action in the panel is one shape rather than a hand-rolled link beside a button.
    • e2e/models-performance.spec.ts raises the /models/ whole-route script ceiling from 1.81 MB to 1.82 MB. The route measured 1,810,629 bytes once this branch carried both its base and today's main; each of those stays under the old ceiling on its own, and the growth is in chunks the homepage loads too — site-wide copy, not catalogue code. The catalogue-only delta ceiling is untouched at 900 kB. Same move and step as test(website): raise models catalogue JS budget to 1.81MB #17971.

Review Focus

  • The Details tab keeps both ways out; e2e/workshop-workflows.spec.ts now asserts the Try in Cloud address after opening that tab rather than from the playground, which is where the link now lives.
  • New component test: the playground panel heads its questions and holds no way out, which fails on both counts before this change.
  • Nothing about running, uploading, polling or cancelling moves: the run control is the same component with the same props.
  • The raised route ceiling is the one judgement call here — if you would rather it held, the alternative is splitting translations.ts per route, which is larger than this PR.
  • The full website unit suite passes (9249), apart from the three IndexedDB draft tests that fail the same way on a clean checkout of main in this environment.

Screenshots (if applicable)

Before, the panel opened with a title and a hint, closed with a billing line, a Run control and a second Try in Cloud, and stopped where its fields did. After, it is the Input bar, the field, and Sign in to run at the bottom of a box the height of the output beside it.

The panel that asks the questions now reads as the V2 design draws it: a headed box beside the output, the fields, and one run control at the bottom of it. The title and hint above the fields, the billing line and the second way out are gone from there; Try in Cloud and the download already sit together on the Details tab, which is where the design puts the ways out. The tabs take the same weight and case as the rest of the page.
@mariana953
mariana953 requested review from a team September 27, 2026 00:26
@vercel

vercel Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 27, 2026 9:58am UTC
billing-web-test Skipped Skipped Sep 27, 2026 9:58am UTC

Request Review

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

📦 Bundle Size

⏳ Size data collection in progress…

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since deec3d7313336ca14b343cb28cc5a13a42a57006

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-19029.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-knzyeiofv-comfyui.vercel.app

Last updated: 2026-09-27T10:00:28Z for 05c389e

@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 4c03a749-956b-47ab-a113-67fadf12e3a0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a05c370d-7faa-4edd-8c23-27c1d5e14293

📥 Commits

Reviewing files that changed from the base of the PR and between 2ea640a and b61d54b.

📒 Files selected for processing (4)
  • apps/website/e2e/workshop-workflows.spec.ts
  • apps/website/src/components/workshop/WorkflowPlayground.test.ts
  • apps/website/src/components/workshop/WorkflowPlayground.vue
  • apps/website/src/components/workshop/WorkflowRunControls.vue

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review.


📝 Walkthrough

Walkthrough

The workshop playground receives a revised input and results layout, updated tab styling, and larger run controls. The tests now check for the “Try in Cloud” link on the Workflow tab and its absence from the Playground tab panel.

Changes

Workshop playground

Layer / File(s) Summary
Playground layout, controls, and validation
apps/website/src/components/workshop/WorkflowPlayground.vue, apps/website/src/components/workshop/WorkflowRunControls.vue, apps/website/src/components/workshop/WorkflowPlayground.test.ts, apps/website/e2e/workshop-workflows.spec.ts
The playground uses a bordered input panel and a 12-column layout, with results spanning seven columns on large screens. The shared Button component renders the sign-in link, and the signed-in submit button uses large sizing. Tests check tab-specific cloud-link behavior.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Feature

Suggested reviewers: benjcooley

Merge Risk: ⚪ Minimal · up to b61d5

The Cloud link and workflow download remain available in the Workflow tab, while the Playground tab has the intended simplified input panel. No concrete merge-blocking regression was found.

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed The PR title and commit subject use feat, not bug-fix language. The changed files are exclusively under apps/website, which this check excludes from the browser_tests/ requirement.
Website End-To-End Regression Coverage ✅ Passed The PR changes website runtime behavior in WorkflowPlayground.vue and WorkflowRunControls.vue. It also updates apps/website/e2e/workshop-workflows.spec.ts to open the tab that now contains `Try …
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed files are limited to apps/website/... workflow playground and test files. None are under src/lib/litegraph/, src/ecs/, or graph-entity-related paths. The ADR compliance check is ther…
Title check ✅ Passed The title clearly and concisely describes the main change: updating the workflow playground to use the V2 input panel.
Description check ✅ Passed The description includes the required Summary, Changes, Review Focus, and Screenshots sections. It explains the UI changes, test coverage, unchanged behavior, and route budget adjustment. No critical …
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                      Coverage Diff                      @@
##           mariana/v2-workflow-graph   #19029      +/-   ##
=============================================================
- Coverage                      84.00%   84.00%   -0.01%     
=============================================================
  Files                           3126     3126              
  Lines                         153780   153778       -2     
  Branches                       41754    41753       -1     
=============================================================
- Hits                          129185   129183       -2     
  Misses                         22997    22997              
  Partials                        1598     1598              
Flag Coverage Δ
website-unit 77.95% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ite/src/components/workshop/WorkflowPlayground.vue 59.13% <100.00%> (-1.28%) ⬇️
...te/src/components/workshop/WorkflowRunControls.vue 31.25% <100.00%> (+2.21%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 27, 2026
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 27, 2026
…mariana/v2-workflow-form

# Conflicts:
#	apps/website/e2e/workshop-workflows.spec.ts
@mariana953
mariana953 changed the base branch from main to mariana/v2-workflow-graph September 27, 2026 09:14
@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 27, 2026 09:14 Inactive
The Hub branches in this stack and main's new Cloud API pricing copy each
stay under the old 1.81MB ceiling on their own; measured together here the
route totals 1,810,629 bytes. The growth sits in chunks the homepage loads
as well — site-wide copy rather than catalogue code — and the catalogue's
own 900kB delta ceiling is untouched, so a catalogue regression still fails
this test.
@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 27, 2026 09:44 Inactive

Copy link
Copy Markdown
Contributor Author

website-e2e was red on the previous head for one assertion, and it is worth a second pair of eyes because the fix moves a ceiling.

e2e/models-performance.spec.ts measured the /models/ route's whole-page script total at 1,810,629 bytes against a 1,810,000 ceiling — 629 bytes, 0.03% over, identical on all three attempts, so not a flake.

It is not catalogue code. The same test's catalogue-only delta passed, well inside its 900 kB ceiling; what grew are chunks the homepage requests too, i.e. site-wide copy. Apart, this branch's base and today's main each stay under the old ceiling — main added 16 strings with the Cloud API pricing copy (#18523), this stack added its own — and it is the sum that crosses it.

49b48a9 raises the whole-route ceiling to 1.82 MB: the same move and the same 10 kB step as #17971 (1.80 → 1.81). The catalogue delta ceiling stays at 900 kB, so catalogue code migrating into a shared chunk still fails this test.

If you would rather the ceiling held and the copy paid for itself, the route to it is splitting translations.ts per route so /models/ stops carrying the pricing and workflow strings. That is a larger change than this PR, so I have not done it here.


Generated by Claude Code

@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 27, 2026 09:56 Inactive
@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 27, 2026 09:58 Inactive
benjcooley added a commit that referenced this pull request Sep 28, 2026
#18979's chip tests open the filter by the name 'Filter', which #19090
renames to its only group ('Use cases'). Each JS budget bump was sized
for one PR; together the /models/ scripts measure 1,816,095 bytes, so
the budget moves to 1,820,000 as #19008, #19010 and #19029 set it.
benjcooley added a commit that referenced this pull request Sep 28, 2026
Behaviour fixes from reviewing Mar's Hub V2 PRs together. No CSS, layout
or copy changes to her design.

- Details graph (#19010): zoom and Reset respond to mouse and touch
  (pointer capture no longer swallows their clicks); zoom scales about
  the drawing's centre instead of carrying it off-frame; drag follows
  the pointer in drawing units; phones can scroll the page past the
  graph; the graph JSON is fetched when Details first opens, not on
  every page view.
- Graph reader (#19009): subgraph nodes are titled with the subgraph's
  name instead of its UUID; unlinked widget inputs are no longer drawn
  as sockets; links find their socket by saved index.
- Filter chips (#18979): Clear on "Browse all models" keeps you in the
  full list; removing a chip keeps keyboard focus in the chip row, then
  returns it to the filter button; tests follow #19090's renamed button.
- Run panel (#19005): a request that never ran no longer says it may
  still be billed or have taken credits.
- Drop three translation keys #19029 left unused.
@benjcooley

Copy link
Copy Markdown
Collaborator

This head is fully contained in #19255, where Mar's Hub V2 work is being staged and reviewed together. Closing this intermediate PR in favor of the combined phase; review fixes are isolated in #19256.

@benjcooley benjcooley closed this Sep 28, 2026
benjcooley added a commit that referenced this pull request Sep 28, 2026
…te PRs (#19255)

## Summary

Mar's Hub V2, staged as one reviewable phase. This combines the 23 PRs
from her [#proj-comfy-hub
post](https://comfy-organization.slack.com/archives/C0AEPRS8N74/p1790528696016959),
including the latest head of #19004, while preserving her presentation
and commit history. Review fixes remain isolated in #19256 above this
PR.

Design reference (not for review): #17804 · [V2 Hub
preview](https://comfy-website-preview-pr-17804.vercel.app/hub/)

## Included

**Independent:** #19031 Hub not Models · #18916 search with filter and
sort · #18915 shorter workflows banner · #18979 filter chips · #19012
one "browse all" · #19016 shelf stops promising more · #18987 home hub
workflows tab · #19025 Apps tab · #19090 filter named after what it
filters · #19017 phone video controls · #19011 API tab endpoint · #19014
workflow header

**Catalogue cards:** #18921 → #19015

**Workflow page V2:** #19009 → #19004 → #19008 → #19010 → #19029

**Run states:** #19005 → #19006 → #19007 → #19022

## Integration with current main

- Rebases the phase onto current `main`, including the canonical
`/models/apps/<slug>/` routes and the separate Apps feature flag.
- Keeps Mar's Apps shelf and card presentation while sourcing its
entries and links from the canonical app catalogue.
- Keeps Apps gated by `workshop-apps-enabled`; Workflows remain gated
independently by `workshop-workflows-enabled`.
- Keeps Mar's latest #19004 Details cleanup and single template-author
attribution while retaining the later interactive graph work in
#19008/#19010.
- Resolves the combined `/models/` JavaScript budget to 1,820,000 bytes.

## Not included

- #19241 (API tab rail): conflicts with #19011 and still needs a design
call.
- #19227 (draft), #17865 and #18306: not part of the Hub V2 set.

## Verification

- Full website unit suite: 9,494 passed, 4 skipped.
- Focused post-rebase app/catalogue suite: 98 passed.
- Website typecheck: 0 errors.
- Commit and push checks: formatting, lint, app/website typechecks, knip
and Fallow passed.
- `workshop-workflows-enabled` gates the home tab, catalogue tab, direct
`?type=` URLs and detail pages without flashing gated content.

---------

Co-authored-by: Mariana Martinho <mariana@comfy.org>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions <github-actions@github.com>
benjcooley added a commit that referenced this pull request Sep 28, 2026
Behaviour fixes from reviewing Mar's Hub V2 PRs together. No CSS, layout
or copy changes to her design.

- Details graph (#19010): zoom and Reset respond to mouse and touch
  (pointer capture no longer swallows their clicks); zoom scales about
  the drawing's centre instead of carrying it off-frame; drag follows
  the pointer in drawing units; phones can scroll the page past the
  graph; the graph JSON is fetched when Details first opens, not on
  every page view.
- Graph reader (#19009): subgraph nodes are titled with the subgraph's
  name instead of its UUID; unlinked widget inputs are no longer drawn
  as sockets; links find their socket by saved index.
- Filter chips (#18979): Clear on "Browse all models" keeps you in the
  full list; removing a chip keeps keyboard focus in the chip row, then
  returns it to the filter button; tests follow #19090's renamed button.
- Run panel (#19005): a request that never ran no longer says it may
  still be billed or have taken credits.
- Drop three translation keys #19029 left unused.

This branch was previously deployed

1 inactive deployment
Preview – billing-web-test — 05c389eb Deployed Sep 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants