Repository navigation
feat(website): the facts rail names where a workflow runs, what it gives back, and who made it - #19008
feat(website): the facts rail names where a workflow runs, what it gives back, and who made it#19008mariana953 wants to merge 3 commits into
Conversation
…es back, and who made it Three more of the design's rows, and the three that have data behind them. Where it runs comes off the workflow's own type, so the day a workflow runs somewhere other than Cloud the row says so without anyone editing it. What it gives back is counted from the outputs the workflow declares, and names the medium only where every output is the same one, because a mixed set has no single name and the count on its own is still true. Who made it is the template's author, which is three different people across the thirty. The other three rows the design draws have nothing behind them anywhere in the catalogue: how often it has run, whether its weights are open, and when it was added. They are left out rather than filled with a guess. The card no longer hangs on there being a template. Where a run happens and what it gives back belong to the workflow, not to the picture of it.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌐 Website E2ETip All tests passed.
📦 Bundle Size
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1cc533bdf9f1767246881e4a425e5abc363334c1
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19008.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-l3viwfply-comfyui.vercel.app Last updated: 2026-09-27T10:00:04Z for |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (68.18%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## mariana/v2-workflow-details-tab #19008 +/- ##
===================================================================
- Coverage 84.02% 84.02% -0.01%
===================================================================
Files 3123 3123
Lines 153511 153532 +21
Branches 41658 41666 +8
===================================================================
+ Hits 128987 129001 +14
Misses 22969 22969
- Partials 1555 1562 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The Hub branches in this stack and main's new Cloud API pricing copy each stay under the old 1.81MB ceiling on their own; measured together here the route totals 1,810,629 bytes. The growth sits in chunks the homepage loads as well — site-wide copy rather than catalogue code — and the catalogue's own 900kB delta ceiling is untouched, so a catalogue regression still fails this test.
|
This branch now carries today's
It is not catalogue code, and it is not the facts rail's components. The same test's catalogue-only delta passed well inside its 900 kB ceiling, so what grew are chunks the homepage requests too: site-wide copy. The stack above this PR (#19010, #19029) inherits the same commit by merge; #19004 below it still measures under the old ceiling and is untouched. If you would rather the ceiling held and the copy paid for itself, the route to it is splitting Generated by Claude Code |
…te PRs (#19255) ## Summary Mar's Hub V2, staged as one reviewable phase. This combines the 23 PRs from her [#proj-comfy-hub post](https://comfy-organization.slack.com/archives/C0AEPRS8N74/p1790528696016959), including the latest head of #19004, while preserving her presentation and commit history. Review fixes remain isolated in #19256 above this PR. Design reference (not for review): #17804 · [V2 Hub preview](https://comfy-website-preview-pr-17804.vercel.app/hub/) ## Included **Independent:** #19031 Hub not Models · #18916 search with filter and sort · #18915 shorter workflows banner · #18979 filter chips · #19012 one "browse all" · #19016 shelf stops promising more · #18987 home hub workflows tab · #19025 Apps tab · #19090 filter named after what it filters · #19017 phone video controls · #19011 API tab endpoint · #19014 workflow header **Catalogue cards:** #18921 → #19015 **Workflow page V2:** #19009 → #19004 → #19008 → #19010 → #19029 **Run states:** #19005 → #19006 → #19007 → #19022 ## Integration with current main - Rebases the phase onto current `main`, including the canonical `/models/apps/<slug>/` routes and the separate Apps feature flag. - Keeps Mar's Apps shelf and card presentation while sourcing its entries and links from the canonical app catalogue. - Keeps Apps gated by `workshop-apps-enabled`; Workflows remain gated independently by `workshop-workflows-enabled`. - Keeps Mar's latest #19004 Details cleanup and single template-author attribution while retaining the later interactive graph work in #19008/#19010. - Resolves the combined `/models/` JavaScript budget to 1,820,000 bytes. ## Not included - #19241 (API tab rail): conflicts with #19011 and still needs a design call. - #19227 (draft), #17865 and #18306: not part of the Hub V2 set. ## Verification - Full website unit suite: 9,494 passed, 4 skipped. - Focused post-rebase app/catalogue suite: 98 passed. - Website typecheck: 0 errors. - Commit and push checks: formatting, lint, app/website typechecks, knip and Fallow passed. - `workshop-workflows-enabled` gates the home tab, catalogue tab, direct `?type=` URLs and detail pages without flashing gated content. --------- Co-authored-by: Mariana Martinho <mariana@comfy.org> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: github-actions <github-actions@github.com>
Summary
Three more of the V2 design's facts join "Runs on" in the Details rail — the three that have data behind them. Stacked on #19004, which built the rail; base retargets to
mainwhen that merges.Changes
dlof label/value rows. Where reads the workflow's owntype, so a workflow that runs somewhere other than Cloud says so without anyone editing it. Output is counted from the outputs the workflow declares. Author is the template's author. Adds six keys inenandzh-CNand three component tests.Output names the medium only where every output is the same one. All thirty workflows are uniform today (twenty-four give back one thing, the rest two to five), but a mixed set has no single name, and the count on its own is still true — so that case falls back to the count rather than picking a medium.
Three of the design's six rows are left out, because nothing in the catalogue carries them: how often a workflow has run, whether its weights are open (
licenseis null on all thirty), and when it was added. They are left out rather than filled with a guess. Getting them needs a data source someone would have to add.The facts card no longer hangs on there being a template. Where a run happens and what it gives back belong to the workflow, not to the picture of it — so a workflow with no template now shows those two rows and no graph, where before it showed no card at all. The "Runs on" band still appears only when the template names models.
Review Focus
model.authorcomes fromtemplate.authorviaworkshop-workflow-pages.ts; it is populated for all thirty (ComfyUI ×21, hellorob ×8, PurzBeats ×1), so the row is real data and not a constant.typeisCLOUDfor all thirty today, so Where reads the same on every page right now. It is still the workflow's own fact and the alternative is already in the type.workshop.task.image/video/audiokeys rather than adding media labels.Verified in the browser on the running page: the rows read "Runs on Comfy Cloud", "Video, 1 per run" and "ComfyUI"; the band measures 430px wide inside the desktop rail and 340px at phone width with no truncation, and
documentElement.scrollWidthequals the viewport at both 1440 and 390.Screenshots (if applicable)
The rail was captured locally at both widths. This session cannot attach binaries to a pull request; the preview link shows the result once
deploy-previewpasses.