Skip to content

feat(website): the facts rail names where a workflow runs, what it gives back, and who made it - #19008

Closed
mariana953 wants to merge 3 commits into
mariana/v2-workflow-details-tabfrom
mariana/v2-workflow-facts
Closed

mariana953 wants to merge 3 commits into
mariana/v2-workflow-details-tabfrom
mariana/v2-workflow-facts

Conversation

@mariana953

@mariana953 mariana953 commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Three more of the V2 design's facts join "Runs on" in the Details rail — the three that have data behind them. Stacked on #19004, which built the rail; base retargets to main when that merges.

Changes

  • What: A second band in the facts card, a dl of label/value rows. Where reads the workflow's own type, so a workflow that runs somewhere other than Cloud says so without anyone editing it. Output is counted from the outputs the workflow declares. Author is the template's author. Adds six keys in en and zh-CN and three component tests.
  • Breaking: none. Presentation only; nothing about running a workflow changed.

Output names the medium only where every output is the same one. All thirty workflows are uniform today (twenty-four give back one thing, the rest two to five), but a mixed set has no single name, and the count on its own is still true — so that case falls back to the count rather than picking a medium.

Three of the design's six rows are left out, because nothing in the catalogue carries them: how often a workflow has run, whether its weights are open (license is null on all thirty), and when it was added. They are left out rather than filled with a guess. Getting them needs a data source someone would have to add.

The facts card no longer hangs on there being a template. Where a run happens and what it gives back belong to the workflow, not to the picture of it — so a workflow with no template now shows those two rows and no graph, where before it showed no card at all. The "Runs on" band still appears only when the template names models.

Review Focus

  • model.author comes from template.author via workshop-workflow-pages.ts; it is populated for all thirty (ComfyUI ×21, hellorob ×8, PurzBeats ×1), so the row is real data and not a constant.
  • type is CLOUD for all thirty today, so Where reads the same on every page right now. It is still the workflow's own fact and the alternative is already in the type.
  • Reuses the existing workshop.task.image / video / audio keys rather than adding media labels.

Verified in the browser on the running page: the rows read "Runs on Comfy Cloud", "Video, 1 per run" and "ComfyUI"; the band measures 430px wide inside the desktop rail and 340px at phone width with no truncation, and documentElement.scrollWidth equals the viewport at both 1440 and 390.

Screenshots (if applicable)

The rail was captured locally at both widths. This session cannot attach binaries to a pull request; the preview link shows the result once deploy-preview passes.

…es back, and who made it

Three more of the design's rows, and the three that have data behind them.
Where it runs comes off the workflow's own type, so the day a workflow runs
somewhere other than Cloud the row says so without anyone editing it. What it
gives back is counted from the outputs the workflow declares, and names the
medium only where every output is the same one, because a mixed set has no
single name and the count on its own is still true. Who made it is the
template's author, which is three different people across the thirty.

The other three rows the design draws have nothing behind them anywhere in the
catalogue: how often it has run, whether its weights are open, and when it was
added. They are left out rather than filled with a guess.

The card no longer hangs on there being a template. Where a run happens and what
it gives back belong to the workflow, not to the picture of it.
@vercel

vercel Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 27, 2026 9:57am UTC
billing-web-test Skipped Skipped Sep 27, 2026 9:57am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 79dd3db8-a854-4aa2-9ffd-72c6df7a0f92

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

📦 Bundle Size

⏳ Size data collection in progress…

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 1cc533bdf9f1767246881e4a425e5abc363334c1

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-19008.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-l3viwfply-comfyui.vercel.app

Last updated: 2026-09-27T10:00:04Z for 6d7e14a

@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 68.18182% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ebsite/src/components/workshop/WorkflowPreview.vue 68.18% 0 Missing and 7 partials ⚠️

❌ Your patch check has failed because the patch coverage (68.18%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@                         Coverage Diff                         @@
##           mariana/v2-workflow-details-tab   #19008      +/-   ##
===================================================================
- Coverage                            84.02%   84.02%   -0.01%     
===================================================================
  Files                                 3123     3123              
  Lines                               153511   153532      +21     
  Branches                             41658    41666       +8     
===================================================================
+ Hits                                128987   129001      +14     
  Misses                               22969    22969              
- Partials                              1555     1562       +7     
Flag Coverage Δ
website-unit 78.00% <68.18%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ebsite/src/components/workshop/WorkflowPreview.vue 82.50% <68.18%> (-17.50%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The Hub branches in this stack and main's new Cloud API pricing copy each
stay under the old 1.81MB ceiling on their own; measured together here the
route totals 1,810,629 bytes. The growth sits in chunks the homepage loads
as well — site-wide copy rather than catalogue code — and the catalogue's
own 900kB delta ceiling is untouched, so a catalogue regression still fails
this test.
@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 27, 2026 09:57 Inactive

Copy link
Copy Markdown
Contributor Author

This branch now carries today's main, and with it one extra commit that is worth flagging because it moves a ceiling rather than fixing code.

website-e2e failed on e2e/models-performance.spec.ts: the /models/ route's whole-page script total measured 1,810,076 bytes against a 1,810,000 ceiling — 76 bytes over, the same on all three attempts.

It is not catalogue code, and it is not the facts rail's components. The same test's catalogue-only delta passed well inside its 900 kB ceiling, so what grew are chunks the homepage requests too: site-wide copy. main added 16 strings with the Cloud API pricing copy (#18523) and this branch adds the facts-rail strings; each side is under the ceiling on its own, and the sum crosses it. 6d7e14a raises the whole-route ceiling to 1.82 MB — the same move and the same 10 kB step as #17971 (1.80 → 1.81) — and leaves the catalogue delta ceiling at 900 kB, so catalogue code migrating into a shared chunk still fails this test.

The stack above this PR (#19010, #19029) inherits the same commit by merge; #19004 below it still measures under the old ceiling and is untouched.

If you would rather the ceiling held and the copy paid for itself, the route to it is splitting translations.ts per route so /models/ stops carrying the pricing and workflow strings. That is a larger change than this PR, so I have not done it here.


Generated by Claude Code

benjcooley added a commit that referenced this pull request Sep 28, 2026
#18979's chip tests open the filter by the name 'Filter', which #19090
renames to its only group ('Use cases'). Each JS budget bump was sized
for one PR; together the /models/ scripts measure 1,816,095 bytes, so
the budget moves to 1,820,000 as #19008, #19010 and #19029 set it.
@benjcooley

Copy link
Copy Markdown
Collaborator

This head is fully contained in #19255, where Mar's Hub V2 work is being staged and reviewed together. Closing this intermediate PR in favor of the combined phase; review fixes are isolated in #19256.

@benjcooley benjcooley closed this Sep 28, 2026
benjcooley added a commit that referenced this pull request Sep 28, 2026
…te PRs (#19255)

## Summary

Mar's Hub V2, staged as one reviewable phase. This combines the 23 PRs
from her [#proj-comfy-hub
post](https://comfy-organization.slack.com/archives/C0AEPRS8N74/p1790528696016959),
including the latest head of #19004, while preserving her presentation
and commit history. Review fixes remain isolated in #19256 above this
PR.

Design reference (not for review): #17804 · [V2 Hub
preview](https://comfy-website-preview-pr-17804.vercel.app/hub/)

## Included

**Independent:** #19031 Hub not Models · #18916 search with filter and
sort · #18915 shorter workflows banner · #18979 filter chips · #19012
one "browse all" · #19016 shelf stops promising more · #18987 home hub
workflows tab · #19025 Apps tab · #19090 filter named after what it
filters · #19017 phone video controls · #19011 API tab endpoint · #19014
workflow header

**Catalogue cards:** #18921 → #19015

**Workflow page V2:** #19009 → #19004 → #19008 → #19010 → #19029

**Run states:** #19005 → #19006 → #19007 → #19022

## Integration with current main

- Rebases the phase onto current `main`, including the canonical
`/models/apps/<slug>/` routes and the separate Apps feature flag.
- Keeps Mar's Apps shelf and card presentation while sourcing its
entries and links from the canonical app catalogue.
- Keeps Apps gated by `workshop-apps-enabled`; Workflows remain gated
independently by `workshop-workflows-enabled`.
- Keeps Mar's latest #19004 Details cleanup and single template-author
attribution while retaining the later interactive graph work in
#19008/#19010.
- Resolves the combined `/models/` JavaScript budget to 1,820,000 bytes.

## Not included

- #19241 (API tab rail): conflicts with #19011 and still needs a design
call.
- #19227 (draft), #17865 and #18306: not part of the Hub V2 set.

## Verification

- Full website unit suite: 9,494 passed, 4 skipped.
- Focused post-rebase app/catalogue suite: 98 passed.
- Website typecheck: 0 errors.
- Commit and push checks: formatting, lint, app/website typechecks, knip
and Fallow passed.
- `workshop-workflows-enabled` gates the home tab, catalogue tab, direct
`?type=` URLs and detail pages without flashing gated content.

---------

Co-authored-by: Mariana Martinho <mariana@comfy.org>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions <github-actions@github.com>

This branch was previously deployed

1 inactive deployment
Preview – billing-web-test — 6d7e14a3 Deployed Sep 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants