Repository navigation
[backport cloud/1.55] FE-2894 feat(account-core): session-backed identity source and boot rules - #19019
Conversation
…ules (#18715) > **Do not merge** until BE-17063 (`GET /api/auth/session`, cloud#10549, merged) is deployed on testcloud (the web session backend is not on staging yet). #18710 (FE-2892) is merged; this PR now targets `main` and the diff shows only this ticket. A site that joins the shared web session has to decide at boot who is signed in: the session on ingest, a login this browser remembers, or nobody. TDD §12's boot table defines that, and §8 defines the silent restore that lets every existing user migrate without signing in again. This PR is that decision, as a pure state machine in `@comfyorg/account-core`, inert until a host calls `boot()`. New entry `@comfyorg/account-core/webSessionIdentity` (`packages/account-core/src/core/webSessionIdentity.ts`): - `createWebSessionIdentity({ session, principal, origin, onBootstrap?, schedule?, retryBaseMs?, retryMaxMs? })` → `{ getState, subscribe, boot, dispose }`. Constructing it sends nothing and starts nothing. - `principal`: `{ kind: 'account', rememberedLogin }` or `{ kind: 'api_key' }`. An API-key principal never enters the machine and never touches `/api/auth/session`. - `RememberedLogin` is an opaque port (`currentUserId`, `getProof` returning `string | null`, `signOutLocally`), so the core imports no provider. `importGuard` now walks the import chain from `webSessionIdentity.ts`. - One discriminated state (`idle | api_key | reading | retry_wait | restoring | signed_in | signed_out`), one pure `transitionWebSessionIdentity(state, event)` returning `{ state, effects }`; the shell only runs effects (`read`, `restore`, `schedule_retry`, `sign_out_locally`, `report`). `session_bootstrap` (outcome, origin) goes out through `onBootstrap`. | `GET /session` | Result | | --- | --- | | 200 | `signed_in`; if the remembered login is a different user, sign it out locally | | 401 `session_revoked` | `signed_out(revoked)`, local sign-out, never a silent restore | | 401 `no_session` / `session_expired`, login remembered | silent restore (`createWebSession` with the remembered proof); success → `signed_in(restored)`; a completed failure → `signed_out(restore_failed)` | | 401 `no_session` / `session_expired`, nothing remembered | `signed_out` | | `SESSION_UNAVAILABLE` (network, 429, 5xx) | `retry_wait`, backoff 1s doubling to 60s, never signs out | - A restore that fails transiently (network, 5xx, or `getProof` throwing) is not spent: after backoff it re-reads first, so a POST that landed but lost its answer yields 200 and no second POST. `getProof` returning `null` is permanent (`restore_failed`, no local sign-out). A restore that gets a real answer completes at most once per boot. - The SDK keeps no record of past sessions; the server's answer decides. - Not wired into any app yet (FE-2896 website, FE-2903 cloud). The shared flag-off harness from #18708/#18710 is inherited from the base and stays green. No UI; the evidence is tests with injected time and the package fakes, no sleeps. - AS IS: no boot logic for the web session. - TO BE: one test per boot-table row (row 1 split by remembered user same/different/none; row 3 for both 401 codes), backoff 1000 → 2000 then sign-in with zero sign-outs, restore lost twice then restored (`GET POST GET POST GET POST GET`), a landed-but-unanswered POST (`GET POST GET`, no second POST), `getProof` null / throwing, a pure table of restore answers, API key → zero requests. ``` pnpm --filter @comfyorg/account-core test Test Files 62 passed, Tests 1070 passed pnpm --filter @comfyorg/account-core typecheck / lint exit 0 pnpm typecheck exit 0 pnpm knip exit 0 pnpm fallow audit --base <FE-2892 branch> No issues in 6 changed files ``` Mutation checks (each reverted): `session_revoked` restores → red; network error on read signs out → red; transient restore failure signs out → red; completed restore failure retries → red; thrown proof signs out → red. Size: `webSessionIdentity.ts` is 336 lines, mostly the state, event and effect types; the transition itself is small. For review: `RememberedLogin.currentUserId()` must return the Comfy user id, since it is compared with the session's `user.id`. The host adapters (FE-2896/FE-2903) need to confirm that equals the Firebase uid. - TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b (sections 8, 12, A8) - Action items and dependency graph: https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3 - Linear: https://linear.app/comfyorg/issue/FE-2894 | Ticket | Scope | Blocked by | State | | --- | --- | --- | --- | | FE-2891 | `unified_web_session` client flag, off by default | BE-17135 to turn on; C11 for website/billing-web readers | #18708 | | FE-2892 | account-core web session client + error codes | C1, C3 (BE-17063 generated types) | #18710, do not merge | | FE-2893 | ADR for the shared web session | none | #18707 | | FE-2901 | non-web clients stay on tokens (baseline) | FE-2895 for `authorize()` rows | #18711 | | **FE-2894 (this PR)** | session-backed identity + boot rules (stacked on #18710) | FE-2892, C3 | #18715, do not merge | | FE-2895 | `authorize()` for cookie requests (stacked on #18710) | FE-2892, C5 | #18716, do not merge | | FE-2897 | session lifecycle, heartbeat (stacked on #18715) | FE-2894, C1, C3 | #18719, do not merge | | FE-2906 | cross-origin E2E harness + §17 test ids | C3/C5/C6/C7 on staging for the rows | #18718 (harness only) | | FE-2896, 2898–2900, 2902–2905, 2907, 2908 | apps, token mint, rollout, cleanup | C5/C6/C7/C8/C11 contracts | not started | ```mermaid flowchart LR subgraph BE["BE · cloud ingest and infra"] C0["BE-17071 C0 preview CORS gate"] C1["BE-17061 C1 sessions table + revocable cookie"] C3["BE-17063 C3 GET /session, trusted origins, flag"] C4["BE-17062 C4 shared workspace resolution"] C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"] C2["BE-17064 C2 revoke-all, purge, caps"] C6["BE-17067 C6 WebSocket on session"] C7["BE-17068 C7 scoped media"] C8["BE-17069 C8 token mint from session"] C9["BE-17065 C9 Redis cache + load test"] C10["BE-17072 C10 prod config, cleanup"] C11["C11 flag before sign-in (OQ17)"] B135["BE-17135 serve unified_web_session (server AND)"] I2["BE-17070 I2 edge limit, log + DNS audit"] end subgraph SDK["FE · account-core"] F2891["FE-2891 flag"] F2892["FE-2892 web session client"] F2894["FE-2894 identity + boot rules"] F2897["FE-2897 lifecycle, heartbeat"] F2895["FE-2895 authorize()"] F2900["FE-2900 lazy token mint"] F2901["FE-2901 non-web stay on tokens"] end subgraph APPS["FE · apps"] F2896["FE-2896 website header"] F2903["FE-2903 cloud lifecycle"] F2899["FE-2899 website credits"] F2904["FE-2904 cloud API client"] F2905["FE-2905 socket + media"] F2898["FE-2898 billing-web joins session"] F2902["FE-2902 platform"] end subgraph QA["QA · rollout · docs"] F2906["FE-2906 cross-origin E2E"] F2893["FE-2893 ADR + docs"] F2907["FE-2907 ramp + rollback"] F2908["FE-2908 cleanup"] end C0 --> C1 --> C3 --> C5 C3 --> C11 --> F2891 B135 --> F2891 C4 --> C5 C1 --> C2 C1 --> C9 C5 --> C6 & C7 & C8 C3 --> F2892 C1 --> F2892 F2891 --> F2894 C3 --> F2894 F2892 --> F2894 --> F2896 F2894 --> F2897 --> F2903 C1 --> F2897 F2892 --> F2895 C5 --> F2895 F2895 --> F2899 & F2904 & F2900 & F2901 & F2902 C5 --> F2899 & F2904 F2903 --> F2904 --> F2905 C6 --> F2905 C7 --> F2905 C8 --> F2900 F2894 --> F2898 F2895 --> F2898 C3 --> F2898 C5 --> F2898 F2903 & F2904 & F2905 & F2898 --> F2906 C3 & C2 --> F2906 F2906 --> F2907 C9 & C10 & I2 --> F2907 F2907 --> F2908 C10 --> F2908 classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000 class F2894 thisPr ``` - Blocked by: #18710 (FE-2892) and BE-17063 (C3). FE-2891 gates it at the host, not here. - Unblocks: FE-2896 (website header), FE-2897 (lifecycle, heartbeat), FE-2898 (billing-web). --------- Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com> (cherry picked from commit 1699fa8)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2124 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 45900e0815ac277a6ba32e0b68136e0d34a21fd5
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-26T18:48:16.718Z",
"gitSha": "a63c6bdfe5441b0030bdcc4d8714ac8f73df5213",
"branch": "backport-18715-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2016.0560000000487,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.579,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.42,
"heapDeltaBytes": 6124020,
"heapUsedBytes": 73800312,
"domNodes": -258,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.484,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.003999999938,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.020999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.66600000000005,
"heapDeltaBytes": -7794760,
"heapUsedBytes": 59859544,
"domNodes": -261,
"jsHeapTotalBytes": 3399680,
"scriptDurationMs": 10.152999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1740.1360000000068,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.269000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 817.1600000000001,
"heapDeltaBytes": -5014508,
"heapUsedBytes": 62598728,
"domNodes": -261,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 164.513,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1739.1759999999294,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.927999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 824.725,
"heapDeltaBytes": 13745192,
"heapUsedBytes": 81149176,
"domNodes": -261,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 163.879,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.8660000000036,
"styleRecalcs": 29,
"styleRecalcDurationMs": 14.612,
"layouts": 6,
"layoutDurationMs": 1.0819999999999999,
"taskDurationMs": 343.35,
"heapDeltaBytes": 3181324,
"heapUsedBytes": 70731572,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.612,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.6929999999593,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.85,
"layouts": 6,
"layoutDurationMs": 1.087,
"taskDurationMs": 322.76,
"heapDeltaBytes": 3120496,
"heapUsedBytes": 70676892,
"domNodes": 79,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.716,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 660.3329999999232,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.339,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.547,
"heapDeltaBytes": 18986236,
"heapUsedBytes": 86592544,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 167.84799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 648.6710000000357,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.279000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.1959999999999,
"heapDeltaBytes": 18921132,
"heapUsedBytes": 86430176,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 168.929,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1195.7640000000538,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 867.056,
"heapDeltaBytes": 35962492,
"heapUsedBytes": 107019156,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 74.16399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 583,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1210.252999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 875.419,
"heapDeltaBytes": 38198196,
"heapUsedBytes": 108541368,
"domNodes": 0,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 76.308,
"eventListeners": 0,
"totalBlockingTimeMs": 595,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.5560000000214,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.1589999999994,
"heapDeltaBytes": 14661048,
"heapUsedBytes": 91188148,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.92100000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 879.9890000000232,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.25099999999946,
"heapDeltaBytes": 16102416,
"heapUsedBytes": 91531636,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 174.28900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11749.434999999949,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10776.022,
"heapDeltaBytes": 3171492,
"heapUsedBytes": 85540332,
"domNodes": -14,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8923.971,
"eventListeners": 0,
"totalBlockingTimeMs": 1533,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10952.241999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9991.748999999998,
"heapDeltaBytes": -12639744,
"heapUsedBytes": 69310032,
"domNodes": -14,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 8554.745,
"eventListeners": 0,
"totalBlockingTimeMs": 1590,
"frameDurationMs": 19.99999999999994,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11710.428999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10793.292000000001,
"heapDeltaBytes": 6887864,
"heapUsedBytes": 89408576,
"domNodes": -16,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 9042.364,
"eventListeners": 0,
"totalBlockingTimeMs": 2054,
"frameDurationMs": 19.996666666666716,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10676.275000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9802.917,
"heapDeltaBytes": 11055916,
"heapUsedBytes": 92892120,
"domNodes": -12,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8078.379999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1280,
"frameDurationMs": 20,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2068.8350000000355,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.451,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 633.2639999999999,
"heapDeltaBytes": 1446700,
"heapUsedBytes": 81155580,
"domNodes": -247,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 38.446999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2039.5930000000817,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.052999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 599.0960000000001,
"heapDeltaBytes": -3372140,
"heapUsedBytes": 83530324,
"domNodes": -238,
"jsHeapTotalBytes": -1806336,
"scriptDurationMs": 34.362,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2467.64799999994,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.665999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1753.019,
"heapDeltaBytes": -18785924,
"heapUsedBytes": 68523392,
"domNodes": -221,
"jsHeapTotalBytes": 1863680,
"scriptDurationMs": 901.759,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2287.732999999889,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.191999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1520.019,
"heapDeltaBytes": -2950660,
"heapUsedBytes": 84707788,
"domNodes": -242,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 869.232,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3703.548000000069,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.883000000000003,
"layouts": 60,
"layoutDurationMs": 13.342,
"taskDurationMs": 1769.2539999999997,
"heapDeltaBytes": 9833628,
"heapUsedBytes": 75105096,
"domNodes": -254,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 829.0569999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3564.440999999988,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.282999999999998,
"layouts": 60,
"layoutDurationMs": 12.86,
"taskDurationMs": 1675.7890000000002,
"heapDeltaBytes": 10197408,
"heapUsedBytes": 75248176,
"domNodes": -7,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 802.919,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3092.563000000041,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.151000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1943.016,
"heapDeltaBytes": 23560796,
"heapUsedBytes": 89379572,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 993.28,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3072.699000000057,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.640999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1952.979,
"heapDeltaBytes": -8268176,
"heapUsedBytes": 82446308,
"domNodes": -260,
"jsHeapTotalBytes": 1495040,
"scriptDurationMs": 1002.6579999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.4679999999653,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.488,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.5530000000001,
"heapDeltaBytes": 19809836,
"heapUsedBytes": 83830372,
"domNodes": -243,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.582,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2023.1959999998708,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.302999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.5920000000001,
"heapDeltaBytes": 20595004,
"heapUsedBytes": 84570096,
"domNodes": -246,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.987,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 571.0520000000088,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.620000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.7060000000001,
"heapDeltaBytes": 13750224,
"heapUsedBytes": 83599848,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 148.031,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.447000000102,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.887,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.667,
"heapDeltaBytes": 13416880,
"heapUsedBytes": 83686528,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.513,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2006.8479999999909,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.031,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.182,
"heapDeltaBytes": 10413316,
"heapUsedBytes": 80020432,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.132000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.930999999995,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.239999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.4010000000001,
"heapDeltaBytes": -4665260,
"heapUsedBytes": 58742336,
"domNodes": -274,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 11.046,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.9910000000318,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.578000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 793.187,
"heapDeltaBytes": 9071984,
"heapUsedBytes": 78541560,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 111.165,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1729.8409999999649,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.485,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 671.169,
"heapDeltaBytes": 9738756,
"heapUsedBytes": 79191048,
"domNodes": -272,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 109.80899999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.768,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.550999999999995,
"layouts": 5,
"layoutDurationMs": 13.716000000000003,
"taskDurationMs": 942.4460000000001,
"heapDeltaBytes": 20302612,
"heapUsedBytes": 103191312,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 31.664000000000005,
"eventListeners": 2383,
"totalBlockingTimeMs": 151,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8407.784999999989,
"styleRecalcs": 251,
"styleRecalcDurationMs": 36.915000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5807.986,
"heapDeltaBytes": -6383460,
"heapUsedBytes": 80409336,
"domNodes": -239,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 2831.286,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8541.144000000031,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.866,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5829.16,
"heapDeltaBytes": -7049172,
"heapUsedBytes": 79911568,
"domNodes": -248,
"jsHeapTotalBytes": 1269760,
"scriptDurationMs": 2866.1600000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17224.172000000068,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16768.700000000004,
"heapDeltaBytes": -57179832,
"heapUsedBytes": 183093852,
"domNodes": -8065,
"jsHeapTotalBytes": -16408576,
"scriptDurationMs": 266.945,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16729.964999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16201.563,
"heapDeltaBytes": -43185156,
"heapUsedBytes": 182623516,
"domNodes": -8061,
"jsHeapTotalBytes": -16494592,
"scriptDurationMs": 254.90100000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20376.906000000075,
"styleRecalcs": 145,
"styleRecalcDurationMs": 18.27000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20198.960999999996,
"heapDeltaBytes": -49621084,
"heapUsedBytes": 180527344,
"domNodes": -8061,
"jsHeapTotalBytes": -20144128,
"scriptDurationMs": 928.396,
"eventListeners": -14928,
"totalBlockingTimeMs": 64,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20648.648999999976,
"styleRecalcs": 162,
"styleRecalcDurationMs": 17.57900000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20351.509000000002,
"heapDeltaBytes": -32531272,
"heapUsedBytes": 181588032,
"domNodes": -8061,
"jsHeapTotalBytes": -12070912,
"scriptDurationMs": 899.666,
"eventListeners": -14928,
"totalBlockingTimeMs": 60,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6157.3869999999715,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.89399999999996,
"layouts": 20,
"layoutDurationMs": 23.353999999999985,
"taskDurationMs": 6098.324,
"heapDeltaBytes": -44133288,
"heapUsedBytes": 176767616,
"domNodes": -8061,
"jsHeapTotalBytes": 10211328,
"scriptDurationMs": 109.30499999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 435,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4759.596000000101,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.812,
"layouts": 20,
"layoutDurationMs": 23.23399999999999,
"taskDurationMs": 4618.867000000001,
"heapDeltaBytes": -26181344,
"heapUsedBytes": 199674548,
"domNodes": -8061,
"jsHeapTotalBytes": 19652608,
"scriptDurationMs": 87.811,
"eventListeners": -14928,
"totalBlockingTimeMs": 102,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8379.780000000097,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8227.784,
"heapDeltaBytes": -19194724,
"heapUsedBytes": 171386060,
"domNodes": 0,
"jsHeapTotalBytes": -10485760,
"scriptDurationMs": 131.25900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8589.98600000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8367.722,
"heapDeltaBytes": -14463148,
"heapUsedBytes": 173917260,
"domNodes": 0,
"jsHeapTotalBytes": -23855104,
"scriptDurationMs": 132.482,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 142.51799999999548,
"styleRecalcs": 9,
"styleRecalcDurationMs": 22.576,
"layouts": 4,
"layoutDurationMs": 2.264,
"taskDurationMs": 112.839,
"heapDeltaBytes": 3346176,
"heapUsedBytes": 68739844,
"domNodes": 141,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 12.681999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 102.27200000008452,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.265,
"layouts": 3,
"layoutDurationMs": 1.572,
"taskDurationMs": 75.52899999999998,
"heapDeltaBytes": 3016440,
"heapUsedBytes": 68591740,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.212,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #19019 +/- ##
=============================================
Coverage ? 83.67%
=============================================
Files ? 3023
Lines ? 149314
Branches ? 40494
=============================================
Hits ? 124937
Misses ? 23059
Partials ? 1318
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified against #18715 before approving: identical file list, and no conflict markers anywhere in the diff. All three required checks green (lint-and-format, test, e2e-status).
…create on sign-in, delete on sign-out, heartbeat (#19021) Backport of #18719 to `cloud/1.55` (cherry-pick -x of 1685d33). Merge #19019 first. This branch is stacked on it, so until #19019 merges the diff also shows its #18715 commit. ## Why The unified web session stack is going to 1.55. #18719 adds the session lifecycle to `webSessionIdentity` (create on sign-in, delete on sign-out, heartbeat) and generalises `CrossTabRefreshPort` so the web cross-tab port can carry it. It builds on #18715 (backported in #19019). ## Root cause (what conflicted) Nothing. On top of the #18715 backport the cherry-pick applied cleanly; every touched file (`sessionContracts.ts`, `webSessionIdentity.ts`, `web/crossTabRefresh.ts`, their tests, `webSessionInertImport.test.ts`) matches main's pre-#18719 state for these lines. The `@comfyorg/account-core/web` entry it adds to the inert-import test is already exported on `cloud/1.55`. ## How Kept everything from #18719 verbatim; dropped nothing. No files from other PRs. Validation: `pnpm typecheck:account-core` exit 0; vitest `webSessionIdentity`, `webSessionIdentity.lifecycle`, `webSession`, `importGuard`, `webSessionInertImport`, `web/crossTabRefresh`, `session`, `requestAuth` 214/214 pass; package.json parses. ## AS IS / TO BE No UI change (inert behind `unified_web_session`). Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
Backport of #18715 to
cloud/1.55(cherry-pick -x of 1699fa8).Why
The unified web session stack is going to 1.55. #18715 adds
@comfyorg/account-core/webSessionIdentity(packages/account-core/src/core/webSessionIdentity.ts), the session-backed identity source and boot rules that #18719 builds on. Its dependencies (#18710webSession, #18716requestAuth) are already oncloud/1.55.Root cause (what conflicted)
packages/account-core/package.json(exports),scripts/smokePack.tsandsrc/webSessionInertImport.test.ts: adjacent-line conflicts wherecloud/1.55already listsrequestAuth(from the #18716 backport) at the same spot #18715 insertswebSessionIdentity.importGuard.test.tsapplied cleanly.How
Kept the release branch's
requestAuthentries and added only #18715's ownwebSessionIdentityentries, in main's order (requestAuththenwebSessionIdentity). No other main-only entries (sessionTokenMintetc.) were pulled in.webSessionIdentity.tsand its test apply verbatim.Validation:
pnpm typecheck:account-coreexit 0; vitestwebSessionIdentity,webSession,importGuard,webSessionInertImport75/75 pass; package.json parses.AS IS / TO BE
No UI change (inert behind
unified_web_session).