Skip to content

[backport cloud/1.55] FE-2897 feat(account-core): session lifecycle, create on sign-in, delete on sign-out, heartbeat - #19021

Merged
christian-byrne merged 1 commit into
cloud/1.55from
backport-18719-to-cloud-1.55
Sep 27, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.55from
backport-18719-to-cloud-1.55

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

Backport of #18719 to cloud/1.55 (cherry-pick -x of 1685d33).

Merge #19019 first. This branch is stacked on it, so until #19019 merges the diff also shows its #18715 commit.

Why

The unified web session stack is going to 1.55. #18719 adds the session lifecycle to webSessionIdentity (create on sign-in, delete on sign-out, heartbeat) and generalises CrossTabRefreshPort so the web cross-tab port can carry it. It builds on #18715 (backported in #19019).

Root cause (what conflicted)

Nothing. On top of the #18715 backport the cherry-pick applied cleanly; every touched file (sessionContracts.ts, webSessionIdentity.ts, web/crossTabRefresh.ts, their tests, webSessionInertImport.test.ts) matches main's pre-#18719 state for these lines. The @comfyorg/account-core/web entry it adds to the inert-import test is already exported on cloud/1.55.

How

Kept everything from #18719 verbatim; dropped nothing. No files from other PRs.

Validation: pnpm typecheck:account-core exit 0; vitest webSessionIdentity, webSessionIdentity.lifecycle, webSession, importGuard, webSessionInertImport, web/crossTabRefresh, session, requestAuth 214/214 pass; package.json parses.

AS IS / TO BE

No UI change (inert behind unified_web_session).

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 79314f20-2fb4-4995-8b34-1bc0c1cd330e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/27/2026, 05:53:27 AM UTC

Links

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🎭 Playwright: ✅ 2124 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2103 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 3e437226c9f677228843fd696602d994dcc1d49d

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.7 MB heap
dom-widget-order-dense-n200-w200-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 250ms TBT · 69.7 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 78ms TBT · 86.3 MB heap
extension-clean-combined-draw: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.3 MB heap
extension-rgthree-prototype-draw: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 10ms TBT · 74.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 51ms TBT · 80.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.2 MB heap
vue-large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 180.1 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 22ms TBT · 181.6 MB heap
vue-node-resize-workload: · 59.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 179.3 MB heap
vue-zoom-out-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 13
canvas-idle: task duration 259ms
canvas-idle: script duration 5ms
canvas-idle: TBT 0ms
canvas-idle: heap used 55.0 MB
canvas-idle: DOM nodes -255
canvas-idle: event listeners -174
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 0ms
canvas-mouse-sweep: style recalc duration 12ms
canvas-mouse-sweep: layout count 0
canvas-mouse-sweep: style recalc count 47
canvas-mouse-sweep: task duration 466ms
canvas-mouse-sweep: script duration 92ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 59.0 MB
canvas-mouse-sweep: DOM nodes -256
canvas-mouse-sweep: event listeners -174
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 10ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 183ms
canvas-zoom-sweep: script duration 7ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 64.6 MB
canvas-zoom-sweep: DOM nodes 79
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 276ms
dom-widget-clipping: script duration 103ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 79.7 MB
dom-widget-clipping: DOM nodes 21
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 17ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 483ms
dom-widget-order-dense-n200-w200-i120: script duration 34ms
dom-widget-order-dense-n200-w200-i120: TBT 250ms
dom-widget-order-dense-n200-w200-i120: heap used 69.7 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -292
dom-widget-order-dense-n200-w200-i120: event listeners -217
dom-widget-order-sparse-n1000-w20-i120: avg frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 237ms
dom-widget-order-sparse-n1000-w20-i120: script duration 79ms
dom-widget-order-sparse-n1000-w20-i120: TBT 78ms
dom-widget-order-sparse-n1000-w20-i120: heap used 86.3 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 17ms
extension-clean-combined-draw: p95 frame time 17ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 3
extension-clean-combined-draw: task duration 4318ms
extension-clean-combined-draw: script duration 3463ms
extension-clean-combined-draw: TBT 0ms
extension-clean-combined-draw: heap used 80.3 MB
extension-clean-combined-draw: DOM nodes -136
extension-clean-combined-draw: event listeners -87
extension-rgthree-prototype-draw: avg frame time 17ms
extension-rgthree-prototype-draw: p95 frame time 17ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 2ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 4
extension-rgthree-prototype-draw: task duration 4670ms
extension-rgthree-prototype-draw: script duration 3695ms
extension-rgthree-prototype-draw: TBT 10ms
extension-rgthree-prototype-draw: heap used 74.1 MB
extension-rgthree-prototype-draw: DOM nodes -266
extension-rgthree-prototype-draw: event listeners -174
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 325ms
large-graph-idle: script duration 18ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 77.8 MB
large-graph-idle: DOM nodes -236
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 70
large-graph-pan: task duration 997ms
large-graph-pan: script duration 518ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 71.6 MB
large-graph-pan: DOM nodes -210
large-graph-pan: event listeners -174
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 66
large-graph-zoom: task duration 1031ms
large-graph-zoom: script duration 485ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.8 MB
large-graph-zoom: DOM nodes -112
large-graph-zoom: event listeners -87
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 9ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 48
legacy-node-drag: task duration 1169ms
legacy-node-drag: script duration 588ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 74.9 MB
legacy-node-drag: DOM nodes -241
legacy-node-drag: event listeners 6
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 304ms
minimap-idle: script duration 17ms
minimap-idle: TBT 0ms
minimap-idle: heap used 78.2 MB
minimap-idle: DOM nodes -241
minimap-idle: event listeners -87
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 49
subgraph-dom-widget-clipping: task duration 239ms
subgraph-dom-widget-clipping: script duration 89ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 76.6 MB
subgraph-dom-widget-clipping: DOM nodes 23
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 12
subgraph-idle: task duration 258ms
subgraph-idle: script duration 5ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 68.9 MB
subgraph-idle: DOM nodes -272
subgraph-idle: event listeners -209
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 0ms
subgraph-mouse-sweep: style recalc duration 16ms
subgraph-mouse-sweep: layout count 0
subgraph-mouse-sweep: style recalc count 48
subgraph-mouse-sweep: task duration 459ms
subgraph-mouse-sweep: script duration 69ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 55.6 MB
subgraph-mouse-sweep: DOM nodes -270
subgraph-mouse-sweep: event listeners -220
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 7ms
subgraph-transition-enter: style recalc duration 17ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 500ms
subgraph-transition-enter: script duration 16ms
subgraph-transition-enter: TBT 51ms
subgraph-transition-enter: heap used 80.0 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 3347ms
viewport-pan-sweep: script duration 1708ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 71.2 MB
viewport-pan-sweep: DOM nodes -222
viewport-pan-sweep: event listeners -163
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 8967ms
vue-large-graph-idle: script duration 115ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 180.1 MB
vue-large-graph-idle: DOM nodes -8062
vue-large-graph-idle: event listeners -14928
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 12ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 67
vue-large-graph-pan: task duration 12535ms
vue-large-graph-pan: script duration 546ms
vue-large-graph-pan: TBT 22ms
vue-large-graph-pan: heap used 181.6 MB
vue-large-graph-pan: DOM nodes -8062
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 17ms
vue-node-resize-workload: style recalc duration 47ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 3590ms
vue-node-resize-workload: script duration 52ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 179.3 MB
vue-node-resize-workload: DOM nodes -8062
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 4609ms
vue-zoom-out-idle: script duration 61ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 172.1 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 12ms
workflow-execution: layout count 3
workflow-execution: style recalc count 10
workflow-execution: task duration 57ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 66.4 MB
workflow-execution: DOM nodes 122
workflow-execution: event listeners 41
Raw data
{
  "timestamp": "2026-09-27T06:00:25.487Z",
  "gitSha": "df32eea6f8878e1ec596c2749da8330c8549a5e7",
  "branch": "backport-18719-to-cloud-1.55",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 1987.0590000000448,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 6.174,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 259.27900000000005,
      "heapDeltaBytes": -7496292,
      "heapUsedBytes": 60022272,
      "domNodes": -255,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 5.0089999999999995,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 1989.883999999961,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.617000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 257.76200000000006,
      "heapDeltaBytes": -7061844,
      "heapUsedBytes": 55306944,
      "domNodes": -254,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 4.736000000000001,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1677.3509999999874,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.888000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 467.638,
      "heapDeltaBytes": -2761124,
      "heapUsedBytes": 59648472,
      "domNodes": -257,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 91.88499999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1690.6450000000177,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 12.374999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 464.115,
      "heapDeltaBytes": -3884604,
      "heapUsedBytes": 64028856,
      "domNodes": -255,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 92.40599999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1706.1969999999747,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 10.881,
      "layouts": 6,
      "layoutDurationMs": 0.959,
      "taskDurationMs": 185.16400000000002,
      "heapDeltaBytes": 2794516,
      "heapUsedBytes": 70594168,
      "domNodes": 79,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 7.115,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1709.5180000000028,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 9.682999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.8619999999999999,
      "taskDurationMs": 180.32199999999997,
      "heapDeltaBytes": 2146160,
      "heapUsedBytes": 64969408,
      "domNodes": 78,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 6.871,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 398.48200000000134,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 6.723999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 273.269,
      "heapDeltaBytes": 18105284,
      "heapUsedBytes": 80725836,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 100.53099999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 432.50399999999445,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 6.669,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 277.96200000000005,
      "heapDeltaBytes": 18519700,
      "heapUsedBytes": 86475916,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 104.727,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 878.1720000000064,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 488.409,
      "heapDeltaBytes": -17044588,
      "heapUsedBytes": 73068960,
      "domNodes": -290,
      "jsHeapTotalBytes": 20840448,
      "scriptDurationMs": 37.579,
      "eventListeners": -217,
      "totalBlockingTimeMs": 252,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 859.1279999999983,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 478.491,
      "heapDeltaBytes": -14619904,
      "heapUsedBytes": 73092064,
      "domNodes": -293,
      "jsHeapTotalBytes": 19005440,
      "scriptDurationMs": 30.84200000000001,
      "eventListeners": -217,
      "totalBlockingTimeMs": 248,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 671.0449999999923,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 240.4390000000003,
      "heapDeltaBytes": 15848972,
      "heapUsedBytes": 91039972,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 81.16000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 76,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 671.0930000000417,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 233.55599999999964,
      "heapDeltaBytes": 14778912,
      "heapUsedBytes": 89990920,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 77.46499999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 79,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 5471.2649999999885,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.6529999999999974,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4408.509,
      "heapDeltaBytes": 13020456,
      "heapUsedBytes": 95075804,
      "domNodes": -14,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 3586.227,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 5049.355999999989,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 1.5210000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4228.1539999999995,
      "heapDeltaBytes": -3742388,
      "heapUsedBytes": 73364624,
      "domNodes": -257,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 3339.84,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 5701.595999999995,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 1.8030000000000026,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4784.057000000001,
      "heapDeltaBytes": -7025788,
      "heapUsedBytes": 69970740,
      "domNodes": -265,
      "jsHeapTotalBytes": 1826816,
      "scriptDurationMs": 3807.149,
      "eventListeners": -174,
      "totalBlockingTimeMs": 2,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 5373.637999999972,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 1.8990000000000014,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4555.3589999999995,
      "heapDeltaBytes": 9835644,
      "heapUsedBytes": 85332380,
      "domNodes": -266,
      "jsHeapTotalBytes": 1040384,
      "scriptDurationMs": 3583.205,
      "eventListeners": -174,
      "totalBlockingTimeMs": 17,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2008.4279999999808,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.4799999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 334.447,
      "heapDeltaBytes": 718108,
      "heapUsedBytes": 79331548,
      "domNodes": -236,
      "jsHeapTotalBytes": -8192,
      "scriptDurationMs": 17.561,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2016.240000000039,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.014999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 316.23900000000003,
      "heapDeltaBytes": -3144552,
      "heapUsedBytes": 83914788,
      "domNodes": -235,
      "jsHeapTotalBytes": -1806336,
      "scriptDurationMs": 17.622000000000007,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2114.84999999999,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.832,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1030.7740000000001,
      "heapDeltaBytes": -17871116,
      "heapUsedBytes": 69773308,
      "domNodes": -211,
      "jsHeapTotalBytes": 815104,
      "scriptDurationMs": 539.188,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2132.824000000028,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 14.232,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 962.8279999999999,
      "heapDeltaBytes": -7198448,
      "heapUsedBytes": 80287168,
      "domNodes": -209,
      "jsHeapTotalBytes": 1040384,
      "scriptDurationMs": 495.92099999999994,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3071.455999999955,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 12.184000000000001,
      "layouts": 60,
      "layoutDurationMs": 13.133,
      "taskDurationMs": 1029.97,
      "heapDeltaBytes": 8590124,
      "heapUsedBytes": 74819220,
      "domNodes": 14,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 494.412,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3070.4470000000015,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 14.103,
      "layouts": 60,
      "layoutDurationMs": 12.868999999999998,
      "taskDurationMs": 1031.8780000000002,
      "heapDeltaBytes": -15001448,
      "heapUsedBytes": 73717928,
      "domNodes": -237,
      "jsHeapTotalBytes": -1019904,
      "scriptDurationMs": 475.29,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2154.5849999999973,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.189000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1166.506,
      "heapDeltaBytes": 216212,
      "heapUsedBytes": 83376748,
      "domNodes": -241,
      "jsHeapTotalBytes": -901120,
      "scriptDurationMs": 590.102,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2175.0069999999937,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 9.421000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1172.253,
      "heapDeltaBytes": -16719372,
      "heapUsedBytes": 73686736,
      "domNodes": -241,
      "jsHeapTotalBytes": 253952,
      "scriptDurationMs": 585.859,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 1998.000999999988,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.199000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 278.776,
      "heapDeltaBytes": 20165676,
      "heapUsedBytes": 84612520,
      "domNodes": -238,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 15.144000000000005,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2004.2049999999563,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.785000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 329.27500000000003,
      "heapDeltaBytes": -7928924,
      "heapUsedBytes": 79349352,
      "domNodes": -244,
      "jsHeapTotalBytes": -233472,
      "scriptDurationMs": 19.564999999999998,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 382.2059999999965,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 8.753999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 238.37800000000004,
      "heapDeltaBytes": 13729808,
      "heapUsedBytes": 83719620,
      "domNodes": 23,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 89.12299999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 398.93800000004376,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 9.013000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 239.791,
      "heapDeltaBytes": 13491036,
      "heapUsedBytes": 76860104,
      "domNodes": 22,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 88.242,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1993.8809999999876,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.185999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 257.023,
      "heapDeltaBytes": -6663128,
      "heapUsedBytes": 63477480,
      "domNodes": -272,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 4.68,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1993.2729999999879,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.074999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 259.06800000000004,
      "heapDeltaBytes": 11028328,
      "heapUsedBytes": 81043872,
      "domNodes": -272,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 4.834,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1674.0430000000401,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 12.220999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 438.36600000000004,
      "heapDeltaBytes": -8848836,
      "heapUsedBytes": 60163992,
      "domNodes": -270,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 67.19,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1688.603999999998,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 20.698,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 479.67499999999995,
      "heapDeltaBytes": -6773036,
      "heapUsedBytes": 56343332,
      "domNodes": -270,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 71.657,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 733.9059999999904,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 17.063000000000002,
      "layouts": 5,
      "layoutDurationMs": 7.336000000000002,
      "taskDurationMs": 499.53899999999993,
      "heapDeltaBytes": -6261316,
      "heapUsedBytes": 83864680,
      "domNodes": 13667,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 16.339000000000006,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 51,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8135.593000000028,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 37.648,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3360.575,
      "heapDeltaBytes": -5406852,
      "heapUsedBytes": 80461740,
      "domNodes": -233,
      "jsHeapTotalBytes": 253952,
      "scriptDurationMs": 1715.243,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8135.491999999999,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 37.744,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3332.944,
      "heapDeltaBytes": -17601864,
      "heapUsedBytes": 68889056,
      "domNodes": -210,
      "jsHeapTotalBytes": 5533696,
      "scriptDurationMs": 1700.6390000000001,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 9985.255999999992,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8904.666,
      "heapDeltaBytes": -29951428,
      "heapUsedBytes": 185226864,
      "domNodes": -8062,
      "jsHeapTotalBytes": -13426688,
      "scriptDurationMs": 111.43000000000002,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10067.409000000112,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9029.653,
      "heapDeltaBytes": -34104644,
      "heapUsedBytes": 192370100,
      "domNodes": -8062,
      "jsHeapTotalBytes": -17309696,
      "scriptDurationMs": 119.059,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 12984.617000000015,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.636000000000008,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12582.876,
      "heapDeltaBytes": -40809368,
      "heapUsedBytes": 185948900,
      "domNodes": -8062,
      "jsHeapTotalBytes": -10059776,
      "scriptDurationMs": 575.2629999999999,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 44,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 12872.751999999991,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.515999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12487.449,
      "heapDeltaBytes": -26596852,
      "heapUsedBytes": 194978140,
      "domNodes": -8062,
      "jsHeapTotalBytes": -19931136,
      "scriptDurationMs": 516.448,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 3674.6729999999843,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 47.72399999999999,
      "layouts": 20,
      "layoutDurationMs": 16.740000000000006,
      "taskDurationMs": 3593.281,
      "heapDeltaBytes": -24813228,
      "heapUsedBytes": 197819720,
      "domNodes": -8062,
      "jsHeapTotalBytes": 21700608,
      "scriptDurationMs": 52.443,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 3669.5819999999912,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 47.10599999999998,
      "layouts": 20,
      "layoutDurationMs": 16.977,
      "taskDurationMs": 3586.3329999999996,
      "heapDeltaBytes": -48511972,
      "heapUsedBytes": 178157484,
      "domNodes": -8062,
      "jsHeapTotalBytes": 18341888,
      "scriptDurationMs": 52.19800000000001,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5170.393000000047,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4576.421,
      "heapDeltaBytes": -14263728,
      "heapUsedBytes": 190528284,
      "domNodes": 0,
      "jsHeapTotalBytes": -35651584,
      "scriptDurationMs": 57.647000000000006,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5183.734000000072,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4641.938,
      "heapDeltaBytes": -1465444,
      "heapUsedBytes": 170480304,
      "domNodes": 0,
      "jsHeapTotalBytes": -29360128,
      "scriptDurationMs": 64.36599999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 416.56900000003816,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 15.662000000000003,
      "layouts": 3,
      "layoutDurationMs": 0.8040000000000002,
      "taskDurationMs": 75.083,
      "heapDeltaBytes": 4909632,
      "heapUsedBytes": 70371436,
      "domNodes": 124,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.507999999999999,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "workflow-execution",
      "durationMs": 54.84200000000783,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 7.827000000000001,
      "layouts": 2,
      "layoutDurationMs": 1.052,
      "taskDurationMs": 38.532,
      "heapDeltaBytes": 3003008,
      "heapUsedBytes": 68819940,
      "domNodes": 119,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 3.6899999999999986,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52316 79094 66.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.8% 1153
src/LGraphNode.ts 70.5% 382
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.1% 330
src/LGraph.ts 78.6% 272
src/scripts/app.ts 72.3% 259
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 1.3% 233
src/scripts/pnginfo.ts 20.8% 221

@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.13139% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ckages/account-core/src/core/webSessionIdentity.ts 85.38% 8 Missing and 11 partials ⚠️
@@              Coverage Diff              @@
##             cloud/1.55   #19021   +/-   ##
=============================================
  Coverage              ?   83.67%           
=============================================
  Files                 ?     3024           
  Lines                 ?   149476           
  Branches              ?    38366           
=============================================
  Hits                  ?   125079           
  Misses                ?    23075           
  Partials              ?     1322           
Flag Coverage Δ
billing-web-unit 88.44% <ø> (?)
e2e 66.13% <100.00%> (?)
unit 80.50% <86.02%> (?)
website-unit 76.24% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/account-core/src/core/sessionContracts.ts 66.66% <ø> (ø)
packages/account-core/src/web/crossTabRefresh.ts 77.96% <100.00%> (ø)
...ckages/account-core/src/core/webSessionIdentity.ts 86.20% <85.38%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 26, 2026

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified before approving. The file list is 10 against #18719's 6; the four extras (account-core package.json, smokePack.ts, importGuard.test.ts, webSessionIdentity.test.ts) are #18715's, because this branch is stacked on #19019 — which the description says. Once #19019 merges this reduces to #18719 alone. No conflict markers in the diff; all three required checks green.

Merging #19019 first.

@christian-byrne

Copy link
Copy Markdown
Contributor

Rebased onto current cloud/1.55 — the branch went DIRTY when the PRs ahead of it merged. Cherry-pick reapplied clean, no conflicts, same 6 files as the original. Force-pushed.

…ete on sign-out, heartbeat (#18719)

> **Stacked on #18715 (FE-2894) → #18710 (FE-2892). Do not merge** until
those merge and BE-17061 (C1) and BE-17063 (C3) are on testcloud (the
web session backend is not on staging yet). The base of this PR is the
FE-2894 branch.

## Why

With one shared session, signing in or out on one site has to reach
every open tab on every other site, and a tab must never finish Alice's
action as Bob. TDD §7, §12 and A8 define how: create the session only on
a real sign-in, delete it on sign-out, and run a heartbeat that notices
a remote sign-out or an account change and tells the app to reset.

## How

This extends the FE-2894 state machine rather than adding a second
module, so there is still one state and one pure transition.

- `signedIn(getProof)`: the host calls it only after an interactive
sign-in. A token refresh never creates a session.
- `signOut()`: signs the tab out at once, sends `DELETE
/api/auth/session` (which works on a dead session), and tells sibling
tabs.
- Heartbeat: `GET /session` every 10 minutes while the tab is visible,
and once when it becomes visible. The GET never extends the idle timer.
  - A new CSRF token is adopted silently.
  - `session_revoked` → signed out.
- `no_session`/`session_expired` → restore in place from the remembered
login, without bumping the epoch.
- `SESSION_UNAVAILABLE` and other ambiguous answers keep the user signed
in; the next beat tries again.
- Cross-tab: within one site, only a visible, signed-in tab holds the
lead and beats. Siblings adopt `ok` and `revoked` answers over the
existing broadcast port and validate each message with a schema before
adopting it.
- `CrossTabRefreshPort` gains a message type parameter (`<Message =
AccountCredential>`). The change is type-only, and the cloud app's
existing `createWebCrossTabRefreshPort()` call keeps the same runtime
behaviour.
- `createWebVisibilityPort()` joins `./web`, so the core still touches
no browser global.
- Account change: `onAccountChanged` fires on a remote sign-out, a
different user in any answer, and the host's own sign-out. `getEpoch()`
goes up on each change, and an answer started under an older epoch is
discarded. The host tags requests with the epoch and clears its own
caches, workspace selection and socket (FE-2903). `onSignedOutRemotely`
is the `session_signed_out_remotely` event (revoked only).
- Inert until `boot()`: nothing watches visibility or the channel before
then; the inert-import test now covers `./web`.
- Size: about 358 net non-test lines, over the ~300 guideline. If you
want it smaller, the split is cross-tab adoption + the visibility port +
the generic port type (~70 lines) into a follow-up, or the pure
transition into its own module.

## AS IS / TO BE

No UI; the evidence is tests with injected time, fake visibility and a
fake cross-tab port, no sleeps.

- AS IS: no session lifecycle or heartbeat.
- TO BE: `webSessionIdentity.lifecycle.test.ts` covers:
- a sign-out on another site reaching this tab at its next beat or on
focus;
- a different user in a heartbeat resetting state, with a pending answer
from the old epoch dropped;
  - a hidden tab never beating;
  - followers adopting instead of reading;
  - a token refresh never creating a session;
  - `SESSION_UNAVAILABLE` never signing out.

```
pnpm --filter @comfyorg/account-core test   Tests 1094 passed
pnpm --filter @comfyorg/account-core typecheck / lint   clean
pnpm typecheck   clean
pnpm knip        clean
pnpm fallow audit --base <FE-2894 branch>   No issues in 6 changed files
```

Mutation checks (each reverted):

| Mutation | Result |
| --- | --- |
| hidden tab beats | 2 red |
| followers read too | 1 red |
| heartbeat creates a session | 5 red |
| `SESSION_UNAVAILABLE` signs out | 1 red |
| old-epoch answer applied after an account change | 1 red |

For review:
- The CSRF token travels on the same-origin broadcast channel, the same
trust boundary the port already documents for the workspace token.
- `signOut()` calls `RememberedLogin.signOutLocally` itself, which may
overlap the host's own Firebase sign-out.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
(sections 7, 12, 15 F2, A8)
- Action items and dependency graph:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2897

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | `unified_web_session` client flag, off by default | BE-17135
to turn on; C11 for website/billing-web readers | #18708 |
| FE-2892 | account-core web session client + error codes | C1, C3
(BE-17063 generated types) | #18710, do not merge |
| FE-2893 | ADR for the shared web session | none | #18707 |
| FE-2901 | non-web clients stay on tokens (baseline) | FE-2895 for
`authorize()` rows | #18711 |
| FE-2894 | session-backed identity + boot rules (stacked on #18710) |
FE-2892, C3 | #18715, do not merge |
| FE-2895 | `authorize()` for cookie requests (stacked on #18710) |
FE-2892, C5 | #18716, do not merge |
| **FE-2897 (this PR)** | session lifecycle, heartbeat (stacked on
#18715) | FE-2894, C1, C3 | #18719, do not merge |
| FE-2906 | cross-origin E2E harness + §17 test ids | C3/C5/C6/C7 on
staging for the rows | #18718 (harness only) |
| FE-2896, 2898–2900, 2902–2905, 2907, 2908 | apps, token mint, rollout,
cleanup | C5/C6/C7/C8/C11 contracts | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2897 thisPr
```

- Blocked by: #18715 (FE-2894), #18710 (FE-2892), BE-17061 (C1),
BE-17063 (C3).
- Unblocks: FE-2903 (cloud app joins the lifecycle), and through it
FE-2904, FE-2905 and FE-2906 rows E2E-02/05/07.

---------

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
(cherry picked from commit 1685d33)
@christian-byrne
christian-byrne force-pushed the backport-18719-to-cloud-1.55 branch from f93f1ac to ead8b55 Compare September 27, 2026 05:47
@christian-byrne

Copy link
Copy Markdown
Contributor

Correction to my earlier note: that rebase never reached the branch. I pushed with a bare git push -f from a worktree branch that had no upstream configured, then reported success from the local SHA instead of the remote one — so the branch stayed on its original commit and showed DIRTY again.

Redone properly, with an explicit refspec and the remote SHA checked against local. The cherry-pick applies clean onto current cloud/1.55, no conflicts, same file list as the original.

@github-actions github-actions Bot added risk:high PR risk grade (advisory shadow check; grader-owned) and removed risk:xhigh PR risk grade (advisory shadow check; grader-owned) labels Sep 27, 2026
@christian-byrne
christian-byrne merged commit efb3ebd into cloud/1.55 Sep 27, 2026
112 checks passed
@christian-byrne
christian-byrne deleted the backport-18719-to-cloud-1.55 branch September 27, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants