Repository navigation
fix(website): a cancelled workflow run says so instead of emptying the panel - #19006
mariana953 wants to merge 5 commits into
Conversation
Stopping a run emptied the panel. The one state the reader caused themselves was the one the page said nothing about: the example went away, the placeholder came back, and the only word for what had happened sat under the panel advising a check of Cloud for a status Cloud had already given. The panel already draws a cancelled run — the sentence, and the way to run it again — for a model's half. It said "we stopped waiting", which is true of a request the page abandons and still may be billed for, and untrue of a workflow run Cloud cancelled and finished. So the sentence is the caller's to give, and both what is shown and what is read out follow it. The two waits the workflow page names on its own are in the same voice as the rest: handing the workflow over, and waiting its turn.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌐 Website E2ETip All tests passed.
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (9 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since fa0eaa59f943220784a60887e5d16685b3e56034
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19006.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-6x5kin9ty-comfyui.vercel.app Last updated: 2026-09-26T18:52:10Z for |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## mariana/v2-workflow-refusals #19006 +/- ##
=============================================================
Coverage 84.02% 84.02%
=============================================================
Files 3124 3124
Lines 153665 153664 -1
Branches 41734 41734
=============================================================
+ Hits 129110 129111 +1
+ Misses 22999 22998 -1
+ Partials 1556 1555 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…cancelled # Conflicts: # apps/website/src/components/workshop/WorkflowResults.vue
|
Included unmodified in #19255, which lands Mar's Hub V2 PRs together as part of the stack #18988 → #19023 → #19255 → #19256. Review fixes for this area are in #19256. Closing in favour of the stack. Your branch is untouched; for further changes, please open a PR on top of #19256 rather than pushing here. |
…te PRs (#19255) ## Summary Mar's Hub V2, staged as one reviewable phase. This combines the 23 PRs from her [#proj-comfy-hub post](https://comfy-organization.slack.com/archives/C0AEPRS8N74/p1790528696016959), including the latest head of #19004, while preserving her presentation and commit history. Review fixes remain isolated in #19256 above this PR. Design reference (not for review): #17804 · [V2 Hub preview](https://comfy-website-preview-pr-17804.vercel.app/hub/) ## Included **Independent:** #19031 Hub not Models · #18916 search with filter and sort · #18915 shorter workflows banner · #18979 filter chips · #19012 one "browse all" · #19016 shelf stops promising more · #18987 home hub workflows tab · #19025 Apps tab · #19090 filter named after what it filters · #19017 phone video controls · #19011 API tab endpoint · #19014 workflow header **Catalogue cards:** #18921 → #19015 **Workflow page V2:** #19009 → #19004 → #19008 → #19010 → #19029 **Run states:** #19005 → #19006 → #19007 → #19022 ## Integration with current main - Rebases the phase onto current `main`, including the canonical `/models/apps/<slug>/` routes and the separate Apps feature flag. - Keeps Mar's Apps shelf and card presentation while sourcing its entries and links from the canonical app catalogue. - Keeps Apps gated by `workshop-apps-enabled`; Workflows remain gated independently by `workshop-workflows-enabled`. - Keeps Mar's latest #19004 Details cleanup and single template-author attribution while retaining the later interactive graph work in #19008/#19010. - Resolves the combined `/models/` JavaScript budget to 1,820,000 bytes. ## Not included - #19241 (API tab rail): conflicts with #19011 and still needs a design call. - #19227 (draft), #17865 and #18306: not part of the Hub V2 set. ## Verification - Full website unit suite: 9,494 passed, 4 skipped. - Focused post-rebase app/catalogue suite: 98 passed. - Website typecheck: 0 errors. - Commit and push checks: formatting, lint, app/website typechecks, knip and Fallow passed. - `workshop-workflows-enabled` gates the home tab, catalogue tab, direct `?type=` URLs and detail pages without flashing gated content. --------- Co-authored-by: Mariana Martinho <mariana@comfy.org> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: github-actions <github-actions@github.com>
Summary
Stopping a workflow run emptied the output panel: the example went away, the placeholder came back, and the one state the reader caused themselves was the one the page said nothing about. The panel now says the run was cancelled and offers to run it again — the branch it already draws for a model's run, reached from the workflow half for the first time.
Stacked on #19005 — both change how the workflow page hands a settled state to the output panel. Review that one first; base retargets to
mainwhen it merges.Changes
WorkflowResultsgives the panel{ status: 'cancelled' }for a cancelled run instead of{ status: 'idle' }.PlaygroundOutputtakes an optionalcancelledMessage, used for both the visible sentence and the screen-reader announcement so the two cannot disagree. The stale paragraph under the panel is gone. The two waits the workflow page names on its own are reworded to the V2 voice: "Handing the workflow over" and "Waiting its turn".Appearance and copy only — the run engine is untouched: cancelling still goes through the same Cloud call and the same state machine.
Why the sentence is a prop and not the shared one: the panel's existing cancelled copy is "We stopped waiting for this result. Check your balance before you run it again." That is true of a model's run, where the page abandons a request that may still be billed. A workflow run is cancelled by Cloud and finished, so it says "This run was cancelled before it finished." The model half and the cinematic studio keep the sentence they had.
The paragraph that was removed said "Cancellation requested. Check Cloud for the final job status." It rendered only once the run's state was cancelled — advising a check for a status Cloud had already given — and the panel now carries the news. The pending case is unaffected: "Waiting for cancellation…" still appears on the Run button while the cancel is in flight.
Review Focus
isExpiredis only ever true for a succeeded run, so the panel'sexpiredbranch cannot swallow the new cancelled one. Confirmed inworkshop-run.ts.workshop.workflow.cancelRequestedis still reachable (a cancelled observation followed by an error puts the page ininterrupted, where the status label is read), so it is not dead and stays.interruptedit waits on the reader pressing "Reconnect to this run", but the panel spins a loader and counts seconds as though something were in progress. Mariana's design has no equivalent state (hers reconnects by itself), so what the panel should show instead is a design decision, not a fix to slip in.Covered by three cases in
WorkflowResults.test.tsand the updated flow inworkshop-workflow-runs.spec.ts.Screenshots (if applicable)
Cancelling needs a live Cloud run, so this state cannot be produced against the local dev server; it is asserted in the tests rather than screenshotted. The preview link goes in the thread once
deploy-previewpasses.