Skip to content

fix(website): a cancelled workflow run says so instead of emptying the panel - #19006

Closed
mariana953 wants to merge 5 commits into
mariana/v2-workflow-refusalsfrom
mariana/v2-workflow-cancelled
Closed

mariana953 wants to merge 5 commits into
mariana/v2-workflow-refusalsfrom
mariana/v2-workflow-cancelled

Conversation

@mariana953

@mariana953 mariana953 commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Stopping a workflow run emptied the output panel: the example went away, the placeholder came back, and the one state the reader caused themselves was the one the page said nothing about. The panel now says the run was cancelled and offers to run it again — the branch it already draws for a model's run, reached from the workflow half for the first time.

Stacked on #19005 — both change how the workflow page hands a settled state to the output panel. Review that one first; base retargets to main when it merges.

Changes

  • What: WorkflowResults gives the panel { status: 'cancelled' } for a cancelled run instead of { status: 'idle' }. PlaygroundOutput takes an optional cancelledMessage, used for both the visible sentence and the screen-reader announcement so the two cannot disagree. The stale paragraph under the panel is gone. The two waits the workflow page names on its own are reworded to the V2 voice: "Handing the workflow over" and "Waiting its turn".
  • Breaking: none.

Appearance and copy only — the run engine is untouched: cancelling still goes through the same Cloud call and the same state machine.

Why the sentence is a prop and not the shared one: the panel's existing cancelled copy is "We stopped waiting for this result. Check your balance before you run it again." That is true of a model's run, where the page abandons a request that may still be billed. A workflow run is cancelled by Cloud and finished, so it says "This run was cancelled before it finished." The model half and the cinematic studio keep the sentence they had.

The paragraph that was removed said "Cancellation requested. Check Cloud for the final job status." It rendered only once the run's state was cancelled — advising a check for a status Cloud had already given — and the panel now carries the news. The pending case is unaffected: "Waiting for cancellation…" still appears on the Run button while the cancel is in flight.

Review Focus

  • isExpired is only ever true for a succeeded run, so the panel's expired branch cannot swallow the new cancelled one. Confirmed in workshop-run.ts.
  • workshop.workflow.cancelRequested is still reachable (a cancelled observation followed by an error puts the page in interrupted, where the status label is read), so it is not dead and stays.
  • Both reworded keys are used only by the workflow page. The browser test that asserted the old empty panel and the old label now asserts the new ones.
  • Not covered here, and named rather than guessed at: while the page is interrupted it waits on the reader pressing "Reconnect to this run", but the panel spins a loader and counts seconds as though something were in progress. Mariana's design has no equivalent state (hers reconnects by itself), so what the panel should show instead is a design decision, not a fix to slip in.

Covered by three cases in WorkflowResults.test.ts and the updated flow in workshop-workflow-runs.spec.ts.

Screenshots (if applicable)

Cancelling needs a live Cloud run, so this state cannot be produced against the local dev server; it is asserted in the tests rather than screenshotted. The preview link goes in the thread once deploy-preview passes.

Stopping a run emptied the panel. The one state the reader caused themselves
was the one the page said nothing about: the example went away, the placeholder
came back, and the only word for what had happened sat under the panel advising
a check of Cloud for a status Cloud had already given.

The panel already draws a cancelled run — the sentence, and the way to run it
again — for a model's half. It said "we stopped waiting", which is true of a
request the page abandons and still may be billed for, and untrue of a workflow
run Cloud cancelled and finished. So the sentence is the caller's to give, and
both what is shown and what is read out follow it.

The two waits the workflow page names on its own are in the same voice as the
rest: handing the workflow over, and waiting its turn.
@vercel

vercel Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 26, 2026 6:50pm UTC
billing-web-test Skipped Skipped Sep 26, 2026 6:50pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 528c16cb-84f0-412f-bc24-2585c2155bb6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (9 changed files).

Kind Finding Where Usual remedy
Complexity <template>() — cyclomatic 66, CRAP undefined apps/website/src/components/workshop/PlaygroundOutput.vue:299 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.

Pre-existing findings are baselined in .fallow-baselines/ and are not your
responsibility — see ADR-DEVEX-LINT-0015.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since fa0eaa59f943220784a60887e5d16685b3e56034

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-19006.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-6x5kin9ty-comfyui.vercel.app

Last updated: 2026-09-26T18:52:10Z for 6331dc5

@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ebsite/src/components/workshop/WorkflowResults.vue 0.00% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@                      Coverage Diff                      @@
##           mariana/v2-workflow-refusals   #19006   +/-   ##
=============================================================
  Coverage                         84.02%   84.02%           
=============================================================
  Files                              3124     3124           
  Lines                            153665   153664    -1     
  Branches                          41734    41734           
=============================================================
+ Hits                             129110   129111    +1     
+ Misses                            22999    22998    -1     
+ Partials                           1556     1555    -1     
Flag Coverage Δ
website-unit 78.01% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...bsite/src/components/workshop/PlaygroundOutput.vue 91.11% <100.00%> (ø)
...ebsite/src/components/workshop/WorkflowResults.vue 75.58% <0.00%> (+2.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 26, 2026
…cancelled

# Conflicts:
#	apps/website/src/components/workshop/WorkflowResults.vue
@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 26, 2026 16:22 Inactive
@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 26, 2026 17:52 Inactive
@benjcooley

Copy link
Copy Markdown
Collaborator

Included unmodified in #19255, which lands Mar's Hub V2 PRs together as part of the stack #18988 → #19023 → #19255 → #19256. Review fixes for this area are in #19256. Closing in favour of the stack. Your branch is untouched; for further changes, please open a PR on top of #19256 rather than pushing here.

@benjcooley benjcooley closed this Sep 28, 2026
benjcooley added a commit that referenced this pull request Sep 28, 2026
…te PRs (#19255)

## Summary

Mar's Hub V2, staged as one reviewable phase. This combines the 23 PRs
from her [#proj-comfy-hub
post](https://comfy-organization.slack.com/archives/C0AEPRS8N74/p1790528696016959),
including the latest head of #19004, while preserving her presentation
and commit history. Review fixes remain isolated in #19256 above this
PR.

Design reference (not for review): #17804 · [V2 Hub
preview](https://comfy-website-preview-pr-17804.vercel.app/hub/)

## Included

**Independent:** #19031 Hub not Models · #18916 search with filter and
sort · #18915 shorter workflows banner · #18979 filter chips · #19012
one "browse all" · #19016 shelf stops promising more · #18987 home hub
workflows tab · #19025 Apps tab · #19090 filter named after what it
filters · #19017 phone video controls · #19011 API tab endpoint · #19014
workflow header

**Catalogue cards:** #18921 → #19015

**Workflow page V2:** #19009 → #19004 → #19008 → #19010 → #19029

**Run states:** #19005 → #19006 → #19007 → #19022

## Integration with current main

- Rebases the phase onto current `main`, including the canonical
`/models/apps/<slug>/` routes and the separate Apps feature flag.
- Keeps Mar's Apps shelf and card presentation while sourcing its
entries and links from the canonical app catalogue.
- Keeps Apps gated by `workshop-apps-enabled`; Workflows remain gated
independently by `workshop-workflows-enabled`.
- Keeps Mar's latest #19004 Details cleanup and single template-author
attribution while retaining the later interactive graph work in
#19008/#19010.
- Resolves the combined `/models/` JavaScript budget to 1,820,000 bytes.

## Not included

- #19241 (API tab rail): conflicts with #19011 and still needs a design
call.
- #19227 (draft), #17865 and #18306: not part of the Hub V2 set.

## Verification

- Full website unit suite: 9,494 passed, 4 skipped.
- Focused post-rebase app/catalogue suite: 98 passed.
- Website typecheck: 0 errors.
- Commit and push checks: formatting, lint, app/website typechecks, knip
and Fallow passed.
- `workshop-workflows-enabled` gates the home tab, catalogue tab, direct
`?type=` URLs and detail pages without flashing gated content.

---------

Co-authored-by: Mariana Martinho <mariana@comfy.org>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions <github-actions@github.com>

This branch was previously deployed

1 inactive deployment
Preview – billing-web-test — 6331dc5a Deployed Sep 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants