Repository navigation
test(website): stand every output-panel state up in stories - #19007
mariana953 wants to merge 5 commits into
Conversation
… it can be looked at A run costs credits and most of the panel's states cannot be reached on purpose at all: a provider failing, a wallet emptying mid-run, a connection going. The words in them were written where nobody could see them, and the only way anyone has checked one is to read the code. The panel now stands up in stories: each wait, each result, the two cancelled sentences, and every refusal the shared vocabulary has words for, including the three that read differently because of who the reader is or what they sent. The waits and the sentences are pulled from the copy rather than typed out again, so a story cannot quietly disagree with the page.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌐 Website E2ETip All tests passed.
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6331dc5a3e8465fcdda13baf281d62a9b4cd0036
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19007.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-3sqgy2lls-comfyui.vercel.app Last updated: 2026-09-26T18:52:41Z for |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## mariana/v2-workflow-cancelled #19007 +/- ##
==============================================================
Coverage 84.02% 84.02%
==============================================================
Files 3124 3124
Lines 153664 153664
Branches 41734 41734
==============================================================
Hits 129111 129111
Misses 22998 22998
Partials 1555 1555
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Included unmodified in #19255, which lands Mar's Hub V2 PRs together as part of the stack #18988 → #19023 → #19255 → #19256. Review fixes for this area are in #19256. Closing in favour of the stack. Your branch is untouched; for further changes, please open a PR on top of #19256 rather than pushing here. |
…te PRs (#19255) ## Summary Mar's Hub V2, staged as one reviewable phase. This combines the 23 PRs from her [#proj-comfy-hub post](https://comfy-organization.slack.com/archives/C0AEPRS8N74/p1790528696016959), including the latest head of #19004, while preserving her presentation and commit history. Review fixes remain isolated in #19256 above this PR. Design reference (not for review): #17804 · [V2 Hub preview](https://comfy-website-preview-pr-17804.vercel.app/hub/) ## Included **Independent:** #19031 Hub not Models · #18916 search with filter and sort · #18915 shorter workflows banner · #18979 filter chips · #19012 one "browse all" · #19016 shelf stops promising more · #18987 home hub workflows tab · #19025 Apps tab · #19090 filter named after what it filters · #19017 phone video controls · #19011 API tab endpoint · #19014 workflow header **Catalogue cards:** #18921 → #19015 **Workflow page V2:** #19009 → #19004 → #19008 → #19010 → #19029 **Run states:** #19005 → #19006 → #19007 → #19022 ## Integration with current main - Rebases the phase onto current `main`, including the canonical `/models/apps/<slug>/` routes and the separate Apps feature flag. - Keeps Mar's Apps shelf and card presentation while sourcing its entries and links from the canonical app catalogue. - Keeps Apps gated by `workshop-apps-enabled`; Workflows remain gated independently by `workshop-workflows-enabled`. - Keeps Mar's latest #19004 Details cleanup and single template-author attribution while retaining the later interactive graph work in #19008/#19010. - Resolves the combined `/models/` JavaScript budget to 1,820,000 bytes. ## Not included - #19241 (API tab rail): conflicts with #19011 and still needs a design call. - #19227 (draft), #17865 and #18306: not part of the Hub V2 set. ## Verification - Full website unit suite: 9,494 passed, 4 skipped. - Focused post-rebase app/catalogue suite: 98 passed. - Website typecheck: 0 errors. - Commit and push checks: formatting, lint, app/website typechecks, knip and Fallow passed. - `workshop-workflows-enabled` gates the home tab, catalogue tab, direct `?type=` URLs and detail pages without flashing gated content. --------- Co-authored-by: Mariana Martinho <mariana@comfy.org> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: github-actions <github-actions@github.com>
Summary
A run costs credits and most of the output panel's states cannot be reached on purpose at all — a provider failing, a wallet emptying mid-run, a connection going. The words in them were written where nobody could see them. This stands every one of them up in Storybook.
Third of a stack: #19005 → #19006 → this. Base retargets as each merges.
Changes
PlaygroundOutput.stories.ts— idle, the example, a finished image, a finished video, a sensitive result, an expired link, both cancelled sentences, every wait the two pages name, and every refusal including the three that read differently because of who the reader is or what they sent.The waits and the sentences are read from
translations.tsrather than typed out again, so a story cannot quietly disagree with the page. The refusals and the waits are tables the stories map over rather than copied blocks, so adding a reason means adding a row.Review Focus
validationis deliberately not in the plain refusal list: it is only ever one of the three variants below it (pinned to a field, pinned to nothing, an unreadable file), and each takes a different branch in the component.concurrencyandconflict, are reachable only from the model half today. They are still in the stories because the panel is shared and its sentence for them is live copy.Screenshots (if applicable)
Storybook needs a developer's machine, so for the designer these states are also written out as a page she can open, with the exact sentence for each. Nothing in this PR changes what a visitor sees.