Skip to content

test(website): stand every output-panel state up in stories - #19007

Closed
mariana953 wants to merge 5 commits into
mariana/v2-workflow-cancelledfrom
mariana/v2-workflow-state-stories
Closed

mariana953 wants to merge 5 commits into
mariana/v2-workflow-cancelledfrom
mariana/v2-workflow-state-stories

Conversation

@mariana953

@mariana953 mariana953 commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

A run costs credits and most of the output panel's states cannot be reached on purpose at all — a provider failing, a wallet emptying mid-run, a connection going. The words in them were written where nobody could see them. This stands every one of them up in Storybook.

Third of a stack: #19005 → #19006 → this. Base retargets as each merges.

Changes

  • What: PlaygroundOutput.stories.ts — idle, the example, a finished image, a finished video, a sensitive result, an expired link, both cancelled sentences, every wait the two pages name, and every refusal including the three that read differently because of who the reader is or what they sent.
  • Breaking: none. Stories only; no component or page change.

The waits and the sentences are read from translations.ts rather than typed out again, so a story cannot quietly disagree with the page. The refusals and the waits are tables the stories map over rather than copied blocks, so adding a reason means adding a row.

Review Focus

  • validation is deliberately not in the plain refusal list: it is only ever one of the three variants below it (pinned to a field, pinned to nothing, an unreadable file), and each takes a different branch in the component.
  • Two reasons in the list, concurrency and conflict, are reachable only from the model half today. They are still in the stories because the panel is shared and its sentence for them is live copy.
  • The media URLs are the same ones the catalogue already serves.

Screenshots (if applicable)

Storybook needs a developer's machine, so for the designer these states are also written out as a page she can open, with the exact sentence for each. Nothing in this PR changes what a visitor sees.

… it can be looked at

A run costs credits and most of the panel's states cannot be reached on purpose
at all: a provider failing, a wallet emptying mid-run, a connection going. The
words in them were written where nobody could see them, and the only way anyone
has checked one is to read the code.

The panel now stands up in stories: each wait, each result, the two cancelled
sentences, and every refusal the shared vocabulary has words for, including the
three that read differently because of who the reader is or what they sent. The
waits and the sentences are pulled from the copy rather than typed out again, so
a story cannot quietly disagree with the page.
@vercel

vercel Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 26, 2026 6:50pm UTC
billing-web-test Skipped Skipped Sep 26, 2026 6:50pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: c19331ad-c9f2-4905-8ac6-9157ed45bf3d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 6331dc5a3e8465fcdda13baf281d62a9b4cd0036

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-19007.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-3sqgy2lls-comfyui.vercel.app

Last updated: 2026-09-26T18:52:41Z for 93380eb

@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                      Coverage Diff                       @@
##           mariana/v2-workflow-cancelled   #19007   +/-   ##
==============================================================
  Coverage                          84.02%   84.02%           
==============================================================
  Files                               3124     3124           
  Lines                             153664   153664           
  Branches                           41734    41734           
==============================================================
  Hits                              129111   129111           
  Misses                             22998    22998           
  Partials                            1555     1555           
Flag Coverage Δ
website-unit 78.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 26, 2026
@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 26, 2026 16:22 Inactive
@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 26, 2026 17:52 Inactive
@benjcooley

Copy link
Copy Markdown
Collaborator

Included unmodified in #19255, which lands Mar's Hub V2 PRs together as part of the stack #18988 → #19023 → #19255 → #19256. Review fixes for this area are in #19256. Closing in favour of the stack. Your branch is untouched; for further changes, please open a PR on top of #19256 rather than pushing here.

@benjcooley benjcooley closed this Sep 28, 2026
benjcooley added a commit that referenced this pull request Sep 28, 2026
…te PRs (#19255)

## Summary

Mar's Hub V2, staged as one reviewable phase. This combines the 23 PRs
from her [#proj-comfy-hub
post](https://comfy-organization.slack.com/archives/C0AEPRS8N74/p1790528696016959),
including the latest head of #19004, while preserving her presentation
and commit history. Review fixes remain isolated in #19256 above this
PR.

Design reference (not for review): #17804 · [V2 Hub
preview](https://comfy-website-preview-pr-17804.vercel.app/hub/)

## Included

**Independent:** #19031 Hub not Models · #18916 search with filter and
sort · #18915 shorter workflows banner · #18979 filter chips · #19012
one "browse all" · #19016 shelf stops promising more · #18987 home hub
workflows tab · #19025 Apps tab · #19090 filter named after what it
filters · #19017 phone video controls · #19011 API tab endpoint · #19014
workflow header

**Catalogue cards:** #18921 → #19015

**Workflow page V2:** #19009 → #19004 → #19008 → #19010 → #19029

**Run states:** #19005 → #19006 → #19007 → #19022

## Integration with current main

- Rebases the phase onto current `main`, including the canonical
`/models/apps/<slug>/` routes and the separate Apps feature flag.
- Keeps Mar's Apps shelf and card presentation while sourcing its
entries and links from the canonical app catalogue.
- Keeps Apps gated by `workshop-apps-enabled`; Workflows remain gated
independently by `workshop-workflows-enabled`.
- Keeps Mar's latest #19004 Details cleanup and single template-author
attribution while retaining the later interactive graph work in
#19008/#19010.
- Resolves the combined `/models/` JavaScript budget to 1,820,000 bytes.

## Not included

- #19241 (API tab rail): conflicts with #19011 and still needs a design
call.
- #19227 (draft), #17865 and #18306: not part of the Hub V2 set.

## Verification

- Full website unit suite: 9,494 passed, 4 skipped.
- Focused post-rebase app/catalogue suite: 98 passed.
- Website typecheck: 0 errors.
- Commit and push checks: formatting, lint, app/website typechecks, knip
and Fallow passed.
- `workshop-workflows-enabled` gates the home tab, catalogue tab, direct
`?type=` URLs and detail pages without flashing gated content.

---------

Co-authored-by: Mariana Martinho <mariana@comfy.org>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions <github-actions@github.com>

This branch was previously deployed

1 inactive deployment
Preview – billing-web-test — 93380eb8 Deployed Sep 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants