Repository navigation
feat(website): move the catalogue tabs down beside the controls - #18862
Conversation
…back link The three pieces of the catalogue shell each knew one section's copy. The hero read its own translation keys, the banner took models and projected them itself, and the back link could only return to /models. They now take what they show: resolved copy, a FeaturedSlide, and the listing to return to. The slide shape stays with the banner so a catalogue holding no models can render it without pulling the model catalogue in behind it; modelSlides builds one from a WorkshopModel and is imported only where models are. No visible change: same copy, same layout, same media on both pages.
The tabs sat in the hero's eyebrow, above the heading, announcing the page. They belong with the search and the order that act on the list, so they move into the sticky bar those already share, at its left. Apps has no list of its own, so it carries the bar for the tabs alone; without it there is no way back out of that half. The hero's eyebrow line shows again, which is what the design asks for. The guard on the tabs stays only where it decides anything: reaching the workflows or apps half means workflows exist, since the active tab falls back to models while there are none.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (14)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe workshop catalogue now uses explicit featured-slide data, places its tabs beside catalogue controls, and passes resolved text and catalogue URLs to shared components. Tests cover slide rendering, tab focus, back-link URLs, and toolbar visibility at selected viewport widths. ChangesWorkshop catalogue
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The catalogue changes are mergeable after normal checks; no outstanding issue is established. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to Current featured-banner callers still use model-derived slides, and the return link remains on the website. No newly reachable security issue was established. URL restrictions and coverage of other potential callers remain uncertain. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Hardening Proposals
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🌐 Website E2ETip All tests passed.
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6919c12e2e185346ffbd5352213f22b9bb506ea5
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-18862.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-55lcsap2p-comfyui.vercel.app Last updated: 2026-09-25T15:33:47Z for |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #18862 +/- ##
==========================================
- Coverage 83.94% 83.92% -0.02%
==========================================
Files 3063 3029 -34
Lines 151677 150949 -728
Branches 41195 39108 -2087
==========================================
- Hits 127325 126691 -634
+ Misses 22920 22874 -46
+ Partials 1432 1384 -48
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 41 files with indirect coverage changes 🚀 New features to boost your workflow:
|
The back link appended the shelf behind a second question mark, so a listing that already carried a query lost it. The featured banner read its media url during setup, before the template's guard, so a catalogue with nothing to feature threw.
benjcooley
left a comment
There was a problem hiding this comment.
👨💻 BILL — SHOULD FIX: two regressions at 3c95df3a; please address before merging.
- Switching catalogue tabs by keyboard removes the focused control and drops focus to the page body.
- At 640–768px wide, the Models toolbar clips the Filter/Sort controls offscreen.
Both reproduced on the production build and compared against #18857, where they pass. Keep Mar's placement/design; these need focus preservation and responsive fitting, not a restyle. The existing tests miss both cases.
Production build, 80 focused unit tests and 18 existing desktop/mobile browser tests passed, including model validation/run submission, Cloud workflow recovery/download/cancellation, disabled flags and /models/ bundle budgets. Independent keyboard-sort probe passed; the two regression probes failed as described. Findings sent to FE-2736; branch unchanged.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 2 |
| TRIVIAL | 0 |
benjcooley
left a comment
There was a problem hiding this comment.
👨💻 BILL — accepted at 67e4804405.
Both SHOULD FIX items are fixed. Independently reproduced keyboard focus restoration through all six tab-switch directions, including a deliberately delayed WorkflowCatalogue chunk; first render does not take focus. The original overflow probe now passes at 320, 390, 639, 640, 700, 768 and 1024px, and the new viewport assertions pass. Mar's presentation is preserved.
Fresh production build, 64 focused unit tests and 24 browser tests passed. These include the original reproductions, keyboard sorting, model validation/submission, Cloud workflow recovery/download/cancellation, flag-off behavior and /models/ JavaScript budgets. No new actionable findings. Branch unchanged.
CI is still finishing; approval is for this exact head, with normal merge-queue checks still required.
| Severity | Remaining |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
benjcooley
left a comment
There was a problem hiding this comment.
👨💻 BILL — accepted at 36b3c92c66.
The inherited Workflows tablet overflow is fixed. The regression now covers both catalogue halves at 640, 700 and 768px, and the earlier tab-focus fix remains intact.
Verified locally on a fresh production build: 493 component unit tests and 25 focused browser checks passed. An independent probe waited for fonts to load: Sort's right edge is 616 / 676 / 744px at viewport widths 640 / 700 / 768px, respectively. All requested controls fit.
No remaining review findings. Source branch unchanged. CI is still finishing; normal required checks must pass before merging.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
…fy-Org#18868) ## Summary An outcome is reached through the model it runs on as often as through the task it performs. The workflows half's filter gains a second group listing those models, the way the V2 design's browse toolbar does. Third of the V2 stack. Stacked on [Comfy-Org#18862](Comfy-Org#18862), which is stacked on [Comfy-Org#18857](Comfy-Org#18857). ## Changes - **What**: - `WorkshopFilterMenu.vue` takes an optional `modelOptions` and a `models` v-model, and adds a second facet group when the caller has one. `FacetSheet` already switched between groups and counted them, so the sheet, its per-group search, the applied count and Clear all needed no change. - `WorkflowCatalogue.vue` builds those options from the models each outcome stands on, with a count each, sorted by how many workflows use them. The choice narrows the list, reads back from `?model=`, and Clear all drops it with the categories. - **Breaking**: none. - **Dependencies**: none. ## Review Focus **Why in the filter rather than beside it**: the 30 launch workflows name 19 distinct models, 12 of them used once. A row of chips would be mostly ones. Inside the sheet they sit behind one control with a count, as the categories already do. **A workflow can stand on several models** (`Connect two images with motion` runs on Wan 2.2 and SeedVR2), so the match is "any of the chosen", not "all". **Choosing a model leaves the outcome rows** for the flat result grid, the same way a category or a search does — the rows are a browse state, and a filtered list is not browsing. ## Tests Component: choosing a model narrows the list and Clear all restores it; choosing two keeps every outcome that stands on either, so an intersection in place of the union fails; a shared URL restores a model the catalogue lists and drops one it does not. Reverting the filter turns these red, and removing `models.value = []` from Clear all turns the first one red. Browser (`e2e/workshop-workflows.spec.ts`): one case counts the outcomes at each step — 30 while browsing, 7 for LTX-2.3, 9 with SeedVR2 added, 30 again after Clear all, and 7 from `?type=workflows&model=LTX-2.3`. Rebuilding with the predicate changed to require every selected model takes the union assertion from 9 to 0. 497 component tests pass across `src/components/workshop/`, and all 12 tests in that spec pass against a production preview; `eslint apps/website`, `oxlint --type-aware`, `typecheck:website` and `fallow audit` are clean. ## Screenshots (if applicable) Captured from a local build of this branch — the preview on this PR is the place to judge it. | | | | --- | --- | | Filter → Model | the group lists the 19 models with a count each, LTX-2.3 leading at 7 | | One chosen | the 7 LTX-2.3 outcomes, the Filter control carrying a 1 | --------- Co-authored-by: benjcooley <benjcooley@gmail.com>
Summary
The Models / Workflows / Apps tabs move out of the hero and into the sticky bar that already holds the search and the order, at its left — the first visible step of the V2 catalogue design.
Second of three. Stacked on #18857, which made the hero take resolved copy so it could give its eyebrow line back.
Changes
WorkshopModelsGrid.vueandWorkflowCatalogue.vuetake atabsslot at the start of their sticky bar, and both bars now carrydata-testid="workshop-toolbar".ModelsCatalogue.vuestops renderingCatalogueTabsin the hero's#eyebrowslot and in its own body, and passes them into each half's bar instead. Apps has no list of its own, so it gets a bar carrying only the tabs.Review Focus
Apps would have become a dead end. It is a "coming soon" panel with no toolbar, so putting the tabs only inside the two halves that have one would have left no way back. It carries the same bar for the tabs alone.
Two of the three
v-if="workflows.length"guards were dead and are gone.activeTabisworkflows.value.length ? selectedTab.value : 'models', so the workflows and apps halves are unreachable when there are no workflows; only the models half can render with none. Keeping all three pushed the template past thefallowcognitive threshold, which is what surfaced it.Not in this PR, though the design has them: the shorter (
compact) banner and the outcome rows. The model filter on the workflows half is the next PR in the stack. The prototype's whole browse stack is about 1,800 lines; taking it in one go would not be reviewable. This is the piece that changes where things sit.Tests: a table over the three halves asserting the tabs render inside
workshop-toolbarand not insideworkshop-hero. Removing the slot from either half turns it red. 492 tests pass acrosssrc/components/workshop/;eslint,oxlint --type-aware,typecheck:website,knipandfallow auditare clean.Screenshots (if applicable)
Captured from a local build of this branch — the preview on this PR is the place to judge it.