Skip to content

fix(website): serve workflow graph files from a website-owned path - #18800

Merged
benjcooley merged 3 commits into
mainfrom
benjcooley/workshop-workflow-graph-path
Sep 25, 2026
Merged

benjcooley merged 3 commits into
mainfrom
benjcooley/workshop-workflow-graph-path

Conversation

@benjcooley

@benjcooley benjcooley commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Workflow graph previews and "Download workflow" links 404 in production because comfy.org routes /workflows/* to the Workflow Hub app, which hides the website's /workflows/prepared/* files. This moves them to /workflow-graphs/, which production routes to the website.

Changes

  • What: Moves the 30 prepared graph JSON/SVG pairs unchanged (all 100% renames) to public/workflow-graphs/ and updates the catalog URLs, schema, generator script, and READMEs. A regression test requires every workflow's preview and download URL to stay under /workflow-graphs/ and point to an existing file.

Review Focus

  • Production today: https://comfy.org/workflows/prepared/change-material.json returns Vercel NOT_FOUND from the Hub project, while the PR preview serves it. This also affects the three workflows shipped in the earlier PR.
  • Not under /models/: the release gate rejects any dist/models/ entry besides index.html when WORKSHOP_IN_BUILD=0, which failed the first push. Production routes /workflow-graphs/* to the website (x-served-by: vercel-website).
  • Verified locally: the release build (WORKSHOP_IN_BUILD=0) passes, and the Workshop-enabled build serves /workflow-graphs/*.json|svg with the correct content types; the full website unit suite (8,948) and 110 Workshop/Models browser tests pass.

Related: FE-2736, follow-up to #18763.

@benjcooley
benjcooley requested review from a team September 25, 2026 05:50
@vercel

vercel Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 25, 2026 2:40pm UTC
billing-web-test Skipped Skipped Sep 25, 2026 2:40pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 22f7d6a501d1eefc3df31572a589fcdffbbe0681

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-18800.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-e5as0r5xk-comfyui.vercel.app

Last updated: 2026-09-25T15:57:34Z for a1be4f0

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a3dbbc45-548d-4834-8d9d-979627368dac

📥 Commits

Reviewing files that changed from the base of the PR and between 22f7d6a and a1be4f0.

⛔ Files ignored due to path filters (30)
  • apps/website/public/workflow-graphs/animate-reference-sheet.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/change-material.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/change-video-background.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/character-turnaround.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/connect-images-with-motion.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/edit-selected-region.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/editable-layers.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/expand-video-frame.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/extend-image-borders.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/image-to-video.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/match-lighting.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/motion-transfer.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/new-angle.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/product-in-scene.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/product-mockup.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/product-photo-to-video.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/remove-background.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/remove-object-from-video.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/remove-object.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/replace-character.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/restore-archival-footage.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/restore-portrait.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/sharpen-product-photo.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/singing-character.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/talking-character.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/upscale-and-restore.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/upscale-illustration.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/upscale-video.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/video-from-references.svg is excluded by !**/*.svg
  • apps/website/public/workflow-graphs/virtual-try-on.svg is excluded by !**/*.svg
📒 Files selected for processing (38)
  • apps/website/README.md
  • apps/website/e2e/workshop-workflows.spec.ts
  • apps/website/public/workflow-graphs/animate-reference-sheet.json
  • apps/website/public/workflow-graphs/change-material.json
  • apps/website/public/workflow-graphs/change-video-background.json
  • apps/website/public/workflow-graphs/character-turnaround.json
  • apps/website/public/workflow-graphs/connect-images-with-motion.json
  • apps/website/public/workflow-graphs/edit-selected-region.json
  • apps/website/public/workflow-graphs/editable-layers.json
  • apps/website/public/workflow-graphs/expand-video-frame.json
  • apps/website/public/workflow-graphs/extend-image-borders.json
  • apps/website/public/workflow-graphs/image-to-video.json
  • apps/website/public/workflow-graphs/match-lighting.json
  • apps/website/public/workflow-graphs/motion-transfer.json
  • apps/website/public/workflow-graphs/new-angle.json
  • apps/website/public/workflow-graphs/product-in-scene.json
  • apps/website/public/workflow-graphs/product-mockup.json
  • apps/website/public/workflow-graphs/product-photo-to-video.json
  • apps/website/public/workflow-graphs/remove-background.json
  • apps/website/public/workflow-graphs/remove-object-from-video.json
  • apps/website/public/workflow-graphs/remove-object.json
  • apps/website/public/workflow-graphs/replace-character.json
  • apps/website/public/workflow-graphs/restore-archival-footage.json
  • apps/website/public/workflow-graphs/restore-portrait.json
  • apps/website/public/workflow-graphs/sharpen-product-photo.json
  • apps/website/public/workflow-graphs/singing-character.json
  • apps/website/public/workflow-graphs/talking-character.json
  • apps/website/public/workflow-graphs/upscale-and-restore.json
  • apps/website/public/workflow-graphs/upscale-illustration.json
  • apps/website/public/workflow-graphs/upscale-video.json
  • apps/website/public/workflow-graphs/video-from-references.json
  • apps/website/public/workflow-graphs/virtual-try-on.json
  • apps/website/scripts/prepare-workflow-previews.test.ts
  • apps/website/scripts/prepare-workflow-previews.ts
  • apps/website/src/config/workshop-workflow-content.test.ts
  • apps/website/src/config/workshop-workflow-definition.ts
  • apps/website/src/content/README.md
  • apps/website/src/content/workshop-display.json

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Workflow preview generation, URL validation, tests, and documentation now use public/workflow-graphs instead of public/workflows/prepared. The executable graph path remains source.path.

Changes

Workflow graph path migration

Layer / File(s) Summary
Move generated graph outputs
apps/website/scripts/prepare-workflow-previews.ts, apps/website/scripts/prepare-workflow-previews.test.ts, apps/website/README.md
The preview script writes JSON and SVG files to public/workflow-graphs. Its test and the website README use the same directory.
Update workflow URL contract and checks
apps/website/src/config/workshop-workflow-definition.ts, apps/website/src/config/workshop-workflow-content.test.ts, apps/website/src/content/README.md
The schema requires preview and download URLs under /workflow-graphs/. The curated-workflow test checks that the URLs resolve to files. The content README documents the new directory.
Verify preview and download links
apps/website/e2e/workshop-workflows.spec.ts
The workflow launch test checks the preview and download paths, successful responses, and SVG and JSON content types.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: benceruleanlu

Merge Risk: ⚪ Minimal · up to a1be4

Workflow preview and download assets now use /workflow-graphs/ consistently. Repository evidence does not confirm the effective production routing, but it also does not establish a merge-blocking failure.

Security Architecture Review

Security architecture risk: 🔵 Low · up to a1be4

The change is intended to make workflow graph files publicly available from the website. The generation and URL constraints remain within the website, but production routing and the files’ effective exposure have not been independently verified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — If production routing matches the PR description, the changed exposure is publicly accessible website-hosted workflow graph assets, not a newly evidenced privileged service operation. Effective production reachability remains unverified.

Trust Boundaries and Controls

  • observed — The changed URL schema restricts paths to fixed-prefix SVG and JSON filenames. The generator reads catalog-selected workflow sources from the named repository and writes static files; no changed authentication or request-time authority transition is evidenced.

Hardening Proposals

  • proposed — Before rollout, verify the production owner and response for both URL prefixes and confirm that the relocated workflow exports are intended to be publicly downloadable.
🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: serving workflow graph files from a website-owned path.
Description check ✅ Passed The description includes the required Summary, Changes, and Review Focus sections. It explains the production issue, the path migration, affected files, regression coverage, validation results, and re…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed The PR title and commit subjects include bug-fix language, but all listed changes are exclusively under apps/website, which the check explicitly excludes because its end-to-end specs live under `app…
Website End-To-End Regression Coverage ✅ Passed The PR changes website runtime configuration and workflow graph paths. It also updates apps/website/e2e/workshop-workflows.spec.ts to open the workflow tab and verify the preview and JSON download l…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed-file list contains only website documentation, preview scripts/tests, workflow configuration/tests, and end-to-end tests. It contains no files under src/lib/litegraph/, src/ecs/, or gr…
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #18800      +/-   ##
==========================================
- Coverage   83.94%   83.92%   -0.02%     
==========================================
  Files        3067     3032      -35     
  Lines      151775   151045     -730     
  Branches    41213    41035     -178     
==========================================
- Hits       127406   126763     -643     
+ Misses      22923    22884      -39     
+ Partials     1446     1398      -48     
Flag Coverage Δ
billing-web-unit ?
website-unit 76.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...website/src/config/workshop-workflow-definition.ts 88.23% <ø> (ø)

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 25, 2026
coderabbitai[bot]
coderabbitai Bot previously requested changes Sep 25, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-merge checks failed. Please resolve the failing checks before merging.

@benjcooley benjcooley changed the title fix(website): serve workflow graph files from the models path fix(website): serve workflow graph files from a website-owned path Sep 25, 2026
@benjcooley
benjcooley force-pushed the benjcooley/workshop-workflow-graph-path branch from a599f9d to 4eaa317 Compare September 25, 2026 14:40
@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 25, 2026 14:40 Inactive
@benjcooley

Copy link
Copy Markdown
Collaborator Author

@coderabbitai Addressed both pre-merge items:

  • Website end-to-end regression coverage: a709b85 adds Playwright coverage in e2e/workshop-workflows.spec.ts. On a workflow detail page, the test opens the Workflow tab and checks that the full-size preview link and the "Download workflow JSON" link point to /workflow-graphs/change-material.svg and .json. It then fetches both from the built site and checks the response status and content type.
  • Description paths: that warning came from the first push, which used /models/workflow-graphs/. The path is now /workflow-graphs/, because the release gate rejects anything under dist/models/ when WORKSHOP_IN_BUILD=0. The description and code both use /workflow-graphs/.

The branch is updated with main (a1be4f0). It was also verified combined with #18862 and #18868: typecheck, 8993 website unit tests, the release (gated) and Workshop builds, and 116 Workshop/Models browser tests all pass.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail
gh pr view 18800 --repo Comfy-Org/ComfyUI_frontend --json headRefOid,body --jq '{headRefOid,body}'
printf '\nRelevant files:\n'
fd -i 'workshop-workflows\.spec\.ts|workshop-workflow-content\.test\.ts|workshop-workflow-definition\.ts|prepare-workflow-previews\.ts' .
printf '\nPath references:\n'
rg -n -C2 '(/workflow-graphs/|/models/workflow-graphs/|/workflows/prepared/)' apps/website/e2e apps/website/src/config apps/website/scripts apps/website/README.md apps/website/src/content/README.md | head -220

Length of output: 4352


🏁 Script executed:

#!/bin/bash
set -euo pipefail
ast-grep outline apps/website/e2e/workshop-workflows.spec.ts --items all
ast-grep outline apps/website/src/config/workshop-workflow-content.test.ts --items all
printf '\nPlaywright test context:\n'
sed -n '85,150p' apps/website/e2e/workshop-workflows.spec.ts
printf '\nSchema and catalog test references:\n'
rg -n -C4 'workflow-graphs|workflows/prepared|models/workflow-graphs' apps/website/src/config/workshop-workflow-definition.ts apps/website/src/config/workshop-workflow-content.test.ts apps/website/scripts/prepare-workflow-previews.ts
printf '\nOther website old-path references (if any):\n'
rg -n '(/models/workflow-graphs/|/workflows/prepared/)' apps/website || true
printf '\nHead and commit check:\n'
git rev-parse HEAD
git log -5 --format='%h %s'

Length of output: 8332


@benjcooley, thanks for the update. I checked commit a1be4f04a2. The Playwright test checks both /workflow-graphs/change-material links, fetches the SVG and JSON, and checks the response status and content type. The PR description, schema, generator, and catalog test use /workflow-graphs/. I found no old-path references under apps/website.

Both pre-merge items are addressed in the current branch. I did not rerun the builds or tests, so I cannot independently confirm the reported pass counts.


✏️ Learnings added
Learnt from: benjcooley
URL: https://github.com/Comfy-Org/ComfyUI_frontend/pull/18800

Timestamp: 2026-09-25T15:56:26.771Z
Learning: In `apps/website` of ComfyUI_frontend, prepared Workshop workflow SVG previews and JSON downloads use `public/workflow-graphs/` and `/workflow-graphs/` URLs. The release build with `WORKSHOP_IN_BUILD=0` rejects graph assets under `dist/models/`, so `/models/workflow-graphs/` is not a valid location for these files.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.


If you found this review helpful, would you consider giving us a shout-out on X?

Thank you for using CodeRabbit!

You are interacting with an AI system.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧐 TED review: #18800 at a1be4f0, no open items

What I checked:

  • Production routing: confirmed today. comfy.org/workflows/prepared/change-material.json returns 404 NOT_FOUND, served by x-served-by: vercel-workflows, the Hub project. comfy.org/workflow-graphs/… is already served by vercel-website; it returns 404 only until this deploys. The PR preview serves /workflow-graphs/change-material.{json,svg} as application/json and image/svg+xml.
  • Diff: 60 of the 68 files are pure renames (30 JSON + 30 SVG). No workflows/prepared references remain anywhere under apps/website. The schema regex, generator target, catalog URLs and both READMEs all move together.
  • Tests: the new content test checks that every workflow's preview and download path stays under /workflow-graphs/ and exists on disk. The e2e test fetches both files and checks the status and content type. Locally, workshop-workflow-content.test.ts and prepare-workflow-previews.test.ts pass (124 tests). CI is green: 50 passed, 0 failed.

Note: the files under /workflow-graphs/ ship in every build, including WORKSHOP_IN_BUILD=0, so they're reachable without the flag. They're copies of public Hub templates, so that's fine.

CodeRabbit's CHANGES_REQUESTED (05:58) is from the pre-merge checks on the earlier a599f9d. Its 15:56 reply confirms both items are addressed.

Severity Open
BLOCKER 0
SHOULD FIX 0
TRIVIAL 0

@benjcooley

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Incremental review skipped.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍💻 BILL — accepted at a1be4f04a2e0a82a0dbebee5420b7bb86a171147. No actionable findings. Posted as COMMENT because this is our own PR.

Verified all 60 JSON/SVG changes are exact-blob renames, and the catalogue is unchanged apart from its 60 URL substitutions. Schema, preparation script, tests and documentation agree on /workflow-graphs/; no old prepared-path references remain under the website. The preview/download component consumes these paths directly, and the execution graph/run configuration is unchanged.

Independent HTTP checks confirm the production problem: the old JSON URL returns 404 from vercel-workflows; the new path reaches vercel-website (still 404 before deployment). The PR preview returns 200 for both graph files with the expected JSON/SVG content types. The combined browser regression passes for both links and fetches.

The release build with WORKSHOP_IN_BUILD=0 passes and contains only models/index.html under Models, no retired Workshop output, and all 60 graph assets. These static graph assets remain publicly reachable independently of the UI flag; this is not an authenticated-content boundary.

Combined verification used main 4cd5c6be276e183cc630a9acd5eec11103903db7 plus #18868 91d2252849882567a560aa3449cb4bf5a138d786, #18879 79fffadb19c4687be29b0e546b829d04f0162916, and #18800 a1be4f04a2e0a82a0dbebee5420b7bb86a171147. The scratch merge was conflict-free; tested tree 5c4b6f498bd919531e4ec583df6f59b512b9c69d. No source branch was changed.

On that combined tree: standard website typecheck passed; gated and Workshop-enabled production builds passed; 8,999 unit tests passed (4 existing skips); 99 Workshop/Models browser tests passed; 7 independent interaction/layout probes passed (1 phone-inapplicable tablet case skipped). Coverage includes graph preview/download fetches, multi-model union and Clear all, shared links, filter keyboard/focus/dismissal, tab focus handoff, both toolbars at 640/700/768, flag gating, bundle budget, and mocked Cloud run/recovery/cancellation. Sort still ends at x=744 in the 768px probe.

CodeRabbit's two pre-merge items are addressed: actual graph-link/fetch coverage is present, and the description now uses the correct website-owned path. Its reply confirms this, and there are no open threads. CI has no pending or failed checks. However, GitHub still reports CHANGES_REQUESTED from the old CodeRabbit review; clear that through the normal reviewer/merge process before queueing. I did not dismiss or alter that review.

Severity Count
BLOCKER 0
SHOULD FIX 0
TRIVIAL 0

@benjcooley

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

Please re-review head a1be4f0. Both pre-merge items from your first review are addressed; see my earlier comment. The e2e coverage is in a709b85, and the path is now /workflow-graphs/ in both the code and the description. There are no open threads.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Incremental review skipped.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@benjcooley

Copy link
Copy Markdown
Collaborator Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

@benjcooley
benjcooley merged commit 2df88ac into main Sep 25, 2026
86 checks passed
@benjcooley
benjcooley deleted the benjcooley/workshop-workflow-graph-path branch September 25, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant