Repository navigation
fix(website): serve workflow graph files from a website-owned path - #18800
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🌐 Website E2ETip All tests passed.
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 22f7d6a501d1eefc3df31572a589fcdffbbe0681
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-18800.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-e5as0r5xk-comfyui.vercel.app Last updated: 2026-09-25T15:57:34Z for |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (30)
📒 Files selected for processing (38)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughWorkflow preview generation, URL validation, tests, and documentation now use ChangesWorkflow graph path migration
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to Workflow preview and download assets now use Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change is intended to make workflow graph files publicly available from the website. The generation and URL constraints remain within the website, but production routing and the files’ effective exposure have not been independently verified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Hardening Proposals
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18800 +/- ##
==========================================
- Coverage 83.94% 83.92% -0.02%
==========================================
Files 3067 3032 -35
Lines 151775 151045 -730
Branches 41213 41035 -178
==========================================
- Hits 127406 126763 -643
+ Misses 22923 22884 -39
+ Partials 1446 1398 -48
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 35 files with indirect coverage changes 🚀 New features to boost your workflow:
|
a599f9d to
4eaa317
Compare
|
@coderabbitai Addressed both pre-merge items:
The branch is updated with main (a1be4f0). It was also verified combined with #18862 and #18868: typecheck, 8993 website unit tests, the release (gated) and Workshop builds, and 116 Workshop/Models browser tests all pass. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
gh pr view 18800 --repo Comfy-Org/ComfyUI_frontend --json headRefOid,body --jq '{headRefOid,body}'
printf '\nRelevant files:\n'
fd -i 'workshop-workflows\.spec\.ts|workshop-workflow-content\.test\.ts|workshop-workflow-definition\.ts|prepare-workflow-previews\.ts' .
printf '\nPath references:\n'
rg -n -C2 '(/workflow-graphs/|/models/workflow-graphs/|/workflows/prepared/)' apps/website/e2e apps/website/src/config apps/website/scripts apps/website/README.md apps/website/src/content/README.md | head -220Length of output: 4352 🏁 Script executed: #!/bin/bash
set -euo pipefail
ast-grep outline apps/website/e2e/workshop-workflows.spec.ts --items all
ast-grep outline apps/website/src/config/workshop-workflow-content.test.ts --items all
printf '\nPlaywright test context:\n'
sed -n '85,150p' apps/website/e2e/workshop-workflows.spec.ts
printf '\nSchema and catalog test references:\n'
rg -n -C4 'workflow-graphs|workflows/prepared|models/workflow-graphs' apps/website/src/config/workshop-workflow-definition.ts apps/website/src/config/workshop-workflow-content.test.ts apps/website/scripts/prepare-workflow-previews.ts
printf '\nOther website old-path references (if any):\n'
rg -n '(/models/workflow-graphs/|/workflows/prepared/)' apps/website || true
printf '\nHead and commit check:\n'
git rev-parse HEAD
git log -5 --format='%h %s'Length of output: 8332
Both pre-merge items are addressed in the current branch. I did not rerun the builds or tests, so I cannot independently confirm the reported pass counts. ✏️ Learnings added
If you found this review helpful, would you consider giving us a shout-out on X? Thank you for using CodeRabbit! You are interacting with an AI system. |
benjcooley
left a comment
There was a problem hiding this comment.
🧐 TED review: #18800 at a1be4f0, no open items
What I checked:
- Production routing: confirmed today.
comfy.org/workflows/prepared/change-material.jsonreturns 404NOT_FOUND, served byx-served-by: vercel-workflows, the Hub project.comfy.org/workflow-graphs/…is already served byvercel-website; it returns 404 only until this deploys. The PR preview serves/workflow-graphs/change-material.{json,svg}asapplication/jsonandimage/svg+xml. - Diff: 60 of the 68 files are pure renames (30 JSON + 30 SVG). No
workflows/preparedreferences remain anywhere underapps/website. The schema regex, generator target, catalog URLs and both READMEs all move together. - Tests: the new content test checks that every workflow's preview and download path stays under
/workflow-graphs/and exists on disk. The e2e test fetches both files and checks the status and content type. Locally,workshop-workflow-content.test.tsandprepare-workflow-previews.test.tspass (124 tests). CI is green: 50 passed, 0 failed.
Note: the files under /workflow-graphs/ ship in every build, including WORKSHOP_IN_BUILD=0, so they're reachable without the flag. They're copies of public Hub templates, so that's fine.
CodeRabbit's CHANGES_REQUESTED (05:58) is from the pre-merge checks on the earlier a599f9d. Its 15:56 reply confirms both items are addressed.
| Severity | Open |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
|
@coderabbitai review |
|
benjcooley
left a comment
There was a problem hiding this comment.
👨💻 BILL — accepted at a1be4f04a2e0a82a0dbebee5420b7bb86a171147. No actionable findings. Posted as COMMENT because this is our own PR.
Verified all 60 JSON/SVG changes are exact-blob renames, and the catalogue is unchanged apart from its 60 URL substitutions. Schema, preparation script, tests and documentation agree on /workflow-graphs/; no old prepared-path references remain under the website. The preview/download component consumes these paths directly, and the execution graph/run configuration is unchanged.
Independent HTTP checks confirm the production problem: the old JSON URL returns 404 from vercel-workflows; the new path reaches vercel-website (still 404 before deployment). The PR preview returns 200 for both graph files with the expected JSON/SVG content types. The combined browser regression passes for both links and fetches.
The release build with WORKSHOP_IN_BUILD=0 passes and contains only models/index.html under Models, no retired Workshop output, and all 60 graph assets. These static graph assets remain publicly reachable independently of the UI flag; this is not an authenticated-content boundary.
Combined verification used main 4cd5c6be276e183cc630a9acd5eec11103903db7 plus #18868 91d2252849882567a560aa3449cb4bf5a138d786, #18879 79fffadb19c4687be29b0e546b829d04f0162916, and #18800 a1be4f04a2e0a82a0dbebee5420b7bb86a171147. The scratch merge was conflict-free; tested tree 5c4b6f498bd919531e4ec583df6f59b512b9c69d. No source branch was changed.
On that combined tree: standard website typecheck passed; gated and Workshop-enabled production builds passed; 8,999 unit tests passed (4 existing skips); 99 Workshop/Models browser tests passed; 7 independent interaction/layout probes passed (1 phone-inapplicable tablet case skipped). Coverage includes graph preview/download fetches, multi-model union and Clear all, shared links, filter keyboard/focus/dismissal, tab focus handoff, both toolbars at 640/700/768, flag gating, bundle budget, and mocked Cloud run/recovery/cancellation. Sort still ends at x=744 in the 768px probe.
CodeRabbit's two pre-merge items are addressed: actual graph-link/fetch coverage is present, and the description now uses the correct website-owned path. Its reply confirms this, and there are no open threads. CI has no pending or failed checks. However, GitHub still reports CHANGES_REQUESTED from the old CodeRabbit review; clear that through the normal reviewer/merge process before queueing. I did not dismiss or alter that review.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
|
@coderabbitai review Please re-review head a1be4f0. Both pre-merge items from your first review are addressed; see my earlier comment. The e2e coverage is in a709b85, and the path is now /workflow-graphs/ in both the code and the description. There are no open threads. |
|
|
@coderabbitai full review |
✅ Action performedFull review finished. |
Summary
Workflow graph previews and "Download workflow" links 404 in production because comfy.org routes
/workflows/*to the Workflow Hub app, which hides the website's/workflows/prepared/*files. This moves them to/workflow-graphs/, which production routes to the website.Changes
public/workflow-graphs/and updates the catalog URLs, schema, generator script, and READMEs. A regression test requires every workflow's preview and download URL to stay under/workflow-graphs/and point to an existing file.Review Focus
https://comfy.org/workflows/prepared/change-material.jsonreturns VercelNOT_FOUNDfrom the Hub project, while the PR preview serves it. This also affects the three workflows shipped in the earlier PR./models/: the release gate rejects anydist/models/entry besidesindex.htmlwhenWORKSHOP_IN_BUILD=0, which failed the first push. Production routes/workflow-graphs/*to the website (x-served-by: vercel-website).WORKSHOP_IN_BUILD=0) passes, and the Workshop-enabled build serves/workflow-graphs/*.json|svgwith the correct content types; the full website unit suite (8,948) and 110 Workshop/Models browser tests pass.Related: FE-2736, follow-up to #18763.