Repository navigation
test(agent): clarify full-tab-reload title regression #18849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
christian-byrne
merged 1 commit into
Comfy-Org:main
from
christian-byrne:intake-2-title-reload
Sep 26, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -211,18 +211,18 @@ test.describe( | |||||
| ) | ||||||
|
|
||||||
| test.describe( | ||||||
| 'Agent CRDT reconcile stomps a locally renamed node title', | ||||||
| 'A full workflow-tab reload stomps a locally renamed node title', | ||||||
| { tag: ['@cloud', '@agent', '@vue-nodes'] }, | ||||||
| () => { | ||||||
| test.use({ conversationCase: UNTOUCHED_CASE }) | ||||||
|
|
||||||
| test.beforeEach(async ({ page }) => enableCrdtDebugPanel(page)) | ||||||
|
|
||||||
| test('keeps a manual canvas rename after an unrelated agent reconcile', async ({ | ||||||
| test('keeps a manual canvas rename after leaving and reloading the workflow tab', async ({ | ||||||
| agentConversation, | ||||||
| page | ||||||
| }, testInfo) => { | ||||||
| // Known, intentionally unfixed repro: the workflow-tab reload wipes | ||||||
| // PM-1717. Known, intentionally unfixed repro: the workflow-tab reload wipes | ||||||
| // this node's reconcile baseline before the title fix ever runs — see | ||||||
| // the file-level comment and agentNodeMaterializer.test.ts's matching | ||||||
| // `it.fails` case for the mechanism. The reconcile step below still | ||||||
|
|
@@ -261,7 +261,7 @@ test.describe( | |||||
| contentType: 'image/png' | ||||||
| }) | ||||||
|
|
||||||
| await test.step('an unrelated agent-driven reconcile runs (returning to the tab)', async () => { | ||||||
| await test.step('leaving and returning fully reloads the workflow tab', async () => { | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [P3] This step also waits for and verifies the catch-up reconcile. Naming that second stage avoids implying that reload alone loses the visible title.
Suggested change
|
||||||
| // The doc's own projection never learns about this manual rename, so | ||||||
| // its title stays stale regardless of whether the real "survives a | ||||||
| // tab reload" gap below is fixed — skip only this node's title check | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P3] The reload discards the reconcile baseline, but the rename survives the reload itself. The following reconcile performs the overwrite, so naming both stages keeps the suite title aligned with the unit repro.