Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -211,18 +211,18 @@ test.describe(
)

test.describe(
'Agent CRDT reconcile stomps a locally renamed node title',
'A full workflow-tab reload stomps a locally renamed node title',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] The reload discards the reconcile baseline, but the rename survives the reload itself. The following reconcile performs the overwrite, so naming both stages keeps the suite title aligned with the unit repro.

Suggested change
'A full workflow-tab reload stomps a locally renamed node title',
'A reconcile after a full workflow-tab reload stomps a locally renamed node title',

{ tag: ['@cloud', '@agent', '@vue-nodes'] },
() => {
test.use({ conversationCase: UNTOUCHED_CASE })

test.beforeEach(async ({ page }) => enableCrdtDebugPanel(page))

test('keeps a manual canvas rename after an unrelated agent reconcile', async ({
test('keeps a manual canvas rename after leaving and reloading the workflow tab', async ({
agentConversation,
page
}, testInfo) => {
// Known, intentionally unfixed repro: the workflow-tab reload wipes
// PM-1717. Known, intentionally unfixed repro: the workflow-tab reload wipes
// this node's reconcile baseline before the title fix ever runs — see
// the file-level comment and agentNodeMaterializer.test.ts's matching
// `it.fails` case for the mechanism. The reconcile step below still
Expand Down Expand Up @@ -261,7 +261,7 @@ test.describe(
contentType: 'image/png'
})

await test.step('an unrelated agent-driven reconcile runs (returning to the tab)', async () => {
await test.step('leaving and returning fully reloads the workflow tab', async () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] This step also waits for and verifies the catch-up reconcile. Naming that second stage avoids implying that reload alone loses the visible title.

Suggested change
await test.step('leaving and returning fully reloads the workflow tab', async () => {
await test.step('leaving and returning reloads the workflow tab, then reconciles it', async () => {

// The doc's own projection never learns about this manual rename, so
// its title stays stale regardless of whether the real "survives a
// tab reload" gap below is fixed — skip only this node's title check
Expand Down
Loading