Repository navigation
test(agent): clarify full-tab-reload title regression - #18849
Conversation
🎨 Storybook: ✅ Built🎭 Playwright: ✅ 2128 passed, 0 failed · 2 flaky📊 Browser Reports
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T12:40:14.185Z",
"gitSha": "6b9e4269949ff97ac337de55290872fb16c8d944",
"branch": "intake-2-title-reload",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2014.6969999999556,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.6539999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.50300000000004,
"heapDeltaBytes": -6548404,
"heapUsedBytes": 54755536,
"domNodes": 0,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.275999999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2011.9600000000446,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.135999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.725,
"heapDeltaBytes": 25349848,
"heapUsedBytes": 87742632,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.718000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1825.1480000000129,
"styleRecalcs": 72,
"styleRecalcDurationMs": 17.866,
"layouts": 12,
"layoutDurationMs": 5.1610000000000005,
"taskDurationMs": 819.506,
"heapDeltaBytes": 8932736,
"heapUsedBytes": 71186556,
"domNodes": -228,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 171.178,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1836.767000000009,
"styleRecalcs": 72,
"styleRecalcDurationMs": 16.997000000000003,
"layouts": 12,
"layoutDurationMs": 4.6370000000000005,
"taskDurationMs": 837.0430000000001,
"heapDeltaBytes": -2370708,
"heapUsedBytes": 60003664,
"domNodes": -228,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 169.799,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1664.794000000029,
"styleRecalcs": 30,
"styleRecalcDurationMs": 9.699,
"layouts": 6,
"layoutDurationMs": 1.1669999999999998,
"taskDurationMs": 315.65200000000004,
"heapDeltaBytes": 2635708,
"heapUsedBytes": 70071184,
"domNodes": 53,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.793,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.804999999994,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.746999999999998,
"layouts": 6,
"layoutDurationMs": 1.0939999999999999,
"taskDurationMs": 314.86199999999997,
"heapDeltaBytes": 2134716,
"heapUsedBytes": 64355608,
"domNodes": 53,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.386999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 682.9100000000494,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.32,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.23,
"heapDeltaBytes": 19316612,
"heapUsedBytes": 80370180,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 168.92200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 696.4199999999892,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.7209999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.77199999999993,
"heapDeltaBytes": 19313976,
"heapUsedBytes": 80820404,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 166.97899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1193.2459999999878,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 855.261,
"heapDeltaBytes": 34823296,
"heapUsedBytes": 100118532,
"domNodes": -259,
"jsHeapTotalBytes": 19296256,
"scriptDurationMs": 70.28,
"eventListeners": 0,
"totalBlockingTimeMs": 583,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1247.5660000000062,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 872.502,
"heapDeltaBytes": 8701032,
"heapUsedBytes": 96234896,
"domNodes": -259,
"jsHeapTotalBytes": 22433792,
"scriptDurationMs": 70.79999999999998,
"eventListeners": -185,
"totalBlockingTimeMs": 634,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.0590000000393,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.93899999999996,
"heapDeltaBytes": 14078436,
"heapUsedBytes": 90377460,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.943,
"eventListeners": 0,
"totalBlockingTimeMs": 235,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.70999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.5470000000007,
"heapDeltaBytes": 14650524,
"heapUsedBytes": 90108172,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.85000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11175.359000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10228.688999999998,
"heapDeltaBytes": -10415756,
"heapUsedBytes": 71896688,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8553.338,
"eventListeners": 0,
"totalBlockingTimeMs": 1578,
"frameDurationMs": 19.99999999999994,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9817.092000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9012.394,
"heapDeltaBytes": -14253968,
"heapUsedBytes": 68368112,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7672.651,
"eventListeners": 0,
"totalBlockingTimeMs": 1259,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10383.299000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9480.458,
"heapDeltaBytes": -14135216,
"heapUsedBytes": 68519708,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7882.8369999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 1282,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11963.893999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10981.883999999998,
"heapDeltaBytes": 35542596,
"heapUsedBytes": 99798692,
"domNodes": -228,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 9230.741,
"eventListeners": -164,
"totalBlockingTimeMs": 1979,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "large-graph-idle",
"durationMs": 2024.6989999999983,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.744999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 533.297,
"heapDeltaBytes": 2110576,
"heapUsedBytes": 83336756,
"domNodes": -228,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 33.972,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2052.505999999994,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.524,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 600.1610000000001,
"heapDeltaBytes": -5802880,
"heapUsedBytes": 75926752,
"domNodes": -228,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 33.86399999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2492.9159999999797,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.919000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1662.3349999999998,
"heapDeltaBytes": 24464140,
"heapUsedBytes": 88929216,
"domNodes": 0,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 917.2660000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2814.6960000000263,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.247,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1789.6299999999999,
"heapDeltaBytes": -11059068,
"heapUsedBytes": 76858676,
"domNodes": -228,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 934.1109999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3568.6450000000036,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.187999999999999,
"layouts": 60,
"layoutDurationMs": 13.142,
"taskDurationMs": 1643.6329999999998,
"heapDeltaBytes": 8145768,
"heapUsedBytes": 74083436,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 782.872,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3653.043000000025,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.411999999999999,
"layouts": 60,
"layoutDurationMs": 13.279,
"taskDurationMs": 1740.2730000000001,
"heapDeltaBytes": -10091444,
"heapUsedBytes": 73585284,
"domNodes": -228,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 794.7109999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3016.6750000000206,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.859,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1770.5790000000002,
"heapDeltaBytes": 17348588,
"heapUsedBytes": 83552252,
"domNodes": 0,
"jsHeapTotalBytes": 2252800,
"scriptDurationMs": 1017.6460000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3123.929999999973,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.814000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1911.206,
"heapDeltaBytes": 25903880,
"heapUsedBytes": 92014900,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 981.2489999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2009.5519999999851,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.105,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.6500000000001,
"heapDeltaBytes": -14550088,
"heapUsedBytes": 73791348,
"domNodes": -228,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 29.740000000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2002.5679999999966,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.595,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.302,
"heapDeltaBytes": -4681512,
"heapUsedBytes": 83845932,
"domNodes": -228,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 31.106999999999996,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.4479999999903,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.595999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.753,
"heapDeltaBytes": 13423544,
"heapUsedBytes": 76807432,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 140.91600000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.975000000034,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.922000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.8999999999999,
"heapDeltaBytes": 13734908,
"heapUsedBytes": 77439528,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 149.65499999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1999.2299999999545,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.204,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.647,
"heapDeltaBytes": 1001272,
"heapUsedBytes": 63773832,
"domNodes": -244,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.5920000000000005,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.4330000000155,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.888000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.70799999999997,
"heapDeltaBytes": 12652688,
"heapUsedBytes": 76300096,
"domNodes": -244,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.585000000000002,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1684.4750000000204,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.66,
"layouts": 16,
"layoutDurationMs": 5.36,
"taskDurationMs": 662.7069999999999,
"heapDeltaBytes": -4436568,
"heapUsedBytes": 59195652,
"domNodes": -244,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 109.82499999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.7940000000353,
"styleRecalcs": 74,
"styleRecalcDurationMs": 18.316,
"layouts": 16,
"layoutDurationMs": 5.550999999999999,
"taskDurationMs": 794.107,
"heapDeltaBytes": 5437720,
"heapUsedBytes": 68172036,
"domNodes": -244,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 115.16600000000003,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1419.0760000000182,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.175000000000008,
"layouts": 5,
"layoutDurationMs": 13.480999999999996,
"taskDurationMs": 940.6180000000002,
"heapDeltaBytes": -6289796,
"heapUsedBytes": 81825812,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 31.316999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 147,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8364.776999999947,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.586000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5624.094,
"heapDeltaBytes": -394900,
"heapUsedBytes": 80297028,
"domNodes": -228,
"jsHeapTotalBytes": -45056,
"scriptDurationMs": 2763.299,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8587.249000000043,
"styleRecalcs": 248,
"styleRecalcDurationMs": 32.039,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5804.603999999999,
"heapDeltaBytes": -249916,
"heapUsedBytes": 80818056,
"domNodes": -228,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 2819.3740000000003,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16543.034000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16049.000999999997,
"heapDeltaBytes": -55648372,
"heapUsedBytes": 184138632,
"domNodes": -8049,
"jsHeapTotalBytes": -16146432,
"scriptDurationMs": 255.282,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16752.950000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16166.377999999999,
"heapDeltaBytes": -38259092,
"heapUsedBytes": 199403036,
"domNodes": -8049,
"jsHeapTotalBytes": -10158080,
"scriptDurationMs": 254.846,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20702.664000000026,
"styleRecalcs": 164,
"styleRecalcDurationMs": 17.176000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20410.043999999998,
"heapDeltaBytes": -49716812,
"heapUsedBytes": 168567676,
"domNodes": -8049,
"jsHeapTotalBytes": -17047552,
"scriptDurationMs": 951.1350000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 126,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20392.594999999914,
"styleRecalcs": 165,
"styleRecalcDurationMs": 17.52199999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20163.029000000002,
"heapDeltaBytes": -70455268,
"heapUsedBytes": 169097032,
"domNodes": -8078,
"jsHeapTotalBytes": -18993152,
"scriptDurationMs": 928.868,
"eventListeners": -14923,
"totalBlockingTimeMs": 107,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6206.864999999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.12599999999998,
"layouts": 20,
"layoutDurationMs": 23.703000000000003,
"taskDurationMs": 6146.759999999999,
"heapDeltaBytes": -62581764,
"heapUsedBytes": 177250324,
"domNodes": -8049,
"jsHeapTotalBytes": 12951552,
"scriptDurationMs": 108.533,
"eventListeners": -14923,
"totalBlockingTimeMs": 441,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5851.183999999989,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.48200000000003,
"layouts": 20,
"layoutDurationMs": 21.434000000000008,
"taskDurationMs": 5749.601,
"heapDeltaBytes": -50379700,
"heapUsedBytes": 176795200,
"domNodes": -8049,
"jsHeapTotalBytes": 11595776,
"scriptDurationMs": 103.33200000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 354,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8641.520000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8435.158000000001,
"heapDeltaBytes": 2512068,
"heapUsedBytes": 179899856,
"domNodes": 0,
"jsHeapTotalBytes": -33030144,
"scriptDurationMs": 158.84200000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8243.349999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7685.840000000001,
"heapDeltaBytes": -20151692,
"heapUsedBytes": 171947348,
"domNodes": 0,
"jsHeapTotalBytes": -27787264,
"scriptDurationMs": 110.73099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 133.45200000003388,
"styleRecalcs": 10,
"styleRecalcDurationMs": 19.636,
"layouts": 5,
"layoutDurationMs": 2.639,
"taskDurationMs": 110.619,
"heapDeltaBytes": 3344112,
"heapUsedBytes": 65305268,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.678999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 116.93300000001727,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.776000000000002,
"layouts": 4,
"layoutDurationMs": 2.113,
"taskDurationMs": 84.276,
"heapDeltaBytes": 3124940,
"heapUsedBytes": 65073888,
"domNodes": 120,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.623999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe expected-failure test now identifies a title-stomp scenario after a full workflow-tab reload. A comment labels the test as a PM-1717 repro. ChangesTitle reload repro
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to This clarifies the existing reload regression test without changing product behavior. No actionable merge risk is identified. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18849 +/- ##
==========================================
- Coverage 84.91% 84.90% -0.02%
==========================================
Files 2340 2305 -35
Lines 133255 132525 -730
Branches 34052 33874 -178
==========================================
- Hits 113154 112514 -640
+ Misses 19747 19705 -42
+ Partials 354 306 -48
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
Approved. The test-only change correctly distinguishes the full workflow-tab reload regression from the within-session reconcile behavior.
The two wording suggestions are non-blocking. The reload discards the title reconcile baseline, but the following reconcile performs the overwrite. Naming both stages matches the focused unit repro.
Existing findings and checked candidates
- CodeRabbit approved this exact head with no actionable findings. The review lanes independently confirmed that result except for the wording nit above.
- The
/no-commentspass proposed deleting the 12-line expected-failure explanation. I rejected that deletion because the block preserves PM-1717 provenance and explains why the intermediate replay must skip this node's stale projected title. Comment deletions: 0. - One lane noted that the existing body-level
test.fail()can accept an earlier failure. That placement predates this PR and the diff does not worsen it, so it is not a finding against this change.
Verification and coverage
- Reviewed head:
c2e99f5b6e54296907e6a8b1772291680c4be6b5 - Effective base:
7cf953950831930d7444079c6a6eeeb40fe53d1e - Exact-head CI rollup: successful, including all Playwright shards, cloud E2E, lint, typecheck, Fallow, and repository checks.
- Focused unit analogue: 1 expected failure, 61 skipped, exit 0.
- Local checks: browser typecheck, scoped ESLint, formatting, and
git diff --checkpassed. - Standard review lanes: correctness, maintainability, idiomaticity, tests with the full Playwright-spec procedure, and documentation.
|
|
||
| test.describe( | ||
| 'Agent CRDT reconcile stomps a locally renamed node title', | ||
| 'A full workflow-tab reload stomps a locally renamed node title', |
There was a problem hiding this comment.
[P3] The reload discards the reconcile baseline, but the rename survives the reload itself. The following reconcile performs the overwrite, so naming both stages keeps the suite title aligned with the unit repro.
| 'A full workflow-tab reload stomps a locally renamed node title', | |
| 'A reconcile after a full workflow-tab reload stomps a locally renamed node title', |
| }) | ||
|
|
||
| await test.step('an unrelated agent-driven reconcile runs (returning to the tab)', async () => { | ||
| await test.step('leaving and returning fully reloads the workflow tab', async () => { |
There was a problem hiding this comment.
[P3] This step also waits for and verifies the catch-up reconcile. Naming that second stage avoids implying that reload alone loses the visible title.
| await test.step('leaving and returning fully reloads the workflow tab', async () => { | |
| await test.step('leaving and returning reloads the workflow tab, then reconciles it', async () => { |
Summary
Pins PM-1717 as the known full workflow-tab reload title-loss gap, distinct from the within-session reconcile behavior fixed by #18075.
Changes
Review Focus
The case remains
test.fail()and red on currentmain: a manual title is visible before leaving the tab and is stomped after returning fully reloads it. This PR changes no production behavior.Source: https://comfy-organization.slack.com/archives/C0A8Z4U7Y1K/p1790329354333089
Follow-up from: #18075