Repository navigation
test(assets): run the media-type-filter suite on the cloud project - #18839
Closed
christian-byrne wants to merge 1 commit into
Closed
christian-byrne wants to merge 1 commit into
christian-byrne wants to merge 1 commit into
Conversation
The 5-test `Assets sidebar - media type filter` suite has been behind `test.fixme(true, 'Requires DISTRIBUTION=cloud build with auth bypass')` since Comfy-Org#10784. Both halves of that blocker have since landed: - `ci-tests-e2e.yaml` builds `frontend-dist-cloud` and runs `playwright test --project=cloud` against it, so the `isCloud`-gated filter button is present. - The `comfyPage` fixture calls `cloudAuth.mockAuth()` for any test tagged `@cloud`, so the suite gets an authenticated session with no per-suite setup. Tagging the describe `@cloud` routes it there, matching the 15+ suites already on that path. No test-body changes.
Contributor
🎨 Storybook: ✅ Built🎭 Playwright: ⏳ Running... |
Contributor
Author
|
Superseded by #18841 — same commit, pushed to an upstream branch so the cloud e2e project actually runs. |
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Assets sidebar - media type filter(5 tests) has been fully disabled since #10784:That was accurate when it was written. It isn't any more — both halves of the blocker have since landed:
DISTRIBUTION=cloudbuild —ci-tests-e2e.yamlbuilds thefrontend-dist-cloudartifact and runsplaywright test --project=cloudagainst it (rm -rf dist && cp -a dist-cloud dist). TheisCloud-gated filter button is present there.ComfyPage.tscallscomfyPage.cloudAuth.mockAuth()automatically for any test whose tags include@cloud. No per-suite setup needed.Change
Tag the describe
@cloud, drop thefixme. That routes the suite to thecloudproject (and out ofchromium, whichgrepInverts@cloud), matching the 15+ suites already on that path —browseModelAssets,cloud-asset-default,workspaceSwitcher,billingFacadeConsumers, etc.No test-body changes, no source changes.
Expected outcome
These 5 tests have never executed, so CI is their first run. Anything that fails is a real defect and gets a
test.fail()pin with a tracking issue rather than going back behindfixme.Surfaced by the disabled-test inventory. Related: #18838 (the other 10 never-executing tests, gated behind abandoned
agent-v1slice PRs). cc @dante01yoon — this was yourfixmefrom #10784.