Skip to content

test(assets): run the media-type-filter suite on the cloud project - #18839

Closed
christian-byrne wants to merge 1 commit into
Comfy-Org:mainfrom
christian-byrne:test/ungate-assets-media-filter
Closed

christian-byrne wants to merge 1 commit into
Comfy-Org:mainfrom
christian-byrne:test/ungate-assets-media-filter

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Problem

Assets sidebar - media type filter (5 tests) has been fully disabled since #10784:

// Filter button is guarded by isCloud; cloud CI needs authenticated setup.
test.describe('Assets sidebar - media type filter', () => {
  test.fixme(true, 'Requires DISTRIBUTION=cloud build with auth bypass')

That was accurate when it was written. It isn't any more — both halves of the blocker have since landed:

  1. DISTRIBUTION=cloud build — ci-tests-e2e.yaml builds the frontend-dist-cloud artifact and runs playwright test --project=cloud against it (rm -rf dist && cp -a dist-cloud dist). The isCloud-gated filter button is present there.
  2. Auth bypass — ComfyPage.ts calls comfyPage.cloudAuth.mockAuth() automatically for any test whose tags include @cloud. No per-suite setup needed.

Change

Tag the describe @cloud, drop the fixme. That routes the suite to the cloud project (and out of chromium, which grepInverts @cloud), matching the 15+ suites already on that path — browseModelAssets, cloud-asset-default, workspaceSwitcher, billingFacadeConsumers, etc.

No test-body changes, no source changes.

Expected outcome

These 5 tests have never executed, so CI is their first run. Anything that fails is a real defect and gets a test.fail() pin with a tracking issue rather than going back behind fixme.

Surfaced by the disabled-test inventory. Related: #18838 (the other 10 never-executing tests, gated behind abandoned agent-v1 slice PRs). cc @dante01yoon — this was your fixme from #10784.

The 5-test `Assets sidebar - media type filter` suite has been behind
`test.fixme(true, 'Requires DISTRIBUTION=cloud build with auth bypass')`
since Comfy-Org#10784. Both halves of that blocker have since landed:

- `ci-tests-e2e.yaml` builds `frontend-dist-cloud` and runs
  `playwright test --project=cloud` against it, so the `isCloud`-gated
  filter button is present.
- The `comfyPage` fixture calls `cloudAuth.mockAuth()` for any test
  tagged `@cloud`, so the suite gets an authenticated session with no
  per-suite setup.

Tagging the describe `@cloud` routes it there, matching the 15+ suites
already on that path. No test-body changes.
@christian-byrne
christian-byrne requested a review from a team September 25, 2026 11:43
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built

Details

⏰ Completed at: 09/25/2026, 11:44:26 AM UTC

Links

🎭 Playwright: ⏳ Running...

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Superseded by #18841 — same commit, pushed to an upstream branch so the cloud e2e project actually runs.

@christian-byrne
christian-byrne deleted the test/ungate-assets-media-filter branch September 25, 2026 11:44
@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 2abae93f-7d18-48e5-bc43-a66eb49472d9

📥 Commits

Reviewing files that changed from the base of the PR and between 4c04e82 and c0e6846.

📒 Files selected for processing (1)
  • browser_tests/tests/sidebar/assets.spec.ts
 _________________________________________
< 💣 Deploying bug fixes in 3... 2... 1... >
 -----------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant