Repository navigation
[backport core/1.55] fix(billing): tell the customer when Billing & invoices is blocked instead of minting more portal sessions - #18799
Conversation
…stead of minting more portal sessions (#18740) When the browser blocks pop-ups, "Billing & invoices" now shows a warning toast and stops. Before, it did nothing visible and created up to two Stripe portal sessions that were never opened. M2 run, case H4 (testcloud, `window.open` returning `null` the way a blocked pop-up does): Settings → Plan & Credits → **Billing & invoices** opened nothing and showed no message. The billing-web tab was refused, then the SDK rail minted a portal session and its window was refused, then the legacy client minted a second session and its window was refused too. The Subscribe path already has a fallback for this (the in-page confirm step). This button had none. `manageSubscription` (`src/platform/workspace/composables/useWorkspaceBilling.ts:528-553`) treats each refused `window.open` as a reason to try the next destination: - `openHostedBillingTab` returns `false` both when the destination isn't billing_web and when the tab was blocked (`src/platform/workspace/billing/openHostedBillingTab.ts:71`). The caller can't tell a block from "not configured", so it goes on to the rail. - A refused rail window (`:537`) falls through to the legacy client, which mints another session. - The legacy `openPortalWindow` result is ignored (`:545`), so the last refusal ends silently. A pop-up blocker refuses the page, not one destination. Once one tab is refused, the next one will be refused as well. - `openHostedBillingTabOutcome` returns `'opened' | 'unavailable' | 'blocked'`. `openHostedBillingTab` keeps its boolean for the three subscribe callers, whose fallback is the same either way. - `manageSubscription` moves to the next destination only when the current one doesn't serve the workspace (`unavailable`, or rail `DECLINED`). A refused tab or portal window ends the attempt with a warning toast: "Couldn't open the billing page. Allow pop-ups for this site and try again." (new key `subscription.billingTabBlocked`). No further portal session is created. - When the hosted tab is unavailable, the portal tab is reserved blank before the rail or legacy request and navigated once the URL arrives (closed when the request fails or returns no URL). A tab opened after the request resolves can have lost the click's activation and be refused even with pop-ups allowed, and a refused reservation now ends the attempt before any portal session is minted. - Same-tab navigation was not used as the fallback because it would unload the app and any unsaved workflow. - `useWorkspaceBilling.test.ts` (`it.for`, 4 rows: hosted tab on legacy / on SDK rail, SDK rail portal, legacy portal): each blocked case must show the toast and create no portal session. Further rows: the portal tab is reserved before the request resolves, and is closed when the request fails or returns no URL. These replace the two tests that asserted the old cascade. Red on the test commit: 1 and 2 sessions for the hosted rows, 2 for the rail row, no toast for any row. Green with the fix. `src/platform/workspace`: 1950 passed. - `browser_tests/tests/dialogs/hostedBillingDestination.spec.ts` (`@cloud`): blocked billing-web tab → toast, 0 `/billing/payment-portal` requests. Blocked provider portal → toast, 0 portal requests (same in `subscriptionLifecycleSdkRail.spec.ts`). Specs whose `window.open` stub returned the live `window` now use a recording stand-in tab (`browser_tests/fixtures/utils/recordOpenedUrl.ts`), since the reserved tab is navigated through its `location`. Red without the fix (toast not found), green with it. The whole spec passes locally (10/10). | AS IS | TO BE | | --- | --- | | _screenshot pending_ | _screenshot pending_ | (cherry picked from commit 52ca6c4)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2120 passed, 0 failed · 2 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3fdef47dc5e21af1c6c178a42e4c50adeb3b3bc2
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T05:59:30.669Z",
"gitSha": "0e1fd767ae68ee863ea5cae5b1d0d9686182aeea",
"branch": "backport-18740-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.4260000000859,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.534,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.56800000000004,
"heapDeltaBytes": 6630204,
"heapUsedBytes": 74240712,
"domNodes": -259,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.187000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2006.343999999899,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.290000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.90000000000003,
"heapDeltaBytes": -7806452,
"heapUsedBytes": 59846480,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.042,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1721.9069999999874,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.339999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 783.047,
"heapDeltaBytes": -153848,
"heapUsedBytes": 67819192,
"domNodes": -259,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 167.468,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1718.79899999999,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.801000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 755.0160000000001,
"heapDeltaBytes": -6442948,
"heapUsedBytes": 61067736,
"domNodes": -258,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 152.081,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.6520000000291,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.738,
"layouts": 6,
"layoutDurationMs": 0.943,
"taskDurationMs": 317.833,
"heapDeltaBytes": 3122640,
"heapUsedBytes": 70541172,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.829999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.2010000001683,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.435,
"layouts": 6,
"layoutDurationMs": 1.092,
"taskDurationMs": 320.897,
"heapDeltaBytes": 3081632,
"heapUsedBytes": 70718092,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.109,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 620.7010000000537,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.944,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.977,
"heapDeltaBytes": 18957456,
"heapUsedBytes": 86514404,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 162.72,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 629.0630000000874,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.944,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.638,
"heapDeltaBytes": 18960864,
"heapUsedBytes": 86218824,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 165.46000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1229.0419999999358,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 916.3749999999999,
"heapDeltaBytes": -17165736,
"heapUsedBytes": 73082232,
"domNodes": -295,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 75.127,
"eventListeners": -217,
"totalBlockingTimeMs": 572,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1164.985999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 826.079,
"heapDeltaBytes": 35299984,
"heapUsedBytes": 104735544,
"domNodes": 0,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 71.15499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 560,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.3970000000245,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.314,
"heapDeltaBytes": 14267580,
"heapUsedBytes": 90840152,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.70299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.6930000000302,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.4319999999996,
"heapDeltaBytes": 14822236,
"heapUsedBytes": 90240724,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.347,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10462.011999999959,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9590.477,
"heapDeltaBytes": 7426948,
"heapUsedBytes": 72170232,
"domNodes": -2,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 7932.373000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1269,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9880.52300000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9033.083,
"heapDeltaBytes": 11438828,
"heapUsedBytes": 93476116,
"domNodes": -16,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7477.85,
"eventListeners": 0,
"totalBlockingTimeMs": 874,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10545.131999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9712.610000000002,
"heapDeltaBytes": 27475212,
"heapUsedBytes": 91697368,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 8091.532000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1157,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10421.296999999868,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9565.417,
"heapDeltaBytes": 11873868,
"heapUsedBytes": 93669172,
"domNodes": -12,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7958.36,
"eventListeners": 0,
"totalBlockingTimeMs": 1055,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2019.296000000054,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.2170000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.4000000000001,
"heapDeltaBytes": -3147144,
"heapUsedBytes": 83443204,
"domNodes": -244,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 30.46700000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2069.9929999998403,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.186000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.1020000000001,
"heapDeltaBytes": -6444496,
"heapUsedBytes": 80554372,
"domNodes": -246,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 31.898999999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2262.9559999999174,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.602000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1628.1979999999999,
"heapDeltaBytes": -12091300,
"heapUsedBytes": 75604804,
"domNodes": -223,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 857.659,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2238.301999999976,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.710999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1514.079,
"heapDeltaBytes": -8229216,
"heapUsedBytes": 79832044,
"domNodes": -245,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 881.0100000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3452.8369999999313,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.532,
"layouts": 60,
"layoutDurationMs": 12.858999999999998,
"taskDurationMs": 1625.44,
"heapDeltaBytes": 9122488,
"heapUsedBytes": 74526952,
"domNodes": 8,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 775.5989999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3498.7589999998363,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.293,
"layouts": 60,
"layoutDurationMs": 12.506000000000002,
"taskDurationMs": 1677.5189999999998,
"heapDeltaBytes": -15978072,
"heapUsedBytes": 73360320,
"domNodes": -254,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 761.5350000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3071.5450000000146,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.051999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1893.977,
"heapDeltaBytes": 22874140,
"heapUsedBytes": 88314016,
"domNodes": 6,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 978.361,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2831.375999999864,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.678999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1741.575,
"heapDeltaBytes": 17540232,
"heapUsedBytes": 85020292,
"domNodes": 6,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 999.4139999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.0709999999644,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.689000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.5600000000001,
"heapDeltaBytes": -6742580,
"heapUsedBytes": 82107708,
"domNodes": -248,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 31.950000000000006,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2032.3510000000624,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.042,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.219,
"heapDeltaBytes": -4009208,
"heapUsedBytes": 84485760,
"domNodes": -246,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 32.914,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.7090000000462,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.530000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.896,
"heapDeltaBytes": 13977588,
"heapUsedBytes": 83764392,
"domNodes": 22,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 142.29899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.9349999999777,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.246,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.02899999999994,
"heapDeltaBytes": 14043804,
"heapUsedBytes": 83880968,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 146.336,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.920999999944,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.960999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.73900000000003,
"heapDeltaBytes": -14433420,
"heapUsedBytes": 55256416,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.876,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.8590000000531,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.887,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.3059999999999,
"heapDeltaBytes": -3034084,
"heapUsedBytes": 66291584,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.669000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.7340000000204,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.021,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.5590000000001,
"heapDeltaBytes": -12848452,
"heapUsedBytes": 56958008,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 100.01899999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.021999999928,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.525,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.422,
"heapDeltaBytes": 10487544,
"heapUsedBytes": 80120680,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 100.888,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.4040000001314,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.281999999999993,
"layouts": 5,
"layoutDurationMs": 12.696,
"taskDurationMs": 864.2639999999999,
"heapDeltaBytes": -6239936,
"heapUsedBytes": 81199712,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 27.311999999999998,
"eventListeners": 2383,
"totalBlockingTimeMs": 139,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8269.339999999942,
"styleRecalcs": 249,
"styleRecalcDurationMs": 33.792,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5611.977000000001,
"heapDeltaBytes": -10181656,
"heapUsedBytes": 76457536,
"domNodes": -243,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 2767.027,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8527.66500000007,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.724000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6033.238000000001,
"heapDeltaBytes": 826984,
"heapUsedBytes": 88510428,
"domNodes": -245,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 3067.059,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16470.658999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15755.959,
"heapDeltaBytes": -71373228,
"heapUsedBytes": 164607420,
"domNodes": -8061,
"jsHeapTotalBytes": -11923456,
"scriptDurationMs": 250.695,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16593.200999999906,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15917.917,
"heapDeltaBytes": -42303852,
"heapUsedBytes": 183554332,
"domNodes": -8061,
"jsHeapTotalBytes": -13901824,
"scriptDurationMs": 238.52800000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20189.99499999995,
"styleRecalcs": 164,
"styleRecalcDurationMs": 16.513000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19879.583,
"heapDeltaBytes": -50704744,
"heapUsedBytes": 169540000,
"domNodes": -8061,
"jsHeapTotalBytes": -19816448,
"scriptDurationMs": 917.3679999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 13,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15636.179999999968,
"styleRecalcs": 78,
"styleRecalcDurationMs": 11.925999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15087.536,
"heapDeltaBytes": -47637112,
"heapUsedBytes": 193364932,
"domNodes": -8062,
"jsHeapTotalBytes": -20193280,
"scriptDurationMs": 810.577,
"eventListeners": -14928,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5974.82500000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.049,
"layouts": 20,
"layoutDurationMs": 22.958999999999993,
"taskDurationMs": 5836.398000000001,
"heapDeltaBytes": -59865652,
"heapUsedBytes": 180943696,
"domNodes": -8061,
"jsHeapTotalBytes": 9498624,
"scriptDurationMs": 101.872,
"eventListeners": -14928,
"totalBlockingTimeMs": 324,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6014.443000000028,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.64999999999998,
"layouts": 20,
"layoutDurationMs": 23.551000000000002,
"taskDurationMs": 5928.258000000001,
"heapDeltaBytes": -34215664,
"heapUsedBytes": 180176676,
"domNodes": -8061,
"jsHeapTotalBytes": 14958592,
"scriptDurationMs": 113.092,
"eventListeners": -14928,
"totalBlockingTimeMs": 433,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8280.851999999868,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7970.629000000001,
"heapDeltaBytes": -4604104,
"heapUsedBytes": 183073172,
"domNodes": 0,
"jsHeapTotalBytes": -22020096,
"scriptDurationMs": 144.17999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8288.686000000098,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7918.562999999999,
"heapDeltaBytes": 1048168,
"heapUsedBytes": 170919512,
"domNodes": -1,
"jsHeapTotalBytes": -12058624,
"scriptDurationMs": 120.63999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 472.58000000010725,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.79,
"layouts": 5,
"layoutDurationMs": 2.457,
"taskDurationMs": 132.739,
"heapDeltaBytes": 5303220,
"heapUsedBytes": 67291840,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.332,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 468.93599999998514,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.767000000000003,
"layouts": 4,
"layoutDurationMs": 1.778,
"taskDurationMs": 123.66300000000003,
"heapDeltaBytes": 5014468,
"heapUsedBytes": 70546148,
"domNodes": 150,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.862,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.55 #18799 +/- ##
=============================================
- Coverage 84.59% 84.58% -0.01%
=============================================
Files 2294 2294
Lines 131265 131278 +13
Branches 35425 33538 -1887
=============================================
+ Hits 111045 111046 +1
- Misses 19920 19932 +12
Partials 300 300
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified rather than rubber-stamped: the changed-file list matches the original PR exactly, and the diff contains no conflict markers. Required checks on this branch are lint-and-format, test and e2e-status; any other red check here is advisory and does not gate the merge.
Backport of #18740 to
core/1.55(cherry-pick -x of 52ca6c4).Conflict resolution
One conflict, in the import block of
src/platform/workspace/composables/useWorkspaceBilling.test.ts. It is not a stacking conflict with the other open backports: on main, #18497 (test: migrate workspace tests to shared mocks) had already switched this test to the shareduseSubscriptionDialogautomock and imported it.core/1.55does not have #18497 and still stubs the dialog with a localmockShow, so the diff context around #18740's newuseToastStoreimport did not match.Resolution: keep the release branch's imports and local
mockShowstub, and add only #18740'suseToastStoreimport. #18497 is not pulled in. All other files applied cleanly.Verification
vitest run src/platform/workspace: 88 files passedpnpm typecheck: pass