Repository navigation
[backport core/1.55] fix(billing-web): theme Stripe Elements from the checkout's own theme scope - #18791
Conversation
… scope (#18686) ## Summary The Stripe Address and Payment Element labels on the billing-web checkout were near-invisible (dark gray on the dark panel), and the input boxes rendered white. Stripe's appearance tokens now come from the checkout's own dark theme scope. ## Changes - **What**: - Why: in dark mode on testbilling.comfy.org, "Full name", "Country or region", "Address" and the country select text were barely readable, and the card inputs sat in a white box. - Root cause: `StripePaymentForm` resolved every appearance color (and `fontFamily`) on a probe appended to `document.body`. billing-web applies `.dark-theme` to a wrapper `div` (`CheckoutView`/`HostedSurface`), not to `body`, so the probe read the light-theme tokens: `colorText` = charcoal-800, `colorBackground` = white. The main app was unaffected because its theme class sits above `body`'s children. - How: resolve the tokens and font inside the payment element's container, so they inherit whichever theme scope the form renders in. The Payment and Address Elements share one `elements()` appearance, so both stay consistent. Light mode resolves the same tokens as before. - Test: a new `StripePaymentForm` case renders the form inside a scoped container whose tokens differ from `body` and asserts Stripe receives the scoped `colorText`/`colorBackground`. It fails on main (it gets the body values) and passes with the fix. ## Review Focus The probe is appended to the payment element's target before Stripe mounts into it, and removed straight away. ## AS IS / TO BE | AS IS | TO BE | | --- | --- | | <img width="780" alt="AS IS" src="https://github.com/user-attachments/assets/ca54ed89-db02-439d-be3f-b59237ad015d" /> | <img width="780" alt="TO BE" src="https://github.com/user-attachments/assets/d0849ed1-2eca-4af7-82da-698b79df772b" /> | Team workspace checkout (`plan=team_per_credit_monthly&team_credit_stop_id=team_700`) against testcloud, card and address filled with Stripe Magic fill. - AS IS: https://testbilling.comfy.org (main build). The Billing address labels and values ("Jenny Rosen", "United States", "354 Oyster Point Blvd", …) are dark gray on the dark panel. - TO BE: this branch on http://localhost:5174. Labels and values read in the checkout's dark-theme text color, on dark inputs. <!-- m2-dep-graph:start --> ## Plan position: Milestone 2 payment-test fixes Found in the live M2 run (testcloud → testbilling, Team per-credit checkout). None of these PRs depends on another to merge. Solid arrows gate a milestone step; dotted ones are nice-to-have. | PR | Defect | Dependency | |---|---|---| | [D5 cloud#10518](Comfy-Org/cloud#10518) | test-v2 billing-worker uses the wrong Stripe key; every confirm fails `parameter_missing client_secret` | Blocker on test only (config). Unblocks the live re-run. | | [D4 cloud#10514](Comfy-Org/cloud#10514) | preview-subscribe attaches `payment_method_configuration_id` only when `embedded_checked_enabled` is on | Required before widening `hosted_billing_destination` past the flag cohort. | | [D3 FE #18684](#18684) | billing-web asks for a card on plan changes that need none | Independent. Shares e2e fixtures with #18687. | | [D6 FE #18687](#18687) | failed-payment UI ignores `recovery_action` / `retryable` | Independent. Shares e2e fixtures with #18684. | | **[D8 FE #18686](#18686) (this PR)** | Stripe Element labels invisible in dark theme | Independent (cosmetic). | | [D7 FE #18685](#18685) | billing-web font URL broken (`/fonts/inter-*.woff2`) | Independent (cosmetic). | ```mermaid flowchart LR c10518["D5 cloud#10518<br/>test-v2 Stripe key"] c10514["D4 cloud#10514<br/>always attach pmc id"] f18684["D3 #18684<br/>no card for plan change"] f18687["D6 #18687<br/>recovery_action UI"] f18686["D8 #18686<br/>dark-theme labels"] f18685["D7 #18685<br/>fonts"] RERUN(["M2 live payment re-run<br/>testcloud → testbilling"]) ROLLOUT(["Widen hosted_billing_destination<br/>beyond flag cohort"]) c10518 --> RERUN c10514 --> ROLLOUT f18684 --> ROLLOUT f18687 --> ROLLOUT f18686 -.-> ROLLOUT f18685 -.-> ROLLOUT RERUN --> ROLLOUT f18684 <-. "shared e2e fixtures:<br/>second to merge pulls main" .-> f18687 style f18686 fill:#f9d71c,stroke:#333,stroke-width:3px,color:#000 ``` <!-- m2-dep-graph:end -->
🌐 Website E2ETip All tests passed.
🎭 Playwright: ✅ 2122 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a98216aca69eceb499622ed009caa3faf2539f00
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T05:11:06.908Z",
"gitSha": "bf5685555971df87e44d6d2f4bf317eefc63cb46",
"branch": "backport-18686-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.7359999999994,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.9940000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.22799999999995,
"heapDeltaBytes": 13905480,
"heapUsedBytes": 81465548,
"domNodes": -260,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.229999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1989.518999999973,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.664000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.24100000000004,
"heapDeltaBytes": -1630224,
"heapUsedBytes": 66047032,
"domNodes": -259,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.431000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.2439999999888,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.685,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 760.454,
"heapDeltaBytes": -12321716,
"heapUsedBytes": 55116324,
"domNodes": -259,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 152.361,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1813.4149999999636,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.862,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 827.7399999999999,
"heapDeltaBytes": 9766316,
"heapUsedBytes": 77366936,
"domNodes": -259,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 167.664,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.6459999999738,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.350000000000005,
"layouts": 6,
"layoutDurationMs": 1.1409999999999998,
"taskDurationMs": 321.77199999999993,
"heapDeltaBytes": 3157524,
"heapUsedBytes": 70621732,
"domNodes": 79,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.792000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.7640000000365,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.915999999999999,
"layouts": 6,
"layoutDurationMs": 1.085,
"taskDurationMs": 345.025,
"heapDeltaBytes": 2788732,
"heapUsedBytes": 70374852,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.532999999999996,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 638.306,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.982000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.75699999999995,
"heapDeltaBytes": 18895656,
"heapUsedBytes": 86463136,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 164.586,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 640.1670000000195,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.942000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.18499999999995,
"heapDeltaBytes": 18671504,
"heapUsedBytes": 86042732,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 164.727,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1199.054999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 889.544,
"heapDeltaBytes": -17039996,
"heapUsedBytes": 73342388,
"domNodes": -295,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 70.47399999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 542,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1168.7780000000885,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 820.5649999999999,
"heapDeltaBytes": 38382740,
"heapUsedBytes": 107661760,
"domNodes": 0,
"jsHeapTotalBytes": 20344832,
"scriptDurationMs": 70.28699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 552,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.5350000000076,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.3430000000002,
"heapDeltaBytes": 15648404,
"heapUsedBytes": 91122764,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.333,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 840.0440000000344,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.3360000000002,
"heapDeltaBytes": 14328020,
"heapUsedBytes": 90672416,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.421,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11370.038000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10428.292000000001,
"heapDeltaBytes": -7783736,
"heapUsedBytes": 74253076,
"domNodes": -14,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 8679.498000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1609,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 49.89999999999782
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10266.548000000057,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9406.436,
"heapDeltaBytes": 1463632,
"heapUsedBytes": 83344108,
"domNodes": -16,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 7835.531000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1079,
"frameDurationMs": 19.996666666666655,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9924.832000000039,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9018.066,
"heapDeltaBytes": -12462192,
"heapUsedBytes": 69695468,
"domNodes": -16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7707.915,
"eventListeners": 0,
"totalBlockingTimeMs": 1095,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10402.150000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9575.748000000001,
"heapDeltaBytes": -6117936,
"heapUsedBytes": 69815308,
"domNodes": -8,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 7930.3189999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 991,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2023.7260000000106,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.511000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.7800000000001,
"heapDeltaBytes": -3505916,
"heapUsedBytes": 83683836,
"domNodes": -240,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 31.53,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2028.1049999999823,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.795000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.46,
"heapDeltaBytes": -2882300,
"heapUsedBytes": 83992584,
"domNodes": -245,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 31.972,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2276.057000000037,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.828999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1628.891,
"heapDeltaBytes": -6594952,
"heapUsedBytes": 81064180,
"domNodes": -219,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 831.3320000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2338.333000000034,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.864999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1706.7230000000002,
"heapDeltaBytes": -2544632,
"heapUsedBytes": 84886732,
"domNodes": -243,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 864.3009999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3546.7479999999796,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.716000000000001,
"layouts": 60,
"layoutDurationMs": 12.979000000000001,
"taskDurationMs": 1679.151,
"heapDeltaBytes": 8733032,
"heapUsedBytes": 74486956,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 792.885,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3581.320000000005,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.073,
"layouts": 60,
"layoutDurationMs": 13.23,
"taskDurationMs": 1746.6870000000001,
"heapDeltaBytes": 8635388,
"heapUsedBytes": 74764600,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 831.9540000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3084.372999999971,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.815000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1900.471,
"heapDeltaBytes": 24526260,
"heapUsedBytes": 90707512,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 978.2090000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3008.972999999969,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.373999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1873.4580000000003,
"heapDeltaBytes": 21023248,
"heapUsedBytes": 87185596,
"domNodes": 6,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 951.189,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2008.3120000000463,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.184999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.093,
"heapDeltaBytes": 20482072,
"heapUsedBytes": 84645660,
"domNodes": -251,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.055,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.395000000056,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.402,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.38200000000006,
"heapDeltaBytes": -6314912,
"heapUsedBytes": 82601364,
"domNodes": -247,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 34.484,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.9330000000205,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.509999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.945,
"heapDeltaBytes": 14098228,
"heapUsedBytes": 83907620,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 145.98699999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.2599999999966,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.812999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.196,
"heapDeltaBytes": 13725136,
"heapUsedBytes": 83515440,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 147.147,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.728,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.7810000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.53400000000005,
"heapDeltaBytes": -1430620,
"heapUsedBytes": 68475380,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.689999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2004.891999999927,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.587,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.53900000000004,
"heapDeltaBytes": 9483348,
"heapUsedBytes": 79621596,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.418999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.1959999999813,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.643,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 701.182,
"heapDeltaBytes": -9022828,
"heapUsedBytes": 61009080,
"domNodes": -275,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 100.31700000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.4710000000077,
"styleRecalcs": 47,
"styleRecalcDurationMs": 16.884999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 738.437,
"heapDeltaBytes": -3359784,
"heapUsedBytes": 65717248,
"domNodes": -274,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 104.315,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.5269999999955,
"styleRecalcs": 16,
"styleRecalcDurationMs": 28.832000000000004,
"layouts": 5,
"layoutDurationMs": 13.422,
"taskDurationMs": 858.0320000000002,
"heapDeltaBytes": 19603960,
"heapUsedBytes": 94395548,
"domNodes": 13667,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 30.008999999999993,
"eventListeners": 2383,
"totalBlockingTimeMs": 133,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8305.201000000012,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.248000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5191.962,
"heapDeltaBytes": -19795424,
"heapUsedBytes": 67463708,
"domNodes": -216,
"jsHeapTotalBytes": 2387968,
"scriptDurationMs": 2818.013,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8420.564000000013,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5813.359,
"heapDeltaBytes": -18564568,
"heapUsedBytes": 68021468,
"domNodes": -240,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 2762.3700000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 16825.518000000102,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16391.174,
"heapDeltaBytes": -49063432,
"heapUsedBytes": 171062584,
"domNodes": -8061,
"jsHeapTotalBytes": -16932864,
"scriptDurationMs": 254.645,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17009.105999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16491.287,
"heapDeltaBytes": -47993892,
"heapUsedBytes": 186764216,
"domNodes": -8090,
"jsHeapTotalBytes": -11210752,
"scriptDurationMs": 268.715,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20416.52499999998,
"styleRecalcs": 167,
"styleRecalcDurationMs": 16.311999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19994.757999999998,
"heapDeltaBytes": -49831928,
"heapUsedBytes": 191813072,
"domNodes": -8061,
"jsHeapTotalBytes": -17244160,
"scriptDurationMs": 872.776,
"eventListeners": -14928,
"totalBlockingTimeMs": 121,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20417.66299999995,
"styleRecalcs": 151,
"styleRecalcDurationMs": 16.375999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20100.983999999997,
"heapDeltaBytes": -42154752,
"heapUsedBytes": 191847404,
"domNodes": -8061,
"jsHeapTotalBytes": -12402688,
"scriptDurationMs": 869.395,
"eventListeners": -14928,
"totalBlockingTimeMs": 45,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6063.645999999949,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.43599999999998,
"layouts": 20,
"layoutDurationMs": 32.73899999999999,
"taskDurationMs": 5957.334,
"heapDeltaBytes": -71630008,
"heapUsedBytes": 169586848,
"domNodes": -8090,
"jsHeapTotalBytes": 6090752,
"scriptDurationMs": 145.853,
"eventListeners": -14928,
"totalBlockingTimeMs": 381,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6072.396000000026,
"styleRecalcs": 20,
"styleRecalcDurationMs": 101.92599999999999,
"layouts": 20,
"layoutDurationMs": 28.476000000000003,
"taskDurationMs": 5979.840999999999,
"heapDeltaBytes": -31235948,
"heapUsedBytes": 188931324,
"domNodes": -8062,
"jsHeapTotalBytes": 2764800,
"scriptDurationMs": 104.84199999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 580,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8500.315999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8304.361999999997,
"heapDeltaBytes": -26853716,
"heapUsedBytes": 171191068,
"domNodes": 0,
"jsHeapTotalBytes": -21757952,
"scriptDurationMs": 121.002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6354.2470000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6052.382,
"heapDeltaBytes": -12223160,
"heapUsedBytes": 174437828,
"domNodes": 0,
"jsHeapTotalBytes": -20971520,
"scriptDurationMs": 97.40199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 447.92899999993097,
"styleRecalcs": 15,
"styleRecalcDurationMs": 23.706999999999997,
"layouts": 3,
"layoutDurationMs": 0.841,
"taskDurationMs": 115.99599999999998,
"heapDeltaBytes": 5050584,
"heapUsedBytes": 67184924,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.085999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 111.13499999999021,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.927999999999997,
"layouts": 3,
"layoutDurationMs": 0.926,
"taskDurationMs": 78.57899999999998,
"heapDeltaBytes": 3064500,
"heapUsedBytes": 68955660,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.377,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #18791 +/- ##
=============================================
- Coverage 84.59% 83.65% -0.95%
=============================================
Files 2294 3019 +725
Lines 131267 148898 +17631
Branches 35426 38459 +3033
=============================================
+ Hits 111044 124558 +13514
- Misses 19923 23038 +3115
- Partials 300 1302 +1002
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 735 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified rather than rubber-stamped: the changed-file list matches the original PR exactly, and the diff contains no conflict markers. Required checks on this branch are lint-and-format, test and e2e-status; any other red check here is advisory and does not gate the merge.
…he theme changes after mount (#18826) Backport of #18778 to `core/1.55` (cherry-pick -x of bf313c7). ## Why testcloud runs `cloud/1.55`; Stripe Elements must re-theme when the palette changes after mount there too. ## Root cause See #18778: the Elements appearance was set only at mount. ## How Cherry-picked cleanly onto #18791's head. The auto-backport conflicted because #18686's backport (#18791) is not on `core/1.55` yet, so this diff includes #18791's commit until it merges. Merge #18791 first. ## AS IS / TO BE Same as #18778.
Backport of #18686 to
core/1.55Automatically created by backport workflow.