Repository navigation
[backport cloud/1.55] fix(account-ui): re-theme Stripe Elements when the theme changes after mount - #18827
Conversation
… scope (#18686) ## Summary The Stripe Address and Payment Element labels on the billing-web checkout were near-invisible (dark gray on the dark panel), and the input boxes rendered white. Stripe's appearance tokens now come from the checkout's own dark theme scope. ## Changes - **What**: - Why: in dark mode on testbilling.comfy.org, "Full name", "Country or region", "Address" and the country select text were barely readable, and the card inputs sat in a white box. - Root cause: `StripePaymentForm` resolved every appearance color (and `fontFamily`) on a probe appended to `document.body`. billing-web applies `.dark-theme` to a wrapper `div` (`CheckoutView`/`HostedSurface`), not to `body`, so the probe read the light-theme tokens: `colorText` = charcoal-800, `colorBackground` = white. The main app was unaffected because its theme class sits above `body`'s children. - How: resolve the tokens and font inside the payment element's container, so they inherit whichever theme scope the form renders in. The Payment and Address Elements share one `elements()` appearance, so both stay consistent. Light mode resolves the same tokens as before. - Test: a new `StripePaymentForm` case renders the form inside a scoped container whose tokens differ from `body` and asserts Stripe receives the scoped `colorText`/`colorBackground`. It fails on main (it gets the body values) and passes with the fix. ## Review Focus The probe is appended to the payment element's target before Stripe mounts into it, and removed straight away. ## AS IS / TO BE | AS IS | TO BE | | --- | --- | | <img width="780" alt="AS IS" src="https://github.com/user-attachments/assets/ca54ed89-db02-439d-be3f-b59237ad015d" /> | <img width="780" alt="TO BE" src="https://github.com/user-attachments/assets/d0849ed1-2eca-4af7-82da-698b79df772b" /> | Team workspace checkout (`plan=team_per_credit_monthly&team_credit_stop_id=team_700`) against testcloud, card and address filled with Stripe Magic fill. - AS IS: https://testbilling.comfy.org (main build). The Billing address labels and values ("Jenny Rosen", "United States", "354 Oyster Point Blvd", …) are dark gray on the dark panel. - TO BE: this branch on http://localhost:5174. Labels and values read in the checkout's dark-theme text color, on dark inputs. <!-- m2-dep-graph:start --> ## Plan position: Milestone 2 payment-test fixes Found in the live M2 run (testcloud → testbilling, Team per-credit checkout). None of these PRs depends on another to merge. Solid arrows gate a milestone step; dotted ones are nice-to-have. | PR | Defect | Dependency | |---|---|---| | [D5 cloud#10518](Comfy-Org/cloud#10518) | test-v2 billing-worker uses the wrong Stripe key; every confirm fails `parameter_missing client_secret` | Blocker on test only (config). Unblocks the live re-run. | | [D4 cloud#10514](Comfy-Org/cloud#10514) | preview-subscribe attaches `payment_method_configuration_id` only when `embedded_checked_enabled` is on | Required before widening `hosted_billing_destination` past the flag cohort. | | [D3 FE #18684](#18684) | billing-web asks for a card on plan changes that need none | Independent. Shares e2e fixtures with #18687. | | [D6 FE #18687](#18687) | failed-payment UI ignores `recovery_action` / `retryable` | Independent. Shares e2e fixtures with #18684. | | **[D8 FE #18686](#18686) (this PR)** | Stripe Element labels invisible in dark theme | Independent (cosmetic). | | [D7 FE #18685](#18685) | billing-web font URL broken (`/fonts/inter-*.woff2`) | Independent (cosmetic). | ```mermaid flowchart LR c10518["D5 cloud#10518<br/>test-v2 Stripe key"] c10514["D4 cloud#10514<br/>always attach pmc id"] f18684["D3 #18684<br/>no card for plan change"] f18687["D6 #18687<br/>recovery_action UI"] f18686["D8 #18686<br/>dark-theme labels"] f18685["D7 #18685<br/>fonts"] RERUN(["M2 live payment re-run<br/>testcloud → testbilling"]) ROLLOUT(["Widen hosted_billing_destination<br/>beyond flag cohort"]) c10518 --> RERUN c10514 --> ROLLOUT f18684 --> ROLLOUT f18687 --> ROLLOUT f18686 -.-> ROLLOUT f18685 -.-> ROLLOUT RERUN --> ROLLOUT f18684 <-. "shared e2e fixtures:<br/>second to merge pulls main" .-> f18687 style f18686 fill:#f9d71c,stroke:#333,stroke-width:3px,color:#000 ``` <!-- m2-dep-graph:end -->
…r mount (#18778) ## Summary Stripe Elements now follow a theme switch that happens after the checkout form has mounted: the appearance is re-resolved from the form's theme root and applied with `elements.update({ appearance })`, without remounting the Payment/Address Elements. ## Why Follow-up to #18686. @christian-byrne's non-blocking note in his approval: "the appearance is still resolved once at Element creation, so a theme change after mount will not re-theme the form." ## Root cause Stripe's `appearance` takes concrete colour strings. `StripePaymentForm` resolved them once inside `onMounted` and passed them to `stripe.elements(...)`, and nothing re-read them afterwards. In the cloud app the palette is live: `GraphView` toggles `.dark-theme` on `<html>` and `colorPaletteService` rewrites root CSS variables whenever `colorPaletteStore.activePaletteId` changes. A palette switch with the pricing dialog open left the Stripe form in the old colours. ## Changes - **What**: - `packages/account-ui` `StripePaymentForm.vue`: appearance building extracted into `resolveAppearance(themeRoot)`. New optional `themeKey` prop; when it changes, a `flush: 'post'` watcher re-resolves against the same theme root and calls `elements.update({ appearance })`. The Elements are not recreated or remounted, so entered card/address data survives. A rejected update reports `payment_element_failed` / `element_phase: 'update'` but does not block payment, since it is cosmetic. - `UnifiedStripePaymentSelector.vue` (cloud host) passes `colorPaletteStore.activePaletteId` as `themeKey`, reusing the store signal the app already uses to drive its theme, so no MutationObserver is needed. - `apps/billing-web` is unchanged: `.dark-theme` is hardcoded on its wrapper with no live toggle, so it leaves `themeKey` unset. - **Breaking**: none (`themeKey` is optional). ## Review Focus - A prop keeps `account-ui` host-agnostic and style-less. The package does not observe the DOM or know which theme system the host uses. Observing the theme root's class would not have worked for the cloud app anyway, because the class is on `<html>`, not on the form's root. - `flush: 'post'` makes sure the host's pre-flush watcher (class toggle) and the palette's CSS variable writes land before the probe reads computed colours. Red → green: the new component test mounts under light tokens, switches the theme root to dark and bumps `themeKey`, then asserts `elements.update` was called with the dark `colorText`/`colorBackground` and that `stripe.elements`/`create`/`mount` each ran only once with no `destroy`. It fails on b690eb5 (test only) and passes on 3b7374e. ## Plan position | # | PR | Scope | |---|----|-------| | 1 | #18686 | Resolve Stripe appearance from the checkout's own theme root (D8) | | **2** | **this PR** | **Re-apply the appearance in place on a post-mount theme change** | ```mermaid graph LR A["#18686 scoped theme root"] --> B["this PR: live re-theme"] style B stroke-width:3px ``` ## Screenshots AS IS / TO BE: _placeholder, to be added_ (cherry picked from commit bf313c7)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🎭 Playwright: ✅ 2124 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6b182a122971834e7559afed59688c0260291886
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-25T13:25:24.234Z",
"gitSha": "16ff424fadefe3ab221e1e05f1a85069a74cb020",
"branch": "backport-18778-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.066999999969,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.079,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.74600000000004,
"heapDeltaBytes": 1213844,
"heapUsedBytes": 68827932,
"domNodes": -258,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.476,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1991.0380000000032,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.653000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.72599999999994,
"heapDeltaBytes": 4724020,
"heapUsedBytes": 72240188,
"domNodes": -257,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.298,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.8330000000187,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.856000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 797.1819999999999,
"heapDeltaBytes": -2812364,
"heapUsedBytes": 59652904,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 164.894,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1725.732999999991,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.174999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 713.9250000000001,
"heapDeltaBytes": -5109352,
"heapUsedBytes": 62769904,
"domNodes": -260,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 165.259,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1670.1110000000199,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.861,
"layouts": 6,
"layoutDurationMs": 0.8890000000000001,
"taskDurationMs": 325.087,
"heapDeltaBytes": 3061152,
"heapUsedBytes": 70683336,
"domNodes": 79,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 9.948000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.1829999999063,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.162999999999998,
"layouts": 6,
"layoutDurationMs": 1.1150000000000002,
"taskDurationMs": 326.27799999999996,
"heapDeltaBytes": 3124224,
"heapUsedBytes": 70784680,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.417,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 696.3739999999916,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.828000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.541,
"heapDeltaBytes": 18627824,
"heapUsedBytes": 86379944,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 168.34799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 643.4829999999465,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.860999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.14899999999994,
"heapDeltaBytes": 18967168,
"heapUsedBytes": 86540908,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 166.046,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1202.782999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 857.374,
"heapDeltaBytes": 38404220,
"heapUsedBytes": 104165640,
"domNodes": 0,
"jsHeapTotalBytes": 19820544,
"scriptDurationMs": 70.624,
"eventListeners": 0,
"totalBlockingTimeMs": 594,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1212.0889999999918,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 896.9260000000002,
"heapDeltaBytes": -17053656,
"heapUsedBytes": 73126600,
"domNodes": -293,
"jsHeapTotalBytes": 19791872,
"scriptDurationMs": 71.39099999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 554,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.3999999999605,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.53700000000043,
"heapDeltaBytes": 14306980,
"heapUsedBytes": 90637432,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 174.26000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.0209999999506,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.03399999999993,
"heapDeltaBytes": 14832580,
"heapUsedBytes": 90145264,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.60999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 229,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11903.26600000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10970.801,
"heapDeltaBytes": 16113800,
"heapUsedBytes": 98644820,
"domNodes": -16,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 9200.777,
"eventListeners": 0,
"totalBlockingTimeMs": 2024,
"frameDurationMs": 18.889999999999905,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10204.99499999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9336.256000000001,
"heapDeltaBytes": 4794800,
"heapUsedBytes": 86574876,
"domNodes": -14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7675,
"eventListeners": 0,
"totalBlockingTimeMs": 1026,
"frameDurationMs": 20,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10075.089999999931,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9259.732000000002,
"heapDeltaBytes": 1898560,
"heapUsedBytes": 84066752,
"domNodes": -12,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 7653.426,
"eventListeners": 0,
"totalBlockingTimeMs": 936,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11314.345000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10364.783,
"heapDeltaBytes": -9822552,
"heapUsedBytes": 72275692,
"domNodes": -16,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 8704.237000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1778,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2030.9839999999895,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.746999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.0749999999999,
"heapDeltaBytes": -2652384,
"heapUsedBytes": 84064992,
"domNodes": -240,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 31.011999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2054.0070000000696,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.429,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.0849999999999,
"heapDeltaBytes": -6097512,
"heapUsedBytes": 80783628,
"domNodes": -246,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 34.487,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2208.033999999998,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.834000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1634.2660000000003,
"heapDeltaBytes": 16092956,
"heapUsedBytes": 80275772,
"domNodes": -247,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 841.0699999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2391.6379999999435,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.651000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1686.3160000000003,
"heapDeltaBytes": 16616468,
"heapUsedBytes": 80709888,
"domNodes": -245,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 884.823,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3509.1750000000275,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.122,
"layouts": 60,
"layoutDurationMs": 13.036,
"taskDurationMs": 1668.091,
"heapDeltaBytes": 9822848,
"heapUsedBytes": 74120708,
"domNodes": -258,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 785.6179999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3520.02200000004,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.254000000000003,
"layouts": 60,
"layoutDurationMs": 13.113,
"taskDurationMs": 1693.04,
"heapDeltaBytes": 9878992,
"heapUsedBytes": 75011936,
"domNodes": -253,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 793.8040000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3153.4729999999627,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.472999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1980.2089999999998,
"heapDeltaBytes": 518452,
"heapUsedBytes": 91406156,
"domNodes": -254,
"jsHeapTotalBytes": -602112,
"scriptDurationMs": 999.838,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3081.9099999999935,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.728999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1881.2610000000002,
"heapDeltaBytes": 21381960,
"heapUsedBytes": 87105032,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 964.0390000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2024.5989999999665,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.876,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.2589999999999,
"heapDeltaBytes": -4274100,
"heapUsedBytes": 84147492,
"domNodes": -245,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 34.452999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2030.4330000000164,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.2620000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.21,
"heapDeltaBytes": -4052368,
"heapUsedBytes": 84474852,
"domNodes": -241,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.952,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.8890000000274,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.153999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.53000000000003,
"heapDeltaBytes": 14123524,
"heapUsedBytes": 83472688,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 146.399,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.5529999999135,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.155999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.80500000000006,
"heapDeltaBytes": 13770512,
"heapUsedBytes": 83458868,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 145.518,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1999.052000000006,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.228,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.9320000000001,
"heapDeltaBytes": 2089572,
"heapUsedBytes": 71940912,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.9110000000000005,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.9400000000232,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.936,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.90700000000004,
"heapDeltaBytes": -11352404,
"heapUsedBytes": 58355548,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.957000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.2140000000163,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.039,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 622.246,
"heapDeltaBytes": 8046036,
"heapUsedBytes": 77773244,
"domNodes": -276,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 102.42000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.2479999999496,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.376999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 719.7719999999999,
"heapDeltaBytes": -10315908,
"heapUsedBytes": 59529880,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 103.50300000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.0569999999607,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.44499999999999,
"layouts": 5,
"layoutDurationMs": 12.932000000000002,
"taskDurationMs": 876.778,
"heapDeltaBytes": -6265196,
"heapUsedBytes": 81964444,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 29.57100000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8283.316000000013,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.783,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5727.963,
"heapDeltaBytes": -6509104,
"heapUsedBytes": 80199960,
"domNodes": -241,
"jsHeapTotalBytes": -565248,
"scriptDurationMs": 2796.794,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8288.57400000004,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.919,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5723.419000000001,
"heapDeltaBytes": 16352136,
"heapUsedBytes": 79716468,
"domNodes": -243,
"jsHeapTotalBytes": 716800,
"scriptDurationMs": 2816.001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16864.304000000062,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16392.962,
"heapDeltaBytes": -36490012,
"heapUsedBytes": 178105020,
"domNodes": -8061,
"jsHeapTotalBytes": -10993664,
"scriptDurationMs": 260.76200000000006,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16846.12799999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16312.414999999997,
"heapDeltaBytes": -49729304,
"heapUsedBytes": 164781964,
"domNodes": -8061,
"jsHeapTotalBytes": -9187328,
"scriptDurationMs": 256.933,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20792.966999999975,
"styleRecalcs": 170,
"styleRecalcDurationMs": 18.00400000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20508.365,
"heapDeltaBytes": -60081136,
"heapUsedBytes": 180261124,
"domNodes": -8061,
"jsHeapTotalBytes": -16146432,
"scriptDurationMs": 877.263,
"eventListeners": -14928,
"totalBlockingTimeMs": 125,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21018.162999999957,
"styleRecalcs": 166,
"styleRecalcDurationMs": 18.614999999999966,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20692.634,
"heapDeltaBytes": -33409576,
"heapUsedBytes": 192172228,
"domNodes": -8061,
"jsHeapTotalBytes": -15806464,
"scriptDurationMs": 906.8470000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 135,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6153.4410000000435,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.51100000000002,
"layouts": 20,
"layoutDurationMs": 23.068999999999992,
"taskDurationMs": 6052.053,
"heapDeltaBytes": -42498596,
"heapUsedBytes": 176895136,
"domNodes": -8061,
"jsHeapTotalBytes": 15196160,
"scriptDurationMs": 108.01200000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 376,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4773.885999999948,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.24300000000001,
"layouts": 20,
"layoutDurationMs": 23.965,
"taskDurationMs": 4655.583,
"heapDeltaBytes": -55827800,
"heapUsedBytes": 179734084,
"domNodes": -8062,
"jsHeapTotalBytes": 22159360,
"scriptDurationMs": 92.116,
"eventListeners": -14928,
"totalBlockingTimeMs": 100,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8392.377000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8139.774000000001,
"heapDeltaBytes": 6372680,
"heapUsedBytes": 188344796,
"domNodes": 0,
"jsHeapTotalBytes": -9699328,
"scriptDurationMs": 172.30200000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8496.067999999923,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8199.008,
"heapDeltaBytes": 15607912,
"heapUsedBytes": 189421544,
"domNodes": 0,
"jsHeapTotalBytes": -29360128,
"scriptDurationMs": 146.48399999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 112.58699999996225,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.985,
"layouts": 2,
"layoutDurationMs": 1.2139999999999997,
"taskDurationMs": 85.05499999999999,
"heapDeltaBytes": 3167524,
"heapUsedBytes": 68643396,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.111,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 113.36699999992561,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.184,
"layouts": 2,
"layoutDurationMs": 0.682,
"taskDurationMs": 82.34,
"heapDeltaBytes": 3070284,
"heapUsedBytes": 68961376,
"domNodes": 108,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.919000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #18827 +/- ##
=============================================
Coverage ? 83.66%
=============================================
Files ? 3020
Lines ? 148979
Branches ? 38486
=============================================
Hits ? 124645
Misses ? 23031
Partials ? 1303
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…to-cloud-1.55 # Conflicts: # packages/account-ui/src/billing/stripe/StripePaymentForm.test.ts # packages/account-ui/src/billing/stripe/StripePaymentForm.vue
christian-byrne
left a comment
There was a problem hiding this comment.
Approving. I verified fidelity to the merged original mechanically rather than reading the diff twice, which is the only thing a backport review needs to establish.
- The set of added and removed lines is byte-identical to the version already merged on
main: 176 changed lines, matching hash, emptydiff. - The whole-diff hashes differ only because context lines around the change differ on this base, which is exactly what a clean cherry-pick onto an older branch looks like.
- Both release backports of this change carry the identical patch, so
coreandcloudcannot diverge.
Full context for agent readers
How this was checked. Comparing whole diffs is misleading for a backport, because unchanged
context lines legitimately differ when the surrounding file has moved on. So I extracted only the
+/- lines from this PR and from the merged original, sorted both, and compared: 176 lines each,
the same SHA-256, and diff reporting no difference. The four touched files also match on path and
on per-file line counts.
That means the reasoning from the original review carries over without re-deriving it. For the record,
the two things worth keeping in mind about this change are that it calls
elements.update({ appearance }) rather than recreating — so a customer mid-way through entering a
card keeps what they typed — and that the watcher uses flush: 'post', which is load-bearing because
the appearance is resolved by appending a probe element and reading its computed colour. Under the
default flush it would read the outgoing theme and re-theme the form to the palette the user just
left, a bug that presents as the watcher not firing at all.
CI is settled and clean on this head — nothing pending, and nothing failing once CANCELLED
superseded-run artifacts are set aside.
Both backports of this change are identical to each other, which is worth stating because a
release line that drifts from its sibling is how one branch quietly loses a fix.
Backport of #18778 to
cloud/1.55(cherry-pick -x of bf313c7).Why
testcloud runs
cloud/1.55; Stripe Elements must re-theme when the palette changes after mount there too.Root cause
See #18778: the Elements appearance was set only at mount.
How
Cherry-picked cleanly onto #18792's head. The auto-backport conflicted because #18686's backport (#18792) is not on
cloud/1.55yet, so this diff includes #18792's commit until it merges. Merge #18792 first.AS IS / TO BE
Same as #18778.