Repository navigation
[backport cloud/1.55] fix(billing-web): drive failed-payment recovery from the server's recovery_action - #18777
Conversation
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since fa2519e77478c572ccb79c99d5074305745758ee
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🎭 Playwright: ✅ 2124 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-25T08:12:30.070Z",
"gitSha": "aadd384d31968442acc35bbcbc962befbb45c6aa",
"branch": "backport-18687-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2004.4100000000071,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.692999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 310.148,
"heapDeltaBytes": -6909152,
"heapUsedBytes": 60670676,
"domNodes": -256,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.453999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2003.6679999999478,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.245000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.21299999999997,
"heapDeltaBytes": -8369500,
"heapUsedBytes": 59362540,
"domNodes": -258,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.743999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.1900000000487,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.27,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.133,
"heapDeltaBytes": -6124228,
"heapUsedBytes": 61361716,
"domNodes": -258,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 109.139,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1717.2590000000127,
"styleRecalcs": 46,
"styleRecalcDurationMs": 17.098000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 692.372,
"heapDeltaBytes": 10174720,
"heapUsedBytes": 78021624,
"domNodes": -259,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 133.887,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.1540000000168,
"styleRecalcs": 29,
"styleRecalcDurationMs": 14.73,
"layouts": 6,
"layoutDurationMs": 1.0759999999999996,
"taskDurationMs": 232.165,
"heapDeltaBytes": 3058896,
"heapUsedBytes": 70632036,
"domNodes": 80,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.560000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.634999999882,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.310000000000002,
"layouts": 6,
"layoutDurationMs": 1.13,
"taskDurationMs": 257.322,
"heapDeltaBytes": 2201868,
"heapUsedBytes": 64635444,
"domNodes": 77,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 12.641,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 431.40600000003815,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.639000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.991,
"heapDeltaBytes": 17924588,
"heapUsedBytes": 80392140,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 104.277,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 581.4300000000685,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.782000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.209,
"heapDeltaBytes": 18940868,
"heapUsedBytes": 86434228,
"domNodes": 21,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 138.673,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 916.2509999999884,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.362,
"heapDeltaBytes": -17658104,
"heapUsedBytes": 73108060,
"domNodes": -293,
"jsHeapTotalBytes": 21364736,
"scriptDurationMs": 43.535000000000004,
"eventListeners": -217,
"totalBlockingTimeMs": 276,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 890.2420000000575,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.188,
"heapDeltaBytes": -16778020,
"heapUsedBytes": 72719316,
"domNodes": -288,
"jsHeapTotalBytes": 21364736,
"scriptDurationMs": 36.742999999999995,
"eventListeners": -217,
"totalBlockingTimeMs": 266,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 688.637999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 280.8170000000003,
"heapDeltaBytes": 14503768,
"heapUsedBytes": 89455048,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 95.73899999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 87,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 681.52699999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 283.46600000000024,
"heapDeltaBytes": 14739500,
"heapUsedBytes": 90636296,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 95.38799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 90,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6559.822999999938,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5245.109,
"heapDeltaBytes": -8537884,
"heapUsedBytes": 73481196,
"domNodes": -14,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 4180.24,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6431.083999999942,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.137,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5372.023,
"heapDeltaBytes": -1677520,
"heapUsedBytes": 76796624,
"domNodes": -269,
"jsHeapTotalBytes": 2613248,
"scriptDurationMs": 4104.537,
"eventListeners": -174,
"totalBlockingTimeMs": 21,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6519.297000000051,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.1150000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5357.722,
"heapDeltaBytes": -5209364,
"heapUsedBytes": 72268968,
"domNodes": -271,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 4092.6270000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6513.490000000047,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.722999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5256.25,
"heapDeltaBytes": 601648,
"heapUsedBytes": 83048988,
"domNodes": -16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 4035.3429999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.6419999999716,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.831,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.21999999999997,
"heapDeltaBytes": -6856512,
"heapUsedBytes": 80389268,
"domNodes": -240,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 32.535000000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2005.92800000004,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.528,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.34600000000006,
"heapDeltaBytes": -7263460,
"heapUsedBytes": 78503700,
"domNodes": -243,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 30.325000000000006,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2545.24200000003,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.665000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1197.9160000000002,
"heapDeltaBytes": -7528160,
"heapUsedBytes": 80508644,
"domNodes": -241,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 587.505,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2712.120000000141,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.552999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1242.871,
"heapDeltaBytes": 25101708,
"heapUsedBytes": 89787764,
"domNodes": 12,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 630.455,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999975,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3325.59399999991,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.127000000000002,
"layouts": 60,
"layoutDurationMs": 14.828000000000001,
"taskDurationMs": 1285.03,
"heapDeltaBytes": -14439660,
"heapUsedBytes": 74341268,
"domNodes": -241,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 559.1039999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3369.7369999999864,
"styleRecalcs": 67,
"styleRecalcDurationMs": 17.127999999999997,
"layouts": 60,
"layoutDurationMs": 15.479,
"taskDurationMs": 1315.084,
"heapDeltaBytes": -1931000,
"heapUsedBytes": 86954352,
"domNodes": -257,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 562.002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2408.9420000000246,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.171999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1337.015,
"heapDeltaBytes": 21009904,
"heapUsedBytes": 87071900,
"domNodes": 12,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 667.656,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2212.5750000000153,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.487000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1309.957,
"heapDeltaBytes": 17652940,
"heapUsedBytes": 83415096,
"domNodes": 12,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 667.9549999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2013.1009999998923,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.016000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.65899999999993,
"heapDeltaBytes": -3827896,
"heapUsedBytes": 84182220,
"domNodes": -239,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 26.321000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2054.8479999999927,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.153,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.0310000000001,
"heapDeltaBytes": -6345508,
"heapUsedBytes": 82905280,
"domNodes": -239,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 45.11900000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 426.14900000000944,
"styleRecalcs": 49,
"styleRecalcDurationMs": 12.298000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 292.69500000000005,
"heapDeltaBytes": 13785988,
"heapUsedBytes": 83905592,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 101.148,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 444.8459999998704,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.99,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 299.02299999999997,
"heapDeltaBytes": 13775172,
"heapUsedBytes": 83494800,
"domNodes": 23,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 103.57699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1989.6170000000666,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.524,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.716,
"heapDeltaBytes": -6621120,
"heapUsedBytes": 63427920,
"domNodes": -272,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.654,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1991.392000000019,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.479,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.61800000000005,
"heapDeltaBytes": -6005604,
"heapUsedBytes": 64062664,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.793000000000003,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1729.0420000000495,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.23,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 629.275,
"heapDeltaBytes": -8317932,
"heapUsedBytes": 61642220,
"domNodes": -273,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 101.63,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.548999999999,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.103,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.324,
"heapDeltaBytes": -5351668,
"heapUsedBytes": 58135608,
"domNodes": -273,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 87.022,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 900.4260000000386,
"styleRecalcs": 19,
"styleRecalcDurationMs": 19.942,
"layouts": 5,
"layoutDurationMs": 8.384,
"taskDurationMs": 680.4190000000001,
"heapDeltaBytes": -6295592,
"heapUsedBytes": 81674336,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 22.336000000000002,
"eventListeners": 2383,
"totalBlockingTimeMs": 62,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8771.649000000025,
"styleRecalcs": 251,
"styleRecalcDurationMs": 44.330999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4211.4890000000005,
"heapDeltaBytes": -10828212,
"heapUsedBytes": 68346908,
"domNodes": -211,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 1948.1660000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9225.783999999976,
"styleRecalcs": 251,
"styleRecalcDurationMs": 45.650000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4418.754,
"heapDeltaBytes": -6512156,
"heapUsedBytes": 80172328,
"domNodes": -237,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 2013.954,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11742.565000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11523.501,
"heapDeltaBytes": -14353348,
"heapUsedBytes": 196805188,
"domNodes": -8062,
"jsHeapTotalBytes": -8708096,
"scriptDurationMs": 162.918,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12033.346999999821,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11711.75,
"heapDeltaBytes": -41135448,
"heapUsedBytes": 181062672,
"domNodes": -8062,
"jsHeapTotalBytes": -9232384,
"scriptDurationMs": 170.843,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14735.96699999996,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.582000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14527.502999999999,
"heapDeltaBytes": -58963224,
"heapUsedBytes": 179034348,
"domNodes": -8062,
"jsHeapTotalBytes": -18669568,
"scriptDurationMs": 721.5709999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 59,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14509.492999999793,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.799000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14412.198999999999,
"heapDeltaBytes": -74016816,
"heapUsedBytes": 167150260,
"domNodes": -8062,
"jsHeapTotalBytes": -21651456,
"scriptDurationMs": 640.61,
"eventListeners": -14928,
"totalBlockingTimeMs": 2,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4354.805000000056,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.51700000000001,
"layouts": 20,
"layoutDurationMs": 24.946999999999996,
"taskDurationMs": 4323.311000000001,
"heapDeltaBytes": -24730136,
"heapUsedBytes": 190661808,
"domNodes": -8062,
"jsHeapTotalBytes": 21176320,
"scriptDurationMs": 75.148,
"eventListeners": -14928,
"totalBlockingTimeMs": 92,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4286.6979999998875,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.790000000000006,
"layouts": 20,
"layoutDurationMs": 24.144000000000013,
"taskDurationMs": 4249.532,
"heapDeltaBytes": -37878052,
"heapUsedBytes": 176999552,
"domNodes": -8062,
"jsHeapTotalBytes": 21176320,
"scriptDurationMs": 71.887,
"eventListeners": -14928,
"totalBlockingTimeMs": 91,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5954.070999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5756.888999999999,
"heapDeltaBytes": -10063968,
"heapUsedBytes": 178506896,
"domNodes": 0,
"jsHeapTotalBytes": -24117248,
"scriptDurationMs": 100.144,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6213.43899999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6037.26,
"heapDeltaBytes": 27676020,
"heapUsedBytes": 201986400,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 83.96599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 107.05300000006446,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.434999999999999,
"layouts": 3,
"layoutDurationMs": 1.6580000000000001,
"taskDurationMs": 81.708,
"heapDeltaBytes": 3275088,
"heapUsedBytes": 65267196,
"domNodes": 131,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.993000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 422.1019999999953,
"styleRecalcs": 15,
"styleRecalcDurationMs": 19.79,
"layouts": 3,
"layoutDurationMs": 0.99,
"taskDurationMs": 90.01799999999999,
"heapDeltaBytes": 4789128,
"heapUsedBytes": 70278404,
"domNodes": 122,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.296,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #18777 +/- ##
=============================================
Coverage ? 84.61%
=============================================
Files ? 2328
Lines ? 131998
Branches ? 35609
=============================================
Hits ? 111684
Misses ? 19968
Partials ? 346
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…overy_action (#18687) ## Summary A failed billing operation now shows the next step the server names in `recovery_action` / `retryable` instead of always offering "Please try again." + "Try again". ## Why On https://testbilling.comfy.org checkout, "Pay and subscribe" settled as `{"status":"failed","error_message":"parameter_missing","recovery_action":"contact_support","retryable":false}`. billing-web rendered "Payment could not be processed / Please try again. / Something went wrong." plus a **Try again** button. The server said the attempt cannot be retried and the customer should contact support, but the UI sent them into a retry loop and gave them no way to reach support. ## Root cause `account-core` already carried `recoveryAction` on the `PaymentProjection`, but nothing read it: - `paymentCopyKeys` always used `billing.step.<step>.body`. For `processing_error` that body is "Please try again." - `CheckoutSteps` (`account-ui`) picked actions only from the step (`processing_error → ['retry']`). It ignored both `recoveryAction` and `retryable`. ## How - `projectPaymentStep` (account-core): a failed operation passes the server's `recovery_action` through. When the server sends none and marks the operation `retryable: false`, the projection reads as `contact_support`. - `paymentCopy`: adds `billing.recovery.<action>` for every generated `recovery_action` value (`retry`, `replace_payment_method`, `authenticate_payment`, `contact_support`). Adds action keys for "Use a different payment method" and "Contact support". The body line is the recovery line when the projection names one. - `CheckoutSteps`: an exhaustive switch over `recoveryAction` picks the actions. `contact_support` renders a support link (`supportUrl` prop, default `mailto:support@comfy.org`, the address billing-web already uses) and no retry button. `retry` and `authenticate_payment` keep "Try again". `replace_payment_method` shows "Use a different payment method", which emits `retry` and returns the host to the payment form. With no recovery action, the actions still come from the step. - Card declines keep their specific copy through the coded `decline_reason` (for example `card_declined` → "Your bank declined the payment."). `error_message` is still never read, as `operationState.ts` requires. If Cloud reports Stripe decline codes only in `error_message` and not in `decline_reason`, that is a server contract gap and not something the UI should parse. ## Tests - `paymentProjection.test.ts`: covers a server-sent `contact_support`, a non-retryable failure with no named action falling back to `contact_support`, and a retryable failure that names no action. - `paymentCopy.test.ts`: `it.for` over every `recovery_action`, checking the body key. - `CheckoutSteps.test.ts`: `it.for` over `retry` / `replace_payment_method` / `authenticate_payment` (checks the line and that the button emits `retry`), plus `contact_support` (support link, no button, no "Please try again."). - billing-web e2e `checkout.spec.ts`: new scenario using the live payload. It checks for the support copy and a `mailto:support@comfy.org` link, and that no "Try again" button appears. The existing decline e2e is unchanged and still passes. ## AS IS / TO BE | AS IS | TO BE | | --- | --- | | <img width="780" alt="AS IS" src="https://github.com/user-attachments/assets/9b83283f-30fb-4805-b4c8-44934d680417" /> | <img width="780" alt="TO BE" src="https://github.com/user-attachments/assets/bfb9e706-980d-4e78-b0ff-77c7cf7820aa" /> | Team workspace checkout on test-v2, Stripe test card 4242 via Magic fill, "Pay and subscribe" clicked. Subscribe still fails on test-v2 (the D5 config bug), so both runs end on the failed operation. - AS IS: https://testbilling.comfy.org (main build) shows "Please try again." and a **Try again** button. - TO BE: this branch shows "This payment cannot be retried. Contact support@comfy.org and we will help you finish it." and a **Contact support** link (`mailto:support@comfy.org`). No Try again button. - The TO BE image is the billing-web Playwright e2e run (`apps/billing-web/e2e/checkout.spec.ts`, mocked Cloud returning `parameter_missing` with `recovery_action: contact_support`), retaken after centering the Contact support link. test-v2 subscribe no longer fails since D5 was fixed, so the failed state cannot be reproduced live now. <!-- m2-dep-graph:start --> ## Plan position: Milestone 2 payment-test fixes Found in the live M2 run (testcloud → testbilling, Team per-credit checkout). None of these PRs depends on another to merge. Solid arrows gate a milestone step; dotted ones are nice-to-have. | PR | Defect | Dependency | |---|---|---| | [D5 cloud#10518](Comfy-Org/cloud#10518) | test-v2 billing-worker uses the wrong Stripe key; every confirm fails `parameter_missing client_secret` | Blocker on test only (config). Unblocks the live re-run. | | [D4 cloud#10514](Comfy-Org/cloud#10514) | preview-subscribe attaches `payment_method_configuration_id` only when `embedded_checked_enabled` is on | Required before widening `hosted_billing_destination` past the flag cohort. | | [D3 FE #18684](#18684) | billing-web asks for a card on plan changes that need none | Independent. Shares e2e fixtures with #18687. | | **[D6 FE #18687](#18687) (this PR)** | failed-payment UI ignores `recovery_action` / `retryable` | Independent. Shares e2e fixtures with #18684. | | [D8 FE #18686](#18686) | Stripe Element labels invisible in dark theme | Independent (cosmetic). | | [D7 FE #18685](#18685) | billing-web font URL broken (`/fonts/inter-*.woff2`) | Independent (cosmetic). | ```mermaid flowchart LR c10518["D5 cloud#10518<br/>test-v2 Stripe key"] c10514["D4 cloud#10514<br/>always attach pmc id"] f18684["D3 #18684<br/>no card for plan change"] f18687["D6 #18687<br/>recovery_action UI"] f18686["D8 #18686<br/>dark-theme labels"] f18685["D7 #18685<br/>fonts"] RERUN(["M2 live payment re-run<br/>testcloud → testbilling"]) ROLLOUT(["Widen hosted_billing_destination<br/>beyond flag cohort"]) c10518 --> RERUN c10514 --> ROLLOUT f18684 --> ROLLOUT f18687 --> ROLLOUT f18686 -.-> ROLLOUT f18685 -.-> ROLLOUT RERUN --> ROLLOUT f18684 <-. "shared e2e fixtures:<br/>second to merge pulls main" .-> f18687 style f18687 fill:#f9d71c,stroke:#333,stroke-width:3px,color:#000 ``` <!-- m2-dep-graph:end -->
6ab7a75 to
192efa7
Compare
This comment has been minimized.
This comment has been minimized.
christian-byrne
left a comment
There was a problem hiding this comment.
Verified rather than rubber-stamped: the changed-file list matches the original PR exactly, and the diff contains no conflict markers. Required checks on this branch are lint-and-format, test and e2e-status; any other red check here is advisory and does not gate the merge.
Backport of #18687 to
cloud/1.55Automatically created by backport workflow.