Repository navigation
[backport core/1.55] fix(billing-web): drive failed-payment recovery from the server's recovery_action - #18776
Conversation
…overy_action (#18687) ## Summary A failed billing operation now shows the next step the server names in `recovery_action` / `retryable` instead of always offering "Please try again." + "Try again". ## Why On https://testbilling.comfy.org checkout, "Pay and subscribe" settled as `{"status":"failed","error_message":"parameter_missing","recovery_action":"contact_support","retryable":false}`. billing-web rendered "Payment could not be processed / Please try again. / Something went wrong." plus a **Try again** button. The server said the attempt cannot be retried and the customer should contact support, but the UI sent them into a retry loop and gave them no way to reach support. ## Root cause `account-core` already carried `recoveryAction` on the `PaymentProjection`, but nothing read it: - `paymentCopyKeys` always used `billing.step.<step>.body`. For `processing_error` that body is "Please try again." - `CheckoutSteps` (`account-ui`) picked actions only from the step (`processing_error → ['retry']`). It ignored both `recoveryAction` and `retryable`. ## How - `projectPaymentStep` (account-core): a failed operation passes the server's `recovery_action` through. When the server sends none and marks the operation `retryable: false`, the projection reads as `contact_support`. - `paymentCopy`: adds `billing.recovery.<action>` for every generated `recovery_action` value (`retry`, `replace_payment_method`, `authenticate_payment`, `contact_support`). Adds action keys for "Use a different payment method" and "Contact support". The body line is the recovery line when the projection names one. - `CheckoutSteps`: an exhaustive switch over `recoveryAction` picks the actions. `contact_support` renders a support link (`supportUrl` prop, default `mailto:support@comfy.org`, the address billing-web already uses) and no retry button. `retry` and `authenticate_payment` keep "Try again". `replace_payment_method` shows "Use a different payment method", which emits `retry` and returns the host to the payment form. With no recovery action, the actions still come from the step. - Card declines keep their specific copy through the coded `decline_reason` (for example `card_declined` → "Your bank declined the payment."). `error_message` is still never read, as `operationState.ts` requires. If Cloud reports Stripe decline codes only in `error_message` and not in `decline_reason`, that is a server contract gap and not something the UI should parse. ## Tests - `paymentProjection.test.ts`: covers a server-sent `contact_support`, a non-retryable failure with no named action falling back to `contact_support`, and a retryable failure that names no action. - `paymentCopy.test.ts`: `it.for` over every `recovery_action`, checking the body key. - `CheckoutSteps.test.ts`: `it.for` over `retry` / `replace_payment_method` / `authenticate_payment` (checks the line and that the button emits `retry`), plus `contact_support` (support link, no button, no "Please try again."). - billing-web e2e `checkout.spec.ts`: new scenario using the live payload. It checks for the support copy and a `mailto:support@comfy.org` link, and that no "Try again" button appears. The existing decline e2e is unchanged and still passes. ## AS IS / TO BE | AS IS | TO BE | | --- | --- | | <img width="780" alt="AS IS" src="https://github.com/user-attachments/assets/9b83283f-30fb-4805-b4c8-44934d680417" /> | <img width="780" alt="TO BE" src="https://github.com/user-attachments/assets/bfb9e706-980d-4e78-b0ff-77c7cf7820aa" /> | Team workspace checkout on test-v2, Stripe test card 4242 via Magic fill, "Pay and subscribe" clicked. Subscribe still fails on test-v2 (the D5 config bug), so both runs end on the failed operation. - AS IS: https://testbilling.comfy.org (main build) shows "Please try again." and a **Try again** button. - TO BE: this branch shows "This payment cannot be retried. Contact support@comfy.org and we will help you finish it." and a **Contact support** link (`mailto:support@comfy.org`). No Try again button. - The TO BE image is the billing-web Playwright e2e run (`apps/billing-web/e2e/checkout.spec.ts`, mocked Cloud returning `parameter_missing` with `recovery_action: contact_support`), retaken after centering the Contact support link. test-v2 subscribe no longer fails since D5 was fixed, so the failed state cannot be reproduced live now. <!-- m2-dep-graph:start --> ## Plan position: Milestone 2 payment-test fixes Found in the live M2 run (testcloud → testbilling, Team per-credit checkout). None of these PRs depends on another to merge. Solid arrows gate a milestone step; dotted ones are nice-to-have. | PR | Defect | Dependency | |---|---|---| | [D5 cloud#10518](Comfy-Org/cloud#10518) | test-v2 billing-worker uses the wrong Stripe key; every confirm fails `parameter_missing client_secret` | Blocker on test only (config). Unblocks the live re-run. | | [D4 cloud#10514](Comfy-Org/cloud#10514) | preview-subscribe attaches `payment_method_configuration_id` only when `embedded_checked_enabled` is on | Required before widening `hosted_billing_destination` past the flag cohort. | | [D3 FE #18684](#18684) | billing-web asks for a card on plan changes that need none | Independent. Shares e2e fixtures with #18687. | | **[D6 FE #18687](#18687) (this PR)** | failed-payment UI ignores `recovery_action` / `retryable` | Independent. Shares e2e fixtures with #18684. | | [D8 FE #18686](#18686) | Stripe Element labels invisible in dark theme | Independent (cosmetic). | | [D7 FE #18685](#18685) | billing-web font URL broken (`/fonts/inter-*.woff2`) | Independent (cosmetic). | ```mermaid flowchart LR c10518["D5 cloud#10518<br/>test-v2 Stripe key"] c10514["D4 cloud#10514<br/>always attach pmc id"] f18684["D3 #18684<br/>no card for plan change"] f18687["D6 #18687<br/>recovery_action UI"] f18686["D8 #18686<br/>dark-theme labels"] f18685["D7 #18685<br/>fonts"] RERUN(["M2 live payment re-run<br/>testcloud → testbilling"]) ROLLOUT(["Widen hosted_billing_destination<br/>beyond flag cohort"]) c10518 --> RERUN c10514 --> ROLLOUT f18684 --> ROLLOUT f18687 --> ROLLOUT f18686 -.-> ROLLOUT f18685 -.-> ROLLOUT RERUN --> ROLLOUT f18684 <-. "shared e2e fixtures:<br/>second to merge pulls main" .-> f18687 style f18687 fill:#f9d71c,stroke:#333,stroke-width:3px,color:#000 ``` <!-- m2-dep-graph:end -->
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a98216aca69eceb499622ed009caa3faf2539f00
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2120 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T03:43:11.782Z",
"gitSha": "827d7806fd3a89fd6a15f94c299fb582b127f7a6",
"branch": "backport-18687-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2004.209000000003,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.683,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.0550000000001,
"heapDeltaBytes": 7621396,
"heapUsedBytes": 74931704,
"domNodes": -259,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 12.450999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2008.2789999999022,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.222999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.48999999999995,
"heapDeltaBytes": 6593412,
"heapUsedBytes": 73837072,
"domNodes": -260,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.867999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1737.166000000002,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.902999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 802.3690000000001,
"heapDeltaBytes": 3951432,
"heapUsedBytes": 71520112,
"domNodes": -262,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 164.19400000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.9850000000151,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.692999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 818.8230000000001,
"heapDeltaBytes": -4908392,
"heapUsedBytes": 62596100,
"domNodes": -259,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 160.394,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.5389999999975,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.059000000000005,
"layouts": 6,
"layoutDurationMs": 1.256,
"taskDurationMs": 388.726,
"heapDeltaBytes": 3098012,
"heapUsedBytes": 70570676,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 15.135000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.8429999999553,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.795,
"layouts": 6,
"layoutDurationMs": 1.1720000000000002,
"taskDurationMs": 362.16399999999993,
"heapDeltaBytes": 3127872,
"heapUsedBytes": 70947176,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.803999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 647.5409999999897,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.084,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.21200000000005,
"heapDeltaBytes": 18634328,
"heapUsedBytes": 86197528,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 184.162,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 709.1110000000072,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.57,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.96100000000007,
"heapDeltaBytes": 18657392,
"heapUsedBytes": 86502668,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 172.07,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1220.2780000000075,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 914.0169999999999,
"heapDeltaBytes": -17724204,
"heapUsedBytes": 72686412,
"domNodes": -295,
"jsHeapTotalBytes": 19529728,
"scriptDurationMs": 72.376,
"eventListeners": -217,
"totalBlockingTimeMs": 567,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1186.3309999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 845.3059999999999,
"heapDeltaBytes": 37986600,
"heapUsedBytes": 105742344,
"domNodes": 0,
"jsHeapTotalBytes": 18509824,
"scriptDurationMs": 76.58600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 569,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.6419999999885,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.953,
"heapDeltaBytes": 14627848,
"heapUsedBytes": 91544044,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.42299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.3640000000041,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.91999999999945,
"heapDeltaBytes": 14891860,
"heapUsedBytes": 91752928,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 174.71200000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10373.69799999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9377.342999999999,
"heapDeltaBytes": -8839368,
"heapUsedBytes": 73455024,
"domNodes": -14,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7932.609,
"eventListeners": 0,
"totalBlockingTimeMs": 1380,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10659.246000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9799.063,
"heapDeltaBytes": -753828,
"heapUsedBytes": 81207316,
"domNodes": -18,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8093.639000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1103,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11088.993000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10230.649,
"heapDeltaBytes": -5008372,
"heapUsedBytes": 70869096,
"domNodes": -8,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 8485.462,
"eventListeners": 0,
"totalBlockingTimeMs": 1371,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10588.075000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9711.643,
"heapDeltaBytes": -9507172,
"heapUsedBytes": 72398992,
"domNodes": -14,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8030.557999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1223,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2054.773999999952,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.267,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 606.079,
"heapDeltaBytes": -6283208,
"heapUsedBytes": 80325772,
"domNodes": -251,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 35.495,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2051.153999999997,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.383000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 648.712,
"heapDeltaBytes": -2593668,
"heapUsedBytes": 83544560,
"domNodes": -242,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 37.081,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2444.857999999954,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.620000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1742.791,
"heapDeltaBytes": -6833836,
"heapUsedBytes": 80439016,
"domNodes": -244,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 880.84,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2334.538000000066,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.224,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1689.351,
"heapDeltaBytes": 15232808,
"heapUsedBytes": 80012056,
"domNodes": 6,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 891.487,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3652.887000000021,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.023,
"layouts": 60,
"layoutDurationMs": 14.220000000000002,
"taskDurationMs": 1791.3660000000002,
"heapDeltaBytes": 9414316,
"heapUsedBytes": 75005584,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 838.47,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3896.5029999999388,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.091999999999997,
"layouts": 60,
"layoutDurationMs": 14.212999999999997,
"taskDurationMs": 1901.287,
"heapDeltaBytes": 9038396,
"heapUsedBytes": 74866308,
"domNodes": -252,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 875.8860000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3095.4399999999964,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.837000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1852.554,
"heapDeltaBytes": 25586868,
"heapUsedBytes": 91559376,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1029.036,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3215.389000000073,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.731000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2036.1349999999998,
"heapDeltaBytes": -4805808,
"heapUsedBytes": 86044984,
"domNodes": -258,
"jsHeapTotalBytes": -77824,
"scriptDurationMs": 1022.4150000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.8449999999525,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.916000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.644,
"heapDeltaBytes": -6608784,
"heapUsedBytes": 82326508,
"domNodes": -248,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 35.16899999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2039.9210000000494,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.1179999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.7680000000001,
"heapDeltaBytes": -4108932,
"heapUsedBytes": 84138272,
"domNodes": -245,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 41.75699999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.9280000000203,
"styleRecalcs": 49,
"styleRecalcDurationMs": 13.421000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.0609999999999,
"heapDeltaBytes": 13984156,
"heapUsedBytes": 83076784,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 150.58,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.1300000000074,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.358,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.43699999999995,
"heapDeltaBytes": 13676748,
"heapUsedBytes": 83612944,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 153.222,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2016.5600000000268,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.783,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.081,
"heapDeltaBytes": 2426872,
"heapUsedBytes": 72331728,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.869999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.06699999994,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.052,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.6430000000001,
"heapDeltaBytes": 9102604,
"heapUsedBytes": 79002980,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.044999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.200999999976,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.421000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 775.4749999999999,
"heapDeltaBytes": 3869164,
"heapUsedBytes": 74049340,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 109.23100000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.9269999999033,
"styleRecalcs": 46,
"styleRecalcDurationMs": 17.917,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 779.537,
"heapDeltaBytes": -3303768,
"heapUsedBytes": 65720792,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 110.00500000000002,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1369.0390000000434,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.935000000000002,
"layouts": 5,
"layoutDurationMs": 13.086,
"taskDurationMs": 927.555,
"heapDeltaBytes": 19448032,
"heapUsedBytes": 106860724,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 30.138000000000005,
"eventListeners": 2383,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8782.100000000013,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.825,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6295.717,
"heapDeltaBytes": 4845376,
"heapUsedBytes": 84884436,
"domNodes": -240,
"jsHeapTotalBytes": 708608,
"scriptDurationMs": 2939.995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8805.186000000049,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.806,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6383.244000000001,
"heapDeltaBytes": -1376288,
"heapUsedBytes": 84917252,
"domNodes": -241,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 2993.621,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17137.64199999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16833.456000000002,
"heapDeltaBytes": -67620160,
"heapUsedBytes": 173598144,
"domNodes": -8061,
"jsHeapTotalBytes": -14880768,
"scriptDurationMs": 297.114,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17092.577000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16730.719,
"heapDeltaBytes": -33339064,
"heapUsedBytes": 180770424,
"domNodes": -8065,
"jsHeapTotalBytes": -6303744,
"scriptDurationMs": 267.82399999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21148.689000000046,
"styleRecalcs": 154,
"styleRecalcDurationMs": 20.540000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20952.549,
"heapDeltaBytes": -53334852,
"heapUsedBytes": 180791004,
"domNodes": -8061,
"jsHeapTotalBytes": -12595200,
"scriptDurationMs": 908.946,
"eventListeners": -14928,
"totalBlockingTimeMs": 26,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21272.297999999977,
"styleRecalcs": 162,
"styleRecalcDurationMs": 20.029999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21038.184999999998,
"heapDeltaBytes": -49469592,
"heapUsedBytes": 191639928,
"domNodes": -8061,
"jsHeapTotalBytes": -18882560,
"scriptDurationMs": 923.9190000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 155,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6228.530999999975,
"styleRecalcs": 20,
"styleRecalcDurationMs": 105.33500000000001,
"layouts": 20,
"layoutDurationMs": 25.20400000000002,
"taskDurationMs": 6187.183,
"heapDeltaBytes": -37049328,
"heapUsedBytes": 190741232,
"domNodes": -8061,
"jsHeapTotalBytes": 7012352,
"scriptDurationMs": 106.273,
"eventListeners": -14928,
"totalBlockingTimeMs": 417,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6154.276999999979,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.70900000000003,
"layouts": 20,
"layoutDurationMs": 24.287000000000003,
"taskDurationMs": 6094.1320000000005,
"heapDeltaBytes": -5980204,
"heapUsedBytes": 177993416,
"domNodes": 0,
"jsHeapTotalBytes": 20185088,
"scriptDurationMs": 112.60699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 441,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8626.378000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8405.736,
"heapDeltaBytes": 7496356,
"heapUsedBytes": 184767304,
"domNodes": 0,
"jsHeapTotalBytes": -20709376,
"scriptDurationMs": 135.71599999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8491.649999999936,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8364.706,
"heapDeltaBytes": 4618408,
"heapUsedBytes": 181467136,
"domNodes": 0,
"jsHeapTotalBytes": -15204352,
"scriptDurationMs": 153.04399999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 102.38799999990533,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.865,
"layouts": 2,
"layoutDurationMs": 1.2659999999999998,
"taskDurationMs": 81.032,
"heapDeltaBytes": 3168104,
"heapUsedBytes": 68779284,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.479000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 460.41600000000926,
"styleRecalcs": 16,
"styleRecalcDurationMs": 21.793000000000003,
"layouts": 4,
"layoutDurationMs": 1.755,
"taskDurationMs": 119.34899999999999,
"heapDeltaBytes": 4875376,
"heapUsedBytes": 70848300,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.952,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #18776 +/- ##
=============================================
- Coverage 84.59% 83.65% -0.94%
=============================================
Files 2294 3019 +725
Lines 131267 148912 +17645
Branches 35426 38468 +3042
=============================================
+ Hits 111044 124579 +13535
- Misses 19923 23032 +3109
- Partials 300 1301 +1001
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 731 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified rather than rubber-stamped: the changed-file list matches the original PR exactly, and the diff contains no conflict markers. Required checks on this branch are lint-and-format, test and e2e-status; any other red check here is advisory and does not gate the merge.
Backport of #18687 to
core/1.55Automatically created by backport workflow.