Skip to content

FE-2892 feat(account-core): web session client and session error codes - #18710

Merged
dante01yoon merged 13 commits into
mainfrom
dante01yoon/fe-2892-web-session-client
Sep 25, 2026
Merged

dante01yoon merged 13 commits into
mainfrom
dante01yoon/fe-2892-web-session-client

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Merge after #18714 (bot ingest-types sync from cloud@70c573d, which includes Comfy-Org/cloud#10549). This branch merges that PR's branch to use the generated zGetSessionResponse; once #18714 lands on main, merging main here leaves no ingest-types diff.

Why

Every site joins the shared web session through @comfyorg/account-core. The later SDK slices (boot rules FE-2894, authorize() FE-2895, lifecycle FE-2897) need one client for the session routes that classifies every answer into a code, so an outage can never read as a sign-out and a revoked session can never be silently restored. This PR is that client, inert until a host opts in.

How

New entry @comfyorg/account-core/webSession:

readWebSession(options, { expectedUserId? }): Promise<WebSessionResult>        // GET  /auth/session, cache: no-store
createWebSession(options, getIdentityProof, { expectedUserId }?): Promise<WebSessionResult>        // POST /auth/session (Bearer proof), then GET
deleteWebSession(options): Promise<WebSessionCommandResult>                     // DELETE /auth/session, no CSRF (works on a dead session)
// options: { apiBaseUrl, fetchImpl, signal? }; every call sends credentials: 'include'
  • WebSession, WebSessionUser, WebSessionErrorCode in sessionContracts.ts. Session failures are codes; apps own the wording.
  • Status mapping:
Response Code Retryable
401 no_session / session_expired / session_revoked NO_SESSION / SESSION_EXPIRED / SESSION_REVOKED no
401 unknown code NO_SESSION (never SESSION_REVOKED, which would block silent restore) no
403 csrf_invalid CSRF_STALE no
403 workspace_access_denied WORKSPACE_ACCESS_DENIED no
403 origin_not_allowed / cross_site_request / other; 400 workspace_id_invalid; other 4xx SESSION_REQUEST_REFUSED (with serverCode) no
4xx whose body is not an ErrorResponse (HTML page, router {"message":"Not Found"}) SESSION_REQUEST_REFUSED no
429, any 5xx, network, abort, 2xx failing the schema SESSION_UNAVAILABLE yes
live session whose user differs from expectedUserId IDENTITY_CHANGED no
  • The client classifies and never retries; the retry-with-backoff loop belongs to the boot rules (FE-2894). A failure to produce the identity proof is the provider's error and propagates to the caller rather than being classified as a transient session failure, so a signed-out provider cannot drive a retry loop.
  • revokeAllWebSessions is held out until cloud#10589 adds POST /sessions/revoke-all and its generated schema (review feedback: no unvalidated endpoint ships).
  • Every response is parsed with a generated schema: zGetSessionResponse, zCreateSessionResponse, zDeleteSessionResponse, zErrorResponse. The draft GET /session schema is gone; the generated one matches it field for field (same required/optional fields, datetime() on both expiries), so the client and tests needed no contract change.
  • createWebSession reads the session back after the POST because today's generated POST response carries no user or CSRF token. If BE-17063 returns the session from POST, that read goes away.
  • Not sent yet: X-Comfy-Client and X-Comfy-Workspace-ID. The backend adds them to the CORS allow-list in C5; sending them before that breaks the preflight.
  • @comfyorg/account-core/testing: fakeWebSessionUser() and createFakeWebSessionEndpoint({ state }), a fetch serving the four routes in each boot case (live, 401 × 3, network error, 5xx) and recording requests. The client's own tests run against it, which is what shows consumers can test the five boot cases.
  • importGuard.test.ts: now walks every file webSession.ts reaches through relative imports and fails on firebase, @firebase/*, the package's firebase entry, or ../firebase/… (the old prefix check missed relative paths), and asserts webSession.ts is among the scanned files so a rename cannot make it vacuous.
  • webSessionInertImport.test.ts: importing ./webSession or ./testing starts no fetch, timer, interval, listener or BroadcastChannel.
  • Size: about 245 non-test lines (client, contracts, package export) plus the 136-line testing fake that ships in ./testing. If the fake should be its own PR, say so.

Flag-off proof

Nothing in the cloud app imports the new entry. The PR carries the same request-level harness as FE-2891 (#18708), byte-identical so the two merge cleanly in any order: src/platform/auth/webSessionFlagOff.test.ts, 2x2 it.for over unified_cloud_auth {off, on} × unified_web_session {absent, false}, pinning the exact sign-in (incl. customer provisioning), token refresh, API call, socket reconnect, media URL and sign-out requests (method, path, full header set, credentials), and asserting no X-Comfy-Workspace-ID / X-CSRF-Token / X-Comfy-Client, credentials: 'include' only on the session POST/DELETE, and no GET /api/auth/session. 4/4 green on this branch.

Combined check: origin/main + all four unified-web-session PRs (#18707, #18708, #18710, #18711) merge without conflict. On that tree the harness passes, pnpm typecheck and pnpm knip exit 0, and pnpm test:unit gives 23807 passed with 17 failures, all in scripts/cicd/check-binary-size and reconcile-latest-release. Those fail the same way on plain main locally (exit 127, a missing local tool), so they are unrelated. The only non-test runtime diff across the four PRs is the flag getter and enum in useFeatureFlags.ts and one RemoteConfig key; nothing in src/ or apps/ reads the getter or imports @comfyorg/account-core/webSession.

AS IS / TO BE

No UI; the evidence is tests.

  • AS IS: account-core has no client for /api/auth/session; the cloud app's useSessionCookie posts and deletes it directly.
  • TO BE: @comfyorg/account-core/webSession exists, fully coded and tested, imported by nothing; cloud app requests unchanged (harness above).
pnpm --filter @comfyorg/account-core test        Test Files 62 passed, Tests 1059 passed
pnpm exec vitest run src/platform/auth/webSessionFlagOff.test.ts   Tests 4 passed
pnpm typecheck                                   exit 0
pnpm --filter @comfyorg/account-core typecheck   exit 0
pnpm --filter @comfyorg/account-core lint        exit 0
pnpm knip                                        exit 0
pnpm --filter @comfyorg/account-core check:pack . 110 packed files are publishable

Mutation checks (each reverted): dropping credentials: 'include' → 4 tests red; mapping 429/5xx to NO_SESSION → 8 red; import '../firebase/index.js' in webSession.ts → importGuard red; a top-level setTimeout → inert-import test red.

Links

Where this PR sits in the plan

Ticket Scope Blocked by State
FE-2891 unified_web_session client flag, off by default BE-17135 to turn on; C11 for website/billing-web readers #18708
FE-2892 (this PR) account-core web session client + error codes #18714 (generated GET /session types) #18710, merge after #18714
FE-2893 ADR for the shared web session none #18707
FE-2901 non-web clients stay on tokens (baseline) FE-2895 for authorize() rows #18711
FE-2894 session-backed identity + boot rules (stacked on #18710) FE-2892, C3 #18715, do not merge
FE-2895 authorize() for cookie requests (stacked on #18710) FE-2892, C5 #18716, do not merge
FE-2897 session lifecycle, heartbeat (stacked on #18715) FE-2894, C1, C3 #18719, do not merge
FE-2906 cross-origin E2E harness + §17 test ids C3/C5/C6/C7 on staging for the rows #18718 (harness only)
FE-2896, 2898–2900, 2902–2905, 2907, 2908 apps, token mint, rollout, cleanup C5/C6/C7/C8/C11 contracts not started
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2892 thisPr
Loading

readWebSession, createWebSession, deleteWebSession and revokeAllWebSessions
for the shared __Host-comfy_session cookie on ingest. Every call sends
credentials, failures are coded (six session codes plus a transient and a
refused bucket), and 429/5xx/network never read as a sign-out. Nothing
imports it yet; importing it starts no timer, listener or request.
@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2130 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2109 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/25/2026, 04:33:32 AM UTC

Links

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 97e28599a74a44dc2c4fae2b5eac9b78e4c61200

Full docs: ADR-DEVEX-LINT-0015

📦 Bundle: 10 MB gzip 🟢 -123 B

Details

Summary

  • Raw size: 42.3 MB baseline 42.3 MB — 🟢 -648 B
  • Gzip: 10 MB baseline 10 MB — 🟢 -123 B
  • Brotli: 7.04 MB baseline 7.04 MB — 🔴 +274 B
  • Bundles: 455 current • 455 baseline • 162 added / 162 removed

Category Glance
Data & Services 🟢 -418 B (3.97 MB) · Other 🟢 -230 B (17.9 MB) · Vendor & Third-Party ⚪ 0 B (17.4 MB) · Graph Workspace ⚪ 0 B (1.45 MB) · Panels & Settings ⚪ 0 B (639 kB) · Utilities & Hooks ⚪ 0 B (576 kB) · + 5 more

App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-B8Wmrs9o.js (new) — 3.77 kB 🔴 +3.77 kB 🔴 +1.9 kB 🔴 +1.65 kB
assets/index-CsRBH0A4.js (removed) 3.77 kB — 🟢 -3.77 kB 🟢 -1.9 kB 🟢 -1.65 kB

Status: 1 added / 1 removed

Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-BLh7psUZ.js (removed) 1.44 MB — 🟢 -1.44 MB 🟢 -315 kB 🟢 -236 kB
assets/GraphView-BPnIi9KN.js (new) — 1.44 MB 🔴 +1.44 MB 🔴 +315 kB 🔴 +236 kB
assets/WidgetCompositor-Cc3kKTGj.js (removed) 8.5 kB — 🟢 -8.5 kB 🟢 -2.8 kB 🟢 -2.48 kB
assets/WidgetCompositor-PqtS0Co5.js (new) — 8.5 kB 🔴 +8.5 kB 🔴 +2.8 kB 🔴 +2.48 kB

Status: 2 added / 2 removed / 1 unchanged

Views & Navigation — 134 kB (baseline 134 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-B_-O9Yl6.js (new) — 26.7 kB 🔴 +26.7 kB 🔴 +6.7 kB 🔴 +5.93 kB
assets/CloudSurveyView-DkwjJPFs.js (removed) 26.7 kB — 🟢 -26.7 kB 🟢 -6.69 kB 🟢 -5.93 kB
assets/CloudLayoutView-bcmD91aC.js (new) — 21.7 kB 🔴 +21.7 kB 🔴 +6.56 kB 🔴 +5.73 kB
assets/CloudLayoutView-DnV6zG-B.js (removed) 21.7 kB — 🟢 -21.7 kB 🟢 -6.56 kB 🟢 -5.73 kB
assets/useCloudAuthPage-Cnjjm07v.js (removed) 11 kB — 🟢 -11 kB 🟢 -4.18 kB 🟢 -3.54 kB
assets/useCloudAuthPage-Dm3HHAQF.js (new) — 11 kB 🔴 +11 kB 🔴 +4.18 kB 🔴 +3.54 kB
assets/CloudLoginView-C8zFSy_-.js (removed) 8.79 kB — 🟢 -8.79 kB 🟢 -2.57 kB 🟢 -2.27 kB
assets/CloudLoginView-D8bBazjG.js (new) — 8.79 kB 🔴 +8.79 kB 🔴 +2.57 kB 🔴 +2.28 kB
assets/UserCheckView-BNsGjADV.js (removed) 8.6 kB — 🟢 -8.6 kB 🟢 -2.18 kB 🟢 -1.9 kB
assets/UserCheckView-BvbXmrXK.js (new) — 8.6 kB 🔴 +8.6 kB 🔴 +2.18 kB 🔴 +1.9 kB
assets/CloudSignupView-DZW_q_hz.js (removed) 6.98 kB — 🟢 -6.98 kB 🟢 -2.28 kB 🟢 -1.99 kB
assets/CloudSignupView-V5-zFItv.js (new) — 6.98 kB 🔴 +6.98 kB 🔴 +2.28 kB 🔴 +1.99 kB
assets/WidgetTextPreview-bendtFLI.js (removed) 6.06 kB — 🟢 -6.06 kB 🟢 -2.12 kB 🟢 -1.89 kB
assets/WidgetTextPreview-Bg7Y3nlt.js (new) — 6.06 kB 🔴 +6.06 kB 🔴 +2.13 kB 🔴 +1.89 kB
assets/CloudSubscriptionRedirectView-CH8Lnzpj.js (removed) 5.67 kB — 🟢 -5.67 kB 🟢 -1.92 kB 🟢 -1.69 kB
assets/CloudSubscriptionRedirectView-DWmLBu2z.js (new) — 5.67 kB 🔴 +5.67 kB 🔴 +1.92 kB 🔴 +1.69 kB
assets/UserSelectView-DP2Fu3Rj.js (new) — 5.64 kB 🔴 +5.64 kB 🔴 +2 kB 🔴 +1.76 kB
assets/UserSelectView-fBiTdJtR.js (removed) 5.64 kB — 🟢 -5.64 kB 🟢 -2 kB 🟢 -1.75 kB
assets/CloudForgotPasswordView-C7d8eX4j.js (new) — 5.04 kB 🔴 +5.04 kB 🔴 +1.73 kB 🔴 +1.5 kB
assets/CloudForgotPasswordView-DaKJXusm.js (removed) 5.04 kB — 🟢 -5.04 kB 🟢 -1.73 kB 🟢 -1.51 kB
assets/CloudAuthTimeoutView-BfMrR_XN.js (new) — 4.43 kB 🔴 +4.43 kB 🔴 +1.54 kB 🔴 +1.33 kB
assets/CloudAuthTimeoutView-BSIsocde.js (removed) 4.43 kB — 🟢 -4.43 kB 🟢 -1.54 kB 🟢 -1.33 kB
assets/WidgetResolutionPreview-B7hSYqsZ.js (removed) 3.78 kB — 🟢 -3.78 kB 🟢 -1.49 kB 🟢 -1.33 kB
assets/WidgetResolutionPreview-CfOm6w0G.js (new) — 3.78 kB 🔴 +3.78 kB 🔴 +1.49 kB 🔴 +1.33 kB
assets/OAuthLayoutView-6zTQh_JG.js (new) — 1.32 kB 🔴 +1.32 kB 🔴 +707 B 🔴 +596 B
assets/OAuthLayoutView-DuByHTw1.js (removed) 1.32 kB — 🟢 -1.32 kB 🟢 -708 B 🟢 -596 B
assets/WidgetTextPreview-Cswzca4o.js (removed) 131 B — 🟢 -131 B 🟢 -100 B 🟢 -96 B
assets/WidgetTextPreview-D9OTOJAY.js (new) — 131 B 🔴 +131 B 🔴 +100 B 🔴 +90 B

Status: 14 added / 14 removed / 4 unchanged

Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/KeybindingPanel-C1NM50w4.js (new) — 49.9 kB 🔴 +49.9 kB 🔴 +10.1 kB 🔴 +8.93 kB
assets/KeybindingPanel-CurzGTJb.js (removed) 49.9 kB — 🟢 -49.9 kB 🟢 -10.1 kB 🟢 -8.94 kB
assets/CreditsPanel-BEaK6y5G.js (new) — 39 kB 🔴 +39 kB 🔴 +9.47 kB 🔴 +8.3 kB
assets/CreditsPanel-CZ7mjpkI.js (removed) 39 kB — 🟢 -39 kB 🟢 -9.47 kB 🟢 -8.3 kB
assets/SecretsPanel-BSgfiHrm.js (new) — 33.9 kB 🔴 +33.9 kB 🔴 +7.89 kB 🔴 +6.93 kB
assets/SecretsPanel-BtOaSPSJ.js (removed) 33.9 kB — 🟢 -33.9 kB 🟢 -7.89 kB 🟢 -6.94 kB
assets/AboutPanel-8bMYYP1C.js (new) — 11.4 kB 🔴 +11.4 kB 🔴 +3.15 kB 🔴 +2.82 kB
assets/AboutPanel-DyrMoDad.js (removed) 11.4 kB — 🟢 -11.4 kB 🟢 -3.15 kB 🟢 -2.82 kB
assets/ExtensionPanel-C5XJtUpg.js (new) — 9.31 kB 🔴 +9.31 kB 🔴 +2.52 kB 🔴 +2.23 kB
assets/ExtensionPanel-s6BFjO1E.js (removed) 9.31 kB — 🟢 -9.31 kB 🟢 -2.52 kB 🟢 -2.22 kB
assets/ServerConfigPanel-DpsQSCeL.js (new) — 6.11 kB 🔴 +6.11 kB 🔴 +1.94 kB 🔴 +1.72 kB
assets/ServerConfigPanel-Qctiejm3.js (removed) 6.11 kB — 🟢 -6.11 kB 🟢 -1.95 kB 🟢 -1.72 kB
assets/UserPanel-CZwnnbzv.js (removed) 5.72 kB — 🟢 -5.72 kB 🟢 -1.77 kB 🟢 -1.52 kB
assets/UserPanel-DBZCXD0H.js (new) — 5.72 kB 🔴 +5.72 kB 🔴 +1.77 kB 🔴 +1.53 kB
assets/refreshRemoteConfig-ChDmJLbt.js (new) — 4.6 kB 🔴 +4.6 kB 🔴 +1.62 kB 🔴 +1.44 kB
assets/refreshRemoteConfig-DvoB7MfZ.js (removed) 4.6 kB — 🟢 -4.6 kB 🟢 -1.62 kB 🟢 -1.44 kB
assets/CreditsPanel-BrgKdQXE.js (removed) 116 B — 🟢 -116 B 🟢 -95 B 🟢 -84 B
assets/CreditsPanel-D-rPctKB.js (new) — 116 B 🔴 +116 B 🔴 +95 B 🔴 +91 B
assets/refreshRemoteConfig-BL5oAShP.js (new) — 110 B 🔴 +110 B 🔴 +89 B 🔴 +82 B
assets/refreshRemoteConfig-CPyvhZn5.js (removed) 110 B — 🟢 -110 B 🟢 -89 B 🟢 -83 B

Status: 10 added / 10 removed / 18 unchanged

User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/SignUpForm-BN6z4yqV.js (new) — 21.4 kB 🔴 +21.4 kB 🔴 +7.07 kB 🔴 +6.09 kB
assets/SignUpForm-vexkYBYG.js (removed) 21.4 kB — 🟢 -21.4 kB 🟢 -7.07 kB 🟢 -6.09 kB
assets/PasswordFields-BsdqNyLK.js (new) — 6.15 kB 🔴 +6.15 kB 🔴 +1.85 kB 🔴 +1.61 kB
assets/PasswordFields-Gv1Ti1ln.js (removed) 6.15 kB — 🟢 -6.15 kB 🟢 -1.85 kB 🟢 -1.62 kB
assets/auth-C262RrS1.js (removed) 4.91 kB — 🟢 -4.91 kB 🟢 -1.64 kB 🟢 -1.39 kB
assets/auth-CwiCm0CY.js (new) — 4.91 kB 🔴 +4.91 kB 🔴 +1.64 kB 🔴 +1.39 kB
assets/UpdatePasswordContent-3QOwrYzQ.js (new) — 1.85 kB 🔴 +1.85 kB 🔴 +844 B 🔴 +737 B
assets/UpdatePasswordContent-Clnok3Yj.js (removed) 1.85 kB — 🟢 -1.85 kB 🟢 -841 B 🟢 -737 B
assets/authStore-CiZuTzsg.js (new) — 126 B 🔴 +126 B 🔴 +103 B 🔴 +103 B
assets/authStore-D4BPZ6lq.js (removed) 126 B — 🟢 -126 B 🟢 -103 B 🟢 -110 B
assets/workspaceAuthStore-DosQ4PXr.js (removed) 108 B — 🟢 -108 B 🟢 -99 B 🟢 -101 B
assets/workspaceAuthStore-izG0nUQJ.js (new) — 108 B 🔴 +108 B 🔴 +99 B 🔴 +107 B
assets/auth-BmQUAKol.js (new) — 105 B 🔴 +105 B 🔴 +96 B 🔴 +86 B
assets/auth-DR-G8jVN.js (removed) 105 B — 🟢 -105 B 🟢 -96 B 🟢 -87 B

Status: 7 added / 7 removed / 4 unchanged

Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyHubPublishDialog-B4ck_kYa.js (new) — 90.8 kB 🔴 +90.8 kB 🔴 +19.3 kB 🔴 +16.5 kB
assets/ComfyHubPublishDialog-BJF5VgpF.js (removed) 90.8 kB — 🟢 -90.8 kB 🟢 -19.3 kB 🟢 -16.5 kB
assets/useShareDialog-B-c_rXRg.js (removed) 23.9 kB — 🟢 -23.9 kB 🟢 -5.74 kB 🟢 -5.09 kB
assets/useShareDialog-B-CTPg8U.js (new) — 23.9 kB 🔴 +23.9 kB 🔴 +5.74 kB 🔴 +5.09 kB
assets/feedbackDialog-Bc9juRrv.js (removed) 4.45 kB — 🟢 -4.45 kB 🟢 -1.86 kB 🟢 -1.59 kB
assets/feedbackDialog-D_yiud8s.js (new) — 4.45 kB 🔴 +4.45 kB 🔴 +1.87 kB 🔴 +1.59 kB
assets/useRangeEditor-CccptqcI.js (new) — 3.29 kB 🔴 +3.29 kB 🔴 +1.14 kB 🔴 +1.06 kB
assets/useRangeEditor-LJwff4Kx.js (removed) 3.29 kB — 🟢 -3.29 kB 🟢 -1.14 kB 🟢 -1.04 kB
assets/useLayerEditor-CV1CAft0.js (removed) 1.19 kB — 🟢 -1.19 kB 🟢 -565 B 🟢 -493 B
assets/useLayerEditor-nTsFxkLb.js (new) — 1.19 kB 🔴 +1.19 kB 🔴 +567 B 🔴 +495 B
assets/ComfyHubPublishDialog-BuARsquS.js (new) — 143 B 🔴 +143 B 🔴 +105 B 🔴 +93 B
assets/ComfyHubPublishDialog-DYgurrBa.js (removed) 143 B — 🟢 -143 B 🟢 -105 B 🟢 -91 B
assets/useSubscriptionDialog-BIo76i3J.js (removed) 107 B — 🟢 -107 B 🟢 -101 B 🟢 -90 B
assets/useSubscriptionDialog-DYFIpVH8.js (new) — 107 B 🔴 +107 B 🔴 +101 B 🔴 +101 B

Status: 7 added / 7 removed / 1 unchanged

UI Components — 125 kB (baseline 125 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useMoreOptionsMenu-3ybzYGZ_.js (new) — 48 kB 🔴 +48 kB 🔴 +11.6 kB 🔴 +10 kB
assets/useMoreOptionsMenu-CnafU8Jw.js (removed) 48 kB — 🟢 -48 kB 🟢 -11.6 kB 🟢 -10 kB
assets/ComfyQueueButton-B2PuEavK.js (new) — 13.7 kB 🔴 +13.7 kB 🔴 +3.71 kB 🔴 +3.29 kB
assets/ComfyQueueButton-BgSDmQfB.js (removed) 13.7 kB — 🟢 -13.7 kB 🟢 -3.7 kB 🟢 -3.29 kB
assets/useTerminalTabs-MaaDvYEt.js (new) — 11.8 kB 🔴 +11.8 kB 🔴 +3.7 kB 🔴 +3.29 kB
assets/useTerminalTabs-VAo_tllo.js (removed) 11.8 kB — 🟢 -11.8 kB 🟢 -3.7 kB 🟢 -3.28 kB
assets/InviteMembersForm-BMJhD4sv.js (removed) 10.5 kB — 🟢 -10.5 kB 🟢 -3.15 kB 🟢 -2.82 kB
assets/InviteMembersForm-hxfYlvdX.js (new) — 10.5 kB 🔴 +10.5 kB 🔴 +3.15 kB 🔴 +2.82 kB
assets/SubscribeButton-BarKbCfP.js (removed) 2.15 kB — 🟢 -2.15 kB 🟢 -968 B 🟢 -848 B
assets/SubscribeButton-BHFTr-8q.js (new) — 2.15 kB 🔴 +2.15 kB 🔴 +970 B 🔴 +850 B
assets/cloudFeedbackTopbarButton-D4Xi9cxc.js (new) — 701 B 🔴 +701 B 🔴 +420 B 🔴 +388 B
assets/cloudFeedbackTopbarButton-DVXFO_Ds.js (removed) 701 B — 🟢 -701 B 🟢 -420 B 🟢 -380 B
assets/ComfyQueueButton-B3f4_jVP.js (removed) 128 B — 🟢 -128 B 🟢 -99 B 🟢 -93 B
assets/ComfyQueueButton-DNiSrfBs.js (new) — 128 B 🔴 +128 B 🔴 +99 B 🔴 +90 B

Status: 7 added / 7 removed / 9 unchanged

Data & Services — 3.97 MB (baseline 3.97 MB) • 🟢 -418 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/settingStore-DHuGrhsb.js (removed) 3.67 MB — 🟢 -3.67 MB 🟢 -875 kB 🟢 -659 kB
assets/settingStore-L7gQ60GO.js (new) — 3.67 MB 🔴 +3.67 MB 🔴 +875 kB 🔴 +658 kB
assets/api-DdisitRV.js (new) — 158 kB 🔴 +158 kB 🔴 +36.7 kB 🔴 +31.1 kB
assets/api-BDeHaZu0.js (removed) 157 kB — 🟢 -157 kB 🟢 -36.6 kB 🟢 -31 kB
assets/load3dService-BU5tiVRE.js (removed) 87.3 kB — 🟢 -87.3 kB 🟢 -20.4 kB 🟢 -17.7 kB
assets/load3dService-CsglQgxM.js (new) — 87.3 kB 🔴 +87.3 kB 🔴 +20.4 kB 🔴 +17.7 kB
assets/releaseStore-CpAgx0q4.js (new) — 24.9 kB 🔴 +24.9 kB 🔴 +7.39 kB 🔴 +6.49 kB
assets/releaseStore-Cpb5Y4fl.js (removed) 24.9 kB — 🟢 -24.9 kB 🟢 -7.39 kB 🟢 -6.49 kB
assets/workflowShareService-BSM_7CDu.js (new) — 17.2 kB 🔴 +17.2 kB 🔴 +5.11 kB 🔴 +4.52 kB
assets/workflowShareService-CDt9TREx.js (removed) 17.2 kB — 🟢 -17.2 kB 🟢 -5.11 kB 🟢 -4.52 kB
assets/userStore-BmBrMGdx.js (new) — 5.47 kB 🔴 +5.47 kB 🔴 +2.02 kB 🔴 +1.81 kB
assets/userStore-D5D0v3J3.js (removed) 5.47 kB — 🟢 -5.47 kB 🟢 -2.02 kB 🟢 -1.81 kB
assets/audioService-0u3kmeq0.js (removed) 1.71 kB — 🟢 -1.71 kB 🟢 -828 B 🟢 -723 B
assets/audioService-DfkxljzT.js (new) — 1.71 kB 🔴 +1.71 kB 🔴 +826 B 🔴 +723 B
assets/dialogService-Byi4mlBf.js (removed) 97 B — 🟢 -97 B 🟢 -96 B 🟢 -82 B
assets/dialogService-ZyLZiNEY.js (new) — 97 B 🔴 +97 B 🔴 +96 B 🔴 +96 B
assets/releaseStore-DxGmSr5-.js (new) — 95 B 🔴 +95 B 🔴 +86 B 🔴 +84 B
assets/releaseStore-K73WNJgr.js (removed) 95 B — 🟢 -95 B 🟢 -86 B 🟢 -86 B
assets/settingStore-Bo_h7vXl.js (new) — 95 B 🔴 +95 B 🔴 +86 B 🔴 +90 B
assets/settingStore-pLa1-cSt.js (removed) 95 B — 🟢 -95 B 🟢 -86 B 🟢 -79 B
assets/assetsStore-CcQyaNVb.js (new) — 94 B 🔴 +94 B 🔴 +92 B 🔴 +88 B
assets/assetsStore-DgyQZ9qM.js (removed) 94 B — 🟢 -94 B 🟢 -92 B 🟢 -83 B
assets/api-D_ssWelT.js (removed) 62 B — 🟢 -62 B 🟢 -74 B 🟢 -66 B
assets/api-DwW-sLQl.js (new) — 62 B 🔴 +62 B 🔴 +74 B 🔴 +66 B

Status: 12 added / 12 removed / 3 unchanged

Utilities & Hooks — 576 kB (baseline 576 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useConflictDetection-BlJC8vg6.js (new) — 244 kB 🔴 +244 kB 🔴 +55.1 kB 🔴 +44.9 kB
assets/useConflictDetection-DIN5_9R5.js (removed) 244 kB — 🟢 -244 kB 🟢 -55.1 kB 🟢 -45 kB
assets/useLayerEditorSession-C_r3vupC.js (new) — 159 kB 🔴 +159 kB 🔴 +41 kB 🔴 +34.5 kB
assets/useLayerEditorSession-C35-F3oj.js (removed) 159 kB — 🟢 -159 kB 🟢 -41 kB 🟢 -34.5 kB
assets/useLoad3d-B02KlMON.js (new) — 26.6 kB 🔴 +26.6 kB 🔴 +6.02 kB 🔴 +5.33 kB
assets/useLoad3d-CMLQYIY0.js (removed) 26.6 kB — 🟢 -26.6 kB 🟢 -6.03 kB 🟢 -5.34 kB
assets/useLoad3dViewer-C2kScwUH.js (removed) 21.9 kB — 🟢 -21.9 kB 🟢 -5.25 kB 🟢 -4.59 kB
assets/useLoad3dViewer-jSavKlrf.js (new) — 21.9 kB 🔴 +21.9 kB 🔴 +5.24 kB 🔴 +4.58 kB
assets/useImageCrop-CkgjoVeq.js (new) — 15.3 kB 🔴 +15.3 kB 🔴 +3.54 kB 🔴 +3.09 kB
assets/useImageCrop-KXRIdFPJ.js (removed) 15.3 kB — 🟢 -15.3 kB 🟢 -3.54 kB 🟢 -3.07 kB
assets/useFeatureFlags-BtXi1wws.js (removed) 11.7 kB — 🟢 -11.7 kB 🟢 -3.48 kB 🟢 -2.94 kB
assets/useFeatureFlags-Clqcckpg.js (new) — 11.7 kB 🔴 +11.7 kB 🔴 +3.47 kB 🔴 +2.94 kB
assets/useDowngradeToPersonal-CXXWqj4O.js (new) — 11 kB 🔴 +11 kB 🔴 +2.78 kB 🔴 +2.39 kB
assets/useDowngradeToPersonal-IGwFhPA1.js (removed) 11 kB — 🟢 -11 kB 🟢 -2.78 kB 🟢 -2.39 kB
assets/useExternalLink-Dfhno8U3.js (new) — 10.2 kB 🔴 +10.2 kB 🔴 +3.5 kB 🔴 +3.04 kB
assets/useExternalLink-q923-jfN.js (removed) 10.2 kB — 🟢 -10.2 kB 🟢 -3.5 kB 🟢 -3.04 kB
assets/usePricingTableUrlLoader-D24aEuEm.js (new) — 4.81 kB 🔴 +4.81 kB 🔴 +1.66 kB 🔴 +1.41 kB
assets/usePricingTableUrlLoader-Merr4V0U.js (removed) 4.81 kB — 🟢 -4.81 kB 🟢 -1.66 kB 🟢 -1.41 kB
assets/downloadUtil-DWo166LJ.js (new) — 3.67 kB 🔴 +3.67 kB 🔴 +1.4 kB 🔴 +1.17 kB
assets/downloadUtil-Vo6EOe3c.js (removed) 3.67 kB — 🟢 -3.67 kB 🟢 -1.41 kB 🟢 -1.15 kB
assets/useCompositorLayers-CnZvV0EI.js (new) — 2.93 kB 🔴 +2.93 kB 🔴 +861 B 🔴 +770 B
assets/useCompositorLayers-CUr_v34T.js (removed) 2.93 kB — 🟢 -2.93 kB 🟢 -857 B 🟢 -775 B
assets/useScheduledPlanChange-B7EJVY0A.js (removed) 2.4 kB — 🟢 -2.4 kB 🟢 -962 B 🟢 -833 B
assets/useScheduledPlanChange-DQkgu32n.js (new) — 2.4 kB 🔴 +2.4 kB 🔴 +964 B 🔴 +833 B
assets/useUpstreamValue-D-36_Fsu.js (removed) 1.97 kB — 🟢 -1.97 kB 🟢 -751 B 🟢 -661 B
assets/useUpstreamValue-HXNV2QPZ.js (new) — 1.97 kB 🔴 +1.97 kB 🔴 +751 B 🔴 +663 B
assets/useWorkspaceTierLabel-CEm1zF_N.js (new) — 1.97 kB 🔴 +1.97 kB 🔴 +845 B 🔴 +715 B
assets/useWorkspaceTierLabel-D5qLSF4v.js (removed) 1.97 kB — 🟢 -1.97 kB 🟢 -843 B 🟢 -710 B
assets/useSessionCookie-C8WiOYpb.js (removed) 688 B — 🟢 -688 B 🟢 -351 B 🟢 -307 B
assets/useSessionCookie-Dg5fW80D.js (new) — 688 B 🔴 +688 B 🔴 +352 B 🔴 +330 B
assets/useLoad3d-9AipAnHm.js (new) — 364 B 🔴 +364 B 🔴 +179 B 🔴 +159 B
assets/useLoad3d-Bd_Vp6kI.js (removed) 364 B — 🟢 -364 B 🟢 -180 B 🟢 -159 B
assets/useSessionCookie-BofxpJo_.js (removed) 101 B — 🟢 -101 B 🟢 -86 B 🟢 -83 B
assets/useSessionCookie-CDUWHQYo.js (new) — 101 B 🔴 +101 B 🔴 +86 B 🔴 +83 B
assets/useFeatureFlags-CUXhxt_3.js (removed) 98 B — 🟢 -98 B 🟢 -85 B 🟢 -79 B
assets/useFeatureFlags-DEqMbM4z.js (new) — 98 B 🔴 +98 B 🔴 +85 B 🔴 +78 B
assets/useLoad3dViewer-Bbn0Yv-8.js (new) — 98 B 🔴 +98 B 🔴 +85 B 🔴 +84 B
assets/useLoad3dViewer-CCrPPfaV.js (removed) 98 B — 🟢 -98 B 🟢 -85 B 🟢 -85 B
assets/useCurrentUser-DOpZJnbU.js (removed) 93 B — 🟢 -93 B 🟢 -94 B 🟢 -78 B
assets/useCurrentUser-jHRhiE97.js (new) — 93 B 🔴 +93 B 🔴 +94 B 🔴 +96 B

Status: 20 added / 20 removed / 16 unchanged

Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 17.9 MB (baseline 17.9 MB) • 🟢 -230 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/main-C2Tj-8NP.js (removed) 228 kB — 🟢 -228 kB 🟢 -66.7 kB 🟢 -55.9 kB
assets/main-WupOfgcX.js (new) — 228 kB 🔴 +228 kB 🔴 +66.7 kB 🔴 +55.9 kB
assets/core-CmXfZo_N.js (new) — 116 kB 🔴 +116 kB 🔴 +30.5 kB 🔴 +25.8 kB
assets/core-GiYSpvUW.js (removed) 116 kB — 🟢 -116 kB 🟢 -30.5 kB 🟢 -25.8 kB
assets/SubscriptionTransitionPreviewWorkspace-BXmHmiU1.js (removed) 113 kB — 🟢 -113 kB 🟢 -22.6 kB 🟢 -19.2 kB
assets/SubscriptionTransitionPreviewWorkspace-DlZelSWx.js (new) — 113 kB 🔴 +113 kB 🔴 +22.6 kB 🔴 +19.1 kB
assets/WorkspaceSettingsPanelContent-8i-V9fjD.js (removed) 111 kB — 🟢 -111 kB 🟢 -21.7 kB 🟢 -18.2 kB
assets/WorkspaceSettingsPanelContent-B8RHbpzh.js (new) — 111 kB 🔴 +111 kB 🔴 +21.7 kB 🔴 +18.2 kB
assets/WidgetSelect-ChUut66R.js (new) — 89.2 kB 🔴 +89.2 kB 🔴 +20.3 kB 🔴 +17.3 kB
assets/WidgetSelect-D48rw1N5.js (removed) 89.2 kB — 🟢 -89.2 kB 🟢 -20.3 kB 🟢 -17.3 kB
assets/Load3D-aAfaVIPI.js (new) — 82.4 kB 🔴 +82.4 kB 🔴 +13.6 kB 🔴 +11.4 kB
assets/Load3D-jjWk2Pch.js (removed) 82.4 kB — 🟢 -82.4 kB 🟢 -13.6 kB 🟢 -11.4 kB
assets/WidgetVideoEdit-20PLuXKL.js (new) — 74.3 kB 🔴 +74.3 kB 🔴 +17.7 kB 🔴 +15.5 kB
assets/WidgetVideoEdit-PYX_U4F_.js (removed) 74.3 kB — 🟢 -74.3 kB 🟢 -17.7 kB 🟢 -15.5 kB
assets/CameraInfo-ConEMRm9.js (new) — 67.3 kB 🔴 +67.3 kB 🔴 +14.6 kB 🔴 +12.8 kB
assets/CameraInfo-rHLXBam0.js (removed) 67.3 kB — 🟢 -67.3 kB 🟢 -14.6 kB 🟢 -12.8 kB
assets/Preview3d-C54KcXif.js (removed) 52.6 kB — 🟢 -52.6 kB 🟢 -8.6 kB 🟢 -7.51 kB
assets/Preview3d-fiLeRBXw.js (new) — 52.6 kB 🔴 +52.6 kB 🔴 +8.6 kB 🔴 +7.51 kB
assets/SubscriptionRequiredDialogContentUnified-B2IoNTUK.js (new) — 52.5 kB 🔴 +52.5 kB 🔴 +11 kB 🔴 +9.68 kB
assets/SubscriptionRequiredDialogContentUnified-ZoklmbuK.js (removed) 52.5 kB — 🟢 -52.5 kB 🟢 -11 kB 🟢 -9.66 kB
assets/Viewport3d-CYCq43Ne.js (removed) 47.7 kB — 🟢 -47.7 kB 🟢 -10.2 kB 🟢 -9.04 kB
assets/Viewport3d-DnBV2IUy.js (new) — 47.7 kB 🔴 +47.7 kB 🔴 +10.2 kB 🔴 +9.04 kB
assets/main-BgPKyS38.js (new) — 46.7 kB 🔴 +46.7 kB 🔴 +14 kB 🔴 +12.1 kB
assets/main-MYgUivM4.js (removed) 46.7 kB — 🟢 -46.7 kB 🟢 -14 kB 🟢 -12.1 kB
assets/LayerEditorContent-Dq4ZaX9n.js (removed) 45.4 kB — 🟢 -45.4 kB 🟢 -10.6 kB 🟢 -9.26 kB
assets/LayerEditorContent-DRagYfEf.js (new) — 45.4 kB 🔴 +45.4 kB 🔴 +10.6 kB 🔴 +9.27 kB
assets/WidgetBoundingBoxes-Co7ptszG.js (new) — 33.8 kB 🔴 +33.8 kB 🔴 +9.18 kB 🔴 +8.13 kB
assets/WidgetBoundingBoxes-D1LoRseF.js (removed) 33.8 kB — 🟢 -33.8 kB 🟢 -9.17 kB 🟢 -8.13 kB
assets/WidgetPainter-CQhiisuy.js (new) — 32.1 kB 🔴 +32.1 kB 🔴 +7.88 kB 🔴 +6.96 kB
assets/WidgetPainter-V7juCfNk.js (removed) 32.1 kB — 🟢 -32.1 kB 🟢 -7.88 kB 🟢 -6.96 kB
assets/Load3dViewerContent-B_B172-c.js (new) — 30.6 kB 🔴 +30.6 kB 🔴 +6.21 kB 🔴 +5.37 kB
assets/Load3dViewerContent-C6dILOiE.js (removed) 30.6 kB — 🟢 -30.6 kB 🟢 -6.21 kB 🟢 -5.38 kB
assets/HdrViewerContent-C6VS2HPr.js (removed) 29.8 kB — 🟢 -29.8 kB 🟢 -8.26 kB 🟢 -7.28 kB
assets/HdrViewerContent-C9UZqxJs.js (new) — 29.8 kB 🔴 +29.8 kB 🔴 +8.26 kB 🔴 +7.29 kB
assets/SubscriptionRequiredDialogContent-9PYe5VnS.js (new) — 27.2 kB 🔴 +27.2 kB 🔴 +6.39 kB 🔴 +5.63 kB
assets/SubscriptionRequiredDialogContent-v7iQoWSP.js (removed) 27.2 kB — 🟢 -27.2 kB 🟢 -6.39 kB 🟢 -5.63 kB
assets/SubscriptionRequiredDialogContentWorkspace-Di65fBIo.js (removed) 26.6 kB — 🟢 -26.6 kB 🟢 -6.09 kB 🟢 -5.37 kB
assets/SubscriptionRequiredDialogContentWorkspace-DKK0eIKK.js (new) — 26.6 kB 🔴 +26.6 kB 🔴 +6.09 kB 🔴 +5.38 kB
assets/load3d-DeZoHKBc.js (new) — 22.8 kB 🔴 +22.8 kB 🔴 +5.63 kB 🔴 +4.89 kB
assets/load3d-DIKk-wVh.js (removed) 22.8 kB — 🟢 -22.8 kB 🟢 -5.63 kB 🟢 -4.88 kB
assets/SignInContent-BENRoFkw.js (new) — 21 kB 🔴 +21 kB 🔴 +5.32 kB 🔴 +4.66 kB
assets/SignInContent-tCG7rX_q.js (removed) 21 kB — 🟢 -21 kB 🟢 -5.32 kB 🟢 -4.66 kB
assets/CurrentUserPopoverWorkspace-ofInH70Z.js (new) — 18 kB 🔴 +18 kB 🔴 +4.23 kB 🔴 +3.74 kB
assets/CurrentUserPopoverWorkspace-rTZCXSGY.js (removed) 18 kB — 🟢 -18 kB 🟢 -4.23 kB 🟢 -3.74 kB
assets/i18n-CtkYA5kO.js (removed) 17.1 kB — 🟢 -17.1 kB 🟢 -4.61 kB 🟢 -3.87 kB
assets/i18n-DzkL4wCE.js (new) — 17.1 kB 🔴 +17.1 kB 🔴 +4.61 kB 🔴 +3.88 kB
assets/WidgetRecordAudio-Dx50rrFJ.js (removed) 16.5 kB — 🟢 -16.5 kB 🟢 -4.59 kB 🟢 -4.1 kB
assets/WidgetRecordAudio-jqOkROz3.js (new) — 16.5 kB 🔴 +16.5 kB 🔴 +4.59 kB 🔴 +4.1 kB
assets/WidgetInputNumber-BcdeH1jY.js (new) — 13.9 kB 🔴 +13.9 kB 🔴 +3.63 kB 🔴 +3.21 kB
assets/WidgetInputNumber-BeY3tZN8.js (removed) 13.9 kB — 🟢 -13.9 kB 🟢 -3.63 kB 🟢 -3.21 kB
assets/WidgetRange-B7kQnRS0.js (removed) 13.7 kB — 🟢 -13.7 kB 🟢 -3.55 kB 🟢 -3.13 kB
assets/WidgetRange-Dhat5Hgn.js (new) — 13.7 kB 🔴 +13.7 kB 🔴 +3.55 kB 🔴 +3.13 kB
assets/WaveAudioPlayer-2QrwF0bh.js (new) — 13.6 kB 🔴 +13.6 kB 🔴 +3.62 kB 🔴 +3.19 kB
assets/WaveAudioPlayer-FK74Yb8_.js (removed) 13.6 kB — 🟢 -13.6 kB 🟢 -3.63 kB 🟢 -3.2 kB
assets/WidgetCurve-DifpYaXP.js (removed) 11.2 kB — 🟢 -11.2 kB 🟢 -3.48 kB 🟢 -3.16 kB
assets/WidgetCurve-McoAAUjK.js (new) — 11.2 kB 🔴 +11.2 kB 🔴 +3.48 kB 🔴 +3.16 kB
assets/AudioPreviewPlayer-A7EtzfRg.js (removed) 10.6 kB — 🟢 -10.6 kB 🟢 -3.04 kB 🟢 -2.72 kB
assets/AudioPreviewPlayer-BMC2c3M3.js (new) — 10.6 kB 🔴 +10.6 kB 🔴 +3.05 kB 🔴 +2.72 kB
assets/TeamWorkspacesDialogContent-Ck7cy8re.js (new) — 10.4 kB 🔴 +10.4 kB 🔴 +2.99 kB 🔴 +2.65 kB
assets/TeamWorkspacesDialogContent-DX-ueEcX.js (removed) 10.4 kB — 🟢 -10.4 kB 🟢 -2.99 kB 🟢 -2.65 kB
assets/onboardingCloudRoutes-PcyOpprS.js (new) — 9.93 kB 🔴 +9.93 kB 🔴 +2.81 kB 🔴 +2.4 kB
assets/onboardingCloudRoutes-VbrWsDCA.js (removed) 9.93 kB — 🟢 -9.93 kB 🟢 -2.81 kB 🟢 -2.41 kB
assets/InviteMemberDialogContent-_UlS_7Jw.js (removed) 9.64 kB — 🟢 -9.64 kB 🟢 -2.86 kB 🟢 -2.56 kB
assets/InviteMemberDialogContent-QmFa4TIc.js (new) — 9.64 kB 🔴 +9.64 kB 🔴 +2.86 kB 🔴 +2.55 kB
assets/WidgetImageCompare-Bk2jpURo.js (removed) 9.41 kB — 🟢 -9.41 kB 🟢 -2.85 kB 🟢 -2.53 kB
assets/WidgetImageCompare-C7ikGs8Q.js (new) — 9.41 kB 🔴 +9.41 kB 🔴 +2.85 kB 🔴 +2.53 kB
assets/nodeTemplates-B253VQf5.js (removed) 8.63 kB — 🟢 -8.63 kB 🟢 -2.97 kB 🟢 -2.61 kB
assets/nodeTemplates-ho5ZQcjq.js (new) — 8.63 kB 🔴 +8.63 kB 🔴 +2.97 kB 🔴 +2.61 kB
assets/WidgetImageCrop-BmfZrnpn.js (removed) 8.49 kB — 🟢 -8.49 kB 🟢 -2.66 kB 🟢 -2.34 kB
assets/WidgetImageCrop-GpB6-GcW.js (new) — 8.49 kB 🔴 +8.49 kB 🔴 +2.66 kB 🔴 +2.34 kB
assets/SetMemberCreditLimitDialogContent-6khE19Ks.js (new) — 8.47 kB 🔴 +8.47 kB 🔴 +2.34 kB 🔴 +2.04 kB
assets/SetMemberCreditLimitDialogContent-DfjigiI_.js (removed) 8.47 kB — 🟢 -8.47 kB 🟢 -2.33 kB 🟢 -2.04 kB
assets/CloudRunButtonWrapper-BEB5rQoB.js (removed) 8.11 kB — 🟢 -8.11 kB 🟢 -2.44 kB 🟢 -2.15 kB
assets/CloudRunButtonWrapper-BySNZfLk.js (new) — 8.11 kB 🔴 +8.11 kB 🔴 +2.44 kB 🔴 +2.15 kB
assets/WorkspaceSwitcherPopover-CCMwkO-o.js (new) — 8.08 kB 🔴 +8.08 kB 🔴 +2.4 kB 🔴 +2.13 kB
assets/WorkspaceSwitcherPopover-DC8dYHlk.js (removed) 8.08 kB — 🟢 -8.08 kB 🟢 -2.39 kB 🟢 -2.13 kB
assets/Load3DConfiguration-DJLVVUaQ.js (removed) 7.96 kB — 🟢 -7.96 kB 🟢 -2.48 kB 🟢 -2.18 kB
assets/Load3DConfiguration-DKk5KMt1.js (new) — 7.96 kB 🔴 +7.96 kB 🔴 +2.48 kB 🔴 +2.18 kB
assets/NightlySurveyController-BNSOcw8I.js (new) — 7.5 kB 🔴 +7.5 kB 🔴 +2.56 kB 🔴 +2.24 kB
assets/NightlySurveyController-BXQjtPwl.js (removed) 7.5 kB — 🟢 -7.5 kB 🟢 -2.56 kB 🟢 -2.25 kB
assets/LayoutDefault-DdLRXUzX.js (removed) 7.41 kB — 🟢 -7.41 kB 🟢 -2.43 kB 🟢 -2.13 kB
assets/LayoutDefault-Dedj3k-i.js (new) — 7.41 kB 🔴 +7.41 kB 🔴 +2.44 kB 🔴 +2.14 kB
assets/missingModelMetadata-BU06klq9.js (new) — 6.52 kB 🔴 +6.52 kB 🔴 +2.22 kB 🔴 +1.94 kB
assets/missingModelMetadata-DzWYKwFg.js (removed) 6.52 kB — 🟢 -6.52 kB 🟢 -2.22 kB 🟢 -1.95 kB
assets/WidgetWithControl-BkCmU7q0.js (removed) 6.47 kB — 🟢 -6.47 kB 🟢 -2.65 kB 🟢 -2.33 kB
assets/WidgetWithControl-DnxZ2Brf.js (new) — 6.47 kB 🔴 +6.47 kB 🔴 +2.65 kB 🔴 +2.37 kB
assets/CancelSubscriptionDialogContent-BIKCZ_8N.js (new) — 6.05 kB 🔴 +6.05 kB 🔴 +2 kB 🔴 +1.76 kB
assets/CancelSubscriptionDialogContent-CzHrvmfw.js (removed) 6.05 kB — 🟢 -6.05 kB 🟢 -2 kB 🟢 -1.76 kB
assets/main-DHfzILeG.js (removed) 5.97 kB — 🟢 -5.97 kB 🟢 -1.93 kB 🟢 -1.61 kB
assets/main-DzcLfj2k.js (new) — 5.97 kB 🔴 +5.97 kB 🔴 +1.92 kB 🔴 +1.61 kB
assets/load3dPreviewExtensions-Bf7fmNNg.js (removed) 5.88 kB — 🟢 -5.88 kB 🟢 -1.81 kB 🟢 -1.6 kB
assets/load3dPreviewExtensions-Exj5Bbty.js (new) — 5.88 kB 🔴 +5.88 kB 🔴 +1.81 kB 🔴 +1.6 kB
assets/ApiNodesSignInContent-BAphhKbU.js (new) — 5.68 kB 🔴 +5.68 kB 🔴 +2.02 kB 🔴 +1.8 kB
assets/ApiNodesSignInContent-Dp4F71g6.js (removed) 5.68 kB — 🟢 -5.68 kB 🟢 -2.01 kB 🟢 -1.79 kB
assets/launchCancellationFlow-B-yAqbsb.js (removed) 5.18 kB — 🟢 -5.18 kB 🟢 -1.78 kB 🟢 -1.55 kB
assets/launchCancellationFlow-B8XsbXuu.js (new) — 5.18 kB 🔴 +5.18 kB 🔴 +1.78 kB 🔴 +1.58 kB
assets/CreateWorkspaceDialogContent-Cbcasdnj.js (new) — 5.11 kB 🔴 +5.11 kB 🔴 +1.79 kB 🔴 +1.54 kB
assets/CreateWorkspaceDialogContent-TxATyWM4.js (removed) 5.11 kB — 🟢 -5.11 kB 🟢 -1.79 kB 🟢 -1.54 kB
assets/ChangeMemberRoleDialogContent-BoqrdywW.js (new) — 4.96 kB 🔴 +4.96 kB 🔴 +1.63 kB 🔴 +1.42 kB
assets/ChangeMemberRoleDialogContent-BRfr8FPJ.js (removed) 4.96 kB — 🟢 -4.96 kB 🟢 -1.63 kB 🟢 -1.42 kB
assets/EditWorkspaceDialogContent-BwTv32G1.js (new) — 4.92 kB 🔴 +4.92 kB 🔴 +1.76 kB 🔴 +1.52 kB
assets/EditWorkspaceDialogContent-OuLhL760.js (removed) 4.92 kB — 🟢 -4.92 kB 🟢 -1.75 kB 🟢 -1.52 kB
assets/WidgetTextarea-CjdEJ4Lu.js (new) — 4.83 kB 🔴 +4.83 kB 🔴 +1.88 kB 🔴 +1.64 kB
assets/WidgetTextarea-DyAFqaRH.js (removed) 4.83 kB — 🟢 -4.83 kB 🟢 -1.88 kB 🟢 -1.64 kB
assets/saveMesh-D-xDIcet.js (removed) 4.66 kB — 🟢 -4.66 kB 🟢 -1.5 kB 🟢 -1.32 kB
assets/saveMesh-D3cwqd1E.js (new) — 4.66 kB 🔴 +4.66 kB 🔴 +1.5 kB 🔴 +1.32 kB
assets/ValueControlPopover-CNM3BIrk.js (removed) 4.49 kB — 🟢 -4.49 kB 🟢 -1.54 kB 🟢 -1.38 kB
assets/ValueControlPopover-DBMxsww9.js (new) — 4.49 kB 🔴 +4.49 kB 🔴 +1.55 kB 🔴 +1.38 kB
assets/GlobalToast-TF9zCTLG.js (removed) 3.89 kB — 🟢 -3.89 kB 🟢 -1.54 kB 🟢 -1.32 kB
assets/GlobalToast-V0RfBYJn.js (new) — 3.89 kB 🔴 +3.89 kB 🔴 +1.53 kB 🔴 +1.33 kB
assets/DeleteWorkspaceDialogContent-ByQrBmSu.js (removed) 3.84 kB — 🟢 -3.84 kB 🟢 -1.43 kB 🟢 -1.24 kB
assets/DeleteWorkspaceDialogContent-D7GCQzbo.js (new) — 3.84 kB 🔴 +3.84 kB 🔴 +1.43 kB 🔴 +1.23 kB
assets/RemoveMemberDialogContent-B4fWv_jp.js (new) — 3.75 kB 🔴 +3.75 kB 🔴 +1.38 kB 🔴 +1.19 kB
assets/RemoveMemberDialogContent-tjZMZ86_.js (removed) 3.75 kB — 🟢 -3.75 kB 🟢 -1.37 kB 🟢 -1.19 kB
assets/RevokeInviteDialogContent-CgTFhGbb.js (removed) 3.66 kB — 🟢 -3.66 kB 🟢 -1.38 kB 🟢 -1.21 kB
assets/RevokeInviteDialogContent-YeKi648t.js (new) — 3.66 kB 🔴 +3.66 kB 🔴 +1.38 kB 🔴 +1.21 kB
assets/LeaveWorkspaceDialogContent-Bsfc5u6b.js (removed) 3.66 kB — 🟢 -3.66 kB 🟢 -1.38 kB 🟢 -1.19 kB
assets/LeaveWorkspaceDialogContent-CFVKq73X.js (new) — 3.66 kB 🔴 +3.66 kB 🔴 +1.38 kB 🔴 +1.18 kB
assets/InviteMemberUpsellDialogContent-Bfh7nvRH.js (new) — 3.46 kB 🔴 +3.46 kB 🔴 +1.23 kB 🔴 +1.08 kB
assets/InviteMemberUpsellDialogContent-D8AkOwmE.js (removed) 3.46 kB — 🟢 -3.46 kB 🟢 -1.23 kB 🟢 -1.08 kB
assets/SubscribeToRun-CGo2HArw.js (new) — 3.34 kB 🔴 +3.34 kB 🔴 +1.42 kB 🔴 +1.22 kB
assets/SubscribeToRun-DyX4Tqmv.js (removed) 3.34 kB — 🟢 -3.34 kB 🟢 -1.42 kB 🟢 -1.22 kB
assets/Media3DTop-Da6X1omJ.js (removed) 3.23 kB — 🟢 -3.23 kB 🟢 -1.28 kB 🟢 -1.12 kB
assets/Media3DTop-DDFb5kcL.js (new) — 3.23 kB 🔴 +3.23 kB 🔴 +1.28 kB 🔴 +1.12 kB
assets/load3dAdvanced-2hddrpqe.js (new) — 2.87 kB 🔴 +2.87 kB 🔴 +1.11 kB 🔴 +966 B
assets/load3dAdvanced-MIyCyTcu.js (removed) 2.87 kB — 🟢 -2.87 kB 🟢 -1.11 kB 🟢 -963 B
assets/signInSchema-CgSVzzwN.js (new) — 2.85 kB 🔴 +2.85 kB 🔴 +1.02 kB 🔴 +862 B
assets/signInSchema-DTbvxKbq.js (removed) 2.85 kB — 🟢 -2.85 kB 🟢 -1.02 kB 🟢 -863 B
assets/LocalRunButtonWrapper-CnCCK338.js (new) — 2.49 kB 🔴 +2.49 kB 🔴 +1.14 kB 🔴 +996 B
assets/LocalRunButtonWrapper-v23ifuMr.js (removed) 2.49 kB — 🟢 -2.49 kB 🟢 -1.14 kB 🟢 -996 B
assets/paymentReturnUrl-BNpHFwqs.js (new) — 1.9 kB 🔴 +1.9 kB 🔴 +946 B 🔴 +743 B
assets/paymentReturnUrl-h-39JqcH.js (removed) 1.9 kB — 🟢 -1.9 kB 🟢 -942 B 🟢 -739 B
assets/inviteLinks-5TZ33IEX.js (removed) 1.83 kB — 🟢 -1.83 kB 🟢 -1.03 kB 🟢 -798 B
assets/inviteLinks-DUKe6x8f.js (new) — 1.83 kB 🔴 +1.83 kB 🔴 +1.03 kB 🔴 +800 B
assets/MediaAudioTop-CYcf1t28.js (new) — 1.62 kB 🔴 +1.62 kB 🔴 +808 B 🔴 +667 B
assets/MediaAudioTop-DmCOeN6N.js (removed) 1.62 kB — 🟢 -1.62 kB 🟢 -810 B 🟢 -670 B
assets/cameraInfo-g81v6IQl.js (new) — 1.1 kB 🔴 +1.1 kB 🔴 +575 B 🔴 +489 B
assets/cameraInfo-MAqANwE0.js (removed) 1.1 kB — 🟢 -1.1 kB 🟢 -574 B 🟢 -487 B
assets/Load3DAdvanced-CYQyshj7.js (new) — 761 B 🔴 +761 B 🔴 +421 B 🔴 +358 B
assets/Load3DAdvanced-DCaNHuJw.js (removed) 761 B — 🟢 -761 B 🟢 -423 B 🟢 -361 B
assets/nightlyBadges-BTBBfIyi.js (removed) 411 B — 🟢 -411 B 🟢 -272 B 🟢 -230 B
assets/nightlyBadges-CCdys0wA.js (new) — 411 B 🔴 +411 B 🔴 +274 B 🔴 +230 B
assets/Load3dViewerContent-CnAQLDw1.js (new) — 137 B 🔴 +137 B 🔴 +103 B 🔴 +101 B
assets/Load3dViewerContent-Dz18cO3M.js (removed) 137 B — 🟢 -137 B 🟢 -103 B 🟢 -93 B
assets/AudioPreviewPlayer-33znnLmc.js (new) — 134 B 🔴 +134 B 🔴 +101 B 🔴 +95 B
assets/AudioPreviewPlayer-CTtlWlLm.js (removed) 134 B — 🟢 -134 B 🟢 -101 B 🟢 -87 B
assets/missingModelMetadata-Bl8foXFJ.js (new) — 125 B 🔴 +125 B 🔴 +103 B 🔴 +103 B
assets/missingModelMetadata-jmNOLnHF.js (removed) 125 B — 🟢 -125 B 🟢 -103 B 🟢 -105 B
assets/Load3DAdvanced-CBfDIR-Q.js (new) — 122 B 🔴 +122 B 🔴 +97 B 🔴 +90 B
assets/Load3DAdvanced-Cs7IUxJH.js (removed) 122 B — 🟢 -122 B 🟢 -97 B 🟢 -98 B
assets/LayoutDefault-akGcRl_j.js (removed) 119 B — 🟢 -119 B 🟢 -92 B 🟢 -90 B
assets/LayoutDefault-BYblD3PP.js (new) — 119 B 🔴 +119 B 🔴 +92 B 🔴 +81 B
assets/WidgetLegacy-BDiD1awr.js (removed) 117 B — 🟢 -117 B 🟢 -106 B 🟢 -96 B
assets/WidgetLegacy-E4kpTG6V.js (new) — 117 B 🔴 +117 B 🔴 +106 B 🔴 +105 B
assets/workflowDraftStoreV2-CvNDKflI.js (new) — 112 B 🔴 +112 B 🔴 +101 B 🔴 +109 B
assets/workflowDraftStoreV2-DSnc27E1.js (removed) 112 B — 🟢 -112 B 🟢 -101 B 🟢 -109 B
assets/CameraInfo-Bw73I9NO.js (new) — 110 B 🔴 +110 B 🔴 +93 B 🔴 +93 B
assets/CameraInfo-DGKtQoER.js (removed) 110 B — 🟢 -110 B 🟢 -93 B 🟢 -92 B
assets/Load3D-BJP5X-si.js (removed) 98 B — 🟢 -98 B 🟢 -89 B 🟢 -78 B
assets/Load3D-CrXschVY.js (new) — 98 B 🔴 +98 B 🔴 +89 B 🔴 +85 B
assets/i18n-BeGyfKzz.js (new) — 97 B 🔴 +97 B 🔴 +92 B 🔴 +101 B
assets/i18n-l6TEdjtp.js (removed) 97 B — 🟢 -97 B 🟢 -92 B 🟢 -89 B
assets/changeTracker-B-vt7AmY.js (new) — 92 B 🔴 +92 B 🔴 +94 B 🔴 +89 B
assets/changeTracker-s59T36qS.js (removed) 92 B — 🟢 -92 B 🟢 -94 B 🟢 -78 B

Status: 82 added / 82 removed / 219 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.9 MB heap
dom-widget-order-dense-n200-w200-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 584ms TBT · 80.8 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 236ms TBT · 86.5 MB heap
extension-clean-combined-draw: · 52.9 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 1162ms TBT · 84.4 MB heap
extension-rgthree-prototype-draw: · 51.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 1571ms TBT · 74.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 141ms TBT · 98.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.0 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 165.2 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 66ms TBT · 172.0 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 427ms TBT · 169.6 MB heap
vue-zoom-out-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.1 MB heap

⚠️ 3 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
extension-clean-combined-draw: heap used 77.5 MB 84.4 MB +9% ⚠️ z=2.0
large-graph-zoom: DOM nodes -228 0 -100% ⚠️ z=2.1
minimap-idle: style recalc duration 3ms 4ms +43% ⚠️ z=2.8
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=0.7
canvas-idle: p95 frame time 17ms 17ms +0% z=0.5
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 4ms 5ms +22% z=1.0
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 10 10 +0% z=0.0
canvas-idle: task duration 441ms 461ms +4% z=0.8
canvas-idle: script duration 8ms 9ms +16% z=0.6
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 62.1 MB 69.3 MB +12% z=0.6
canvas-idle: DOM nodes -228 -228 +0% z=-1.1
canvas-idle: event listeners -142 -142 +0% z=-1.0
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=0.8
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% z=0.3
canvas-mouse-sweep: layout duration 5ms 5ms +9% z=1.3
canvas-mouse-sweep: style recalc duration 17ms 18ms +7% z=0.5
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 72 73 +1% z=2.0
canvas-mouse-sweep: task duration 804ms 833ms +4% z=0.5
canvas-mouse-sweep: script duration 156ms 166ms +6% z=0.6
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 71.7 MB 67.7 MB -6% z=0.7
canvas-mouse-sweep: DOM nodes -228 -228 +0% —
canvas-mouse-sweep: event listeners -142 -153 +8% z=-0.1
canvas-zoom-sweep: avg frame time 17ms 17ms +0% z=-0.7
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% z=-1.4
canvas-zoom-sweep: layout duration 1ms 1ms -3% z=0.6
canvas-zoom-sweep: style recalc duration 10ms 10ms +2% z=0.7
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 31 31 +0% z=0.4
canvas-zoom-sweep: task duration 326ms 331ms +2% z=0.4
canvas-zoom-sweep: script duration 12ms 12ms +2% z=0.2
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 61.5 MB 61.5 MB -0% z=0.8
canvas-zoom-sweep: DOM nodes 53 53 +0% —
canvas-zoom-sweep: event listeners 15 15 +0% —
dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.7
dom-widget-clipping: p95 frame time 17ms 17ms -0% z=-1.2
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 4ms 4ms +4% z=0.6
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 13 12 -8% z=-0.1
dom-widget-clipping: task duration 429ms 445ms +4% z=0.4
dom-widget-clipping: script duration 159ms 168ms +6% z=0.5
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 76.9 MB 76.9 MB -0% z=0.1
dom-widget-clipping: DOM nodes 0 0 +0% —
dom-widget-clipping: event listeners 0 0 +0% —
dom-widget-order-dense-n200-w200-i120: avg frame time 17ms 17ms -0% z=-0.7
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms 17ms -0% z=-0.2
dom-widget-order-dense-n200-w200-i120: layout duration 0ms 0ms +0% —
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms 0ms +0% —
dom-widget-order-dense-n200-w200-i120: layout count 0 0 +0% —
dom-widget-order-dense-n200-w200-i120: style recalc count 0 0 +0% —
dom-widget-order-dense-n200-w200-i120: task duration 829ms 902ms +9% z=0.6
dom-widget-order-dense-n200-w200-i120: script duration 63ms 74ms +18% z=0.9
dom-widget-order-dense-n200-w200-i120: TBT 529ms 584ms +10% z=0.8
dom-widget-order-dense-n200-w200-i120: heap used 68.9 MB 80.8 MB +17% z=0.3
dom-widget-order-dense-n200-w200-i120: DOM nodes -259 -259 +0% z=-0.5
dom-widget-order-dense-n200-w200-i120: event listeners -185 -196 +6% z=-0.5
dom-widget-order-sparse-n1000-w20-i120: avg frame time 17ms 17ms -0% z=-0.8
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms 17ms +0% z=-0.0
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms 0ms +0% —
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms 0ms +0% —
dom-widget-order-sparse-n1000-w20-i120: layout count 0 0 +0% —
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0 0 +0% —
dom-widget-order-sparse-n1000-w20-i120: task duration 456ms 491ms +8% z=1.0
dom-widget-order-sparse-n1000-w20-i120: script duration 139ms 171ms +23% z=1.0
dom-widget-order-sparse-n1000-w20-i120: TBT 218ms 236ms +8% z=0.9
dom-widget-order-sparse-n1000-w20-i120: heap used 86.7 MB 86.5 MB -0% z=0.6
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0 0 +0% —
dom-widget-order-sparse-n1000-w20-i120: event listeners 0 0 +0% —
extension-clean-combined-draw: avg frame time 18ms 19ms +6% z=0.3
extension-clean-combined-draw: p95 frame time 33ms 50ms +50% z=1.0
extension-clean-combined-draw: layout duration 0ms 0ms +0% —
extension-clean-combined-draw: style recalc duration 0ms 0ms +0% variance too high
extension-clean-combined-draw: layout count 0 0 +0% —
extension-clean-combined-draw: style recalc count 0 0 +0% variance too high
extension-clean-combined-draw: task duration 7729ms 9328ms +21% z=0.7
extension-clean-combined-draw: script duration 6452ms 7807ms +21% z=0.8
extension-clean-combined-draw: TBT 147ms 1162ms +690% variance too high
extension-clean-combined-draw: heap used 77.5 MB 84.4 MB +9% ⚠️ z=2.0
extension-clean-combined-draw: DOM nodes 0 0 +0% z=0.7
extension-clean-combined-draw: event listeners 0 0 +0% z=0.7
extension-rgthree-prototype-draw: avg frame time 18ms 19ms +9% z=1.2
extension-rgthree-prototype-draw: p95 frame time 33ms 50ms +50% z=1.0
extension-rgthree-prototype-draw: layout duration 0ms 0ms +0% —
extension-rgthree-prototype-draw: style recalc duration 0ms 0ms +0% variance too high
extension-rgthree-prototype-draw: layout count 0 0 +0% —
extension-rgthree-prototype-draw: style recalc count 0 0 +0% variance too high
extension-rgthree-prototype-draw: task duration 8080ms 10207ms +26% z=1.3
extension-rgthree-prototype-draw: script duration 6537ms 8518ms +30% z=1.3
extension-rgthree-prototype-draw: TBT 205ms 1571ms +666% variance too high
extension-rgthree-prototype-draw: heap used 68.2 MB 74.3 MB +9% z=-0.7
extension-rgthree-prototype-draw: DOM nodes 0 -114 — z=-0.2
extension-rgthree-prototype-draw: event listeners 0 -82 — z=-0.2
large-graph-idle: avg frame time 17ms 17ms +0% z=0.4
large-graph-idle: p95 frame time 17ms 17ms -0% z=0.5
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 3ms 3ms -9% z=-0.6
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 9 7 -22% z=-1.7
large-graph-idle: task duration 594ms 564ms -5% z=-0.2
large-graph-idle: script duration 33ms 35ms +5% z=0.5
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 74.8 MB 75.7 MB +1% z=-0.0
large-graph-idle: DOM nodes -228 -228 +0% —
large-graph-idle: event listeners -164 -153 -7% z=-0.1
large-graph-pan: avg frame time 17ms 17ms -0% z=1.5
large-graph-pan: p95 frame time 17ms 17ms +0% z=-1.6
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 11ms 10ms -10% z=-0.3
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 69 69 -1% z=0.6
large-graph-pan: task duration 1574ms 1675ms +6% z=0.6
large-graph-pan: script duration 805ms 866ms +8% z=0.6
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 76.6 MB 78.5 MB +3% z=0.6
large-graph-pan: DOM nodes -228 -228 +0% z=-0.7
large-graph-pan: event listeners -164 -142 -13% z=-0.7
large-graph-zoom: avg frame time 17ms 17ms -0% z=-0.5
large-graph-zoom: p95 frame time 17ms 17ms +0% z=-1.0
large-graph-zoom: layout duration 15ms 14ms -10% z=-0.7
large-graph-zoom: style recalc duration 12ms 11ms -11% z=-1.3
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 63 62 -2% z=-2.1
large-graph-zoom: task duration 1702ms 1739ms +2% z=0.7
large-graph-zoom: script duration 780ms 819ms +5% z=0.8
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 70.8 MB 72.6 MB +3% z=-0.3
large-graph-zoom: DOM nodes -228 0 -100% ⚠️ z=2.1
large-graph-zoom: event listeners 0 0 +0% z=1.6
legacy-node-drag: avg frame time 17ms 17ms +0% z=1.0
legacy-node-drag: p95 frame time 17ms 17ms +0% z=0.1
legacy-node-drag: layout duration 0ms 0ms +0% —
legacy-node-drag: style recalc duration 7ms 6ms -19% z=-0.9
legacy-node-drag: layout count 0 0 +0% —
legacy-node-drag: style recalc count 46 44 -5% z=-0.9
legacy-node-drag: task duration 1934ms 1939ms +0% z=0.4
legacy-node-drag: script duration 994ms 976ms -2% z=0.2
legacy-node-drag: TBT 0ms 0ms +0% variance too high
legacy-node-drag: heap used 79.2 MB 87.6 MB +11% z=1.2
legacy-node-drag: DOM nodes 0 0 +0% z=0.9
legacy-node-drag: event listeners 180 180 +0% variance too high
minimap-idle: avg frame time 17ms 17ms -0% z=-3.0
minimap-idle: p95 frame time 17ms 17ms -0% z=1.9
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 3ms 4ms +43% ⚠️ z=2.8
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 7 9 +21% z=1.5
minimap-idle: task duration 554ms 634ms +15% z=1.7
minimap-idle: script duration 35ms 35ms +3% z=0.7
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 79.8 MB 70.5 MB -12% z=-3.5
minimap-idle: DOM nodes -228 -228 +0% z=-0.4
minimap-idle: event listeners -142 -164 +15% z=-1.4
subgraph-dom-widget-clipping: avg frame time 17ms 17ms -0% z=-1.1
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +0% z=-1.2
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 6ms 6ms -6% z=-0.5
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 47 47 +0% z=-0.8
subgraph-dom-widget-clipping: task duration 391ms 387ms -1% z=0.2
subgraph-dom-widget-clipping: script duration 148ms 144ms -2% z=0.3
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 73.1 MB 73.0 MB -0% z=-0.7
subgraph-dom-widget-clipping: DOM nodes 0 0 +0% —
subgraph-dom-widget-clipping: event listeners 6 6 +0% —
subgraph-idle: avg frame time 17ms 17ms +0% z=0.4
subgraph-idle: p95 frame time 17ms 17ms +0% z=-0.2
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 4ms 4ms +9% z=0.1
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 11 11 -5% z=-0.2
subgraph-idle: task duration 447ms 448ms +0% z=0.2
subgraph-idle: script duration 7ms 7ms +2% z=-0.7
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 56.3 MB 61.0 MB +8% z=-0.5
subgraph-idle: DOM nodes -244 -244 +0% z=0.3
subgraph-idle: event listeners -210 -199 -5% z=-0.1
subgraph-mouse-sweep: avg frame time 17ms 17ms -0% z=-1.3
subgraph-mouse-sweep: p95 frame time 17ms 17ms -1% z=-2.2
subgraph-mouse-sweep: layout duration 6ms 6ms -1% z=0.6
subgraph-mouse-sweep: style recalc duration 17ms 19ms +10% z=0.9
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 74 67 -9% z=-0.6
subgraph-mouse-sweep: task duration 739ms 790ms +7% z=0.6
subgraph-mouse-sweep: script duration 100ms 117ms +16% z=1.1
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 56.2 MB 69.7 MB +24% z=0.9
subgraph-mouse-sweep: DOM nodes -244 -244 +0% z=-0.3
subgraph-mouse-sweep: event listeners -210 -188 -10% z=0.2
subgraph-transition-enter: avg frame time 17ms 17ms +0% z=0.9
subgraph-transition-enter: p95 frame time 17ms 17ms +0% z=-0.6
subgraph-transition-enter: layout duration 12ms 13ms +14% z=0.3
subgraph-transition-enter: style recalc duration 28ms 29ms +4% z=0.3
subgraph-transition-enter: layout count 5 5 +0% —
subgraph-transition-enter: style recalc count 17 17 +0% z=-0.1
subgraph-transition-enter: task duration 867ms 709ms -18% z=-1.4
subgraph-transition-enter: script duration 28ms 26ms -7% z=-0.5
subgraph-transition-enter: TBT 126ms 141ms +12% z=0.5
subgraph-transition-enter: heap used 98.8 MB 98.9 MB +0% z=1.1
subgraph-transition-enter: DOM nodes 13667 13667 +0% —
subgraph-transition-enter: event listeners 2383 2383 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms -0% z=-0.5
viewport-pan-sweep: p95 frame time 17ms 17ms -1% z=-1.6
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 36ms 33ms -10% z=-0.4
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 249 249 +0% z=-1.7
viewport-pan-sweep: task duration 5493ms 5588ms +2% z=0.0
viewport-pan-sweep: script duration 2648ms 2841ms +7% z=0.6
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 73.0 MB 75.0 MB +3% z=-0.1
viewport-pan-sweep: DOM nodes -228 -228 +0% z=-0.3
viewport-pan-sweep: event listeners -142 -153 +8% z=-0.4
vue-large-graph-idle: avg frame time 18ms 18ms -0% z=0.7
vue-large-graph-idle: p95 frame time 17ms 17ms -0% z=-0.5
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 16670ms 16848ms +1% z=0.9
vue-large-graph-idle: script duration 272ms 286ms +5% z=1.2
vue-large-graph-idle: TBT 0ms 0ms +0% variance too high
vue-large-graph-idle: heap used 183.1 MB 165.2 MB -10% z=-1.9
vue-large-graph-idle: DOM nodes -8049 -8049 +0% z=0.5
vue-large-graph-idle: event listeners -14923 -14923 +0% z=0.3
vue-large-graph-pan: avg frame time 18ms 18ms +0% z=0.5
vue-large-graph-pan: p95 frame time 17ms 17ms +1% z=1.3
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 18ms 17ms -4% z=0.3
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 153 160 +4% z=0.8
vue-large-graph-pan: task duration 21009ms 20479ms -3% z=0.7
vue-large-graph-pan: script duration 882ms 929ms +5% z=1.0
vue-large-graph-pan: TBT 59ms 66ms +12% variance too high
vue-large-graph-pan: heap used 182.4 MB 172.0 MB -6% z=-0.6
vue-large-graph-pan: DOM nodes -8049 -8050 +0% z=0.1
vue-large-graph-pan: event listeners -14923 -14923 +0% z=0.3
vue-node-resize-workload: avg frame time 18ms 18ms -0% z=0.5
vue-node-resize-workload: p95 frame time 17ms 17ms -0% z=-0.5
vue-node-resize-workload: layout duration 24ms 24ms -2% z=0.2
vue-node-resize-workload: style recalc duration 74ms 80ms +8% z=0.9
vue-node-resize-workload: layout count 20 20 +0% —
vue-node-resize-workload: style recalc count 20 20 +0% —
vue-node-resize-workload: task duration 6152ms 6086ms -1% z=0.7
vue-node-resize-workload: script duration 113ms 110ms -2% z=0.4
vue-node-resize-workload: TBT 472ms 427ms -10% z=0.9
vue-node-resize-workload: heap used 185.7 MB 169.6 MB -9% z=-2.4
vue-node-resize-workload: DOM nodes -8049 -8049 +0% z=-0.4
vue-node-resize-workload: event listeners -14923 -14923 +0% z=-0.3
vue-zoom-out-idle: avg frame time 18ms 18ms +0% z=0.8
vue-zoom-out-idle: p95 frame time 17ms 17ms -0% z=-0.8
vue-zoom-out-idle: layout duration 0ms 0ms +0% —
vue-zoom-out-idle: style recalc duration 0ms 0ms +0% —
vue-zoom-out-idle: layout count 0 0 +0% —
vue-zoom-out-idle: style recalc count 0 0 +0% —
vue-zoom-out-idle: task duration 8372ms 8389ms +0% z=0.6
vue-zoom-out-idle: script duration 135ms 136ms +1% z=0.4
vue-zoom-out-idle: TBT 0ms 0ms +0% variance too high
vue-zoom-out-idle: heap used 175.5 MB 169.8 MB -3% z=-0.8
vue-zoom-out-idle: DOM nodes 0 0 +0% z=0.4
vue-zoom-out-idle: event listeners 0 0 +0% —
workflow-execution: avg frame time 17ms 17ms +0% z=0.2
workflow-execution: p95 frame time 17ms 17ms +1% z=1.8
workflow-execution: layout duration 1ms 2ms +3% z=-0.3
workflow-execution: style recalc duration 15ms 16ms +5% z=0.2
workflow-execution: layout count 3 4 +17% z=0.0
workflow-execution: style recalc count 13 11 -15% z=-0.4
workflow-execution: task duration 102ms 103ms +1% z=0.3
workflow-execution: script duration 9ms 10ms +17% z=0.2
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 63.6 MB 63.1 MB -1% z=0.2
workflow-execution: DOM nodes 102 99 -3% z=-1.8
workflow-execution: event listeners 65 57 -12% z=0.6
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: p95 frame time 17ms 0ms 0.1%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 4ms 0ms 11.9%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 10 1 5.0%
canvas-idle: task duration 421ms 50ms 11.9%
canvas-idle: script duration 9ms 1ms 10.4%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: heap used 65.1 MB 6.5 MB 10.0%
canvas-idle: DOM nodes -142 75 0.0%
canvas-idle: event listeners -92 49 0.0%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: p95 frame time 17ms 0ms 0.2%
canvas-mouse-sweep: layout duration 5ms 0ms 7.1%
canvas-mouse-sweep: style recalc duration 17ms 1ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 71 1 1.2%
canvas-mouse-sweep: task duration 798ms 66ms 8.2%
canvas-mouse-sweep: script duration 154ms 17ms 11.3%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: heap used 64.0 MB 5.4 MB 8.4%
canvas-mouse-sweep: DOM nodes -228 0 0.0%
canvas-mouse-sweep: event listeners -152 8 0.0%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: p95 frame time 17ms 0ms 0.2%
canvas-zoom-sweep: layout duration 1ms 0ms 5.6%
canvas-zoom-sweep: style recalc duration 10ms 1ms 6.3%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 1 3.4%
canvas-zoom-sweep: task duration 320ms 31ms 9.8%
canvas-zoom-sweep: script duration 12ms 1ms 7.4%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: heap used 61.3 MB 321.3 KB 0.5%
canvas-zoom-sweep: DOM nodes 53 0 0.0%
canvas-zoom-sweep: event listeners 15 0 0.0%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: p95 frame time 17ms 0ms 0.1%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 4ms 0ms 10.2%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 12 1 4.9%
dom-widget-clipping: task duration 431ms 36ms 8.4%
dom-widget-clipping: script duration 160ms 16ms 9.9%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: heap used 76.9 MB 158.3 KB 0.2%
dom-widget-clipping: DOM nodes 0 0 0.0%
dom-widget-clipping: event listeners 0 0 0.0%
dom-widget-order-dense-n200-w200-i120: avg frame time 17ms 0ms 0.0%
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms 0ms 0.2%
dom-widget-order-dense-n200-w200-i120: layout duration 0ms 0ms 0.0%
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms 0ms 0.0%
dom-widget-order-dense-n200-w200-i120: layout count 0 0 0.0%
dom-widget-order-dense-n200-w200-i120: style recalc count 0 0 0.0%
dom-widget-order-dense-n200-w200-i120: task duration 860ms 72ms 8.3%
dom-widget-order-dense-n200-w200-i120: script duration 65ms 9ms 14.1%
dom-widget-order-dense-n200-w200-i120: TBT 539ms 57ms 10.6%
dom-widget-order-dense-n200-w200-i120: heap used 78.5 MB 8.5 MB 10.8%
dom-widget-order-dense-n200-w200-i120: DOM nodes -234 50 0.0%
dom-widget-order-dense-n200-w200-i120: event listeners -177 42 0.0%
dom-widget-order-sparse-n1000-w20-i120: avg frame time 17ms 0ms 0.0%
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms 0ms 0.2%
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms 0ms 0.0%
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms 0ms 0.0%
dom-widget-order-sparse-n1000-w20-i120: layout count 0 0 0.0%
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0 0 0.0%
dom-widget-order-sparse-n1000-w20-i120: task duration 444ms 47ms 10.7%
dom-widget-order-sparse-n1000-w20-i120: script duration 149ms 22ms 14.8%
dom-widget-order-sparse-n1000-w20-i120: TBT 206ms 35ms 16.8%
dom-widget-order-sparse-n1000-w20-i120: heap used 86.2 MB 512.5 KB 0.6%
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0 0 0.0%
dom-widget-order-sparse-n1000-w20-i120: event listeners 0 0 0.0%
extension-clean-combined-draw: avg frame time 19ms 1ms 4.0%
extension-clean-combined-draw: p95 frame time 42ms 8ms 19.1%
extension-clean-combined-draw: layout duration 0ms 0ms 0.0%
extension-clean-combined-draw: style recalc duration 0ms 0ms 287.4%
extension-clean-combined-draw: layout count 0 0 0.0%
extension-clean-combined-draw: style recalc count 0 0 227.6%
extension-clean-combined-draw: task duration 8473ms 1158ms 13.7%
extension-clean-combined-draw: script duration 6964ms 1067ms 15.3%
extension-clean-combined-draw: TBT 700ms 557ms 79.6%
extension-clean-combined-draw: heap used 77.3 MB 3.6 MB 4.6%
extension-clean-combined-draw: DOM nodes -41 56 0.0%
extension-clean-combined-draw: event listeners -29 41 0.0%
extension-rgthree-prototype-draw: avg frame time 19ms 1ms 3.7%
extension-rgthree-prototype-draw: p95 frame time 42ms 8ms 20.0%
extension-rgthree-prototype-draw: layout duration 0ms 0ms 0.0%
extension-rgthree-prototype-draw: style recalc duration 0ms 0ms 151.7%
extension-rgthree-prototype-draw: layout count 0 0 0.0%
extension-rgthree-prototype-draw: style recalc count 1 1 124.6%
extension-rgthree-prototype-draw: task duration 8565ms 1302ms 15.2%
extension-rgthree-prototype-draw: script duration 6971ms 1199ms 17.2%
extension-rgthree-prototype-draw: TBT 660ms 542ms 82.1%
extension-rgthree-prototype-draw: heap used 77.7 MB 5.3 MB 6.8%
extension-rgthree-prototype-draw: DOM nodes -101 62 0.0%
extension-rgthree-prototype-draw: event listeners -73 45 0.0%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: p95 frame time 17ms 0ms 0.2%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 3ms 1ms 17.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 8 1 9.5%
large-graph-idle: task duration 572ms 44ms 7.7%
large-graph-idle: script duration 34ms 2ms 7.1%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: heap used 75.7 MB 1.9 MB 2.5%
large-graph-idle: DOM nodes -228 0 0.0%
large-graph-idle: event listeners -152 5 0.0%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: p95 frame time 17ms 0ms 0.2%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 10ms 1ms 6.2%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 68 1 1.1%
large-graph-pan: task duration 1587ms 137ms 8.7%
large-graph-pan: script duration 813ms 83ms 10.2%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: heap used 76.8 MB 3.1 MB 4.1%
large-graph-pan: DOM nodes -192 48 0.0%
large-graph-pan: event listeners -117 38 0.0%
large-graph-zoom: avg frame time 17ms 0ms 0.0%
large-graph-zoom: p95 frame time 17ms 0ms 0.2%
large-graph-zoom: layout duration 14ms 1ms 4.7%
large-graph-zoom: style recalc duration 12ms 1ms 5.9%
large-graph-zoom: layout count 60 0 0.0%
large-graph-zoom: style recalc count 64 1 1.7%
large-graph-zoom: task duration 1648ms 121ms 7.3%
large-graph-zoom: script duration 765ms 64ms 8.4%
large-graph-zoom: TBT 0ms 0ms 0.0%
large-graph-zoom: heap used 74.2 MB 4.8 MB 6.5%
large-graph-zoom: DOM nodes -117 56 0.0%
large-graph-zoom: event listeners -72 45 0.0%
legacy-node-drag: avg frame time 17ms 0ms 0.0%
legacy-node-drag: p95 frame time 17ms 0ms 0.2%
legacy-node-drag: layout duration 0ms 0ms 0.0%
legacy-node-drag: style recalc duration 6ms 1ms 8.3%
legacy-node-drag: layout count 0 0 0.0%
legacy-node-drag: style recalc count 45 1 3.2%
legacy-node-drag: task duration 1878ms 169ms 9.0%
legacy-node-drag: script duration 955ms 94ms 9.8%
legacy-node-drag: TBT 2ms 4ms 183.0%
legacy-node-drag: heap used 79.8 MB 6.2 MB 7.8%
legacy-node-drag: DOM nodes -43 45 0.0%
legacy-node-drag: event listeners 113 65 57.7%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: p95 frame time 17ms 0ms 0.2%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 3ms 0ms 10.7%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 7 1 11.0%
minimap-idle: task duration 552ms 48ms 8.8%
minimap-idle: script duration 34ms 2ms 5.8%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: heap used 77.8 MB 2.1 MB 2.7%
minimap-idle: DOM nodes -218 27 0.0%
minimap-idle: event listeners -130 25 0.0%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: p95 frame time 17ms 0ms 0.2%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 6ms 1ms 8.3%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 47 1 1.2%
subgraph-dom-widget-clipping: task duration 381ms 34ms 8.8%
subgraph-dom-widget-clipping: script duration 140ms 13ms 9.6%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: heap used 73.7 MB 925.5 KB 1.2%
subgraph-dom-widget-clipping: DOM nodes 0 0 0.0%
subgraph-dom-widget-clipping: event listeners 6 0 0.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: p95 frame time 17ms 0ms 0.2%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 4ms 1ms 13.3%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 4.8%
subgraph-idle: task duration 441ms 32ms 7.2%
subgraph-idle: script duration 8ms 1ms 10.8%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: heap used 63.4 MB 4.8 MB 7.6%
subgraph-idle: DOM nodes -244 0 0.0%
subgraph-idle: event listeners -198 7 0.0%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: p95 frame time 17ms 0ms 0.1%
subgraph-mouse-sweep: layout duration 6ms 0ms 7.6%
subgraph-mouse-sweep: style recalc duration 18ms 1ms 6.5%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 70 5 6.8%
subgraph-mouse-sweep: task duration 755ms 59ms 7.8%
subgraph-mouse-sweep: script duration 105ms 11ms 10.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: heap used 64.8 MB 5.5 MB 8.4%
subgraph-mouse-sweep: DOM nodes -239 21 0.0%
subgraph-mouse-sweep: event listeners -193 19 0.0%
subgraph-transition-enter: avg frame time 17ms 0ms 0.0%
subgraph-transition-enter: p95 frame time 17ms 0ms 0.3%
subgraph-transition-enter: layout duration 12ms 3ms 22.1%
subgraph-transition-enter: style recalc duration 28ms 4ms 15.0%
subgraph-transition-enter: layout count 5 0 0.0%
subgraph-transition-enter: style recalc count 17 1 4.1%
subgraph-transition-enter: task duration 844ms 97ms 11.5%
subgraph-transition-enter: script duration 28ms 4ms 12.8%
subgraph-transition-enter: TBT 131ms 20ms 15.3%
subgraph-transition-enter: heap used 87.9 MB 9.9 MB 11.3%
subgraph-transition-enter: DOM nodes 13667 0 0.0%
subgraph-transition-enter: event listeners 2383 0 0.0%
viewport-pan-sweep: avg frame time 17ms 0ms 0.0%
viewport-pan-sweep: p95 frame time 17ms 0ms 0.2%
viewport-pan-sweep: layout duration 0ms 0ms 0.0%
viewport-pan-sweep: style recalc duration 34ms 2ms 6.5%
viewport-pan-sweep: layout count 0 0 0.0%
viewport-pan-sweep: style recalc count 250 0 0.2%
viewport-pan-sweep: task duration 5570ms 504ms 9.0%
viewport-pan-sweep: script duration 2677ms 273ms 10.2%
viewport-pan-sweep: TBT 0ms 0ms 0.0%
viewport-pan-sweep: heap used 75.4 MB 3.7 MB 4.9%
viewport-pan-sweep: DOM nodes -222 20 0.0%
viewport-pan-sweep: event listeners -149 12 0.0%
vue-large-graph-idle: avg frame time 18ms 0ms 1.7%
vue-large-graph-idle: p95 frame time 17ms 0ms 0.2%
vue-large-graph-idle: layout duration 0ms 0ms 0.0%
vue-large-graph-idle: style recalc duration 0ms 0ms 0.0%
vue-large-graph-idle: layout count 0 0 0.0%
vue-large-graph-idle: style recalc count 0 0 0.0%
vue-large-graph-idle: task duration 15157ms 1912ms 12.6%
vue-large-graph-idle: script duration 245ms 33ms 13.4%
vue-large-graph-idle: TBT 0ms 1ms 280.3%
vue-large-graph-idle: heap used 174.6 MB 4.9 MB 2.8%
vue-large-graph-idle: DOM nodes -8051 4 0.0%
vue-large-graph-idle: event listeners -14923 1 0.0%
vue-large-graph-pan: avg frame time 18ms 0ms 1.3%
vue-large-graph-pan: p95 frame time 17ms 0ms 0.2%
vue-large-graph-pan: layout duration 0ms 0ms 0.0%
vue-large-graph-pan: style recalc duration 17ms 2ms 10.5%
vue-large-graph-pan: layout count 0 0 0.0%
vue-large-graph-pan: style recalc count 141 25 17.7%
vue-large-graph-pan: task duration 19186ms 1927ms 10.0%
vue-large-graph-pan: script duration 859ms 70ms 8.1%
vue-large-graph-pan: TBT 57ms 33ms 58.4%
vue-large-graph-pan: heap used 174.4 MB 4.1 MB 2.4%
vue-large-graph-pan: DOM nodes -8050 2 0.0%
vue-large-graph-pan: event listeners -14923 1 0.0%
vue-node-resize-workload: avg frame time 18ms 0ms 1.4%
vue-node-resize-workload: p95 frame time 17ms 0ms 0.2%
vue-node-resize-workload: layout duration 24ms 1ms 4.6%
vue-node-resize-workload: style recalc duration 73ms 7ms 9.5%
vue-node-resize-workload: layout count 20 0 0.0%
vue-node-resize-workload: style recalc count 20 0 0.0%
vue-node-resize-workload: task duration 5656ms 628ms 11.1%
vue-node-resize-workload: script duration 104ms 14ms 13.2%
vue-node-resize-workload: TBT 325ms 118ms 36.3%
vue-node-resize-workload: heap used 176.2 MB 2.7 MB 1.5%
vue-node-resize-workload: DOM nodes -8049 0 0.0%
vue-node-resize-workload: event listeners -14923 1 0.0%
vue-zoom-out-idle: avg frame time 18ms 0ms 1.3%
vue-zoom-out-idle: p95 frame time 17ms 0ms 0.2%
vue-zoom-out-idle: layout duration 0ms 0ms 0.0%
vue-zoom-out-idle: style recalc duration 0ms 0ms 0.0%
vue-zoom-out-idle: layout count 0 0 0.0%
vue-zoom-out-idle: style recalc count 0 0 0.0%
vue-zoom-out-idle: task duration 7872ms 803ms 10.2%
vue-zoom-out-idle: script duration 127ms 19ms 15.1%
vue-zoom-out-idle: TBT 0ms 0ms 387.3%
vue-zoom-out-idle: heap used 174.0 MB 5.3 MB 3.0%
vue-zoom-out-idle: DOM nodes -0 0 0.0%
vue-zoom-out-idle: event listeners 0 0 0.0%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: p95 frame time 17ms 0ms 0.2%
workflow-execution: layout duration 2ms 0ms 21.5%
workflow-execution: style recalc duration 15ms 2ms 15.1%
workflow-execution: layout count 3 1 18.7%
workflow-execution: style recalc count 12 4 29.8%
workflow-execution: task duration 98ms 15ms 15.1%
workflow-execution: script duration 10ms 1ms 14.8%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: heap used 62.9 MB 649.3 KB 1.0%
workflow-execution: DOM nodes 113 8 6.9%
workflow-execution: event listeners 48 16 33.7%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▃▆▆█▁▆▃▃▃▆▁▆▆▆▁ ➡️ 17ms
canvas-idle: p95 frame time ▃▆▃▁▃▃▃▃▃▁█▆▃▃▃ ➡️ 17ms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▆▇▇▆▅▄▄█▆▆▇█▁█▅ ➡️ 4ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count ▃▅▅▃▅▆▁▆▅▇▂▅█▃▆ ➡️ 10
canvas-idle: task duration ▅▄▆▆▅▆▅▆▅▃█▇▁▅▅ ➡️ 427ms
canvas-idle: script duration ▄▄▂▄▁▁▂▂▁▂█▄▁▂▁ ➡️ 8ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used █▁▂▂▇▂▅▁▇▄▂▅▂▂▂ ➡️ 61.4 MB
canvas-idle: DOM nodes ▆▃▁▁▆▁▆▃█▆▁▁▆▃▃ 📉 -152
canvas-idle: event listeners ▆▃▁▁▅▁▆▄█▆▁▁▆▃▄ 📉 -95
canvas-mouse-sweep: avg frame time ▁▄█▄▄▄▅▄▅▄▄▄▄▄▄ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ▁▆▃▃▃▃▆▆▁▃█▃▁█▁ ➡️ 17ms
canvas-mouse-sweep: layout duration ▇▅▅▆▆▆█▅▇▃▆▅▁▆▅ ➡️ 5ms
canvas-mouse-sweep: style recalc duration ▆▆▇▆▅▇█▆▇▄▇▇▁▇▆ ➡️ 17ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count ▆▆▆▁█▄█▂▃▅▄▄▅▃▆ ➡️ 72
canvas-mouse-sweep: task duration ▇▃▇▇▆▆▇▆▆▃█▆▁▆▆ ➡️ 804ms
canvas-mouse-sweep: script duration ▆▃▇▇▆▅▇▇█▃██▁█▆ ➡️ 154ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used █▁▄▆▅▅▇▃▇▁▅▅▂▆▆ ➡️ 66.4 MB
canvas-mouse-sweep: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ -228
canvas-mouse-sweep: event listeners █▁▃▆▆▆█▃█▁▃▆▁▆▆ ➡️ -149
canvas-zoom-sweep: avg frame time █▆▅▆▃▆▁▅▆▆▆▆▅▃▃ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ▃▁▃▁▃▃▆▃▃▆█▆▁▃▃ ➡️ 17ms
canvas-zoom-sweep: layout duration ▆▂▁▅▇▆█▅▆▄▄▇▆▂▇ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▇▃▆▇▄▆▆██▄██▁▆▇ ➡️ 10ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▅▃▇▆▇▇▆▇▆▁▅█▃▆▆ ➡️ 31
canvas-zoom-sweep: task duration ▅▃▇▇▄▅▆▆▆▁██▁▆▆ ➡️ 326ms
canvas-zoom-sweep: script duration ▄▅▆▅▃▄▄▅▅▄██▁▄▄ ➡️ 11ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ██▆▁▃▇▅▅▆▇▆▇▇▆▇ ➡️ 61.5 MB
canvas-zoom-sweep: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 53
canvas-zoom-sweep: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 15
dom-widget-clipping: avg frame time █▄▆▁▄▆▃▆▄▆▄▃▅▆▅ ➡️ 17ms
dom-widget-clipping: p95 frame time █▁▁█▅▁▅▄▅█▁▅▅▅▁ ➡️ 17ms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▄█▆▆▇▅▇▆▆▅▅▆▁▆▅ ➡️ 4ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▅█▂▃▇▂▅▅▃▇▁▆▇▇▆ ➡️ 12
dom-widget-clipping: task duration ▇▃█▆▇▇▇█▇▃█▇▁▇▆ ➡️ 432ms
dom-widget-clipping: script duration ▆▃█▆▆▇▇▇▇▃▇▇▁▇▆ ➡️ 160ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ▁▂▇▂▅▂▅▆▃▅▅█▂▆▁ ➡️ 76.7 MB
dom-widget-clipping: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-dense-n200-w200-i120: avg frame time ▁█▁▃▆▃▃▃▁▆▃▆▁█▃ ➡️ 17ms
dom-widget-order-dense-n200-w200-i120: p95 frame time ▆▆█▁▆▃▃▆▆▁▃▆█▃█ ➡️ 17ms
dom-widget-order-dense-n200-w200-i120: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-order-dense-n200-w200-i120: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-dense-n200-w200-i120: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-dense-n200-w200-i120: task duration ▅▁▅▆▅▅▆▅▇▁█▇▃▆▄ ➡️ 839ms
dom-widget-order-dense-n200-w200-i120: script duration ▄▂▇█▃▄▅██▁█▇▁▆▄ ➡️ 62ms
dom-widget-order-dense-n200-w200-i120: TBT ▇▂▇▇▅▅▆▇▇▁█▇▃▆▅ ➡️ 530ms
dom-widget-order-dense-n200-w200-i120: heap used ▅▆█▆▃▁▁▆▃▃▁▃▁▁▃ ➡️ 78.4 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes ▁▁▅▁▁▁▁█▁▁▁▁▁▁▅ ➡️ -173
dom-widget-order-dense-n200-w200-i120: event listeners ▂▂▅▅▁▁▁█▁▁▁▂▁▂▅ ➡️ -131
dom-widget-order-sparse-n1000-w20-i120: avg frame time ▃▁▆▁▆▆█▃▃▃█▃▃▁▃ ➡️ 17ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time █▃▆▃▃▃▃▃▆▆▆▆█▁▃ ➡️ 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-sparse-n1000-w20-i120: task duration ▅▃█▇▅▇▇▆▇▃▇█▁█▆ ➡️ 451ms
dom-widget-order-sparse-n1000-w20-i120: script duration ▄▃█▇▄▅▅▇▇▂▇█▁█▄ ➡️ 140ms
dom-widget-order-sparse-n1000-w20-i120: TBT ▅▃█▇▅▇▇██▃▇█▁█▇ ➡️ 219ms
dom-widget-order-sparse-n1000-w20-i120: heap used ▅▅▆▅▆▄▆▃▂▂▂█▄▁▇ ➡️ 86.8 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-sparse-n1000-w20-i120: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
extension-clean-combined-draw: avg frame time ▆▂▇▅▂▁▄▇▅▁█▆▂▅▁ ➡️ 18ms
extension-clean-combined-draw: p95 frame time ▆▁██▁▁▃██▁██▁█▁ ➡️ 33ms
extension-clean-combined-draw: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
extension-clean-combined-draw: style recalc duration ▁█▁▁▁▁▁▁▁▁▁▁▃▁▁ 📉 0ms
extension-clean-combined-draw: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
extension-clean-combined-draw: style recalc count ▁▆▁▁▁▁▁▁▁▃▁▁█▁▁ 📈 0
extension-clean-combined-draw: task duration ▅▂▇▇▅▄▆██▃█▇▁▇▄ ➡️ 7786ms
extension-clean-combined-draw: script duration ▅▂▇▇▅▄▆▇█▃█▇▁▇▄ ➡️ 6413ms
extension-clean-combined-draw: TBT ▃▁▇▇▂▂▃█▇▁█▇▁▆▂ 📈 211ms
extension-clean-combined-draw: heap used ▄▄▄▂▄▄▄█▂▅▅█▆▁▇ ➡️ 81.3 MB
extension-clean-combined-draw: DOM nodes █▅▁▁██████▅▅▅██ 📉 0
extension-clean-combined-draw: event listeners █▅▁▁██████▅▅▅██ 📉 0
extension-rgthree-prototype-draw: avg frame time ▇▂▇▅▂▁▂▅▇▂▇█▂▇▁ ➡️ 18ms
extension-rgthree-prototype-draw: p95 frame time ▆▁██▁▁▁██▁██▁█▁ ➡️ 33ms
extension-rgthree-prototype-draw: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
extension-rgthree-prototype-draw: style recalc duration ▁█▁▁▃▃▁▁▁▅▁▁█▁▃ 📈 0ms
extension-rgthree-prototype-draw: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
extension-rgthree-prototype-draw: style recalc count ▂▇▁▂▃▄▁▁▁▅▁▂█▂▂ ➡️ 0
extension-rgthree-prototype-draw: task duration ▅▃▇█▄▅▅██▂██▁▇▅ ➡️ 8117ms
extension-rgthree-prototype-draw: script duration ▅▃▇█▄▅▅██▂██▁▇▅ ➡️ 6561ms
extension-rgthree-prototype-draw: TBT ▃▁▇▇▂▂▂▇▇▁█▇▁▆▂ 📈 209ms
extension-rgthree-prototype-draw: heap used ▄█▂▁▆▃▅▇▅▂▅▅▅▆▂ ➡️ 71.1 MB
extension-rgthree-prototype-draw: DOM nodes ▆▁▆▃▆▃▆██▆▆▃▃▄▆ 📉 -76
extension-rgthree-prototype-draw: event listeners ▆▁▆▃▆▃▆██▆▆▃▃▃▆ 📉 -55
large-graph-idle: avg frame time ▁▃▆█▃▃█▆▃▆▆▆▃▆▆ ➡️ 17ms
large-graph-idle: p95 frame time ▃▁▃▆▆▁▃▆▁▁▁▁▃▆█ ➡️ 17ms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▄█▃▆▂▃▄▄▄▄▅▄▁█▄ ➡️ 3ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count ▇█▁▅▃▆▄▄▃▇▃▂██▇ ➡️ 9
large-graph-idle: task duration ▅▂▄▄▄▄▅▄▄▂█▅▁▅▅ ➡️ 595ms
large-graph-idle: script duration ▅▃▄▅▂▅▇▄▄▃█▇▁▇▅ ➡️ 34ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ▆▆▆█▅▅▅▅▅▆▅▅▁▆▅ ➡️ 75.2 MB
large-graph-idle: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ -228
large-graph-idle: event listeners ▆▆▆█▆▆▃▆▃▆▃▆▁▃▃ ➡️ -157
large-graph-pan: avg frame time █▄▁▅█▄▄▅█▄▄▄▁▁▄ ➡️ 17ms
large-graph-pan: p95 frame time ▄▁▁▄██▄█▄█▁███▄ ➡️ 17ms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▅█▁▂▂▇▇▄▄▇▄▅▃▃█ ➡️ 11ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▇▆▁▁▂▆▃▆▅▆▅▇█▅█ ➡️ 69
large-graph-pan: task duration ▆▂▅▆▅▅▅▆▇▂█▇▁▆▅ ➡️ 1573ms
large-graph-pan: script duration ▆▂▆▇▅▅▅▆▇▂█▇▁▆▅ ➡️ 799ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ▃▆▆▆▄▅▅▆▃▇▅▃▁█▄ ➡️ 74.9 MB
large-graph-pan: DOM nodes ▁▅█▅▁▁▁▁▅▅▁▁▁▄▁ ➡️ -228
large-graph-pan: event listeners ▁▅██▁▄▂▅▄▅▅▁▁▅▁ 📈 -157
large-graph-zoom: avg frame time █▁▆▆▁▃▃▁▃▃▁▃▁▆▃ ➡️ 17ms
large-graph-zoom: p95 frame time ▆▆▆▁█▃▁▁▁█▃▁▃▁▃ ➡️ 17ms
large-graph-zoom: layout duration ▃▄▂▂▂▆█▃▁▂▄▂▂▂▅ ➡️ 15ms
large-graph-zoom: style recalc duration ▄▆▁▁▃▇█▅▄▃▅▂▄▃▅ ➡️ 12ms
large-graph-zoom: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 60
large-graph-zoom: style recalc count ▅▇▁▂▆▆▄▇▁▄▄▂█▄▃ ➡️ 64
large-graph-zoom: task duration ▅▃▅▆▅▅▆▇▆▂█▇▁▆▆ ➡️ 1698ms
large-graph-zoom: script duration ▆▃▇▇▅▆▆▇▇▂█▇▁▆▆ ➡️ 784ms
large-graph-zoom: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-zoom: heap used ▃▅▃▃▁█▄▆▃▃▅▃▅▄▂ ➡️ 69.4 MB
large-graph-zoom: DOM nodes ▃▁█▆▃▆▆▃▃▆▃▆▃▆▃ 📈 -152
large-graph-zoom: event listeners ▃▁██▃▆▆▃▆▆▃▆▃▆▆ ➡️ -55
legacy-node-drag: avg frame time ██▅▄▁▁█▄██▄█▅▅▅ ➡️ 17ms
legacy-node-drag: p95 frame time ▁▃█▁▆█▁▃▆█▆▁▃▃▃ ➡️ 17ms
legacy-node-drag: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
legacy-node-drag: style recalc duration ▆▆▁▅▄▂▅▃▂▇█▇▁▃█ ➡️ 7ms
legacy-node-drag: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
legacy-node-drag: style recalc count ▃▅▁▅▅▁▂▃▂█▂▆▅▃▆ ➡️ 46
legacy-node-drag: task duration ▇▃▇▆▆▆▇▆▆▃█▇▁▇▆ ➡️ 1923ms
legacy-node-drag: script duration ▇▃▇▇▆▆▇▇▇▃█▇▁▇▇ ➡️ 997ms
legacy-node-drag: TBT ▁▁▁█▇▁▁▁▁▁▁▅▁▁▄ 📉 5ms
legacy-node-drag: heap used █▇▄▄▄▇▆▆▁▂▆▃▂▆▄ ➡️ 78.0 MB
legacy-node-drag: DOM nodes ▁██▅▄▄████▄█▅▄▅ 📉 -66
legacy-node-drag: event listeners ▅██▆▅▆█▅██▅▁▆▅▆ 📉 125
minimap-idle: avg frame time ▆█▁▃█▁▆▆▆▃▆▆▆▆█ ➡️ 17ms
minimap-idle: p95 frame time ▃▃▁▃▃▁█▁▆▃█▃▃▃▆ ➡️ 17ms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▇▄▇█▄▄▄▄█▄▅▃▁▅▅ ➡️ 3ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▁▅▅█▄▅▃▅▅▆▃▂█▅▂ ➡️ 6
minimap-idle: task duration ▄▂▅▆▅▅▄▄▆▁██▁▃▄ ➡️ 552ms
minimap-idle: script duration ▃▂▆▄▄▄▅▃▅▂█▇▁▄▅ ➡️ 35ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used █▅▃▁▆▅█▅▅█▆▇▅▅█ ➡️ 79.9 MB
minimap-idle: DOM nodes ▁▁█▁▁▁▁█▁▁▁▁▁▁▁ ➡️ -228
minimap-idle: event listeners ▃▂▇▁▂▂█▇▂▃▇▂▂▇█ ➡️ -95
subgraph-dom-widget-clipping: avg frame time ▅▆▁▃▅▄▆█▁▃▆▃▅▅▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ▃▃▃▆▆▆█▁▃▁█▃▁▆▁ ➡️ 17ms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration █▇▇█▆▇██▇█▇▇▁▇▇ ➡️ 6ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▅▆▅▃▅▃▂▁▃█▅▅▇▁▁ ➡️ 47
subgraph-dom-widget-clipping: task duration █▃█▇▆▇▇▇█▃██▁▇▆ ➡️ 373ms
subgraph-dom-widget-clipping: script duration ▇▃▇█▆▇█▇█▄▇▇▁▇▇ ➡️ 146ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ▂▂▁▂▂██▁▃▂█▂▂▂▂ ➡️ 73.2 MB
subgraph-dom-widget-clipping: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
subgraph-idle: avg frame time ▆▄▆▆▄█▄█▆▃▆▁▆▄▆ ➡️ 17ms
subgraph-idle: p95 frame time ▃▆▃▃██▆▃▁▃██▆▃▃ ➡️ 17ms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▅▆▅▆▄▃▅▆▇▆██▁▆▄ ➡️ 4ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▄▅▁▅▁▄▅▂▂█▁▂▅▅▁ ➡️ 10
subgraph-idle: task duration ▆▂▅▅▃▄▃▅▅▂█▇▁▄▅ ➡️ 448ms
subgraph-idle: script duration ▃▃▁▂▁▁▄▂▂▆█▅▁▂▂ ➡️ 7ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ▇▃▄▆▆▁█▄▄▅▆▄▁▆▄ ➡️ 61.2 MB
subgraph-idle: DOM nodes ████████████▁██ ➡️ -244
subgraph-idle: event listeners ▆▄▆▆▆▂█▄▄▆▆█▁▆▄ ➡️ -203
subgraph-mouse-sweep: avg frame time ▃▃▁▆▆█▁▆▆▆▆▆▆▆▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ▄▁▄▄▄▄█████▄█▄█ ➡️ 17ms
subgraph-mouse-sweep: layout duration █▅▆▇▅▆█▇▆▆▇▇▁▇█ ➡️ 6ms
subgraph-mouse-sweep: style recalc duration ▆▆▆▇▆▆█▇▇▆██▁▇▇ ➡️ 18ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅█▃▅▇▅▇▁▇▇▅▇█▃▅ ➡️ 69
subgraph-mouse-sweep: task duration ▆▃▆▆▅▅▆▆▆▃█▅▁▅▅ ➡️ 766ms
subgraph-mouse-sweep: script duration ▅▄▇▇▅▅▆▇▇▄█▇▁▇▅ ➡️ 104ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ▁▇▄▄▆▃█▅▆█▆▃▁▆▂ ➡️ 57.5 MB
subgraph-mouse-sweep: DOM nodes ▁█▁▁▁▁▁▁▁▁▁▁▁▁▁ ➡️ -244
subgraph-mouse-sweep: event listeners ▁█▂▂▃▂▃▂▃▃▃▂▁▃▁ ➡️ -210
subgraph-transition-enter: avg frame time ▁█▁█▁████▁██▁▁▁ ➡️ 17ms
subgraph-transition-enter: p95 frame time ▁▁▁█▁▁▁▁▁██▁█▁▁ ➡️ 17ms
subgraph-transition-enter: layout duration ▃▂▄▄▂▃▃▄▄▁█▄▁▄▃ ➡️ 12ms
subgraph-transition-enter: style recalc duration ▃▁▄▄▃▃▅▄▅▁█▅▁▅▄ ➡️ 28ms
subgraph-transition-enter: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 5
subgraph-transition-enter: style recalc count ██▅▅▅▅▅▁█▅▁█▅▁▅ ➡️ 17
subgraph-transition-enter: task duration ▁▃▅▅▅▅▅▅▅▁█▆▁▅▅ ➡️ 867ms
subgraph-transition-enter: script duration ▃▄▆▆▅▅▆▅▆▁█▇▁▅▅ ➡️ 28ms
subgraph-transition-enter: TBT ▅▁▆▆▄▄▅▅▆▁█▆▃▆▄ ➡️ 126ms
subgraph-transition-enter: heap used ▇▆▇█▁▁▆▁▁▁▁▁███ ➡️ 98.8 MB
subgraph-transition-enter: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 13667
subgraph-transition-enter: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 2383
viewport-pan-sweep: avg frame time ▃▃▃▁▁▃▁▅▆▃▃█▁▁▃ ➡️ 17ms
viewport-pan-sweep: p95 frame time ▅▁█▅██▄█▄▁▁██▅█ ➡️ 17ms
viewport-pan-sweep: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
viewport-pan-sweep: style recalc duration ▄▅▃▄▂▆█▄▃▅▄▄▁▃▆ ➡️ 36ms
viewport-pan-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
viewport-pan-sweep: style recalc count ▂▄▁▄▄▄▅▅▅█▂▂▅▄▂ ➡️ 249
viewport-pan-sweep: task duration ▆▂▆▆▆▅▆▆▆▂█▆▁▆▅ ➡️ 5437ms
viewport-pan-sweep: script duration ▆▃▆▆▅▅▆▆▇▃█▆▁▆▅ ➡️ 2689ms
viewport-pan-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
viewport-pan-sweep: heap used ▄▆▅▄▅██▆▄▃▃▁▇▁▁ ➡️ 70.6 MB
viewport-pan-sweep: DOM nodes ▂█▁▁▁▁▁▁▁▂▁▁▁▁▁ ➡️ -228
viewport-pan-sweep: event listeners ▃█▄▂▃▂▃▃▂▁▃▄▂▃▃ ➡️ -149
vue-large-graph-idle: avg frame time ▁▆▇▃▅▆▇▃▆▇▇▇▃█▇ ➡️ 18ms
vue-large-graph-idle: p95 frame time ▃█▁▃█▃▆▆▆▆▆▆▆██ ➡️ 17ms
vue-large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-idle: style recalc duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-idle: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-idle: task duration ▁▅▇▆▅▇█▄▆▅▇▇▂▇▇ ➡️ 16869ms
vue-large-graph-idle: script duration ▁▄▅▅▄▆█▄▅▃▆▆▂▆▆ ➡️ 272ms
vue-large-graph-idle: TBT ▁▅▁▁▁▁█▁▁▁▁▁▁▁▁ 📉 0ms
vue-large-graph-idle: heap used ▆▅▂▄▄▇▁▇▅▁▂▅▅▃█ ➡️ 182.9 MB
vue-large-graph-idle: DOM nodes ██████▂▁████▂██ ➡️ -8049
vue-large-graph-idle: event listeners ████████████▁██ ➡️ -14923
vue-large-graph-pan: avg frame time ▁▁▃█▁▁██▆▁▆▆▁▆▆ ➡️ 18ms
vue-large-graph-pan: p95 frame time ▁▄▅█▄▁▁██▁▄█▄▄▁ ➡️ 17ms
vue-large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-pan: style recalc duration ▃▄▃▄▂▄█▄▄▃▅▄▁▄▅ ➡️ 18ms
vue-large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-pan: style recalc count ▅▅▆█▅▄█▇▇▅▇█▁█▇ ➡️ 153
vue-large-graph-pan: task duration ▄▄▄▆▄▃█▆▆▃▇▆▁▆▇ ➡️ 20949ms
vue-large-graph-pan: script duration ▆▂▆▆▄▅▇▆█▁▇█▂▇▆ ➡️ 880ms
vue-large-graph-pan: TBT ▁▁▂▄▂▄█▃▄▁▅▅▁▄▃ ➡️ 60ms
vue-large-graph-pan: heap used ▆▄█▃▅▅▃▁▄▆▆▄▅▄▅ ➡️ 175.9 MB
vue-large-graph-pan: DOM nodes █▇████▁████████ ➡️ -8049
vue-large-graph-pan: event listeners ████████████▁██ ➡️ -14923
vue-node-resize-workload: avg frame time ▁▆█▄▆▆▆▆▆▃█▃▁▆▆ ➡️ 18ms
vue-node-resize-workload: p95 frame time ▃▆█▃███▁▆▆▆▆█▃▆ ➡️ 17ms
vue-node-resize-workload: layout duration ▆▆▆▄▆▅█▃▇▁█▇▂▄▇ ➡️ 24ms
vue-node-resize-workload: style recalc duration ▅▂█▇▆▅▅▇█▁▇█▁▇▆ ➡️ 74ms
vue-node-resize-workload: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 20
vue-node-resize-workload: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 20
vue-node-resize-workload: task duration ▂▅▇▅▅▇█▇▇▄█▄▁▇▇ ➡️ 6181ms
vue-node-resize-workload: script duration ▂▃▄▄▃▅█▅▅▂▆▃▁▅▅ ➡️ 113ms
vue-node-resize-workload: TBT ▁▅▇▆▅▇▇▇▇▄▇▄▁▆█ ➡️ 461ms
vue-node-resize-workload: heap used ▁▃▅▃▃▃▆▄▅▆▃▂▅▅█ ➡️ 182.4 MB
vue-node-resize-workload: DOM nodes ▁▁█▁█▁▁▁▁▁▁▁▁▁▁ ➡️ -8049
vue-node-resize-workload: event listeners ▁▁▁▁█▁▁▁▁▁▁▁▁▁▁ ➡️ -14923
vue-zoom-out-idle: avg frame time ▁▅▆▅▆▅███▆██▃██ ➡️ 18ms
vue-zoom-out-idle: p95 frame time ▁████▄▁▁█▁▄▄██▄ ➡️ 17ms
vue-zoom-out-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-zoom-out-idle: style recalc duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-zoom-out-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-zoom-out-idle: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-zoom-out-idle: task duration ▃▅▇▇▄▅█▇▇▄▇▇▁▇▇ ➡️ 8412ms
vue-zoom-out-idle: script duration ▃▃▆▆▅▄█▆▄▂▅▅▁▄▅ ➡️ 134ms
vue-zoom-out-idle: TBT ▁▁█▁▁▁▁▁▁▁▁▁▁▁▁ 📉 0ms
vue-zoom-out-idle: heap used ▃▅▆▃▂▂▇▄█▆▄▁█▂▆ ➡️ 176.6 MB
vue-zoom-out-idle: DOM nodes ████████▁▁█████ ➡️ 0
vue-zoom-out-idle: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
workflow-execution: avg frame time ▅▄█▆▃▆▁▅▁▅▃▆▃▃▃ ➡️ 17ms
workflow-execution: p95 frame time ▃█▆▆▁▃▆▃▆▆▁▆▆▁▃ ➡️ 17ms
workflow-execution: layout duration ▆▄▁▅▃▄▄▅▇▂▆▃█▅▄ 📈 2ms
workflow-execution: style recalc duration ▄▂▁▂▂▂▆██▂▆▃▄▃▅ 📈 16ms
workflow-execution: layout count ▄▃▁▃▃▃▃▅▄▃▅▃█▃▃ 📈 3
workflow-execution: style recalc count ▃▃▂▁▂▂▆█▇▄▃▃▆▂▃ 📈 11
workflow-execution: task duration ▄▂▂▁▂▂▆█▆▂▅▄▄▃▄ 📈 99ms
workflow-execution: script duration ▄▂▂▄▁▂▇█▆▃▇▃▃▄▂ ➡️ 8ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ▃▄▃▁▂▃▅▆█▅▃▃▅▂▄ ➡️ 63.1 MB
workflow-execution: DOM nodes ▆▂▄▅▄▂▅█▇▁▄▅▇▄▃ ➡️ 106
workflow-execution: event listeners ▃▅▃▁▂▄▆█▆▆▄▅▆▃▅ 📈 54
Raw data
{
  "timestamp": "2026-09-25T04:44:02.389Z",
  "gitSha": "9b8902ead4dba296298531948e8ac36f7f5ba23d",
  "branch": "dante01yoon/fe-2892-web-session-client",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2022.4319999999807,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.473,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 465.108,
      "heapDeltaBytes": 9529804,
      "heapUsedBytes": 71741464,
      "domNodes": -228,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 10.065999999999999,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2024.236999999971,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.593,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.91200000000003,
      "heapDeltaBytes": 11413932,
      "heapUsedBytes": 73592780,
      "domNodes": -228,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.668000000000003,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1841.3869999999974,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 17.983,
      "layouts": 12,
      "layoutDurationMs": 5.675000000000001,
      "taskDurationMs": 838.2189999999999,
      "heapDeltaBytes": 3192016,
      "heapUsedBytes": 65011204,
      "domNodes": -228,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 168.852,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1840.3859999999668,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 17.451,
      "layouts": 12,
      "layoutDurationMs": 4.29,
      "taskDurationMs": 827.5010000000001,
      "heapDeltaBytes": 14697224,
      "heapUsedBytes": 76896020,
      "domNodes": -228,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 162.249,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1708.4630000000516,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 10.12,
      "layouts": 6,
      "layoutDurationMs": 1.1390000000000002,
      "taskDurationMs": 328.131,
      "heapDeltaBytes": 2067492,
      "heapUsedBytes": 64467952,
      "domNodes": 53,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 11.69,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1733.2139999999754,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 10.642999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.435,
      "taskDurationMs": 333.18899999999996,
      "heapDeltaBytes": 2147408,
      "heapUsedBytes": 64491136,
      "domNodes": 53,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 12.002000000000002,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 713.0360000000451,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 4.244,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 451.233,
      "heapDeltaBytes": 17986172,
      "heapUsedBytes": 80273004,
      "domNodes": 0,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 168.945,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 697.781999999961,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 3.600000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 439.33599999999996,
      "heapDeltaBytes": 18622836,
      "heapUsedBytes": 80986592,
      "domNodes": 0,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 167.502,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1229.1610000000333,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 892.962,
      "heapDeltaBytes": 8137708,
      "heapUsedBytes": 95732172,
      "domNodes": -259,
      "jsHeapTotalBytes": 24268800,
      "scriptDurationMs": 73.00800000000001,
      "eventListeners": -185,
      "totalBlockingTimeMs": 606,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1237.0509999999513,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 911.2000000000002,
      "heapDeltaBytes": -12770876,
      "heapUsedBytes": 73784064,
      "domNodes": -259,
      "jsHeapTotalBytes": 19005440,
      "scriptDurationMs": 74.211,
      "eventListeners": -207,
      "totalBlockingTimeMs": 561,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 862.4729999999659,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 491.5799999999999,
      "heapDeltaBytes": 14479572,
      "heapUsedBytes": 90041924,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 168.90900000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 232,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 861.5160000000515,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 490.38000000000005,
      "heapDeltaBytes": 14188840,
      "heapUsedBytes": 91349560,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 172.84500000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 240,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 11025.74599999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10047.291,
      "heapDeltaBytes": 2532868,
      "heapUsedBytes": 85096244,
      "domNodes": 0,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 8328.697,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1217,
      "frameDurationMs": 18.889999999999905,
      "p95FrameDurationMs": 49.900000000001455
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9375.081000000024,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8607.725999999999,
      "heapDeltaBytes": 9313140,
      "heapUsedBytes": 91964764,
      "domNodes": 0,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 7285.096,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1107,
      "frameDurationMs": 18.890000000000025,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 11209.846999999969,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10199.281,
      "heapDeltaBytes": -4411584,
      "heapUsedBytes": 72336408,
      "domNodes": 0,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 8526.824,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1631,
      "frameDurationMs": 20,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 11233.813000000055,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10214.723000000002,
      "heapDeltaBytes": 6583448,
      "heapUsedBytes": 83417928,
      "domNodes": -228,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8509.837999999998,
      "eventListeners": -164,
      "totalBlockingTimeMs": 1511,
      "frameDurationMs": 18.883333333333333,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.0380000000246,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.640999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 578.3309999999999,
      "heapDeltaBytes": -6350904,
      "heapUsedBytes": 74825252,
      "domNodes": -228,
      "jsHeapTotalBytes": -757760,
      "scriptDurationMs": 33.35399999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2028.3359999999675,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.5359999999999991,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 550.253,
      "heapDeltaBytes": 2888792,
      "heapUsedBytes": 83951676,
      "domNodes": -228,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 36.168000000000006,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2421.2040000000457,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 9.656,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1639.027,
      "heapDeltaBytes": -931804,
      "heapUsedBytes": 80344292,
      "domNodes": -228,
      "jsHeapTotalBytes": 479232,
      "scriptDurationMs": 843.998,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2585.515999999984,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 10.174,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1710.4149999999997,
      "heapDeltaBytes": 3074568,
      "heapUsedBytes": 84384712,
      "domNodes": -228,
      "jsHeapTotalBytes": 1003520,
      "scriptDurationMs": 888.254,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3741.269999999986,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 11.099999999999998,
      "layouts": 60,
      "layoutDurationMs": 13.715,
      "taskDurationMs": 1738.1609999999998,
      "heapDeltaBytes": 7691084,
      "heapUsedBytes": 73787944,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 804.641,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3700.136000000043,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 10.504999999999997,
      "layouts": 60,
      "layoutDurationMs": 13.773,
      "taskDurationMs": 1739.421,
      "heapDeltaBytes": 12261468,
      "heapUsedBytes": 78523764,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 834.221,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3109.626999999989,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 6.057999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1912.6840000000002,
      "heapDeltaBytes": 25434608,
      "heapUsedBytes": 91619540,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 960.4990000000001,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3131.243999999924,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 5.9430000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1966.234,
      "heapDeltaBytes": 25633308,
      "heapUsedBytes": 92022616,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 991.0930000000001,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2035.3829999999675,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 3.016999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 606.1109999999999,
      "heapDeltaBytes": -14025772,
      "heapUsedBytes": 74622916,
      "domNodes": -228,
      "jsHeapTotalBytes": 4485120,
      "scriptDurationMs": 35.28099999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2030.3819999999178,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.2029999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 662.311,
      "heapDeltaBytes": -13996352,
      "heapUsedBytes": 73147600,
      "domNodes": -228,
      "jsHeapTotalBytes": 2912256,
      "scriptDurationMs": 35.55499999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 602.4909999999863,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 6.034999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 387.78900000000004,
      "heapDeltaBytes": 13698800,
      "heapUsedBytes": 76313460,
      "domNodes": 0,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 144.03199999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 608.0810000000838,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 5.819,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 386.12800000000004,
      "heapDeltaBytes": 13414164,
      "heapUsedBytes": 76840476,
      "domNodes": 0,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 143.959,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2018.2490000000257,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.920999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 446.802,
      "heapDeltaBytes": -5322900,
      "heapUsedBytes": 57276600,
      "domNodes": -244,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 7.726999999999998,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1991.3510000000088,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 4.490000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 449.002,
      "heapDeltaBytes": 7075400,
      "heapUsedBytes": 70742100,
      "domNodes": -244,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.162999999999999,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1691.3370000000327,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 18.584,
      "layouts": 16,
      "layoutDurationMs": 6.101000000000001,
      "taskDurationMs": 786.002,
      "heapDeltaBytes": 7199032,
      "heapUsedBytes": 69791844,
      "domNodes": -244,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 116.47999999999999,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1689.7910000000138,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 18.725,
      "layouts": 16,
      "layoutDurationMs": 6.253000000000001,
      "taskDurationMs": 793.882,
      "heapDeltaBytes": 13809992,
      "heapUsedBytes": 76295340,
      "domNodes": -244,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 117.007,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 933.6799999999812,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 28.810999999999996,
      "layouts": 5,
      "layoutDurationMs": 13.159999999999998,
      "taskDurationMs": 709.0169999999998,
      "heapDeltaBytes": 20206304,
      "heapUsedBytes": 103745952,
      "domNodes": 13667,
      "jsHeapTotalBytes": 11796480,
      "scriptDurationMs": 26.303000000000008,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 141,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8452.604000000008,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 32.766,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5281.41,
      "heapDeltaBytes": -3149816,
      "heapUsedBytes": 76733256,
      "domNodes": -228,
      "jsHeapTotalBytes": 708608,
      "scriptDurationMs": 2837.378,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8728.91100000004,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 33.152,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5894.274,
      "heapDeltaBytes": 81692,
      "heapUsedBytes": 80505532,
      "domNodes": -228,
      "jsHeapTotalBytes": -569344,
      "scriptDurationMs": 2844.08,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16966.386,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16623.162999999997,
      "heapDeltaBytes": -45078432,
      "heapUsedBytes": 168833992,
      "domNodes": -8049,
      "jsHeapTotalBytes": -19988480,
      "scriptDurationMs": 286.374,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17460.739999999987,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17071.987,
      "heapDeltaBytes": -62460092,
      "heapUsedBytes": 177564200,
      "domNodes": -8049,
      "jsHeapTotalBytes": -16408576,
      "scriptDurationMs": 285.75,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20654.33999999999,
      "styleRecalcs": 160,
      "styleRecalcDurationMs": 17.188999999999982,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20421.987999999998,
      "heapDeltaBytes": -33252376,
      "heapUsedBytes": 191725012,
      "domNodes": -8049,
      "jsHeapTotalBytes": -18165760,
      "scriptDurationMs": 909.408,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 76,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20746.181999999975,
      "styleRecalcs": 159,
      "styleRecalcDurationMs": 17.502000000000017,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20535.851000000002,
      "heapDeltaBytes": -68808692,
      "heapUsedBytes": 168982640,
      "domNodes": -8050,
      "jsHeapTotalBytes": -17235968,
      "scriptDurationMs": 947.62,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 56,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6145.709000000011,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.63599999999998,
      "layouts": 20,
      "layoutDurationMs": 22.859999999999992,
      "taskDurationMs": 6073.674999999999,
      "heapDeltaBytes": -54735900,
      "heapUsedBytes": 182693956,
      "domNodes": -8049,
      "jsHeapTotalBytes": 13959168,
      "scriptDurationMs": 106.67899999999999,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 372,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6182.100999999989,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 82.446,
      "layouts": 20,
      "layoutDurationMs": 25.012999999999995,
      "taskDurationMs": 6098.866000000001,
      "heapDeltaBytes": -67527704,
      "heapUsedBytes": 172967636,
      "domNodes": -8049,
      "jsHeapTotalBytes": 8585216,
      "scriptDurationMs": 113.109,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 481,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8737.983999999982,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8467.317,
      "heapDeltaBytes": -16127336,
      "heapUsedBytes": 177947220,
      "domNodes": 0,
      "jsHeapTotalBytes": -26214400,
      "scriptDurationMs": 139.05100000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8508.249999999975,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8310.850999999999,
      "heapDeltaBytes": -3362232,
      "heapUsedBytes": 178245212,
      "domNodes": 0,
      "jsHeapTotalBytes": -14942208,
      "scriptDurationMs": 132.03500000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 116.62999999998647,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 11.522,
      "layouts": 3,
      "layoutDurationMs": 0.9980000000000002,
      "taskDurationMs": 85.05699999999999,
      "heapDeltaBytes": 3217288,
      "heapUsedBytes": 65155068,
      "domNodes": 97,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 9.040000000000001,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 463.55900000003203,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 19.634,
      "layouts": 4,
      "layoutDurationMs": 2.058,
      "taskDurationMs": 120.06500000000003,
      "heapDeltaBytes": 4940248,
      "heapUsedBytes": 67096932,
      "domNodes": 101,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.992999999999999,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52451 79398 66.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.6% 1153
src/LGraphNode.ts 70.5% 382
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.8% 320
src/LGraph.ts 78.6% 271
src/scripts/app.ts 72.1% 259
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 0.9% 232
src/scripts/pnginfo.ts 20.8% 221

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 6dc94947-8940-44a9-96b3-a45935065f41

📥 Commits

Reviewing files that changed from the base of the PR and between 5dfb638 and 5a09df1.

📒 Files selected for processing (5)
  • packages/account-core/src/core/importGuard.test.ts
  • packages/account-core/src/core/webSession.ts
  • packages/ingest-types/src/index.ts
  • packages/ingest-types/src/types.gen.ts
  • packages/ingest-types/src/zod.gen.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The change adds web-session API contracts, client operations, package exports, and test support. It also updates generated API schemas and the description of a payment configuration field.

Changes

Web Session Client

Layer / File(s) Summary
Web-session contracts and API types
packages/account-core/src/core/sessionContracts.ts, packages/ingest-types/src/*
Adds web-session user, session, and result contracts. Generated API types and schemas describe session responses and GET /api/auth/session. The type barrel exports the new types.
Web-session client and package entry
packages/account-core/src/core/webSession.ts, packages/account-core/package.json, packages/account-core/scripts/smokePack.ts
Adds read, create, delete, and revoke-all operations. Exposes the client through the package export and includes it in typed-consumer coverage.
Session test support and validation
packages/account-core/src/testing.ts, packages/account-core/src/core/webSession.test.ts, packages/account-core/src/core/importGuard.test.ts, packages/account-core/src/webSessionInertImport.test.ts
Adds a fake session endpoint and tests for client behavior, error mapping, import side effects, and Firebase-free imports.

Payment Configuration Description

Layer / File(s) Summary
Payment configuration field description
packages/ingest-types/src/types.gen.ts
Updates the generated description to state that payment_method_configuration_id is present when configured for the environment.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant Application
  participant WebSessionClient
  participant IdentityProofProvider
  participant SessionAPI
  Application->>WebSessionClient: Call createWebSession
  WebSessionClient->>IdentityProofProvider: Obtain identity proof
  IdentityProofProvider-->>WebSessionClient: Return identity proof
  WebSessionClient->>SessionAPI: POST /auth/session with bearer proof
  SessionAPI-->>WebSessionClient: Return creation response
  WebSessionClient->>SessionAPI: GET /auth/session with credentials and no-store
  SessionAPI-->>WebSessionClient: Return session response
  WebSessionClient-->>Application: Return WebSessionResult
Loading

Merge Risk: ⚪ Minimal · up to 5a09d

Cancellation follows the documented session-client contract. No actionable issue remains before normal merge checks.

Security Architecture Review

Security architecture risk: 🟡 Moderate · up to 5a09d

The new client is not shown changing current sign-in behavior, but its public interface leaves important endpoint-trust and session-identity guarantees to future adopters. Those guarantees should be settled before hosts rely on it.

Retained concerns

  • Medium · security · inferred: The public client delegates endpoint and fetch authority to each host without constraining transport or destination before sending an identity proof. A host-supplied untrusted or plaintext endpoint could expose that proof; no such production configuration is established in this PR.
  • Medium · security · inferred: Session creation reports the result of a separate GET without binding its user to the submitted proof. Failure or concurrency can leave the server session changed while the caller receives an error or a session for a different identity; backend guarantees that would rule this out are not available.
Security review details

Security Blast Radius

  • inferred — The immediate exposure is a newly published library interface, not a demonstrated production invocation. An adopting host could direct the proof to its configured endpoint; the evidence does not establish attacker control of a production URL or fetch implementation.

Security Findings and Attack Paths

  • inferred — No vulnerability is verified. The conditional transport path requires an untrusted or plaintext endpoint supplied by an adopter; the conditional identity path requires a failed or competing transition between creation and the subsequent read. Neither production condition is established here.

Trust Boundaries and Controls

  • observed — The caller controls the identity proof, endpoint, fetch implementation, and revoke-all CSRF token. The client validates response shapes, distinguishes recognized 401 and 403 codes, and can compare a read’s user ID with a caller-provided expected ID.

Resilience and Maintainability Implications

  • inferred — Classifying an outage separately from a missing session protects callers from treating common failures as sign-out. It does not establish whether a timed-out creation was committed, whether retry is idempotent, or whether a successful revoke-all status means all sessions were revoked.

Hardening Proposals

  • proposed — Before host adoption, define an enforced trusted-HTTPS endpoint policy and establish the backend’s identity binding, mutation ordering, retry/idempotency, CSRF, and revoke-all completion contracts. Bind the post-create read to an expected identity where that identity is available.
🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed No bug-fix signal appears in the PR title or commit subjects. The title uses feat, and the commit subjects use feat, test, chore, refactor, or merge wording. Therefore the required bug-fix c…
Website End-To-End Regression Coverage ✅ Passed No files under apps/website/src/ or apps/website/public/ changed. The pull request changes only packages/ files, so this website-specific check is out of scope.
Adr Compliance For Entity/Litegraph Changes ✅ Passed The available changed-file list contains only files under packages/account-core/ and packages/ingest-types/. It contains no files under src/lib/litegraph/, src/ecs/, or graph-entity-related pa…
Title check ✅ Passed The title clearly identifies the main change: adding the account-core web session client and session error codes.
Description check ✅ Passed The description is comprehensive and covers the change scope, behavior, dependencies, review focus, testing evidence, rollout state, and related links. It does not use the template headings exactly, b…
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.37209% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/account-core/src/testing.ts 83.78% 1 Missing and 5 partials ⚠️
packages/account-core/src/core/webSession.ts 91.48% 2 Missing and 2 partials ⚠️
@@            Coverage Diff            @@
##             main   #18710     +/-   ##
=========================================
  Coverage   83.91%   83.91%             
=========================================
  Files        3054     3055      +1     
  Lines      151109   151195     +86     
  Branches    41025    39148   -1877     
=========================================
+ Hits       126797   126873     +76     
- Misses      22900    22903      +3     
- Partials     1412     1419      +7     
Flag Coverage Δ
billing-web-unit 88.08% <ø> (ø)
e2e 66.06% <100.00%> (+<0.01%) ⬆️
unit 80.99% <88.09%> (+<0.01%) ⬆️
website-unit 76.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/account-core/src/core/sessionContracts.ts 66.66% <ø> (ø)
packages/ingest-types/src/zod.gen.ts 100.00% <100.00%> (ø)
packages/account-core/src/core/webSession.ts 91.48% <91.48%> (ø)
packages/account-core/src/testing.ts 84.21% <83.78%> (-15.79%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 24, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 24, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 24, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 24, 2026
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 24, 2026
…g#18707)

## Why

The "One Comfy session across comfy.org" TDD moves every first-party web
app onto one revocable session cookie on the Cloud host. The decisions
behind it, and above all why the cookie is host-only `__Host-` instead
of the domain-wide cookie first recorded in the Account Layer TDD,
cannot be read off the code. This ADR records them before the SDK and
app slices land, so reviewers of those slices have one place to check
against.

## How

- New
`docs/adr/AUTH-SESSION-0037-shared-web-session-on-a-host-only-cookie.md`:
the eight decisions (host-only `__Host-comfy_session`, opaque DB-backed
reference, provider-neutral session, workspace per request, stored CSRF
token + trusted Origin, new session per real sign-in, tokens stay for
non-web clients, one client flag with the server owning the AND), the
rejected alternatives with the reason each lost (domain-wide cookie:
vendor-operated hosts under comfy.org, sibling-host overwrite,
twin-cookie switch, rollback cleanup; signed cookie; workspace in
cookie; double-submit CSRF; cookie-only-for-sign-in; cookie on other
services; redirect hub; timer rotation), and the consequences.
- Index row in `docs/adr/README.md`. `pnpm adr:check` passes.
- Not in this PR: the README auth sections for `apps/website`,
`apps/billing-web` and `packages/account-core`. The ticket finalizes
them as the SDK and app slices land; writing them now would describe
code that does not exist yet.

## AS IS / TO BE

Docs only, no UI.

- AS IS: no ADR for the web session; the domain-wide cookie decision
exists only in the Account Layer TDD, amended in security review on
2026-09-24.
- TO BE: `AUTH-SESSION-0037` (Proposed) records the host-only decision
and the alternatives it rejected; `pnpm adr:check` → `ADR naming and
index validation passed`.

## docs.comfy.org suggestion

Once the flag ramps (FE-2907): a short "Signing in across Comfy sites"
note. Signing in on comfy.org, cloud.comfy.org or billing.comfy.org
signs you in on the others; signing out of one signs you out of all;
"sign out of all devices" ends every session. CLI, API keys and Desktop
are unchanged.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
(sections 4, 10, A10)
- Action items and dependency graph:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2893

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | `unified_web_session` client flag, off by default | BE-17135
to turn on; C11 for website/billing-web readers | Comfy-Org#18708 |
| FE-2892 | account-core web session client + error codes | C1, C3
(BE-17063 generated types) | Comfy-Org#18710, do not merge |
| **FE-2893 (this PR)** | ADR for the shared web session | none | Comfy-Org#18707
|
| FE-2901 | non-web clients stay on tokens (baseline) | FE-2895 for
`authorize()` rows | Comfy-Org#18711 |
| FE-2894 | session-backed identity + boot rules (stacked on Comfy-Org#18710) |
FE-2892, C3 | Comfy-Org#18715, do not merge |
| FE-2895 | `authorize()` for cookie requests (stacked on Comfy-Org#18710) |
FE-2892, C5 | Comfy-Org#18716, do not merge |
| FE-2897 | session lifecycle, heartbeat (stacked on Comfy-Org#18715) | FE-2894,
C1, C3 | Comfy-Org#18719, do not merge |
| FE-2906 | cross-origin E2E harness + §17 test ids | C3/C5/C6/C7 on
staging for the rows | Comfy-Org#18718 (harness only) |
| FE-2896, 2898–2900, 2902–2905, 2907, 2908 | apps, token mint, rollout,
cleanup | C5/C6/C7/C8/C11 contracts | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2893 thisPr
```

- Blocked by: nothing.
- Unblocks: nothing in code; it is the reference the SDK and app slices
(FE-2892 onward) are reviewed against.
zeus-onl pushed a commit to zeus-onl/ComfyUI_frontend that referenced this pull request Sep 25, 2026
…omfy-Org#18708)

## Why

The unified web session (TDD "One Comfy session across comfy.org") ships
dark behind one client flag, `unified_web_session`, so every later slice
(FE-2894 onward) can merge with the flag off and rollback is a flag
flip. This PR adds the flag reader and a request-level proof that
nothing changes while it is off.

## How

- `unified_web_session?: boolean` on `RemoteConfig`,
`ServerFeatureFlag.UNIFIED_WEB_SESSION`, and
`flags.unifiedWebSessionEnabled`, false outside cloud, then session
override (`?ff=`) > dev override (`ff:unified_web_session`) >
`/api/features` > `false`. Unlike `resolveFlag` there is no
`api.getServerFeature` fallback, so `/api/features` (where the backend
serves the AND) is the only server source, and only a literal `true`
counts, so a malformed value such as `"false"` stays off.
- It reads no other flag. The backend serves `unified_web_session` true
only when its own `web_session_enabled` is on for the caller (BE-17135,
cloud#10552); the frontend never combines them.
- Nothing reads the getter yet, so the app is unchanged. It is not added
to `startFeatureFlagTelemetry` either, because that would emit a new
evaluation event while the flag is off; FE-2907 can add it when the ramp
needs the metric.
- Scope note: the ticket also lists `apps/website` and
`apps/billing-web`. Those sites read the flag before they know the user,
which is open question 17 / C11 (not started). Their readers land with
C11 instead of guessing its shape here.

### The flag-off proof (`src/platform/auth/webSessionFlagOff.test.ts`)

Drives the real cloud auth code: real Pinia stores, the real
`Comfy.Cloud.SessionCookie` extension hooked through
`useCurrentUser().onUserResolved` / `onTokenRefreshed`, real
`useSessionCookie`, real `workspaceAuthStore` unified mint and refresh
scheduler, real `api.fetchApi`, and flags loaded through the real
`refreshRemoteConfig` from a stubbed `GET /api/features`. Only the
Firebase identity, telemetry, `reportError` and `distribution/types` are
faked. `fetch` is a recorder.

2x2, `it.for`: `unified_cloud_auth` ∈ {off, on} × `unified_web_session`
∈ {absent from `/api/features`, `false`}. Each row must produce exactly
the pinned request list (method, path, full lowercased header set,
`credentials`; WebSocket opens are recorded by URL) for each phase and
in total:

| Flow | `unified_cloud_auth` off | `unified_cloud_auth` on |
| --- | --- | --- |
| sign-in (`authStore.login()`) | `POST /api/auth/session` (Bearer
Firebase, `credentials: include`), then `POST {comfy-api}/customers`
(Bearer Firebase) | `POST /api/auth/token`, then `POST
/api/auth/session`, then `POST {comfy-api}/customers` |
| token refresh | `POST /api/auth/session` | `POST /api/auth/token`,
then `POST /api/auth/session` |
| API call | `GET /api/queue`, `POST /api/prompt` with Bearer Firebase +
`Comfy-User`, no credentials | same, with Bearer Cloud JWT |
| sign-out | `DELETE /api/auth/session` (`credentials: include`, no
headers), then the socket reconnects at `/ws` with no token | same |
| socket reconnect | `WebSocket /ws?token=<Firebase token>` | `WebSocket
/ws?token=<Cloud JWT>` |
| media URLs | `/api/view?filename=…&type=…&subfolder=` and the preview
with `&res=512`, no `workspace_id` | same |

Every row also asserts: no `X-Comfy-Workspace-ID`, `X-CSRF-Token` or
`X-Comfy-Client` on any request; `credentials: 'include'` only on the
session POST/DELETE; no `GET /api/auth/session`.

The file does not reference the new flag by type, so the identical file
ships in FE-2892 and FE-2901 and passes on plain `main` (verified).
Identical content merges cleanly in any order.

Mutation check: adding `X-Comfy-Client` to `fetchApi` headers → 4/4 rows
red; adding `credentials: 'include'` to `fetchApi` → 4/4 rows red;
adding `workspace_id` to the socket URL → 4/4 red; adding `X-CSRF-Token`
to the sign-out DELETE → 4/4 red; adding `workspace_id` to media URLs →
4/4 red; adding `credentials: 'include'` to customer provisioning → 4/4
red.

Combined check: `origin/main` + all four unified-web-session PRs
(Comfy-Org#18707, Comfy-Org#18708, Comfy-Org#18710, Comfy-Org#18711) merge without conflict. On that tree
the harness passes, `pnpm typecheck` and `pnpm knip` exit 0, and `pnpm
test:unit` gives 23807 passed with 17 failures, all in
`scripts/cicd/check-binary-size` and `reconcile-latest-release`. Those
fail the same way on plain `main` locally (exit 127, a missing local
tool), so they are unrelated. The only non-test runtime diff across the
four PRs is the flag getter and enum in `useFeatureFlags.ts` and one
`RemoteConfig` key; nothing in `src/` or `apps/` reads the getter or
imports `@comfyorg/account-core/webSession`.


## AS IS / TO BE

No UI; the evidence is tests.

- AS IS: no `unified_web_session` flag; cloud auth sends the requests
pinned above.
- TO BE: the flag exists, defaults off, and with it off (absent or
`false`) the cloud app sends exactly the same requests, for
`unified_cloud_auth` on and off.

```
pnpm exec vitest run src/composables/useFeatureFlags.test.ts src/platform/auth/webSessionFlagOff.test.ts
 Test Files  2 passed (2)
      Tests  95 passed (95)
```

Flag reader cases (`useFeatureFlags.test.ts`): off when `/api/features`
lacks it (even if the server-feature channel says `true`), failed to
load, or an override is malformed (`"true"`, `"false"`, `1`); on when
the server sends true on cloud; `ff:` and `?ff=` overrides honoured; off
outside cloud; independent of `unified_cloud_auth` in both directions.

Checks: `pnpm typecheck` exit 0, `pnpm knip` exit 0, eslint/oxlint/oxfmt
clean on changed files, `vitest run src/platform/auth src/composables
src/platform/remoteConfig src/stores/authStore` 2205 passed.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
(sections 15, 18)
- Action items and dependency graph:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2891
- Backend flag: Comfy-Org/cloud#10552 (BE-17135)

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| **FE-2891 (this PR)** | `unified_web_session` client flag, off by
default | BE-17135 to turn on; C11 for website/billing-web readers |
Comfy-Org#18708 |
| FE-2892 | account-core web session client + error codes | C1, C3
(BE-17063 generated types) | Comfy-Org#18710, do not merge |
| FE-2893 | ADR for the shared web session | none | Comfy-Org#18707 |
| FE-2901 | non-web clients stay on tokens (baseline) | FE-2895 for
`authorize()` rows | Comfy-Org#18711 |
| FE-2894 | session-backed identity + boot rules (stacked on Comfy-Org#18710) |
FE-2892, C3 | Comfy-Org#18715, do not merge |
| FE-2895 | `authorize()` for cookie requests (stacked on Comfy-Org#18710) |
FE-2892, C5 | Comfy-Org#18716, do not merge |
| FE-2897 | session lifecycle, heartbeat (stacked on Comfy-Org#18715) | FE-2894,
C1, C3 | Comfy-Org#18719, do not merge |
| FE-2906 | cross-origin E2E harness + §17 test ids | C3/C5/C6/C7 on
staging for the rows | Comfy-Org#18718 (harness only) |
| FE-2896, 2898–2900, 2902–2905, 2907, 2908 | apps, token mint, rollout,
cleanup | C5/C6/C7/C8/C11 contracts | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2891 thisPr
```

- Blocked by: BE-17135 to turn it on anywhere (the reader lands first
and stays off); C11 for the website and billing-web readers.
- Unblocks: FE-2894 (session-backed identity and boot rules), FE-2907
(ramp and rollback).
comfy-pr-bot added a commit that referenced this pull request Sep 25, 2026
…nd session error codes (#18846)

Backport of #18710 to `core/1.55`

Automatically created by backport workflow.

---------

Co-authored-by: Dante <bunggl@naver.com>
Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
comfy-pr-bot added a commit that referenced this pull request Sep 25, 2026
…and session error codes (#18847)

Backport of #18710 to `cloud/1.55`

Automatically created by backport workflow.

---------

Co-authored-by: Dante <bunggl@naver.com>
Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 25, 2026
…ules (Comfy-Org#18715)

> **Do not merge** until BE-17063 (`GET /api/auth/session`, cloud#10549,
merged) is deployed on testcloud (the web session backend is not on
staging yet). Comfy-Org#18710 (FE-2892) is merged; this PR now targets `main` and
the diff shows only this ticket.

## Why

A site that joins the shared web session has to decide at boot who is
signed in: the session on ingest, a login this browser remembers, or
nobody. TDD §12's boot table defines that, and §8 defines the silent
restore that lets every existing user migrate without signing in again.
This PR is that decision, as a pure state machine in
`@comfyorg/account-core`, inert until a host calls `boot()`.

## How

New entry `@comfyorg/account-core/webSessionIdentity`
(`packages/account-core/src/core/webSessionIdentity.ts`):

- `createWebSessionIdentity({ session, principal, origin, onBootstrap?,
schedule?, retryBaseMs?, retryMaxMs? })` → `{ getState, subscribe, boot,
dispose }`. Constructing it sends nothing and starts nothing.
- `principal`: `{ kind: 'account', rememberedLogin }` or `{ kind:
'api_key' }`. An API-key principal never enters the machine and never
touches `/api/auth/session`.
- `RememberedLogin` is an opaque port (`currentUserId`, `getProof`
returning `string | null`, `signOutLocally`), so the core imports no
provider. `importGuard` now walks the import chain from
`webSessionIdentity.ts`.
- One discriminated state (`idle | api_key | reading | retry_wait |
restoring | signed_in | signed_out`), one pure
`transitionWebSessionIdentity(state, event)` returning `{ state, effects
}`; the shell only runs effects (`read`, `restore`, `schedule_retry`,
`sign_out_locally`, `report`). `session_bootstrap` (outcome, origin)
goes out through `onBootstrap`.

| `GET /session` | Result |
| --- | --- |
| 200 | `signed_in`; if the remembered login is a different user, sign
it out locally |
| 401 `session_revoked` | `signed_out(revoked)`, local sign-out, never a
silent restore |
| 401 `no_session` / `session_expired`, login remembered | silent
restore (`createWebSession` with the remembered proof); success →
`signed_in(restored)`; a completed failure →
`signed_out(restore_failed)` |
| 401 `no_session` / `session_expired`, nothing remembered |
`signed_out` |
| `SESSION_UNAVAILABLE` (network, 429, 5xx) | `retry_wait`, backoff 1s
doubling to 60s, never signs out |

- A restore that fails transiently (network, 5xx, or `getProof`
throwing) is not spent: after backoff it re-reads first, so a POST that
landed but lost its answer yields 200 and no second POST. `getProof`
returning `null` is permanent (`restore_failed`, no local sign-out). A
restore that gets a real answer completes at most once per boot.
- The SDK keeps no record of past sessions; the server's answer decides.
- Not wired into any app yet (FE-2896 website, FE-2903 cloud). The
shared flag-off harness from Comfy-Org#18708/Comfy-Org#18710 is inherited from the base
and stays green.

## AS IS / TO BE

No UI; the evidence is tests with injected time and the package fakes,
no sleeps.

- AS IS: no boot logic for the web session.
- TO BE: one test per boot-table row (row 1 split by remembered user
same/different/none; row 3 for both 401 codes), backoff 1000 → 2000 then
sign-in with zero sign-outs, restore lost twice then restored (`GET POST
GET POST GET POST GET`), a landed-but-unanswered POST (`GET POST GET`,
no second POST), `getProof` null / throwing, a pure table of restore
answers, API key → zero requests.

```
pnpm --filter @comfyorg/account-core test   Test Files 62 passed, Tests 1070 passed
pnpm --filter @comfyorg/account-core typecheck / lint   exit 0
pnpm typecheck   exit 0
pnpm knip        exit 0
pnpm fallow audit --base <FE-2892 branch>   No issues in 6 changed files
```

Mutation checks (each reverted): `session_revoked` restores → red;
network error on read signs out → red; transient restore failure signs
out → red; completed restore failure retries → red; thrown proof signs
out → red.

Size: `webSessionIdentity.ts` is 336 lines, mostly the state, event and
effect types; the transition itself is small.

For review: `RememberedLogin.currentUserId()` must return the Comfy user
id, since it is compared with the session's `user.id`. The host adapters
(FE-2896/FE-2903) need to confirm that equals the Firebase uid.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
(sections 8, 12, A8)
- Action items and dependency graph:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2894

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | `unified_web_session` client flag, off by default | BE-17135
to turn on; C11 for website/billing-web readers | Comfy-Org#18708 |
| FE-2892 | account-core web session client + error codes | C1, C3
(BE-17063 generated types) | Comfy-Org#18710, do not merge |
| FE-2893 | ADR for the shared web session | none | Comfy-Org#18707 |
| FE-2901 | non-web clients stay on tokens (baseline) | FE-2895 for
`authorize()` rows | Comfy-Org#18711 |
| **FE-2894 (this PR)** | session-backed identity + boot rules (stacked
on Comfy-Org#18710) | FE-2892, C3 | Comfy-Org#18715, do not merge |
| FE-2895 | `authorize()` for cookie requests (stacked on Comfy-Org#18710) |
FE-2892, C5 | Comfy-Org#18716, do not merge |
| FE-2897 | session lifecycle, heartbeat (stacked on Comfy-Org#18715) | FE-2894,
C1, C3 | Comfy-Org#18719, do not merge |
| FE-2906 | cross-origin E2E harness + §17 test ids | C3/C5/C6/C7 on
staging for the rows | Comfy-Org#18718 (harness only) |
| FE-2896, 2898–2900, 2902–2905, 2907, 2908 | apps, token mint, rollout,
cleanup | C5/C6/C7/C8/C11 contracts | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2894 thisPr
```

- Blocked by: Comfy-Org#18710 (FE-2892) and BE-17063 (C3). FE-2891 gates it at
the host, not here.
- Unblocks: FE-2896 (website header), FE-2897 (lifecycle, heartbeat),
FE-2898 (billing-web).

---------

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 26, 2026
…ts (Comfy-Org#18716)

> **Do not merge** until BE-17066 (C5: cookie on API routes, CSRF/Origin
checks, workspace header, and the CORS allow-list for `X-Comfy-Client`,
`X-Comfy-Workspace-ID`, `X-CSRF-Token`) is on testcloud (the web session
backend is not on staging yet). Comfy-Org#18710 (FE-2892) is merged; this PR now
targets `main`.

## Why

Once a site holds the shared web session, every request to ingest needs
the right credential shape: the cookie with a workspace header and, on
writes, the CSRF token; everything else keeps today's single header. TDD
§9 and A8 put that decision in one function so no app assembles headers
by hand, and require the one automatic retry (`csrf_invalid`) to be tied
to the user the request started for.

## How

- New entry `@comfyorg/account-core/requestAuth`:
`createRequestAuthorizer({ getWorkspaceToken })` returns
`authorize(principal, { target, method, workspaceId? })` → `{ headers,
credentials? }`. It only decides headers; it does not send, retry or
track scope. The principal is a per-call argument so a caller that
re-read the session after `csrf_invalid` authorizes again with the new
token, and `authorize` stays stateless.

| Principal | Target | Headers | credentials |
| --- | --- | --- | --- |
| session | ingest, GET/HEAD/OPTIONS | `X-Comfy-Client`,
`X-Comfy-Workspace-ID` (absent = personal) | `include` |
| session | ingest, unsafe methods | the above + `X-CSRF-Token` |
`include` |
| session | resource | `Authorization: Bearer <workspace token>` from
the injected source (minting is FE-2900) | none |
| firebase | either | `Authorization: Bearer <id token>` (today's) |
none |
| API key | either | `X-API-KEY` (today's) | none |

- `X-Comfy-Client` is `@comfyorg/account-core/<version>`, read from the
package's own `package.json` so version bumps cannot leave it stale. It
is sent only on cookie requests to ingest; bearer calls to other
services keep today's headers, since a new custom header there could
fail their CORS preflight.
- `createCredentialedBillingTransport` gains an opt-in `webSession: {
authorize, getSession, readSession }`. With it, headers come from
`authorize`, and `403 csrf_invalid` is retried exactly once after
`readSession({ expectedUserId })`, in the workspace captured at the
start. If the session now belongs to another user, the request is
abandoned with `SUPERSEDED`, the existing "identity or workspace changed
in flight" code that account-ui already drops silently (a new
`IDENTITY_CHANGED` billing code would surface as a visible error in
every consumer). `origin_not_allowed`, `cross_site_request` and
`workspace_access_denied` are never retried and never re-read;
`workspace_access_denied` is never replayed in another workspace.
- Without `webSession`, the credentialed transport sends exactly what it
sends today; `transport.ts`, `transport.test.ts` and
`createSessionBillingTransport` are untouched (empty diff). No app
constructs the credentialed transport yet.

## AS IS / TO BE

No UI; the evidence is tests.

- AS IS: no `authorize()`; the credentialed transport has no cookie/CSRF
path.
- TO BE: `requestAuth.test.ts` is an `it.for` matrix of target ×
principal × method (including lowercase methods).
`credentialedTransport.webSession.test.ts` covers one csrf retry for the
same user, a second `csrf_invalid` returned without retrying again,
`SUPERSEDED` on a user change, no retry for origin/cross-site/workspace
denials, and nothing sent without a session. The existing transport
tests pass unedited.

```
pnpm --filter @comfyorg/account-core test   Test Files 63 passed, Tests 1092 passed
pnpm --filter @comfyorg/account-core typecheck / lint   exit 0
pnpm typecheck   exit 0
pnpm knip        exit 0
pnpm fallow audit --base <FE-2892 branch>   No issues in 8 changed files
pnpm --filter @comfyorg/account-core smoke:pack   passed
```

Mutation checks (each reverted): CSRF header on GET → 3 red;
`csrf_invalid` retried twice → red; retry after a user change → red;
`origin_not_allowed` retried → red; `credentials: include` for an API
key → 6 red.

For review: the billing transport always sends `X-Comfy-Workspace-ID`,
including the personal workspace's id, because
`BillingScope.workspaceId` is always set. That relies on C5 accepting
the personal workspace id in the header.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
(sections 9, 12, A8)
- Action items and dependency graph:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2895

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | `unified_web_session` client flag, off by default | BE-17135
to turn on; C11 for website/billing-web readers | Comfy-Org#18708 |
| FE-2892 | account-core web session client + error codes | C1, C3
(BE-17063 generated types) | Comfy-Org#18710, do not merge |
| FE-2893 | ADR for the shared web session | none | Comfy-Org#18707 |
| FE-2901 | non-web clients stay on tokens (baseline) | FE-2895 for
`authorize()` rows | Comfy-Org#18711 |
| FE-2894 | session-backed identity + boot rules (stacked on Comfy-Org#18710) |
FE-2892, C3 | Comfy-Org#18715, do not merge |
| **FE-2895 (this PR)** | `authorize()` for cookie requests (stacked on
Comfy-Org#18710) | FE-2892, C5 | Comfy-Org#18716, do not merge |
| FE-2897 | session lifecycle, heartbeat (stacked on Comfy-Org#18715) | FE-2894,
C1, C3 | Comfy-Org#18719, do not merge |
| FE-2906 | cross-origin E2E harness + §17 test ids | C3/C5/C6/C7 on
staging for the rows | Comfy-Org#18718 (harness only) |
| FE-2896, 2898–2900, 2902–2905, 2907, 2908 | apps, token mint, rollout,
cleanup | C5/C6/C7/C8/C11 contracts | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2895 thisPr
```

- Blocked by: Comfy-Org#18710 (FE-2892) and BE-17066 (C5).
- Unblocks: FE-2899 (website credits), FE-2904 (cloud API client),
FE-2900 (lazy token mint), FE-2902 (platform), FE-2898 (billing-web),
and the `authorize()` rows of FE-2901.

---------

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 26, 2026
## Why

The web session changes how browsers on our sites authenticate; it must
not change anything for the clients the TDD leaves on tokens (§2, §12):
API keys, a localhost frontend, Desktop's login approval, CLI and MCP.
This PR pins today's behavior for those paths before any session slice
lands, so every later slice (FE-2894 onward) has to keep them green. It
is the "baseline tests can land before the session slices" part of the
ticket.

## How

`src/platform/auth/nonWebClientsStayOnTokens.test.ts` runs the real
stores, `api.fetchApi`, the real `Comfy.Cloud.SessionCookie` extension
hooks and the real `installDesktopLoginRedemption`, with flags loaded
through the real `refreshRemoteConfig` from a stubbed `/api/features`.
Only the Firebase identity, dialogs, telemetry and `reportError` are
faked; `fetch` is a recorder. Each case is `it.for` over
`unified_cloud_auth` {off, on} × `unified_web_session` {absent, `false`}
and pins the exact request list (method, path, full header set,
credentials):

| Client | Pinned requests | `unified_cloud_auth` dependence |
| --- | --- | --- |
| API-key identity on cloud | `GET /api/features`; `POST
{comfy-api}/customers` with `X-API-KEY`; `GET /api/queue`, `POST
/api/prompt` | off: API calls carry `X-API-KEY`; on: no auth header
(today's behavior, see note) |
| Localhost frontend (`isCloud` false), Firebase user signs in,
refreshes, calls the API | `GET /api/features`; `GET /api/queue`, `POST
/api/prompt` with only `Comfy-User` | none; no `/api/auth/session` even
with the session-cookie hooks fired |
| Desktop login approval | `POST /api/auth/desktop-login-codes/redeem`
with Bearer Firebase, no credentials | none |

Every row also asserts no request to `/api/auth/session*`, no
`credentials: 'include'`, and none of `X-Comfy-Workspace-ID`,
`X-CSRF-Token`, `X-Comfy-Client`.

Plus the shared flag-off harness
`src/platform/auth/webSessionFlagOff.test.ts`, byte-identical to the
copy in Comfy-Org#18708 (FE-2891) and Comfy-Org#18710 (FE-2892) so they merge cleanly in
any order: sign-in (incl. customer provisioning), token refresh, API
calls, socket reconnect, media URLs and sign-out pinned for the 2x2.

Note for review: with `unified_cloud_auth` on, an API-key identity on
cloud sends no auth header on ingest calls, because
`authStore.getAuthHeader()` returns only the unified token under that
flag. That is main's behavior today and is pinned as-is; it is not
changed here. Worth a look by whoever owns `unified_cloud_auth`, since
TDD §12 expects API keys to keep "today's headers".

Not covered here, and why:
- `authorize()` returning today's headers for an API-key principal:
`authorize()` lands in FE-2895; its rows join this file then.
- CLI and MCP: they live outside this repo and never load the web app.
- Desktop cookie persistence across relaunch and the open question 8
answer: needs a Desktop build against testcloud with the flag on;
recorded on the ticket when that runs.


Combined check: `origin/main` + all four unified-web-session PRs
(Comfy-Org#18707, Comfy-Org#18708, Comfy-Org#18710, Comfy-Org#18711) merge without conflict. On that tree
the harness passes, `pnpm typecheck` and `pnpm knip` exit 0, and `pnpm
test:unit` gives 23807 passed with 17 failures, all in
`scripts/cicd/check-binary-size` and `reconcile-latest-release`. Those
fail the same way on plain `main` locally (exit 127, a missing local
tool), so they are unrelated. The only non-test runtime diff across the
four PRs is the flag getter and enum in `useFeatureFlags.ts` and one
`RemoteConfig` key; nothing in `src/` or `apps/` reads the getter or
imports `@comfyorg/account-core/webSession`.

## AS IS / TO BE

No UI; the evidence is tests.

- AS IS: no test pins what API-key, localhost and Desktop-approval paths
send, across the two auth flags.
- TO BE: 12 + 4 pinned rows, all green on main's code.

```
pnpm exec vitest run src/platform/auth src/platform/cloud/onboarding   Test Files 25 passed, Tests 289 passed
pnpm typecheck   exit 0
pnpm knip        exit 0
eslint / oxlint / oxfmt on the two files: clean
```

Mutation checks (each reverted): dropping the `isCloud` guard in
`useSessionCookie.createSession` → the 4 localhost rows red; adding
`credentials: 'include'` to the Desktop redeem → 4 rows red; adding
`X-Comfy-Client` to the API-key header → 4 rows red.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
(sections 2, 12, 14 question 8)
- Action items and dependency graph:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2901

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | `unified_web_session` client flag, off by default | BE-17135
to turn on; C11 for website/billing-web readers | Comfy-Org#18708 |
| FE-2892 | account-core web session client + error codes | C1, C3
(BE-17063 generated types) | Comfy-Org#18710, do not merge |
| FE-2893 | ADR for the shared web session | none | Comfy-Org#18707 |
| **FE-2901 (this PR)** | non-web clients stay on tokens (baseline) |
FE-2895 for `authorize()` rows | Comfy-Org#18711 |
| FE-2894 | session-backed identity + boot rules (stacked on Comfy-Org#18710) |
FE-2892, C3 | Comfy-Org#18715, do not merge |
| FE-2895 | `authorize()` for cookie requests (stacked on Comfy-Org#18710) |
FE-2892, C5 | Comfy-Org#18716, do not merge |
| FE-2897 | session lifecycle, heartbeat (stacked on Comfy-Org#18715) | FE-2894,
C1, C3 | Comfy-Org#18719, do not merge |
| FE-2906 | cross-origin E2E harness + §17 test ids | C3/C5/C6/C7 on
staging for the rows | Comfy-Org#18718 (harness only) |
| FE-2896, 2898–2900, 2902–2905, 2907, 2908 | apps, token mint, rollout,
cleanup | C5/C6/C7/C8/C11 contracts | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2901 thisPr
```

- Blocked by: nothing for this baseline. The `authorize()` rows wait on
FE-2895; the Desktop relaunch check waits on a staging build with the
flag on.
- Unblocks: every session slice (FE-2894 onward) is reviewed against
these rows; FE-2906 E2E reuses the matrix.
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 26, 2026
…ssion (Comfy-Org#18870)

> **Stacked on Comfy-Org#18716 (FE-2895). Do not merge** until Comfy-Org#18716 merges and
C8 (BE-17069, cloud#10585 + Comfy-Org#10697: `POST /api/auth/token` accepts the
cookie) is on testcloud.

## Why

comfy-api and the other services cannot read the session cookie. A site
that arrived by session has no Firebase login to hand them. TDD §7/§12
has the site mint a short-lived workspace token from the session, lazily
and only when a non-ingest call needs one. This is the token source
`authorize()` (Comfy-Org#18716) takes for its `resource` target.

## How

New entry `@comfyorg/account-core/sessionTokenMint`:
`createSessionTokenMint({ apiBaseUrl, fetchImpl, getSession, now?,
refreshBufferMs? })` returns:
- `mint(workspaceId?)`, which returns a coded result;
- `getWorkspaceToken(workspaceId?)`, which plugs into
`createRequestAuthorizer({ getWorkspaceToken })` and rejects with
`SessionTokenError` on failure.

Details:
- **Request.** `POST /auth/token` with `credentials: 'include'`,
`X-Comfy-Client`, `X-CSRF-Token` and `X-Comfy-Workspace-ID`. The body is
`{}` for the personal workspace or `{ workspace_id }`. No
`Authorization` header is sent. The response is parsed with the
generated `zExchangeTokenResponse`, since C8 leaves the 200 shape
unchanged.
- **Lazy.** Nothing is sent until the first call.
- **Cache.** Tokens are cached per workspace and owned by the current
session user, and reused until 60 s before expiry. Concurrent callers
for one workspace share a single request. A user change or sign-out
drops the cache and anything in flight, and a token that arrives after
the user changed is not cached.
- **Failure codes.** A 401 is the session's code (and clears the cache).
403 `csrf_invalid` is `CSRF_STALE` and 403 `workspace_access_denied` is
`WORKSPACE_ACCESS_DENIED`. Other 403s, 400 and 404 are refused. 5xx and
network errors are transient. A 429 carries `retryAfterMs` and holds
further requests until then.
- **Inert on import.** It is added to the importGuard closure, the
inert-import test, package exports and smokePack. No app wires it yet,
and the flag-off harness is unchanged (4/4).
- **For review:**
- It sends `X-Comfy-Workspace-ID` equal to the body's `workspace_id`. C8
only rejects a header that names a different workspace; if you'd rather
send none, it's a one-line removal.
- It has its own classifier because C8 defines a code-less 401 as a dead
session, where `webSession.ts` refuses it.

## AS IS / TO BE

No UI; the evidence is tests.

- AS IS: a session-only site has no token for comfy-api.
- TO BE: tests cover zero requests before the first call, headers and
credentials, cache hit, re-mint at expiry, single-flight, the cache
dropping on a user change, per-workspace keys, a late token not cached
across users, 401/403/404/429/5xx mapping, and Retry-After.

Eight mutations, each reverted with the full suite rerun, all go red:
cache key, user-change drop, expiry buffer, credentials, single-flight,
Retry-After, stale-owner guard, and 401 cache clear.

Checks: account-core 1139 tests pass; typecheck, lint, knip, fallow and
smoke:pack are clean.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
(sections 7, 9, 12, F6)
- Action items:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2900
- Contract: Comfy-Org/cloud#10585, Comfy-Org/cloud#10697

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | flag (cloud) + website/billing-web readers | C11 cloud#10689
+ probe switch (readers) | Comfy-Org#18708 merged; readers in progress |
| FE-2892 | web session client (+ revoke-all follow-up) | C2a
cloud#10589 for revoke-all | Comfy-Org#18710 merged; revoke-all Comfy-Org#18869, do not
merge |
| FE-2893 | ADR | none | Comfy-Org#18707 merged |
| FE-2894 | identity + boot rules | BE-17063 on testcloud | Comfy-Org#18715, do
not merge |
| FE-2895 | `authorize()` | C5 cloud#10555 | Comfy-Org#18716, do not merge |
| FE-2897 | lifecycle, heartbeat | FE-2894, C1 | Comfy-Org#18719, do not merge |
| **FE-2900 (this PR)** | lazy token mint from the session | FE-2895, C8
cloud#10585 | Comfy-Org#18870, do not merge |
| FE-2901 | non-web clients stay on tokens | — | Comfy-Org#18711 |
| FE-2903 | cloud app joins the lifecycle | FE-2897 | Comfy-Org#18871, do not
merge |
| FE-2904 | cloud API client on `authorize()` | FE-2903, FE-2895, C5 |
in progress |
| FE-2905 | socket + media carry workspace | FE-2904, C6, C7 | next |
| FE-2896 / 2899 / 2898 | website header, website credits, billing-web |
FE-2891 readers, FE-2894/2895, C5, C11 | next |
| FE-2906 | cross-origin E2E harness | — | Comfy-Org#18718 (harness only) |
| FE-2902 / 2907 / 2908 | platform, rollout, cleanup | other repo / ops
/ after ramp | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2900 thisPr
```

- Blocked by: Comfy-Org#18716 (FE-2895) and C8 cloud#10585 on testcloud.
- Unblocks: comfy-api callers on session sites (FE-2904 host wiring,
FE-2898 billing-web).

---------

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 26, 2026
…ete on sign-out, heartbeat (Comfy-Org#18719)

> **Stacked on Comfy-Org#18715 (FE-2894) → Comfy-Org#18710 (FE-2892). Do not merge** until
those merge and BE-17061 (C1) and BE-17063 (C3) are on testcloud (the
web session backend is not on staging yet). The base of this PR is the
FE-2894 branch.

## Why

With one shared session, signing in or out on one site has to reach
every open tab on every other site, and a tab must never finish Alice's
action as Bob. TDD §7, §12 and A8 define how: create the session only on
a real sign-in, delete it on sign-out, and run a heartbeat that notices
a remote sign-out or an account change and tells the app to reset.

## How

This extends the FE-2894 state machine rather than adding a second
module, so there is still one state and one pure transition.

- `signedIn(getProof)`: the host calls it only after an interactive
sign-in. A token refresh never creates a session.
- `signOut()`: signs the tab out at once, sends `DELETE
/api/auth/session` (which works on a dead session), and tells sibling
tabs.
- Heartbeat: `GET /session` every 10 minutes while the tab is visible,
and once when it becomes visible. The GET never extends the idle timer.
  - A new CSRF token is adopted silently.
  - `session_revoked` → signed out.
- `no_session`/`session_expired` → restore in place from the remembered
login, without bumping the epoch.
- `SESSION_UNAVAILABLE` and other ambiguous answers keep the user signed
in; the next beat tries again.
- Cross-tab: within one site, only a visible, signed-in tab holds the
lead and beats. Siblings adopt `ok` and `revoked` answers over the
existing broadcast port and validate each message with a schema before
adopting it.
- `CrossTabRefreshPort` gains a message type parameter (`<Message =
AccountCredential>`). The change is type-only, and the cloud app's
existing `createWebCrossTabRefreshPort()` call keeps the same runtime
behaviour.
- `createWebVisibilityPort()` joins `./web`, so the core still touches
no browser global.
- Account change: `onAccountChanged` fires on a remote sign-out, a
different user in any answer, and the host's own sign-out. `getEpoch()`
goes up on each change, and an answer started under an older epoch is
discarded. The host tags requests with the epoch and clears its own
caches, workspace selection and socket (FE-2903). `onSignedOutRemotely`
is the `session_signed_out_remotely` event (revoked only).
- Inert until `boot()`: nothing watches visibility or the channel before
then; the inert-import test now covers `./web`.
- Size: about 358 net non-test lines, over the ~300 guideline. If you
want it smaller, the split is cross-tab adoption + the visibility port +
the generic port type (~70 lines) into a follow-up, or the pure
transition into its own module.

## AS IS / TO BE

No UI; the evidence is tests with injected time, fake visibility and a
fake cross-tab port, no sleeps.

- AS IS: no session lifecycle or heartbeat.
- TO BE: `webSessionIdentity.lifecycle.test.ts` covers:
- a sign-out on another site reaching this tab at its next beat or on
focus;
- a different user in a heartbeat resetting state, with a pending answer
from the old epoch dropped;
  - a hidden tab never beating;
  - followers adopting instead of reading;
  - a token refresh never creating a session;
  - `SESSION_UNAVAILABLE` never signing out.

```
pnpm --filter @comfyorg/account-core test   Tests 1094 passed
pnpm --filter @comfyorg/account-core typecheck / lint   clean
pnpm typecheck   clean
pnpm knip        clean
pnpm fallow audit --base <FE-2894 branch>   No issues in 6 changed files
```

Mutation checks (each reverted):

| Mutation | Result |
| --- | --- |
| hidden tab beats | 2 red |
| followers read too | 1 red |
| heartbeat creates a session | 5 red |
| `SESSION_UNAVAILABLE` signs out | 1 red |
| old-epoch answer applied after an account change | 1 red |

For review:
- The CSRF token travels on the same-origin broadcast channel, the same
trust boundary the port already documents for the workspace token.
- `signOut()` calls `RememberedLogin.signOutLocally` itself, which may
overlap the host's own Firebase sign-out.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
(sections 7, 12, 15 F2, A8)
- Action items and dependency graph:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2897

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | `unified_web_session` client flag, off by default | BE-17135
to turn on; C11 for website/billing-web readers | Comfy-Org#18708 |
| FE-2892 | account-core web session client + error codes | C1, C3
(BE-17063 generated types) | Comfy-Org#18710, do not merge |
| FE-2893 | ADR for the shared web session | none | Comfy-Org#18707 |
| FE-2901 | non-web clients stay on tokens (baseline) | FE-2895 for
`authorize()` rows | Comfy-Org#18711 |
| FE-2894 | session-backed identity + boot rules (stacked on Comfy-Org#18710) |
FE-2892, C3 | Comfy-Org#18715, do not merge |
| FE-2895 | `authorize()` for cookie requests (stacked on Comfy-Org#18710) |
FE-2892, C5 | Comfy-Org#18716, do not merge |
| **FE-2897 (this PR)** | session lifecycle, heartbeat (stacked on
Comfy-Org#18715) | FE-2894, C1, C3 | Comfy-Org#18719, do not merge |
| FE-2906 | cross-origin E2E harness + §17 test ids | C3/C5/C6/C7 on
staging for the rows | Comfy-Org#18718 (harness only) |
| FE-2896, 2898–2900, 2902–2905, 2907, 2908 | apps, token mint, rollout,
cleanup | C5/C6/C7/C8/C11 contracts | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2897 thisPr
```

- Blocked by: Comfy-Org#18715 (FE-2894), Comfy-Org#18710 (FE-2892), BE-17061 (C1),
BE-17063 (C3).
- Unblocks: FE-2903 (cloud app joins the lifecycle), and through it
FE-2904, FE-2905 and FE-2906 rows E2E-02/05/07.

---------

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
christian-byrne pushed a commit that referenced this pull request Sep 27, 2026
…tity source and boot rules (#19019)

Backport of #18715 to `cloud/1.55` (cherry-pick -x of 1699fa8).

## Why

The unified web session stack is going to 1.55. #18715 adds
`@comfyorg/account-core/webSessionIdentity`
(`packages/account-core/src/core/webSessionIdentity.ts`), the
session-backed identity source and boot rules that #18719 builds on. Its
dependencies (#18710 `webSession`, #18716 `requestAuth`) are already on
`cloud/1.55`.

## Root cause (what conflicted)

`packages/account-core/package.json` (exports), `scripts/smokePack.ts`
and `src/webSessionInertImport.test.ts`: adjacent-line conflicts where
`cloud/1.55` already lists `requestAuth` (from the #18716 backport) at
the same spot #18715 inserts `webSessionIdentity`. `importGuard.test.ts`
applied cleanly.

## How

Kept the release branch's `requestAuth` entries and added only #18715's
own `webSessionIdentity` entries, in main's order (`requestAuth` then
`webSessionIdentity`). No other main-only entries (`sessionTokenMint`
etc.) were pulled in. `webSessionIdentity.ts` and its test apply
verbatim.

Validation: `pnpm typecheck:account-core` exit 0; vitest
`webSessionIdentity`, `webSession`, `importGuard`,
`webSessionInertImport` 75/75 pass; package.json parses.

## AS IS / TO BE

No UI change (inert behind `unified_web_session`).

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
christian-byrne pushed a commit that referenced this pull request Sep 27, 2026
…ules (#18715)

> **Do not merge** until BE-17063 (`GET /api/auth/session`, cloud#10549,
merged) is deployed on testcloud (the web session backend is not on
staging yet). #18710 (FE-2892) is merged; this PR now targets `main` and
the diff shows only this ticket.

A site that joins the shared web session has to decide at boot who is
signed in: the session on ingest, a login this browser remembers, or
nobody. TDD §12's boot table defines that, and §8 defines the silent
restore that lets every existing user migrate without signing in again.
This PR is that decision, as a pure state machine in
`@comfyorg/account-core`, inert until a host calls `boot()`.

New entry `@comfyorg/account-core/webSessionIdentity`
(`packages/account-core/src/core/webSessionIdentity.ts`):

- `createWebSessionIdentity({ session, principal, origin, onBootstrap?,
schedule?, retryBaseMs?, retryMaxMs? })` → `{ getState, subscribe, boot,
dispose }`. Constructing it sends nothing and starts nothing.
- `principal`: `{ kind: 'account', rememberedLogin }` or `{ kind:
'api_key' }`. An API-key principal never enters the machine and never
touches `/api/auth/session`.
- `RememberedLogin` is an opaque port (`currentUserId`, `getProof`
returning `string | null`, `signOutLocally`), so the core imports no
provider. `importGuard` now walks the import chain from
`webSessionIdentity.ts`.
- One discriminated state (`idle | api_key | reading | retry_wait |
restoring | signed_in | signed_out`), one pure
`transitionWebSessionIdentity(state, event)` returning `{ state, effects
}`; the shell only runs effects (`read`, `restore`, `schedule_retry`,
`sign_out_locally`, `report`). `session_bootstrap` (outcome, origin)
goes out through `onBootstrap`.

| `GET /session` | Result |
| --- | --- |
| 200 | `signed_in`; if the remembered login is a different user, sign
it out locally |
| 401 `session_revoked` | `signed_out(revoked)`, local sign-out, never a
silent restore |
| 401 `no_session` / `session_expired`, login remembered | silent
restore (`createWebSession` with the remembered proof); success →
`signed_in(restored)`; a completed failure →
`signed_out(restore_failed)` |
| 401 `no_session` / `session_expired`, nothing remembered |
`signed_out` |
| `SESSION_UNAVAILABLE` (network, 429, 5xx) | `retry_wait`, backoff 1s
doubling to 60s, never signs out |

- A restore that fails transiently (network, 5xx, or `getProof`
throwing) is not spent: after backoff it re-reads first, so a POST that
landed but lost its answer yields 200 and no second POST. `getProof`
returning `null` is permanent (`restore_failed`, no local sign-out). A
restore that gets a real answer completes at most once per boot.
- The SDK keeps no record of past sessions; the server's answer decides.
- Not wired into any app yet (FE-2896 website, FE-2903 cloud). The
shared flag-off harness from #18708/#18710 is inherited from the base
and stays green.

No UI; the evidence is tests with injected time and the package fakes,
no sleeps.

- AS IS: no boot logic for the web session.
- TO BE: one test per boot-table row (row 1 split by remembered user
same/different/none; row 3 for both 401 codes), backoff 1000 → 2000 then
sign-in with zero sign-outs, restore lost twice then restored (`GET POST
GET POST GET POST GET`), a landed-but-unanswered POST (`GET POST GET`,
no second POST), `getProof` null / throwing, a pure table of restore
answers, API key → zero requests.

```
pnpm --filter @comfyorg/account-core test   Test Files 62 passed, Tests 1070 passed
pnpm --filter @comfyorg/account-core typecheck / lint   exit 0
pnpm typecheck   exit 0
pnpm knip        exit 0
pnpm fallow audit --base <FE-2892 branch>   No issues in 6 changed files
```

Mutation checks (each reverted): `session_revoked` restores → red;
network error on read signs out → red; transient restore failure signs
out → red; completed restore failure retries → red; thrown proof signs
out → red.

Size: `webSessionIdentity.ts` is 336 lines, mostly the state, event and
effect types; the transition itself is small.

For review: `RememberedLogin.currentUserId()` must return the Comfy user
id, since it is compared with the session's `user.id`. The host adapters
(FE-2896/FE-2903) need to confirm that equals the Firebase uid.

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
(sections 8, 12, A8)
- Action items and dependency graph:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2894

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | `unified_web_session` client flag, off by default | BE-17135
to turn on; C11 for website/billing-web readers | #18708 |
| FE-2892 | account-core web session client + error codes | C1, C3
(BE-17063 generated types) | #18710, do not merge |
| FE-2893 | ADR for the shared web session | none | #18707 |
| FE-2901 | non-web clients stay on tokens (baseline) | FE-2895 for
`authorize()` rows | #18711 |
| **FE-2894 (this PR)** | session-backed identity + boot rules (stacked
on #18710) | FE-2892, C3 | #18715, do not merge |
| FE-2895 | `authorize()` for cookie requests (stacked on #18710) |
FE-2892, C5 | #18716, do not merge |
| FE-2897 | session lifecycle, heartbeat (stacked on #18715) | FE-2894,
C1, C3 | #18719, do not merge |
| FE-2906 | cross-origin E2E harness + §17 test ids | C3/C5/C6/C7 on
staging for the rows | #18718 (harness only) |
| FE-2896, 2898–2900, 2902–2905, 2907, 2908 | apps, token mint, rollout,
cleanup | C5/C6/C7/C8/C11 contracts | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2894 thisPr
```

- Blocked by: #18710 (FE-2892) and BE-17063 (C3). FE-2891 gates it at
the host, not here.
- Unblocks: FE-2896 (website header), FE-2897 (lifecycle, heartbeat),
FE-2898 (billing-web).

---------

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
(cherry picked from commit 1699fa8)
christian-byrne pushed a commit that referenced this pull request Sep 27, 2026
…ete on sign-out, heartbeat (#18719)

> **Stacked on #18715 (FE-2894) → #18710 (FE-2892). Do not merge** until
those merge and BE-17061 (C1) and BE-17063 (C3) are on testcloud (the
web session backend is not on staging yet). The base of this PR is the
FE-2894 branch.

## Why

With one shared session, signing in or out on one site has to reach
every open tab on every other site, and a tab must never finish Alice's
action as Bob. TDD §7, §12 and A8 define how: create the session only on
a real sign-in, delete it on sign-out, and run a heartbeat that notices
a remote sign-out or an account change and tells the app to reset.

## How

This extends the FE-2894 state machine rather than adding a second
module, so there is still one state and one pure transition.

- `signedIn(getProof)`: the host calls it only after an interactive
sign-in. A token refresh never creates a session.
- `signOut()`: signs the tab out at once, sends `DELETE
/api/auth/session` (which works on a dead session), and tells sibling
tabs.
- Heartbeat: `GET /session` every 10 minutes while the tab is visible,
and once when it becomes visible. The GET never extends the idle timer.
  - A new CSRF token is adopted silently.
  - `session_revoked` → signed out.
- `no_session`/`session_expired` → restore in place from the remembered
login, without bumping the epoch.
- `SESSION_UNAVAILABLE` and other ambiguous answers keep the user signed
in; the next beat tries again.
- Cross-tab: within one site, only a visible, signed-in tab holds the
lead and beats. Siblings adopt `ok` and `revoked` answers over the
existing broadcast port and validate each message with a schema before
adopting it.
- `CrossTabRefreshPort` gains a message type parameter (`<Message =
AccountCredential>`). The change is type-only, and the cloud app's
existing `createWebCrossTabRefreshPort()` call keeps the same runtime
behaviour.
- `createWebVisibilityPort()` joins `./web`, so the core still touches
no browser global.
- Account change: `onAccountChanged` fires on a remote sign-out, a
different user in any answer, and the host's own sign-out. `getEpoch()`
goes up on each change, and an answer started under an older epoch is
discarded. The host tags requests with the epoch and clears its own
caches, workspace selection and socket (FE-2903). `onSignedOutRemotely`
is the `session_signed_out_remotely` event (revoked only).
- Inert until `boot()`: nothing watches visibility or the channel before
then; the inert-import test now covers `./web`.
- Size: about 358 net non-test lines, over the ~300 guideline. If you
want it smaller, the split is cross-tab adoption + the visibility port +
the generic port type (~70 lines) into a follow-up, or the pure
transition into its own module.

## AS IS / TO BE

No UI; the evidence is tests with injected time, fake visibility and a
fake cross-tab port, no sleeps.

- AS IS: no session lifecycle or heartbeat.
- TO BE: `webSessionIdentity.lifecycle.test.ts` covers:
- a sign-out on another site reaching this tab at its next beat or on
focus;
- a different user in a heartbeat resetting state, with a pending answer
from the old epoch dropped;
  - a hidden tab never beating;
  - followers adopting instead of reading;
  - a token refresh never creating a session;
  - `SESSION_UNAVAILABLE` never signing out.

```
pnpm --filter @comfyorg/account-core test   Tests 1094 passed
pnpm --filter @comfyorg/account-core typecheck / lint   clean
pnpm typecheck   clean
pnpm knip        clean
pnpm fallow audit --base <FE-2894 branch>   No issues in 6 changed files
```

Mutation checks (each reverted):

| Mutation | Result |
| --- | --- |
| hidden tab beats | 2 red |
| followers read too | 1 red |
| heartbeat creates a session | 5 red |
| `SESSION_UNAVAILABLE` signs out | 1 red |
| old-epoch answer applied after an account change | 1 red |

For review:
- The CSRF token travels on the same-origin broadcast channel, the same
trust boundary the port already documents for the workspace token.
- `signOut()` calls `RememberedLogin.signOutLocally` itself, which may
overlap the host's own Firebase sign-out.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
(sections 7, 12, 15 F2, A8)
- Action items and dependency graph:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2897

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | `unified_web_session` client flag, off by default | BE-17135
to turn on; C11 for website/billing-web readers | #18708 |
| FE-2892 | account-core web session client + error codes | C1, C3
(BE-17063 generated types) | #18710, do not merge |
| FE-2893 | ADR for the shared web session | none | #18707 |
| FE-2901 | non-web clients stay on tokens (baseline) | FE-2895 for
`authorize()` rows | #18711 |
| FE-2894 | session-backed identity + boot rules (stacked on #18710) |
FE-2892, C3 | #18715, do not merge |
| FE-2895 | `authorize()` for cookie requests (stacked on #18710) |
FE-2892, C5 | #18716, do not merge |
| **FE-2897 (this PR)** | session lifecycle, heartbeat (stacked on
#18715) | FE-2894, C1, C3 | #18719, do not merge |
| FE-2906 | cross-origin E2E harness + §17 test ids | C3/C5/C6/C7 on
staging for the rows | #18718 (harness only) |
| FE-2896, 2898–2900, 2902–2905, 2907, 2908 | apps, token mint, rollout,
cleanup | C5/C6/C7/C8/C11 contracts | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2897 thisPr
```

- Blocked by: #18715 (FE-2894), #18710 (FE-2892), BE-17061 (C1),
BE-17063 (C3).
- Unblocks: FE-2903 (cloud app joins the lifecycle), and through it
FE-2904, FE-2905 and FE-2906 rows E2E-02/05/07.

---------

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
(cherry picked from commit 1685d33)
christian-byrne pushed a commit that referenced this pull request Sep 27, 2026
…ity source and boot rules (#19018)

Backport of #18715 to `core/1.55` (cherry-pick -x of 1699fa8).

## Why

The unified web session stack is going to 1.55. #18715 adds
`@comfyorg/account-core/webSessionIdentity`
(`packages/account-core/src/core/webSessionIdentity.ts`), the
session-backed identity source and boot rules that #18719 builds on. Its
dependencies (#18710 `webSession`, #18716 `requestAuth`) are already on
`core/1.55`.

## Root cause (what conflicted)

`packages/account-core/package.json` (exports), `scripts/smokePack.ts`
and `src/webSessionInertImport.test.ts`: adjacent-line conflicts where
`core/1.55` already lists `requestAuth` (from the #18716 backport) at
the same spot #18715 inserts `webSessionIdentity`. `importGuard.test.ts`
applied cleanly.

## How

Kept the release branch's `requestAuth` entries and added only #18715's
own `webSessionIdentity` entries, in main's order (`requestAuth` then
`webSessionIdentity`). No other main-only entries (`sessionTokenMint`
etc.) were pulled in. `webSessionIdentity.ts` and its test apply
verbatim.

Validation: `pnpm typecheck:account-core` exit 0; vitest
`webSessionIdentity`, `webSession`, `importGuard`,
`webSessionInertImport` 75/75 pass; package.json parses.

## AS IS / TO BE

No UI change (inert behind `unified_web_session`).

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
christian-byrne pushed a commit that referenced this pull request Sep 27, 2026
…ete on sign-out, heartbeat (#18719)

> **Stacked on #18715 (FE-2894) → #18710 (FE-2892). Do not merge** until
those merge and BE-17061 (C1) and BE-17063 (C3) are on testcloud (the
web session backend is not on staging yet). The base of this PR is the
FE-2894 branch.

## Why

With one shared session, signing in or out on one site has to reach
every open tab on every other site, and a tab must never finish Alice's
action as Bob. TDD §7, §12 and A8 define how: create the session only on
a real sign-in, delete it on sign-out, and run a heartbeat that notices
a remote sign-out or an account change and tells the app to reset.

## How

This extends the FE-2894 state machine rather than adding a second
module, so there is still one state and one pure transition.

- `signedIn(getProof)`: the host calls it only after an interactive
sign-in. A token refresh never creates a session.
- `signOut()`: signs the tab out at once, sends `DELETE
/api/auth/session` (which works on a dead session), and tells sibling
tabs.
- Heartbeat: `GET /session` every 10 minutes while the tab is visible,
and once when it becomes visible. The GET never extends the idle timer.
  - A new CSRF token is adopted silently.
  - `session_revoked` → signed out.
- `no_session`/`session_expired` → restore in place from the remembered
login, without bumping the epoch.
- `SESSION_UNAVAILABLE` and other ambiguous answers keep the user signed
in; the next beat tries again.
- Cross-tab: within one site, only a visible, signed-in tab holds the
lead and beats. Siblings adopt `ok` and `revoked` answers over the
existing broadcast port and validate each message with a schema before
adopting it.
- `CrossTabRefreshPort` gains a message type parameter (`<Message =
AccountCredential>`). The change is type-only, and the cloud app's
existing `createWebCrossTabRefreshPort()` call keeps the same runtime
behaviour.
- `createWebVisibilityPort()` joins `./web`, so the core still touches
no browser global.
- Account change: `onAccountChanged` fires on a remote sign-out, a
different user in any answer, and the host's own sign-out. `getEpoch()`
goes up on each change, and an answer started under an older epoch is
discarded. The host tags requests with the epoch and clears its own
caches, workspace selection and socket (FE-2903). `onSignedOutRemotely`
is the `session_signed_out_remotely` event (revoked only).
- Inert until `boot()`: nothing watches visibility or the channel before
then; the inert-import test now covers `./web`.
- Size: about 358 net non-test lines, over the ~300 guideline. If you
want it smaller, the split is cross-tab adoption + the visibility port +
the generic port type (~70 lines) into a follow-up, or the pure
transition into its own module.

## AS IS / TO BE

No UI; the evidence is tests with injected time, fake visibility and a
fake cross-tab port, no sleeps.

- AS IS: no session lifecycle or heartbeat.
- TO BE: `webSessionIdentity.lifecycle.test.ts` covers:
- a sign-out on another site reaching this tab at its next beat or on
focus;
- a different user in a heartbeat resetting state, with a pending answer
from the old epoch dropped;
  - a hidden tab never beating;
  - followers adopting instead of reading;
  - a token refresh never creating a session;
  - `SESSION_UNAVAILABLE` never signing out.

```
pnpm --filter @comfyorg/account-core test   Tests 1094 passed
pnpm --filter @comfyorg/account-core typecheck / lint   clean
pnpm typecheck   clean
pnpm knip        clean
pnpm fallow audit --base <FE-2894 branch>   No issues in 6 changed files
```

Mutation checks (each reverted):

| Mutation | Result |
| --- | --- |
| hidden tab beats | 2 red |
| followers read too | 1 red |
| heartbeat creates a session | 5 red |
| `SESSION_UNAVAILABLE` signs out | 1 red |
| old-epoch answer applied after an account change | 1 red |

For review:
- The CSRF token travels on the same-origin broadcast channel, the same
trust boundary the port already documents for the workspace token.
- `signOut()` calls `RememberedLogin.signOutLocally` itself, which may
overlap the host's own Firebase sign-out.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
(sections 7, 12, 15 F2, A8)
- Action items and dependency graph:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2897

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | `unified_web_session` client flag, off by default | BE-17135
to turn on; C11 for website/billing-web readers | #18708 |
| FE-2892 | account-core web session client + error codes | C1, C3
(BE-17063 generated types) | #18710, do not merge |
| FE-2893 | ADR for the shared web session | none | #18707 |
| FE-2901 | non-web clients stay on tokens (baseline) | FE-2895 for
`authorize()` rows | #18711 |
| FE-2894 | session-backed identity + boot rules (stacked on #18710) |
FE-2892, C3 | #18715, do not merge |
| FE-2895 | `authorize()` for cookie requests (stacked on #18710) |
FE-2892, C5 | #18716, do not merge |
| **FE-2897 (this PR)** | session lifecycle, heartbeat (stacked on
#18715) | FE-2894, C1, C3 | #18719, do not merge |
| FE-2906 | cross-origin E2E harness + §17 test ids | C3/C5/C6/C7 on
staging for the rows | #18718 (harness only) |
| FE-2896, 2898–2900, 2902–2905, 2907, 2908 | apps, token mint, rollout,
cleanup | C5/C6/C7/C8/C11 contracts | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2897 thisPr
```

- Blocked by: #18715 (FE-2894), #18710 (FE-2892), BE-17061 (C1),
BE-17063 (C3).
- Unblocks: FE-2903 (cloud app joins the lifecycle), and through it
FE-2904, FE-2905 and FE-2906 rows E2E-02/05/07.

---------

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
(cherry picked from commit 1685d33)
christian-byrne pushed a commit that referenced this pull request Sep 27, 2026
…ssion (#18870)

> **Stacked on #18716 (FE-2895). Do not merge** until #18716 merges and
C8 (BE-17069, cloud#10585 + #10697: `POST /api/auth/token` accepts the
cookie) is on testcloud.

## Why

comfy-api and the other services cannot read the session cookie. A site
that arrived by session has no Firebase login to hand them. TDD §7/§12
has the site mint a short-lived workspace token from the session, lazily
and only when a non-ingest call needs one. This is the token source
`authorize()` (#18716) takes for its `resource` target.

## How

New entry `@comfyorg/account-core/sessionTokenMint`:
`createSessionTokenMint({ apiBaseUrl, fetchImpl, getSession, now?,
refreshBufferMs? })` returns:
- `mint(workspaceId?)`, which returns a coded result;
- `getWorkspaceToken(workspaceId?)`, which plugs into
`createRequestAuthorizer({ getWorkspaceToken })` and rejects with
`SessionTokenError` on failure.

Details:
- **Request.** `POST /auth/token` with `credentials: 'include'`,
`X-Comfy-Client`, `X-CSRF-Token` and `X-Comfy-Workspace-ID`. The body is
`{}` for the personal workspace or `{ workspace_id }`. No
`Authorization` header is sent. The response is parsed with the
generated `zExchangeTokenResponse`, since C8 leaves the 200 shape
unchanged.
- **Lazy.** Nothing is sent until the first call.
- **Cache.** Tokens are cached per workspace and owned by the current
session user, and reused until 60 s before expiry. Concurrent callers
for one workspace share a single request. A user change or sign-out
drops the cache and anything in flight, and a token that arrives after
the user changed is not cached.
- **Failure codes.** A 401 is the session's code (and clears the cache).
403 `csrf_invalid` is `CSRF_STALE` and 403 `workspace_access_denied` is
`WORKSPACE_ACCESS_DENIED`. Other 403s, 400 and 404 are refused. 5xx and
network errors are transient. A 429 carries `retryAfterMs` and holds
further requests until then.
- **Inert on import.** It is added to the importGuard closure, the
inert-import test, package exports and smokePack. No app wires it yet,
and the flag-off harness is unchanged (4/4).
- **For review:**
- It sends `X-Comfy-Workspace-ID` equal to the body's `workspace_id`. C8
only rejects a header that names a different workspace; if you'd rather
send none, it's a one-line removal.
- It has its own classifier because C8 defines a code-less 401 as a dead
session, where `webSession.ts` refuses it.

## AS IS / TO BE

No UI; the evidence is tests.

- AS IS: a session-only site has no token for comfy-api.
- TO BE: tests cover zero requests before the first call, headers and
credentials, cache hit, re-mint at expiry, single-flight, the cache
dropping on a user change, per-workspace keys, a late token not cached
across users, 401/403/404/429/5xx mapping, and Retry-After.

Eight mutations, each reverted with the full suite rerun, all go red:
cache key, user-change drop, expiry buffer, credentials, single-flight,
Retry-After, stale-owner guard, and 401 cache clear.

Checks: account-core 1139 tests pass; typecheck, lint, knip, fallow and
smoke:pack are clean.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
(sections 7, 9, 12, F6)
- Action items:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2900
- Contract: Comfy-Org/cloud#10585, Comfy-Org/cloud#10697

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | flag (cloud) + website/billing-web readers | C11 cloud#10689
+ probe switch (readers) | #18708 merged; readers in progress |
| FE-2892 | web session client (+ revoke-all follow-up) | C2a
cloud#10589 for revoke-all | #18710 merged; revoke-all #18869, do not
merge |
| FE-2893 | ADR | none | #18707 merged |
| FE-2894 | identity + boot rules | BE-17063 on testcloud | #18715, do
not merge |
| FE-2895 | `authorize()` | C5 cloud#10555 | #18716, do not merge |
| FE-2897 | lifecycle, heartbeat | FE-2894, C1 | #18719, do not merge |
| **FE-2900 (this PR)** | lazy token mint from the session | FE-2895, C8
cloud#10585 | #18870, do not merge |
| FE-2901 | non-web clients stay on tokens | — | #18711 |
| FE-2903 | cloud app joins the lifecycle | FE-2897 | #18871, do not
merge |
| FE-2904 | cloud API client on `authorize()` | FE-2903, FE-2895, C5 |
in progress |
| FE-2905 | socket + media carry workspace | FE-2904, C6, C7 | next |
| FE-2896 / 2899 / 2898 | website header, website credits, billing-web |
FE-2891 readers, FE-2894/2895, C5, C11 | next |
| FE-2906 | cross-origin E2E harness | — | #18718 (harness only) |
| FE-2902 / 2907 / 2908 | platform, rollout, cleanup | other repo / ops
/ after ramp | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2900 thisPr
```

- Blocked by: #18716 (FE-2895) and C8 cloud#10585 on testcloud.
- Unblocks: comfy-api callers on session sites (FE-2904 host wiring,
FE-2898 billing-web).

---------

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
(cherry picked from commit 70ce571)
christian-byrne pushed a commit that referenced this pull request Sep 27, 2026
…ete on sign-out, heartbeat (#18719)

> **Stacked on #18715 (FE-2894) → #18710 (FE-2892). Do not merge** until
those merge and BE-17061 (C1) and BE-17063 (C3) are on testcloud (the
web session backend is not on staging yet). The base of this PR is the
FE-2894 branch.

## Why

With one shared session, signing in or out on one site has to reach
every open tab on every other site, and a tab must never finish Alice's
action as Bob. TDD §7, §12 and A8 define how: create the session only on
a real sign-in, delete it on sign-out, and run a heartbeat that notices
a remote sign-out or an account change and tells the app to reset.

## How

This extends the FE-2894 state machine rather than adding a second
module, so there is still one state and one pure transition.

- `signedIn(getProof)`: the host calls it only after an interactive
sign-in. A token refresh never creates a session.
- `signOut()`: signs the tab out at once, sends `DELETE
/api/auth/session` (which works on a dead session), and tells sibling
tabs.
- Heartbeat: `GET /session` every 10 minutes while the tab is visible,
and once when it becomes visible. The GET never extends the idle timer.
  - A new CSRF token is adopted silently.
  - `session_revoked` → signed out.
- `no_session`/`session_expired` → restore in place from the remembered
login, without bumping the epoch.
- `SESSION_UNAVAILABLE` and other ambiguous answers keep the user signed
in; the next beat tries again.
- Cross-tab: within one site, only a visible, signed-in tab holds the
lead and beats. Siblings adopt `ok` and `revoked` answers over the
existing broadcast port and validate each message with a schema before
adopting it.
- `CrossTabRefreshPort` gains a message type parameter (`<Message =
AccountCredential>`). The change is type-only, and the cloud app's
existing `createWebCrossTabRefreshPort()` call keeps the same runtime
behaviour.
- `createWebVisibilityPort()` joins `./web`, so the core still touches
no browser global.
- Account change: `onAccountChanged` fires on a remote sign-out, a
different user in any answer, and the host's own sign-out. `getEpoch()`
goes up on each change, and an answer started under an older epoch is
discarded. The host tags requests with the epoch and clears its own
caches, workspace selection and socket (FE-2903). `onSignedOutRemotely`
is the `session_signed_out_remotely` event (revoked only).
- Inert until `boot()`: nothing watches visibility or the channel before
then; the inert-import test now covers `./web`.
- Size: about 358 net non-test lines, over the ~300 guideline. If you
want it smaller, the split is cross-tab adoption + the visibility port +
the generic port type (~70 lines) into a follow-up, or the pure
transition into its own module.

## AS IS / TO BE

No UI; the evidence is tests with injected time, fake visibility and a
fake cross-tab port, no sleeps.

- AS IS: no session lifecycle or heartbeat.
- TO BE: `webSessionIdentity.lifecycle.test.ts` covers:
- a sign-out on another site reaching this tab at its next beat or on
focus;
- a different user in a heartbeat resetting state, with a pending answer
from the old epoch dropped;
  - a hidden tab never beating;
  - followers adopting instead of reading;
  - a token refresh never creating a session;
  - `SESSION_UNAVAILABLE` never signing out.

```
pnpm --filter @comfyorg/account-core test   Tests 1094 passed
pnpm --filter @comfyorg/account-core typecheck / lint   clean
pnpm typecheck   clean
pnpm knip        clean
pnpm fallow audit --base <FE-2894 branch>   No issues in 6 changed files
```

Mutation checks (each reverted):

| Mutation | Result |
| --- | --- |
| hidden tab beats | 2 red |
| followers read too | 1 red |
| heartbeat creates a session | 5 red |
| `SESSION_UNAVAILABLE` signs out | 1 red |
| old-epoch answer applied after an account change | 1 red |

For review:
- The CSRF token travels on the same-origin broadcast channel, the same
trust boundary the port already documents for the workspace token.
- `signOut()` calls `RememberedLogin.signOutLocally` itself, which may
overlap the host's own Firebase sign-out.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
(sections 7, 12, 15 F2, A8)
- Action items and dependency graph:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2897

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | `unified_web_session` client flag, off by default | BE-17135
to turn on; C11 for website/billing-web readers | #18708 |
| FE-2892 | account-core web session client + error codes | C1, C3
(BE-17063 generated types) | #18710, do not merge |
| FE-2893 | ADR for the shared web session | none | #18707 |
| FE-2901 | non-web clients stay on tokens (baseline) | FE-2895 for
`authorize()` rows | #18711 |
| FE-2894 | session-backed identity + boot rules (stacked on #18710) |
FE-2892, C3 | #18715, do not merge |
| FE-2895 | `authorize()` for cookie requests (stacked on #18710) |
FE-2892, C5 | #18716, do not merge |
| **FE-2897 (this PR)** | session lifecycle, heartbeat (stacked on
#18715) | FE-2894, C1, C3 | #18719, do not merge |
| FE-2906 | cross-origin E2E harness + §17 test ids | C3/C5/C6/C7 on
staging for the rows | #18718 (harness only) |
| FE-2896, 2898–2900, 2902–2905, 2907, 2908 | apps, token mint, rollout,
cleanup | C5/C6/C7/C8/C11 contracts | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2897 thisPr
```

- Blocked by: #18715 (FE-2894), #18710 (FE-2892), BE-17061 (C1),
BE-17063 (C3).
- Unblocks: FE-2903 (cloud app joins the lifecycle), and through it
FE-2904, FE-2905 and FE-2906 rows E2E-02/05/07.

---------

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
(cherry picked from commit 1685d33)
laurigates pushed a commit to laurigates/ComfyUI_frontend that referenced this pull request Sep 28, 2026
…ds (Comfy-Org#18718)

## Why

The unified web session only proves itself across real origins: a cookie
on the Cloud host, read by pages on other `comfy.org` names, refused for
untrusted origins. TDD §17 lists the end-to-end rows and failure
sequences that gate turning the flag on (rollout step 5). The web
session backend is not on staging yet, so the suite targets the test
environment (`testcloud.comfy.org`, `testbilling.comfy.org`); it moves
to staging by changing env vars once the backend is there. The
behaviours need backend C3/C5/C6/C7 on testcloud and FE-2894..FE-2905,
but the harness and the test-id map can land now so each slice fills in
its rows instead of building infrastructure late.

## How

- `playwright.session.config.ts`: a separate config with projects
`session-flag-off` and `session-flag-on` (selected by `@flag-off` /
`@flag-on`), one worker, no global setup. Not part of the default run:
`playwright.config.ts` only gains `'**/crossOriginSession/**'` in
`testIgnore`; the default `--list` is identical before and after (2641
tests in 472 files).
- Mapping the website to a `comfy.org` name: the fixture serves the
locally running website under a real name (default
`https://www.comfy.org`) by intercepting that host in the browser and
fetching from the local server. Page URL, `Origin`, secure context and
same-site checks all use the real name, which the `__Host-` cookie
needs; `--host-resolver-rules` would need a trusted local TLS server on
443. This proves Origin and trusted-origin behaviour, not TLS, DNS or
hosting (TDD §17).
- Fixtures: `cloudTab`, `websiteTab`, `billingTab`, `platformTab` in one
browser context (shared cookie jar). Each records Firebase Auth calls
(`identitytoolkit`/`securetoken`) and `/api/auth/session` calls, and has
`waitForSocket` / `waitForClose`. Also `sessionAccount`,
`teamWorkspaceId`, `signInOnCloud`, `openPreviewPage` (a
`pr-1.testenvs.comfy.org` page) and `credentialedFetch`.
- Safety, fail-closed: production hosts (cloud, api, billing, platform)
are refused even if configured and fail the test; any other `comfy.org`
origin that is not configured (the `SESSION_E2E_*` URLs or
`SESSION_E2E_EXTRA_ORIGINS`) is blocked, as are unlisted third-party
requests, and all blocked egress is attached as `blocked-egress.json`; a
test whose env vars are missing skips and names them. No credentials in
the repo; they come from env (`SESSION_E2E_*`), see the README.
- The flag is set both ways the app reads it: `ff:unified_web_session`
in localStorage and `?ff=unified_web_session:<bool>` on the Cloud tab.
- Test ids: every §17 row and FE-observable failure sequence, plus M2
SS1–SS6 / SO1–SO6, is a definition-level `test.fixme('[E2E-01] …',
blockedBy('<ticket / slice>'), expectStepsWritten)`: it keeps a stable
id and its blocker as a `blocked-by` annotation, skips before any
fixture runs, and has no guessed steps. `expectStepsWritten` throws, so
a row flipped to `test` before its steps are written fails instead of
passing empty. Steps are written when each blocker lands. `HARNESS-01`
is the one runnable smoke (flag off): the website loads under the mapped
name, calls testcloud with the right `Origin`, and the Firebase recorder
sees the sign-in.
- Carries the shared flag-off request test
(`src/platform/auth/webSessionFlagOff.test.ts`), byte-identical to
Comfy-Org#18708 / Comfy-Org#18710 / Comfy-Org#18711.

| ID | Row | Blocked by |
| --- | --- | --- |
| HARNESS-01 | runnable smoke, flag off | testcloud credentials |
| E2E-01 | sign in on Cloud → website signed in, zero Firebase calls |
FE-2896, FE-2894; C3, C11 |
| E2E-02 | the reverse | FE-2897, FE-2903; C1, C3 |
| E2E-03 | two tabs, two workspaces | FE-2904; C5 |
| E2E-04 | team-workspace media | FE-2905; C7 |
| E2E-05 | sign out on one site, other signs out, socket closes |
FE-2897, FE-2903, FE-2905; C6 |
| E2E-06 | removed from workspace → next request refused | FE-2904; C5 |
| E2E-07 | sign out of all devices | FE-2897; C2 |
| E2E-08 | flag off behaves as today | FE-2891, FE-2894, FE-2903 |
| E2E-09 | signed-in user crosses each rollout step | FE-2903, FE-2907;
C1, C3 |
| FS-01, 02, 06–15, 18, 19 | failure sequences a browser can observe |
see each test's fixme reason |
| SS1–SS6, SO1–SO6 | M2 billing-web rows | FE-2898 (+
FE-2903/2897/2895/2894); C1/C3/C5/C11 |

Not mapped on purpose: FS-03, FS-04, FS-05, FS-16, FS-17 (backend races
and load a browser cannot observe).

## AS IS / TO BE

No UI change; the evidence is the test list and checks.

- AS IS: no harness for cross-origin session tests.
- TO BE: `pnpm exec playwright test --config
playwright.session.config.ts --list` → `Total: 36 tests in 4 files`;
with no env every test skips cleanly. Default config unchanged (`Total:
2641 tests in 472 files` before and after, identical sorted list).

Checked by hand with a temporary spec (deleted): the local website
served as `https://www.comfy.org` in a secure context, a call to Cloud
carried `Origin: https://www.comfy.org` (that manual check ran against
stagingcloud before the switch to testcloud), the Firebase recorder
caught a `securetoken` call, and a request to `cloud.comfy.org` failed
the test with "A session E2E run reached production". The HARNESS-01
smoke itself has not run end to end; it needs a testcloud account.

Checks: `pnpm typecheck:browser` pass, eslint/oxlint/oxfmt clean on
changed files, `pnpm knip` clean, `crossOriginSessionConfig.test.ts`
11/11, flag-off request test 4/4.

## Needs a human

- A dedicated testcloud account: verified `@comfy.org` (so `?ff=` works
on deployed builds), in the test environment's `web_session_enabled`
set, owning a team workspace. A second account for FS-10, FS-13 and SS3.
- Which `comfy.org` name for the website is on the test environment's
trusted-origin list (README defaults to `https://www.comfy.org`).
- Whether Cloudflare Access or Turnstile in front of testcloud needs an
origin in `SESSION_E2E_EXTRA_ORIGINS` or an Access token.
- The test platform URL is unknown.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
(sections 17, 18)
- Action items and dependency graph:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- M2 QA test plan:
https://app.notion.com/p/3e26d73d3650815fb78ec0d273278d3b
- Linear: https://linear.app/comfyorg/issue/FE-2906

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | `unified_web_session` client flag, off by default | BE-17135
to turn on; C11 for website/billing-web readers | Comfy-Org#18708 |
| FE-2892 | account-core web session client + error codes | C1, C3
(BE-17063 generated types) | Comfy-Org#18710, do not merge |
| FE-2893 | ADR for the shared web session | none | Comfy-Org#18707 |
| FE-2901 | non-web clients stay on tokens (baseline) | FE-2895 for
`authorize()` rows | Comfy-Org#18711 |
| FE-2894 | session-backed identity + boot rules (stacked on Comfy-Org#18710) |
FE-2892, C3 | Comfy-Org#18715, do not merge |
| FE-2895 | `authorize()` for cookie requests (stacked on Comfy-Org#18710) |
FE-2892, C5 | Comfy-Org#18716, do not merge |
| FE-2897 | session lifecycle, heartbeat (stacked on Comfy-Org#18715) | FE-2894,
C1, C3 | Comfy-Org#18719, do not merge |
| **FE-2906 (this PR)** | cross-origin E2E harness + §17 test ids |
C3/C5/C6/C7 on testcloud for the rows | Comfy-Org#18718 (harness only) |
| FE-2896, 2898–2900, 2902–2905, 2907, 2908 | apps, token mint, rollout,
cleanup | C5/C6/C7/C8/C11 contracts | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2906 thisPr
```

- Blocked by: nothing for the harness. The rows need C3/C5/C6/C7 on
testcloud and FE-2894..FE-2905.
- Unblocks: FE-2907 (turning the flag on needs the §17 rows green).
zeus-onl pushed a commit to zeus-onl/ComfyUI_frontend that referenced this pull request Sep 28, 2026
…omfy-Org#19002)

## Why

The web session PRs merged with four non-blocking review notes from
Christian, and CodeRabbit found one real defect after Comfy-Org#18719 merged. All
of this code is on main now, so the fixes land together here.

## Root cause (the defect)

`signedIn()` awaited `createWebSession` (a POST, then a GET) and then
always dispatched `session_created` and published `sign_in`. It never
checked whether `signOut()` had run in the meantime.
- The cloud store starts the interactive session without awaiting it, so
a user who logs out quickly hits exactly this window.
- The tab went back to `signed_in`, and every signed-out sibling tab
adopted the published `sign_in`.
- If the POST reached the server after the DELETE, a live session cookie
also stayed behind.

The epoch alone can't catch this: a sign-out from a settling or idle
state emits no `account_changed`, so the epoch never moves.

## How

- **Sign-out wins over an in-flight sign-in** (CodeRabbit on Comfy-Org#18871,
Major). `signOut()` bumps a sign-out counter, and `signedIn()` captures
it before the POST. If the counter changed, the new session is:
  - not dispatched and not published;
- deleted again, so no live cookie is left, unless a newer sign-in has
started since (that sign-in owns the cookie now);
- answered as `SESSION_REVOKED`, or with the cleanup's failure if the
DELETE fails.
- **FE-2894: adopt a live session when the remembered-login lookup
throws** (Christian on Comfy-Org#18715). A failed `currentUserId()` used to
discard a successful session read and retry. Now it only matters when
there is no live session. With one, the lookup can skip nothing but the
different-user sign-out, so the session is adopted.
- **CSRF replay re-checks scope after the re-read** (Christian on
Comfy-Org#18716). `stillInScope()` is checked again between the re-read and the
replay, so a request superseded during that round trip is abandoned
rather than replayed.
- **Comments Christian asked for:**
- on `zSharedMessage` (Comfy-Org#18719): the shared host-only cookie is what
licenses trusting a sibling tab's answer;
- in `mint()` (Comfy-Org#18870): the cache check deliberately precedes the
backoff.

## Tests

- **Sign-out during sign-in:** a lifecycle test holds the POST, signs
out, then releases it. It checks that both the tab and its sibling stay
`signed_out`, and that the late session is deleted (`DELETE, POST, GET,
DELETE`).
- **Lookup throws with a live session:** a boot test checks for
`signed_in` with no retry and no local sign-out. The existing test for a
failed lookup with no session (retry) still passes.
- **Overlapping sign-ins:** a stale sign-in released after a newer one
has succeeded sends no DELETE, and the tab stays signed in.
- **Failed cleanup:** when the cleanup DELETE fails, the call answers
`SESSION_UNAVAILABLE` instead of a clean revocation.
- **Scope changes during the re-read:** a transport test checks for
`SUPERSEDED` with no second send.
- **Mutation check:** reverting any of the three fixes turns exactly its
own test red.
- `pnpm --filter @comfyorg/account-core` suite: 1199 passed.
- The cloud auth tests pass, including the flag-off harness
`src/platform/auth/webSessionFlagOff.test.ts`.
- `fallow audit`: no issues in the changed files.

## Flag-off parity

Every change sits on the web session path, which only runs with
`unified_web_session` on. Flag-off behaviour is unchanged, and the
flag-off harness passes.

## AS IS / TO BE

| Case | AS IS | TO BE |
| --- | --- | --- |
| Sign out while an interactive sign-in is in flight | the tab and its
siblings go back to `signed_in`; a cookie may remain | stays signed out;
the late session is deleted |
| Session live, remembered-login lookup throws | discards the session
and retries | adopts the session |
| Scope changes during the CSRF re-read | replays into the old scope |
`SUPERSEDED`, no replay |

This is library logic with no UI of its own; the tests above are the
evidence.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
- Action items:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2894

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | flag (cloud) + website/billing-web readers | C11 cloud#10689
+ BE-17276 probe (readers) | Comfy-Org#18708 merged; readers Comfy-Org#18874, do not merge
|
| FE-2892 | web session client (+ revoke-all follow-up) | C2a
cloud#10589 for revoke-all | Comfy-Org#18710 merged; revoke-all Comfy-Org#18869, do not
merge |
| FE-2893 | ADR | none | Comfy-Org#18707 merged |
| **FE-2894 (this PR)** | identity + boot rules | BE-17063 on testcloud
| Comfy-Org#18715 merged; review follow-ups in this PR |
| FE-2895 | `authorize()` | C5 cloud#10555 | Comfy-Org#18716 merged |
| FE-2897 | lifecycle, heartbeat | FE-2894, C1 | Comfy-Org#18719 merged |
| FE-2900 | lazy token mint from the session | FE-2895, C8 cloud#10585 |
Comfy-Org#18870 merged |
| FE-2901 | non-web clients stay on tokens | — | Comfy-Org#18711 merged (Desktop
checks open) |
| FE-2903 | cloud app joins the lifecycle | FE-2897 | Comfy-Org#18871, do not
merge |
| FE-2904 | cloud API client on `authorize()` | FE-2903, FE-2895, C5 |
Comfy-Org#18875, do not merge |
| FE-2905 | socket + media carry workspace | FE-2904, C6, C7 | Comfy-Org#18878,
do not merge |
| FE-2896 | website header | FE-2891 readers, FE-2894, C11 | Comfy-Org#18877, do
not merge |
| FE-2899 | website credits | FE-2896, FE-2895, C5 | Comfy-Org#18882, do not
merge |
| FE-2898 | billing-web on the session (A identity, B transport) |
FE-2891 readers, FE-2894, FE-2895, C5 | Comfy-Org#18880 + Comfy-Org#18881, do not merge |
| FE-2906 | cross-origin E2E harness | — | Comfy-Org#18718 (harness only) |
| FE-2902 / 2907 / 2908 | platform, rollout, cleanup | other repo / ops
/ after ramp | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2894 thisPr
```

- Blocked by: none: all the code is on main
- Unblocks: none; closes the review notes on Comfy-Org#18715, Comfy-Org#18716, Comfy-Org#18719 and
Comfy-Org#18870, and a CodeRabbit finding on Comfy-Org#18871
github-merge-queue Bot pushed a commit that referenced this pull request Sep 28, 2026
…or website and billing-web (#18874)

> **Do not merge until
[BE-17276](https://linear.app/comfyorg/issue/BE-17276) (C11b) settles
the `web_session_probe` contract.** Until the server sends the key,
every reader resolves to off. Nothing calls these readers yet, so
merging changes no request; the hold is only so the contract can't drift
under them.

## Why

The website and billing-web learn a session visitor's
`unified_web_session` only through C11 (cloud#10689). That means `GET
/api/features` with `credentials: 'include'` and `X-Comfy-Client`, sent
before the site knows the flag. We agreed to gate that request on a
global runtime switch served to anonymous callers, `web_session_probe`
(BE-17276, Maanil). Then the request and its CORS preflight don't exist
until rollout, and turning them off needs no deploy. This PR adds the
readers the website header (FE-2896), website credits (FE-2899) and
billing-web (FE-2898) will use.

## How

- **New entry `@comfyorg/account-core/webSessionFlag`.**
- `readWebSessionProbe`: a plain anonymous `GET /api/features` with no
credentials and no custom headers, so there is no preflight. It is on
only for `web_session_probe === true`.
- `resolveUnifiedWebSession({ probe, … })`: sends the credentialed read
(`credentials: 'include'`, `cache: 'no-store'`, `X-Comfy-Client`) only
when the probe resolves `true`. It returns on only for
`unified_web_session === true`.
- The probe never feeds into the result: it decides whether to ask, and
the per-user answer decides behaviour, so no server state is assembled
on the client.
- Any failure (network, non-2xx, bad body, timeout) is off, and nothing
throws into the apps. Importing the entry is inert, and there are no
browser globals in core.
- **billing-web.** It reads `web_session_probe` from the anonymous
`/api/features` it already fetches for the Firebase config.
- `fetchCloudFeatures` / `resolveWebSessionProbe` in
`@comfyorg/account-core/firebase` share that memoized request; the
timeout must stay 4000 ms to share it.
- With the probe absent or false, billing-web's requests are identical
to main. `readBillingWebUnifiedWebSession()` is cached per page load.
- **website.** It has no anonymous features read today, only the
signed-in Bearer read in `workshop-features.ts`. So its probe is one
plain anonymous GET.
- This is the one accepted flag-off request difference. It is cached per
page load, lazy, and never blocks render.
- The request is only sent once FE-2896 calls
`readUnifiedWebSessionEnabled()`; until then the website is unchanged.
- **`X-Comfy-Client`.** `COMFY_CLIENT` is not on main (it lives in
#18716), so the value is defined once in this module with the same shape
(`name/version`), and a note says it converges with #18716.
- The cloud app is unchanged, and
`src/platform/auth/webSessionFlagOff.test.ts` passes.

## AS IS / TO BE

No UI yet; the evidence is the request tables pinned with `it.for`.

| State | billing-web vs main | website vs main |
| --- | --- | --- |
| probe absent / false / `"true"` | identical | + one plain anonymous
GET |
| probe true, flag false | + one credentialed GET, result off | +
anonymous GET + one credentialed GET, result off |
| probe true, flag true | + one credentialed GET, result on | +
anonymous GET + one credentialed GET, result on |

These rows describe what happens once a consumer calls a reader; nothing
calls one in this PR. The `"true"` string row is covered in the
account-core tests. A second call sends nothing new.

Mutations (each reverted, full suites rerun):

| Mutation | Tests red |
| --- | --- |
| remove the probe gate | core 3, billing-web 3, website 4 |
| add credentials to the probe | core 1, website 4 |
| OR the probe into the result | core 1 |
| drop the cache | billing-web 2, website 4 |
| probe timeout ≠ 4000 on billing-web (breaks the shared fetch) | 5 |
| truthy comparison in `configSource` | 1 |

Checks: vitest passes for account-core 1101, billing-web 198, website
8924 and the flag-off harness 4. Typecheck, oxlint, eslint, oxfmt, knip,
fallow (no issues in 12 files) and `checkPublishable` are all clean.

For review:
- Does ingest check the `X-Comfy-Client` value or only that the header
is present? The value carries the package version.
- If an anonymous features document ever carried the probe but no
Firebase or Stripe fields, the memo would be evicted and refetched. The
eviction rule is unchanged from main.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b (§14
OQ17, §15 C11, §18)
- Action items:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2891 ; backend switch
https://linear.app/comfyorg/issue/BE-17276
- Contract: Comfy-Org/cloud#10689 (C11), BE-17276 (C11b, not yet built)

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| **FE-2891 (this PR)** | flag (cloud) + website/billing-web readers |
C11 cloud#10689 + BE-17276 probe (readers) | #18708 merged; readers
#18874, do not merge |
| FE-2892 | web session client (+ revoke-all follow-up) | C2a
cloud#10589 for revoke-all | #18710 merged; revoke-all #18869, do not
merge |
| FE-2893 | ADR | none | #18707 merged |
| FE-2894 | identity + boot rules | BE-17063 on testcloud | #18715, do
not merge |
| FE-2895 | `authorize()` | C5 cloud#10555 | #18716, do not merge |
| FE-2897 | lifecycle, heartbeat | FE-2894, C1 | #18719, do not merge |
| FE-2900 | lazy token mint from the session | FE-2895, C8 cloud#10585 |
#18870, do not merge |
| FE-2901 | non-web clients stay on tokens | — | #18711 |
| FE-2903 | cloud app joins the lifecycle | FE-2897 | #18871, do not
merge |
| FE-2904 | cloud API client on `authorize()` | FE-2903, FE-2895, C5 |
in progress |
| FE-2905 | socket + media carry workspace | FE-2904, C6, C7 | next |
| FE-2896 / 2899 / 2898 | website header, website credits, billing-web |
FE-2891 readers, FE-2894/2895, C5, C11 | next |
| FE-2906 | cross-origin E2E harness | — | #18718 (harness only) |
| FE-2902 / 2907 / 2908 | platform, rollout, cleanup | other repo / ops
/ after ramp | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2891 thisPr
```

- Blocked by: BE-17276 (probe switch) for the contract; C11 cloud#10689.
- Unblocks: FE-2896 (website header), FE-2899 (website credits), FE-2898
(billing-web).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kashish00208 pushed a commit to kashish00208/ComfyUI_frontend that referenced this pull request Sep 28, 2026
…ified_web_session (1/2) (Comfy-Org#18880)

> **Do not merge.** Part 1 of 2 for FE-2898 (part 2, the transport, is
Comfy-Org#18881, stacked on this). Gated on BE-17276 via the readers (Comfy-Org#18874), on
FE-2894 (Comfy-Org#18715), FE-2895 (Comfy-Org#18716) and C5 cloud#10555. Base is the
readers branch; the diff also shows the FE-2894/FE-2895 merges. This
PR's own change: 9 files, 299 non-test lines.

## Why

billing-web signs in on its own Firebase login and mints a workspace
token. With `unified_web_session` on, a visitor already signed in on
Cloud should be recognised from the shared session without starting
Firebase or signing in again. This part adds the one decision point and
the session-backed identity and sign-in. Part 2 adds the workspace scope
and the credentialed billing transport.

## How

- **`billingWebAuth.ts`: one decision per page load.** It chooses
`session-client` (today's path) or `web-session`.
- The router guard starts the decision but never waits for it. Until the
decision lands, every phase reads `pending`, which is exactly what main
shows while Firebase hasn't answered.
- A probe that is absent or false settles it as soon as the
`/api/features` document arrives. That is the same document Firebase's
config comes from, so Firebase starts at the same moment as on main.
- The session path gets **800 ms**. After that, the page load stays on
today's path, and a late `true` is ignored.
- **`unifiedBillingSession.ts`** boots the FE-2894 identity
(`@comfyorg/account-core/webSessionIdentity`). Firebase is only a lazy
RememberedLogin proof, consulted after the server says there is no
session.
- **Sign-in controller port:** `SignInView` gets a port that follows the
decision. If a Cloud session is found in time, the page is left the same
way a restored login leaves it.
- The router, `App` and `SignInView` are rewired to the decision point.
Entry-workspace rebinding still mints on today's path only.

### Decisions for review
1. **Flag-on first paint.** A visitor with a live Cloud session briefly
sees main's pre-config sign-in screen: disabled buttons and the
"unavailable" notice. It lasts until the decision lands, at most 800 ms,
and then the page leaves it. This is the price of never delaying the
flag-off path.
2. **A different remembered Firebase user is not signed out.** While the
session is live, nothing on billing-web asks Firebase for a token or
mints from `/auth/token`. Identity, scope and every billing request come
only from the session cookie. So a different remembered user has no path
to any request. It is consulted only after the server reports no
session, and a restore goes through the server's silent-restore rules.

## Flag-off parity

`billingWebAuth.flagOff.test.ts` renders `App` with the real router:
- **Features read hangs:** the page is on `/sign-in`, the notice is
shown, and Firebase is not initialised. Same as main.
- **Credentialed flag read hangs:** Firebase is not started at 799 ms
and is started at 800 ms. A late `true` sends no `/api/auth/session` and
doesn't re-initialise Firebase.
- **Probe false:** Firebase is initialised well before the cap.

The request tables are identical to main with the probe absent or false,
and `src/platform/auth/webSessionFlagOff.test.ts` passes.

Timing mutations each go red: no cap, cap at 5000 ms, the guard awaits
the decision, a late `true` swaps the mode, a false probe waits for the
cap.

## AS IS / TO BE

| | AS IS | TO BE |
| --- | --- | --- |
| Flag off | Firebase sign-in | unchanged, same first render and notice
|
| Flag on, live Cloud session | Firebase sign-in form | recognised from
the session in ≤ 800 ms, no Firebase |

Screenshots will be added by editing this description once testcloud
serves the probe.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
- Action items:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2898

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | flag (cloud) + website/billing-web readers | C11 cloud#10689
+ BE-17276 probe (readers) | Comfy-Org#18708 merged; readers Comfy-Org#18874, do not merge
|
| FE-2892 | web session client (+ revoke-all follow-up) | C2a
cloud#10589 for revoke-all | Comfy-Org#18710 merged; revoke-all Comfy-Org#18869, do not
merge |
| FE-2893 | ADR | none | Comfy-Org#18707 merged |
| FE-2894 | identity + boot rules | BE-17063 on testcloud | Comfy-Org#18715, do
not merge |
| FE-2895 | `authorize()` | C5 cloud#10555 | Comfy-Org#18716, do not merge |
| FE-2897 | lifecycle, heartbeat | FE-2894, C1 | Comfy-Org#18719, do not merge |
| FE-2900 | lazy token mint from the session | FE-2895, C8 cloud#10585 |
Comfy-Org#18870, do not merge |
| FE-2901 | non-web clients stay on tokens | — | Comfy-Org#18711 |
| FE-2903 | cloud app joins the lifecycle | FE-2897 | Comfy-Org#18871, do not
merge |
| FE-2904 | cloud API client on `authorize()` | FE-2903, FE-2895, C5 |
Comfy-Org#18875, do not merge |
| FE-2905 | socket + media carry workspace | FE-2904, C6, C7 | Comfy-Org#18878,
do not merge |
| FE-2896 | website header | FE-2891 readers, FE-2894, C11 | Comfy-Org#18877, do
not merge |
| FE-2899 | website credits | FE-2896, FE-2895, C5 | in progress |
| **FE-2898 (this PR)** | billing-web on the session (A identity, B
transport) | FE-2891 readers, FE-2894, FE-2895, C5 | A + B, do not merge
|
| FE-2906 | cross-origin E2E harness | — | Comfy-Org#18718 (harness only) |
| FE-2902 / 2907 / 2908 | platform, rollout, cleanup | other repo / ops
/ after ramp | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2898 thisPr
```

- Blocked by: FE-2891 readers Comfy-Org#18874, FE-2894 Comfy-Org#18715, FE-2895 Comfy-Org#18716, C5
cloud#10555
- Unblocks: M2 billing-web checkout on the shared session

---------

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kashish00208 pushed a commit to kashish00208/ComfyUI_frontend that referenced this pull request Sep 28, 2026
…ession (Comfy-Org#18877)

> **Do not merge.** Gated on BE-17276 (`web_session_probe`) through the
readers in Comfy-Org#18874, and on the FE-2894 identity in Comfy-Org#18715. Base is the
readers branch; the diff also shows the FE-2894 merge. This PR's own
change is 5 files: 154 non-test lines and 390 test lines.

## Why

On the website, a visitor who is already signed in to Cloud through the
shared web session should see that account in the header, without
starting Firebase. Today the header always loads the Firebase account
island. FE-2896 lets the header take the account from the web session
when `unified_web_session` is on for that visitor, and changes nothing
when it is off.

## How

- **`resolveWorkshopAccountSource()`**
(`apps/website/src/config/workshop-web-session-identity.ts`) settles
once per page load to `'session'` or `'firebase'`.
- The probe (Comfy-Org#18874) is absent or false, or the per-user flag is off:
`'firebase'` at once. No session read is sent.
- The flag is on: the FE-2894 identity boots. A live session gives
`'session'` and a signed-out answer gives `'firebase'`.
- **Cap: at most 800 ms.** If the cap fires first, the answer is
`'firebase'` for the page load and the identity is disposed. A late
answer never swaps a mounted header, and a session read is never sent
after the cap.
- **`HeaderMain.vue`**: the async loaders for `HeaderAccount` and
`BuyCreditsDialog` wait for the source. On `'session'` they mount
`HeaderSessionAccount` (an initials chip labelled with the email) and an
empty dialog, so no Firebase island starts.
- **RememberedLogin port**: the proof comes from Firebase only if
Firebase is already loaded. The website never force-loads Firebase to
build a proof.
- **User id**: the Comfy user id is the Firebase uid today (`token.UID`
in cloud `firebase_auth.go`). This holds until Phase 2.5.

### Kept out of this PR
- **Session-mode header**: no menu, sign-out, credits or workspace
switcher. Sign-out is FE-2897. Credits (FE-2899) and the workspace come
next. Asking to buy credits in session mode does nothing until FE-2899.
- **Playground and `/login`**: these still start Firebase. A stale
Firebase login for a different user is signed out only if Firebase was
already loaded when the session answered.
- **SDK follow-up**: `readWebSession` sends no `X-Comfy-Client`. If C5
requires it on `/api/auth/session`, the fix belongs in account-core.

### /models/ script budget

`e2e/models-performance.spec.ts` caps the JavaScript that `/models/`
loads. This PR raises that ceiling from 1,810,000 to 1,815,000 bytes.

- main measures 1,808,088 bytes, 1.9 KB under the old ceiling.
- The header's once-per-page-load session decision ships even with the
flag off: the probe read, the flag read and the 800 ms cap.
- Two changes already moved code behind the flag:
  - the session boot now loads lazily;
- `COMFY_CLIENT`, which inlines the package manifest, now loads only for
the credentialed read.
- With both, this branch measures 1,811,181 bytes in CI (an extra ~3 KB,
down from ~8 KB).
- The catalogue-only delta check (900,000) is unchanged.

## Flag-off parity

- Probe absent or false: the same islands mount, and no
`/api/auth/session` request is sent (`HeaderMain.webSession.test.ts`).
- The header's only new wait is the probe read. It ends when the probe
answers, and it never lasts past 800 ms.
- `src/platform/auth/webSessionFlagOff.test.ts` passes. The cloud app is
not touched.
- Mutation checks: 10 mutations, all red. They include: the cap never
decides, the session boots after the cap, the flag-off path waits for
the cap, the header is ungated, and the boot ignores the flag.

## AS IS / TO BE

| | AS IS | TO BE |
| --- | --- | --- |
| Flag off | Firebase header | Firebase header, unchanged |
| Flag on, live session | Firebase header | Session chip (screenshot to
follow once testcloud serves the probe) |

Screenshots will be added by editing this description.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
- Action items:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2896

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | flag (cloud) + website/billing-web readers | C11 cloud#10689
+ BE-17276 probe (readers) | Comfy-Org#18708 merged; readers Comfy-Org#18874, do not merge
|
| FE-2892 | web session client (+ revoke-all follow-up) | C2a
cloud#10589 for revoke-all | Comfy-Org#18710 merged; revoke-all Comfy-Org#18869, do not
merge |
| FE-2893 | ADR | none | Comfy-Org#18707 merged |
| FE-2894 | identity + boot rules | BE-17063 on testcloud | Comfy-Org#18715, do
not merge |
| FE-2895 | `authorize()` | C5 cloud#10555 | Comfy-Org#18716, do not merge |
| FE-2897 | lifecycle, heartbeat | FE-2894, C1 | Comfy-Org#18719, do not merge |
| FE-2900 | lazy token mint from the session | FE-2895, C8 cloud#10585 |
Comfy-Org#18870, do not merge |
| FE-2901 | non-web clients stay on tokens | — | Comfy-Org#18711 |
| FE-2903 | cloud app joins the lifecycle | FE-2897 | Comfy-Org#18871, do not
merge |
| FE-2904 | cloud API client on `authorize()` | FE-2903, FE-2895, C5 |
Comfy-Org#18875, do not merge |
| FE-2905 | socket + media carry workspace | FE-2904, C6, C7 | next |
| **FE-2896 (this PR)** / 2899 / 2898 | website header (this PR),
website credits, billing-web | FE-2891 readers, FE-2894/2895, C5, C11 |
next |
| FE-2906 | cross-origin E2E harness | — | Comfy-Org#18718 (harness only) |
| FE-2902 / 2907 / 2908 | platform, rollout, cleanup | other repo / ops
/ after ramp | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2896 thisPr
```

- Blocked by: FE-2891 readers Comfy-Org#18874 (BE-17276 probe), FE-2894 Comfy-Org#18715,
BE-17063 on testcloud
- Unblocks: FE-2899 website credits (next, stacked on this branch)

---------

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 28, 2026
…mfy-Org#18871)

> **Stacked on Comfy-Org#18719 (FE-2897) → Comfy-Org#18715 (FE-2894). Do not merge** until
those merge and C1/C3 are on testcloud.

## Why

With `unified_web_session` on, the cloud app must join the shared
session. It creates the session only on a real sign-in, deletes it on
sign-out, boots and heartbeats from it, and resets a tab whose account
changed. It must also stop re-creating the old cookie on every token
refresh, which would undo a sign-out made on another site (TDD §12, §18,
F2). With the flag off, nothing may change.

## How

- New `useCloudWebSessionStore`
(`src/platform/auth/session/cloudWebSessionStore.ts`) wraps
account-core's `createWebSessionIdentity`. Its host adapters:
  - `RememberedLogin`, backed by the Firebase identity;
  - `createWebVisibilityPort()` for the heartbeat;
- `createWebCrossTabRefreshPort<WebSessionResult>()` for the cross-tab
leader.
- **`start()` is the only place that reads the flag.** It reads it once
per page load, on the first call, and returns whether the session is on.
- The first call comes from the workspace gate or the extension's
`onAuthUserResolved`, both of which run after the signed-in
`/api/features` read. So the flag is never read in its anonymous
default.
  - A later flag change applies on the next page load.
- **Flag on**, the existing `useSessionCookie` entry points switch over:
- `createSession` (called on user-resolved and on token refresh) starts
the lifecycle and sends nothing, so the re-create-on-refresh behaviour
is gone.
  - `ensureSessionCookie` waits for the lifecycle to be ready.
- `deleteSession` does nothing, because sign-out is owned by
`authStore.logout` → `signOut()` → DELETE.
- `createSessionOrThrow` (OAuth resume, consent redirect) waits only if
the lifecycle is already active.
- `login`, `register`, `loginWithGoogle` and `loginWithGithub` call
`signedInInteractively`, the only thing that creates a session.
- **Account change.** The store clears the workspace selection, resets
the team workspace store and the socket, and, only when the account
became a different user, shows the `auth.accountChanged` notice (a
notice, not a confirm, per open question 11).
- Until FE-2904 moves the API client onto the session, the app still
needs a Firebase login. So a different user ends in a signed-out page,
not an in-place switch, and the copy does not promise a switch.
- **Flag off.** `start()` returns false, every entry point falls through
to today's code, and `webSessionFlagOff.test.ts` is unchanged and passes
(4/4).
- **For review: user id equality.** `currentUserId` returns the Firebase
uid, which equals `comfy_user_id` today (cloud's Phase 2 invariant in
`identity_resolution.go`). Cloud names a Phase 2.5 where they can
diverge; the boot rule would then sign out a valid login, so the adapter
must change before that phase.

## AS IS / TO BE

No UI change with the flag off. With the flag on, the evidence is
`webSessionFlagOn.test.ts`:

| Scenario | Result |
| --- | --- |
| interactive sign-in | one session POST |
| token refresh | no session request |
| sign-out | one DELETE |
| boot, 200 same user | GET only |
| boot, 200 different user | local Firebase sign-out |
| boot, 401 `session_revoked` | signed out, no restore |
| boot, 401 `no_session` | one restore |
| heartbeat sees a different user | socket and workspace reset, plus the
notice |

Nine mutations, each reverted with the full suite rerun, all go red,
including "ignore the flag", which turns 4 flag-off rows red.

Checks:
- vitest over auth, stores, extensions, cloud and workspace: 5172 tests
pass.
- account-core: 1114 tests pass.
- typecheck, knip, lint and fallow are clean.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
(sections 12, 15 F2, 18)
- Action items:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2903

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | flag (cloud) + website/billing-web readers | C11 cloud#10689
+ probe switch (readers) | Comfy-Org#18708 merged; readers in progress |
| FE-2892 | web session client (+ revoke-all follow-up) | C2a
cloud#10589 for revoke-all | Comfy-Org#18710 merged; revoke-all Comfy-Org#18869, do not
merge |
| FE-2893 | ADR | none | Comfy-Org#18707 merged |
| FE-2894 | identity + boot rules | BE-17063 on testcloud | Comfy-Org#18715, do
not merge |
| FE-2895 | `authorize()` | C5 cloud#10555 | Comfy-Org#18716, do not merge |
| FE-2897 | lifecycle, heartbeat | FE-2894, C1 | Comfy-Org#18719, do not merge |
| FE-2900 | lazy token mint from the session | FE-2895, C8 cloud#10585 |
Comfy-Org#18870, do not merge |
| FE-2901 | non-web clients stay on tokens | — | Comfy-Org#18711 |
| **FE-2903 (this PR)** | cloud app joins the lifecycle | FE-2897 |
Comfy-Org#18871, do not merge |
| FE-2904 | cloud API client on `authorize()` | FE-2903, FE-2895, C5 |
in progress |
| FE-2905 | socket + media carry workspace | FE-2904, C6, C7 | next |
| FE-2896 / 2899 / 2898 | website header, website credits, billing-web |
FE-2891 readers, FE-2894/2895, C5, C11 | next |
| FE-2906 | cross-origin E2E harness | — | Comfy-Org#18718 (harness only) |
| FE-2902 / 2907 / 2908 | platform, rollout, cleanup | other repo / ops
/ after ramp | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2903 thisPr
```

- Blocked by: Comfy-Org#18719 (FE-2897), Comfy-Org#18715 (FE-2894), C1/C3 on testcloud.
- Unblocks: FE-2904 (API client on the session), then FE-2905; FE-2906
rows E2E-02/05.

---------

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
ksanislo pushed a commit to ksanislo/ComfyUI_frontend that referenced this pull request Sep 29, 2026
…e shared web session (2/2) (Comfy-Org#18881)

> **Do not merge.** Part 2 of 2 for FE-2898, stacked on part 1 Comfy-Org#18880
(identity and sign-in gating). Gated on C5 cloud#10555. 11 files, 224
non-test lines.

## Why

Part 1 recognises a Cloud session on billing-web. This part gives that
session a workspace scope and sends billing requests on the cookie, so
the flag-on path never mints a workspace token.

## How

- **Workspace lookup:** `GET /workspaces/current` is authorized with
`authorize()` from FE-2895.
- The request uses `credentials: 'include'`, `X-Comfy-Client`, and
`X-Comfy-Workspace-ID` from the entry link's bound workspace. Absent
means personal.
  - The phase is `authenticated` only once that lookup succeeds.
- **Refusals from C5:**
  - `workspace_access_denied` → `ACCESS_DENIED`
  - `workspace_id_invalid` → `WORKSPACE_NOT_FOUND`
  - 401 → `NOT_AUTHENTICATED`
  - Anything else maps to the existing `TOKEN_EXCHANGE_FAILED`.
- **Billing client:** `createWebSessionBillingClient` uses
`createCredentialedBillingTransport` (`@comfyorg/account-core/billing`,
opt-in `webSession` from Comfy-Org#18716). Its `getWorkspaceToken` rejects:
billing-web never mints on this path.
- **UI:** `BillingShell`, `HostedSurface` and `useBilledWorkspace` read
the scope from the decision point. On a refusal, `SignInView` shows the
refusal copy.

### Decisions for review
1. **A refused workspace hides the sign-in form.** The visitor is signed
in, but the entry names a workspace they can't use. Signing in again
wouldn't fix that, so the page shows only the refusal.
2. **The role defaults to `member`** when `/workspaces/current` omits
it. That is the least privilege; the server still enforces every write.
3. **The transport may re-read the session.** When the credentialed
transport has a request refused, it re-reads the session
(`readWebSession` with `expectedUserId`) before failing. That can add a
`GET /api/auth/session` on a refusal.

## Flag-off parity

The flag-off path doesn't reach any of this: the mode is
`session-client` and the existing token client is unchanged. The part 1
flag-off pin, including its timing tests, passes here unchanged, and so
does `src/platform/auth/webSessionFlagOff.test.ts`.

The flag-on tests (SS1, SS6, SO4) cover:
- the exact headers and credentials on the workspace lookup and on
billing requests;
- no `Authorization` header and no `/api/auth/token`;
- refusal copy per code.

## AS IS / TO BE

| Flag on | AS IS | TO BE |
| --- | --- | --- |
| Billing requests | `Authorization: Bearer <workspace token>` | cookie
+ `X-Comfy-Workspace-ID`, no token |
| Entry workspace refused | sign-in form | refusal copy, no form |

Screenshots will be added by editing this description once testcloud
serves C5.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
- Action items:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2898

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | flag (cloud) + website/billing-web readers | C11 cloud#10689
+ BE-17276 probe (readers) | Comfy-Org#18708 merged; readers Comfy-Org#18874, do not merge
|
| FE-2892 | web session client (+ revoke-all follow-up) | C2a
cloud#10589 for revoke-all | Comfy-Org#18710 merged; revoke-all Comfy-Org#18869, do not
merge |
| FE-2893 | ADR | none | Comfy-Org#18707 merged |
| FE-2894 | identity + boot rules | BE-17063 on testcloud | Comfy-Org#18715, do
not merge |
| FE-2895 | `authorize()` | C5 cloud#10555 | Comfy-Org#18716, do not merge |
| FE-2897 | lifecycle, heartbeat | FE-2894, C1 | Comfy-Org#18719, do not merge |
| FE-2900 | lazy token mint from the session | FE-2895, C8 cloud#10585 |
Comfy-Org#18870, do not merge |
| FE-2901 | non-web clients stay on tokens | — | Comfy-Org#18711 |
| FE-2903 | cloud app joins the lifecycle | FE-2897 | Comfy-Org#18871, do not
merge |
| FE-2904 | cloud API client on `authorize()` | FE-2903, FE-2895, C5 |
Comfy-Org#18875, do not merge |
| FE-2905 | socket + media carry workspace | FE-2904, C6, C7 | Comfy-Org#18878,
do not merge |
| FE-2896 | website header | FE-2891 readers, FE-2894, C11 | Comfy-Org#18877, do
not merge |
| FE-2899 | website credits | FE-2896, FE-2895, C5 | in progress |
| **FE-2898 (this PR: B)** | billing-web on the session (A identity, B
transport) | FE-2891 readers, FE-2894, FE-2895, C5 | A + B, do not merge
|
| FE-2906 | cross-origin E2E harness | — | Comfy-Org#18718 (harness only) |
| FE-2902 / 2907 / 2908 | platform, rollout, cleanup | other repo / ops
/ after ramp | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2898 thisPr
```

- Blocked by: FE-2891 readers Comfy-Org#18874, FE-2894 Comfy-Org#18715, FE-2895 Comfy-Org#18716, C5
cloud#10555
- Unblocks: M2 billing-web checkout on the shared session

---------

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ksanislo pushed a commit to ksanislo/ComfyUI_frontend that referenced this pull request Sep 29, 2026
…fy-Org#18882)

> **Do not merge.** Stacked on FE-2896 (Comfy-Org#18877) with the FE-2895
(Comfy-Org#18716) merge, and gated on C5 cloud#10555. The diff also shows the
fe-2895 merge. This PR's own change is 7 files, about 160 non-test
lines.

## Why

In FE-2896's session mode, the website header shows the account but no
credit balance, because the balance read needs a minted workspace token.
This is the first consumer of `authorize()` on the session. It proves
the cookie path end to end on a read, with no workspace token in page
memory.

## How

- **`workshop-session-balance.ts`**: `readSessionBalance(session,
fetchImpl)` sends `GET /api/billing/balance` through
`createRequestAuthorizer(...)` → `authorize({ kind: 'session', session
}, { target: 'ingest', method: 'GET' })`.
- The request carries `credentials: 'include'` and `X-Comfy-Client`. It
has no `Authorization` and no workspace header, which means personal.
- The authorizer's `getWorkspaceToken` always rejects, so this path can
never mint a token.
- The result is one of `ok`, `unavailable`, `session_ended` or
`unknown`.
- **`useWorkshopSessionBalance`**: one shared state per page. It reads
once, again on window focus, and never again after a 401. The header
mounts twice (desktop and mobile) but sends one request.
- **`HeaderSessionAccount.vue`** shows a credits chip, styled like the
Firebase one, only when the state is `ok`.
- **The decision is FE-2896's.** `useWorkshopWebSession()` keeps the
whole `WebSession`, and this module is loaded only when
`resolveWorkshopAccountSource()` answered `'session'`. There is no new
flag read.
- **`X-Comfy-Client` is converged:** `webSessionFlag` (readers, Comfy-Org#18874)
now imports `COMFY_CLIENT` from requestAuth instead of keeping its own
copy.
- The Firebase balance reader (`workshop-balance.ts`) is untouched. The
session module keeps its own short copy of the balance-body parse, so
the Firebase path's code and requests are identical to main.

### Decisions for review
1. **Workspace.** Session mode reads the personal workspace. The session
header has no workspace picker, and the Firebase selection lives in a
minted token that doesn't exist here. Nothing is derived from other
server data.
2. **Refusals.** C5 403s (`origin_not_allowed`,
`workspace_access_denied`, `csrf_invalid`, `cross_site_request`), a 400
`workspace_id_invalid`, 5xx, and network or body errors all hide the
balance. It is read again on the next focus. A 401 hides it and stops
reading. Neither case signs anyone out; sign-out stays with the identity
module.
3. **Out of scope:**
- Buying credits and the top-up watch: `BuyCreditsDialog` is still empty
in session mode.
   - Workspace switching.
   - Refreshing the balance after a run.
- The balance on `ModelDetail`, which still calls `useWorkshopCredits`
and can start Firebase session state in session mode. That is a
follow-up, and it also touches FE-2896's "no Firebase on comfy.org"
criterion.

## Flag-off parity

- The request-table test (`it.for`) pins both sources:
- Firebase: exactly `{ authorization: 'Bearer …' }`, with no
`credentials`.
- Session: exactly `{ x-comfy-client }`, with `credentials: 'include'`,
one request and no workspace header.
- The HeaderMain request list now records `Authorization` and
`X-Comfy-Client` on every request. The flag-off rows are unchanged. The
live-session row adds only the balance read, with no `Authorization` and
no `/api/auth/token`.
- `src/platform/auth/webSessionFlagOff.test.ts` passes.
- Mutations, each red:
  - always use the session header;
  - drop `credentials`;
  - add `Authorization`;
  - mint a token;
  - send `X-Comfy-Workspace-ID`;
  - treat a 403 as a 401;
  - keep reading after a 401.

## End-to-end coverage

No `apps/website/e2e/` spec is added. The credits balance only renders
when `unified_web_session` is on and a real `__Host-comfy_session`
cookie from Cloud ingest is present. The website Playwright suite serves
a static build with no Cloud backend and blocks cross-origin requests,
so it cannot hold that session. The cross-origin session flow is covered
by the `playwright.session.config.ts` harness (Comfy-Org#18718), which runs
against staging. The flag-off path, which is what every visitor sees
today, is unchanged, and the existing website e2e suite covers it. The
balance behaviour itself (read on sign-in, clear on sign-out, stale
reads ignored across a same-user sign-out and sign-in) is pinned in
`workshop-session-balance.test.ts`.

## AS IS / TO BE

| Session mode | AS IS | TO BE |
| --- | --- | --- |
| Header | account chip, no balance | account chip + credits chip from
the cookie read |
| Flag off | Firebase header + balance | unchanged |

Screenshots will be added by editing this description once testcloud
serves C5.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
- Action items:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2899

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | flag (cloud) + website/billing-web readers | C11 cloud#10689
+ BE-17276 probe (readers) | Comfy-Org#18708 merged; readers Comfy-Org#18874, do not merge
|
| FE-2892 | web session client (+ revoke-all follow-up) | C2a
cloud#10589 for revoke-all | Comfy-Org#18710 merged; revoke-all Comfy-Org#18869, do not
merge |
| FE-2893 | ADR | none | Comfy-Org#18707 merged |
| FE-2894 | identity + boot rules | BE-17063 on testcloud | Comfy-Org#18715, do
not merge |
| FE-2895 | `authorize()` | C5 cloud#10555 | Comfy-Org#18716, do not merge |
| FE-2897 | lifecycle, heartbeat | FE-2894, C1 | Comfy-Org#18719, do not merge |
| FE-2900 | lazy token mint from the session | FE-2895, C8 cloud#10585 |
Comfy-Org#18870, do not merge |
| FE-2901 | non-web clients stay on tokens | — | Comfy-Org#18711 |
| FE-2903 | cloud app joins the lifecycle | FE-2897 | Comfy-Org#18871, do not
merge |
| FE-2904 | cloud API client on `authorize()` | FE-2903, FE-2895, C5 |
Comfy-Org#18875, do not merge |
| FE-2905 | socket + media carry workspace | FE-2904, C6, C7 | Comfy-Org#18878,
do not merge |
| FE-2896 | website header | FE-2891 readers, FE-2894, C11 | Comfy-Org#18877, do
not merge |
| **FE-2899 (this PR)** | website credits | FE-2896, FE-2895, C5 | this
PR, do not merge |
| FE-2898 | billing-web on the session (A identity, B transport) |
FE-2891 readers, FE-2894, FE-2895, C5 | Comfy-Org#18880 + Comfy-Org#18881, do not merge |
| FE-2906 | cross-origin E2E harness | — | Comfy-Org#18718 (harness only) |
| FE-2902 / 2907 / 2908 | platform, rollout, cleanup | other repo / ops
/ after ramp | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2899 thisPr
```

- Blocked by: FE-2896 Comfy-Org#18877, FE-2895 Comfy-Org#18716, C5 cloud#10555
- Unblocks: Session-mode buy credits and workspace picker (follow-up)

---------

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ksanislo pushed a commit to ksanislo/ComfyUI_frontend that referenced this pull request Sep 29, 2026
…itch without a mint (Comfy-Org#18875)

> **Stacked on Comfy-Org#18871 (FE-2903) and includes a merge of Comfy-Org#18716 (FE-2895,
`authorize()`). Do not merge** until those merge and C5 (BE-17066,
cloud#10555) is on testcloud. My change is the last commit
(`e7085c16e7`); the diff also shows the FE-2895 merge until Comfy-Org#18716
lands.

## Why

With `unified_web_session` on, the cloud app should call ingest on the
session cookie instead of a token (TDD §9, §12, F4). That means the
headers come from `authorize()`, switching workspace changes a header
instead of minting a token, and the one automatic retry is tied to the
user and workspace the request started for. With the flag off, nothing
may change.

## How

- **One decision point.** `src/platform/auth/session/webSessionFetch.ts`
is a registration slot the cloud session store (FE-2903) fills in
`start()` when the session is on, and clears on dispose.
- `api.ts`, `workspaceAuthStore` and `authStore` check it synchronously.
When the slot is empty the code runs exactly as today.
- A slot rather than importing the store avoids two import cycles that
fallow flagged.
- **`api.fetchApi`.** When the session is on and signed in, the request
goes through `fetchOnWebSession`, which takes its headers from
`authorize()`:
  - `X-Comfy-Client` on every request.
- `X-Comfy-Workspace-ID` only for a team workspace (absent means
personal).
  - `X-CSRF-Token` on POST, PUT, PATCH and DELETE.
  - `credentials: 'include'` and no `Authorization` header.

Otherwise the unchanged token path runs; it is moved verbatim into
`addCloudAuthHeader` to keep `fetchApi` under fallow's complexity limit.
- **Retries.**
- `csrf_invalid`: one re-read of the session, pinned to the same user,
then one retry in the same workspace, only if the user and session epoch
are unchanged. Otherwise the original 403 is returned. Later requests
reuse the fresh token, and a streaming body is never replayed.
- `workspace_access_denied`: the selection is dropped through the
existing revoked-workspace path, and the request is never replayed in
another workspace.
- **Workspace switch.** With the session on, the switch calls `GET
/api/workspaces/current` with the workspace header and stores id, name,
type and role. It mints no token. With no signed-in session it falls
back to today's switch.
- **`authStore.getAuthHeader`.** With the session on, it returns the
user's Firebase or API-key header instead of minting a workspace token,
so the router's check on every navigation no longer mints.
- **Not in this PR:**
- Other ingest callers: `workspaceApi` (axios), remote widgets and agent
consent stay on today's tokens.
- With the flag on, remote widgets resolve to the personal workspace.
This is a flag-on-only gap; moving the axios clients onto `authorize()`
is a proposed follow-up.
- WebSocket and media URLs are FE-2905. The comfy-api session mint is
FE-2900.
  - `permissions` are not stored, since nothing reads them yet.

## AS IS / TO BE

Flag off: `src/platform/auth/webSessionFlagOff.test.ts` is
byte-identical to the base and passes. The full `src` and account-core
vitest run is 1620 files, 23152 tests.

Flag on: `webSessionFlagOn.test.ts` gains five cases.
- **Boot into a remembered team workspace.** The GET carries the client
and workspace headers with `include` and no `Authorization`. The POST
adds CSRF. `getAuthHeader` returns the Firebase header. Switching to
personal changes only the header, and `/api/auth/token` is never called.
- **`csrf_invalid`, same user.** One re-read, then one retry, and later
requests use the fresh token.
- **`csrf_invalid` after the user changed.** The request is abandoned.
- **`workspace_access_denied`.** The selection is dropped, and the
request is not replayed.
- **A switch into a refused workspace** throws.

Eleven mutations were each reverted with the full suites rerun, and all
went red:

| Mutation |
| --- |
| no CSRF retry |
| the re-read ignores the user |
| denied workspace not dropped |
| workspace header sent for the personal workspace |
| `fetchApi` ignores the session |
| request method dropped |
| fresh CSRF token not reused |
| the switch mints a token |
| `getAuthHeader` mints a token |
| session never registered |
| denied request replayed in another workspace |

Checks: typecheck, eslint, oxlint, oxfmt and knip are clean, and fallow
reports 0 new findings against the FE-2903 branch.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
(sections 9, 12, F4)
- Action items:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2904
- Contract: Comfy-Org/cloud#10555 (C5)

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | flag (cloud) + website/billing-web readers | C11 cloud#10689
+ BE-17276 probe (readers) | Comfy-Org#18708 merged; readers Comfy-Org#18874, do not merge
|
| FE-2892 | web session client (+ revoke-all follow-up) | C2a
cloud#10589 for revoke-all | Comfy-Org#18710 merged; revoke-all Comfy-Org#18869, do not
merge |
| FE-2893 | ADR | none | Comfy-Org#18707 merged |
| FE-2894 | identity + boot rules | BE-17063 on testcloud | Comfy-Org#18715, do
not merge |
| FE-2895 | `authorize()` | C5 cloud#10555 | Comfy-Org#18716, do not merge |
| FE-2897 | lifecycle, heartbeat | FE-2894, C1 | Comfy-Org#18719, do not merge |
| FE-2900 | lazy token mint from the session | FE-2895, C8 cloud#10585 |
Comfy-Org#18870, do not merge |
| FE-2901 | non-web clients stay on tokens | — | Comfy-Org#18711 |
| FE-2903 | cloud app joins the lifecycle | FE-2897 | Comfy-Org#18871, do not
merge |
| **FE-2904 (this PR)** | cloud API client on `authorize()` | FE-2903,
FE-2895, C5 | Comfy-Org#18875, do not merge |
| FE-2905 | socket + media carry workspace | FE-2904, C6, C7 | next |
| FE-2896 / 2899 / 2898 | website header, website credits, billing-web |
FE-2891 readers, FE-2894/2895, C5, C11 | next |
| FE-2906 | cross-origin E2E harness | — | Comfy-Org#18718 (harness only) |
| FE-2902 / 2907 / 2908 | platform, rollout, cleanup | other repo / ops
/ after ramp | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2904 thisPr
```

- Blocked by: Comfy-Org#18871 (FE-2903) and Comfy-Org#18716 (FE-2895); C5 cloud#10555 on
testcloud.
- Unblocks: FE-2905 (socket and media), FE-2906 rows E2E-03/06 and
FS-13/14.

---------

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
laurigates pushed a commit to laurigates/ComfyUI_frontend that referenced this pull request Sep 29, 2026
…space (Comfy-Org#18878)

> **Do not merge.** Stacked on FE-2904 (Comfy-Org#18875) and gated on C6
cloud#10583 (+Comfy-Org#10699) and C7 cloud#10584 (+Comfy-Org#10698). The diff is 6 files:
about 125 non-test lines.

## Why

With `unified_web_session` on, API requests already travel on the
session cookie with `X-Comfy-Workspace-ID` (FE-2904). Two surfaces can't
carry that header:
- the WebSocket handshake;
- media URLs loaded by `<img>` / `<video>` tags.

Without this PR they would still need a minted token in the URL, and
they would read the personal workspace in a team. C6 and C7 let both
accept the cookie and a `?workspace_id=` query parameter instead.

## How

Everything hangs off the single registration slot `webSessionRequests()`
from FE-2904. There is no second flag read.

- **`WebSessionRequests.workspaceId()`** returns the team workspace id
only while the tab is signed in on the session. Otherwise it returns
nothing, which means personal.
- **Socket (`api.ts`):** the auth params come from a private
`addSocketAuth(params)`.
- Signed in on the session: no `token`. `workspace_id` is set for a team
and left out for personal.
  - No session: today's token code, moved as is.
  - With the flag on, no session and no token, no socket opens.
- **Reconnect:**
- `api.reconnectSocket()` re-handshakes and keeps the client id.
`resetSocket()` still clears the ids, and both share `replaceSocket()`.
- `cloudWebSessionStore` watches the signed-in user and the team
workspace, and reconnects on any change while signed in. There is no
token mint.
- **Media URLs:** `apiURL()` passes the media routes through
`scopeMediaRoute`, which adds `workspace_id` for a team and never
duplicates it. The routes are `/view`, `/viewvideo`, `/vhs/viewvideo`,
`/vhs/viewaudio` and `/assets/:id/content`, with or without an `/api`
prefix.

### Decisions for review
1. **Flag on and signed out: no socket.** Today a tokenless `/ws` keeps
reopening. One gap is covered only by a reload: the flag is on, the
session was never created, and Firebase signs in again in the same page.
2. **A removed team member's socket retries every 300 ms.** It stops
when the next API call gets `workspace_access_denied`, which drops the
workspace and reconnects in personal. That matches today's token-socket
loop, and no probe request is added.
3. **A Cloud workspace switch may open one extra short-lived socket**
before the reload. The newer socket wins and the older one is closed.
4. **Not scoped:** literal `api/view` strings that don't go through
`apiURL` (`useWidgetSelectItems.getMediaUrl`, `LoaderManager`,
`BackgroundImageUpload`), and server-supplied `preview_url`s. These fall
back to C7's cross-workspace lookup. Moving them onto `apiURL` would
change the flag-off output, so it is left for a follow-up.
5. **Header or query, never both.** `fetchApi` names the workspace only
in `X-Comfy-Workspace-ID`, and its URL skips `scopeMediaRoute`. The
query is only for URLs that tags load without headers. A test pins that
a session media fetch sends the header and a bare URL, and it goes red
if `fetchApi` goes back to the scoped URL.

## Flag-off parity

- With the slot empty, `apiURL` returns the route unchanged, and the
socket runs today's token code. `addSocketAuth` returns true, as before.
- The shared harness `src/platform/auth/webSessionFlagOff.test.ts` is
extended, not loosened. It now also pins `/api/viewvideo…`,
`/api/vhs/viewaudio…` and `/api/assets/:id/content`, because `apiURL` is
on their path.
- Mutation checks, all red: drop `workspace_id` from the socket, keep
the token on the session, open a socket while signed out, remove the
workspace reconnect, leave media unscoped.

## AS IS / TO BE

| Flag on, team workspace | AS IS | TO BE |
| --- | --- | --- |
| Socket | `/ws?token=<minted>` | `/ws?workspace_id=<team>` on the
cookie |
| Media URL | `/api/view?filename=…` (personal) |
`/api/view?filename=…&workspace_id=<team>` |
| Flag off | unchanged | unchanged |

Network screenshots will be added by editing this description once
testcloud serves C6/C7.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
- Action items:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2905

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | flag (cloud) + website/billing-web readers | C11 cloud#10689
+ BE-17276 probe (readers) | Comfy-Org#18708 merged; readers Comfy-Org#18874, do not merge
|
| FE-2892 | web session client (+ revoke-all follow-up) | C2a
cloud#10589 for revoke-all | Comfy-Org#18710 merged; revoke-all Comfy-Org#18869, do not
merge |
| FE-2893 | ADR | none | Comfy-Org#18707 merged |
| FE-2894 | identity + boot rules | BE-17063 on testcloud | Comfy-Org#18715, do
not merge |
| FE-2895 | `authorize()` | C5 cloud#10555 | Comfy-Org#18716, do not merge |
| FE-2897 | lifecycle, heartbeat | FE-2894, C1 | Comfy-Org#18719, do not merge |
| FE-2900 | lazy token mint from the session | FE-2895, C8 cloud#10585 |
Comfy-Org#18870, do not merge |
| FE-2901 | non-web clients stay on tokens | — | Comfy-Org#18711 |
| FE-2903 | cloud app joins the lifecycle | FE-2897 | Comfy-Org#18871, do not
merge |
| FE-2904 | cloud API client on `authorize()` | FE-2903, FE-2895, C5 |
Comfy-Org#18875, do not merge |
| **FE-2905 (this PR)** | socket + media carry workspace | FE-2904, C6,
C7 | this PR, do not merge |
| FE-2896 | website header | FE-2891 readers, FE-2894, C11 | Comfy-Org#18877, do
not merge |
| FE-2899 / 2898 | website credits, billing-web | FE-2896, FE-2895, C5 |
next |
| FE-2906 | cross-origin E2E harness | — | Comfy-Org#18718 (harness only) |
| FE-2902 / 2907 / 2908 | platform, rollout, cleanup | other repo / ops
/ after ramp | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2905 thisPr
```

- Blocked by: FE-2904 Comfy-Org#18875, C6 cloud#10583 (+Comfy-Org#10699), C7 cloud#10584
(+Comfy-Org#10698)
- Unblocks: FE-2907 rollout: the cloud app's socket and media are
covered

---------

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
github-merge-queue Bot pushed a commit that referenced this pull request Sep 29, 2026
…e-all contract (#18869)

> cloud#10589 (BE-17064 C2a, `POST /api/auth/sessions/revoke-all`) is
merged and #18926 synced its generated schema; this PR validates against
it.

## Why

`revokeAllWebSessions` was held out of #18710 in review: the route had
no contract, and the old version accepted any 2xx, which is the worst
lie this client could tell (the caller would believe every device is
signed out). cloud#10589 now defines the route and its response, so it
comes back validated.

## How

- `revokeAllWebSessions(options, csrfToken, getIdentityProof)`: `POST
/auth/sessions/revoke-all` with `credentials: 'include'`,
`Authorization: Bearer <proof>` and `X-CSRF-Token`.
- The contract authenticates this route with the Firebase ID token only
(`security: BearerAuth`). Accepting the cookie is a listed backend
follow-up in cloud#10696.
- The CSRF header and credentials are sent now so the cookie path works
when that follow-up lands.
- The 200 body is validated against `RevokeAllSessionsResponse` (`{
revoked: integer }`), the generated `zRevokeAllSessionsResponse` from
`@comfyorg/ingest-types/zod` (cloud#10589, synced by #18926).
- A 2xx that fails the schema (empty 204, `{}`, wrong types, HTML) is
`SESSION_UNAVAILABLE` and retryable; it is never reported as ok.
  - Non-2xx goes through the existing classifier.
- The testing fake serves the route. It checks the bearer, then a dead
session, then CSRF; a successful call revokes the session.
- Nothing in any app calls it yet, so the flag-off request harness is
unchanged (4/4).

## AS IS / TO BE

No UI; the evidence is tests.

- AS IS: no revoke-all client.
- TO BE: status-mapping rows, credentials, bearer and CSRF headers, six
schema-failing 2xx bodies (all transient), a stale CSRF token →
`CSRF_STALE`, and a successful revoke followed by `SESSION_REVOKED` on
the next read.

Mutations (each reverted, full suite rerun):

| Mutation | Tests red |
| --- | --- |
| accept any 2xx without validation | 6 |
| drop CSRF | 2 |
| drop credentials | 4 |
| drop Bearer | 3 |

account-core 1083 tests pass; typecheck, lint, knip and fallow are
clean.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
(sections 7, 9)
- Action items:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2892
- Contract: Comfy-Org/cloud#10589, Comfy-Org/cloud#10696

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | flag (cloud) + website/billing-web readers | C11 cloud#10689
+ probe switch (readers) | #18708 merged; readers in progress |
| **FE-2892 (this PR)** | web session client (+ revoke-all follow-up) |
C2a cloud#10589 (merged) | #18710 merged; revoke-all #18869 ready for
review |
| FE-2893 | ADR | none | #18707 merged |
| FE-2894 | identity + boot rules | BE-17063 on testcloud | #18715, do
not merge |
| FE-2895 | `authorize()` | C5 cloud#10555 | #18716, do not merge |
| FE-2897 | lifecycle, heartbeat | FE-2894, C1 | #18719, do not merge |
| FE-2900 | lazy token mint from the session | FE-2895, C8 cloud#10585 |
#18870, do not merge |
| FE-2901 | non-web clients stay on tokens | — | #18711 |
| FE-2903 | cloud app joins the lifecycle | FE-2897 | #18871, do not
merge |
| FE-2904 | cloud API client on `authorize()` | FE-2903, FE-2895, C5 |
in progress |
| FE-2905 | socket + media carry workspace | FE-2904, C6, C7 | next |
| FE-2896 / 2899 / 2898 | website header, website credits, billing-web |
FE-2891 readers, FE-2894/2895, C5, C11 | next |
| FE-2906 | cross-origin E2E harness | — | #18718 (harness only) |
| FE-2902 / 2907 / 2908 | platform, rollout, cleanup | other repo / ops
/ after ramp | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2892 thisPr
```

- Blocked by: none (cloud#10589 and #18926 merged).
- Unblocks: FE-2897 host wiring for "sign out of all devices"; FE-2906
E2E-07.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cloud/1.55 Backport PRs for cloud 1.55 core/1.55 Backport PRs for core 1.55 risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants