Skip to content

[backport cloud/1.54] fix: render widgets on insert_workflow-materialized nodes - #18601

Merged
comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-18598-to-cloud-1.54
Sep 23, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-18598-to-cloud-1.54

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #18598 to cloud/1.54

Automatically created by backport workflow.

@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 23, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 23, 2026 11:52
@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 12:29pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/23/2026, 12:31:28 PM UTC

Links

🎭 Playwright: ✅ 1945 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1924 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 7ms TBT · 76.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 130ms TBT · 101.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.2 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.3 MB heap
vue-large-graph-pan: · 54.6 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 176ms TBT · 167.0 MB heap
vue-node-resize-workload: · 54.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 522ms TBT · 170.9 MB heap
vue-zoom-out-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 9ms TBT · 175.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 535ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 69.8 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -180
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 30ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 879ms
canvas-mouse-sweep: script duration 150ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 63.6 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -196
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 345ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.4 MB
canvas-zoom-sweep: DOM nodes 75
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 445ms
dom-widget-clipping: script duration 156ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.3 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 609ms
large-graph-idle: script duration 32ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.6 MB
large-graph-idle: DOM nodes -269
large-graph-idle: event listeners -178
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1661ms
large-graph-pan: script duration 827ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 79.7 MB
large-graph-pan: DOM nodes -261
large-graph-pan: event listeners -193
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1728ms
large-graph-zoom: script duration 787ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.6 MB
large-graph-zoom: DOM nodes -280
large-graph-zoom: event listeners -91
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1917ms
legacy-node-drag: script duration 972ms
legacy-node-drag: TBT 7ms
legacy-node-drag: heap used 76.4 MB
legacy-node-drag: DOM nodes 4
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 588ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.9 MB
minimap-idle: DOM nodes -276
minimap-idle: event listeners -95
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 401ms
subgraph-dom-widget-clipping: script duration 140ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.6 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 486ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 68.0 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 27ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 793ms
subgraph-mouse-sweep: script duration 105ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 73.0 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -212
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 911ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 130ms
subgraph-transition-enter: heap used 101.6 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 40ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5654ms
viewport-pan-sweep: script duration 2595ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 79.2 MB
viewport-pan-sweep: DOM nodes -278
viewport-pan-sweep: event listeners -178
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17359ms
vue-large-graph-idle: script duration 303ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.3 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14934
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 22ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 178
vue-large-graph-pan: task duration 22504ms
vue-large-graph-pan: script duration 941ms
vue-large-graph-pan: TBT 176ms
vue-large-graph-pan: heap used 167.0 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14931
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 76ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6405ms
vue-node-resize-workload: script duration 119ms
vue-node-resize-workload: TBT 522ms
vue-node-resize-workload: heap used 170.9 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14930
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8904ms
vue-zoom-out-idle: script duration 182ms
vue-zoom-out-idle: TBT 9ms
vue-zoom-out-idle: heap used 175.4 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 3
workflow-execution: style recalc count 10
workflow-execution: task duration 87ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.5 MB
workflow-execution: DOM nodes 124
workflow-execution: event listeners 42
Raw data
{
  "timestamp": "2026-09-23T12:40:33.097Z",
  "gitSha": "e9d47e7a00f7b2f4301fcd6ad3f56a22b0eb3035",
  "branch": "backport-18598-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2118.114999999989,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.106000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 569.5,
      "heapDeltaBytes": 10218744,
      "heapUsedBytes": 81273144,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 10.180000000000001,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2046.5880000000425,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.313,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 499.876,
      "heapDeltaBytes": -5265540,
      "heapUsedBytes": 65056200,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.907000000000002,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1875.4779999999869,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 30.602999999999998,
      "layouts": 14,
      "layoutDurationMs": 4.454,
      "taskDurationMs": 868.5989999999999,
      "heapDeltaBytes": -1651640,
      "heapUsedBytes": 68796232,
      "domNodes": -280,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 152.118,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1855.6199999999308,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 30.240000000000002,
      "layouts": 14,
      "layoutDurationMs": 4.223,
      "taskDurationMs": 888.8069999999999,
      "heapDeltaBytes": -5705620,
      "heapUsedBytes": 64657904,
      "domNodes": -278,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 147.13000000000002,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1683.4870000000137,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 15.415,
      "layouts": 6,
      "layoutDurationMs": 1.186,
      "taskDurationMs": 347.073,
      "heapDeltaBytes": 4249056,
      "heapUsedBytes": 74646016,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.400000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1717.8330000000415,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 14.486,
      "layouts": 6,
      "layoutDurationMs": 1.186,
      "taskDurationMs": 343.767,
      "heapDeltaBytes": 4548704,
      "heapUsedBytes": 75013792,
      "domNodes": 73,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 11.115,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 726.1559999999463,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.424,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 445.49499999999995,
      "heapDeltaBytes": 18849688,
      "heapUsedBytes": 88444184,
      "domNodes": 18,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 157.277,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 641.0680000000184,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.864000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 444.46899999999994,
      "heapDeltaBytes": -7490904,
      "heapUsedBytes": 63119476,
      "domNodes": 20,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 155.12300000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.6470000000218,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.723000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 596.513,
      "heapDeltaBytes": -16317512,
      "heapUsedBytes": 87439468,
      "domNodes": -266,
      "jsHeapTotalBytes": -1380352,
      "scriptDurationMs": 31.830000000000005,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.9339999999793,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.681000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 622.3770000000001,
      "heapDeltaBytes": 9336340,
      "heapUsedBytes": 85750976,
      "domNodes": -272,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 32.225,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2233.739000000014,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.628,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1660.2289999999998,
      "heapDeltaBytes": 4356904,
      "heapUsedBytes": 81790428,
      "domNodes": -245,
      "jsHeapTotalBytes": 1167360,
      "scriptDurationMs": 822.392,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2224.5829999999387,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.822999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1661.269,
      "heapDeltaBytes": 7816676,
      "heapUsedBytes": 85408488,
      "domNodes": -276,
      "jsHeapTotalBytes": 905216,
      "scriptDurationMs": 831.582,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3599.1989999999987,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 13.945999999999996,
      "layouts": 60,
      "layoutDurationMs": 13.312999999999999,
      "taskDurationMs": 1777.2979999999998,
      "heapDeltaBytes": -2441324,
      "heapUsedBytes": 76248976,
      "domNodes": -280,
      "jsHeapTotalBytes": -2203648,
      "scriptDurationMs": 801.776,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3522.1819999999298,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 11.028,
      "layouts": 60,
      "layoutDurationMs": 13.384,
      "taskDurationMs": 1679.6930000000002,
      "heapDeltaBytes": 8214428,
      "heapUsedBytes": 76088360,
      "domNodes": -280,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 772.014,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3135.4929999999968,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 8.841000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1936.7060000000001,
      "heapDeltaBytes": -10454848,
      "heapUsedBytes": 70315024,
      "domNodes": 8,
      "jsHeapTotalBytes": 5136384,
      "scriptDurationMs": 993.18,
      "eventListeners": 188,
      "totalBlockingTimeMs": 13,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3121.5029999999615,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.536,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1896.902,
      "heapDeltaBytes": 21755904,
      "heapUsedBytes": 89838936,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 950.988,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2041.119999999978,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.3659999999999992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 551.591,
      "heapDeltaBytes": 22056472,
      "heapUsedBytes": 88626992,
      "domNodes": -273,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 33.887,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2062.1679999999287,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.354999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 623.774,
      "heapDeltaBytes": 5678528,
      "heapUsedBytes": 83212084,
      "domNodes": -278,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 35.201,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 596.1599999999407,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.031,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 394.348,
      "heapDeltaBytes": 15031404,
      "heapUsedBytes": 87311060,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 141.29500000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 606.4240000000609,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.607,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 407.01000000000005,
      "heapDeltaBytes": 14958900,
      "heapUsedBytes": 87943316,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 138.922,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2024.0370000000212,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.214,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.66900000000004,
      "heapDeltaBytes": 6543352,
      "heapUsedBytes": 79872408,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.67,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.2079999999778,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.015999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 491,
      "heapDeltaBytes": -9785452,
      "heapUsedBytes": 62724540,
      "domNodes": -294,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 7.876999999999999,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1723.9739999999983,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 27.674,
      "layouts": 18,
      "layoutDurationMs": 5.221,
      "taskDurationMs": 789.6569999999999,
      "heapDeltaBytes": 820676,
      "heapUsedBytes": 74123812,
      "domNodes": -296,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 105.268,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1733.1380000000536,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 26.606000000000005,
      "layouts": 18,
      "layoutDurationMs": 5.182000000000001,
      "taskDurationMs": 795.59,
      "heapDeltaBytes": 6080544,
      "heapUsedBytes": 79014300,
      "domNodes": -297,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 103.98199999999999,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.1099999999642,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 30.659000000000006,
      "layouts": 15,
      "layoutDurationMs": 15.810999999999998,
      "taskDurationMs": 911.0540000000002,
      "heapDeltaBytes": 21963832,
      "heapUsedBytes": 106517608,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 28.772,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 130,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8284.565000000042,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 41.791000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5681.725,
      "heapDeltaBytes": 878352,
      "heapUsedBytes": 77163288,
      "domNodes": -280,
      "jsHeapTotalBytes": 380928,
      "scriptDurationMs": 2607.176,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8263.412000000017,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 37.672000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5625.565,
      "heapDeltaBytes": 12556900,
      "heapUsedBytes": 88905332,
      "domNodes": -276,
      "jsHeapTotalBytes": -667648,
      "scriptDurationMs": 2583.671,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18297.64,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17351.382,
      "heapDeltaBytes": -59854720,
      "heapUsedBytes": 178771748,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16216064,
      "scriptDurationMs": 311.199,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18027.73300000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17366.835000000003,
      "heapDeltaBytes": -64678432,
      "heapUsedBytes": 178444628,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18903040,
      "scriptDurationMs": 295.38399999999996,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22916.440999999963,
      "styleRecalcs": 178,
      "styleRecalcDurationMs": 21.268000000000008,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22599.822,
      "heapDeltaBytes": -50772324,
      "heapUsedBytes": 179137736,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19574784,
      "scriptDurationMs": 935.5619999999999,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 89,
      "frameDurationMs": 18.886666666666738,
      "p95FrameDurationMs": 16.700000000004366
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22758.369000000017,
      "styleRecalcs": 177,
      "styleRecalcDurationMs": 22.33200000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22407.226000000002,
      "heapDeltaBytes": -61225960,
      "heapUsedBytes": 171153976,
      "domNodes": -8068,
      "jsHeapTotalBytes": -9449472,
      "scriptDurationMs": 946.1039999999999,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 262,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000004366
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6513.901000000033,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.399,
      "layouts": 20,
      "layoutDurationMs": 25.498999999999995,
      "taskDurationMs": 6405.811,
      "heapDeltaBytes": -40403484,
      "heapUsedBytes": 177585580,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10735616,
      "scriptDurationMs": 121.53599999999999,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 586,
      "frameDurationMs": 18.33333333333327,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6487.8159999999525,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.849,
      "layouts": 20,
      "layoutDurationMs": 24.800000000000004,
      "taskDurationMs": 6403.557,
      "heapDeltaBytes": -45524688,
      "heapUsedBytes": 180920440,
      "domNodes": -8068,
      "jsHeapTotalBytes": 9740288,
      "scriptDurationMs": 116.952,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 458,
      "frameDurationMs": 18.329999999999988,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9319.716999999968,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8887.108,
      "heapDeltaBytes": 18364836,
      "heapUsedBytes": 188640756,
      "domNodes": 0,
      "jsHeapTotalBytes": -7602176,
      "scriptDurationMs": 216.538,
      "eventListeners": -12,
      "totalBlockingTimeMs": 18,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9326.193999999987,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8920.955,
      "heapDeltaBytes": 2213880,
      "heapUsedBytes": 179192816,
      "domNodes": 0,
      "jsHeapTotalBytes": -18874368,
      "scriptDurationMs": 146.8940000000001,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 103.26600000007602,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 13.876,
      "layouts": 2,
      "layoutDurationMs": 1.1959999999999997,
      "taskDurationMs": 73.49199999999999,
      "heapDeltaBytes": 3070804,
      "heapUsedBytes": 72351920,
      "domNodes": 129,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.710000000000001,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 447.19899999995505,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 20.979,
      "layouts": 3,
      "layoutDurationMs": 0.932,
      "taskDurationMs": 100.45100000000001,
      "heapDeltaBytes": 4748972,
      "heapUsedBytes": 69255180,
      "domNodes": 119,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.074,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50404 75596 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@datadog-official

This comment has been minimized.

<!-- ccr-slack-attribution -->
_Requested by **Christian Byrne** · [Slack
thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449?thread_ts=1790058330.774449&cid=C0BGH348Z0C)_

Fixes a bug where an agent's `insert_workflow` batch (e.g. the in-app
agent loading a template like "Z Image Turbo") materialized nodes with
correct positions and types, and links between them materialized
correctly (#18458 / PM-1562), but every inserted node's **widgets
rendered as empty/blank bodies** even though the widget values,
`MarkdownNote` text, `SaveImage` `filename_prefix`, etc. were present in
the CRDT document and in the widget store.

Two independent, compounding bugs, both specific to how
`insert_workflow` differs from `add_node`:

**Bug 1 — widgets undiscoverable (blank node body, zero widget rows).**

`comfy-multi-player`'s `insert_workflow` applier remaps every inserted
node's id to a derived string carrying colons for reasons that have
nothing to do with subgraph scoping (`remap.ts`'s `derivedId`, e.g.
`insert:<opId>:root:node:<originalId>`). `add_node` never does this — it
keeps the id comfy-cli minted. Widget registration
(`attachNodeToStores`/`BaseWidget.setNodeId` in
`nodeShellLifecycle.ts`/`BaseWidget.ts`) always keys on that full id.

The node-render path reads widget ids back through `stripGraphPrefix`
(`src/stores/widgetValueStore.ts`) — used by `LGraphNode.vue`,
`processedWidgetRenderModel.ts`, `WidgetItem.vue`, and
`WidgetTextPreview.vue`. It used to strip *everything up to the last
colon* unconditionally, which is correct for a genuine subgraph-scoped
id (`<uuid>:<localId>`) but wrong for `insert_workflow`'s derived id: it
collapsed `insert:<opId>:root:node:9` down to bare `9`, a key nothing
was ever registered under (and, if a second `insert_workflow` op
happened to reuse the same original id, a key two unrelated nodes would
collapse onto). The lookup came back empty, so the node rendered with
**zero widget rows**.

Fixed `stripGraphPrefix` to only strip a prefix that is actually a
subgraph UUID (repeating for nested subgraphs), leaving any other
colon-bearing id untouched.

**Bug 2 — widget discoverable but stuck at its constructor default.**

Once bug 1 is fixed, `agentNodeMaterializer.ts`'s `materialize()` still
didn't restore the real value. The op layer stores an ordinary node's
`widgets_values` **by name** (`readSemanticNode`), but
`LGraphNode.configure()`'s named-value restore is gated behind the
experimental `Comfy.Workflow.NamedValuesRestore` setting (off by
default) or a `fallbackNames` list that is never populated for real
catalog nodes. Without either, `configure()` falls back to *positional*
restore against `widgets_values` — for a named payload that's a plain
object, not an array, so nothing restores and the widget keeps whatever
value its constructor set.

This file already has a `withNamedValuesRestore()` helper that flips
`LiteGraph.namedValuesRestore` on for the duration of a call — it was
used only when configuring a subgraph *definition*, never for the node's
own `configure()` call in `materialize()`. `add_node`-created nodes
mostly dodge this because the agent's add-node tool typically follow-ups
with discrete `set_widget` ops (a direct, always-correct value write),
whereas `insert_workflow` bakes every widget value into the node's
initial creation payload, hitting this path on every single widget of
every inserted node.

**Fix:** wrap `materialize()`'s `node.configure(...)` call in
`withNamedValuesRestore()` too, so a named payload actually lands.

**Tests:**
- `agentInsertWorkflowWidgets.regression.test.ts` (new): drives the real
pipeline (comfy-multi-player's `insert_workflow` applier →
`EcsFollowerAdapter`/`AgentCrdtProjection` → `graphMutations` →
`agentNodeMaterializer`), then reads widget ids back exactly the way
`LGraphNode.vue` does (`stripGraphPrefix` + `getNodeWidgetIds`),
asserting the widget is both discoverable and correctly-valued. Also
covers two `insert_workflow` ops that reuse the same original node id,
proving they no longer collide.
- `widgetValueStore.test.ts`: focused unit coverage for
`stripGraphPrefix` — bare id passthrough, single/nested subgraph-uuid
stripping, the derived-id passthrough case, the same-trailing-segment
non-collision case, and the empty-id case.

**Verified:** `pnpm typecheck`, `pnpm lint` (eslint + oxlint), `pnpm
format:check` (via the repo's pre-commit hook) and the full
`src/workbench/extensions/agent/crdt` + `src/stores` Vitest suites (2148
passed, 16 pre-existing expected-fails unrelated to this change, 1
skipped) all pass, plus the render-adjacent
`LGraphNode.widgetOrder.test.ts`, `WidgetItem.test.ts`, and
`WidgetTextPreview.test.ts`.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY

---
_Generated by [Claude
Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_
@claude
claude Bot force-pushed the backport-18598-to-cloud-1.54 branch from f5bac5c to fe3012a Compare September 23, 2026 12:29
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 23, 2026
@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18601   +/-   ##
=============================================
  Coverage              ?   83.67%           
=============================================
  Files                 ?     2105           
  Lines                 ?   124645           
  Branches              ?    31598           
=============================================
  Hits                  ?   104298           
  Misses                ?    20168           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.68% <66.66%> (?)
unit 78.70% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/stores/widgetValueStore.ts 95.83% <100.00%> (ø)
...nch/extensions/agent/crdt/agentNodeMaterializer.ts 98.77% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit 6587301 into cloud/1.54 Sep 23, 2026
90 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-18598-to-cloud-1.54 branch September 23, 2026 12:52
comfy-pr-bot pushed a commit that referenced this pull request Sep 23, 2026
…ets when execId derivation fails (PM-1580 follow-up) (#18608)

&lt;!-- ccr-slack-attribution --&gt;
_Requested by **Christian Byrne** · [Slack
thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449?thread_ts=1790058330.774449&cid=C0BGH348Z0C)_

Backport of #18604 to `cloud/1.54`.

Opened manually: the `PR Backport` workflow (`pr-backport.yaml`) only
runs when the PR carries the `needs-backport` label — `core/1.54` +
`cloud/1.54` alone (added manually before merge) don't trigger it, so it
never ran at merge time. After adding `needs-backport`, the workflow did
run and this target (`cloud/1.54`) cherry-picked `035d9056b0` cleanly,
but the run's overall job still failed because the `core/1.54` target
hit a real conflict (that target is missing #18598 entirely, since its
own backport #18600 is still open/unmerged against `core/1.54`) — and
the workflow's "Cleanup stranded backport branches" step then deleted
the `cloud/1.54` branch it had just successfully pushed, because it runs
on `failure()` for the *job*, not per-target. So this clean backport
never got a PR from the bot despite succeeding.

Re-cherry-picked `035d9056b0` onto `cloud/1.54` (which already has
#18598 via #18601) by hand — clean apply, no conflicts.

`core/1.54` is intentionally not backported here: it needs #18600 (the
#18598 backport) merged first.

---
🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY

---
_Generated by [Claude
Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
CodeJuggernaut pushed a commit that referenced this pull request Sep 23, 2026
…ets when execId derivation fails (PM-1580 follow-up) (#18608)

&lt;!-- ccr-slack-attribution --&gt;
_Requested by **Christian Byrne** · [Slack
thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449?thread_ts=1790058330.774449&cid=C0BGH348Z0C)_

Backport of #18604 to `cloud/1.54`.

Opened manually: the `PR Backport` workflow (`pr-backport.yaml`) only
runs when the PR carries the `needs-backport` label — `core/1.54` +
`cloud/1.54` alone (added manually before merge) don't trigger it, so it
never ran at merge time. After adding `needs-backport`, the workflow did
run and this target (`cloud/1.54`) cherry-picked `035d9056b0` cleanly,
but the run's overall job still failed because the `core/1.54` target
hit a real conflict (that target is missing #18598 entirely, since its
own backport #18600 is still open/unmerged against `core/1.54`) — and
the workflow's "Cleanup stranded backport branches" step then deleted
the `cloud/1.54` branch it had just successfully pushed, because it runs
on `failure()` for the *job*, not per-target. So this clean backport
never got a PR from the bot despite succeeding.

Re-cherry-picked `035d9056b0` onto `cloud/1.54` (which already has
#18598 via #18601) by hand — clean apply, no conflicts.

`core/1.54` is intentionally not backported here: it needs #18600 (the
#18598 backport) merged first.

---
🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY

---
_Generated by [Claude
Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_

(cherry picked from commit a55ce3d)
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants