Repository navigation
[backport cloud/1.54] fix: render widgets on insert_workflow-materialized nodes - #18601
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1945 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-23T12:40:33.097Z",
"gitSha": "e9d47e7a00f7b2f4301fcd6ad3f56a22b0eb3035",
"branch": "backport-18598-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2118.114999999989,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.106000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.5,
"heapDeltaBytes": 10218744,
"heapUsedBytes": 81273144,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.180000000000001,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2046.5880000000425,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.313,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.876,
"heapDeltaBytes": -5265540,
"heapUsedBytes": 65056200,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.907000000000002,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1875.4779999999869,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.602999999999998,
"layouts": 14,
"layoutDurationMs": 4.454,
"taskDurationMs": 868.5989999999999,
"heapDeltaBytes": -1651640,
"heapUsedBytes": 68796232,
"domNodes": -280,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 152.118,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.6199999999308,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.240000000000002,
"layouts": 14,
"layoutDurationMs": 4.223,
"taskDurationMs": 888.8069999999999,
"heapDeltaBytes": -5705620,
"heapUsedBytes": 64657904,
"domNodes": -278,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 147.13000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1683.4870000000137,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.415,
"layouts": 6,
"layoutDurationMs": 1.186,
"taskDurationMs": 347.073,
"heapDeltaBytes": 4249056,
"heapUsedBytes": 74646016,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.400000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.8330000000415,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.486,
"layouts": 6,
"layoutDurationMs": 1.186,
"taskDurationMs": 343.767,
"heapDeltaBytes": 4548704,
"heapUsedBytes": 75013792,
"domNodes": 73,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.115,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 726.1559999999463,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.424,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.49499999999995,
"heapDeltaBytes": 18849688,
"heapUsedBytes": 88444184,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 157.277,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 641.0680000000184,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.864000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.46899999999994,
"heapDeltaBytes": -7490904,
"heapUsedBytes": 63119476,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 155.12300000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.6470000000218,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.723000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 596.513,
"heapDeltaBytes": -16317512,
"heapUsedBytes": 87439468,
"domNodes": -266,
"jsHeapTotalBytes": -1380352,
"scriptDurationMs": 31.830000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2055.9339999999793,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.681000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 622.3770000000001,
"heapDeltaBytes": 9336340,
"heapUsedBytes": 85750976,
"domNodes": -272,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 32.225,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2233.739000000014,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.628,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1660.2289999999998,
"heapDeltaBytes": 4356904,
"heapUsedBytes": 81790428,
"domNodes": -245,
"jsHeapTotalBytes": 1167360,
"scriptDurationMs": 822.392,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2224.5829999999387,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.822999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1661.269,
"heapDeltaBytes": 7816676,
"heapUsedBytes": 85408488,
"domNodes": -276,
"jsHeapTotalBytes": 905216,
"scriptDurationMs": 831.582,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3599.1989999999987,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.945999999999996,
"layouts": 60,
"layoutDurationMs": 13.312999999999999,
"taskDurationMs": 1777.2979999999998,
"heapDeltaBytes": -2441324,
"heapUsedBytes": 76248976,
"domNodes": -280,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 801.776,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3522.1819999999298,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.028,
"layouts": 60,
"layoutDurationMs": 13.384,
"taskDurationMs": 1679.6930000000002,
"heapDeltaBytes": 8214428,
"heapUsedBytes": 76088360,
"domNodes": -280,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 772.014,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3135.4929999999968,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.841000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1936.7060000000001,
"heapDeltaBytes": -10454848,
"heapUsedBytes": 70315024,
"domNodes": 8,
"jsHeapTotalBytes": 5136384,
"scriptDurationMs": 993.18,
"eventListeners": 188,
"totalBlockingTimeMs": 13,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3121.5029999999615,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.536,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1896.902,
"heapDeltaBytes": 21755904,
"heapUsedBytes": 89838936,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 950.988,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2041.119999999978,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.3659999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.591,
"heapDeltaBytes": 22056472,
"heapUsedBytes": 88626992,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.887,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2062.1679999999287,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.354999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.774,
"heapDeltaBytes": 5678528,
"heapUsedBytes": 83212084,
"domNodes": -278,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 35.201,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.1599999999407,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.031,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.348,
"heapDeltaBytes": 15031404,
"heapUsedBytes": 87311060,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 141.29500000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.4240000000609,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.607,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.01000000000005,
"heapDeltaBytes": 14958900,
"heapUsedBytes": 87943316,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 138.922,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2024.0370000000212,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.214,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.66900000000004,
"heapDeltaBytes": 6543352,
"heapUsedBytes": 79872408,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.67,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2022.2079999999778,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.015999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491,
"heapDeltaBytes": -9785452,
"heapUsedBytes": 62724540,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.876999999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.9739999999983,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.674,
"layouts": 18,
"layoutDurationMs": 5.221,
"taskDurationMs": 789.6569999999999,
"heapDeltaBytes": 820676,
"heapUsedBytes": 74123812,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 105.268,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1733.1380000000536,
"styleRecalcs": 76,
"styleRecalcDurationMs": 26.606000000000005,
"layouts": 18,
"layoutDurationMs": 5.182000000000001,
"taskDurationMs": 795.59,
"heapDeltaBytes": 6080544,
"heapUsedBytes": 79014300,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 103.98199999999999,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.1099999999642,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.659000000000006,
"layouts": 15,
"layoutDurationMs": 15.810999999999998,
"taskDurationMs": 911.0540000000002,
"heapDeltaBytes": 21963832,
"heapUsedBytes": 106517608,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 28.772,
"eventListeners": 2387,
"totalBlockingTimeMs": 130,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8284.565000000042,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.791000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5681.725,
"heapDeltaBytes": 878352,
"heapUsedBytes": 77163288,
"domNodes": -280,
"jsHeapTotalBytes": 380928,
"scriptDurationMs": 2607.176,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8263.412000000017,
"styleRecalcs": 245,
"styleRecalcDurationMs": 37.672000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5625.565,
"heapDeltaBytes": 12556900,
"heapUsedBytes": 88905332,
"domNodes": -276,
"jsHeapTotalBytes": -667648,
"scriptDurationMs": 2583.671,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18297.64,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17351.382,
"heapDeltaBytes": -59854720,
"heapUsedBytes": 178771748,
"domNodes": -8068,
"jsHeapTotalBytes": -16216064,
"scriptDurationMs": 311.199,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18027.73300000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17366.835000000003,
"heapDeltaBytes": -64678432,
"heapUsedBytes": 178444628,
"domNodes": -8068,
"jsHeapTotalBytes": -18903040,
"scriptDurationMs": 295.38399999999996,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22916.440999999963,
"styleRecalcs": 178,
"styleRecalcDurationMs": 21.268000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22599.822,
"heapDeltaBytes": -50772324,
"heapUsedBytes": 179137736,
"domNodes": -8068,
"jsHeapTotalBytes": -19574784,
"scriptDurationMs": 935.5619999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 89,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 22758.369000000017,
"styleRecalcs": 177,
"styleRecalcDurationMs": 22.33200000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22407.226000000002,
"heapDeltaBytes": -61225960,
"heapUsedBytes": 171153976,
"domNodes": -8068,
"jsHeapTotalBytes": -9449472,
"scriptDurationMs": 946.1039999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 262,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-node-resize-workload",
"durationMs": 6513.901000000033,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.399,
"layouts": 20,
"layoutDurationMs": 25.498999999999995,
"taskDurationMs": 6405.811,
"heapDeltaBytes": -40403484,
"heapUsedBytes": 177585580,
"domNodes": -8068,
"jsHeapTotalBytes": 10735616,
"scriptDurationMs": 121.53599999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 586,
"frameDurationMs": 18.33333333333327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6487.8159999999525,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.849,
"layouts": 20,
"layoutDurationMs": 24.800000000000004,
"taskDurationMs": 6403.557,
"heapDeltaBytes": -45524688,
"heapUsedBytes": 180920440,
"domNodes": -8068,
"jsHeapTotalBytes": 9740288,
"scriptDurationMs": 116.952,
"eventListeners": -14929,
"totalBlockingTimeMs": 458,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9319.716999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8887.108,
"heapDeltaBytes": 18364836,
"heapUsedBytes": 188640756,
"domNodes": 0,
"jsHeapTotalBytes": -7602176,
"scriptDurationMs": 216.538,
"eventListeners": -12,
"totalBlockingTimeMs": 18,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9326.193999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8920.955,
"heapDeltaBytes": 2213880,
"heapUsedBytes": 179192816,
"domNodes": 0,
"jsHeapTotalBytes": -18874368,
"scriptDurationMs": 146.8940000000001,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 103.26600000007602,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.876,
"layouts": 2,
"layoutDurationMs": 1.1959999999999997,
"taskDurationMs": 73.49199999999999,
"heapDeltaBytes": 3070804,
"heapUsedBytes": 72351920,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.710000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 447.19899999995505,
"styleRecalcs": 13,
"styleRecalcDurationMs": 20.979,
"layouts": 3,
"layoutDurationMs": 0.932,
"taskDurationMs": 100.45100000000001,
"heapDeltaBytes": 4748972,
"heapUsedBytes": 69255180,
"domNodes": 119,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.074,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
<!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449?thread_ts=1790058330.774449&cid=C0BGH348Z0C)_ Fixes a bug where an agent's `insert_workflow` batch (e.g. the in-app agent loading a template like "Z Image Turbo") materialized nodes with correct positions and types, and links between them materialized correctly (#18458 / PM-1562), but every inserted node's **widgets rendered as empty/blank bodies** even though the widget values, `MarkdownNote` text, `SaveImage` `filename_prefix`, etc. were present in the CRDT document and in the widget store. Two independent, compounding bugs, both specific to how `insert_workflow` differs from `add_node`: **Bug 1 — widgets undiscoverable (blank node body, zero widget rows).** `comfy-multi-player`'s `insert_workflow` applier remaps every inserted node's id to a derived string carrying colons for reasons that have nothing to do with subgraph scoping (`remap.ts`'s `derivedId`, e.g. `insert:<opId>:root:node:<originalId>`). `add_node` never does this — it keeps the id comfy-cli minted. Widget registration (`attachNodeToStores`/`BaseWidget.setNodeId` in `nodeShellLifecycle.ts`/`BaseWidget.ts`) always keys on that full id. The node-render path reads widget ids back through `stripGraphPrefix` (`src/stores/widgetValueStore.ts`) — used by `LGraphNode.vue`, `processedWidgetRenderModel.ts`, `WidgetItem.vue`, and `WidgetTextPreview.vue`. It used to strip *everything up to the last colon* unconditionally, which is correct for a genuine subgraph-scoped id (`<uuid>:<localId>`) but wrong for `insert_workflow`'s derived id: it collapsed `insert:<opId>:root:node:9` down to bare `9`, a key nothing was ever registered under (and, if a second `insert_workflow` op happened to reuse the same original id, a key two unrelated nodes would collapse onto). The lookup came back empty, so the node rendered with **zero widget rows**. Fixed `stripGraphPrefix` to only strip a prefix that is actually a subgraph UUID (repeating for nested subgraphs), leaving any other colon-bearing id untouched. **Bug 2 — widget discoverable but stuck at its constructor default.** Once bug 1 is fixed, `agentNodeMaterializer.ts`'s `materialize()` still didn't restore the real value. The op layer stores an ordinary node's `widgets_values` **by name** (`readSemanticNode`), but `LGraphNode.configure()`'s named-value restore is gated behind the experimental `Comfy.Workflow.NamedValuesRestore` setting (off by default) or a `fallbackNames` list that is never populated for real catalog nodes. Without either, `configure()` falls back to *positional* restore against `widgets_values` — for a named payload that's a plain object, not an array, so nothing restores and the widget keeps whatever value its constructor set. This file already has a `withNamedValuesRestore()` helper that flips `LiteGraph.namedValuesRestore` on for the duration of a call — it was used only when configuring a subgraph *definition*, never for the node's own `configure()` call in `materialize()`. `add_node`-created nodes mostly dodge this because the agent's add-node tool typically follow-ups with discrete `set_widget` ops (a direct, always-correct value write), whereas `insert_workflow` bakes every widget value into the node's initial creation payload, hitting this path on every single widget of every inserted node. **Fix:** wrap `materialize()`'s `node.configure(...)` call in `withNamedValuesRestore()` too, so a named payload actually lands. **Tests:** - `agentInsertWorkflowWidgets.regression.test.ts` (new): drives the real pipeline (comfy-multi-player's `insert_workflow` applier → `EcsFollowerAdapter`/`AgentCrdtProjection` → `graphMutations` → `agentNodeMaterializer`), then reads widget ids back exactly the way `LGraphNode.vue` does (`stripGraphPrefix` + `getNodeWidgetIds`), asserting the widget is both discoverable and correctly-valued. Also covers two `insert_workflow` ops that reuse the same original node id, proving they no longer collide. - `widgetValueStore.test.ts`: focused unit coverage for `stripGraphPrefix` — bare id passthrough, single/nested subgraph-uuid stripping, the derived-id passthrough case, the same-trailing-segment non-collision case, and the empty-id case. **Verified:** `pnpm typecheck`, `pnpm lint` (eslint + oxlint), `pnpm format:check` (via the repo's pre-commit hook) and the full `src/workbench/extensions/agent/crdt` + `src/stores` Vitest suites (2148 passed, 16 pre-existing expected-fails unrelated to this change, 1 skipped) all pass, plus the render-adjacent `LGraphNode.widgetOrder.test.ts`, `WidgetItem.test.ts`, and `WidgetTextPreview.test.ts`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_
f5bac5c to
fe3012a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18601 +/- ##
=============================================
Coverage ? 83.67%
=============================================
Files ? 2105
Lines ? 124645
Branches ? 31598
=============================================
Hits ? 104298
Misses ? 20168
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…ets when execId derivation fails (PM-1580 follow-up) (#18608) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449?thread_ts=1790058330.774449&cid=C0BGH348Z0C)_ Backport of #18604 to `cloud/1.54`. Opened manually: the `PR Backport` workflow (`pr-backport.yaml`) only runs when the PR carries the `needs-backport` label — `core/1.54` + `cloud/1.54` alone (added manually before merge) don't trigger it, so it never ran at merge time. After adding `needs-backport`, the workflow did run and this target (`cloud/1.54`) cherry-picked `035d9056b0` cleanly, but the run's overall job still failed because the `core/1.54` target hit a real conflict (that target is missing #18598 entirely, since its own backport #18600 is still open/unmerged against `core/1.54`) — and the workflow's "Cleanup stranded backport branches" step then deleted the `cloud/1.54` branch it had just successfully pushed, because it runs on `failure()` for the *job*, not per-target. So this clean backport never got a PR from the bot despite succeeding. Re-cherry-picked `035d9056b0` onto `cloud/1.54` (which already has #18598 via #18601) by hand — clean apply, no conflicts. `core/1.54` is intentionally not backported here: it needs #18600 (the #18598 backport) merged first. --- 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…ets when execId derivation fails (PM-1580 follow-up) (#18608) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449?thread_ts=1790058330.774449&cid=C0BGH348Z0C)_ Backport of #18604 to `cloud/1.54`. Opened manually: the `PR Backport` workflow (`pr-backport.yaml`) only runs when the PR carries the `needs-backport` label — `core/1.54` + `cloud/1.54` alone (added manually before merge) don't trigger it, so it never ran at merge time. After adding `needs-backport`, the workflow did run and this target (`cloud/1.54`) cherry-picked `035d9056b0` cleanly, but the run's overall job still failed because the `core/1.54` target hit a real conflict (that target is missing #18598 entirely, since its own backport #18600 is still open/unmerged against `core/1.54`) — and the workflow's "Cleanup stranded backport branches" step then deleted the `cloud/1.54` branch it had just successfully pushed, because it runs on `failure()` for the *job*, not per-target. So this clean backport never got a PR from the bot despite succeeding. Re-cherry-picked `035d9056b0` onto `cloud/1.54` (which already has #18598 via #18601) by hand — clean apply, no conflicts. `core/1.54` is intentionally not backported here: it needs #18600 (the #18598 backport) merged first. --- 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ (cherry picked from commit a55ce3d)
Backport of #18598 to
cloud/1.54Automatically created by backport workflow.