Skip to content

[backport cloud/1.54] chore: replace comfy-multi-player tarball pin with 0.3.5 - #18574

Merged
christian-byrne merged 2 commits into
cloud/1.54from
claude/manual-backport-18552-cloud-1.54
Sep 23, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.54from
claude/manual-backport-18552-cloud-1.54

Conversation

@claude

@claude claude Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Manual backport of #18552 to cloud/1.54, after the automated backport bot's cherry-pick failed on pnpm-lock.yaml/pnpm-workspace.yaml conflicts (see the bot's comment).

Why this needed manual resolution

cloud/1.54 had already diverged from what #18552 assumed: it was pinned to @comfyorg/comfy-multi-player@0.3.3 via a direct npm version (not the tarball pin #18552 replaced on main). So this is a 0.3.3 -> 0.3.5 bump on top of the branch's existing state, not a fresh application of the original diff.

Changes

  • Bumps @comfyorg/comfy-multi-player from 0.3.3 to 0.3.5, moved to the shared catalog: entry (matching main's structure).
  • Bumps the yjs catalog pin from ^13.6.27 to ^13.6.32: comfy-multi-player@0.3.5's own yjs ^13.6.27 dependency resolves to 13.6.32, which otherwise coexists with the previously-pinned 13.6.31 as two separate package instances and breaks vue-tsc (TS2345, incompatible Doc/AbstractType/Item types). Deduping to one yjs instance fixes it.
  • Removes the now-unused tarball allowBuilds entry and collapses minimumReleaseAgeExclude to just the current 0.3.5 exclusion.
  • pnpm-lock.yaml regenerated via pnpm install / pnpm update yjs @comfyorg/comfy-multi-player (scoped to just these two packages, verified no unrelated dependency churn).

Testing

  • pnpm typecheck — passes clean, no duplicate-yjs TS2345 errors.
  • pnpm oxlint — no new warnings introduced by this change.
  • git diff on pnpm-lock.yaml reviewed line-by-line to confirm only the two intended packages changed.

Fixes the same duplicate-yjs typecheck regression #18552 fixed on main.

Claude-Session: https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY


Generated by Claude Code

@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 9:05am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d71d18c2-9247-477c-83cb-0e97653c25a4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@claude claude Bot added the backport Backporting a PR onto a release candidate label Sep 23, 2026
@github-actions
github-actions Bot requested a review from huang47 September 23, 2026 08:42
Use published `@comfyorg/comfy-multi-player@0.3.5`, matching main after
PR #18552. Manual backport to cloud/1.54 (comfy-multi-player was
already at npm 0.3.3 here, not a tarball pin, so this resolves as a
0.3.3 -> 0.3.5 bump rather than a fresh application):

- Bumps `@comfyorg/comfy-multi-player` from `0.3.3` to `0.3.5` (moved
  to the shared `catalog:` entry, matching main's structure).
- Bumps the `yjs` catalog pin from `^13.6.27` to `^13.6.32`:
  comfy-multi-player@0.3.5's own `yjs ^13.6.27` dependency resolves to
  `13.6.32`, which otherwise coexists with the previously-pinned
  `13.6.31` as two separate package instances and breaks `vue-tsc`
  (`TS2345`, incompatible `Doc`/`AbstractType`/`Item` types). Deduping
  to one `yjs` instance fixes it.
- Removes the now-unused tarball `allowBuilds` entry and collapses
  `minimumReleaseAgeExclude` to just the current `0.3.5` exclusion.

Backport of 18552 to `cloud/1.54`. Automated backport failed on
lockfile conflicts (cloud/1.54's baseline diverged: 0.3.3 npm pin vs
main's tarball pin), so this was resolved and regenerated manually via
`pnpm install`.
@claude
claude Bot force-pushed the claude/manual-backport-18552-cloud-1.54 branch from 88532eb to 153deba Compare September 23, 2026 08:46
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​comfyorg/​comfy-multi-player@​0.3.4 ⏵ 0.3.51001001009670
Updatednpm/​yjs@​13.6.31 ⏵ 13.6.3210010010088 -1100

View full report

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/23/2026, 09:07:21 AM UTC

Links

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🎭 Playwright: ✅ 1945 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1924 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 144ms TBT · 99.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.2 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.4 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 76ms TBT · 177.7 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 386ms TBT · 173.2 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 588ms
canvas-idle: script duration 12ms
canvas-idle: TBT 0ms
canvas-idle: heap used 66.8 MB
canvas-idle: DOM nodes -279
canvas-idle: event listeners -180
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 30ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 921ms
canvas-mouse-sweep: script duration 165ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 64.3 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -195
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 414ms
canvas-zoom-sweep: script duration 15ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.7 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 468ms
dom-widget-clipping: script duration 165ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.2 MB
dom-widget-clipping: DOM nodes 16
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 699ms
large-graph-idle: script duration 39ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 80.0 MB
large-graph-idle: DOM nodes -273
large-graph-idle: event listeners -178
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 1744ms
large-graph-pan: script duration 854ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 84.5 MB
large-graph-pan: DOM nodes -274
large-graph-pan: event listeners -78
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1813ms
large-graph-zoom: script duration 817ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.8 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 2028ms
legacy-node-drag: script duration 994ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 86.7 MB
legacy-node-drag: DOM nodes -144
legacy-node-drag: event listeners 89
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 660ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 86.3 MB
minimap-idle: DOM nodes -132
minimap-idle: event listeners -93
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 436ms
subgraph-dom-widget-clipping: script duration 145ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.3 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 10ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 547ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 57.9 MB
subgraph-idle: DOM nodes -294
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 29ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 881ms
subgraph-mouse-sweep: script duration 116ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 71.3 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -212
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 1028ms
subgraph-transition-enter: script duration 34ms
subgraph-transition-enter: TBT 144ms
subgraph-transition-enter: heap used 99.5 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 40ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 6169ms
viewport-pan-sweep: script duration 2746ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 81.2 MB
viewport-pan-sweep: DOM nodes -272
viewport-pan-sweep: event listeners -160
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17117ms
vue-large-graph-idle: script duration 298ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.4 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 160
vue-large-graph-pan: task duration 21075ms
vue-large-graph-pan: script duration 926ms
vue-large-graph-pan: TBT 76ms
vue-large-graph-pan: heap used 177.7 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14926
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 26ms
vue-node-resize-workload: style recalc duration 85ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6265ms
vue-node-resize-workload: script duration 117ms
vue-node-resize-workload: TBT 386ms
vue-node-resize-workload: heap used 173.2 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14930
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8631ms
vue-zoom-out-idle: script duration 175ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 172.2 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -13
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 19ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 96ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.3 MB
workflow-execution: DOM nodes 136
workflow-execution: event listeners 42
Raw data
{
  "timestamp": "2026-09-23T09:16:59.084Z",
  "gitSha": "14c112597976e406eee0fe51a928b0ce4871a80b",
  "branch": "claude/manual-backport-18552-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2092.0750000000226,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.671999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 616.4379999999999,
      "heapDeltaBytes": -10354964,
      "heapUsedBytes": 60894056,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 14.084,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2029.6420000000808,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.817999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 560.0509999999999,
      "heapDeltaBytes": 9073496,
      "heapUsedBytes": 79275100,
      "domNodes": -279,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 10.844000000000003,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1819.6729999999661,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 30.098,
      "layouts": 14,
      "layoutDurationMs": 4.236999999999999,
      "taskDurationMs": 907.916,
      "heapDeltaBytes": -757600,
      "heapUsedBytes": 70114632,
      "domNodes": -283,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 162.545,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1848.1299999999692,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 30.794,
      "layouts": 14,
      "layoutDurationMs": 4.428,
      "taskDurationMs": 933.776,
      "heapDeltaBytes": -5634300,
      "heapUsedBytes": 64672928,
      "domNodes": -277,
      "jsHeapTotalBytes": 7331840,
      "scriptDurationMs": 166.925,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.5659999999916,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.441,
      "layouts": 6,
      "layoutDurationMs": 1.249,
      "taskDurationMs": 416.8790000000001,
      "heapDeltaBytes": 4614172,
      "heapUsedBytes": 75707192,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 15.019000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1732.4979999999641,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.649,
      "layouts": 6,
      "layoutDurationMs": 1.179,
      "taskDurationMs": 411.39000000000004,
      "heapDeltaBytes": 4270496,
      "heapUsedBytes": 74584780,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 14.921999999999997,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 710.5510000000095,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.711000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 458.027,
      "heapDeltaBytes": 18081860,
      "heapUsedBytes": 88284884,
      "domNodes": 14,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 161.795,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 710.0710000000845,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.792,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 477.112,
      "heapDeltaBytes": -7854256,
      "heapUsedBytes": 63165716,
      "domNodes": 18,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 169.03300000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2031.6309999999476,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.925999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 656.879,
      "heapDeltaBytes": 10646700,
      "heapUsedBytes": 86950688,
      "domNodes": -272,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 34.759,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2054.7769999999446,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.663,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 741.1800000000001,
      "heapDeltaBytes": 4940164,
      "heapUsedBytes": 80837244,
      "domNodes": -274,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 43.022000000000006,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2437.2230000000172,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 8.621,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1704.7569999999998,
      "heapDeltaBytes": 22298128,
      "heapUsedBytes": 88481860,
      "domNodes": -277,
      "jsHeapTotalBytes": 749568,
      "scriptDurationMs": 835.643,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2579.7489999999925,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.932,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1782.2500000000002,
      "heapDeltaBytes": 11907560,
      "heapUsedBytes": 88824748,
      "domNodes": -271,
      "jsHeapTotalBytes": 905216,
      "scriptDurationMs": 873.162,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3717.873999999938,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.087000000000002,
      "layouts": 60,
      "layoutDurationMs": 12.265,
      "taskDurationMs": 1787.9019999999998,
      "heapDeltaBytes": 11771848,
      "heapUsedBytes": 80226312,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 801.128,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3866.347000000019,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.046000000000003,
      "layouts": 60,
      "layoutDurationMs": 12.382999999999997,
      "taskDurationMs": 1838.0319999999997,
      "heapDeltaBytes": 8249376,
      "heapUsedBytes": 76573180,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 832.369,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3179.153000000042,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.053999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2020.447,
      "heapDeltaBytes": 9853488,
      "heapUsedBytes": 91312500,
      "domNodes": -288,
      "jsHeapTotalBytes": -475136,
      "scriptDurationMs": 977.6250000000001,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3104.8510000000533,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.2490000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2036.238,
      "heapDeltaBytes": 22968944,
      "heapUsedBytes": 90435872,
      "domNodes": 0,
      "jsHeapTotalBytes": 942080,
      "scriptDurationMs": 1009.6100000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 1996.9519999999648,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.209999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 663.676,
      "heapDeltaBytes": 22438588,
      "heapUsedBytes": 93272072,
      "domNodes": 10,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 35.24000000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2049.346000000014,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 5.155000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 655.3290000000001,
      "heapDeltaBytes": 9512288,
      "heapUsedBytes": 87633140,
      "domNodes": -274,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 35.371,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 656.7009999999982,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 12.579,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 444.897,
      "heapDeltaBytes": 14220848,
      "heapUsedBytes": 86395836,
      "domNodes": 20,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 146.965,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 605.0769999999375,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.855,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 427.593,
      "heapDeltaBytes": 14979804,
      "heapUsedBytes": 88252544,
      "domNodes": 16,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 143.51,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.4039999999377,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.959000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 535.8199999999999,
      "heapDeltaBytes": -15119940,
      "heapUsedBytes": 58001704,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 9.899999999999999,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2036.8689999999106,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.127,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 558.8169999999999,
      "heapDeltaBytes": -9039568,
      "heapUsedBytes": 63484684,
      "domNodes": -293,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 10.402999999999999,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1723.4760000000051,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 26.904,
      "layouts": 18,
      "layoutDurationMs": 4.603,
      "taskDurationMs": 872.0369999999999,
      "heapDeltaBytes": 10706564,
      "heapUsedBytes": 83912796,
      "domNodes": -299,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 112.44999999999999,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1789.8020000000088,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 31.901,
      "layouts": 18,
      "layoutDurationMs": 5.24,
      "taskDurationMs": 889.186,
      "heapDeltaBytes": -6637820,
      "heapUsedBytes": 65572012,
      "domNodes": -295,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 119.925,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1419.665000000009,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 33.507999999999996,
      "layouts": 15,
      "layoutDurationMs": 16.434,
      "taskDurationMs": 1027.7559999999999,
      "heapDeltaBytes": 19996752,
      "heapUsedBytes": 104346752,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 34.334,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 144,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9172.928000000069,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 42.809,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6247.603,
      "heapDeltaBytes": 8511380,
      "heapUsedBytes": 84835688,
      "domNodes": -274,
      "jsHeapTotalBytes": -1224704,
      "scriptDurationMs": 2795.376,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9106.33699999994,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 37.032999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6090.357999999999,
      "heapDeltaBytes": 9579660,
      "heapUsedBytes": 85525248,
      "domNodes": -270,
      "jsHeapTotalBytes": -176128,
      "scriptDurationMs": 2696.103,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17705.242999999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17140.266,
      "heapDeltaBytes": -27229032,
      "heapUsedBytes": 178451048,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11153408,
      "scriptDurationMs": 288.517,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17754.13900000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17094.22,
      "heapDeltaBytes": -54263492,
      "heapUsedBytes": 178828664,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11292672,
      "scriptDurationMs": 307.734,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21283.48500000004,
      "styleRecalcs": 157,
      "styleRecalcDurationMs": 20.008000000000024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20999.779,
      "heapDeltaBytes": -44871032,
      "heapUsedBytes": 178666356,
      "domNodes": -8068,
      "jsHeapTotalBytes": -15478784,
      "scriptDurationMs": 950.178,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 17,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21387.081999999966,
      "styleRecalcs": 163,
      "styleRecalcDurationMs": 20.009,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21151.163,
      "heapDeltaBytes": -39260884,
      "heapUsedBytes": 193969960,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11362304,
      "scriptDurationMs": 902.747,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 135,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6384.398000000033,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 83.43699999999998,
      "layouts": 20,
      "layoutDurationMs": 25.432999999999982,
      "taskDurationMs": 6304.049,
      "heapDeltaBytes": -30659892,
      "heapUsedBytes": 181485204,
      "domNodes": -8068,
      "jsHeapTotalBytes": 11882496,
      "scriptDurationMs": 117.60999999999999,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 459,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6327.065999999832,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 85.588,
      "layouts": 20,
      "layoutDurationMs": 25.602000000000015,
      "taskDurationMs": 6226.92,
      "heapDeltaBytes": -36054396,
      "heapUsedBytes": 181832720,
      "domNodes": -8068,
      "jsHeapTotalBytes": 16502784,
      "scriptDurationMs": 116.08699999999999,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 312,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8932.900999999902,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8641.966999999999,
      "heapDeltaBytes": 5531468,
      "heapUsedBytes": 176848072,
      "domNodes": 0,
      "jsHeapTotalBytes": -25952256,
      "scriptDurationMs": 183.192,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8912.593000000015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8619.473000000002,
      "heapDeltaBytes": 19148328,
      "heapUsedBytes": 184192632,
      "domNodes": 0,
      "jsHeapTotalBytes": -19660800,
      "scriptDurationMs": 166.02699999999993,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 475.09100000002036,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 22.936999999999998,
      "layouts": 4,
      "layoutDurationMs": 1.9909999999999997,
      "taskDurationMs": 121.875,
      "heapDeltaBytes": 4968360,
      "heapUsedBytes": 73239000,
      "domNodes": 147,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 12.38,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 107.73199999994176,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 14.273,
      "layouts": 2,
      "layoutDurationMs": 1.0459999999999998,
      "taskDurationMs": 69.935,
      "heapDeltaBytes": 2952080,
      "heapUsedBytes": 72140340,
      "domNodes": 125,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.0200000000000005,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50343 75521 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18574   +/-   ##
=============================================
  Coverage              ?   82.17%           
=============================================
  Files                 ?     2530           
  Lines                 ?   131949           
  Branches              ?    35467           
=============================================
  Hits                  ?   108430           
  Misses                ?    23006           
  Partials              ?      513           
Flag Coverage Δ
e2e 66.67% <ø> (?)
unit 78.70% <ø> (?)
website-unit 57.82% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 23, 2026
@christian-byrne
christian-byrne enabled auto-merge (squash) September 23, 2026 09:18
@datadog-official

Copy link
Copy Markdown

Pipelines

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 2 Pipeline jobs failed

CI: Tests E2E | e2e-status — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

CI: Tests E2E | playwright-tests (cloud) — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 66d20c8 | Docs | View more details | Give us feedback!

@claude

claude Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

playwright-tests (cloud) failure is pre-existing on cloud/1.54, not caused by this PR

What's failing: browser_tests/tests/agent/agentToolCallHistoryPersistence.spec.ts:24:1 — "keeps a completed turn work summary after a browser refresh" — fails on all 4 attempts with:

Error: expect(locator).toBeVisible() failed
Locator: locator('#agent-panel-root').getByRole('button', { name: 'Worked', exact: true })

Run: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35840865004/job/107116257444

Evidence it's pre-existing on cloud/1.54's base branch: #18555 ([backport cloud/1.54] feat: restore tool-call work summary on reload and chat switch — the cloud/1.54 counterpart of #18554, both backports of #18282) merged into cloud/1.54 at 2026-09-23T06:47:55Z, before this PR's CI ran. Its own playwright-tests (cloud) check failed with the exact same test, same locator, same error:

https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35828144801/job/107080951626

This is the same regression already identified on core/1.54 (traced to #18554, see the standing-down comment on #18559) — it has now also landed on cloud/1.54 via #18555's merge. It is unrelated to this PR's diff (comfy-multi-player 0.3.5 pin bump, yjs dedup fix, pnpm-workspace changes).

I searched for an existing fix (issues/PRs referencing agentToolCallHistoryPersistence, #agent-panel-root, the "Worked" button, and #18554/#18555) and found none. No fix exists yet.

Auto-merge note: this PR has auto-merge enabled. If playwright-tests (cloud) is a required check, auto-merge will not complete until this regression is fixed directly on cloud/1.54 (not from this PR — this PR shouldn't attempt to root-cause #18554/#18555's regression).

Generated by Claude Code

@christian-byrne
christian-byrne enabled auto-merge (squash) September 23, 2026 09:28
@christian-byrne
christian-byrne merged commit e790192 into cloud/1.54 Sep 23, 2026
91 of 93 checks passed
@christian-byrne
christian-byrne deleted the claude/manual-backport-18552-cloud-1.54 branch September 23, 2026 09:29
christian-byrne pushed a commit that referenced this pull request Sep 23, 2026
…oolCallGroup UI (#18579)

## Summary

`browser_tests/tests/agent/agentToolCallHistoryPersistence.spec.ts:24`
("keeps a completed turn work summary after a browser refresh") fails
deterministically on `core/1.54` since #18554. Fixes it by correcting
the test's UI assertion to match this branch's actual, working
agent-panel component.

<details>
<summary>Full context for agent readers</summary>

## Root cause

#18554 backported #18282 ("restore tool-call work summary on reload and
chat switch") from `main`, including a **new** E2E test. The data-layer
change it ported — `agentTranscript.ts`'s `normalizeAgentTranscript`,
which folds a persisted assistant row's `content.tool_calls` into
`ToolPart`s — is **byte-for-byte identical** between `main` and the
backport, and its 49 existing/added unit tests
(`agentTranscript.test.ts`, `agentConversationStore.test.ts`) pass
unchanged. So the actual bug the PR fixes (tool-call history vanishing
on reload) is already correctly fixed on `core/1.54`.

What's missing is a separate, **unrelated, unbackported** UI redesign
that #18282 on `main` happens to sit on top of: `main` replaced the
agent panel's `ToolCallGroup.vue` (dynamic label: `"Ran {count} tool
calls for {seconds} seconds"`) with a
`WorkSummary.vue`/`ActivityTrace.vue` split, where a settled group's
trigger is the static i18n string `agent.worked` ("Worked"). That
redesign was never backported to `core/1.54` — `ToolCallGroup.vue` is
still what's rendered here, and it still (correctly, per its own pinned
tests, e.g. `T-11 / PM-661 / FE-1301` in `ToolCallGroup.test.ts`)
renders the dynamic "Ran N tool calls..." label.

The backported test, however, was carried over verbatim from `main` and
asserts a button named `enMessages.agent.worked` — text that no
component on `core/1.54` renders (`agent.worked` has zero non-test
usages in this codebase). Reproduced locally: the persisted transcript
restores its `ToolPart`s correctly, but the actual rendered trigger
reads `"Ran 2 tool calls for 0.6 seconds"`, so `getByRole('button', {
name: 'Worked', exact: true })` never matches → the reported timeout.

## Fix

Rather than backport the full main-branch `WorkSummary`/`ActivityTrace`
redesign (a large, unrelated surface, under time pressure and not what
this bug is about), this updates the test's assertion to the label
`ToolCallGroup.vue` actually — and correctly — produces for the mocked
2-call, 600ms-total turn: `/ran 2 tool calls for 0\.6 seconds/i`. The
rest of the test (aria-expanded default state, expand-to-reveal
humanized tool names "Search nodes"/"Add node") already passed against
the existing `ToolCallCard.vue`/`agentToolGlyph.ts` and is untouched.

## Verification

- `pnpm eslint` on the changed file: clean.
- `pnpm exec vue-tsc --noEmit`: no errors on the changed file.
- `npx vitest run` on `ToolCallGroup.test.ts` +
`agentTranscript.test.ts`: 49/49 pass (confirms the data-layer restore
and existing `ToolCallGroup` behavior are both intact and untouched by
this change).
- Pre-commit hooks (oxfmt/oxlint/eslint/typecheck) ran clean on commit.
- Could not execute the Playwright browser test itself in this sandbox
(outbound fetch of the Chromium binary from `cdn.playwright.dev` is
blocked by the environment's proxy allowlist); the fix was validated by
reproducing the exact rendered trigger text via the unit-level
`ToolCallGroup.test.ts` coverage instead, plus reading the mocked test
data (`420ms + 180ms` → `0.6s`, `2` calls) against `ToolCallGroup.vue`'s
`statusLabel`/`ranToolCallsTimed` i18n string directly.

Merging via admin bypass given severity — this is blocking #18559 and
#18574's `playwright-tests (cloud)` checks. Posting a post-merge-review
request comment once merged.

</details>

Claude-Session: https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY

---
_Generated by [Claude
Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
christian-byrne added a commit that referenced this pull request Sep 23, 2026
…ession (#18581) (#18582)

## Summary
Repair the release-only failing assertion introduced by #18555, with
chat-switch coverage from #18581.

## Changes
- cloud/1.54 has ToolCallGroup, not main’s WorkSummary. Its exact
accessible name for the existing payload is "Ran 2 tool calls for 0.6
seconds", not "Worked".
- Preserve all collapse/expand and visible-call assertions. Also require
exactly two rows with their separate 0.4s/0.2s durations, no summary in
a new chat, and restoration via chat history.
- Test-only; no runtime, package pins, feature flags, or deployment
changes. #18574 remains untouched.

## Review Focus
Baseline e790192 reproduced the exact line-132 failure. Its
accessibility snapshot already showed the completed two-call summary and
"Found it." Hydration was working; the backport had assumed a newer
renderer. This is an exact branch-contract adaptation, not a fallback
selector or skipped assertion.

Validation: Cloud browser test plus adjacent prompt-history test: 2
passed (32.3s), retries disabled.
Transcript/store/transport/ToolCallGroup/glyph unit tests: 117 passed.
Browser typecheck, targeted ESLint/oxfmt passed. Await exact-head CI and
source #18581 before merge.

---------

Co-authored-by: Amp <amp@ampcode.com>
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants