Repository navigation
FE-2709 feat(cloud): links to platform carry the active workspace - #18444
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2072 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since f19fb94159cca4393f59e90bf00d1ded3ba4bb73
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-22T15:37:27.333Z",
"gitSha": "31af8db457bfc9733c3d9fb7b3cd512b264b3693",
"branch": "jaewon/fe-2709-cloud-links-to-platform-carry-the-active-workspace",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1993.4379999999692,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.254999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 341.338,
"heapDeltaBytes": 17647500,
"heapUsedBytes": 79516952,
"domNodes": -259,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.192999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1993.8459999999623,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.834999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 283.816,
"heapDeltaBytes": 14818808,
"heapUsedBytes": 76771476,
"domNodes": -260,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 8.273000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1707.868000000019,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.875000000000004,
"layouts": 14,
"layoutDurationMs": 3.0729999999999995,
"taskDurationMs": 604.9030000000001,
"heapDeltaBytes": 17437580,
"heapUsedBytes": 79395652,
"domNodes": -257,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 100.278,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.7770000000446,
"styleRecalcs": 73,
"styleRecalcDurationMs": 18.123,
"layouts": 14,
"layoutDurationMs": 3.439,
"taskDurationMs": 554.4689999999999,
"heapDeltaBytes": 283020,
"heapUsedBytes": 62701092,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 103.19700000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.015999999935,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.319,
"layouts": 6,
"layoutDurationMs": 1.067,
"taskDurationMs": 234.92000000000002,
"heapDeltaBytes": 3199048,
"heapUsedBytes": 70225432,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.217999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.1339999999827,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.796000000000001,
"layouts": 6,
"layoutDurationMs": 1.2560000000000002,
"taskDurationMs": 253.8,
"heapDeltaBytes": 3104192,
"heapUsedBytes": 70538224,
"domNodes": 79,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.579999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 492.16499999999996,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.144000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 303.027,
"heapDeltaBytes": 18259952,
"heapUsedBytes": 80036728,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 106.6,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 483.09099999994487,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.787000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 303.15899999999993,
"heapDeltaBytes": 18247036,
"heapUsedBytes": 80602516,
"domNodes": 19,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 115.99399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 981.2180000000126,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.0919999999999,
"heapDeltaBytes": 34735032,
"heapUsedBytes": 101355184,
"domNodes": 0,
"jsHeapTotalBytes": 19296256,
"scriptDurationMs": 45.058,
"eventListeners": 0,
"totalBlockingTimeMs": 378,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 987.5059999999394,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 631.008,
"heapDeltaBytes": -17393136,
"heapUsedBytes": 72847832,
"domNodes": -293,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 40.488,
"eventListeners": -217,
"totalBlockingTimeMs": 350,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 699.4930000000181,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 294.826,
"heapDeltaBytes": 14480588,
"heapUsedBytes": 89586212,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 96.07600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 100,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 733.6599999999862,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.067,
"heapDeltaBytes": 14747728,
"heapUsedBytes": 90816300,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 104.69300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 120,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5774.353000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4979.708,
"heapDeltaBytes": 12211564,
"heapUsedBytes": 94181332,
"domNodes": -16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 3928.484,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6146.233000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5349.096,
"heapDeltaBytes": -2459068,
"heapUsedBytes": 71885748,
"domNodes": -8,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 4165.637000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 54,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5914.664999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5068.508000000001,
"heapDeltaBytes": 3191856,
"heapUsedBytes": 77615116,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 3928.3280000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6125.9750000000395,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5172.219,
"heapDeltaBytes": 26757316,
"heapUsedBytes": 100760504,
"domNodes": 0,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 4005.2380000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2038.1770000000188,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.108999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.19,
"heapDeltaBytes": 441612,
"heapUsedBytes": 81909352,
"domNodes": -242,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 34.675999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2025.2420000000484,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.269000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.438,
"heapDeltaBytes": 1563748,
"heapUsedBytes": 83486416,
"domNodes": -240,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 29.597000000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2133.1329999999866,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1188.043,
"heapDeltaBytes": -19622936,
"heapUsedBytes": 67438744,
"domNodes": -217,
"jsHeapTotalBytes": 2650112,
"scriptDurationMs": 583.3040000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2092.441000000008,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.917,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1114.5140000000001,
"heapDeltaBytes": -1907756,
"heapUsedBytes": 80181460,
"domNodes": -246,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 526.04,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3143.6330000000225,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.058,
"layouts": 60,
"layoutDurationMs": 13.638000000000002,
"taskDurationMs": 1232.79,
"heapDeltaBytes": 8195272,
"heapUsedBytes": 73495536,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 547.9190000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3181.523000000084,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.476999999999999,
"layouts": 60,
"layoutDurationMs": 14.084,
"taskDurationMs": 1226.6490000000001,
"heapDeltaBytes": -9033012,
"heapUsedBytes": 74358748,
"domNodes": -252,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 564.3829999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2136.006000000009,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.913000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1308.3029999999999,
"heapDeltaBytes": 16843304,
"heapUsedBytes": 83126796,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 633.293,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2154.0320000000293,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.076000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1255.4779999999998,
"heapDeltaBytes": 17240596,
"heapUsedBytes": 82839536,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 607.052,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.1720000000923,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.304999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.272,
"heapDeltaBytes": -7367584,
"heapUsedBytes": 74843364,
"domNodes": -259,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 23.374,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.6950000000224,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.849999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.5040000000001,
"heapDeltaBytes": -4570428,
"heapUsedBytes": 84095588,
"domNodes": -246,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 28.231999999999992,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 407.77300000002015,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.403000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 262.963,
"heapDeltaBytes": 12919044,
"heapUsedBytes": 76559516,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 90.117,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 448.4549999999672,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.5809999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 285.469,
"heapDeltaBytes": 12930444,
"heapUsedBytes": 76552168,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 96.842,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1995.0690000000009,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.082999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 277.72999999999996,
"heapDeltaBytes": -5219336,
"heapUsedBytes": 64490672,
"domNodes": -274,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.013999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1992.7829999999176,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.364000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.41599999999994,
"heapDeltaBytes": 455500,
"heapUsedBytes": 64118896,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.902,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.7589999999764,
"styleRecalcs": 77,
"styleRecalcDurationMs": 20.162,
"layouts": 18,
"layoutDurationMs": 4.515,
"taskDurationMs": 612.673,
"heapDeltaBytes": -1385884,
"heapUsedBytes": 61321380,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 77.82799999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.977000000018,
"styleRecalcs": 77,
"styleRecalcDurationMs": 19.209999999999997,
"layouts": 18,
"layoutDurationMs": 4.2989999999999995,
"taskDurationMs": 585.132,
"heapDeltaBytes": -2530640,
"heapUsedBytes": 61329328,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 76.106,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 815.7520000000886,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.855999999999998,
"layouts": 5,
"layoutDurationMs": 7.4350000000000005,
"taskDurationMs": 589.3900000000001,
"heapDeltaBytes": -6336736,
"heapUsedBytes": 81699184,
"domNodes": 13667,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 19.432,
"eventListeners": 2383,
"totalBlockingTimeMs": 88,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8139.018999999962,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.845,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4027.901,
"heapDeltaBytes": -11948824,
"heapUsedBytes": 67077884,
"domNodes": -216,
"jsHeapTotalBytes": 2088960,
"scriptDurationMs": 1835.4089999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8141.210999999998,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.121,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4119.855,
"heapDeltaBytes": -14227184,
"heapUsedBytes": 64972112,
"domNodes": -251,
"jsHeapTotalBytes": 3399680,
"scriptDurationMs": 1861.1529999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11089.568999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10286.381000000001,
"heapDeltaBytes": -45444600,
"heapUsedBytes": 191321292,
"domNodes": -8062,
"jsHeapTotalBytes": -16908288,
"scriptDurationMs": 145.436,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11797.236999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10815.428,
"heapDeltaBytes": -39855524,
"heapUsedBytes": 183419676,
"domNodes": -8062,
"jsHeapTotalBytes": -9723904,
"scriptDurationMs": 163.956,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13111.129000000004,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.288999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12448.299000000003,
"heapDeltaBytes": -22012748,
"heapUsedBytes": 192994168,
"domNodes": -8062,
"jsHeapTotalBytes": -15020032,
"scriptDurationMs": 618.0949999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14249.482999999942,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.798000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13771.671000000002,
"heapDeltaBytes": -34481760,
"heapUsedBytes": 189319636,
"domNodes": -8062,
"jsHeapTotalBytes": -24125440,
"scriptDurationMs": 714.771,
"eventListeners": -14928,
"totalBlockingTimeMs": 46,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3666.99600000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.419999999999995,
"layouts": 20,
"layoutDurationMs": 20.986000000000004,
"taskDurationMs": 3501.341,
"heapDeltaBytes": -35100156,
"heapUsedBytes": 182381784,
"domNodes": -8061,
"jsHeapTotalBytes": 13692928,
"scriptDurationMs": 59.641999999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 54,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4296.086000000059,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.638999999999996,
"layouts": 20,
"layoutDurationMs": 24.569999999999993,
"taskDurationMs": 4170.666,
"heapDeltaBytes": -45438388,
"heapUsedBytes": 178274080,
"domNodes": -8061,
"jsHeapTotalBytes": 7139328,
"scriptDurationMs": 70.84,
"eventListeners": -14928,
"totalBlockingTimeMs": 20,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5263.768000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4727.843,
"heapDeltaBytes": 20230636,
"heapUsedBytes": 187855012,
"domNodes": 0,
"jsHeapTotalBytes": -18350080,
"scriptDurationMs": 90.426,
"eventListeners": -1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6018.002000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5614.399,
"heapDeltaBytes": -27343700,
"heapUsedBytes": 173850420,
"domNodes": -1,
"jsHeapTotalBytes": -25952256,
"scriptDurationMs": 84.77600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 103.8260000000264,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.132,
"layouts": 4,
"layoutDurationMs": 2.14,
"taskDurationMs": 85.54400000000001,
"heapDeltaBytes": 3376792,
"heapUsedBytes": 65214404,
"domNodes": 137,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.928,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 88.512000000037,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.841999999999999,
"layouts": 3,
"layoutDurationMs": 1.6859999999999997,
"taskDurationMs": 68.659,
"heapDeltaBytes": 3106380,
"heapUsedBytes": 68422456,
"domNodes": 131,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.894000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## jaewon/fe-2646-workspace-deep-link-contract-workspace-in-comfyorgaccount #18444 +/- ##
============================================================================================================
+ Coverage 83.27% 84.27% +0.99%
============================================================================================================
Files 2982 2282 -700
Lines 146704 129515 -17189
Branches 37902 34973 -2929
============================================================================================================
- Hits 122172 109144 -13028
+ Misses 23250 20076 -3174
+ Partials 1282 295 -987
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 706 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…e the session billed (#18443) ## Why A customer who pays for team workspace B on billing-web and clicks **Return to ComfyUI** should land in B. billing-web receives the workspace on the way in (#18316) but dropped it on the way out, so the cloud app opened its browser-wide `Comfy.Workspace.LastWorkspaceId` instead. That is personal, or another workspace if a different tab switched while the customer was paying: "I paid and the app still says Free." ## Root cause `buildReturnUrl` in `@comfyorg/billing-contract` took only `target / environment / result / reference`. No caller could send the workspace even if it wanted to. `CheckoutView`'s hosted-payment result URL (`buildBillingEntryUrl`, intent `result`) also omitted it, so a result opened in a fresh tab (empty `sessionStorage`) bound to personal. ## How - `ReturnUrlInput.workspace` is a **required** key typed `string | undefined`. Every caller must state it, so a future return link that forgets the workspace is a type error. `buildReturnUrl` writes it as `?workspace=` via a new `ENTRY_PARAM_WORKSPACE` constant that the entry field row now also uses (one spelling). Invalid ids are dropped like `reference`. No new runtime dependency. - `useBilledWorkspace()` returns the workspace the session's credential was minted for (what billing acted on), falling back to the tab's entry binding before a mint. `HostedSurface` and `CheckoutView` pass it to `buildReturnUrl`; `resultUrl()` passes it to `buildBillingEntryUrl`. - The cloud app already applies `?workspace=` on arrival, including alongside `?settings=plan-credits` (#18345). Tests: per-target return URLs carry the id and `readWorkspaceLink` reads it back; `undefined` and invalid ids write nothing; component tests assert the minted workspace wins over the binding; billing-web e2e return-link hrefs updated plus a team-workspace return assertion. Each new assertion was confirmed red with the change reverted. ## AS IS / TO BE **Backend: mocked.** Captured with the billing-web Playwright harness (`apps/billing-web/e2e`): a production build, with Firebase and every Cloud billing route answered by `e2e/fixtures/cloud.ts`. Same scenario on both sides: a team-workspace entry link (`workspace=ws_team_e2e`, token minted for "Acme Team"). AS IS is the base branch (`fe-2617` @ `8e1ce9c696`), TO BE is this PR (`1746a49c91`). The red outline marks **Return to ComfyUI**. The dark strip at the bottom is added by the capture script and prints the link's `href` read from the DOM. **Hosted page** (`/v1/subscription?...&workspace=ws_team_e2e`). AS IS `https://testcloud.comfy.org/`, TO BE `https://testcloud.comfy.org/?workspace=ws_team_e2e`. | AS IS | TO BE | |---|---| | <img width="640" alt="fe2708-asis-subscription" src="https://github.com/user-attachments/assets/cfcfa3a2-96f1-4274-a8b4-96718884cf35" /> | <img width="640" alt="fe2708-tobe-subscription" src="https://github.com/user-attachments/assets/1c66d71a-f9ea-4bd4-9c54-afbbde4574fb" /> | **Payment result page** (`/v1/result?...&workspace=ws_team_e2e`, operation succeeded). AS IS `https://testcloud.comfy.org/?billing_result=success&billing_ref=op_1`, TO BE `https://testcloud.comfy.org/?workspace=ws_team_e2e&billing_result=success&billing_ref=op_1`. | AS IS | TO BE | |---|---| | <img width="640" alt="fe2708-asis-result" src="https://github.com/user-attachments/assets/4078424f-b57b-4530-acd3-1488e6a0939e" /> | <img width="640" alt="fe2708-tobe-result" src="https://github.com/user-attachments/assets/d2e09ef6-ef88-4fb4-be5d-031aff75a3a1" /> | Not pictured: the hosted-payment `return_url` sent with `POST /billing/subscribe`. The harness has no Stripe key, so no confirmation token exists to submit; the `CheckoutView` component test covers it. ## Where this sits in the plan Every signed-in link that crosses surfaces carries the workspace, in both directions (ADR AUTH-WORKSPACE-0036, decision 6). Each hop needs a sender that writes `?workspace=` and a receiver that applies it. | Ticket | Change | Hop | PR | |---|---|---|---| | FE-2646 | `?workspace=` contract in `@comfyorg/account-core/workspaceLink` + ADR | all | #18341 | | FE-2617 | billing-web binds its session to the entry link's workspace | → billing-web (receiver) | #18316 | | FE-2618 | Cloud's hosted-billing opener sends the active workspace | cloud → billing-web (sender) | #18318 | | FE-2647 | Cloud opens the workspace a `?workspace=` link names | → cloud (receiver) | #18345 | | FE-2648 | comfy.org carries the active workspace on cloud / platform links | comfy.org → cloud / platform (sender) | #18344 | | FE-2708 | billing-web return and result links carry the billed workspace | billing-web → cloud / platform (sender) | this PR | | FE-2709 | Cloud links to platform carry the active workspace | cloud → platform (sender) | #18444 | | (platform repo) | Platform reads `?workspace=` on usage / API-key / billing routes; platform links send it | platform ↔ others | not in this repo | ```mermaid flowchart LR web[comfy.org] -- "#18344" --> cloud[cloud] web -- "#18344" --> plat[platform] cloud -- "#18318" --> bw[billing-web] bw -- "FE-2708" --> cloud bw -- "FE-2708" --> plat cloud -- "FE-2709" --> plat plat -. "platform repo" .-> cloud plat -. "platform repo" .-> bw linkStyle 3,4 stroke:#e11,stroke-width:3px ```
|
🔗 Commit SHA: a12678f | Docs | View more details | Give us feedback! |
df4f657
into
jaewon/fe-2646-workspace-deep-link-contract-workspace-in-comfyorgaccount
…shared by the auth and billing SDKs (Comfy-Org#18341) ## Why Every future billing or account link that names a workspace has to agree on one parameter name and one contract for what a destination owes it. Before this PR, `@comfyorg/billing-contract`'s entry URL alone defined a `workspace_id` query parameter, and nothing else — not the auth SDK, not the cloud app, not comfy.org — shared a definition of what that parameter means or how a destination should treat it. FE-2647 (cloud app reads the link) and FE-2648 (comfy.org writes the link) both depend on this contract existing first. ## Root cause Not a fix: this is the first PR to define the contract, so nothing was broken. What was missing: the workspace query parameter had no shared home. `@comfyorg/billing-contract`'s `OPTIONAL_ENTRY_FIELDS` (`packages/billing-contract/src/entryFields.ts`) named it `workspace_id` in isolation, with no counterpart in the auth SDK for a non-billing surface to read or write the same link, and no written statement of what "the workspace on a link" is allowed to do — mint against it, fall back from it, or fail closed on it. ## How - Adds `@comfyorg/account-core/workspaceLink` (`packages/account-core/src/workspaceLink.ts`): `WORKSPACE_LINK_PARAM = 'workspace'`, `isWorkspaceId`, `readWorkspaceLink`, `withWorkspaceLink`, `withoutWorkspaceLink`. Module JSDoc states the contract: it's the URL parameter, not the token API's request body field; a destination applies it before loading workspace-scoped content, by minting against it and letting the server decide membership; a payment/billing destination fails closed and never acts on a different workspace; a navigation destination may fall back but must show which workspace it's on rather than switch silently; it survives the sign-in redirect. - Registers the subpath in `package.json`'s `exports` and `publishConfig.exports`, and in `scripts/smokePack.ts`'s typed-consumer source (the `assertTypedConsumerCoversEveryExport` guard there would otherwise fail the pack smoke test on this PR). - Renames `@comfyorg/billing-contract`'s `OPTIONAL_ENTRY_FIELDS` workspace field from `workspace_id` to `workspace` (key stays `workspaceId`, code stays `INVALID_WORKSPACE_ID`) — no alias, since nothing in production ever emitted `workspace_id` as a URL parameter (the hosted billing app is still behind a flag). - Adds `@comfyorg/account-core` as a `devDependency` of `billing-contract` (no runtime dependency; not part of the published tarball) so a parity test can import `WORKSPACE_LINK_PARAM` and assert it equals the entry field's `param`, so the two names can't drift apart silently. Confirmed no dependency cycle (`account-core` does not import `billing-contract`) and `knip` / the account-core pack smoke test stay green. - Fixes every fixture in the repo asserting the literal `workspace_id=` query string on an entry URL: `packages/billing-contract/src/billingEntry.test.ts` and `apps/billing-web/src/router.test.ts`. Left `apps/billing-web/e2e/fixtures/scenario.ts`'s `workspace_id` alone — that's the `resolved_for.workspace_id` field on a `BillingCapabilitiesResponse`, a server response body field, not the entry URL. - Does **not** touch `POST /api/auth/token`'s request body field, which stays `{ workspace_id }` everywhere (`src/platform/workspace/**`). - Adds `docs/adr/AUTH-WORKSPACE-0036-workspace-deep-link-contract.md`, recording the decision, the path-segment and no-alias alternatives considered, and the standalone-package alternative the owner rejected in favor of the auth SDK subpath. No deleted code: this is new surface, and the renamed parameter had no prior production traffic to preserve compatibility with. **This branch now carries the whole wave, not just the contract.** The PRs stacked on it were reviewed separately and merged here rather than onto `main`, because none of them can land before the contract does: - FE-2617 (Comfy-Org#18316) billing-web binds its session to the entry link's workspace - FE-2618 (Comfy-Org#18318) one hosted-billing opener that sends the workspace and refreshes on return - FE-2619 (Comfy-Org#18320) in-app subscribe, plan change and resubscribe hand off to billing-web checkout - FE-2648 (Comfy-Org#18344) comfy.org carries the active workspace on cloud and platform links - FE-2708 (Comfy-Org#18443) billing-web return and result links carry the workspace the session billed - FE-2647 (Comfy-Org#18345) the cloud app opens the workspace a `?workspace=` link names - FE-2709 (Comfy-Org#18444) links to Platform carry the active workspace Two later commits are this branch's own, from resolving `main` and from review: - `ed0f68a7` merges `main`, reconciling this branch's `?workspace=` loader with `main`'s `?assets=1` deep link (Comfy-Org#18442). Both features register in the same ordered loader list; the workspace loader stays first because a successful switch calls `window.location.reload()`, and `main`'s `HANDLED_PARAMS` sweep becomes the last step, so the loop's "reload in flight" stop still short-circuits before it. - `75758244` adds `workspace` to that sweep. `stripParam()` catches a rejected `router.replace` and returns normally, so without the backstop a failed strip left the deep link live with nothing to retry it. ## AS IS / TO BE AS IS: _screenshot pending_ TO BE: _screenshot pending_ ## Testing - `pnpm --filter @comfyorg/account-core test` — 949 passed (57 files), including the new `workspaceLink.test.ts` (table-driven `it.for` coverage of all four functions) and a `redirect.test.ts` case proving `safeInternalPath('/v1/pricing?workspace=w-abc&x=1', origin, '/')` keeps `workspace` through a sign-in redirect. - `pnpm --filter @comfyorg/billing-contract test` — 64 passed (3 files), including the new parity test. - `pnpm --filter @comfyorg/billing-web test:unit` — 125 passed (13 files). - `pnpm --filter @comfyorg/billing-web test:e2e:local` — 15 passed. - `pnpm typecheck` (root, covers account-core, billing-web, account-ui, billing-contract) — clean. - `pnpm --filter @comfyorg/account-core run lint`, `pnpm --filter @comfyorg/billing-contract run lint`, `pnpm --filter @comfyorg/billing-web run lint` — clean. - `pnpm adr:check` — passed. - `pnpm knip` — clean (also ran again via the pre-push hook). - Red run proving the tests fail without the fix: reverted `entryFields.ts`'s param back to `'workspace_id'` and reran `billing-contract`'s tests — the `INVALID_WORKSPACE_ID` fixture and the new parity test both failed (`expected 'workspace_id' to be 'workspace'`), then restored. Separately renamed `workspaceLink.ts` aside and reran `account-core`'s tests — `workspaceLink.test.ts` failed with "Cannot find module './workspaceLink'" (926 of the other 949 tests still passed), then restored. - No flag gates this: the contract has no on/off behavior of its own, so there's no flag-off/on/fallback matrix to prove here — FE-2647 and FE-2648, which consume it, carry that. **Why no `browser_tests/` change.** This PR adds a URL-parameter contract to `packages/account-core` and renames one entry-link parameter in `packages/billing-contract`; it changes no screen. The one commit titled `fix(account)` tightens this PR's own new reader (an empty `?workspace=` is invalid) before anything consumes it, so there is no shipped behaviour to regress. The contract is covered where it is exercised: unit tables for every function, a parity test that fails if billing-contract and account-core disagree, the sign-in redirect survival test, and the billing-web Playwright suite (15 specs) that parses entry links. The browser-level coverage of the new behaviour lands with its consumers, which are now merged into this branch: PR 18345 (cloud app `@cloud` spec for `?workspace=`) and PR 18344 (website e2e for the carried link). The later `fix(url-action-loaders)` commit (`75758244`) is in the same position. It adds `workspace` to `main`'s `HANDLED_PARAMS` sweep so a silently-swallowed `router.replace` rejection can't strand the deep link. The failure it guards against is a rejected router call, which a Playwright run cannot induce; it is pinned instead by three unit tests — one that fails without the change (`expected { workspace: 'w-1', … } to deeply equal { workflow: 'keep-me' }`), one pinning the swallow behaviour itself so it can't change silently, and one proving the sweep still never runs when a switch reload is in flight. ## Where this sits in the plan Milestone 2 moves the cloud app's subscription checkout to billing-web (billing.comfy.org) in a new tab. The workspace deep-link contract (FE-2646) makes every surface open in the workspace the customer came from, with one parameter, `?workspace=`, shared by the auth and billing SDKs. | Ticket | Change | Closes | Repo | Depends on | Status | |---|---|---|---|---|---| | FE-2646 | Workspace deep-link contract in `@comfyorg/account-core/workspaceLink`; billing entry uses `workspace` | one parameter across surfaces | ComfyUI_frontend | none | this PR | | FE-2647 | Cloud app opens the workspace named by `?workspace=` | comfy.org / platform → cloud keeps the workspace | ComfyUI_frontend | FE-2646 | PR 18345 merged into this branch | | FE-2648 | comfy.org carries the active workspace on cloud / platform links | producer side of the contract | ComfyUI_frontend | FE-2646 | PR 18344 merged into this branch | | FE-2617 | billing-web binds its session to the entry link's workspace | workspace B billed as personal | ComfyUI_frontend | FE-2646 | PR 18316 merged into this branch | | FE-2618 | Host: one hosted-billing opener, sends the workspace, refreshes on return | host half of the above, no return refresh | ComfyUI_frontend | FE-2646 | PR 18318 merged into this branch | | FE-2619 | Host: in-app subscribe, plan change, resubscribe hand off to billing-web checkout | checkout never handed off | ComfyUI_frontend | FE-2618 | PR 18320 merged into this branch | | FE-2708 | billing-web return and result links carry the workspace the session billed | return path lost the workspace | ComfyUI_frontend | FE-2646 | PR 18443 merged into this branch | | FE-2709 | Links to Platform carry the active workspace | cloud → platform lost the workspace | ComfyUI_frontend | FE-2646 | PR 18444 merged into this branch | | FE-2620 | billing-web checkout E2E | money path had no browser test | ComfyUI_frontend | none | PR 18315 merged | | FE-2621 | Cloud ingest CORS allows `Idempotency-Key` | every billing-web write blocked | Comfy-Org/cloud | none | cloud#10253 merged | ```mermaid flowchart LR W["FE-2646 workspace deep-link contract"] W --> CA["FE-2647 cloud app reads ?workspace="] W --> WS["FE-2648 comfy.org sends ?workspace="] W --> A["FE-2617 PR 18316 billing-web binds to entry workspace"] W --> B["FE-2618 PR 18318 host opener sends workspace"] B --> C["FE-2619 PR 18320 in-app checkout handoff"] D["FE-2620 PR 18315 billing-web checkout E2E"] E["FE-2621 cloud CORS Idempotency-Key (planned)"] A --> V["M2 test plan rerun"] C --> V D --> V E --> V style W stroke-width:4px ``` Test plan: https://app.notion.com/p/3e26d73d3650815fb78ec0d273278d3b · Workspace deeplinks approaches (ShihChi): https://app.notion.com/p/3e36d73d365081b794bbf431953c1f11
Why
A customer in team workspace B who clicks Full usage activity / View usage history in the cloud app should see B's usage on platform. Cloud opened
platform.comfy.org/profile/usagewith no workspace, so platform showed whatever workspace it last had.Root cause
The three signed-in links to platform's usage page (
SubscriptionFooterLinks.vue,useSubscription.ts,WorkspaceActivityContent.vue) concatenatedgetComfyPlatformBaseUrl()with a path and never applied the active workspace. There was no helper for a cloud → platform link, so each call site built the URL by hand.How
platformLink(path)(src/platform/workspace/utils/platformLink.ts) builds the platform URL and appliesuseTeamWorkspaceStore().activeWorkspaceIdwithwithWorkspaceLinkfrom@comfyorg/account-core/workspaceLink. With no active workspace (OSS, store not initialized) or an id outside the shared charset, it returns the plain URL rather than throwing inside a click handler.WorkspaceActivityContent's link becomes acomputedso it follows a workspace switch.SubscriptionFooterLinks, Settings → Plan & Credits) is reachable in the app today.useSubscription().handleViewUsageHistoryhas no caller andWorkspaceActivityContentis mounted only by its story; they are updated so no platform link insrc/is built without the workspace, and their removal is left to a separate cleanup./payment/success//payment/failedStripe return URLs (the checkout is already bound to a workspace server-side; they are confirmation pages, not workspace-scoped navigation).?workspace=on/profile/usageis the platform repo's half of this hop.Tests: helper cases (carries, omits, replaces a stale param, rejects an invalid id); the three call-site tests now expect
?workspace=<active id>, each confirmed red without the change.AS IS / TO BE
Backend: real (testcloud). Local cloud dev server pointed at
testcloud.comfy.org, signed in, active workspaceteam-test(w-4df077fa-0957-4d7a-94c6-521ddde5bb14, a real team workspace). Settings → Plan & Credits → Full usage activity (red outline).window.openwas stubbed for the capture so the click records its URL instead of opening a tab. The dark strip at the bottom is added by the capture script and prints that URL. AS IS runs the base branch's three call-site files (fe-2646@a2fae4f1be) on the same server and session. TO BE is this PR (a12678f699).AS IS
https://stagingplatform.comfy.org/profile/usage, TO BEhttps://stagingplatform.comfy.org/profile/usage?workspace=w-4df077fa-0957-4d7a-94c6-521ddde5bb14.Not pictured:
useSubscription().handleViewUsageHistory("View usage history") andWorkspaceActivityContent's full-activity link have no reachable UI at this commit. Nothing insrc/calls the handler, and the component is mounted only by its Storybook story. Their unit tests cover both.Where this sits in the plan
Every signed-in link that crosses surfaces carries the workspace, in both directions (ADR AUTH-WORKSPACE-0036, decision 6). Each hop needs a sender that writes
?workspace=and a receiver that applies it.?workspace=contract in@comfyorg/account-core/workspaceLink+ ADR?workspace=link names?workspace=on usage / API-key / billing routes; platform links send it