Repository navigation
FE-2708 feat(billing-web): return and result links carry the workspace the session billed - #18443
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌐 Website E2ETip All tests passed.
🎭 Playwright: ✅ 2076 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 76a5666bc85d34abf04e560de565e436d16775b8
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-22T16:26:26.715Z",
"gitSha": "0391096643bc02bd3c2efbcb2da72093df0a16bd",
"branch": "jaewon/fe-2708-billing-web-return-and-result-links-carry-the-workspace-the",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2003.34799999996,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.915,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.983,
"heapDeltaBytes": -5692172,
"heapUsedBytes": 61684116,
"domNodes": -256,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.939999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2012.0500000000447,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.398,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.462,
"heapDeltaBytes": -381384,
"heapUsedBytes": 66954252,
"domNodes": -258,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.918,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.4270000000188,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.792,
"layouts": 14,
"layoutDurationMs": 2.836,
"taskDurationMs": 575.73,
"heapDeltaBytes": -3739196,
"heapUsedBytes": 63898944,
"domNodes": -258,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 100.243,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1684.5690000000104,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.172,
"layouts": 14,
"layoutDurationMs": 3.15,
"taskDurationMs": 575.908,
"heapDeltaBytes": -3504556,
"heapUsedBytes": 63907104,
"domNodes": -259,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 95.114,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.739999999987,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.217999999999998,
"layouts": 6,
"layoutDurationMs": 1.3120000000000003,
"taskDurationMs": 244.60899999999998,
"heapDeltaBytes": 2179860,
"heapUsedBytes": 64477052,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.48,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.4039999999495,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.406,
"layouts": 6,
"layoutDurationMs": 0.9479999999999998,
"taskDurationMs": 234.89100000000002,
"heapDeltaBytes": 3197716,
"heapUsedBytes": 70483796,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.338999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 449.2650000000822,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.739,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 290.466,
"heapDeltaBytes": 18118300,
"heapUsedBytes": 80349260,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 99.73,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 510.14599999996335,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.275,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 299.406,
"heapDeltaBytes": 18220428,
"heapUsedBytes": 80554360,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 106.81099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1049.4109999999637,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 683.3620000000001,
"heapDeltaBytes": -13058964,
"heapUsedBytes": 72997160,
"domNodes": -293,
"jsHeapTotalBytes": 19267584,
"scriptDurationMs": 41.964,
"eventListeners": -217,
"totalBlockingTimeMs": 397,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 957.809999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.0930000000001,
"heapDeltaBytes": 34450928,
"heapUsedBytes": 101796136,
"domNodes": 0,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 41.598000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 361,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 698.1580000000349,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 291.7829999999997,
"heapDeltaBytes": 14025924,
"heapUsedBytes": 90312776,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 95.084,
"eventListeners": 0,
"totalBlockingTimeMs": 101,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 698.757999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 283.79200000000003,
"heapDeltaBytes": 14417840,
"heapUsedBytes": 89921332,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 89.87100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 97,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6157.340999999974,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.9980000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5262.651,
"heapDeltaBytes": -343808,
"heapUsedBytes": 81662208,
"domNodes": -14,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 4051.7279999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 47,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6297.0450000000255,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5372.063,
"heapDeltaBytes": -10515160,
"heapUsedBytes": 71856608,
"domNodes": -16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 4103.746,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6212.260999999899,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5316.351,
"heapDeltaBytes": -5454372,
"heapUsedBytes": 76436232,
"domNodes": -12,
"jsHeapTotalBytes": 17301504,
"scriptDurationMs": 4259.609,
"eventListeners": 0,
"totalBlockingTimeMs": 43,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6312.8339999999525,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5359.637,
"heapDeltaBytes": -13015300,
"heapUsedBytes": 68577956,
"domNodes": -16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 4104.326999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 28,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2008.6649999999509,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.222000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.4939999999999,
"heapDeltaBytes": -7419560,
"heapUsedBytes": 79530996,
"domNodes": -246,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 27.15399999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2006.2060000000201,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.049,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.96599999999995,
"heapDeltaBytes": -3390636,
"heapUsedBytes": 83749700,
"domNodes": -243,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 31.401,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2104.1810000000396,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.355999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1117.2569999999998,
"heapDeltaBytes": 16176148,
"heapUsedBytes": 80099520,
"domNodes": -242,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 545.45,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2131.616000000008,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.358,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1167.04,
"heapDeltaBytes": -11809384,
"heapUsedBytes": 76098864,
"domNodes": -216,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 579.527,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3137.62399999996,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.077999999999998,
"layouts": 60,
"layoutDurationMs": 13.876000000000001,
"taskDurationMs": 1237.743,
"heapDeltaBytes": 7271672,
"heapUsedBytes": 73616840,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 546.5490000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3132.131000000072,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.528000000000002,
"layouts": 60,
"layoutDurationMs": 13.868,
"taskDurationMs": 1296.1490000000001,
"heapDeltaBytes": -10260596,
"heapUsedBytes": 72757664,
"domNodes": -251,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 545.892,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2195.414000000028,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.918,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1357.6779999999999,
"heapDeltaBytes": -16194204,
"heapUsedBytes": 74684408,
"domNodes": -217,
"jsHeapTotalBytes": 2088960,
"scriptDurationMs": 641.0859999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2187.7600000000257,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.925999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1418.003,
"heapDeltaBytes": -10963436,
"heapUsedBytes": 75029432,
"domNodes": -252,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 678.0070000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.9820000000745,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.747999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.57500000000005,
"heapDeltaBytes": -9320288,
"heapUsedBytes": 80254164,
"domNodes": -250,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 27.623999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2032.096000000024,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.253000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.828,
"heapDeltaBytes": -9583204,
"heapUsedBytes": 79216644,
"domNodes": -251,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 29.84599999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 381.0290000000123,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.963,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 246.11299999999997,
"heapDeltaBytes": 13780692,
"heapUsedBytes": 83420464,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 91.048,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 412.9449999999224,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.048,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 265.52,
"heapDeltaBytes": 13750344,
"heapUsedBytes": 76358648,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 92.467,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1993.1360000000495,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.211,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.48,
"heapDeltaBytes": 906180,
"heapUsedBytes": 64519748,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.569999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2005.7959999999184,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.9769999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.137,
"heapDeltaBytes": 8089252,
"heapUsedBytes": 77805532,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.006,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.6389999999383,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.644000000000002,
"layouts": 18,
"layoutDurationMs": 4.059,
"taskDurationMs": 566.123,
"heapDeltaBytes": -1347256,
"heapUsedBytes": 61321380,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 70.43900000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.6370000000807,
"styleRecalcs": 78,
"styleRecalcDurationMs": 18.793999999999997,
"layouts": 18,
"layoutDurationMs": 4.358,
"taskDurationMs": 583.2310000000001,
"heapDeltaBytes": 17566016,
"heapUsedBytes": 81110332,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 74.14899999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 849.7200000000475,
"styleRecalcs": 17,
"styleRecalcDurationMs": 20.476999999999997,
"layouts": 5,
"layoutDurationMs": 8.036999999999999,
"taskDurationMs": 630.925,
"heapDeltaBytes": -6326672,
"heapUsedBytes": 81429952,
"domNodes": 13667,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 21.788,
"eventListeners": 2383,
"totalBlockingTimeMs": 98,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8173.147999999969,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.318999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3992.593,
"heapDeltaBytes": -20319552,
"heapUsedBytes": 66661356,
"domNodes": -217,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 1818.8300000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8129.700000000071,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.87,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4017.8120000000004,
"heapDeltaBytes": 3324816,
"heapUsedBytes": 84666848,
"domNodes": -241,
"jsHeapTotalBytes": -1843200,
"scriptDurationMs": 1822.769,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 11898.900000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10848.491,
"heapDeltaBytes": -41394020,
"heapUsedBytes": 182885216,
"domNodes": -8062,
"jsHeapTotalBytes": -17240064,
"scriptDurationMs": 153.35999999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11534.290000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10579.713000000002,
"heapDeltaBytes": -48013996,
"heapUsedBytes": 175349812,
"domNodes": -8062,
"jsHeapTotalBytes": -20647936,
"scriptDurationMs": 179.73600000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13787.408000000029,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.267000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13108.426000000001,
"heapDeltaBytes": -55070772,
"heapUsedBytes": 168494172,
"domNodes": -8062,
"jsHeapTotalBytes": -21434368,
"scriptDurationMs": 676.754,
"eventListeners": -14928,
"totalBlockingTimeMs": 5,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13641.778000000046,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.670999999999989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12949.153000000002,
"heapDeltaBytes": -38552684,
"heapUsedBytes": 190718632,
"domNodes": -8062,
"jsHeapTotalBytes": -12111872,
"scriptDurationMs": 633.9240000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4257.07900000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.85400000000001,
"layouts": 20,
"layoutDurationMs": 23.173,
"taskDurationMs": 4149.275000000001,
"heapDeltaBytes": -22112296,
"heapUsedBytes": 195296500,
"domNodes": -8062,
"jsHeapTotalBytes": 10547200,
"scriptDurationMs": 68.497,
"eventListeners": -14928,
"totalBlockingTimeMs": 11,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4259.400000000028,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.565000000000005,
"layouts": 20,
"layoutDurationMs": 21.936999999999998,
"taskDurationMs": 4149.678,
"heapDeltaBytes": -46541296,
"heapUsedBytes": 176431516,
"domNodes": -8061,
"jsHeapTotalBytes": 17235968,
"scriptDurationMs": 66.54400000000003,
"eventListeners": -14928,
"totalBlockingTimeMs": 6,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5754.970999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5294.44,
"heapDeltaBytes": -5277764,
"heapUsedBytes": 190270464,
"domNodes": 0,
"jsHeapTotalBytes": -24641536,
"scriptDurationMs": 74.80999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6074.662999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5623.899999999999,
"heapDeltaBytes": 10132852,
"heapUsedBytes": 183877480,
"domNodes": 0,
"jsHeapTotalBytes": -17039360,
"scriptDurationMs": 83.16499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 73.39600000000246,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.24,
"layouts": 3,
"layoutDurationMs": 1.1419999999999997,
"taskDurationMs": 54.48500000000001,
"heapDeltaBytes": 3170720,
"heapUsedBytes": 68574316,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.8149999999999995,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 74.22300000007453,
"styleRecalcs": 4,
"styleRecalcDurationMs": 8.243999999999998,
"layouts": 2,
"layoutDurationMs": 1.002,
"taskDurationMs": 51.839,
"heapDeltaBytes": 3039552,
"heapUsedBytes": 64773832,
"domNodes": 122,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 4.506999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## jaewon/fe-2646-workspace-deep-link-contract-workspace-in-comfyorgaccount #18443 +/- ##
============================================================================================================
- Coverage 83.37% 83.31% -0.07%
============================================================================================================
Files 2995 2987 -8
Lines 147316 146800 -516
Branches 38254 38128 -126
============================================================================================================
- Hits 122826 122306 -520
- Misses 23200 23205 +5
+ Partials 1290 1289 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 69 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at exact head 1746a49c91a0ecd301a89f8015bdf5699ad36d7b.
- Return links and hosted-payment result URLs carry the workspace actually billed.
- The typed contract makes every caller state whether a workspace exists.
- Exact-head remote CI is green.
Full context for agent readers
I reviewed the three workspace-return commits separately from the already-reviewed billing-web workspace-binding parent. buildReturnUrl validates and writes the shared workspace parameter for every registered destination. Billing-web prefers the minted session workspace, which is the authority for what billing acted on, and uses the entry binding only before a credential exists. Both the customer-facing return link and Stripe result URL use that same source.
Coverage distinguishes minted workspace from a conflicting entry binding, checks the pre-mint fallback, verifies all destinations plus invalid and absent identifiers, and exercises the real billing-web route through remote E2E. The branch currently conflicts after its parent advanced; reconcile that before merge, and request re-review if the head changes.
Local heavy verification remains deferred under the owner resource-safety directive; this decision uses exact-head source inspection and completed remote CI.
buildReturnUrl takes a required workspace key and writes it under the entry contract's workspace param, so a destination opens in the workspace billing acted on instead of its own last-used one. Required-with-undefined makes every caller state it; an id outside the contract charset is dropped like a reference. billing-web passes the workspace the session's credential was minted for, falling back to the entry binding before a mint, on both return links and on the hosted-payment result URL, so a result opened in a fresh tab binds to the billed workspace instead of personal.
1746a49 to
ef3c184
Compare
cb183a3
into
jaewon/fe-2646-workspace-deep-link-contract-workspace-in-comfyorgaccount
…8444) ## Why A customer in team workspace B who clicks **Full usage activity** / **View usage history** in the cloud app should see B's usage on platform. Cloud opened `platform.comfy.org/profile/usage` with no workspace, so platform showed whatever workspace it last had. ## Root cause The three signed-in links to platform's usage page (`SubscriptionFooterLinks.vue`, `useSubscription.ts`, `WorkspaceActivityContent.vue`) concatenated `getComfyPlatformBaseUrl()` with a path and never applied the active workspace. There was no helper for a cloud → platform link, so each call site built the URL by hand. ## How - `platformLink(path)` (`src/platform/workspace/utils/platformLink.ts`) builds the platform URL and applies `useTeamWorkspaceStore().activeWorkspaceId` with `withWorkspaceLink` from `@comfyorg/account-core/workspaceLink`. With no active workspace (OSS, store not initialized) or an id outside the shared charset, it returns the plain URL rather than throwing inside a click handler. - All three usage links use it. `WorkspaceActivityContent`'s link becomes a `computed` so it follows a workspace switch. - Only **Full usage activity** (`SubscriptionFooterLinks`, Settings → Plan & Credits) is reachable in the app today. `useSubscription().handleViewUsageHistory` has no caller and `WorkspaceActivityContent` is mounted only by its story; they are updated so no platform link in `src/` is built without the workspace, and their removal is left to a separate cleanup. - Left alone on purpose: the sign-in dialog and API-key form links (signed out, no workspace to carry) and the `/payment/success` / `/payment/failed` Stripe return URLs (the checkout is already bound to a workspace server-side; they are confirmation pages, not workspace-scoped navigation). - Platform reading `?workspace=` on `/profile/usage` is the platform repo's half of this hop. Tests: helper cases (carries, omits, replaces a stale param, rejects an invalid id); the three call-site tests now expect `?workspace=<active id>`, each confirmed red without the change. ## AS IS / TO BE **Backend: real (testcloud).** Local cloud dev server pointed at `testcloud.comfy.org`, signed in, active workspace `team-test` (`w-4df077fa-0957-4d7a-94c6-521ddde5bb14`, a real team workspace). Settings → Plan & Credits → **Full usage activity** (red outline). `window.open` was stubbed for the capture so the click records its URL instead of opening a tab. The dark strip at the bottom is added by the capture script and prints that URL. AS IS runs the base branch's three call-site files (`fe-2646` @ `a2fae4f1be`) on the same server and session. TO BE is this PR (`a12678f699`). AS IS `https://stagingplatform.comfy.org/profile/usage`, TO BE `https://stagingplatform.comfy.org/profile/usage?workspace=w-4df077fa-0957-4d7a-94c6-521ddde5bb14`. | AS IS | TO BE | |---|---| | <img width="477" alt="fe2709-asis-full-usage-activity" src="https://github.com/user-attachments/assets/5229c7cf-c403-456a-ba40-af663a57abd8" /> | <img width="477" alt="fe2709-tobe-full-usage-activity" src="https://github.com/user-attachments/assets/cd388752-9259-4d40-987f-2b9175a54573" /> | Not pictured: `useSubscription().handleViewUsageHistory` ("View usage history") and `WorkspaceActivityContent`'s full-activity link have no reachable UI at this commit. Nothing in `src/` calls the handler, and the component is mounted only by its Storybook story. Their unit tests cover both. ## Where this sits in the plan Every signed-in link that crosses surfaces carries the workspace, in both directions (ADR AUTH-WORKSPACE-0036, decision 6). Each hop needs a sender that writes `?workspace=` and a receiver that applies it. | Ticket | Change | Hop | PR | |---|---|---|---| | FE-2646 | `?workspace=` contract in `@comfyorg/account-core/workspaceLink` + ADR | all | #18341 | | FE-2617 | billing-web binds its session to the entry link's workspace | → billing-web (receiver) | #18316 | | FE-2618 | Cloud's hosted-billing opener sends the active workspace | cloud → billing-web (sender) | #18318 | | FE-2647 | Cloud opens the workspace a `?workspace=` link names | → cloud (receiver) | #18345 | | FE-2648 | comfy.org carries the active workspace on cloud / platform links | comfy.org → cloud / platform (sender) | #18344 | | FE-2708 | billing-web return and result links carry the billed workspace | billing-web → cloud / platform (sender) | #18443 | | FE-2709 | Cloud links to platform carry the active workspace | cloud → platform (sender) | this PR | | (platform repo) | Platform reads `?workspace=` on usage / API-key / billing routes; platform links send it | platform ↔ others | not in this repo | ```mermaid flowchart LR web[comfy.org] -- "#18344" --> cloud[cloud] web -- "#18344" --> plat[platform] cloud -- "#18318" --> bw[billing-web] bw -- "FE-2708" --> cloud bw -- "FE-2708" --> plat cloud -- "FE-2709" --> plat plat -. "platform repo" .-> cloud plat -. "platform repo" .-> bw linkStyle 5 stroke:#e11,stroke-width:3px ```
…shared by the auth and billing SDKs (Comfy-Org#18341) ## Why Every future billing or account link that names a workspace has to agree on one parameter name and one contract for what a destination owes it. Before this PR, `@comfyorg/billing-contract`'s entry URL alone defined a `workspace_id` query parameter, and nothing else — not the auth SDK, not the cloud app, not comfy.org — shared a definition of what that parameter means or how a destination should treat it. FE-2647 (cloud app reads the link) and FE-2648 (comfy.org writes the link) both depend on this contract existing first. ## Root cause Not a fix: this is the first PR to define the contract, so nothing was broken. What was missing: the workspace query parameter had no shared home. `@comfyorg/billing-contract`'s `OPTIONAL_ENTRY_FIELDS` (`packages/billing-contract/src/entryFields.ts`) named it `workspace_id` in isolation, with no counterpart in the auth SDK for a non-billing surface to read or write the same link, and no written statement of what "the workspace on a link" is allowed to do — mint against it, fall back from it, or fail closed on it. ## How - Adds `@comfyorg/account-core/workspaceLink` (`packages/account-core/src/workspaceLink.ts`): `WORKSPACE_LINK_PARAM = 'workspace'`, `isWorkspaceId`, `readWorkspaceLink`, `withWorkspaceLink`, `withoutWorkspaceLink`. Module JSDoc states the contract: it's the URL parameter, not the token API's request body field; a destination applies it before loading workspace-scoped content, by minting against it and letting the server decide membership; a payment/billing destination fails closed and never acts on a different workspace; a navigation destination may fall back but must show which workspace it's on rather than switch silently; it survives the sign-in redirect. - Registers the subpath in `package.json`'s `exports` and `publishConfig.exports`, and in `scripts/smokePack.ts`'s typed-consumer source (the `assertTypedConsumerCoversEveryExport` guard there would otherwise fail the pack smoke test on this PR). - Renames `@comfyorg/billing-contract`'s `OPTIONAL_ENTRY_FIELDS` workspace field from `workspace_id` to `workspace` (key stays `workspaceId`, code stays `INVALID_WORKSPACE_ID`) — no alias, since nothing in production ever emitted `workspace_id` as a URL parameter (the hosted billing app is still behind a flag). - Adds `@comfyorg/account-core` as a `devDependency` of `billing-contract` (no runtime dependency; not part of the published tarball) so a parity test can import `WORKSPACE_LINK_PARAM` and assert it equals the entry field's `param`, so the two names can't drift apart silently. Confirmed no dependency cycle (`account-core` does not import `billing-contract`) and `knip` / the account-core pack smoke test stay green. - Fixes every fixture in the repo asserting the literal `workspace_id=` query string on an entry URL: `packages/billing-contract/src/billingEntry.test.ts` and `apps/billing-web/src/router.test.ts`. Left `apps/billing-web/e2e/fixtures/scenario.ts`'s `workspace_id` alone — that's the `resolved_for.workspace_id` field on a `BillingCapabilitiesResponse`, a server response body field, not the entry URL. - Does **not** touch `POST /api/auth/token`'s request body field, which stays `{ workspace_id }` everywhere (`src/platform/workspace/**`). - Adds `docs/adr/AUTH-WORKSPACE-0036-workspace-deep-link-contract.md`, recording the decision, the path-segment and no-alias alternatives considered, and the standalone-package alternative the owner rejected in favor of the auth SDK subpath. No deleted code: this is new surface, and the renamed parameter had no prior production traffic to preserve compatibility with. **This branch now carries the whole wave, not just the contract.** The PRs stacked on it were reviewed separately and merged here rather than onto `main`, because none of them can land before the contract does: - FE-2617 (Comfy-Org#18316) billing-web binds its session to the entry link's workspace - FE-2618 (Comfy-Org#18318) one hosted-billing opener that sends the workspace and refreshes on return - FE-2619 (Comfy-Org#18320) in-app subscribe, plan change and resubscribe hand off to billing-web checkout - FE-2648 (Comfy-Org#18344) comfy.org carries the active workspace on cloud and platform links - FE-2708 (Comfy-Org#18443) billing-web return and result links carry the workspace the session billed - FE-2647 (Comfy-Org#18345) the cloud app opens the workspace a `?workspace=` link names - FE-2709 (Comfy-Org#18444) links to Platform carry the active workspace Two later commits are this branch's own, from resolving `main` and from review: - `ed0f68a7` merges `main`, reconciling this branch's `?workspace=` loader with `main`'s `?assets=1` deep link (Comfy-Org#18442). Both features register in the same ordered loader list; the workspace loader stays first because a successful switch calls `window.location.reload()`, and `main`'s `HANDLED_PARAMS` sweep becomes the last step, so the loop's "reload in flight" stop still short-circuits before it. - `75758244` adds `workspace` to that sweep. `stripParam()` catches a rejected `router.replace` and returns normally, so without the backstop a failed strip left the deep link live with nothing to retry it. ## AS IS / TO BE AS IS: _screenshot pending_ TO BE: _screenshot pending_ ## Testing - `pnpm --filter @comfyorg/account-core test` — 949 passed (57 files), including the new `workspaceLink.test.ts` (table-driven `it.for` coverage of all four functions) and a `redirect.test.ts` case proving `safeInternalPath('/v1/pricing?workspace=w-abc&x=1', origin, '/')` keeps `workspace` through a sign-in redirect. - `pnpm --filter @comfyorg/billing-contract test` — 64 passed (3 files), including the new parity test. - `pnpm --filter @comfyorg/billing-web test:unit` — 125 passed (13 files). - `pnpm --filter @comfyorg/billing-web test:e2e:local` — 15 passed. - `pnpm typecheck` (root, covers account-core, billing-web, account-ui, billing-contract) — clean. - `pnpm --filter @comfyorg/account-core run lint`, `pnpm --filter @comfyorg/billing-contract run lint`, `pnpm --filter @comfyorg/billing-web run lint` — clean. - `pnpm adr:check` — passed. - `pnpm knip` — clean (also ran again via the pre-push hook). - Red run proving the tests fail without the fix: reverted `entryFields.ts`'s param back to `'workspace_id'` and reran `billing-contract`'s tests — the `INVALID_WORKSPACE_ID` fixture and the new parity test both failed (`expected 'workspace_id' to be 'workspace'`), then restored. Separately renamed `workspaceLink.ts` aside and reran `account-core`'s tests — `workspaceLink.test.ts` failed with "Cannot find module './workspaceLink'" (926 of the other 949 tests still passed), then restored. - No flag gates this: the contract has no on/off behavior of its own, so there's no flag-off/on/fallback matrix to prove here — FE-2647 and FE-2648, which consume it, carry that. **Why no `browser_tests/` change.** This PR adds a URL-parameter contract to `packages/account-core` and renames one entry-link parameter in `packages/billing-contract`; it changes no screen. The one commit titled `fix(account)` tightens this PR's own new reader (an empty `?workspace=` is invalid) before anything consumes it, so there is no shipped behaviour to regress. The contract is covered where it is exercised: unit tables for every function, a parity test that fails if billing-contract and account-core disagree, the sign-in redirect survival test, and the billing-web Playwright suite (15 specs) that parses entry links. The browser-level coverage of the new behaviour lands with its consumers, which are now merged into this branch: PR 18345 (cloud app `@cloud` spec for `?workspace=`) and PR 18344 (website e2e for the carried link). The later `fix(url-action-loaders)` commit (`75758244`) is in the same position. It adds `workspace` to `main`'s `HANDLED_PARAMS` sweep so a silently-swallowed `router.replace` rejection can't strand the deep link. The failure it guards against is a rejected router call, which a Playwright run cannot induce; it is pinned instead by three unit tests — one that fails without the change (`expected { workspace: 'w-1', … } to deeply equal { workflow: 'keep-me' }`), one pinning the swallow behaviour itself so it can't change silently, and one proving the sweep still never runs when a switch reload is in flight. ## Where this sits in the plan Milestone 2 moves the cloud app's subscription checkout to billing-web (billing.comfy.org) in a new tab. The workspace deep-link contract (FE-2646) makes every surface open in the workspace the customer came from, with one parameter, `?workspace=`, shared by the auth and billing SDKs. | Ticket | Change | Closes | Repo | Depends on | Status | |---|---|---|---|---|---| | FE-2646 | Workspace deep-link contract in `@comfyorg/account-core/workspaceLink`; billing entry uses `workspace` | one parameter across surfaces | ComfyUI_frontend | none | this PR | | FE-2647 | Cloud app opens the workspace named by `?workspace=` | comfy.org / platform → cloud keeps the workspace | ComfyUI_frontend | FE-2646 | PR 18345 merged into this branch | | FE-2648 | comfy.org carries the active workspace on cloud / platform links | producer side of the contract | ComfyUI_frontend | FE-2646 | PR 18344 merged into this branch | | FE-2617 | billing-web binds its session to the entry link's workspace | workspace B billed as personal | ComfyUI_frontend | FE-2646 | PR 18316 merged into this branch | | FE-2618 | Host: one hosted-billing opener, sends the workspace, refreshes on return | host half of the above, no return refresh | ComfyUI_frontend | FE-2646 | PR 18318 merged into this branch | | FE-2619 | Host: in-app subscribe, plan change, resubscribe hand off to billing-web checkout | checkout never handed off | ComfyUI_frontend | FE-2618 | PR 18320 merged into this branch | | FE-2708 | billing-web return and result links carry the workspace the session billed | return path lost the workspace | ComfyUI_frontend | FE-2646 | PR 18443 merged into this branch | | FE-2709 | Links to Platform carry the active workspace | cloud → platform lost the workspace | ComfyUI_frontend | FE-2646 | PR 18444 merged into this branch | | FE-2620 | billing-web checkout E2E | money path had no browser test | ComfyUI_frontend | none | PR 18315 merged | | FE-2621 | Cloud ingest CORS allows `Idempotency-Key` | every billing-web write blocked | Comfy-Org/cloud | none | cloud#10253 merged | ```mermaid flowchart LR W["FE-2646 workspace deep-link contract"] W --> CA["FE-2647 cloud app reads ?workspace="] W --> WS["FE-2648 comfy.org sends ?workspace="] W --> A["FE-2617 PR 18316 billing-web binds to entry workspace"] W --> B["FE-2618 PR 18318 host opener sends workspace"] B --> C["FE-2619 PR 18320 in-app checkout handoff"] D["FE-2620 PR 18315 billing-web checkout E2E"] E["FE-2621 cloud CORS Idempotency-Key (planned)"] A --> V["M2 test plan rerun"] C --> V D --> V E --> V style W stroke-width:4px ``` Test plan: https://app.notion.com/p/3e26d73d3650815fb78ec0d273278d3b · Workspace deeplinks approaches (ShihChi): https://app.notion.com/p/3e36d73d365081b794bbf431953c1f11
Why
A customer who pays for team workspace B on billing-web and clicks Return to ComfyUI should land in B. billing-web receives the workspace on the way in (#18316) but dropped it on the way out, so the cloud app opened its browser-wide
Comfy.Workspace.LastWorkspaceIdinstead. That is personal, or another workspace if a different tab switched while the customer was paying: "I paid and the app still says Free."Root cause
buildReturnUrlin@comfyorg/billing-contracttook onlytarget / environment / result / reference. No caller could send the workspace even if it wanted to.CheckoutView's hosted-payment result URL (buildBillingEntryUrl, intentresult) also omitted it, so a result opened in a fresh tab (emptysessionStorage) bound to personal.How
ReturnUrlInput.workspaceis a required key typedstring | undefined. Every caller must state it, so a future return link that forgets the workspace is a type error.buildReturnUrlwrites it as?workspace=via a newENTRY_PARAM_WORKSPACEconstant that the entry field row now also uses (one spelling). Invalid ids are dropped likereference. No new runtime dependency.useBilledWorkspace()returns the workspace the session's credential was minted for (what billing acted on), falling back to the tab's entry binding before a mint.HostedSurfaceandCheckoutViewpass it tobuildReturnUrl;resultUrl()passes it tobuildBillingEntryUrl.?workspace=on arrival, including alongside?settings=plan-credits(FE-2647 feat(workspace): open the workspace a ?workspace= link names #18345).Tests: per-target return URLs carry the id and
readWorkspaceLinkreads it back;undefinedand invalid ids write nothing; component tests assert the minted workspace wins over the binding; billing-web e2e return-link hrefs updated plus a team-workspace return assertion. Each new assertion was confirmed red with the change reverted.AS IS / TO BE
Backend: mocked. Captured with the billing-web Playwright harness (
apps/billing-web/e2e): a production build, with Firebase and every Cloud billing route answered bye2e/fixtures/cloud.ts. Same scenario on both sides: a team-workspace entry link (workspace=ws_team_e2e, token minted for "Acme Team"). AS IS is the base branch (fe-2617@8e1ce9c696), TO BE is this PR (1746a49c91). The red outline marks Return to ComfyUI. The dark strip at the bottom is added by the capture script and prints the link'shrefread from the DOM.Hosted page (
/v1/subscription?...&workspace=ws_team_e2e). AS IShttps://testcloud.comfy.org/, TO BEhttps://testcloud.comfy.org/?workspace=ws_team_e2e.Payment result page (
/v1/result?...&workspace=ws_team_e2e, operation succeeded). AS IShttps://testcloud.comfy.org/?billing_result=success&billing_ref=op_1, TO BEhttps://testcloud.comfy.org/?workspace=ws_team_e2e&billing_result=success&billing_ref=op_1.Not pictured: the hosted-payment
return_urlsent withPOST /billing/subscribe. The harness has no Stripe key, so no confirmation token exists to submit; theCheckoutViewcomponent test covers it.Where this sits in the plan
Every signed-in link that crosses surfaces carries the workspace, in both directions (ADR AUTH-WORKSPACE-0036, decision 6). Each hop needs a sender that writes
?workspace=and a receiver that applies it.?workspace=contract in@comfyorg/account-core/workspaceLink+ ADR?workspace=link names?workspace=on usage / API-key / billing routes; platform links send it