Repository navigation
[backport core/1.54] fix(agent-crdt): scope layout mint ops to the bound document's root graph - #18356
Conversation
…raph (#18109) Backport of #18109 to core/1.54. While the Agent panel is bound to a workflow, switching to another workflow tab reuses the same in-memory root graph object for the new tab's nodes before the panel's document binding has caught up. Every node LiteGraph attaches during that window queued a layout createNode change, and the mint port did not check which graph a change belonged to, so those changes for the new tab were minted as add_node operations and sent into the previous tab's still-bound document. The layout mint port now compares every root-scoped createNode/deleteNode/clearGraph change against the bound document's own root graph id. A change naming a different graph is dropped and reported once instead of being minted. Cherry-pick of f664247 onto core/1.54. Conflicts in layoutMintPort.ts, layoutMintPort.test.ts, layoutStoreMintDelivery.test.ts and AgentPanelRoot.vue were resolved by taking the incoming change as-is (the target's side of each hunk was empty). Backported the withoutGhostFlag helper into layoutMintPort.ts and the toRootGraphId import into AgentPanelRoot.test.ts, both dependencies from earlier main commits (#18191 and an unbackported test import) not yet on core/1.54 but required for this change to compile.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1935 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T04:49:14.164Z",
"gitSha": "cedd158d1c97fb6abb358eba59362522c7703133",
"branch": "backport-18109-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.8010000000386,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.9990000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.6650000000001,
"heapDeltaBytes": 671240,
"heapUsedBytes": 64998032,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7.714,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.0020000000432,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.105000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.28900000000004,
"heapDeltaBytes": -10796500,
"heapUsedBytes": 59488420,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.231,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1778.1039999999848,
"styleRecalcs": 71,
"styleRecalcDurationMs": 21.449,
"layouts": 14,
"layoutDurationMs": 3.5509999999999993,
"taskDurationMs": 711.426,
"heapDeltaBytes": -9655516,
"heapUsedBytes": 59795028,
"domNodes": -283,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 118.21000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1707.3559999999475,
"styleRecalcs": 74,
"styleRecalcDurationMs": 22.938,
"layouts": 14,
"layoutDurationMs": 3.615999999999999,
"taskDurationMs": 666.9350000000001,
"heapDeltaBytes": -13749736,
"heapUsedBytes": 57052020,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 112.663,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1658.095000000003,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.357000000000001,
"layouts": 6,
"layoutDurationMs": 0.977,
"taskDurationMs": 282.183,
"heapDeltaBytes": 4403224,
"heapUsedBytes": 74545804,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 9.372999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1671.7399999999998,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.491,
"layouts": 6,
"layoutDurationMs": 0.8389999999999999,
"taskDurationMs": 279.17900000000003,
"heapDeltaBytes": 4659352,
"heapUsedBytes": 75664840,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.247999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 534.7079999999664,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.0809999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.155,
"heapDeltaBytes": 18102712,
"heapUsedBytes": 83046160,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 123.67500000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 531.4989999999966,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.768,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.33,
"heapDeltaBytes": -8028332,
"heapUsedBytes": 62838628,
"domNodes": 20,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 125.136,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2007.7200000000062,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.411999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.297,
"heapDeltaBytes": 5975152,
"heapUsedBytes": 82549716,
"domNodes": -274,
"jsHeapTotalBytes": -892928,
"scriptDurationMs": 28.752999999999993,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2036.2480000000005,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.191999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.0799999999999,
"heapDeltaBytes": 10925636,
"heapUsedBytes": 87424352,
"domNodes": -270,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 26.347999999999995,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2195.4840000000218,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.610999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1317.319,
"heapDeltaBytes": 6327536,
"heapUsedBytes": 83733368,
"domNodes": -240,
"jsHeapTotalBytes": -1191936,
"scriptDurationMs": 652.7389999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2166.3800000000037,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.774999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1299.125,
"heapDeltaBytes": -7788400,
"heapUsedBytes": 68777992,
"domNodes": -279,
"jsHeapTotalBytes": -106496,
"scriptDurationMs": 620.992,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3216.7440000000056,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.937000000000001,
"layouts": 60,
"layoutDurationMs": 11.106,
"taskDurationMs": 1436.485,
"heapDeltaBytes": -2750704,
"heapUsedBytes": 74806168,
"domNodes": -276,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 611.351,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3135.3240000000255,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.006000000000002,
"layouts": 60,
"layoutDurationMs": 11.177000000000001,
"taskDurationMs": 1350.299,
"heapDeltaBytes": 9698996,
"heapUsedBytes": 76869936,
"domNodes": 6,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 613.8979999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2271.546999999998,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.181000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1592.9959999999999,
"heapDeltaBytes": -8643816,
"heapUsedBytes": 71767860,
"domNodes": -249,
"jsHeapTotalBytes": -630784,
"scriptDurationMs": 766.83,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2315.9430000000043,
"styleRecalcs": 45,
"styleRecalcDurationMs": 11.315999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1561.3639999999998,
"heapDeltaBytes": -8269160,
"heapUsedBytes": 72073792,
"domNodes": -252,
"jsHeapTotalBytes": 155648,
"scriptDurationMs": 761.924,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2038.710999999978,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.775999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.093,
"heapDeltaBytes": 9330344,
"heapUsedBytes": 86918908,
"domNodes": -269,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 28.636000000000003,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2011.5879999999606,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.708000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.01000000000005,
"heapDeltaBytes": 5008860,
"heapUsedBytes": 82026476,
"domNodes": -279,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 27.99000000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.8310000000151,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.037999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 321.87899999999996,
"heapDeltaBytes": 14286644,
"heapUsedBytes": 86599008,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 111.323,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 525.180999999975,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.24,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.493,
"heapDeltaBytes": 14958596,
"heapUsedBytes": 88078564,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 114.04400000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1989.0960000000177,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.434999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.996,
"heapDeltaBytes": -9933344,
"heapUsedBytes": 63331688,
"domNodes": -294,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 6.184,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.1440000000198,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.213,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.55,
"heapDeltaBytes": -4379224,
"heapUsedBytes": 67555384,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.453999999999998,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.9630000000438,
"styleRecalcs": 78,
"styleRecalcDurationMs": 21.416999999999998,
"layouts": 18,
"layoutDurationMs": 3.857,
"taskDurationMs": 638.145,
"heapDeltaBytes": -8002480,
"heapUsedBytes": 64097884,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 81.503,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.252000000034,
"styleRecalcs": 78,
"styleRecalcDurationMs": 21.968999999999998,
"layouts": 18,
"layoutDurationMs": 3.9180000000000006,
"taskDurationMs": 635.6469999999999,
"heapDeltaBytes": -9359528,
"heapUsedBytes": 63054332,
"domNodes": -287,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 80.748,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 866.7140000000018,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.492000000000008,
"layouts": 16,
"layoutDurationMs": 11.935999999999998,
"taskDurationMs": 704.8970000000002,
"heapDeltaBytes": 21870412,
"heapUsedBytes": 105599592,
"domNodes": 13751,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 21.46,
"eventListeners": 2385,
"totalBlockingTimeMs": 89,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8205.490999999995,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.091,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4554.5109999999995,
"heapDeltaBytes": -17532160,
"heapUsedBytes": 85318664,
"domNodes": -262,
"jsHeapTotalBytes": -892928,
"scriptDurationMs": 2118.9179999999997,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8258.665999999948,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.422999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4614.576,
"heapDeltaBytes": 4523804,
"heapUsedBytes": 80724312,
"domNodes": -272,
"jsHeapTotalBytes": -143360,
"scriptDurationMs": 2110.0220000000004,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14666.455999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14067.996999999998,
"heapDeltaBytes": -41639468,
"heapUsedBytes": 176545384,
"domNodes": -8068,
"jsHeapTotalBytes": -13373440,
"scriptDurationMs": 231.98599999999996,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14541.718999999943,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13780.691,
"heapDeltaBytes": -44910584,
"heapUsedBytes": 179267976,
"domNodes": -8068,
"jsHeapTotalBytes": -14098432,
"scriptDurationMs": 221.62500000000003,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17592.09100000004,
"styleRecalcs": 149,
"styleRecalcDurationMs": 14.684000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17204.189,
"heapDeltaBytes": -69706480,
"heapUsedBytes": 170453776,
"domNodes": -8068,
"jsHeapTotalBytes": -20406272,
"scriptDurationMs": 726.144,
"eventListeners": -14931,
"totalBlockingTimeMs": 3,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17196.322000000007,
"styleRecalcs": 146,
"styleRecalcDurationMs": 14.411999999999981,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16845.43,
"heapDeltaBytes": -26429792,
"heapUsedBytes": 192438936,
"domNodes": -8068,
"jsHeapTotalBytes": -11898880,
"scriptDurationMs": 714.132,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5307.680000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.76200000000001,
"layouts": 20,
"layoutDurationMs": 21.568000000000005,
"taskDurationMs": 5155.016,
"heapDeltaBytes": -55397536,
"heapUsedBytes": 182446212,
"domNodes": -8068,
"jsHeapTotalBytes": 8146944,
"scriptDurationMs": 87.26,
"eventListeners": -14933,
"totalBlockingTimeMs": 267,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5244.529000000057,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.78099999999998,
"layouts": 20,
"layoutDurationMs": 21.814,
"taskDurationMs": 5090.561999999999,
"heapDeltaBytes": -44564908,
"heapUsedBytes": 183455692,
"domNodes": -8068,
"jsHeapTotalBytes": 8253440,
"scriptDurationMs": 89.363,
"eventListeners": -14929,
"totalBlockingTimeMs": 247,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7360.108000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7054.871000000002,
"heapDeltaBytes": 7539320,
"heapUsedBytes": 185999780,
"domNodes": 0,
"jsHeapTotalBytes": -19398656,
"scriptDurationMs": 126.07300000000005,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7300.620999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7019.7660000000005,
"heapDeltaBytes": -11372144,
"heapUsedBytes": 179660972,
"domNodes": 0,
"jsHeapTotalBytes": -19136512,
"scriptDurationMs": 105.00999999999999,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 87.69300000000158,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.965,
"layouts": 3,
"layoutDurationMs": 1.819,
"taskDurationMs": 68.769,
"heapDeltaBytes": 3492656,
"heapUsedBytes": 71793100,
"domNodes": 220,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.212,
"eventListeners": 55,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 444.2959999998948,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.222,
"layouts": 3,
"layoutDurationMs": 1.2550000000000001,
"taskDurationMs": 86.72999999999999,
"heapDeltaBytes": 4901128,
"heapUsedBytes": 74225812,
"domNodes": 146,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.397000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #18356 +/- ##
=============================================
+ Coverage 83.55% 83.56% +0.01%
=============================================
Files 2094 2094
Lines 123520 123568 +48
Branches 33296 33315 +19
=============================================
+ Hits 103202 103259 +57
+ Misses 20139 20130 -9
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…ound document's root graph (#18360) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789709550015299?thread_ts=1789709550.015299&cid=C0BGH348Z0C)_ Backport of #18109 to `cloud/1.54`. ## Summary **Before:** While the Agent panel is bound to a workflow, switching to another workflow tab reuses the same in-memory root graph object for the new tab's nodes before the panel's document binding has caught up. Every node LiteGraph attaches during that window queued a layout `createNode` change, and the mint port did not check which graph a change belonged to, so those changes for the new tab were minted as `add_node` operations and sent into the previous tab's still-bound document. **After:** The layout mint port now compares every root-scoped `createNode`/`deleteNode`/`clearGraph` change against the bound document's own root graph id. A change naming a different graph is dropped and reported once instead of being minted, so a tab switch can no longer leak one workflow's nodes into another workflow's document. ## Changes - **What**: Cherry-picked the squash-merge commit `f664247339869597a78c165b164c4220246b15fa` (#18109) onto a new branch from `origin/cloud/1.54`. The automated backport failed with conflicts in `src/renderer/core/layout/store/layoutStoreMintDelivery.test.ts`, `src/workbench/extensions/agent/AgentPanelRoot.vue`, `src/workbench/extensions/agent/crdt/layoutMintPort.test.ts`, and `src/workbench/extensions/agent/crdt/layoutMintPort.ts` — the same shape of conflicts as the `core/1.54` backport (#18356). In every conflicting hunk the target branch's side was empty (the PR's code is purely additive on top of code `cloud/1.54` already had unchanged), so each hunk was resolved by taking the incoming PR content as-is; no logic was rewritten by hand. ## Review Focus - The cherry-pick failed typecheck for two missing dependencies not yet on `cloud/1.54`: the `withoutGhostFlag` helper (added to `layoutMintPort.ts` earlier by #18191, needed by this PR's new code) and a `toRootGraphId` import in `AgentPanelRoot.test.ts` (used by this PR's new tests, already imported on `main` from an earlier, separately un-backported change). Both were added back verbatim from `main` so the cherry-picked code compiles; no other logic was changed. - Verification: `pnpm vitest run src/workbench/extensions/agent/crdt src/renderer/core/layout/store/layoutStoreMintDelivery.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts` — 938 passed, 3 failed, 1 expected fail; the 3 failures (`AgentPanelRoot.test.ts` "Media-card" attach/upload cases) were confirmed pre-existing and unrelated (also reproduced against unmodified `origin/core/1.54`, same failures, same cause). `pnpm eslint` and `pnpm format:check` (oxfmt) on all changed files: clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01NQVcfKhCKjLstqo3mJS7fc Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Requested by Christian Byrne · Slack thread
Backport of #18109 to
core/1.54.Summary
Before: While the Agent panel is bound to a workflow, switching to another workflow tab reuses the same in-memory root graph object for the new tab's nodes before the panel's document binding has caught up. Every node LiteGraph attaches during that window queued a layout
createNodechange, and the mint port did not check which graph a change belonged to, so those changes for the new tab were minted asadd_nodeoperations and sent into the previous tab's still-bound document.After: The layout mint port now compares every root-scoped
createNode/deleteNode/clearGraphchange against the bound document's own root graph id. A change naming a different graph is dropped and reported once instead of being minted, so a tab switch can no longer leak one workflow's nodes into another workflow's document.Changes
f664247339869597a78c165b164c4220246b15fa(fix(agent-crdt): scope layout mint ops to the bound document's root graph #18109) onto a new branch fromorigin/core/1.54. The automated backport failed with conflicts insrc/renderer/core/layout/store/layoutStoreMintDelivery.test.ts,src/workbench/extensions/agent/AgentPanelRoot.vue,src/workbench/extensions/agent/crdt/layoutMintPort.test.ts, andsrc/workbench/extensions/agent/crdt/layoutMintPort.ts. In every conflicting hunk the target branch's side was empty (the PR's code is purely additive on top of codecore/1.54already had unchanged), so each hunk was resolved by taking the incoming PR content as-is; no logic was rewritten by hand.Review Focus
core/1.54: thewithoutGhostFlaghelper (added tolayoutMintPort.tsearlier by fix(agent-crdt): keep the ghost placement flag out of the document #18191, needed by this PR's new code) and atoRootGraphIdimport inAgentPanelRoot.test.ts(used by this PR's new tests, already imported onmainfrom an earlier, separately un-backported change). Both were added back verbatim frommainso the cherry-picked code compiles; no other logic was changed.pnpm vitest run src/workbench/extensions/agent/crdt src/renderer/core/layout/store/layoutStoreMintDelivery.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts— 904 passed, 3 failed, 1 expected fail; the 3 failures (AgentPanelRoot.test.ts"Media-card" attach/upload cases) were confirmed pre-existing and unrelated by running the same tests against unmodifiedorigin/core/1.54, where they fail identically.pnpm eslintandpnpm format:check(oxfmt) on all changed files: clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01NQVcfKhCKjLstqo3mJS7fc