Repository navigation
[backport cloud/1.54] fix(agent-crdt): scope layout mint ops to the bound document's root graph - #18360
Conversation
…raph (#18109) Backport of #18109 to cloud/1.54. While the Agent panel is bound to a workflow, switching to another workflow tab reuses the same in-memory root graph object for the new tab's nodes before the panel's document binding has caught up. Every node LiteGraph attaches during that window queued a layout createNode change, and the mint port did not check which graph a change belonged to, so those changes for the new tab were minted as add_node operations and sent into the previous tab's still-bound document. The layout mint port now compares every root-scoped createNode/deleteNode/clearGraph change against the bound document's own root graph id. A change naming a different graph is dropped and reported once instead of being minted. Cherry-pick of f664247 onto cloud/1.54. Conflicts in layoutMintPort.ts, layoutMintPort.test.ts, layoutStoreMintDelivery.test.ts and AgentPanelRoot.vue were resolved by taking the incoming change as-is (the target's side of each hunk was empty). Backported the withoutGhostFlag helper into layoutMintPort.ts and the toRootGraphId import into AgentPanelRoot.test.ts, both dependencies from earlier main commits (#18191 and an unbackported test import) not yet on cloud/1.54 but required for this change to compile.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1934 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-22T05:02:39.885Z",
"gitSha": "10f44da168dd4f88dcdd236bdcce304a951f9ebc",
"branch": "backport-18109-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2054.8299999999813,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.828999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.68100000000004,
"heapDeltaBytes": -9900696,
"heapUsedBytes": 60273332,
"domNodes": -281,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.069999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2019.2260000000033,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.911,
"heapDeltaBytes": 7983128,
"heapUsedBytes": 77948448,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.704,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2007.1570000000065,
"styleRecalcs": 78,
"styleRecalcDurationMs": 32.537000000000006,
"layouts": 14,
"layoutDurationMs": 4.457,
"taskDurationMs": 1011.6529999999999,
"heapDeltaBytes": -3768748,
"heapUsedBytes": 66951636,
"domNodes": -277,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 188.59699999999998,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1850.9960000000092,
"styleRecalcs": 73,
"styleRecalcDurationMs": 27.448999999999998,
"layouts": 14,
"layoutDurationMs": 4.0200000000000005,
"taskDurationMs": 872.251,
"heapDeltaBytes": 1460432,
"heapUsedBytes": 72372616,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 161.14000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.4719999999725,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.729,
"layouts": 6,
"layoutDurationMs": 0.9499999999999998,
"taskDurationMs": 363.64300000000003,
"heapDeltaBytes": 4621020,
"heapUsedBytes": 74957296,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.258000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.6459999999452,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.312,
"layouts": 6,
"layoutDurationMs": 1.091,
"taskDurationMs": 358.47700000000003,
"heapDeltaBytes": 4508720,
"heapUsedBytes": 75194252,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.873000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 653.9639999999736,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.567000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.30400000000003,
"heapDeltaBytes": -7941884,
"heapUsedBytes": 63191628,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 159.389,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 657.1170000000279,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.944999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.545,
"heapDeltaBytes": -7504988,
"heapUsedBytes": 63331732,
"domNodes": 16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 165.584,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.565999999999,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.120000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 628.6129999999999,
"heapDeltaBytes": 5274164,
"heapUsedBytes": 80971296,
"domNodes": -277,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 35.457,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2038.9190000000212,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.473999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 608.1730000000001,
"heapDeltaBytes": 11074400,
"heapUsedBytes": 87422012,
"domNodes": -268,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 33.019999999999996,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2384.6889999999803,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.355000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1692.697,
"heapDeltaBytes": -11627552,
"heapUsedBytes": 92517964,
"domNodes": -271,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 842.667,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2391.1560000000236,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.570000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1743.8380000000002,
"heapDeltaBytes": -10328784,
"heapUsedBytes": 67130396,
"domNodes": -284,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 832.233,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3647.970999999984,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.604000000000001,
"layouts": 60,
"layoutDurationMs": 11.767,
"taskDurationMs": 1727.585,
"heapDeltaBytes": 8759352,
"heapUsedBytes": 76526336,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 792.412,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3691.100000000006,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.527999999999999,
"layouts": 60,
"layoutDurationMs": 12.346,
"taskDurationMs": 1754.162,
"heapDeltaBytes": 10834148,
"heapUsedBytes": 89239240,
"domNodes": 8,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 788.239,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3115.0240000000053,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.4159999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1907.308,
"heapDeltaBytes": 18265756,
"heapUsedBytes": 85795960,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 952.3729999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3197.1469999999726,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.135999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2028.1660000000002,
"heapDeltaBytes": 27093964,
"heapUsedBytes": 94853716,
"domNodes": -280,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1022.5769999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2039.4739999999842,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.579,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.275,
"heapDeltaBytes": 10131616,
"heapUsedBytes": 87580296,
"domNodes": -267,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 37.059999999999995,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2018.0410000000393,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.6039999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.6500000000001,
"heapDeltaBytes": 21853276,
"heapUsedBytes": 88109864,
"domNodes": -270,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.797,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 585.0319999999556,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.426,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.138,
"heapDeltaBytes": 14630424,
"heapUsedBytes": 86632824,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 140.36200000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 623.1610000000956,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.057,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.3119999999999,
"heapDeltaBytes": 13631732,
"heapUsedBytes": 86191668,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 150.48,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2054.6679999999924,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.771000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.92,
"heapDeltaBytes": -5872496,
"heapUsedBytes": 66996436,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 7.998000000000002,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1990.0260000000003,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.214000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.497,
"heapDeltaBytes": -9651212,
"heapUsedBytes": 61765676,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.717999999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1738.8509999999542,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.713,
"layouts": 18,
"layoutDurationMs": 4.643000000000001,
"taskDurationMs": 812.781,
"heapDeltaBytes": 10751636,
"heapUsedBytes": 83857676,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 110.47699999999999,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.074999999957,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.245,
"layouts": 18,
"layoutDurationMs": 5.36,
"taskDurationMs": 825.104,
"heapDeltaBytes": 9514096,
"heapUsedBytes": 82644168,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 114.89300000000001,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.2720000000058,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.674,
"layouts": 15,
"layoutDurationMs": 15.985,
"taskDurationMs": 939.114,
"heapDeltaBytes": -7304088,
"heapUsedBytes": 85149852,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 29.116000000000003,
"eventListeners": 2385,
"totalBlockingTimeMs": 149,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8705.579999999998,
"styleRecalcs": 249,
"styleRecalcDurationMs": 40.407,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6023.671,
"heapDeltaBytes": 9794324,
"heapUsedBytes": 85434536,
"domNodes": -245,
"jsHeapTotalBytes": 118784,
"scriptDurationMs": 2776.3900000000003,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8796.595000000025,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.952999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5996.151,
"heapDeltaBytes": 8948428,
"heapUsedBytes": 85469000,
"domNodes": -247,
"jsHeapTotalBytes": 643072,
"scriptDurationMs": 2776.9000000000005,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17127.770999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16662.373000000003,
"heapDeltaBytes": -59765492,
"heapUsedBytes": 176338100,
"domNodes": -8068,
"jsHeapTotalBytes": -17768448,
"scriptDurationMs": 304.481,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16983.795999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16544.095,
"heapDeltaBytes": -31465384,
"heapUsedBytes": 179538868,
"domNodes": -8068,
"jsHeapTotalBytes": -16691200,
"scriptDurationMs": 280.875,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20979.671999999995,
"styleRecalcs": 169,
"styleRecalcDurationMs": 18.396000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20595.118,
"heapDeltaBytes": -57614676,
"heapUsedBytes": 170266436,
"domNodes": -8068,
"jsHeapTotalBytes": -14573568,
"scriptDurationMs": 935.348,
"eventListeners": -14927,
"totalBlockingTimeMs": 212,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21114.434999999958,
"styleRecalcs": 175,
"styleRecalcDurationMs": 19.02100000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20745.921000000002,
"heapDeltaBytes": -38887832,
"heapUsedBytes": 178798220,
"domNodes": -8068,
"jsHeapTotalBytes": -10256384,
"scriptDurationMs": 943.1639999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 90,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6276.33400000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.12999999999998,
"layouts": 20,
"layoutDurationMs": 22.218,
"taskDurationMs": 6154.487999999999,
"heapDeltaBytes": -26660652,
"heapUsedBytes": 184968532,
"domNodes": -8068,
"jsHeapTotalBytes": 14766080,
"scriptDurationMs": 115.42,
"eventListeners": -14929,
"totalBlockingTimeMs": 372,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6284.797000000026,
"styleRecalcs": 20,
"styleRecalcDurationMs": 99.27900000000001,
"layouts": 20,
"layoutDurationMs": 29.86000000000001,
"taskDurationMs": 6152.935,
"heapDeltaBytes": -35064152,
"heapUsedBytes": 183498192,
"domNodes": -8068,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 108.93499999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 442,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8669.043999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8426.019,
"heapDeltaBytes": 10913652,
"heapUsedBytes": 182088444,
"domNodes": 0,
"jsHeapTotalBytes": -3670016,
"scriptDurationMs": 147.29999999999998,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8649.312000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8419.121000000003,
"heapDeltaBytes": 4959944,
"heapUsedBytes": 178655752,
"domNodes": 0,
"jsHeapTotalBytes": -15466496,
"scriptDurationMs": 137.0840000000001,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 110.59399999999187,
"styleRecalcs": 9,
"styleRecalcDurationMs": 14.822000000000003,
"layouts": 2,
"layoutDurationMs": 0.4670000000000001,
"taskDurationMs": 78.292,
"heapDeltaBytes": 3099108,
"heapUsedBytes": 71981084,
"domNodes": 111,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.720000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 102.08799999998064,
"styleRecalcs": 6,
"styleRecalcDurationMs": 14.690000000000001,
"layouts": 3,
"layoutDurationMs": 1.434,
"taskDurationMs": 65.86799999999998,
"heapDeltaBytes": 2955468,
"heapUsedBytes": 71281300,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.9270000000000005,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #18360 +/- ##
=============================================
Coverage ? 83.58%
=============================================
Files ? 2094
Lines ? 123714
Branches ? 31315
=============================================
Hits ? 103403
Misses ? 20133
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Requested by Christian Byrne · Slack thread
Backport of #18109 to
cloud/1.54.Summary
Before: While the Agent panel is bound to a workflow, switching to another workflow tab reuses the same in-memory root graph object for the new tab's nodes before the panel's document binding has caught up. Every node LiteGraph attaches during that window queued a layout
createNodechange, and the mint port did not check which graph a change belonged to, so those changes for the new tab were minted asadd_nodeoperations and sent into the previous tab's still-bound document.After: The layout mint port now compares every root-scoped
createNode/deleteNode/clearGraphchange against the bound document's own root graph id. A change naming a different graph is dropped and reported once instead of being minted, so a tab switch can no longer leak one workflow's nodes into another workflow's document.Changes
f664247339869597a78c165b164c4220246b15fa(fix(agent-crdt): scope layout mint ops to the bound document's root graph #18109) onto a new branch fromorigin/cloud/1.54. The automated backport failed with conflicts insrc/renderer/core/layout/store/layoutStoreMintDelivery.test.ts,src/workbench/extensions/agent/AgentPanelRoot.vue,src/workbench/extensions/agent/crdt/layoutMintPort.test.ts, andsrc/workbench/extensions/agent/crdt/layoutMintPort.ts— the same shape of conflicts as thecore/1.54backport ([backport core/1.54] fix(agent-crdt): scope layout mint ops to the bound document's root graph #18356). In every conflicting hunk the target branch's side was empty (the PR's code is purely additive on top of codecloud/1.54already had unchanged), so each hunk was resolved by taking the incoming PR content as-is; no logic was rewritten by hand.Review Focus
cloud/1.54: thewithoutGhostFlaghelper (added tolayoutMintPort.tsearlier by fix(agent-crdt): keep the ghost placement flag out of the document #18191, needed by this PR's new code) and atoRootGraphIdimport inAgentPanelRoot.test.ts(used by this PR's new tests, already imported onmainfrom an earlier, separately un-backported change). Both were added back verbatim frommainso the cherry-picked code compiles; no other logic was changed.pnpm vitest run src/workbench/extensions/agent/crdt src/renderer/core/layout/store/layoutStoreMintDelivery.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts— 938 passed, 3 failed, 1 expected fail; the 3 failures (AgentPanelRoot.test.ts"Media-card" attach/upload cases) were confirmed pre-existing and unrelated (also reproduced against unmodifiedorigin/core/1.54, same failures, same cause).pnpm eslintandpnpm format:check(oxfmt) on all changed files: clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01NQVcfKhCKjLstqo3mJS7fc