Skip to content

[backport cloud/1.54] fix(agent-crdt): scope layout mint ops to the bound document's root graph - #18360

Merged
christian-byrne merged 1 commit into
cloud/1.54from
backport-18109-to-cloud-1.54
Sep 22, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
backport-18109-to-cloud-1.54

Conversation

@claude

@claude claude Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Requested by Christian Byrne · Slack thread

Backport of #18109 to cloud/1.54.

Summary

Before: While the Agent panel is bound to a workflow, switching to another workflow tab reuses the same in-memory root graph object for the new tab's nodes before the panel's document binding has caught up. Every node LiteGraph attaches during that window queued a layout createNode change, and the mint port did not check which graph a change belonged to, so those changes for the new tab were minted as add_node operations and sent into the previous tab's still-bound document.

After: The layout mint port now compares every root-scoped createNode/deleteNode/clearGraph change against the bound document's own root graph id. A change naming a different graph is dropped and reported once instead of being minted, so a tab switch can no longer leak one workflow's nodes into another workflow's document.

Changes

Review Focus

  • The cherry-pick failed typecheck for two missing dependencies not yet on cloud/1.54: the withoutGhostFlag helper (added to layoutMintPort.ts earlier by fix(agent-crdt): keep the ghost placement flag out of the document #18191, needed by this PR's new code) and a toRootGraphId import in AgentPanelRoot.test.ts (used by this PR's new tests, already imported on main from an earlier, separately un-backported change). Both were added back verbatim from main so the cherry-picked code compiles; no other logic was changed.
  • Verification: pnpm vitest run src/workbench/extensions/agent/crdt src/renderer/core/layout/store/layoutStoreMintDelivery.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts — 938 passed, 3 failed, 1 expected fail; the 3 failures (AgentPanelRoot.test.ts "Media-card" attach/upload cases) were confirmed pre-existing and unrelated (also reproduced against unmodified origin/core/1.54, same failures, same cause). pnpm eslint and pnpm format:check (oxfmt) on all changed files: clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01NQVcfKhCKjLstqo3mJS7fc

…raph (#18109)

Backport of #18109 to cloud/1.54.

While the Agent panel is bound to a workflow, switching to another
workflow tab reuses the same in-memory root graph object for the new
tab's nodes before the panel's document binding has caught up. Every
node LiteGraph attaches during that window queued a layout createNode
change, and the mint port did not check which graph a change belonged
to, so those changes for the new tab were minted as add_node
operations and sent into the previous tab's still-bound document.

The layout mint port now compares every root-scoped
createNode/deleteNode/clearGraph change against the bound document's
own root graph id. A change naming a different graph is dropped and
reported once instead of being minted.

Cherry-pick of f664247 onto
cloud/1.54. Conflicts in layoutMintPort.ts, layoutMintPort.test.ts,
layoutStoreMintDelivery.test.ts and AgentPanelRoot.vue were resolved by
taking the incoming change as-is (the target's side of each hunk was
empty). Backported the withoutGhostFlag helper into layoutMintPort.ts
and the toRootGraphId import into AgentPanelRoot.test.ts, both
dependencies from earlier main commits (#18191 and an unbackported
test import) not yet on cloud/1.54 but required for this change to
compile.
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 676a3167-0258-47b6-91e0-8bbe18ba1b20

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 22, 2026 4:37am UTC

Request Review

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/22/2026, 04:57:05 AM UTC

Links

🎭 Playwright: ✅ 1934 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1913 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.0 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 149ms TBT · 81.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.5 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.7 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 151ms TBT · 166.4 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 407ms TBT · 175.7 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 500ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 65.9 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -180
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 30ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 942ms
canvas-mouse-sweep: script duration 175ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 66.4 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -195
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 361ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.6 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 451ms
dom-widget-clipping: script duration 162ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 60.3 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 618ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 80.3 MB
large-graph-idle: DOM nodes -273
large-graph-idle: event listeners -192
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1718ms
large-graph-pan: script duration 837ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 76.1 MB
large-graph-pan: DOM nodes -278
large-graph-pan: event listeners -177
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1741ms
large-graph-zoom: script duration 790ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 79.0 MB
large-graph-zoom: DOM nodes 4
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1968ms
legacy-node-drag: script duration 987ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 86.1 MB
legacy-node-drag: DOM nodes -140
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 583ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.8 MB
minimap-idle: DOM nodes -269
minimap-idle: event listeners -179
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 419ms
subgraph-dom-widget-clipping: script duration 145ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 82.4 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 488ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 61.4 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -240
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 28ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 819ms
subgraph-mouse-sweep: script duration 113ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 79.4 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -212
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 939ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 149ms
subgraph-transition-enter: heap used 81.2 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 6010ms
viewport-pan-sweep: script duration 2777ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 81.5 MB
viewport-pan-sweep: DOM nodes -246
viewport-pan-sweep: event listeners -176
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16603ms
vue-large-graph-idle: script duration 293ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.7 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14933
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 172
vue-large-graph-pan: task duration 20671ms
vue-large-graph-pan: script duration 939ms
vue-large-graph-pan: TBT 151ms
vue-large-graph-pan: heap used 166.4 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14927
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 26ms
vue-node-resize-workload: style recalc duration 89ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6154ms
vue-node-resize-workload: script duration 112ms
vue-node-resize-workload: TBT 407ms
vue-node-resize-workload: heap used 175.7 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8423ms
vue-zoom-out-idle: script duration 142ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 172.0 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 3
workflow-execution: style recalc count 8
workflow-execution: task duration 72ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.3 MB
workflow-execution: DOM nodes 118
workflow-execution: event listeners 25
Raw data
{
  "timestamp": "2026-09-22T05:02:39.885Z",
  "gitSha": "10f44da168dd4f88dcdd236bdcce304a951f9ebc",
  "branch": "backport-18109-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2054.8299999999813,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.828999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 504.68100000000004,
      "heapDeltaBytes": -9900696,
      "heapUsedBytes": 60273332,
      "domNodes": -281,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 9.069999999999999,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2019.2260000000033,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 495.911,
      "heapDeltaBytes": 7983128,
      "heapUsedBytes": 77948448,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.704,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2007.1570000000065,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 32.537000000000006,
      "layouts": 14,
      "layoutDurationMs": 4.457,
      "taskDurationMs": 1011.6529999999999,
      "heapDeltaBytes": -3768748,
      "heapUsedBytes": 66951636,
      "domNodes": -277,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 188.59699999999998,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1850.9960000000092,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 27.448999999999998,
      "layouts": 14,
      "layoutDurationMs": 4.0200000000000005,
      "taskDurationMs": 872.251,
      "heapDeltaBytes": 1460432,
      "heapUsedBytes": 72372616,
      "domNodes": -280,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 161.14000000000001,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1720.4719999999725,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.729,
      "layouts": 6,
      "layoutDurationMs": 0.9499999999999998,
      "taskDurationMs": 363.64300000000003,
      "heapDeltaBytes": 4621020,
      "heapUsedBytes": 74957296,
      "domNodes": 77,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 11.258000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1717.6459999999452,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.312,
      "layouts": 6,
      "layoutDurationMs": 1.091,
      "taskDurationMs": 358.47700000000003,
      "heapDeltaBytes": 4508720,
      "heapUsedBytes": 75194252,
      "domNodes": 76,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.873000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 653.9639999999736,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.567000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 447.30400000000003,
      "heapDeltaBytes": -7941884,
      "heapUsedBytes": 63191628,
      "domNodes": 18,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 159.389,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 657.1170000000279,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.944999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 454.545,
      "heapDeltaBytes": -7504988,
      "heapUsedBytes": 63331732,
      "domNodes": 16,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 165.584,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.565999999999,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.120000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 628.6129999999999,
      "heapDeltaBytes": 5274164,
      "heapUsedBytes": 80971296,
      "domNodes": -277,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 35.457,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2038.9190000000212,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.473999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 608.1730000000001,
      "heapDeltaBytes": 11074400,
      "heapUsedBytes": 87422012,
      "domNodes": -268,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 33.019999999999996,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2384.6889999999803,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.355000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1692.697,
      "heapDeltaBytes": -11627552,
      "heapUsedBytes": 92517964,
      "domNodes": -271,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 842.667,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2391.1560000000236,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.570000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1743.8380000000002,
      "heapDeltaBytes": -10328784,
      "heapUsedBytes": 67130396,
      "domNodes": -284,
      "jsHeapTotalBytes": 942080,
      "scriptDurationMs": 832.233,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3647.970999999984,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.604000000000001,
      "layouts": 60,
      "layoutDurationMs": 11.767,
      "taskDurationMs": 1727.585,
      "heapDeltaBytes": 8759352,
      "heapUsedBytes": 76526336,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 792.412,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3691.100000000006,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 13.527999999999999,
      "layouts": 60,
      "layoutDurationMs": 12.346,
      "taskDurationMs": 1754.162,
      "heapDeltaBytes": 10834148,
      "heapUsedBytes": 89239240,
      "domNodes": 8,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 788.239,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3115.0240000000053,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.4159999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1907.308,
      "heapDeltaBytes": 18265756,
      "heapUsedBytes": 85795960,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 952.3729999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3197.1469999999726,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.135999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2028.1660000000002,
      "heapDeltaBytes": 27093964,
      "heapUsedBytes": 94853716,
      "domNodes": -280,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 1022.5769999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2039.4739999999842,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.579,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 613.275,
      "heapDeltaBytes": 10131616,
      "heapUsedBytes": 87580296,
      "domNodes": -267,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 37.059999999999995,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2018.0410000000393,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.6039999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 552.6500000000001,
      "heapDeltaBytes": 21853276,
      "heapUsedBytes": 88109864,
      "domNodes": -270,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 33.797,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 585.0319999999556,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.426,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 410.138,
      "heapDeltaBytes": 14630424,
      "heapUsedBytes": 86632824,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 140.36200000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 623.1610000000956,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 12.057,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 428.3119999999999,
      "heapDeltaBytes": 13631732,
      "heapUsedBytes": 86191668,
      "domNodes": 22,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 150.48,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2054.6679999999924,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.771000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 484.92,
      "heapDeltaBytes": -5872496,
      "heapUsedBytes": 66996436,
      "domNodes": -296,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 7.998000000000002,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1990.0260000000003,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.214000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 491.497,
      "heapDeltaBytes": -9651212,
      "heapUsedBytes": 61765676,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.717999999999999,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1738.8509999999542,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 27.713,
      "layouts": 18,
      "layoutDurationMs": 4.643000000000001,
      "taskDurationMs": 812.781,
      "heapDeltaBytes": 10751636,
      "heapUsedBytes": 83857676,
      "domNodes": -294,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 110.47699999999999,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1739.074999999957,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 28.245,
      "layouts": 18,
      "layoutDurationMs": 5.36,
      "taskDurationMs": 825.104,
      "heapDeltaBytes": 9514096,
      "heapUsedBytes": 82644168,
      "domNodes": -296,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 114.89300000000001,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.2720000000058,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 32.674,
      "layouts": 15,
      "layoutDurationMs": 15.985,
      "taskDurationMs": 939.114,
      "heapDeltaBytes": -7304088,
      "heapUsedBytes": 85149852,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 29.116000000000003,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 149,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8705.579999999998,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 40.407,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6023.671,
      "heapDeltaBytes": 9794324,
      "heapUsedBytes": 85434536,
      "domNodes": -245,
      "jsHeapTotalBytes": 118784,
      "scriptDurationMs": 2776.3900000000003,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8796.595000000025,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 34.952999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5996.151,
      "heapDeltaBytes": 8948428,
      "heapUsedBytes": 85469000,
      "domNodes": -247,
      "jsHeapTotalBytes": 643072,
      "scriptDurationMs": 2776.9000000000005,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17127.770999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16662.373000000003,
      "heapDeltaBytes": -59765492,
      "heapUsedBytes": 176338100,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17768448,
      "scriptDurationMs": 304.481,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16983.795999999984,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16544.095,
      "heapDeltaBytes": -31465384,
      "heapUsedBytes": 179538868,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16691200,
      "scriptDurationMs": 280.875,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20979.671999999995,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 18.396000000000022,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20595.118,
      "heapDeltaBytes": -57614676,
      "heapUsedBytes": 170266436,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14573568,
      "scriptDurationMs": 935.348,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 212,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21114.434999999958,
      "styleRecalcs": 175,
      "styleRecalcDurationMs": 19.02100000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20745.921000000002,
      "heapDeltaBytes": -38887832,
      "heapUsedBytes": 178798220,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10256384,
      "scriptDurationMs": 943.1639999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 90,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6276.33400000002,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.12999999999998,
      "layouts": 20,
      "layoutDurationMs": 22.218,
      "taskDurationMs": 6154.487999999999,
      "heapDeltaBytes": -26660652,
      "heapUsedBytes": 184968532,
      "domNodes": -8068,
      "jsHeapTotalBytes": 14766080,
      "scriptDurationMs": 115.42,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 372,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6284.797000000026,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 99.27900000000001,
      "layouts": 20,
      "layoutDurationMs": 29.86000000000001,
      "taskDurationMs": 6152.935,
      "heapDeltaBytes": -35064152,
      "heapUsedBytes": 183498192,
      "domNodes": -8068,
      "jsHeapTotalBytes": 4358144,
      "scriptDurationMs": 108.93499999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 442,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8669.043999999985,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8426.019,
      "heapDeltaBytes": 10913652,
      "heapUsedBytes": 182088444,
      "domNodes": 0,
      "jsHeapTotalBytes": -3670016,
      "scriptDurationMs": 147.29999999999998,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8649.312000000009,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8419.121000000003,
      "heapDeltaBytes": 4959944,
      "heapUsedBytes": 178655752,
      "domNodes": 0,
      "jsHeapTotalBytes": -15466496,
      "scriptDurationMs": 137.0840000000001,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 110.59399999999187,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 14.822000000000003,
      "layouts": 2,
      "layoutDurationMs": 0.4670000000000001,
      "taskDurationMs": 78.292,
      "heapDeltaBytes": 3099108,
      "heapUsedBytes": 71981084,
      "domNodes": 111,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.720000000000001,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 102.08799999998064,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 14.690000000000001,
      "layouts": 3,
      "layoutDurationMs": 1.434,
      "taskDurationMs": 65.86799999999998,
      "heapDeltaBytes": 2955468,
      "heapUsedBytes": 71281300,
      "domNodes": 125,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.9270000000000005,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 50323 75371 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1159
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.3% 264
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.6% 257
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 22, 2026
@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/workbench/extensions/agent/AgentPanelRoot.vue 83.33% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #18360   +/-   ##
=============================================
  Coverage              ?   83.58%           
=============================================
  Files                 ?     2094           
  Lines                 ?   123714           
  Branches              ?    31315           
=============================================
  Hits                  ?   103403           
  Misses                ?    20133           
  Partials              ?      178           
Flag Coverage Δ
e2e 66.77% <ø> (?)
unit 78.52% <98.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../workbench/extensions/agent/crdt/layoutMintPort.ts 100.00% <100.00%> (ø)
.../workbench/extensions/agent/crdt/mintPortWiring.ts 93.33% <ø> (ø)
src/workbench/extensions/agent/AgentPanelRoot.vue 93.41% <83.33%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit 64fe8c1 into cloud/1.54 Sep 22, 2026
91 checks passed
@christian-byrne
christian-byrne deleted the backport-18109-to-cloud-1.54 branch September 22, 2026 06:35
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants