Skip to content

[backport cloud/1.53] fix: avoid TDZ crash restoring saved multiline widget value - #18350

Merged
comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-18324-to-cloud-1.53
Sep 23, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-18324-to-cloud-1.53

Conversation

@claude

@claude claude Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Requested via Slack thread

Manual backport of #18324 to cloud/1.53. The automated backport bot hit a merge conflict in src/renderer/extensions/vueNodes/widgets/composables/useStringWidget.ts and could not land it automatically, so this was cherry-picked and resolved by hand.

Fix: setValue in useStringWidget.ts's addMultilineWidget() closed over the outer widget const to read widget.options, but node.addDOMWidget(...) can invoke setValue synchronously — while restoring a previously saved widget value during workflow load — before that assignment completes, throwing a ReferenceError (temporal dead zone). The fix hoists the widget's options object into its own widgetOptions const, declared and initialized before addDOMWidget is called, and has setValue reference that instead of the outer widget binding.

Conflict resolution: the only conflict was in useStringWidget.ts, where cloud/1.53's version of setValue still referenced widget.options ?? {}; resolved by taking the fixed version (options: widgetOptions), consistent with the rest of the already-hoisted widgetOptions pattern. useStringWidget.test.ts merged automatically with no conflicts. No package.json/pnpm-lock.yaml changes were needed.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KQEWS3P3LxaJx8jVvy5TUb


Generated by Claude Code

setValue in useStringWidget.ts's addMultilineWidget() closed over the
outer `widget` const to read widget.options, but node.addDOMWidget(...)
can invoke setValue synchronously - while restoring a previously saved
widget value during workflow load - before that assignment completes.
Reading widget.options at that point threw a ReferenceError (temporal
dead zone).

Hoists the widget's options object into its own widgetOptions const,
declared and fully initialized before addDOMWidget is called, and has
setValue reference that instead of the outer widget binding.

Backport of #18324 to cloud/1.53.
@claude
claude Bot requested a review from a team as a code owner September 22, 2026 04:18
@claude claude Bot added the backport Backporting a PR onto a release candidate label Sep 22, 2026
@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 22, 2026 4:18am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0d9813b5-03a1-4e84-b72e-80c17211496f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1903 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1882 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/22/2026, 04:29:42 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 142ms TBT · 83.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.4 MB heap
vue-large-graph-idle: · 57.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.3 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 113ms TBT · 180.8 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 417ms TBT · 171.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 554ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 60.7 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 43ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 917ms
canvas-mouse-sweep: script duration 165ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 70.2 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -185
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 380ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.8 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 455ms
dom-widget-clipping: script duration 166ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.1 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 631ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.2 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -168
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 1686ms
large-graph-pan: script duration 848ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 84.5 MB
large-graph-pan: DOM nodes -138
large-graph-pan: event listeners -89
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1759ms
large-graph-zoom: script duration 792ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.3 MB
large-graph-zoom: DOM nodes 1
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 2010ms
legacy-node-drag: script duration 1014ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 88.0 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 621ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.4 MB
minimap-idle: DOM nodes -273
minimap-idle: event listeners -154
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 45
subgraph-dom-widget-clipping: task duration 419ms
subgraph-dom-widget-clipping: script duration 143ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.2 MB
subgraph-dom-widget-clipping: DOM nodes 16
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 526ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 63.6 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -216
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 42ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 870ms
subgraph-mouse-sweep: script duration 117ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 71.6 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -233
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 941ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 142ms
subgraph-transition-enter: heap used 83.0 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 6114ms
viewport-pan-sweep: script duration 2829ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 85.4 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -152
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16576ms
vue-large-graph-idle: script duration 274ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 167.3 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 173
vue-large-graph-pan: task duration 20867ms
vue-large-graph-pan: script duration 957ms
vue-large-graph-pan: TBT 113ms
vue-large-graph-pan: heap used 180.8 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7470
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 82ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6068ms
vue-node-resize-workload: script duration 120ms
vue-node-resize-workload: TBT 417ms
vue-node-resize-workload: heap used 171.7 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7471
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 101ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.4 MB
workflow-execution: DOM nodes 131
workflow-execution: event listeners 74
Raw data
{
  "timestamp": "2026-09-22T04:35:37.925Z",
  "gitSha": "72bf1e62b7f26a9d5a04dc55e73751bc792250c8",
  "branch": "backport-18324-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2104.1079999999965,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.576,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 597.4240000000001,
      "heapDeltaBytes": 191192,
      "heapUsedBytes": 70607712,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 11.022000000000004,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2056.966999999986,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 11.032000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 510.29799999999994,
      "heapDeltaBytes": -13034588,
      "heapUsedBytes": 56599100,
      "domNodes": -282,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.421,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1923.798999999974,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 45.068999999999996,
      "layouts": 14,
      "layoutDurationMs": 4.324,
      "taskDurationMs": 940.409,
      "heapDeltaBytes": 2642628,
      "heapUsedBytes": 73068316,
      "domNodes": -278,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 169.23,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1885.5819999999994,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 40.129999999999995,
      "layouts": 14,
      "layoutDurationMs": 4.431,
      "taskDurationMs": 892.636,
      "heapDeltaBytes": 4313556,
      "heapUsedBytes": 74080092,
      "domNodes": -284,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 161.172,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1663.5109999999713,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 18.522000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.0450000000000002,
      "taskDurationMs": 398.08200000000005,
      "heapDeltaBytes": 4658816,
      "heapUsedBytes": 75512160,
      "domNodes": 76,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 13.129999999999995,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.0789999999706,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.864,
      "layouts": 6,
      "layoutDurationMs": 0.9360000000000002,
      "taskDurationMs": 361.163,
      "heapDeltaBytes": 4368208,
      "heapUsedBytes": 75029776,
      "domNodes": 77,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.415000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 690.0619999999549,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.743,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.547,
      "heapDeltaBytes": 18803180,
      "heapUsedBytes": 88388048,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 167.503,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 675.3120000000763,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.522999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 453.0799999999999,
      "heapDeltaBytes": 17791184,
      "heapUsedBytes": 88031828,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 165.015,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2028.3069999999839,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.0889999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 663.8240000000001,
      "heapDeltaBytes": -14300296,
      "heapUsedBytes": 86459316,
      "domNodes": -270,
      "jsHeapTotalBytes": -1355776,
      "scriptDurationMs": 36.53200000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2029.7309999999698,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.446,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 598.7520000000001,
      "heapDeltaBytes": 10919624,
      "heapUsedBytes": 86006544,
      "domNodes": -269,
      "jsHeapTotalBytes": -1130496,
      "scriptDurationMs": 33.155,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2581.729999999993,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 9.374999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1786.225,
      "heapDeltaBytes": 23467304,
      "heapUsedBytes": 88875864,
      "domNodes": -280,
      "jsHeapTotalBytes": 2060288,
      "scriptDurationMs": 879.039,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2260.992999999985,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 8.855000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1584.867,
      "heapDeltaBytes": 22144968,
      "heapUsedBytes": 88239216,
      "domNodes": 4,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 816.33,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3764.1810000000078,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.517999999999999,
      "layouts": 60,
      "layoutDurationMs": 12.649000000000001,
      "taskDurationMs": 1868.933,
      "heapDeltaBytes": 8016860,
      "heapUsedBytes": 75410424,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 826.0400000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3492.8200000000516,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 10.254000000000003,
      "layouts": 60,
      "layoutDurationMs": 11.583,
      "taskDurationMs": 1648.2199999999998,
      "heapDeltaBytes": 8497776,
      "heapUsedBytes": 76204424,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 758.171,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3182.95599999999,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.159000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2087.1279999999997,
      "heapDeltaBytes": 25629684,
      "heapUsedBytes": 92670716,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 1051.893,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3136.27699999995,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.872999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1932.34,
      "heapDeltaBytes": 24481900,
      "heapUsedBytes": 91924548,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 975.7499999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2016.8009999999867,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.488999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 655.4630000000001,
      "heapDeltaBytes": -15223128,
      "heapUsedBytes": 87201652,
      "domNodes": -274,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 36.106,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2012.644000000023,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 5.478000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 587.525,
      "heapDeltaBytes": 21802572,
      "heapUsedBytes": 87692996,
      "domNodes": -272,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 33.28600000000001,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 659.4589999999698,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 12.222,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 435.85100000000006,
      "heapDeltaBytes": 14739332,
      "heapUsedBytes": 87350964,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 147.71200000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 583.4810000000061,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 8.226999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 401.27700000000004,
      "heapDeltaBytes": 14810620,
      "heapUsedBytes": 87154452,
      "domNodes": 14,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 138.678,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2054.8989999999776,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.129999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 556.9399999999999,
      "heapDeltaBytes": -77080,
      "heapUsedBytes": 71854320,
      "domNodes": -296,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 10.488999999999999,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.135000000072,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.481,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 495.221,
      "heapDeltaBytes": -10343064,
      "heapUsedBytes": 61544176,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.757000000000001,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1773.2139999999958,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 44.81499999999999,
      "layouts": 18,
      "layoutDurationMs": 5.667,
      "taskDurationMs": 899.442,
      "heapDeltaBytes": 2371756,
      "heapUsedBytes": 75259028,
      "domNodes": -294,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 121.57699999999998,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1722.4249999999302,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 39.61000000000001,
      "layouts": 18,
      "layoutDurationMs": 5.939,
      "taskDurationMs": 841.068,
      "heapDeltaBytes": 2095776,
      "heapUsedBytes": 74901532,
      "domNodes": -295,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 112.888,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1449.043999999958,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 32.086,
      "layouts": 15,
      "layoutDurationMs": 15.723,
      "taskDurationMs": 941.032,
      "heapDeltaBytes": -5488580,
      "heapUsedBytes": 86999364,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 32.52200000000001,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 142,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9562.085000000025,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 37.543000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6411.3769999999995,
      "heapDeltaBytes": 14216752,
      "heapUsedBytes": 90141800,
      "domNodes": -270,
      "jsHeapTotalBytes": 110592,
      "scriptDurationMs": 2925.243,
      "eventListeners": -165,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8496.217,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 34.902,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5817.52,
      "heapDeltaBytes": -11948828,
      "heapUsedBytes": 88973552,
      "domNodes": -268,
      "jsHeapTotalBytes": -1130496,
      "scriptDurationMs": 2732.009,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17073.81600000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16495.862,
      "heapDeltaBytes": -34819260,
      "heapUsedBytes": 175376612,
      "domNodes": -6548,
      "jsHeapTotalBytes": 3424256,
      "scriptDurationMs": 278.974,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17126.251000000026,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16655.740999999998,
      "heapDeltaBytes": -34859964,
      "heapUsedBytes": 175476880,
      "domNodes": -6548,
      "jsHeapTotalBytes": 3141632,
      "scriptDurationMs": 268.98,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.216666666666665,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21368.08400000001,
      "styleRecalcs": 178,
      "styleRecalcDurationMs": 18.844000000000026,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20931.745,
      "heapDeltaBytes": -14211660,
      "heapUsedBytes": 190203276,
      "domNodes": -6548,
      "jsHeapTotalBytes": -901120,
      "scriptDurationMs": 960.9319999999999,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 178,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21087.475000000042,
      "styleRecalcs": 168,
      "styleRecalcDurationMs": 19.85399999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20801.987999999998,
      "heapDeltaBytes": -11779412,
      "heapUsedBytes": 188949236,
      "domNodes": -6548,
      "jsHeapTotalBytes": 5996544,
      "scriptDurationMs": 953.1310000000001,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 47,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6121.403999999984,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 82.07999999999998,
      "layouts": 20,
      "layoutDurationMs": 23.299,
      "taskDurationMs": 6019.607,
      "heapDeltaBytes": -34231400,
      "heapUsedBytes": 174622320,
      "domNodes": -6548,
      "jsHeapTotalBytes": 4501504,
      "scriptDurationMs": 126.29200000000002,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 372,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6202.046999999993,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 81.30400000000004,
      "layouts": 20,
      "layoutDurationMs": 23.819999999999993,
      "taskDurationMs": 6117.094000000001,
      "heapDeltaBytes": -16875788,
      "heapUsedBytes": 185454540,
      "domNodes": -6548,
      "jsHeapTotalBytes": 13103104,
      "scriptDurationMs": 113.57600000000001,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 462,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 480.4789999999457,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 23.529,
      "layouts": 3,
      "layoutDurationMs": 1.6429999999999998,
      "taskDurationMs": 122.52799999999999,
      "heapDeltaBytes": 5311016,
      "heapUsedBytes": 73810344,
      "domNodes": 153,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 12.893000000000002,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 110.04100000002381,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 17.645999999999997,
      "layouts": 2,
      "layoutDurationMs": 0.7540000000000001,
      "taskDurationMs": 79.117,
      "heapDeltaBytes": 3156116,
      "heapUsedBytes": 71661272,
      "domNodes": 108,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.850999999999997,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48226 70918 68.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.2% 1185
src/LGraphNode.ts 69.5% 396
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.1% 305
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.4% 261
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 45.0% 203

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 22, 2026
@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.53   #18350   +/-   ##
=============================================
  Coverage              ?   83.42%           
=============================================
  Files                 ?     2028           
  Lines                 ?   117783           
  Branches              ?    32472           
=============================================
  Hits                  ?    98262           
  Misses                ?    19172           
  Partials              ?      349           
Flag Coverage Δ
e2e 66.50% <100.00%> (?)
unit 76.82% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ns/vueNodes/widgets/composables/useStringWidget.ts 97.43% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

comfy-pr-bot pushed a commit that referenced this pull request Sep 23, 2026
…idget value (#18354)

<!-- ccr-slack-attribution -->
_Requested via [Slack
thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1790036595619019?thread_ts=1790036595.619019&cid=C09KFK2ABB8)_

Manual backport of #18324 to `core/1.54`. The automated
`pr-backport.yaml` bot never reached this target (it errored out after
processing `core/1.53` and `cloud/1.53`, and never attempted `core/1.54`
or `cloud/1.54`), even though #18324 carries the `core/1.54` label. No
bot failure comment exists for this target, so this was cherry-picked
manually following the same pattern used for the `core/1.53` (#18352)
and `cloud/1.53` (#18350) backports.

## Fix

Fixes a `ReferenceError` (temporal-dead-zone) crash when a workflow with
a saved multiline STRING widget value is loaded. `setValue` in
`useStringWidget.ts`'s `addMultilineWidget()` closed over the outer
`widget` const to read `widget.options`, but `node.addDOMWidget(...)`
can invoke `setValue` synchronously (while restoring a saved value
during workflow load) before that `const widget =
node.addDOMWidget(...)` assignment completes. The fix hoists the
widget's options into their own `widgetOptions` const, declared and
initialized before `addDOMWidget` is called, and has `setValue` read
that instead of the outer `widget` binding.

## Conflict resolution

The cherry-pick of `eefd88f4f424803e102c367d296106ecd749d798`
(single-parent commit, plain `git cherry-pick`) applied cleanly with no
conflicts in either `useStringWidget.ts` or `useStringWidget.test.ts` —
git's auto-merge resolved both files without manual intervention.

## Verification

- `useStringWidget.test.ts`: 5/5 tests pass
- `pnpm typecheck`: clean
- No `pnpm-lock.yaml` or `package.json` changes needed

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01KQEWS3P3LxaJx8jVvy5TUb

---
_Generated by [Claude
Code](https://claude.ai/code/session_01KQEWS3P3LxaJx8jVvy5TUb)_

Co-authored-by: comfy-tag-bot <comfy-tag-bot@users.noreply.github.com>
@comfy-pr-bot
comfy-pr-bot merged commit 932b8ee into cloud/1.53 Sep 23, 2026
110 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-18324-to-cloud-1.53 branch September 23, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R2 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants