Repository navigation
[backport cloud/1.53] fix: avoid TDZ crash restoring saved multiline widget value - #18350
Conversation
setValue in useStringWidget.ts's addMultilineWidget() closed over the outer `widget` const to read widget.options, but node.addDOMWidget(...) can invoke setValue synchronously - while restoring a previously saved widget value during workflow load - before that assignment completes. Reading widget.options at that point threw a ReferenceError (temporal dead zone). Hoists the widget's options object into its own widgetOptions const, declared and fully initialized before addDOMWidget is called, and has setValue reference that instead of the outer widget binding. Backport of #18324 to cloud/1.53.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1903 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-22T04:35:37.925Z",
"gitSha": "72bf1e62b7f26a9d5a04dc55e73751bc792250c8",
"branch": "backport-18324-to-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2104.1079999999965,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.576,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.4240000000001,
"heapDeltaBytes": 191192,
"heapUsedBytes": 70607712,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.022000000000004,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2056.966999999986,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.032000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.29799999999994,
"heapDeltaBytes": -13034588,
"heapUsedBytes": 56599100,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.421,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1923.798999999974,
"styleRecalcs": 82,
"styleRecalcDurationMs": 45.068999999999996,
"layouts": 14,
"layoutDurationMs": 4.324,
"taskDurationMs": 940.409,
"heapDeltaBytes": 2642628,
"heapUsedBytes": 73068316,
"domNodes": -278,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 169.23,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1885.5819999999994,
"styleRecalcs": 76,
"styleRecalcDurationMs": 40.129999999999995,
"layouts": 14,
"layoutDurationMs": 4.431,
"taskDurationMs": 892.636,
"heapDeltaBytes": 4313556,
"heapUsedBytes": 74080092,
"domNodes": -284,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 161.172,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1663.5109999999713,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.522000000000002,
"layouts": 6,
"layoutDurationMs": 1.0450000000000002,
"taskDurationMs": 398.08200000000005,
"heapDeltaBytes": 4658816,
"heapUsedBytes": 75512160,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.129999999999995,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.0789999999706,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.864,
"layouts": 6,
"layoutDurationMs": 0.9360000000000002,
"taskDurationMs": 361.163,
"heapDeltaBytes": 4368208,
"heapUsedBytes": 75029776,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.415000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 690.0619999999549,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.743,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.547,
"heapDeltaBytes": 18803180,
"heapUsedBytes": 88388048,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 167.503,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 675.3120000000763,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.522999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.0799999999999,
"heapDeltaBytes": 17791184,
"heapUsedBytes": 88031828,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 165.015,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2028.3069999999839,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.0889999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 663.8240000000001,
"heapDeltaBytes": -14300296,
"heapUsedBytes": 86459316,
"domNodes": -270,
"jsHeapTotalBytes": -1355776,
"scriptDurationMs": 36.53200000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2029.7309999999698,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.446,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 598.7520000000001,
"heapDeltaBytes": 10919624,
"heapUsedBytes": 86006544,
"domNodes": -269,
"jsHeapTotalBytes": -1130496,
"scriptDurationMs": 33.155,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2581.729999999993,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.374999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1786.225,
"heapDeltaBytes": 23467304,
"heapUsedBytes": 88875864,
"domNodes": -280,
"jsHeapTotalBytes": 2060288,
"scriptDurationMs": 879.039,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2260.992999999985,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.855000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1584.867,
"heapDeltaBytes": 22144968,
"heapUsedBytes": 88239216,
"domNodes": 4,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 816.33,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3764.1810000000078,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.517999999999999,
"layouts": 60,
"layoutDurationMs": 12.649000000000001,
"taskDurationMs": 1868.933,
"heapDeltaBytes": 8016860,
"heapUsedBytes": 75410424,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 826.0400000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3492.8200000000516,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.254000000000003,
"layouts": 60,
"layoutDurationMs": 11.583,
"taskDurationMs": 1648.2199999999998,
"heapDeltaBytes": 8497776,
"heapUsedBytes": 76204424,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 758.171,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3182.95599999999,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.159000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2087.1279999999997,
"heapDeltaBytes": 25629684,
"heapUsedBytes": 92670716,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1051.893,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3136.27699999995,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.872999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1932.34,
"heapDeltaBytes": 24481900,
"heapUsedBytes": 91924548,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 975.7499999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2016.8009999999867,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.488999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.4630000000001,
"heapDeltaBytes": -15223128,
"heapUsedBytes": 87201652,
"domNodes": -274,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 36.106,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.644000000023,
"styleRecalcs": 3,
"styleRecalcDurationMs": 5.478000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.525,
"heapDeltaBytes": 21802572,
"heapUsedBytes": 87692996,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.28600000000001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 659.4589999999698,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.222,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.85100000000006,
"heapDeltaBytes": 14739332,
"heapUsedBytes": 87350964,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 147.71200000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 583.4810000000061,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.226999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.27700000000004,
"heapDeltaBytes": 14810620,
"heapUsedBytes": 87154452,
"domNodes": 14,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 138.678,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2054.8989999999776,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.129999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.9399999999999,
"heapDeltaBytes": -77080,
"heapUsedBytes": 71854320,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.488999999999999,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.135000000072,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.481,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.221,
"heapDeltaBytes": -10343064,
"heapUsedBytes": 61544176,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.757000000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1773.2139999999958,
"styleRecalcs": 79,
"styleRecalcDurationMs": 44.81499999999999,
"layouts": 18,
"layoutDurationMs": 5.667,
"taskDurationMs": 899.442,
"heapDeltaBytes": 2371756,
"heapUsedBytes": 75259028,
"domNodes": -294,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 121.57699999999998,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.4249999999302,
"styleRecalcs": 78,
"styleRecalcDurationMs": 39.61000000000001,
"layouts": 18,
"layoutDurationMs": 5.939,
"taskDurationMs": 841.068,
"heapDeltaBytes": 2095776,
"heapUsedBytes": 74901532,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 112.888,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1449.043999999958,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.086,
"layouts": 15,
"layoutDurationMs": 15.723,
"taskDurationMs": 941.032,
"heapDeltaBytes": -5488580,
"heapUsedBytes": 86999364,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 32.52200000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9562.085000000025,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.543000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6411.3769999999995,
"heapDeltaBytes": 14216752,
"heapUsedBytes": 90141800,
"domNodes": -270,
"jsHeapTotalBytes": 110592,
"scriptDurationMs": 2925.243,
"eventListeners": -165,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8496.217,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.902,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5817.52,
"heapDeltaBytes": -11948828,
"heapUsedBytes": 88973552,
"domNodes": -268,
"jsHeapTotalBytes": -1130496,
"scriptDurationMs": 2732.009,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17073.81600000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16495.862,
"heapDeltaBytes": -34819260,
"heapUsedBytes": 175376612,
"domNodes": -6548,
"jsHeapTotalBytes": 3424256,
"scriptDurationMs": 278.974,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17126.251000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16655.740999999998,
"heapDeltaBytes": -34859964,
"heapUsedBytes": 175476880,
"domNodes": -6548,
"jsHeapTotalBytes": 3141632,
"scriptDurationMs": 268.98,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21368.08400000001,
"styleRecalcs": 178,
"styleRecalcDurationMs": 18.844000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20931.745,
"heapDeltaBytes": -14211660,
"heapUsedBytes": 190203276,
"domNodes": -6548,
"jsHeapTotalBytes": -901120,
"scriptDurationMs": 960.9319999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 178,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21087.475000000042,
"styleRecalcs": 168,
"styleRecalcDurationMs": 19.85399999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20801.987999999998,
"heapDeltaBytes": -11779412,
"heapUsedBytes": 188949236,
"domNodes": -6548,
"jsHeapTotalBytes": 5996544,
"scriptDurationMs": 953.1310000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 47,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6121.403999999984,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.07999999999998,
"layouts": 20,
"layoutDurationMs": 23.299,
"taskDurationMs": 6019.607,
"heapDeltaBytes": -34231400,
"heapUsedBytes": 174622320,
"domNodes": -6548,
"jsHeapTotalBytes": 4501504,
"scriptDurationMs": 126.29200000000002,
"eventListeners": -7471,
"totalBlockingTimeMs": 372,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6202.046999999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.30400000000004,
"layouts": 20,
"layoutDurationMs": 23.819999999999993,
"taskDurationMs": 6117.094000000001,
"heapDeltaBytes": -16875788,
"heapUsedBytes": 185454540,
"domNodes": -6548,
"jsHeapTotalBytes": 13103104,
"scriptDurationMs": 113.57600000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 462,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 480.4789999999457,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.529,
"layouts": 3,
"layoutDurationMs": 1.6429999999999998,
"taskDurationMs": 122.52799999999999,
"heapDeltaBytes": 5311016,
"heapUsedBytes": 73810344,
"domNodes": 153,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.893000000000002,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 110.04100000002381,
"styleRecalcs": 7,
"styleRecalcDurationMs": 17.645999999999997,
"layouts": 2,
"layoutDurationMs": 0.7540000000000001,
"taskDurationMs": 79.117,
"heapDeltaBytes": 3156116,
"heapUsedBytes": 71661272,
"domNodes": 108,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.850999999999997,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.53 #18350 +/- ##
=============================================
Coverage ? 83.42%
=============================================
Files ? 2028
Lines ? 117783
Branches ? 32472
=============================================
Hits ? 98262
Misses ? 19172
Partials ? 349
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…idget value (#18354) <!-- ccr-slack-attribution --> _Requested via [Slack thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1790036595619019?thread_ts=1790036595.619019&cid=C09KFK2ABB8)_ Manual backport of #18324 to `core/1.54`. The automated `pr-backport.yaml` bot never reached this target (it errored out after processing `core/1.53` and `cloud/1.53`, and never attempted `core/1.54` or `cloud/1.54`), even though #18324 carries the `core/1.54` label. No bot failure comment exists for this target, so this was cherry-picked manually following the same pattern used for the `core/1.53` (#18352) and `cloud/1.53` (#18350) backports. ## Fix Fixes a `ReferenceError` (temporal-dead-zone) crash when a workflow with a saved multiline STRING widget value is loaded. `setValue` in `useStringWidget.ts`'s `addMultilineWidget()` closed over the outer `widget` const to read `widget.options`, but `node.addDOMWidget(...)` can invoke `setValue` synchronously (while restoring a saved value during workflow load) before that `const widget = node.addDOMWidget(...)` assignment completes. The fix hoists the widget's options into their own `widgetOptions` const, declared and initialized before `addDOMWidget` is called, and has `setValue` read that instead of the outer `widget` binding. ## Conflict resolution The cherry-pick of `eefd88f4f424803e102c367d296106ecd749d798` (single-parent commit, plain `git cherry-pick`) applied cleanly with no conflicts in either `useStringWidget.ts` or `useStringWidget.test.ts` — git's auto-merge resolved both files without manual intervention. ## Verification - `useStringWidget.test.ts`: 5/5 tests pass - `pnpm typecheck`: clean - No `pnpm-lock.yaml` or `package.json` changes needed 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01KQEWS3P3LxaJx8jVvy5TUb --- _Generated by [Claude Code](https://claude.ai/code/session_01KQEWS3P3LxaJx8jVvy5TUb)_ Co-authored-by: comfy-tag-bot <comfy-tag-bot@users.noreply.github.com>
Requested via Slack thread
Manual backport of #18324 to
cloud/1.53. The automated backport bot hit a merge conflict insrc/renderer/extensions/vueNodes/widgets/composables/useStringWidget.tsand could not land it automatically, so this was cherry-picked and resolved by hand.Fix:
setValueinuseStringWidget.ts'saddMultilineWidget()closed over the outerwidgetconst to readwidget.options, butnode.addDOMWidget(...)can invokesetValuesynchronously — while restoring a previously saved widget value during workflow load — before that assignment completes, throwing aReferenceError(temporal dead zone). The fix hoists the widget's options object into its ownwidgetOptionsconst, declared and initialized beforeaddDOMWidgetis called, and hassetValuereference that instead of the outerwidgetbinding.Conflict resolution: the only conflict was in
useStringWidget.ts, where cloud/1.53's version ofsetValuestill referencedwidget.options ?? {}; resolved by taking the fixed version (options: widgetOptions), consistent with the rest of the already-hoistedwidgetOptionspattern.useStringWidget.test.tsmerged automatically with no conflicts. Nopackage.json/pnpm-lock.yamlchanges were needed.🤖 Generated with Claude Code
https://claude.ai/code/session_01KQEWS3P3LxaJx8jVvy5TUb
Generated by Claude Code