Skip to content

[backport cloud/1.54] MiniMax template wiring (PM-993): preserve agent workflow connections after dynamic input reordering - #18393

Merged
christian-byrne merged 1 commit into
cloud/1.54from
backport-17221-to-cloud-1.54
Sep 22, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
backport-17221-to-cloud-1.54

Conversation

@ryan-di

@ryan-di ryan-di commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Backport #17221 to cloud/1.54 so agent-loaded workflows keep connections on their named inputs after dynamic input reordering. Fixes PM-993.

Changes

Review Focus

Release test-fixture adaptation. Original limitations remain: authoritative snapshots can replace runtime slot objects; producer-side addressing is out of scope.

Validation: input-order regressions fail 2/2 on the release baseline and pass with the backport; related CRDT/store suites pass (50 files, 770 passed, 2 expected failures). App/browser typechecks, full lint, formatting, Knip, ADR validation and commit hooks passed. Browser tests were not executed locally.

CI on 80fb9c3cb3 completed with no failures or pending checks. Cloud browser suite: 215 passed, 2 skipped, 0 flaky; minimaxAutogrowReload.spec.ts passed on its first attempt (retry 0). Unit coverage, browser matrix, ecosystem and lint checks passed.

Backport of #17221 (4e497de). Adapt the browser regression to the release HostDoc and agent boot fixtures; #18340 is already in the release base.
@ryan-di ryan-di added the backport Backporting a PR onto a release candidate label Sep 22, 2026
@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 22, 2026 6:48am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: c4df1721-a381-40c0-b453-42e122aa15fa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/22/2026, 06:51:35 AM UTC

Links

🎭 Playwright: ✅ 1937 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1916 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 127ms TBT · 99.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.4 MB heap
vue-large-graph-idle: · 57.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.2 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 33ms TBT · 166.2 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 350ms TBT · 172.3 MB heap
vue-zoom-out-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 10ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 537ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 54.5 MB
canvas-idle: DOM nodes -279
canvas-idle: event listeners -194
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 32ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 936ms
canvas-mouse-sweep: script duration 153ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 68.5 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -180
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 368ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.6 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 445ms
dom-widget-clipping: script duration 154ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.5 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 4
large-graph-idle: task duration 595ms
large-graph-idle: script duration 31ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.5 MB
large-graph-idle: DOM nodes -268
large-graph-idle: event listeners -176
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1632ms
large-graph-pan: script duration 779ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 79.5 MB
large-graph-pan: DOM nodes -273
large-graph-pan: event listeners -163
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1673ms
large-graph-zoom: script duration 738ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.3 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 10ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 1976ms
legacy-node-drag: script duration 950ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 75.4 MB
legacy-node-drag: DOM nodes -253
legacy-node-drag: event listeners -10
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 603ms
minimap-idle: script duration 31ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.9 MB
minimap-idle: DOM nodes -268
minimap-idle: event listeners -179
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 411ms
subgraph-dom-widget-clipping: script duration 136ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.8 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 521ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 64.3 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -240
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 27ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 828ms
subgraph-mouse-sweep: script duration 97ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 69.4 MB
subgraph-mouse-sweep: DOM nodes -293
subgraph-mouse-sweep: event listeners -226
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 28ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 921ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 127ms
subgraph-transition-enter: heap used 99.2 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5749ms
viewport-pan-sweep: script duration 2570ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 85.4 MB
viewport-pan-sweep: DOM nodes -267
viewport-pan-sweep: event listeners -163
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 15284ms
vue-large-graph-idle: script duration 261ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.2 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14934
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 16ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 143
vue-large-graph-pan: task duration 18410ms
vue-large-graph-pan: script duration 848ms
vue-large-graph-pan: TBT 33ms
vue-large-graph-pan: heap used 166.2 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 27ms
vue-node-resize-workload: style recalc duration 82ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5589ms
vue-node-resize-workload: script duration 105ms
vue-node-resize-workload: TBT 350ms
vue-node-resize-workload: heap used 172.3 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14931
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7607ms
vue-zoom-out-idle: script duration 133ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 169.9 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 3
workflow-execution: style recalc count 9
workflow-execution: task duration 85ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.5 MB
workflow-execution: DOM nodes 124
workflow-execution: event listeners 33
Raw data
{
  "timestamp": "2026-09-22T06:59:47.153Z",
  "gitSha": "65a835891aa786f367e6acdf3a08d19be9bbfa44",
  "branch": "backport-17221-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2061.9660000000977,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.123999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 559.7789999999999,
      "heapDeltaBytes": -12289424,
      "heapUsedBytes": 56791028,
      "domNodes": -280,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 9.864999999999998,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2037.3759999999947,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.918,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 514.8229999999999,
      "heapDeltaBytes": -11491252,
      "heapUsedBytes": 57604784,
      "domNodes": -278,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 8.683,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2020.894999999996,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 35.82599999999999,
      "layouts": 14,
      "layoutDurationMs": 4.752,
      "taskDurationMs": 991.7890000000001,
      "heapDeltaBytes": 7743560,
      "heapUsedBytes": 78816964,
      "domNodes": -282,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 161.03,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1822.9629999999588,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 28.070999999999998,
      "layouts": 14,
      "layoutDurationMs": 3.9229999999999996,
      "taskDurationMs": 880.5319999999999,
      "heapDeltaBytes": -5262228,
      "heapUsedBytes": 64775508,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 144.31900000000002,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1665.271999999959,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 15.004000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.082,
      "taskDurationMs": 372.714,
      "heapDeltaBytes": 4561308,
      "heapUsedBytes": 75552160,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.931000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1756.5859999999702,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.634999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.9519999999999997,
      "taskDurationMs": 362.612,
      "heapDeltaBytes": 4593316,
      "heapUsedBytes": 74552960,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.842,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 674.2329999999583,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.117000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 435.7420000000001,
      "heapDeltaBytes": -7535656,
      "heapUsedBytes": 63435972,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 149.50799999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 651.3739999999189,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.636000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 455.2289999999999,
      "heapDeltaBytes": 18672604,
      "heapUsedBytes": 88648372,
      "domNodes": 16,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 159.191,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.2410000000373,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.501000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 647.371,
      "heapDeltaBytes": 10325948,
      "heapUsedBytes": 86838256,
      "domNodes": -271,
      "jsHeapTotalBytes": -2203648,
      "scriptDurationMs": 31.583000000000006,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2000.2789999999777,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.6510000000000031,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 543.5129999999999,
      "heapDeltaBytes": 21409736,
      "heapUsedBytes": 88366464,
      "domNodes": -264,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 31.313999999999993,
      "eventListeners": -158,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2323.3279999999468,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 9.759,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1664.886,
      "heapDeltaBytes": 3686628,
      "heapUsedBytes": 80867972,
      "domNodes": -275,
      "jsHeapTotalBytes": -929792,
      "scriptDurationMs": 785.587,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2167.863000000011,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 9.531,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1599.9750000000001,
      "heapDeltaBytes": -18233896,
      "heapUsedBytes": 85960468,
      "domNodes": -271,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 771.942,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3579.0519999999333,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.822999999999999,
      "layouts": 60,
      "layoutDurationMs": 12.265999999999998,
      "taskDurationMs": 1700.8360000000002,
      "heapDeltaBytes": 12213200,
      "heapUsedBytes": 80107820,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 746.185,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3565.729000000033,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.526,
      "layouts": 60,
      "layoutDurationMs": 11.863999999999999,
      "taskDurationMs": 1644.4270000000004,
      "heapDeltaBytes": 7747196,
      "heapUsedBytes": 75705432,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 729.3720000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3131.1509999999316,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 12.533,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1992.7759999999998,
      "heapDeltaBytes": 4833820,
      "heapUsedBytes": 85205344,
      "domNodes": -252,
      "jsHeapTotalBytes": 573440,
      "scriptDurationMs": 945.3480000000001,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3114.9940000000242,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 8.225999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1959.0850000000003,
      "heapDeltaBytes": -7760796,
      "heapUsedBytes": 72830372,
      "domNodes": -254,
      "jsHeapTotalBytes": -368640,
      "scriptDurationMs": 954.8659999999999,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2040.0589999999283,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 8.05,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 610.994,
      "heapDeltaBytes": 10186788,
      "heapUsedBytes": 88011344,
      "domNodes": -266,
      "jsHeapTotalBytes": -2203648,
      "scriptDurationMs": 30.313000000000006,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2034.0310000000272,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.504000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 594.312,
      "heapDeltaBytes": 10552060,
      "heapUsedBytes": 87859864,
      "domNodes": -269,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 30.804,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 590.319999999906,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.228,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 415.644,
      "heapDeltaBytes": 14700688,
      "heapUsedBytes": 87740340,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 136.833,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 605.1070000000891,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.060999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 405.941,
      "heapDeltaBytes": 15064520,
      "heapUsedBytes": 87914088,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 135.97400000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.7229999999754,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.871999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 542.9509999999999,
      "heapDeltaBytes": -8834284,
      "heapUsedBytes": 63288980,
      "domNodes": -296,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.719999999999999,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2016.6239999999789,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.248000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 498.613,
      "heapDeltaBytes": -475412,
      "heapUsedBytes": 71552632,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.104,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1715.7529999999497,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 27.090999999999998,
      "layouts": 18,
      "layoutDurationMs": 4.9350000000000005,
      "taskDurationMs": 834.25,
      "heapDeltaBytes": -5633932,
      "heapUsedBytes": 67225376,
      "domNodes": -292,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 97.77,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1739.9179999999888,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 26.805999999999997,
      "layouts": 18,
      "layoutDurationMs": 4.974,
      "taskDurationMs": 822.365,
      "heapDeltaBytes": 5305944,
      "heapUsedBytes": 78395536,
      "domNodes": -294,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 96.249,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1385.5669999999236,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 28.479999999999997,
      "layouts": 16,
      "layoutDurationMs": 13.906000000000002,
      "taskDurationMs": 921.0559999999999,
      "heapDeltaBytes": 20808396,
      "heapUsedBytes": 104070580,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 29.108999999999995,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 127,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8281.535000000076,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 35.069,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5755.588,
      "heapDeltaBytes": 13948780,
      "heapUsedBytes": 89723864,
      "domNodes": -269,
      "jsHeapTotalBytes": 380928,
      "scriptDurationMs": 2558.2380000000003,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8314.00999999994,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 34.665,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5742.923999999999,
      "heapDeltaBytes": -12798140,
      "heapUsedBytes": 89353196,
      "domNodes": -265,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 2582.477,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15940.35299999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15301.100999999999,
      "heapDeltaBytes": -63713776,
      "heapUsedBytes": 171629252,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16691200,
      "scriptDurationMs": 272.84000000000003,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16038.14699999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15267.468,
      "heapDeltaBytes": -53104376,
      "heapUsedBytes": 183104248,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11448320,
      "scriptDurationMs": 248.56499999999997,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18602.036,
      "styleRecalcs": 143,
      "styleRecalcDurationMs": 16.025000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18372.878999999997,
      "heapDeltaBytes": -58110136,
      "heapUsedBytes": 166058880,
      "domNodes": -8068,
      "jsHeapTotalBytes": -13205504,
      "scriptDurationMs": 848.7289999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 60,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18780.451000000085,
      "styleRecalcs": 143,
      "styleRecalcDurationMs": 16.371999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18446.709,
      "heapDeltaBytes": -35664836,
      "heapUsedBytes": 182429052,
      "domNodes": -8068,
      "jsHeapTotalBytes": -8634368,
      "scriptDurationMs": 847.101,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 5,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5610.738000000083,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 88.52599999999997,
      "layouts": 20,
      "layoutDurationMs": 29.637999999999998,
      "taskDurationMs": 5526.186000000001,
      "heapDeltaBytes": -40928488,
      "heapUsedBytes": 176388088,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10952704,
      "scriptDurationMs": 98.96300000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 484,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5731.567999999925,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 75.888,
      "layouts": 20,
      "layoutDurationMs": 24.024000000000004,
      "taskDurationMs": 5651.254,
      "heapDeltaBytes": -42710180,
      "heapUsedBytes": 184933728,
      "domNodes": -8068,
      "jsHeapTotalBytes": 14544896,
      "scriptDurationMs": 111.198,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 215,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8026.454000000058,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7624.891999999999,
      "heapDeltaBytes": -4341572,
      "heapUsedBytes": 176778520,
      "domNodes": 0,
      "jsHeapTotalBytes": -26476544,
      "scriptDurationMs": 149.04300000000003,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7906.811999999945,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7590.017999999999,
      "heapDeltaBytes": -2739300,
      "heapUsedBytes": 179532144,
      "domNodes": 0,
      "jsHeapTotalBytes": -14417920,
      "scriptDurationMs": 116.97800000000002,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 130.58300000000145,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 19.542000000000005,
      "layouts": 3,
      "layoutDurationMs": 3.6350000000000002,
      "taskDurationMs": 95.17099999999999,
      "heapDeltaBytes": 3142084,
      "heapUsedBytes": 72041452,
      "domNodes": 141,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.665000000000001,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 101.62300000001778,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 14.251000000000001,
      "layouts": 2,
      "layoutDurationMs": 0.866,
      "taskDurationMs": 73.94500000000001,
      "heapDeltaBytes": 3001548,
      "heapUsedBytes": 71623684,
      "domNodes": 106,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.587000000000001,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 50306 75409 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.3% 264
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.6% 257
src/scripts/pnginfo.ts 21.4% 221

@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.45455% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../extensions/agent/crdt/__fixtures__/crdtSession.ts 91.11% 4 Missing ⚠️
.../workbench/extensions/agent/crdt/graphMutations.ts 98.27% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #18393   +/-   ##
=============================================
  Coverage              ?   83.60%           
=============================================
  Files                 ?     2097           
  Lines                 ?   123942           
  Branches              ?    31377           
=============================================
  Hits                  ?   103623           
  Misses                ?    20141           
  Partials              ?      178           
Flag Coverage Δ
e2e 66.72% <ø> (?)
unit 78.56% <95.45%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...h/extensions/agent/crdt/__fixtures__/inputOrder.ts 100.00% <100.00%> (ø)
...nch/extensions/agent/crdt/agentNodeMaterializer.ts 99.25% <100.00%> (ø)
.../workbench/extensions/agent/crdt/graphMutations.ts 95.29% <98.27%> (ø)
.../extensions/agent/crdt/__fixtures__/crdtSession.ts 91.11% <91.11%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ryan-di
ryan-di marked this pull request as ready for review September 22, 2026 07:12
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 22, 2026
@github-actions
github-actions Bot requested a review from huang47 September 22, 2026 07:13
@ryan-di ryan-di added core/1.54 Backport PRs for core 1.54 cloud/1.54 Backport PRs for cloud 1.54 labels Sep 22, 2026
@christian-byrne
christian-byrne merged commit 9199835 into cloud/1.54 Sep 22, 2026
130 of 134 checks passed
@christian-byrne
christian-byrne deleted the backport-17221-to-cloud-1.54 branch September 22, 2026 07:20
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-docs Agent product architecture, contracts or documentation agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-docs Agent product architecture, contracts or documentation agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support backport Backporting a PR onto a release candidate cloud/1.54 Backport PRs for cloud 1.54 core/1.54 Backport PRs for core 1.54 risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants