Repository navigation
[backport core/1.54] fix: copy/paste beside the agent panel (#18062) - #18337
Conversation
Backport of ec5da77 to core/1.54. Dropped the agentConversationFixture and agent replay spec hunks: those files do not exist on core/1.54. Dropped AgentCopyPasteDriver.ts and agentCopyPaste.spec.ts: the agent conversation replay fixture they depend on is absent on core/1.54.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1933 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T02:46:42.288Z",
"gitSha": "f80c61e3598747c3642d346af448615b8850063a",
"branch": "backport-18062-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2084.403000000009,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.593000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 590.3439999999999,
"heapDeltaBytes": -9515236,
"heapUsedBytes": 60592168,
"domNodes": -282,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.470000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1997.4640000000363,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.627000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.451,
"heapDeltaBytes": 1935604,
"heapUsedBytes": 71975096,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.401,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1833.4799999999518,
"styleRecalcs": 74,
"styleRecalcDurationMs": 30.549,
"layouts": 14,
"layoutDurationMs": 4.231999999999999,
"taskDurationMs": 868.091,
"heapDeltaBytes": -14047940,
"heapUsedBytes": 56767240,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 155.304,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1874.7449999999617,
"styleRecalcs": 76,
"styleRecalcDurationMs": 30.135,
"layouts": 14,
"layoutDurationMs": 4.487,
"taskDurationMs": 886.012,
"heapDeltaBytes": -3716964,
"heapUsedBytes": 67060508,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 161.719,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.1699999999682,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.29,
"layouts": 6,
"layoutDurationMs": 1.089,
"taskDurationMs": 370.226,
"heapDeltaBytes": 4317956,
"heapUsedBytes": 74243864,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.896999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.8869999999397,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.827,
"layouts": 6,
"layoutDurationMs": 1.3000000000000003,
"taskDurationMs": 396.108,
"heapDeltaBytes": 4265640,
"heapUsedBytes": 73942148,
"domNodes": 78,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 12.575,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 721.8369999999936,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.091,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.972,
"heapDeltaBytes": -7606460,
"heapUsedBytes": 63150360,
"domNodes": 14,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 173.676,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 692.1469999999772,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.572,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.72400000000005,
"heapDeltaBytes": 17645284,
"heapUsedBytes": 88204688,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 170.436,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2048.198999999954,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.835000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 624.7420000000001,
"heapDeltaBytes": -16368108,
"heapUsedBytes": 86875044,
"domNodes": -267,
"jsHeapTotalBytes": -856064,
"scriptDurationMs": 37.629,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2066.320000000019,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.044,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 664.404,
"heapDeltaBytes": 9232744,
"heapUsedBytes": 85284288,
"domNodes": -269,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 39.285000000000004,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2361.838999999975,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.254000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1680.5000000000002,
"heapDeltaBytes": 23279500,
"heapUsedBytes": 89736468,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 861.671,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2241.6090000000395,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.956999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1645.6739999999998,
"heapDeltaBytes": 20453964,
"heapUsedBytes": 87342976,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 829.441,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3573.6029999999914,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.584000000000001,
"layouts": 60,
"layoutDurationMs": 12.169999999999998,
"taskDurationMs": 1709.3660000000002,
"heapDeltaBytes": 8049444,
"heapUsedBytes": 75887240,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 771.3389999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3563.4240000000545,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.846000000000004,
"layouts": 60,
"layoutDurationMs": 12.209000000000001,
"taskDurationMs": 1725.479,
"heapDeltaBytes": 8557100,
"heapUsedBytes": 76117852,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 795.9999999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3086.268000000018,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.695999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1914.1329999999998,
"heapDeltaBytes": 22522248,
"heapUsedBytes": 90633328,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 956.5340000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3065.411999999924,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.825999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1946.263,
"heapDeltaBytes": 22092348,
"heapUsedBytes": 89934064,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 955.3040000000002,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2039.611999999977,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.1110000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 630.372,
"heapDeltaBytes": 5177072,
"heapUsedBytes": 81963072,
"domNodes": -280,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 33.90800000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2061.2149999999474,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.0890000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 624.4159999999999,
"heapDeltaBytes": 10163076,
"heapUsedBytes": 87701068,
"domNodes": -276,
"jsHeapTotalBytes": -2727936,
"scriptDurationMs": 35.528000000000006,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.0700000000074,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.412999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.644,
"heapDeltaBytes": 15088608,
"heapUsedBytes": 88195384,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 143.393,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.9789999999193,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.357999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.80100000000004,
"heapDeltaBytes": 14695304,
"heapUsedBytes": 80745340,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.69199999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2049.4379999999524,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.949,
"heapDeltaBytes": -7732660,
"heapUsedBytes": 64233292,
"domNodes": -295,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 8.848000000000003,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.2080000000014,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.727,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.63199999999995,
"heapDeltaBytes": -8296332,
"heapUsedBytes": 63645596,
"domNodes": -293,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 7.993999999999998,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.0080000000166,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.096000000000004,
"layouts": 18,
"layoutDurationMs": 5.139,
"taskDurationMs": 826.5210000000001,
"heapDeltaBytes": -5096828,
"heapUsedBytes": 67802984,
"domNodes": -296,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 114.25,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.7800000000138,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.037999999999997,
"layouts": 18,
"layoutDurationMs": 4.517,
"taskDurationMs": 829.9409999999999,
"heapDeltaBytes": -927952,
"heapUsedBytes": 72046788,
"domNodes": -294,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 110.14400000000002,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.4269999999929,
"styleRecalcs": 20,
"styleRecalcDurationMs": 32.884,
"layouts": 16,
"layoutDurationMs": 16.174,
"taskDurationMs": 984.8329999999999,
"heapDeltaBytes": 21945144,
"heapUsedBytes": 105924204,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 32.937,
"eventListeners": 2385,
"totalBlockingTimeMs": 147,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8924.466999999993,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.37899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6132.377,
"heapDeltaBytes": -5702904,
"heapUsedBytes": 70975508,
"domNodes": -285,
"jsHeapTotalBytes": 5136384,
"scriptDurationMs": 2835.772,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8504.550000000108,
"styleRecalcs": 246,
"styleRecalcDurationMs": 34.296,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5887.889999999999,
"heapDeltaBytes": 14141880,
"heapUsedBytes": 89558160,
"domNodes": -274,
"jsHeapTotalBytes": -405504,
"scriptDurationMs": 2701.1020000000003,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17245.77899999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16734.794,
"heapDeltaBytes": -51139832,
"heapUsedBytes": 183202240,
"domNodes": -8068,
"jsHeapTotalBytes": -9400320,
"scriptDurationMs": 291.37199999999996,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17615.094999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16832.934999999998,
"heapDeltaBytes": -60578440,
"heapUsedBytes": 178340060,
"domNodes": -8068,
"jsHeapTotalBytes": -18001920,
"scriptDurationMs": 287.24300000000005,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20755.137000000046,
"styleRecalcs": 166,
"styleRecalcDurationMs": 17.71800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20372.888,
"heapDeltaBytes": -24603204,
"heapUsedBytes": 192449364,
"domNodes": -8097,
"jsHeapTotalBytes": -11399168,
"scriptDurationMs": 926.0459999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 35,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20887.395999999968,
"styleRecalcs": 172,
"styleRecalcDurationMs": 17.855999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20518.617,
"heapDeltaBytes": -64849624,
"heapUsedBytes": 168746720,
"domNodes": -8068,
"jsHeapTotalBytes": -13012992,
"scriptDurationMs": 886.302,
"eventListeners": -14929,
"totalBlockingTimeMs": 75,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6227.515000000039,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.87899999999999,
"layouts": 20,
"layoutDurationMs": 34.65299999999999,
"taskDurationMs": 6116.258999999999,
"heapDeltaBytes": -62756752,
"heapUsedBytes": 176277204,
"domNodes": -8067,
"jsHeapTotalBytes": 4804608,
"scriptDurationMs": 107.234,
"eventListeners": -14929,
"totalBlockingTimeMs": 588,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6311.406000000034,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.18600000000004,
"layouts": 20,
"layoutDurationMs": 22.389000000000006,
"taskDurationMs": 6190.736,
"heapDeltaBytes": -38446064,
"heapUsedBytes": 187033560,
"domNodes": -8068,
"jsHeapTotalBytes": 12623872,
"scriptDurationMs": 117.25,
"eventListeners": -14927,
"totalBlockingTimeMs": 422,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8772.809999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8469.718999999997,
"heapDeltaBytes": 16813024,
"heapUsedBytes": 178818732,
"domNodes": 0,
"jsHeapTotalBytes": -11796480,
"scriptDurationMs": 142.96600000000004,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9030.157000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8562.018,
"heapDeltaBytes": 5398336,
"heapUsedBytes": 176777160,
"domNodes": 0,
"jsHeapTotalBytes": -19922944,
"scriptDurationMs": 173.438,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 108.39700000002495,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.697999999999997,
"layouts": 2,
"layoutDurationMs": 1.111,
"taskDurationMs": 78.06,
"heapDeltaBytes": 3015796,
"heapUsedBytes": 71887256,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.684,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 100.59300000000349,
"styleRecalcs": 6,
"styleRecalcDurationMs": 10.973000000000003,
"layouts": 2,
"layoutDurationMs": 0.9340000000000002,
"taskDurationMs": 66.64200000000001,
"heapDeltaBytes": 3010644,
"heapUsedBytes": 71860564,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.657,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18337 +/- ##
============================================
Coverage 83.54% 83.54%
============================================
Files 2094 2094
Lines 123479 123520 +41
Branches 31432 33296 +1864
============================================
+ Hits 103165 103200 +35
- Misses 20135 20141 +6
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…ir real slot after an agent slot sync (PM-1449) (#18339) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789965308493739)_ ## Summary Backport of #18279 to `core/1.54`. The automated backport failed with a merge conflict, so this is a manual cherry-pick of merge commit `566c343fb95e77ee04c4dc3aa02ea40bcb416e66`. A hand-wired connection into an autogrow port could be serialized against the wrong input after an agent slot sync. `updateNodeSlots` replaced the store's slot arrays even though the live `LGraphNode` retained the original arrays, leaving serialization and the canvas with different slot layouts. The fix preserves the registered input/output arrays and patches matching slot objects in place instead of reassigning them. ## Conflict resolution Conflicts were in `src/stores/nodeDataStore.ts` and `src/stores/nodeDataStore.test.ts`: - `nodeDataStore.ts`: `updateNodeSlots` conflicted because `core/1.54`'s current version does a plain array reassignment (`state.inputs = slots.inputs`), while #18279 replaces that with the occurrence-aware `mergeSlotsByName` in-place patch, which is the entire point of this fix. Took the incoming (PR) side; `mergeSlotsByName`/`patchInputSlot`/`patchOutputSlot`/`copyInputSlot`/`copyOutputSlot` all merged in cleanly elsewhere in the file. - `nodeDataStore.test.ts`: an import conflict (`core/1.54` already has `createTestingPinia`/`setActivePinia`/`beforeEach` for existing tests; #18279 added `vi` for its new tests) was resolved by merging both import sets. A second conflict was a pure addition (`keeps live slot edits visible after a remote slot sync` test) with nothing on the `core/1.54` side to reconcile against, so it was taken as-is. `src/workbench/extensions/agent/crdt/graphMutations.ts` and its test file auto-merged cleanly with no conflicts. ## Is this a real conflict or a stacking conflict? Checked #18337, #18334, and #17872 (the other open PRs against `core/1.54` the backport bot flagged as possible stacking candidates): none of them touch `src/stores/nodeDataStore.ts` or `nodeDataStore.test.ts`. This is a real, direct conflict between #18279's rewrite of `updateNodeSlots` and `core/1.54`'s pre-existing simpler implementation, not a stacking conflict with any of those three PRs. ## Verification - `pnpm vitest run src/stores/nodeDataStore.test.ts` — 31 passed. - `pnpm vitest run src/workbench/extensions/agent/crdt/graphMutations.test.ts src/core/graph/widgets/dynamicWidgets.test.ts` — 71 passed, 1 expected failure (matches the original PR's reported results). - `pnpm typecheck` — passed. - `eslint` on the 4 changed files — passed. - Working tree matches the 4 files changed by #18279 exactly (`nodeDataStore.ts`, `nodeDataStore.test.ts`, `graphMutations.ts`, `graphMutations.test.ts`), no stray diffs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01PqHg3D8o2RbujF1t4dz4J6 --- _Generated by [Claude Code](https://claude.ai/code/session_01PqHg3D8o2RbujF1t4dz4J6)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com>
Requested by Christian Byrne · Slack thread
Summary
Source: #18062, merged as
ec5da77d0ff9a45d637bcfe128772ac8557e8a06. Target:core/1.54at6d2daca629b4e21155ae8270e0fce503da4ee482.Before: With the agent panel open, copying a node after text in the transcript had been selected pasted an older node or nothing: the canvas cancels the default pointerdown, so the transcript selection survived the click on the node and
shouldIgnoreCopyPaste()swallowed both the Ctrl+C and the Ctrl+V, leaving the next paste to fall back to the stalelocalStoragenode clipboard. Pasting into the composer (a contenteditable editor) could likewise drop a stale node onto the canvas.After: Clicking into the graph collapses a text selection made outside the clicked element, so the copy and paste that follow reach the graph. Copy respects text selection: with non-editable text selected, Ctrl+C copies the text and canvas copy/paste stays out of the way, and a later text copy clears the canvas clipboard slot when it still holds the node copy it superseded. Ownership is tracked by a per-copy id (
localStorage['litegrapheditor_clipboard_id']) stamped by everyLGraphCanvas.copyToClipboard(), souseCopyonly clears the slot while its own Ctrl+C copy is still current. Contenteditable editors count as text inputs, and selections inside a textarea or text/search input are detected throughselectionStart/selectionEnd.Changes
src/workbench/eventHelpers.ts:collapseTextSelectionOutside(),collapseOutsideSelectionOnPrimaryPointerDown(),hasTextSelection()(textarea/input selections, whitespace-only selections),shouldIgnoreCopyPaste()treats contenteditable as a text input.src/components/graph/GraphCanvas.vue: collapses an outside text selection on primary pointerdown into the graph.src/composables/useCopy.ts: remembers the id of its own Ctrl+C node copy and clears the canvas clipboard slot when a later text copy supersedes it.src/lib/litegraph/src/LGraphCanvas.ts:copyToClipboard()stamps a freshlitegrapheditor_clipboard_id.browser_tests/fixtures/components/Topbar.ts:getWorkflowTabLabel()helper.src/composables/useCopy.test.ts,src/workbench/eventHelpers.test.ts(new),src/lib/litegraph/src/LGraphCanvas.clipboard.test.ts,browser_tests/tests/canvas/copyPasteAfterTextSelection.spec.ts(new canvas regression spec).Backport adaptations
Dropped the hunks touching
browser_tests/fixtures/agentConversationFixture.tsand the agent replay specs (agentConversationReplay,agentHumanAddTabSwitch,agentHumanDeleteTabSwitch,agentLayoutQuality,agentNewChatClearedCanvas,agentPastedNodeOrphanedOnRetarget,agentTabSwitchCatchUp,agentTabSwitchRunSubmission,cmpDocumentAcceptance): none of these files exist oncore/1.54(modify/delete conflicts), so they stay absent.Dropped
browser_tests/fixtures/AgentCopyPasteDriver.tsandbrowser_tests/tests/agent/agentCopyPaste.spec.ts: they build onagentConversationTestfrom the recorded-conversation replay fixture, which has no equivalent on this branch (noagentConversationFixture, no recorded conversation data). The canvas regression speccopyPasteAfterTextSelection.spec.tsand the unit tests carry the coverage here.src/composables/useCopy.test.ts: content conflict resolved by taking the fix: copy/paste beside the agent panel #18062 version wholesale; its imports (fromPartial,useCanvasStore,eventHelpers) all resolve on the branch.src/lib/litegraph/src/LGraphCanvas.clipboard.test.ts: the auto-merge dropped the source commit's import hunk, socreateTestNode(@/lib/litegraph/src/__fixtures__/nodeHelpers) andcreateTestRootGraph(@/lib/litegraph/src/subgraph/__fixtures__/subgraphHelpers) were re-added; both helpers already exist on the branch.Review Focus
Straight cherry-pick of the source files; only e2e files tied to the absent agent replay harness were dropped. Unit tests and the canvas e2e spec remain.
🤖 Generated with Claude Code
https://claude.ai/code/session_01M9ZKkgcvdGt7LHjkvJUq63