Repository navigation
[Cloud 1.54] Apply run permission choice without save step - #18265
Conversation
Backport of 146ef34 to cloud/1.54.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1931 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-21T16:41:46.780Z",
"gitSha": "2a27061e317457902106b59c2d7ceca1dffb3564",
"branch": "backport-18115-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2066.295000000025,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.571,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.189,
"heapDeltaBytes": -6783584,
"heapUsedBytes": 62425588,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.621999999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2080.6949999999915,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.722000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.5719999999999,
"heapDeltaBytes": 9543944,
"heapUsedBytes": 79824708,
"domNodes": -281,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 10.554,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2135.4179999999587,
"styleRecalcs": 81,
"styleRecalcDurationMs": 39.161,
"layouts": 14,
"layoutDurationMs": 5.182,
"taskDurationMs": 1117.5049999999999,
"heapDeltaBytes": 5216096,
"heapUsedBytes": 75613696,
"domNodes": -278,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 215.10199999999998,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1868.803000000014,
"styleRecalcs": 77,
"styleRecalcDurationMs": 31.669999999999998,
"layouts": 14,
"layoutDurationMs": 4.638000000000001,
"taskDurationMs": 847.0280000000001,
"heapDeltaBytes": 24211720,
"heapUsedBytes": 88958404,
"domNodes": 39,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 163,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1657.2780000000193,
"styleRecalcs": 29,
"styleRecalcDurationMs": 15.963999999999999,
"layouts": 6,
"layoutDurationMs": 1.142,
"taskDurationMs": 374.129,
"heapDeltaBytes": 4327368,
"heapUsedBytes": 74135932,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.436999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.9280000000954,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.087,
"layouts": 6,
"layoutDurationMs": 1.0759999999999998,
"taskDurationMs": 375.5109999999999,
"heapDeltaBytes": 3861760,
"heapUsedBytes": 68298896,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.472999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 719.3230000000312,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.407,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.62499999999994,
"heapDeltaBytes": -7532932,
"heapUsedBytes": 63088488,
"domNodes": 16,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 164.56500000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 710.2319999999622,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.088,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.693,
"heapDeltaBytes": -7253768,
"heapUsedBytes": 63457152,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 161.89800000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2055.1509999999666,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.862,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 685.604,
"heapDeltaBytes": 8904676,
"heapUsedBytes": 84653800,
"domNodes": -273,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 39.66599999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2050.679000000059,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.189,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 637.767,
"heapDeltaBytes": 11322512,
"heapUsedBytes": 86587000,
"domNodes": -265,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 38.36500000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2225.2260000000206,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.888,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1633.1299999999999,
"heapDeltaBytes": 14639844,
"heapUsedBytes": 80895552,
"domNodes": -268,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 812.049,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2355.6460000000925,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.663999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1675.5410000000002,
"heapDeltaBytes": 22370580,
"heapUsedBytes": 88467992,
"domNodes": -277,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 835.652,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3772.266000000002,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.576999999999996,
"layouts": 60,
"layoutDurationMs": 12.826,
"taskDurationMs": 1802.6449999999998,
"heapDeltaBytes": 11758492,
"heapUsedBytes": 80147084,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 816.8559999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3791.7289999999184,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.256999999999998,
"layouts": 60,
"layoutDurationMs": 12.251000000000001,
"taskDurationMs": 1818.844,
"heapDeltaBytes": -2863820,
"heapUsedBytes": 76039464,
"domNodes": -283,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 822.554,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3203.1180000000177,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.345000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2130.291,
"heapDeltaBytes": 793772,
"heapUsedBytes": 80654796,
"domNodes": -289,
"jsHeapTotalBytes": 4505600,
"scriptDurationMs": 1041.579,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3268.957999999998,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.816999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2094.895,
"heapDeltaBytes": 8331456,
"heapUsedBytes": 88305736,
"domNodes": -251,
"jsHeapTotalBytes": 835584,
"scriptDurationMs": 1036.2050000000002,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2009.5469999999978,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.198000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.598,
"heapDeltaBytes": 21255468,
"heapUsedBytes": 87743920,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 40.768,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2071.6429999999946,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.7769999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.137,
"heapDeltaBytes": 4809432,
"heapUsedBytes": 82146472,
"domNodes": -284,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 39.66799999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 627.9880000000162,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.620999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.85200000000003,
"heapDeltaBytes": 14998864,
"heapUsedBytes": 88155708,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 143.705,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 639.9599999999737,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.36,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.618,
"heapDeltaBytes": 15121216,
"heapUsedBytes": 87750508,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 152.62499999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2023.698999999965,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.823,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.812,
"heapDeltaBytes": -7869848,
"heapUsedBytes": 64451224,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.291,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2033.6249999999723,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.398000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.528,
"heapDeltaBytes": -14942552,
"heapUsedBytes": 57669512,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.169,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1716.5259999999876,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.896,
"layouts": 18,
"layoutDurationMs": 4.907,
"taskDurationMs": 836.575,
"heapDeltaBytes": -6454396,
"heapUsedBytes": 66411000,
"domNodes": -293,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 113.028,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1749.099000000001,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.095,
"layouts": 18,
"layoutDurationMs": 4.811999999999999,
"taskDurationMs": 842.053,
"heapDeltaBytes": 7269856,
"heapUsedBytes": 80098804,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 114.05300000000001,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.3810000000149,
"styleRecalcs": 21,
"styleRecalcDurationMs": 33.735,
"layouts": 17,
"layoutDurationMs": 16.332,
"taskDurationMs": 977.1359999999997,
"heapDeltaBytes": 20064780,
"heapUsedBytes": 103414352,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 30.394,
"eventListeners": 2385,
"totalBlockingTimeMs": 147,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8923.503999999979,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.607,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6178.889,
"heapDeltaBytes": 15131036,
"heapUsedBytes": 90911196,
"domNodes": -271,
"jsHeapTotalBytes": 348160,
"scriptDurationMs": 2869.7490000000003,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8608.249,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.806,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6068.599000000001,
"heapDeltaBytes": -17384532,
"heapUsedBytes": 85508972,
"domNodes": -269,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 2795.569,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17510.913000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16831.564,
"heapDeltaBytes": -40663668,
"heapUsedBytes": 177856320,
"domNodes": -8068,
"jsHeapTotalBytes": -8130560,
"scriptDurationMs": 287.41,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17441.81400000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16873.859,
"heapDeltaBytes": -53593288,
"heapUsedBytes": 182773000,
"domNodes": -8068,
"jsHeapTotalBytes": -15904768,
"scriptDurationMs": 285.431,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21643.916999999987,
"styleRecalcs": 165,
"styleRecalcDurationMs": 20.519999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21357.807,
"heapDeltaBytes": -49107004,
"heapUsedBytes": 168658428,
"domNodes": -8068,
"jsHeapTotalBytes": -13139968,
"scriptDurationMs": 973.639,
"eventListeners": -14925,
"totalBlockingTimeMs": 41,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20984.46100000001,
"styleRecalcs": 162,
"styleRecalcDurationMs": 17.78000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20651.602,
"heapDeltaBytes": -43052604,
"heapUsedBytes": 178602644,
"domNodes": -8068,
"jsHeapTotalBytes": -13115392,
"scriptDurationMs": 912.165,
"eventListeners": -14929,
"totalBlockingTimeMs": 81,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6485.089000000016,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.258,
"layouts": 20,
"layoutDurationMs": 25.656,
"taskDurationMs": 6372.206,
"heapDeltaBytes": -56238036,
"heapUsedBytes": 182905288,
"domNodes": -8068,
"jsHeapTotalBytes": 12931072,
"scriptDurationMs": 117.07900000000001,
"eventListeners": -14933,
"totalBlockingTimeMs": 583,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6282.519999999977,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.12599999999998,
"layouts": 20,
"layoutDurationMs": 26.892,
"taskDurationMs": 6176.8009999999995,
"heapDeltaBytes": -62482636,
"heapUsedBytes": 176699076,
"domNodes": -8068,
"jsHeapTotalBytes": 4014080,
"scriptDurationMs": 111.84700000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 606,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8909.722999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8531.051,
"heapDeltaBytes": 18053760,
"heapUsedBytes": 186202956,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 143.99300000000005,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9079.191000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8606.756999999998,
"heapDeltaBytes": 7537688,
"heapUsedBytes": 178003384,
"domNodes": 0,
"jsHeapTotalBytes": -11272192,
"scriptDurationMs": 148.39599999999996,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 479.411999999968,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.541999999999994,
"layouts": 4,
"layoutDurationMs": 2.146,
"taskDurationMs": 126.62399999999998,
"heapDeltaBytes": 5073204,
"heapUsedBytes": 73368008,
"domNodes": 151,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.167,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 117.90800000005675,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.002,
"layouts": 2,
"layoutDurationMs": 0.701,
"taskDurationMs": 75.716,
"heapDeltaBytes": 3025780,
"heapUsedBytes": 72101892,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.802999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18265 +/- ##
=============================================
Coverage ? 83.56%
=============================================
Files ? 2094
Lines ? 123612
Branches ? 33124
=============================================
Hits ? 103299
Misses ? 20135
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: changes requested.
The production adaptation matches source PR #18115 at merged SHA 146ef34bc87e660772ba52ebfb16d6200aa1ae45, apart from the documented release-native styling. The backport drops the source's browser regression coverage, however, and the unit replacement cannot exercise Reka's real roving-focus behavior.
Pre-merge blockers:
- [P1] Carry the source browser cases for arrow navigation plus Enter apply and keyboard retry after a rejected write. The inline comment has the failure modes and target-branch harness evidence.
Findings without an anchorable line
- [P2] The PR body still says local checks were deferred. I ran exact-head local checks: the focused Composer suite passed 87/87, typecheck passed, targeted ESLint passed, and formatting passed. Fallow also ran and exited 1 on the two complexity candidates discussed below. Please update the verification section to report the current evidence rather than saying no local checks ran.
- [P3] Nit: The body attributes the earlier deferral to an owner-directed host resource restriction, but it does not link a policy or artifact that substantiates that explanation, and local checks have since completed. Please remove that explanation or link the restriction if it matters for provenance.
Existing findings confirmed or contested
No prior human or automated code-review findings were present.
Unverified candidates
None.
Checked and cleared
- Fallow reported
migrateLegacyPreferenceat complexity 12. I cleared it because that function is unchanged from the base; this PR only makesDEFAULT_CREDIT_LIMITprivate. - Fallow reported template complexity 11 in
RunModePopover.vue. I cleared it because the component shrinks from 223 to 189 lines and removes the draft, limit-validation, and save-button states. The remaining branches represent distinct selected, pending, and accessibility states carried from the source PR.
Coverage
Depth: standard. I reviewed all 18 changed files through correctness, maintainability, idiomaticity, tests, and documentation lanes. I compared the core behavior and tests with source PR #18115 at merged SHA 146ef34bc87e660772ba52ebfb16d6200aa1ae45. Focused local checks passed as listed above; the store race suite also passed 18/18. Exact-head hosted checks are green, with the risk check skipped. No changed path was left untraced.
| expect(fetchApi).toHaveBeenCalledTimes(2) | ||
| }) | ||
|
|
||
| it('commits the focused mode on Enter', async () => { |
There was a problem hiding this comment.
[P1] This unit test manually focuses the Auto item, so it cannot catch the browser behavior that motivated the source change. Source PR #18115 added Chromium cases that press ArrowDown and prove focus movement does not issue a PUT, then prove Enter commits, plus a rejected-write case that verifies focus survives aria-disabled and Enter retries. A regression that commits on ArrowDown or loses focus after failure still passes all 87 tests here. The reason in the PR body only says this spec file is absent on cloud/1.54, but the base already has the @cloud project, Agent fixtures, agentPanelMocks.ts, and neighboring Agent specs. Please carry the source browser cases, either in the same new path or an existing Agent spec, and run that focused cloud spec.
There was a problem hiding this comment.
Tracked as FE-2601. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
Backport adaptation: runtime. The line's run-mode menu is #18265, the cloud/1.54 carrier of #18115. It keeps the DropdownMenu and the store calls, but still styles them with the old agent tooltip helper, raw buttons and surface classes. Main's final file (146ef34, still the blob on origin/main) is the same DropdownMenu with the same behaviour, styled with the shared Button and design tokens. This takes main's file unchanged.
#18622) ## Summary Backports the Agent UI changes that staging and prod are missing to `cloud/1.54`, as one cherry-pick catalogue: the folded trace, the shared design system and buttons for the Agent controls, the consent card redesign, and the moved Agent button with the nested panel. Staging picks it up with the next `cloud/1.54` deploy; prod gets it at the next production promotion of `cloud/1.54`. Linear: [PM-1657](https://linear.app/comfyorg/issue/PM-1657/test-stagingprod-missing-the-tool-call-always-expose-thinking-then), [PM-1656](https://linear.app/comfyorg/issue/PM-1656) ## Changes - **What**: `cherry-pick -x` of 8 merged `main` PRs, in `main` merge order: - #17339 fold the finished trace into one summary - #17908 consent card video and stacked card layout - #17420 animate a step as it arrives (follow-up to #17339) - #18348 remove the workflow timing display (follow-up to #17339) - #18043 make the agent button legible in the light theme - #17621 agent button at the far right, nested panel, without its two `src/lib/litegraph/` files (see Review Focus) - #17471 replace the Agent shadow theme with the shared design system - #17690 use shared buttons across Agent controls - **Already on `cloud/1.54`** from the same request, so not repeated here: #17439 (via #18162), #17912 (via #18185), #17730 (via #18550). - **Breaking**: none. - **Dependencies**: none. `package.json` and the lockfile are unchanged apart from the merged 1.54.15 bump (#18569). ## Review Focus - #17621 changes shared chrome outside the Agent panel (top bar, workflow tabs, side toolbar, breadcrumb, canvas splitter, LinearView), so every user sees the new layout. #17471 changes the shared tooltip. - #17621's two `src/lib/litegraph/` files are held out (agent fixes keep litegraph unchanged); a 5 px HUD offset in `SideToolbar.vue` compensates. Carrying them instead is a one-file follow-up if preferred. - #18351 and #18367 are superseded by main's trace renderer, which this brings in. - Hosted checks are green on the head: 86 passed, 0 failed. Per-source resolutions and the full verification log are in the details below. <details><summary>Resolution and verification, per source</summary> ### Resolution - `b5401705d8` drops a duplicate `useI18n` declaration left by the #17339 pick. - The merge of the `cloud/1.54` tip keeps main's `AgentMessage.vue` and its test, which supersede #18351 and #18367: the working spinner after tools is #17339's composing row, covered by `AgentMessage.test.ts` "marks the turn as still working between the last tool and the first reply token", and the thinking text uses the trace's `text-sm/5`. - #17621: 8 release-line browser files switch from `askComfyAgent` to `entryButton`, since #17621 removes that label; its GraphCanvas dock tests set linear mode after mount on this line's test setup. - `101c8f19cd` (test-only): three agent browser tests move off the removed "Ran N tool calls" button to main's WorkSummary locators. - `09236f342d` (test-only): `exact: true` on the autogrow spec's two entry-button lookups, as on main, since "Agent" now also prefixes the targeted workflow tab's button name. - `d49b4ddf12` (runtime): `SideToolbar.vue` places the canvas info HUD at `sidebarRight + canvasGutter() - 5`. The release line's `renderInfo` keeps a 5 px text inset that main removed in #17621's litegraph half, so this offset lands the HUD where main puts it. It goes away when that litegraph change reaches the line. - #17471: 12 conflicts resolved toward main. `ab65e60731` (runtime) takes main's final `RunModePopover.vue` as is: main's end state is the DropdownMenu form from #18115, which this line carries via #18265, and the remaining diff was styling only. `55e005ed10` (runtime) maps the last 2 shadow-theme tokens in `CrdtDevPanel`. 38 of 42 files carry the source's exact change stream. - #17690: 1 conflict resolved toward main; 17 of 18 files carry the source's exact change stream. - The `cloud/1.54` tip was merged in twice; the second merge brings the 1.54.15 bump (#18569) with no other change. ### Verification - Hosted checks on the head: 86 passed, 0 failed (e2e run 35907168615: 16 chromium shards, cloud, 0.5x, 2x, mobile-chrome, mobile-safari, video). - `git diff --name-only origin/cloud/1.54...HEAD -- ':/src/lib/litegraph/'` prints nothing. - Local at the head: `pnpm typecheck` and `pnpm typecheck:browser` exit 0; 41 unit suites, 563 tests pass; 0 shadow-theme tokens and 0 `AgentTooltip` references remain. - #17908: `agentConsent.spec.ts` passes 14 of 14 with the change and fails 5 of 14 without it (local run, devtools setup endpoints stubbed). - Per-source parity: every difference from the source change streams is listed under Resolution. - Staging acceptance after landing: the trace fold, the design system and buttons in light and dark, the nested panel and moved button, the consent card, plus the onboarding tour, consent without a click and the graph activity bar as regressions. Prod needs a production promotion of `cloud/1.54` after that. </details> ## Screenshots (if applicable) Visual changes are the ones already reviewed on `main` in #17471, #17690, #17621 and #17908; the e2e screenshot baselines in this PR come from those merges. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: ryan-di <ryan.weihao.di@gmail.com> Co-authored-by: jaeone lee <89377375+jaeone94@users.noreply.github.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
Summary
Full context for agent readers
Changes
146ef34bc87e660772ba52ebfb16d6200aa1ae45ontocloud/1.54.browser_tests/tests/agent/agentRunModePopover.spec.tsdoes not exist on this release target.Review focus
Please verify the target-native styling adaptation and the immediate-save failure/retry behavior.
Provenance