Skip to content

[Cloud 1.54] Apply run permission choice without save step - #18265

Merged
christian-byrne merged 3 commits into
cloud/1.54from
backport-18115-to-cloud-1.54
Sep 21, 2026
Merged

christian-byrne merged 3 commits into
cloud/1.54from
backport-18115-to-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Full context for agent readers

Changes

  • What: Backports 146ef34bc87e660772ba52ebfb16d6200aa1ae45 onto cloud/1.54.
  • Adaptation: Keeps the target branch's Agent tooltip helper, colors, surfaces, and raw trigger/option controls while applying the source interaction and accessibility behavior.
  • Test scope: Carries the target-native Composer unit coverage. The source browser spec is not included because browser_tests/tests/agent/agentRunModePopover.spec.ts does not exist on this release target.

Review focus

Please verify the target-native styling adaptation and the immediate-save failure/retry behavior.

Provenance

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 71e4eb78-8988-4761-a85e-c50b4d43333c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 21, 2026 4:30pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/21/2026, 04:32:34 PM UTC

Links

🎭 Playwright: ✅ 1931 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1910 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 147ms TBT · 98.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.1 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.0 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 61ms TBT · 165.6 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 595ms TBT · 171.5 MB heap
vue-zoom-out-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 527ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.8 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -180
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 35ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 982ms
canvas-mouse-sweep: script duration 189ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 78.5 MB
canvas-mouse-sweep: DOM nodes -120
canvas-mouse-sweep: event listeners -81
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 375ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 67.9 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 466ms
dom-widget-clipping: script duration 163ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 60.3 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 662ms
large-graph-idle: script duration 39ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 81.7 MB
large-graph-idle: DOM nodes -269
large-graph-idle: event listeners -177
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1654ms
large-graph-pan: script duration 824ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 80.8 MB
large-graph-pan: DOM nodes -273
large-graph-pan: event listeners -78
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1811ms
large-graph-zoom: script duration 820ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.5 MB
large-graph-zoom: DOM nodes -142
large-graph-zoom: event listeners -89
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 2113ms
legacy-node-drag: script duration 1039ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 80.6 MB
legacy-node-drag: DOM nodes -270
legacy-node-drag: event listeners -104
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 621ms
minimap-idle: script duration 40ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.0 MB
minimap-idle: DOM nodes -141
minimap-idle: event listeners -94
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 431ms
subgraph-dom-widget-clipping: script duration 148ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.9 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 525ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 58.2 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 28ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 839ms
subgraph-mouse-sweep: script duration 114ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 69.9 MB
subgraph-mouse-sweep: DOM nodes -294
subgraph-mouse-sweep: event listeners -227
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 17
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 977ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 147ms
subgraph-transition-enter: heap used 98.6 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 6124ms
viewport-pan-sweep: script duration 2833ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 84.1 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -146
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16853ms
vue-large-graph-idle: script duration 286ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 172.0 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 164
vue-large-graph-pan: task duration 21005ms
vue-large-graph-pan: script duration 943ms
vue-large-graph-pan: TBT 61ms
vue-large-graph-pan: heap used 165.6 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14927
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 26ms
vue-node-resize-workload: style recalc duration 83ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6275ms
vue-node-resize-workload: script duration 114ms
vue-node-resize-workload: TBT 595ms
vue-node-resize-workload: heap used 171.5 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14931
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8569ms
vue-zoom-out-idle: script duration 146ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 173.7 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -13
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 20ms
workflow-execution: layout count 3
workflow-execution: style recalc count 14
workflow-execution: task duration 101ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.4 MB
workflow-execution: DOM nodes 130
workflow-execution: event listeners 49
Raw data
{
  "timestamp": "2026-09-21T16:41:46.780Z",
  "gitSha": "2a27061e317457902106b59c2d7ceca1dffb3564",
  "branch": "backport-18115-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2066.295000000025,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.571,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 515.189,
      "heapDeltaBytes": -6783584,
      "heapUsedBytes": 62425588,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.621999999999998,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2080.6949999999915,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.722000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 538.5719999999999,
      "heapDeltaBytes": 9543944,
      "heapUsedBytes": 79824708,
      "domNodes": -281,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 10.554,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2135.4179999999587,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 39.161,
      "layouts": 14,
      "layoutDurationMs": 5.182,
      "taskDurationMs": 1117.5049999999999,
      "heapDeltaBytes": 5216096,
      "heapUsedBytes": 75613696,
      "domNodes": -278,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 215.10199999999998,
      "eventListeners": -168,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1868.803000000014,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 31.669999999999998,
      "layouts": 14,
      "layoutDurationMs": 4.638000000000001,
      "taskDurationMs": 847.0280000000001,
      "heapDeltaBytes": 24211720,
      "heapUsedBytes": 88958404,
      "domNodes": 39,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 163,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1657.2780000000193,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 15.963999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.142,
      "taskDurationMs": 374.129,
      "heapDeltaBytes": 4327368,
      "heapUsedBytes": 74135932,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 12.436999999999996,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1719.9280000000954,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 19.087,
      "layouts": 6,
      "layoutDurationMs": 1.0759999999999998,
      "taskDurationMs": 375.5109999999999,
      "heapDeltaBytes": 3861760,
      "heapUsedBytes": 68298896,
      "domNodes": 77,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 12.472999999999997,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 719.3230000000312,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.407,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 464.62499999999994,
      "heapDeltaBytes": -7532932,
      "heapUsedBytes": 63088488,
      "domNodes": 16,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 164.56500000000003,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 710.2319999999622,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.088,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 467.693,
      "heapDeltaBytes": -7253768,
      "heapUsedBytes": 63457152,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 161.89800000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.1509999999666,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.862,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 685.604,
      "heapDeltaBytes": 8904676,
      "heapUsedBytes": 84653800,
      "domNodes": -273,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 39.66599999999999,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2050.679000000059,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.189,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 637.767,
      "heapDeltaBytes": 11322512,
      "heapUsedBytes": 86587000,
      "domNodes": -265,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 38.36500000000001,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2225.2260000000206,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.888,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1633.1299999999999,
      "heapDeltaBytes": 14639844,
      "heapUsedBytes": 80895552,
      "domNodes": -268,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 812.049,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2355.6460000000925,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 8.663999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1675.5410000000002,
      "heapDeltaBytes": 22370580,
      "heapUsedBytes": 88467992,
      "domNodes": -277,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 835.652,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3772.266000000002,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.576999999999996,
      "layouts": 60,
      "layoutDurationMs": 12.826,
      "taskDurationMs": 1802.6449999999998,
      "heapDeltaBytes": 11758492,
      "heapUsedBytes": 80147084,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 816.8559999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3791.7289999999184,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.256999999999998,
      "layouts": 60,
      "layoutDurationMs": 12.251000000000001,
      "taskDurationMs": 1818.844,
      "heapDeltaBytes": -2863820,
      "heapUsedBytes": 76039464,
      "domNodes": -283,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 822.554,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3203.1180000000177,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 7.345000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2130.291,
      "heapDeltaBytes": 793772,
      "heapUsedBytes": 80654796,
      "domNodes": -289,
      "jsHeapTotalBytes": 4505600,
      "scriptDurationMs": 1041.579,
      "eventListeners": -197,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3268.957999999998,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 8.816999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2094.895,
      "heapDeltaBytes": 8331456,
      "heapUsedBytes": 88305736,
      "domNodes": -251,
      "jsHeapTotalBytes": 835584,
      "scriptDurationMs": 1036.2050000000002,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "minimap-idle",
      "durationMs": 2009.5469999999978,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 1.198000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 567.598,
      "heapDeltaBytes": 21255468,
      "heapUsedBytes": 87743920,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 40.768,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2071.6429999999946,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.7769999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 674.137,
      "heapDeltaBytes": 4809432,
      "heapUsedBytes": 82146472,
      "domNodes": -284,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 39.66799999999999,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 627.9880000000162,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.620999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 430.85200000000003,
      "heapDeltaBytes": 14998864,
      "heapUsedBytes": 88155708,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 143.705,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 639.9599999999737,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.36,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 431.618,
      "heapDeltaBytes": 15121216,
      "heapUsedBytes": 87750508,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 152.62499999999997,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2023.698999999965,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.823,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 520.812,
      "heapDeltaBytes": -7869848,
      "heapUsedBytes": 64451224,
      "domNodes": -296,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.291,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2033.6249999999723,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.398000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 529.528,
      "heapDeltaBytes": -14942552,
      "heapUsedBytes": 57669512,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 10.169,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1716.5259999999876,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 27.896,
      "layouts": 18,
      "layoutDurationMs": 4.907,
      "taskDurationMs": 836.575,
      "heapDeltaBytes": -6454396,
      "heapUsedBytes": 66411000,
      "domNodes": -293,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 113.028,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1749.099000000001,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 28.095,
      "layouts": 18,
      "layoutDurationMs": 4.811999999999999,
      "taskDurationMs": 842.053,
      "heapDeltaBytes": 7269856,
      "heapUsedBytes": 80098804,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 114.05300000000001,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.3810000000149,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 33.735,
      "layouts": 17,
      "layoutDurationMs": 16.332,
      "taskDurationMs": 977.1359999999997,
      "heapDeltaBytes": 20064780,
      "heapUsedBytes": 103414352,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 30.394,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 147,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8923.503999999979,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 37.607,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6178.889,
      "heapDeltaBytes": 15131036,
      "heapUsedBytes": 90911196,
      "domNodes": -271,
      "jsHeapTotalBytes": 348160,
      "scriptDurationMs": 2869.7490000000003,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8608.249,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 35.806,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6068.599000000001,
      "heapDeltaBytes": -17384532,
      "heapUsedBytes": 85508972,
      "domNodes": -269,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 2795.569,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17510.913000000015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16831.564,
      "heapDeltaBytes": -40663668,
      "heapUsedBytes": 177856320,
      "domNodes": -8068,
      "jsHeapTotalBytes": -8130560,
      "scriptDurationMs": 287.41,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17441.81400000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16873.859,
      "heapDeltaBytes": -53593288,
      "heapUsedBytes": 182773000,
      "domNodes": -8068,
      "jsHeapTotalBytes": -15904768,
      "scriptDurationMs": 285.431,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21643.916999999987,
      "styleRecalcs": 165,
      "styleRecalcDurationMs": 20.519999999999982,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21357.807,
      "heapDeltaBytes": -49107004,
      "heapUsedBytes": 168658428,
      "domNodes": -8068,
      "jsHeapTotalBytes": -13139968,
      "scriptDurationMs": 973.639,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 41,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20984.46100000001,
      "styleRecalcs": 162,
      "styleRecalcDurationMs": 17.78000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20651.602,
      "heapDeltaBytes": -43052604,
      "heapUsedBytes": 178602644,
      "domNodes": -8068,
      "jsHeapTotalBytes": -13115392,
      "scriptDurationMs": 912.165,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 81,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6485.089000000016,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 84.258,
      "layouts": 20,
      "layoutDurationMs": 25.656,
      "taskDurationMs": 6372.206,
      "heapDeltaBytes": -56238036,
      "heapUsedBytes": 182905288,
      "domNodes": -8068,
      "jsHeapTotalBytes": 12931072,
      "scriptDurationMs": 117.07900000000001,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 583,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6282.519999999977,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 82.12599999999998,
      "layouts": 20,
      "layoutDurationMs": 26.892,
      "taskDurationMs": 6176.8009999999995,
      "heapDeltaBytes": -62482636,
      "heapUsedBytes": 176699076,
      "domNodes": -8068,
      "jsHeapTotalBytes": 4014080,
      "scriptDurationMs": 111.84700000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 606,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8909.722999999985,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8531.051,
      "heapDeltaBytes": 18053760,
      "heapUsedBytes": 186202956,
      "domNodes": 0,
      "jsHeapTotalBytes": -14417920,
      "scriptDurationMs": 143.99300000000005,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9079.191000000037,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8606.756999999998,
      "heapDeltaBytes": 7537688,
      "heapUsedBytes": 178003384,
      "domNodes": 0,
      "jsHeapTotalBytes": -11272192,
      "scriptDurationMs": 148.39599999999996,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 479.411999999968,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 25.541999999999994,
      "layouts": 4,
      "layoutDurationMs": 2.146,
      "taskDurationMs": 126.62399999999998,
      "heapDeltaBytes": 5073204,
      "heapUsedBytes": 73368008,
      "domNodes": 151,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 14.167,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 117.90800000005675,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 14.002,
      "layouts": 2,
      "layoutDurationMs": 0.701,
      "taskDurationMs": 75.716,
      "heapDeltaBytes": 3025780,
      "heapUsedBytes": 72101892,
      "domNodes": 108,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.802999999999998,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 50270 75334 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1159
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.3% 264
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.6% 257
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 21, 2026
@codecov

codecov Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18265   +/-   ##
=============================================
  Coverage              ?   83.56%           
=============================================
  Files                 ?     2094           
  Lines                 ?   123612           
  Branches              ?    33124           
=============================================
  Hits                  ?   103299           
  Misses                ?    20135           
  Partials              ?      178           
Flag Coverage Δ
e2e 66.73% <ø> (?)
unit 78.50% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...agent/components/agent/composer/RunModePopover.vue 100.00% <100.00%> (ø)
...extensions/agent/stores/agent/agentRunModeStore.ts 96.96% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: changes requested.

The production adaptation matches source PR #18115 at merged SHA 146ef34bc87e660772ba52ebfb16d6200aa1ae45, apart from the documented release-native styling. The backport drops the source's browser regression coverage, however, and the unit replacement cannot exercise Reka's real roving-focus behavior.

Pre-merge blockers:

  • [P1] Carry the source browser cases for arrow navigation plus Enter apply and keyboard retry after a rejected write. The inline comment has the failure modes and target-branch harness evidence.
Findings without an anchorable line
  • [P2] The PR body still says local checks were deferred. I ran exact-head local checks: the focused Composer suite passed 87/87, typecheck passed, targeted ESLint passed, and formatting passed. Fallow also ran and exited 1 on the two complexity candidates discussed below. Please update the verification section to report the current evidence rather than saying no local checks ran.
  • [P3] Nit: The body attributes the earlier deferral to an owner-directed host resource restriction, but it does not link a policy or artifact that substantiates that explanation, and local checks have since completed. Please remove that explanation or link the restriction if it matters for provenance.
Existing findings confirmed or contested

No prior human or automated code-review findings were present.

Unverified candidates

None.

Checked and cleared
  • Fallow reported migrateLegacyPreference at complexity 12. I cleared it because that function is unchanged from the base; this PR only makes DEFAULT_CREDIT_LIMIT private.
  • Fallow reported template complexity 11 in RunModePopover.vue. I cleared it because the component shrinks from 223 to 189 lines and removes the draft, limit-validation, and save-button states. The remaining branches represent distinct selected, pending, and accessibility states carried from the source PR.
Coverage

Depth: standard. I reviewed all 18 changed files through correctness, maintainability, idiomaticity, tests, and documentation lanes. I compared the core behavior and tests with source PR #18115 at merged SHA 146ef34bc87e660772ba52ebfb16d6200aa1ae45. Focused local checks passed as listed above; the store race suite also passed 18/18. Exact-head hosted checks are green, with the risk check skipped. No changed path was left untraced.

expect(fetchApi).toHaveBeenCalledTimes(2)
})

it('commits the focused mode on Enter', async () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] This unit test manually focuses the Auto item, so it cannot catch the browser behavior that motivated the source change. Source PR #18115 added Chromium cases that press ArrowDown and prove focus movement does not issue a PUT, then prove Enter commits, plus a rejected-write case that verifies focus survives aria-disabled and Enter retries. A regression that commits on ArrowDown or loses focus after failure still passes all 87 tests here. The reason in the PR body only says this spec file is absent on cloud/1.54, but the base already has the @cloud project, Agent fixtures, agentPanelMocks.ts, and neighboring Agent specs. Please carry the source browser cases, either in the same new path or an existing Agent spec, and run that focused cloud spec.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracked as FE-2601. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.

@christian-byrne christian-byrne removed their assignment Sep 21, 2026
@christian-byrne
christian-byrne merged commit 5d0ecc3 into cloud/1.54 Sep 21, 2026
93 checks passed
@christian-byrne
christian-byrne deleted the backport-18115-to-cloud-1.54 branch September 21, 2026 19:29
CodeJuggernaut added a commit that referenced this pull request Sep 23, 2026
Backport adaptation: runtime.

The line's run-mode menu is #18265, the cloud/1.54 carrier of #18115.
It keeps the DropdownMenu and the store calls, but still styles them
with the old agent tooltip helper, raw buttons and surface classes.

Main's final file (146ef34, still the blob on origin/main) is the
same DropdownMenu with the same behaviour, styled with the shared
Button and design tokens. This takes main's file unchanged.
comfy-pr-bot pushed a commit that referenced this pull request Sep 23, 2026
#18622)

## Summary

Backports the Agent UI changes that staging and prod are missing to
`cloud/1.54`, as one cherry-pick catalogue: the folded trace, the shared
design system and buttons for the Agent controls, the consent card
redesign, and the moved Agent button with the nested panel. Staging
picks it up with the next `cloud/1.54` deploy; prod gets it at the next
production promotion of `cloud/1.54`.

Linear:
[PM-1657](https://linear.app/comfyorg/issue/PM-1657/test-stagingprod-missing-the-tool-call-always-expose-thinking-then),
[PM-1656](https://linear.app/comfyorg/issue/PM-1656)

## Changes

- **What**: `cherry-pick -x` of 8 merged `main` PRs, in `main` merge
order:
  - #17339 fold the finished trace into one summary
  - #17908 consent card video and stacked card layout
  - #17420 animate a step as it arrives (follow-up to #17339)
  - #18348 remove the workflow timing display (follow-up to #17339)
  - #18043 make the agent button legible in the light theme
- #17621 agent button at the far right, nested panel, without its two
`src/lib/litegraph/` files (see Review Focus)
  - #17471 replace the Agent shadow theme with the shared design system
  - #17690 use shared buttons across Agent controls
- **Already on `cloud/1.54`** from the same request, so not repeated
here: #17439 (via #18162), #17912 (via #18185), #17730 (via #18550).
- **Breaking**: none.
- **Dependencies**: none. `package.json` and the lockfile are unchanged
apart from the merged 1.54.15 bump (#18569).

## Review Focus

- #17621 changes shared chrome outside the Agent panel (top bar,
workflow tabs, side toolbar, breadcrumb, canvas splitter, LinearView),
so every user sees the new layout. #17471 changes the shared tooltip.
- #17621's two `src/lib/litegraph/` files are held out (agent fixes keep
litegraph unchanged); a 5 px HUD offset in `SideToolbar.vue`
compensates. Carrying them instead is a one-file follow-up if preferred.
- #18351 and #18367 are superseded by main's trace renderer, which this
brings in.
- Hosted checks are green on the head: 86 passed, 0 failed. Per-source
resolutions and the full verification log are in the details below.

<details><summary>Resolution and verification, per source</summary>

### Resolution

- `b5401705d8` drops a duplicate `useI18n` declaration left by the
#17339 pick.
- The merge of the `cloud/1.54` tip keeps main's `AgentMessage.vue` and
its test, which supersede #18351 and #18367: the working spinner after
tools is #17339's composing row, covered by `AgentMessage.test.ts`
"marks the turn as still working between the last tool and the first
reply token", and the thinking text uses the trace's `text-sm/5`.
- #17621: 8 release-line browser files switch from `askComfyAgent` to
`entryButton`, since #17621 removes that label; its GraphCanvas dock
tests set linear mode after mount on this line's test setup.
- `101c8f19cd` (test-only): three agent browser tests move off the
removed "Ran N tool calls" button to main's WorkSummary locators.
- `09236f342d` (test-only): `exact: true` on the autogrow spec's two
entry-button lookups, as on main, since "Agent" now also prefixes the
targeted workflow tab's button name.
- `d49b4ddf12` (runtime): `SideToolbar.vue` places the canvas info HUD
at `sidebarRight + canvasGutter() - 5`. The release line's `renderInfo`
keeps a 5 px text inset that main removed in #17621's litegraph half, so
this offset lands the HUD where main puts it. It goes away when that
litegraph change reaches the line.
- #17471: 12 conflicts resolved toward main. `ab65e60731` (runtime)
takes main's final `RunModePopover.vue` as is: main's end state is the
DropdownMenu form from #18115, which this line carries via #18265, and
the remaining diff was styling only. `55e005ed10` (runtime) maps the
last 2 shadow-theme tokens in `CrdtDevPanel`. 38 of 42 files carry the
source's exact change stream.
- #17690: 1 conflict resolved toward main; 17 of 18 files carry the
source's exact change stream.
- The `cloud/1.54` tip was merged in twice; the second merge brings the
1.54.15 bump (#18569) with no other change.

### Verification

- Hosted checks on the head: 86 passed, 0 failed (e2e run 35907168615:
16 chromium shards, cloud, 0.5x, 2x, mobile-chrome, mobile-safari,
video).
- `git diff --name-only origin/cloud/1.54...HEAD --
':/src/lib/litegraph/'` prints nothing.
- Local at the head: `pnpm typecheck` and `pnpm typecheck:browser` exit
0; 41 unit suites, 563 tests pass; 0 shadow-theme tokens and 0
`AgentTooltip` references remain.
- #17908: `agentConsent.spec.ts` passes 14 of 14 with the change and
fails 5 of 14 without it (local run, devtools setup endpoints stubbed).
- Per-source parity: every difference from the source change streams is
listed under Resolution.
- Staging acceptance after landing: the trace fold, the design system
and buttons in light and dark, the nested panel and moved button, the
consent card, plus the onboarding tour, consent without a click and the
graph activity bar as regressions. Prod needs a production promotion of
`cloud/1.54` after that.

</details>

## Screenshots (if applicable)

Visual changes are the ones already reviewed on `main` in #17471,
#17690, #17621 and #17908; the e2e screenshot baselines in this PR come
from those merges.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: uytieu <uytieu@users.noreply.github.com>
Co-authored-by: ryan-di <ryan.weihao.di@gmail.com>
Co-authored-by: jaeone lee <89377375+jaeone94@users.noreply.github.com>
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants