Repository navigation
fix: preserve workflow document binding identity (cloud/1.54) - #18219
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1932 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-20T19:19:12.817Z",
"gitSha": "059611278a1bdab1228195956a75028e4e0a5e7a",
"branch": "christian/binding-cloud154",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.8449999999807,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.262,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.619,
"heapDeltaBytes": -7966416,
"heapUsedBytes": 61885576,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.540999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.7379999999666,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.194000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.537,
"heapDeltaBytes": -3346012,
"heapUsedBytes": 67345480,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.975000000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2081.976999999995,
"styleRecalcs": 80,
"styleRecalcDurationMs": 40.912000000000006,
"layouts": 14,
"layoutDurationMs": 4.824,
"taskDurationMs": 1061.479,
"heapDeltaBytes": -4420536,
"heapUsedBytes": 65581448,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 190.098,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1836.2549999999374,
"styleRecalcs": 74,
"styleRecalcDurationMs": 29.790999999999997,
"layouts": 14,
"layoutDurationMs": 4.304,
"taskDurationMs": 891.6070000000001,
"heapDeltaBytes": -3061544,
"heapUsedBytes": 66814256,
"domNodes": -284,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 162.39000000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.6510000000044,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.553,
"layouts": 6,
"layoutDurationMs": 1.3579999999999999,
"taskDurationMs": 377.342,
"heapDeltaBytes": 4642948,
"heapUsedBytes": 75355448,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 12.756999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1685.8579999999392,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.634999999999998,
"layouts": 6,
"layoutDurationMs": 1.045,
"taskDurationMs": 364.17100000000005,
"heapDeltaBytes": 4610864,
"heapUsedBytes": 75247384,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.928,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 718.6790000000087,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.337,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.815,
"heapDeltaBytes": 18387584,
"heapUsedBytes": 88677448,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 169.57,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 641.4509999999609,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.864999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.67999999999995,
"heapDeltaBytes": 18714588,
"heapUsedBytes": 87942060,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 159.341,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2058.3500000000186,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.4129999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 670.4290000000001,
"heapDeltaBytes": 4164168,
"heapUsedBytes": 79731192,
"domNodes": -282,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 35.972,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2021.6630000001032,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.8039999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.0889999999999,
"heapDeltaBytes": 21885576,
"heapUsedBytes": 87757708,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.025000000000006,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2405.9259999999654,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.276,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1694.0500000000002,
"heapDeltaBytes": 26702096,
"heapUsedBytes": 92804684,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 836.776,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2343.829000000028,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.389000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1724.871,
"heapDeltaBytes": -8874952,
"heapUsedBytes": 68504908,
"domNodes": -284,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 836.322,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3827.362999999991,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.521999999999998,
"layouts": 60,
"layoutDurationMs": 12.589999999999998,
"taskDurationMs": 1807.028,
"heapDeltaBytes": 15521732,
"heapUsedBytes": 94175892,
"domNodes": 8,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 828.4599999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3553.425000000061,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.536,
"layouts": 60,
"layoutDurationMs": 11.853,
"taskDurationMs": 1699.1660000000002,
"heapDeltaBytes": 12064140,
"heapUsedBytes": 80149300,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 772.799,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3144.0939999999955,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.6359999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1982.0469999999996,
"heapDeltaBytes": 12017440,
"heapUsedBytes": 92778408,
"domNodes": -285,
"jsHeapTotalBytes": -737280,
"scriptDurationMs": 960.3760000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3116.4159999999583,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.751000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1933.916,
"heapDeltaBytes": 21938824,
"heapUsedBytes": 89407220,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 963.625,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.711999999994,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.919999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 599.6949999999999,
"heapDeltaBytes": 10794580,
"heapUsedBytes": 88035452,
"domNodes": -274,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 34.20100000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2072.541000000001,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.255,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 662.198,
"heapDeltaBytes": 6945204,
"heapUsedBytes": 83696228,
"domNodes": -279,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 41.501999999999995,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.296000000043,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.132,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.43699999999995,
"heapDeltaBytes": 14937036,
"heapUsedBytes": 87904228,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 145.405,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.6269999999513,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.239999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.79600000000005,
"heapDeltaBytes": 13864516,
"heapUsedBytes": 86210156,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 144.35,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2014.6499999999605,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.279,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.78000000000003,
"heapDeltaBytes": -13381160,
"heapUsedBytes": 59599492,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 9.633,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2016.9550000000527,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.923000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.85200000000003,
"heapDeltaBytes": 8705828,
"heapUsedBytes": 81702608,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.302999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.6040000000426,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.598000000000003,
"layouts": 18,
"layoutDurationMs": 5.189,
"taskDurationMs": 855.7880000000001,
"heapDeltaBytes": -5329712,
"heapUsedBytes": 67794204,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 119.05399999999999,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.1900000000824,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.145999999999997,
"layouts": 18,
"layoutDurationMs": 5.248,
"taskDurationMs": 828.767,
"heapDeltaBytes": -6312508,
"heapUsedBytes": 66557556,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 111.072,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1403.3759999999802,
"styleRecalcs": 19,
"styleRecalcDurationMs": 33.36500000000001,
"layouts": 15,
"layoutDurationMs": 16.351999999999997,
"taskDurationMs": 987.9159999999998,
"heapDeltaBytes": 20095264,
"heapUsedBytes": 104083400,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 33.04599999999999,
"eventListeners": 2387,
"totalBlockingTimeMs": 153,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8950.418000000012,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.574,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6158.784000000001,
"heapDeltaBytes": 9061852,
"heapUsedBytes": 85284756,
"domNodes": -272,
"jsHeapTotalBytes": -1486848,
"scriptDurationMs": 2831.725,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8589.470000000005,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.395999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5895.644,
"heapDeltaBytes": 6800300,
"heapUsedBytes": 82372712,
"domNodes": -245,
"jsHeapTotalBytes": 643072,
"scriptDurationMs": 2755.3320000000003,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17723.43999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16948.194,
"heapDeltaBytes": -57502496,
"heapUsedBytes": 179579672,
"domNodes": -8068,
"jsHeapTotalBytes": -16166912,
"scriptDurationMs": 289.08,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17074.758999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16585.332000000002,
"heapDeltaBytes": -57509368,
"heapUsedBytes": 179127444,
"domNodes": -8076,
"jsHeapTotalBytes": -16953344,
"scriptDurationMs": 266.883,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21134.500000000004,
"styleRecalcs": 166,
"styleRecalcDurationMs": 19.363999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20836.737,
"heapDeltaBytes": -40598948,
"heapUsedBytes": 171839988,
"domNodes": -8097,
"jsHeapTotalBytes": -11657216,
"scriptDurationMs": 934.033,
"eventListeners": -14927,
"totalBlockingTimeMs": 118,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21070.114999999987,
"styleRecalcs": 160,
"styleRecalcDurationMs": 19.43499999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20780.411,
"heapDeltaBytes": -35353044,
"heapUsedBytes": 182446624,
"domNodes": -8068,
"jsHeapTotalBytes": -13164544,
"scriptDurationMs": 951.4520000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 94,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6373.428999999987,
"styleRecalcs": 20,
"styleRecalcDurationMs": 97.30099999999997,
"layouts": 20,
"layoutDurationMs": 30.96299999999999,
"taskDurationMs": 6249.342000000001,
"heapDeltaBytes": -53070772,
"heapUsedBytes": 178261460,
"domNodes": -8068,
"jsHeapTotalBytes": 5328896,
"scriptDurationMs": 159.8,
"eventListeners": -14929,
"totalBlockingTimeMs": 550,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6280.093000000079,
"styleRecalcs": 20,
"styleRecalcDurationMs": 90.31899999999999,
"layouts": 20,
"layoutDurationMs": 24.135999999999992,
"taskDurationMs": 6175.862999999999,
"heapDeltaBytes": -55471788,
"heapUsedBytes": 183559032,
"domNodes": -8068,
"jsHeapTotalBytes": 11620352,
"scriptDurationMs": 115.432,
"eventListeners": -14929,
"totalBlockingTimeMs": 511,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9033.186999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8717.453000000001,
"heapDeltaBytes": 9239384,
"heapUsedBytes": 178338136,
"domNodes": 0,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 151.281,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8861.232999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8569.997,
"heapDeltaBytes": 19959528,
"heapUsedBytes": 181471816,
"domNodes": 0,
"jsHeapTotalBytes": -11272192,
"scriptDurationMs": 138.62600000000003,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 122.70799999998871,
"styleRecalcs": 9,
"styleRecalcDurationMs": 17.493000000000002,
"layouts": 3,
"layoutDurationMs": 1.6920000000000002,
"taskDurationMs": 88.005,
"heapDeltaBytes": 3192872,
"heapUsedBytes": 72053272,
"domNodes": 129,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.864000000000003,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 106.23199999997723,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.268000000000002,
"layouts": 2,
"layoutDurationMs": 1.4150000000000003,
"taskDurationMs": 74.805,
"heapDeltaBytes": 2987428,
"heapUsedBytes": 71960476,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.085,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #18219 +/- ##
=============================================
Coverage ? 83.54%
=============================================
Files ? 2094
Lines ? 123478
Branches ? 34486
=============================================
Hits ? 103164
Misses ? 20136
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…#18077) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789592076376929?thread_ts=1789592076.376929&cid=C0BGH348Z0C)_ **Before:** Every new unsaved tab opens at the same default path, and the agent panel remembers which tab belongs to which agent workflow by that path. When a bound tab was closed without the app's own cleanup (the browser tab was simply closed), its record stayed behind. On the next visit the still-open chat thread named that workflow, the panel matched it to the brand-new tab by path, the next message was sent as that workflow, and the agent's document was pulled onto the fresh canvas over the default graph. **After:** A remembered binding only attaches to a tab that carries the same workflow document id it was bound with. A fresh tab has a new id, so it is refused and keeps its default canvas and its own identity; a reload or a browser-restart restore of the same draft keeps its id, so the sidebar stays attached as before. This change makes the agent workflow tab binding store prove ownership by document identity instead of by tab path alone. **How:** Records move to a new storage key (`Comfy.Agent.WorkflowTabBindings.v2`) as `{ tabPath, graphId, confirmedAt }`, migrated once from the legacy map, which is left in place so a rollback keeps reading the shape it wrote. The store's watcher adopts a tab only when the ids match; the exported lookups hide a record while an unproven tab occupies its path, without deleting it, so a live binding in another browser tab is never damaged. A 30-day `confirmedAt` TTL prunes dead records at store creation. A draft refused for a record cannot become its owner by being saved in place at that path. Alternatives (page-load nonce, tab identity, re-keying on the graph id) and the consequences, including the one-time upgrade cost for open unsaved drafts, are in ADR `docs/adr/AGENT-BINDING-0035-document-identity-gates-persisted-workflow-tab-bindings.md`. - Red then green in two commits: `d44406a` (tests and ADR only; the new store, component and E2E tests fail against the old store) then `f7b06a2` (the fix, all green). - `eccfc83` repairs the E2E spec: a fresh tab boots with the default graph, not an empty canvas, so the spec now captures the boot node titles and asserts they are unchanged after the turn, that the outgoing turn carries the newly saved workflow id, and that the stale ack is rejected visibly. - `77915be` splits the store watcher into two named helpers (same behavior) to clear the fallow complexity gate, and adds tests for the two parse fallbacks (non-JSON legacy key, non-JSON `originalContent`) that Codecov flagged. - `pnpm vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts src/workbench/extensions/agent/stores/agent/agentWorkflowTabBindingStore.test.ts`: 239 passed; store file at 100% line coverage. - `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm knip`, `pnpm adr:check`, eslint and `oxfmt --check` on every touched file, and `pnpm fallow audit --changed-since origin/main` (verdict pass, no introduced findings): clean on the pushed head. - Not run locally: `browser_tests/tests/agent/agentStaleWorkflowTabBinding.spec.ts` needs the app server, which this environment does not have. It is type-checked and linted; CI's cloud Playwright project (and the new-tests video job) is the only place it runs. --------- Co-authored-by: bymyself <cbyrne@comfy.org> (cherry picked from commit be3d753)
eb395fe to
7b9285e
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Target-native adaptation reviewed; exact-head guard passes.
No unresolved human objection. Admin merge authorized.
Full context for agent readers
Reviewed head 7b9285ef762b4d78efadd6c582c1c37b162b8a30 against live cloud/1.54 target a84e8cc7eee78b8e96daad1749e11151e358120d. The metadata-only head change retains the previously tested production tree. The release adaptation preserves workflow document identity while retaining the target store/API shape. Published evidence covers 239 focused tests, source and browser typechecks, hooks, and the target-native browser case with the old-store control failing and restored fix passing. The target-aware program guard reports 88 terminal non-adverse checks, fresh receipts, target ancestry, and no unresolved thread or later reviewer objection. Christian’s Agent 1.54 backport grant authorizes guarded admin merge without manufacturing a self-approval. This merge is not deployment or incident closure.
Glossary: target-native means adapted and tested on this release branch; guard means the program’s exact-head ancestry/check/review verification.
…t a cloud carrier (#18257) ## Summary Eight merged `main` Agent fixes that had no `cloud/1.54` carrier are cherry-picked onto the current release tip. Two sources need hand re-expression and are excluded. Runtime source is unmodified from the eight sources; seven follow-up commits are test-only adaptations to the release's module surface. Verification at the current head `2991cfc3f8` is hosted CI (77 success, 16 skipped, 0 failed) plus DrJKL's local run (see below); the picked browser specs had not been run against the target before this PR. Open gates: release-scope sign-off on the three non-Agent carries and exact-head human re-approval on `2991cfc3f8`, both tracked in [blocked-on-christian 825](christian-byrne/blocked-on-christian#825). Replaces [18254](#18254): six picks there inherited `Co-authored-by: Claude` trailers from the `main` squash commits and failed the AI co-author check. Runtime source is byte-identical to that PR's head `d1f35ac622`; two test files differ (listed under Adaptations). <details><summary>Full context for agent readers</summary> ## Changes Sources, all `cherry-pick -x -m 1`, clean, in merge order: - [18104](#18104) prefer previewUrl for dragged batch-output attachments - [18110](#18110) re-measure Vue node slot offsets after graph reload - [18117](#18117) record an undo entry when a link is dropped from a Vue node slot - [18118](#18118) stop a canvas click after redo from pushing a spurious undo entry - [18124](#18124) never silently no-op the subscription-required dialog - [18127](#18127) restore autogrow inputs after Agent reconciliation - [18191](#18191) keep the ghost placement flag out of the CRDT document - [18196](#18196) retarget new Agent chat to the workflow tab on screen Adaptations, all test-only, no runtime change: - `NodeSlots` reload unit test uses `createTestingPinia` + `setActivePinia` instead of `getActivePinia()!`, because the shared test Pinia setup from [17237](#17237) is `main`-only. - Browser fixture gains `NodeSlotReference.expectLinkCount` (same body as `main`, from [17403](#17403)); three picked Agent specs open the panel with the label the release UI renders, `agent.askComfyAgent`, because `agent.entryButton` from [17621](#17621) does not exist on this line. - `useSlotLinkInteraction.autoPan.test.ts`: the `globalEnums` mock is dropped (the picked composable now reads `RenderShape` from the real module, as on `main`), and the `@vueuse/core` mock spreads the actual module so release-native transitive imports such as `useStorage` resolve while the event-listener overrides stay focused. - `useSlotLinkInteraction.autoPan.test.ts` (`249123390c`): the workflow store is mocked at its seam instead of a partial module mock, per dante01yoon's review. - `subgraphPromotedWidgetExternalLink.spec.ts` (`2991cfc3f8`): the plain CLIPTextEncode "hides the text control" case and its two constants are deleted, because it asserts [17576](#17576) behavior (WidgetGrid retains labels for connected inputs) that is not on `cloud/1.54`. Re-add when 17576 lands on this line; the 17576 decision is [blocked-on-christian 824](christian-byrne/blocked-on-christian#824). Dependencies: none added; release lockfile pins preserved. Exclusions: [18063](#18063) and [18073](#18073) conflict because they edit `agentCrdtProjection.ts` and `agentCrdtDocLifecycle.ts`, files created by the follower split in [16908](#16908), which `cloud/1.54` never received. They need focused hand re-expression onto the pre-split follower, following [18219](#18219) and [18195](#18195); tracked as separate program rows. ## Review focus - Every source commit is an unmodified cherry-pick; review effort belongs on the test-only adaptation commits and on whether the eight sources are wanted on this line at all. - Sources 18110, 18117, and 18118 touch undo/redo and slot measurement outside the Agent panel, so they change behavior for users who never open the Agent. - This is not behavioral acceptance or a merge-check waiver; no target-native browser acceptance has run outside hosted CI. ## Exact-head verification Head history: `210e191fc9` (approved by DrJKL) received five test-only follow-ups: `a9ab888243` (module-surface alignment), `a63fef35ae` (`test.fixme` instead of `test.skip`, which the release's oxlint config rejects), `118ac5e9c6` (restore VueUse exports in the auto-pan mock, fixing the suite-collection failure DrJKL found at `a63fef35ae`), `249123390c` (workflow-store seam mock), and `2991cfc3f8` (delete the plain CLIPTextEncode browser case). - `210e191fc9`, local on top of `cloud/1.54` tip `1bbcdc66fa`: cherry-pick dry run of all 10 candidates, 8 clean individually and as a sequential stack, 2 conflicting as described above; `vitest run` on the 9 touched unit test files 405 passed; both `vue-tsc` projects exit 0; `oxfmt` and `eslint` clean; lint-staged and knip passed in hooks. - `a63fef35ae`, hosted: `lint-and-format` passed. DrJKL's local focused run: 405 passed plus one suite-collection failure in `useSlotLinkInteraction.autoPan.test.ts` (`useStorage` missing from the total `@vueuse/core` mock). Fixed in `118ac5e9c6`. - `118ac5e9c6`: hosted CI green; the unit `test` job covers the collection fix. - `2991cfc3f8` (current head): hosted CI 77 success, 16 skipped, 0 failed. DrJKL's local run on this head: both typecheck projects, ESLint, Oxlint, format, and Knip clean; Vitest 4 of 4 on the auto-pan suite; Playwright discovery 43 tests across 7 specs; Fallow clean. Author-side local verification is not run on this head (host resource hold); hosted CI plus DrJKL's run are the verification of record. Program receipt: [2026-09-21-ms215-gap-backport-cloud154.md](https://github.com/christian-byrne/in-app-agent-program/blob/main/reports/pr-ownership/2026-09-21-ms215-gap-backport-cloud154.md). </details> --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: test-bot <test-bot@users.noreply.github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com>
Summary
Backport the merged persisted-tab binding fix so a fresh canvas cannot inherit an abandoned chat's workflow identity.
Changes
Review Focus
Document identity, saved-in-place refusal, restoration ordering and cross-tab ownership. The thirty-day retention ADR remains Proposed. Original incident stays open through original-session and release acceptance.
Full context for agent readers
Source: merged commit. This is a manual backport because the test setup and ADR index do not apply unchanged; no unrelated main commits are imported.
Target-native validation: 239 store/component tests, source and browser typechecks, lint, formatting and knip pass. The black-box browser regression passes on a verified Cloud-distribution server against the qualified local backend. It checks the newly saved outgoing workflow identity, rejected stale acknowledgement, unchanged fresh canvas and active tab. Screenshots were inspected.
Sensitivity control on the Cloud release: restoring only the old production store makes the outgoing workflow identity assertion fail with the abandoned workflow ID. The two release carriers use the same production fix and equivalent browser assertions. Earlier browser attempts used an occupied/wrong-checkout port and are not evidence of a product regression. No tests were skipped or weakened.
This PR does not deploy the release or close the broader incident. Glossary: backport applies a merged fix to a release branch; binding associates an Agent workflow with an editor tab.