Repository navigation
fix(deps): bump happy-dom to 20.14.5 to stop MutationObserver GC drops - #18157
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2041 passed, 0 failed📊 Browser Reports
🌐 Website E2ETip All tests passed.
📦 Bundle: 9.92 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category Status: 298 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-19T22:52:44.533Z",
"gitSha": "8ff069aa2a5214ec77ffe73d1fafeb2d9b1f2e19",
"branch": "fix/agent-panel-root-composer-flake",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2045.4560000000015,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.1850000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 665.7890000000001,
"heapDeltaBytes": 9494536,
"heapUsedBytes": 70693756,
"domNodes": -266,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 15.625000000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2021.1890000000494,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.598999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.25600000000003,
"heapDeltaBytes": 15294628,
"heapUsedBytes": 76468224,
"domNodes": -264,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 14.747,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1924.2039999999747,
"styleRecalcs": 78,
"styleRecalcDurationMs": 35.486999999999995,
"layouts": 14,
"layoutDurationMs": 4.325000000000001,
"taskDurationMs": 968.705,
"heapDeltaBytes": -6142640,
"heapUsedBytes": 55151276,
"domNodes": -265,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 179.24099999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1936.1900000000105,
"styleRecalcs": 77,
"styleRecalcDurationMs": 34.831,
"layouts": 14,
"layoutDurationMs": 4.764,
"taskDurationMs": 971.1809999999999,
"heapDeltaBytes": 14719828,
"heapUsedBytes": 76302188,
"domNodes": -265,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 179.789,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.2930000000415,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.941,
"layouts": 6,
"layoutDurationMs": 1.1170000000000002,
"taskDurationMs": 410.173,
"heapDeltaBytes": 2106948,
"heapUsedBytes": 64100556,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 16.249,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.4220000000141,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.789,
"layouts": 6,
"layoutDurationMs": 1.353,
"taskDurationMs": 428.70200000000006,
"heapDeltaBytes": 2162704,
"heapUsedBytes": 64254944,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 17.493000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 811.0570000000052,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.513000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.053,
"heapDeltaBytes": 17139596,
"heapUsedBytes": 77813956,
"domNodes": 10,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 200.49999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 722.6099999999178,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.127999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.267,
"heapDeltaBytes": 18311948,
"heapUsedBytes": 79952748,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 170.82500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2046.3430000000358,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.650000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 743.904,
"heapDeltaBytes": 3039064,
"heapUsedBytes": 83211480,
"domNodes": -250,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 41.400999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.721999999936,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.670000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 740.141,
"heapDeltaBytes": 3710960,
"heapUsedBytes": 82272008,
"domNodes": -253,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 43.823,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2876.287999999988,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.825,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1832.6320000000003,
"heapDeltaBytes": 22263756,
"heapUsedBytes": 86157884,
"domNodes": -255,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 918.46,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2905.602999999928,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.877,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1831.8369999999998,
"heapDeltaBytes": 22793976,
"heapUsedBytes": 86984200,
"domNodes": -257,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 928.451,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3618.0889999999977,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.728999999999996,
"layouts": 60,
"layoutDurationMs": 14.243,
"taskDurationMs": 1688.2210000000002,
"heapDeltaBytes": 7787952,
"heapUsedBytes": 73566824,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 847.102,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3844.889999999964,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.994,
"layouts": 60,
"layoutDurationMs": 14.132,
"taskDurationMs": 1874.783,
"heapDeltaBytes": 8718280,
"heapUsedBytes": 74226792,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 869.1569999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3167.89,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.3629999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2096.888,
"heapDeltaBytes": 23041824,
"heapUsedBytes": 88615284,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1053.347,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3199.324000000047,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.5870000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2126.3099999999995,
"heapDeltaBytes": 22713908,
"heapUsedBytes": 88654224,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1093.0389999999998,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2026.2309999999388,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.43,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 724.688,
"heapDeltaBytes": -4293156,
"heapUsedBytes": 83366544,
"domNodes": -254,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 42.31499999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2039.4850000000133,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.389,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 734.592,
"heapDeltaBytes": -3988656,
"heapUsedBytes": 83312876,
"domNodes": -256,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 43.050999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 658.4220000000869,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.543,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.744,
"heapDeltaBytes": 13410464,
"heapUsedBytes": 76769264,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 150.05,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 690.9570000000258,
"styleRecalcs": 48,
"styleRecalcDurationMs": 14.449,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.725,
"heapDeltaBytes": 13866132,
"heapUsedBytes": 77091796,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 154.785,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2035.2460000000292,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.060000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.81600000000003,
"heapDeltaBytes": 12781476,
"heapUsedBytes": 76121748,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 13.251999999999997,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2017.688000000021,
"styleRecalcs": 12,
"styleRecalcDurationMs": 12.735000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.70900000000006,
"heapDeltaBytes": 9873400,
"heapUsedBytes": 73147752,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 13.700000000000005,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.9830000000006,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.068,
"layouts": 18,
"layoutDurationMs": 6.033,
"taskDurationMs": 905.844,
"heapDeltaBytes": 1993812,
"heapUsedBytes": 64720032,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 129.54700000000003,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1774.3689999999788,
"styleRecalcs": 78,
"styleRecalcDurationMs": 32.674,
"layouts": 18,
"layoutDurationMs": 6.1850000000000005,
"taskDurationMs": 926.4850000000001,
"heapDeltaBytes": 8641584,
"heapUsedBytes": 71171216,
"domNodes": -276,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 129.56599999999997,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.5929999999498,
"styleRecalcs": 17,
"styleRecalcDurationMs": 31.842999999999996,
"layouts": 5,
"layoutDurationMs": 14.390000000000004,
"taskDurationMs": 1063.6599999999999,
"heapDeltaBytes": -6413736,
"heapUsedBytes": 80431136,
"domNodes": 13587,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 37.549,
"eventListeners": 2383,
"totalBlockingTimeMs": 165,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9871.485999999948,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.305,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6587.125999999999,
"heapDeltaBytes": 899892,
"heapUsedBytes": 79617112,
"domNodes": -248,
"jsHeapTotalBytes": 446464,
"scriptDurationMs": 3034.455,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 10415.87400000003,
"styleRecalcs": 247,
"styleRecalcDurationMs": 40.22299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6804.09,
"heapDeltaBytes": -94776,
"heapUsedBytes": 79349404,
"domNodes": -250,
"jsHeapTotalBytes": 708608,
"scriptDurationMs": 3152.215,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17959.212999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17481.893,
"heapDeltaBytes": -32911996,
"heapUsedBytes": 170639604,
"domNodes": -8061,
"jsHeapTotalBytes": -11079680,
"scriptDurationMs": 291.343,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18111.336999999934,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17593.057,
"heapDeltaBytes": -49367272,
"heapUsedBytes": 191645180,
"domNodes": -8061,
"jsHeapTotalBytes": -12066816,
"scriptDurationMs": 294.495,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21479.52399999997,
"styleRecalcs": 157,
"styleRecalcDurationMs": 22.607000000000042,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21316.472,
"heapDeltaBytes": -50710156,
"heapUsedBytes": 178825012,
"domNodes": -8061,
"jsHeapTotalBytes": -14487552,
"scriptDurationMs": 976.428,
"eventListeners": -14929,
"totalBlockingTimeMs": 188,
"frameDurationMs": 18.889999999999905,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21573.17699999999,
"styleRecalcs": 159,
"styleRecalcDurationMs": 22.237000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21393.389,
"heapDeltaBytes": -28161356,
"heapUsedBytes": 188213600,
"domNodes": -8061,
"jsHeapTotalBytes": -17768448,
"scriptDurationMs": 950.6759999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 89,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6391.869999999926,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.82000000000001,
"layouts": 20,
"layoutDurationMs": 27.660000000000004,
"taskDurationMs": 6332.349000000001,
"heapDeltaBytes": -57870696,
"heapUsedBytes": 178205560,
"domNodes": -8061,
"jsHeapTotalBytes": 11206656,
"scriptDurationMs": 111.68099999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 429,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6459.989999999948,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.71000000000001,
"layouts": 20,
"layoutDurationMs": 30.256000000000018,
"taskDurationMs": 6414.713000000001,
"heapDeltaBytes": -64919596,
"heapUsedBytes": 170466596,
"domNodes": -8061,
"jsHeapTotalBytes": 8060928,
"scriptDurationMs": 117.80099999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 564,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9062.524999999936,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8896.999,
"heapDeltaBytes": 26838980,
"heapUsedBytes": 194755192,
"domNodes": 0,
"jsHeapTotalBytes": -27000832,
"scriptDurationMs": 211.19899999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 12,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8877.068000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8701.235,
"heapDeltaBytes": 8884272,
"heapUsedBytes": 180765052,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 168.56400000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 485.9109999999873,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.348000000000003,
"layouts": 4,
"layoutDurationMs": 1.953,
"taskDurationMs": 141.84800000000004,
"heapDeltaBytes": 5071740,
"heapUsedBytes": 66645212,
"domNodes": 147,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 15.676000000000002,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 462.5419999999849,
"styleRecalcs": 14,
"styleRecalcDurationMs": 27.998,
"layouts": 4,
"layoutDurationMs": 1.882,
"taskDurationMs": 127.42000000000003,
"heapDeltaBytes": 4748520,
"heapUsedBytes": 66699160,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.545999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates the ChangesTest Environment Compatibility
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18157 +/- ##
==========================================
- Coverage 82.78% 82.77% -0.01%
==========================================
Files 2940 2940
Lines 144690 144692 +2
Branches 37236 39104 +1868
==========================================
- Hits 119778 119774 -4
- Misses 23638 23644 +6
Partials 1274 1274
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@coderabbitai full review |
✅ Action performedFull review finished. |
…ationObserver GC drops (#18170) ## Summary Focused backport of [#18157 (bump happy-dom to 20.14.5)](#18157) to `core/1.54`, from merged source commit [`1e385c25`](1e385c2). - Bumps the workspace catalog `happy-dom` from 20.9.0 to 20.14.5, which carries the upstream fix for MutationObserver callbacks being garbage collected. - Adapts the same three test doubles the source PR adapted. No assertion is weakened, and no production code changes. - `pnpm-lock.yaml` is regenerated on this branch, not copied from `main`: the diff touches only the `happy-dom` entry and the `vitest` peer-resolution keys that name it. No billing/account or other `main`-only entries are imported. ## Why it is worth carrying to 1.54 In happy-dom 20.9.0 `MutationObserverListener` held its callback only in a `WeakRef`, so `reportMutation` silently dropped records once the callback was collected (upstream [happy-dom#2264](capricorn86/happy-dom#2264)). That is a whole-environment defect in the Vitest DOM: any suite whose code under test relies on `MutationObserver` can lose records under GC pressure, which is exactly the GC-timing-dependent flake class that makes a release branch's CI untrustworthy. ## Source applicability on this target All five source paths exist on `core/1.54` and the source hunks applied without conflict (context offsets only). The specific symptom case the source PR names, `AgentPanelRoot.test.ts` "defers the tour in App Mode", does **not** exist on this branch. Confirmed with the runner rather than a title grep: `vitest list src/workbench/extensions/agent/AgentPanelRoot.test.ts` enumerates 127 cases on this branch and none match `App Mode` or `tour`. The repeat-run flake loop from the source PR is therefore not applicable here and is recorded as such rather than importing an unrelated feature to create the case. The dependency and test-double fix still applies on its own terms. ## Verification on this exact target Base `ffed3f0ca28163a89246f39715ca46eb754885f0`, head `c42ffe3d27ae053b3a85e2355bf7ae34b019ee58`. Node 25.9.0, pnpm 11.13.1 (the versions this branch's `engines`/`packageManager` require). - Installed environment: `node_modules/happy-dom/package.json` reports `20.14.5`. - Lockfile consistency: `pnpm install --frozen-lockfile` exits 0 with "Already up to date". - Affected suites, `vitest run --maxWorkers=1 --fileParallelism=false` over `useVideoFilmstrip.test.ts`, `cursorCache.test.ts`, `LGraphCanvas.drawConnections.test.ts`, `LGraphCanvas.invalidation.test.ts`: 4 files, 59 tests, all passing. - Format, lint and typecheck ran over the changed files through the repo's own pre-commit path (`oxfmt`, `oxlint --type-aware`, `eslint`, `pnpm typecheck`), all clean. ## Scope This is test-infrastructure only. The source PR explains that the defect lives in the unit-test DOM and cannot be reproduced in a real browser, so there is no Playwright case here and nothing in this PR should be read as real-browser acceptance.
…tationObserver GC drops (#18171) ## Summary Focused backport of [#18157 (bump happy-dom to 20.14.5)](#18157) to `cloud/1.54`, from merged source commit [`1e385c25`](1e385c2). - Bumps the workspace catalog `happy-dom` from 20.9.0 to 20.14.5, which carries the upstream fix for MutationObserver callbacks being garbage collected. - Adapts the same three test doubles the source PR adapted. No assertion is weakened, and no production code changes. - `pnpm-lock.yaml` is regenerated on this branch, not copied from `main`: the diff touches only the `happy-dom` entry and the `vitest` peer-resolution keys that name it. No billing/account or other `main`-only entries are imported. ## Why it is worth carrying to 1.54 In happy-dom 20.9.0 `MutationObserverListener` held its callback only in a `WeakRef`, so `reportMutation` silently dropped records once the callback was collected (upstream [happy-dom#2264](capricorn86/happy-dom#2264)). That is a whole-environment defect in the Vitest DOM: any suite whose code under test relies on `MutationObserver` can lose records under GC pressure, which is exactly the GC-timing-dependent flake class that makes a release branch's CI untrustworthy. ## Source applicability on this target All five source paths exist on `cloud/1.54` and the source hunks applied without conflict (context offsets only). The specific symptom case the source PR names, `AgentPanelRoot.test.ts` "defers the tour in App Mode", does **not** exist on this branch. Confirmed with the runner rather than a title grep: `vitest list src/workbench/extensions/agent/AgentPanelRoot.test.ts` enumerates 127 cases on this branch and none match `App Mode` or `tour`. The repeat-run flake loop from the source PR is therefore not applicable here and is recorded as such rather than importing an unrelated feature to create the case. The dependency and test-double fix still applies on its own terms. ## Verification on this exact target Base `d3a2a091b9cea02244bd4ecd95dfdf7e178faf7a`, head `8aa20aaa3af8a25349066a859b4ddf81d87646b8`. Node 25.9.0, pnpm 11.13.1 (the versions this branch's `engines`/`packageManager` require). - Installed environment: `node_modules/happy-dom/package.json` reports `20.14.5`. - Lockfile consistency: `pnpm install --frozen-lockfile` exits 0 with "Already up to date". - Affected suites, `vitest run --maxWorkers=1 --fileParallelism=false` over `useVideoFilmstrip.test.ts`, `cursorCache.test.ts`, `LGraphCanvas.drawConnections.test.ts`, `LGraphCanvas.invalidation.test.ts`: 4 files, 59 tests, all passing. - Format, lint and typecheck ran over the changed files through the repo's own pre-commit path (`oxfmt`, `oxlint --type-aware`, `eslint`, `pnpm typecheck`), all clean. ## Scope This is test-infrastructure only. The source PR explains that the defect lives in the unit-test DOM and cannot be reproduced in a real browser, so there is no Playwright case here and nothing in this PR should be read as real-browser acceptance.
Summary
AgentPanelRoot.test.tscomposer flake (Exlain this appp): happy-dom 20.9.0 dropped MutationObserver records after GC, so ProseMirror missed keystrokes.happy-domfrom 20.9.0 to 20.14.5, which carries the upstream fix.happy-domdevDependency (the Vitest DOM environment) and adjusts test doubles undersrc/**/*.test.tsandsrc/utils/__tests__/; the bug lives in the unit-test environment and cannot be reproduced in a real browser, so an end-to-end test cannot cover it.Related to the agent stream drop bug tracked in Linear as PM-1199 (agent stream drops mid-turn) only in that it blocked green CI for the fix PRs (#18152 (agent turn survives socket drop), #18154 (reconcile hydrated streaming turn)).
Full context for agent readers
Root cause
In happy-dom 20.9.0,
MutationObserverListenerheld its callback only in aWeakRef. Once the callback was collected,reportMutationsilently dropped records. ProseMirror'sDOMObserverrelies on MutationObserver to see the DOM mutation from a typed character; when a record was dropped, the editor state fell behind the DOM and later characters were inserted at a stale offset. The symptom insrc/workbench/extensions/agent/AgentPanelRoot.test.ts("defers the tour in App Mode") was the composer textExlain this apppinstead ofExplain this app. The failure was GC-timing dependent, so it reproduced in roughly 7 of 12 isolated runs and more often in the full suite.Upstream: happy-dom issue #2264 (MutationObserver callback garbage collected), fixed by holding a strong
#listenerCallbackreference (duplicate report in happy-dom issue #2255 (MutationObserver stops firing)). A deterministic scratch test that forced GC with--expose-gcfailed on 20.9.0 and passed on 20.14.5; it is not committed because it needs the--expose-gcnode flag, which the vitest config does not pass.Test adaptations (environment changes, not weakened assertions)
src/composables/video/useVideoFilmstrip.test.ts: happy-dom 20.14 now definescreateImageBitmapandOffscreenCanvas, which routed the canvas-fallback cases down the bitmap path against theMockVideoElement. AbeforeEachstubs both toundefined; the bitmap-path tests already install their own mocks inside the test body and so override it.src/lib/litegraph/src/cursorCache.test.ts:CSSStyleDeclarationis now a Proxy that rejectsdefinePropertyoncursor. The mock element now defines a plainstyleobject with acursoraccessor. ProductioncreateCursorCacheis unchanged.src/utils/__tests__/litegraphTestUtils.ts: happy-dom images now reportwidth > 0, sodrawBackCanvasreachesctx.createPattern. Both mock 2D context factories now providecreatePattern: vi.fn(() => null). This fixedLGraphCanvas.drawConnections.test.tsandLGraphCanvas.invalidation.test.ts.Verification
AgentPanelRoot.test.ts -t "defers the tour in App Mode": 12/12 pass on 20.14.5 (7/12 failed on 20.9.0).pnpm test:unit: 1610 files, 22182 passed, 14 expected fail, 7 skipped, exit 0.pnpm exec vitest runin each dir:packages/account-core907/907,packages/account-ui120/120,apps/billing-web125/125,apps/website5179/5179.pnpm typecheck,pnpm lint,pnpm knip,pnpm formatall exit 0.Decisions to veto
--expose-gc. If reviewers want one, it could live behind a dedicated vitest project withpoolOptions.forks.execArgv.576a8bcwould do.