Repository navigation
[backport cloud/1.54] fix(deps): bump happy-dom to 20.14.5 to stop MutationObserver GC drops - #18171
Conversation
Backport of #18157 (squash commit 1e385c2). happy-dom 20.9.0 held the MutationObserver callback only in a WeakRef, so reportMutation silently dropped records once the callback was collected. 20.14.5 carries the upstream fix (capricorn86/happy-dom#2264). Three test doubles are adapted to the newer environment; no assertion is weakened and no production code changes.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
🎭 Playwright: ✅ 1918 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-20T02:25:40.385Z",
"gitSha": "1c618b88b2109d174be0952e5da2354d4cf8ce38",
"branch": "bp/happy-dom-18157-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.5709999999904,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.474999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.0729999999999,
"heapDeltaBytes": -3420912,
"heapUsedBytes": 65861616,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.806,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2015.4580000000806,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.079,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.65299999999996,
"heapDeltaBytes": 1317356,
"heapUsedBytes": 65431292,
"domNodes": 16,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 9.138,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2002.3410000000013,
"styleRecalcs": 81,
"styleRecalcDurationMs": 45.806,
"layouts": 14,
"layoutDurationMs": 5.098,
"taskDurationMs": 1020.2280000000002,
"heapDeltaBytes": -8519072,
"heapUsedBytes": 61992116,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 152.45899999999997,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1790.7109999999875,
"styleRecalcs": 74,
"styleRecalcDurationMs": 31.125999999999998,
"layouts": 14,
"layoutDurationMs": 4.019,
"taskDurationMs": 823.608,
"heapDeltaBytes": 1355868,
"heapUsedBytes": 71230540,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 133.226,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1774.028000000044,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.141999999999996,
"layouts": 6,
"layoutDurationMs": 1.3820000000000001,
"taskDurationMs": 363.26599999999996,
"heapDeltaBytes": 4680720,
"heapUsedBytes": 74889252,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.092999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1680.9819999999718,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.056,
"layouts": 6,
"layoutDurationMs": 1.3559999999999999,
"taskDurationMs": 354.06000000000006,
"heapDeltaBytes": 5031684,
"heapUsedBytes": 75824652,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.575,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 642.7120000000173,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.458,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.50600000000003,
"heapDeltaBytes": -7539472,
"heapUsedBytes": 63189192,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 147.44000000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 613.0980000000363,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.399000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.636,
"heapDeltaBytes": 18683460,
"heapUsedBytes": 82032400,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 147.309,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2036.3330000000133,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.677999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.6270000000001,
"heapDeltaBytes": 11772596,
"heapUsedBytes": 87670664,
"domNodes": -268,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 38.418,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2071.1219999999457,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.062999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 624.3190000000001,
"heapDeltaBytes": 11227644,
"heapUsedBytes": 87391312,
"domNodes": -265,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 45.406,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2124.9109999999973,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.648999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1426.9270000000001,
"heapDeltaBytes": 18190424,
"heapUsedBytes": 84606872,
"domNodes": 4,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 685.23,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2256.3030000000026,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.927000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1603.6260000000002,
"heapDeltaBytes": 8901432,
"heapUsedBytes": 86000700,
"domNodes": -270,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 777.1210000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3561.2939999999753,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.940000000000003,
"layouts": 60,
"layoutDurationMs": 13.993,
"taskDurationMs": 1622.099,
"heapDeltaBytes": 7760376,
"heapUsedBytes": 75989828,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 694.0690000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3610.4669999999714,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.853000000000002,
"layouts": 60,
"layoutDurationMs": 14.434,
"taskDurationMs": 1653.2,
"heapDeltaBytes": 8527272,
"heapUsedBytes": 75976928,
"domNodes": -270,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 707.84,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2969.6860000000243,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.965000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1771.2740000000001,
"heapDeltaBytes": 12725776,
"heapUsedBytes": 80523960,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 857.4040000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3053.214999999909,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.670999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1819.599,
"heapDeltaBytes": 22348148,
"heapUsedBytes": 89848016,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 867.9399999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.674000000099,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.4499999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.086,
"heapDeltaBytes": 10382888,
"heapUsedBytes": 87626040,
"domNodes": -268,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 39.897,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.5379999999122,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.237,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.3659999999999,
"heapDeltaBytes": 10493680,
"heapUsedBytes": 87602008,
"domNodes": -270,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 30.19000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 584.1219999999794,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.625,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.36799999999994,
"heapDeltaBytes": 14826256,
"heapUsedBytes": 87786508,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 127.21700000000003,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.6480000000165,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.617999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.45699999999994,
"heapDeltaBytes": 15125904,
"heapUsedBytes": 88284556,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 135.16699999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.8509999999933,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.362,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.6430000000001,
"heapDeltaBytes": -2642044,
"heapUsedBytes": 69650236,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.767,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2014.3580000000156,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.198999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.09200000000004,
"heapDeltaBytes": -988956,
"heapUsedBytes": 72210320,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.117,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.982000000016,
"styleRecalcs": 78,
"styleRecalcDurationMs": 35.968,
"layouts": 18,
"layoutDurationMs": 5.603000000000001,
"taskDurationMs": 834.866,
"heapDeltaBytes": -22708,
"heapUsedBytes": 73155408,
"domNodes": -295,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 100.97099999999999,
"eventListeners": -222,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1759.221000000025,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.394,
"layouts": 18,
"layoutDurationMs": 6.140000000000001,
"taskDurationMs": 852.427,
"heapDeltaBytes": 6797616,
"heapUsedBytes": 79932624,
"domNodes": -297,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 101.83999999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1133.279000000016,
"styleRecalcs": 21,
"styleRecalcDurationMs": 28.83299999999999,
"layouts": 17,
"layoutDurationMs": 12.831999999999999,
"taskDurationMs": 873.3900000000001,
"heapDeltaBytes": 20967476,
"heapUsedBytes": 109886980,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 27.207000000000008,
"eventListeners": 2385,
"totalBlockingTimeMs": 146,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8287.215999999944,
"styleRecalcs": 247,
"styleRecalcDurationMs": 40.276999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5488.7300000000005,
"heapDeltaBytes": -12354120,
"heapUsedBytes": 89771716,
"domNodes": -269,
"jsHeapTotalBytes": 159744,
"scriptDurationMs": 2450.5840000000003,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8258.75700000006,
"styleRecalcs": 247,
"styleRecalcDurationMs": 44.955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5433.3009999999995,
"heapDeltaBytes": 13671388,
"heapUsedBytes": 89426064,
"domNodes": -268,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 2424.005,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14644.604999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14002.932,
"heapDeltaBytes": -23274028,
"heapUsedBytes": 181190644,
"domNodes": -6548,
"jsHeapTotalBytes": 1396736,
"scriptDurationMs": 278.065,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14814.38300000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14258.067000000001,
"heapDeltaBytes": -14371836,
"heapUsedBytes": 174866312,
"domNodes": -6548,
"jsHeapTotalBytes": 2084864,
"scriptDurationMs": 261.555,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17855.803000000036,
"styleRecalcs": 148,
"styleRecalcDurationMs": 19.87899999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17582.482,
"heapDeltaBytes": -24969368,
"heapUsedBytes": 180443484,
"domNodes": -6548,
"jsHeapTotalBytes": 192512,
"scriptDurationMs": 924.4079999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 40,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 18540.209000000003,
"styleRecalcs": 156,
"styleRecalcDurationMs": 21.896000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18125.489999999998,
"heapDeltaBytes": -18538324,
"heapUsedBytes": 191795272,
"domNodes": -6548,
"jsHeapTotalBytes": -4939776,
"scriptDurationMs": 940.2080000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 17,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5262.671999999952,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.72499999999998,
"layouts": 20,
"layoutDurationMs": 23.537000000000003,
"taskDurationMs": 5193.428,
"heapDeltaBytes": -31382520,
"heapUsedBytes": 173645976,
"domNodes": -6577,
"jsHeapTotalBytes": 17289216,
"scriptDurationMs": 104.45400000000002,
"eventListeners": -7474,
"totalBlockingTimeMs": 192,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5255.262000000016,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.727,
"layouts": 20,
"layoutDurationMs": 30.49800000000001,
"taskDurationMs": 5144.687999999999,
"heapDeltaBytes": -27101692,
"heapUsedBytes": 174636144,
"domNodes": -6548,
"jsHeapTotalBytes": 11259904,
"scriptDurationMs": 95.544,
"eventListeners": -7473,
"totalBlockingTimeMs": 367,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7422.876999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7249.964,
"heapDeltaBytes": 15587472,
"heapUsedBytes": 174823544,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 116.46200000000006,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7351.875999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7106.257999999999,
"heapDeltaBytes": 15267300,
"heapUsedBytes": 178137580,
"domNodes": 0,
"jsHeapTotalBytes": -8650752,
"scriptDurationMs": 116.32599999999998,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 475.7520000000568,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.493,
"layouts": 3,
"layoutDurationMs": 1.9819999999999998,
"taskDurationMs": 116.08100000000002,
"heapDeltaBytes": 4937264,
"heapUsedBytes": 72558760,
"domNodes": 147,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.552999999999997,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 449.94999999994434,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.159000000000002,
"layouts": 3,
"layoutDurationMs": 0.9240000000000002,
"taskDurationMs": 99.22899999999998,
"heapDeltaBytes": 4801796,
"heapUsedBytes": 72774508,
"domNodes": 119,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 7.498999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18171 +/- ##
=============================================
Coverage ? 81.54%
=============================================
Files ? 2487
Lines ? 128115
Branches ? 33222
=============================================
Hits ? 104465
Misses ? 23140
Partials ? 510
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Focused backport of #18157 (bump happy-dom to 20.14.5) to
cloud/1.54, from merged source commit1e385c25.happy-domfrom 20.9.0 to 20.14.5, which carries the upstream fix for MutationObserver callbacks being garbage collected.pnpm-lock.yamlis regenerated on this branch, not copied frommain: the diff touches only thehappy-domentry and thevitestpeer-resolution keys that name it. No billing/account or othermain-only entries are imported.Why it is worth carrying to 1.54
In happy-dom 20.9.0
MutationObserverListenerheld its callback only in aWeakRef, soreportMutationsilently dropped records once the callback was collected (upstream happy-dom#2264). That is a whole-environment defect in the Vitest DOM: any suite whose code under test relies onMutationObservercan lose records under GC pressure, which is exactly the GC-timing-dependent flake class that makes a release branch's CI untrustworthy.Source applicability on this target
All five source paths exist on
cloud/1.54and the source hunks applied without conflict (context offsets only).The specific symptom case the source PR names,
AgentPanelRoot.test.ts"defers the tour in App Mode", does not exist on this branch. Confirmed with the runner rather than a title grep:vitest list src/workbench/extensions/agent/AgentPanelRoot.test.tsenumerates 127 cases on this branch and none matchApp Modeortour. The repeat-run flake loop from the source PR is therefore not applicable here and is recorded as such rather than importing an unrelated feature to create the case. The dependency and test-double fix still applies on its own terms.Verification on this exact target
Base
d3a2a091b9cea02244bd4ecd95dfdf7e178faf7a, head8aa20aaa3af8a25349066a859b4ddf81d87646b8. Node 25.9.0, pnpm 11.13.1 (the versions this branch'sengines/packageManagerrequire).node_modules/happy-dom/package.jsonreports20.14.5.pnpm install --frozen-lockfileexits 0 with "Already up to date".vitest run --maxWorkers=1 --fileParallelism=falseoveruseVideoFilmstrip.test.ts,cursorCache.test.ts,LGraphCanvas.drawConnections.test.ts,LGraphCanvas.invalidation.test.ts: 4 files, 59 tests, all passing.oxfmt,oxlint --type-aware,eslint,pnpm typecheck), all clean.Scope
This is test-infrastructure only. The source PR explains that the defect lives in the unit-test DOM and cannot be reproduced in a real browser, so there is no Playwright case here and nothing in this PR should be read as real-browser acceptance.