Repository navigation
fix(nodes): allow shrinking after content growth and tab switches - #18093
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2143 passed, 0 failed📊 Browser Reports
📦 Bundle: 10 MB gzip 🔴 +233 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 134 kB (baseline 134 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 4 MB (baseline 4 MB) • 🔴 +731 BStores, services, APIs, and repositories
Status: 12 added / 12 removed / 3 unchanged Utilities & Hooks — 578 kB (baseline 578 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 17 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • ⚪ 0 BBundles that do not match a named category
Status: 74 added / 74 removed / 227 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-27T07:28:27.276Z",
"gitSha": "08e2a389b7aa2b7884796e1be7592f09fd2c6564",
"branch": "test/pm-1304-flux-resize-ratchet-repro",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.1050000000241,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.946000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.90999999999997,
"heapDeltaBytes": 12756576,
"heapUsedBytes": 75029848,
"domNodes": -228,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.032000000000002,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1994.3100000000413,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.6310000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.19100000000003,
"heapDeltaBytes": 2069816,
"heapUsedBytes": 64566576,
"domNodes": -228,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.110999999999997,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1788.3669999999938,
"styleRecalcs": 71,
"styleRecalcDurationMs": 16.973000000000003,
"layouts": 12,
"layoutDurationMs": 4.14,
"taskDurationMs": 806.899,
"heapDeltaBytes": 22458208,
"heapUsedBytes": 85090620,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 168.03099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1874.7250000000122,
"styleRecalcs": 72,
"styleRecalcDurationMs": 17.987999999999996,
"layouts": 12,
"layoutDurationMs": 4.595,
"taskDurationMs": 853.9780000000001,
"heapDeltaBytes": 16088104,
"heapUsedBytes": 78316280,
"domNodes": -228,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 170.132,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1718.2530000000042,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.753000000000002,
"layouts": 6,
"layoutDurationMs": 1.3899999999999997,
"taskDurationMs": 356.249,
"heapDeltaBytes": 2088268,
"heapUsedBytes": 64709112,
"domNodes": 53,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 13.301999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.5279999999739,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.460999999999999,
"layouts": 6,
"layoutDurationMs": 1.442,
"taskDurationMs": 339.77199999999993,
"heapDeltaBytes": 2389008,
"heapUsedBytes": 64906496,
"domNodes": 53,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.072,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 696.1359999999672,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.7020000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.43500000000006,
"heapDeltaBytes": 18419768,
"heapUsedBytes": 80913144,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 172.798,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 727.6039999999284,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.491999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.61800000000005,
"heapDeltaBytes": 19368712,
"heapUsedBytes": 86891944,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 174.345,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1194.2020000000184,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 844.5339999999999,
"heapDeltaBytes": 35302804,
"heapUsedBytes": 102293240,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 75.654,
"eventListeners": 0,
"totalBlockingTimeMs": 572,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1237.6460000000407,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 898.683,
"heapDeltaBytes": 10644788,
"heapUsedBytes": 98430096,
"domNodes": -259,
"jsHeapTotalBytes": 24530944,
"scriptDurationMs": 68.468,
"eventListeners": -185,
"totalBlockingTimeMs": 601,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 863.409000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.01300000000003,
"heapDeltaBytes": 14114676,
"heapUsedBytes": 90632472,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 177.367,
"eventListeners": 0,
"totalBlockingTimeMs": 240,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 878.7760000000162,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.75400000000025,
"heapDeltaBytes": 15013876,
"heapUsedBytes": 91342300,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 174.86599999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 235,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10277.491999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9437.185000000001,
"heapDeltaBytes": -14315304,
"heapUsedBytes": 69049288,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 8015.16,
"eventListeners": 0,
"totalBlockingTimeMs": 1731,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11002.24300000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10192.827000000001,
"heapDeltaBytes": -11898316,
"heapUsedBytes": 70530500,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 8738.233,
"eventListeners": 0,
"totalBlockingTimeMs": 2034,
"frameDurationMs": 20.00000000000006,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11492.004000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10477.955,
"heapDeltaBytes": -12474476,
"heapUsedBytes": 70037160,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 8738.320000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 1720,
"frameDurationMs": 18.889999999999905,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11059.350999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10006.538,
"heapDeltaBytes": -7794376,
"heapUsedBytes": 69289568,
"domNodes": -228,
"jsHeapTotalBytes": 2351104,
"scriptDurationMs": 8189.074999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 1346,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2023.666999999989,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.957999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.00000000000006,
"heapDeltaBytes": 2551360,
"heapUsedBytes": 83173200,
"domNodes": -228,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 35.39200000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2069.9489999999514,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.019000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.273,
"heapDeltaBytes": -418708,
"heapUsedBytes": 80966840,
"domNodes": -228,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 37.79299999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2257.8399999999874,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.750000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1547.212,
"heapDeltaBytes": -1522740,
"heapUsedBytes": 80818776,
"domNodes": -228,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 893.591,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2877.0529999999326,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.686000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1793.868,
"heapDeltaBytes": -15246212,
"heapUsedBytes": 66686788,
"domNodes": -228,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 943.2,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3708.5380000000328,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.966,
"layouts": 60,
"layoutDurationMs": 14.068000000000001,
"taskDurationMs": 1753.7889999999998,
"heapDeltaBytes": 8561920,
"heapUsedBytes": 74685060,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 828.431,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3790.8740000000307,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.931000000000001,
"layouts": 60,
"layoutDurationMs": 14.206,
"taskDurationMs": 1830.655,
"heapDeltaBytes": -5097348,
"heapUsedBytes": 78745996,
"domNodes": -228,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 831.9559999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3125.4710000000046,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.633,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1926.9489999999998,
"heapDeltaBytes": 25944968,
"heapUsedBytes": 92306416,
"domNodes": 0,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 971.8149999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3152.323000000024,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.534999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1983.5669999999998,
"heapDeltaBytes": 30831564,
"heapUsedBytes": 96590680,
"domNodes": 0,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 1013.7020000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2003.534000000002,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.5130000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.2690000000001,
"heapDeltaBytes": 20140844,
"heapUsedBytes": 84483968,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.846000000000004,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2061.3369999999804,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.333999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 608.5950000000001,
"heapDeltaBytes": -10150612,
"heapUsedBytes": 77948100,
"domNodes": -228,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 36.934,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 646.9650000000229,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.029999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.49899999999997,
"heapDeltaBytes": 13987544,
"heapUsedBytes": 76838448,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 155.11799999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 620.9430000000111,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.541,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.90299999999996,
"heapDeltaBytes": 13856832,
"heapUsedBytes": 76837268,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 154.663,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.424000000005,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.608,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.93000000000006,
"heapDeltaBytes": 2695268,
"heapUsedBytes": 66128492,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.397000000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.1660000000074,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.205,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.62600000000003,
"heapDeltaBytes": 4943536,
"heapUsedBytes": 68582996,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.777000000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1701.8719999999803,
"styleRecalcs": 72,
"styleRecalcDurationMs": 16.892,
"layouts": 16,
"layoutDurationMs": 5.804,
"taskDurationMs": 778.222,
"heapDeltaBytes": -3453892,
"heapUsedBytes": 60140464,
"domNodes": -244,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 113.29400000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.9270000000406,
"styleRecalcs": 74,
"styleRecalcDurationMs": 20.005000000000003,
"layouts": 16,
"layoutDurationMs": 6.247,
"taskDurationMs": 839.3670000000001,
"heapDeltaBytes": -5918356,
"heapUsedBytes": 57110172,
"domNodes": -244,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 125.199,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.7500000000164,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.946000000000005,
"layouts": 5,
"layoutDurationMs": 13.086,
"taskDurationMs": 901.3329999999997,
"heapDeltaBytes": -6340512,
"heapUsedBytes": 81305180,
"domNodes": 13667,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 30.3,
"eventListeners": 2383,
"totalBlockingTimeMs": 139,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9245.837999999992,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.226,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6053.652999999999,
"heapDeltaBytes": -13063088,
"heapUsedBytes": 68490144,
"domNodes": -228,
"jsHeapTotalBytes": 5009408,
"scriptDurationMs": 2946.282,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8891.627000000084,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.382999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5997.964,
"heapDeltaBytes": -3630632,
"heapUsedBytes": 76949152,
"domNodes": -228,
"jsHeapTotalBytes": 184320,
"scriptDurationMs": 2890.4910000000004,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18219.580999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17951.823,
"heapDeltaBytes": -37458488,
"heapUsedBytes": 187878716,
"domNodes": -8050,
"jsHeapTotalBytes": -11280384,
"scriptDurationMs": 305.06,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18181.145000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17488.412,
"heapDeltaBytes": -51123516,
"heapUsedBytes": 174227732,
"domNodes": -8049,
"jsHeapTotalBytes": -11280384,
"scriptDurationMs": 293.107,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22617.129999999976,
"styleRecalcs": 176,
"styleRecalcDurationMs": 20.853999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22350.500000000004,
"heapDeltaBytes": -58878016,
"heapUsedBytes": 180492064,
"domNodes": -8049,
"jsHeapTotalBytes": -20828160,
"scriptDurationMs": 977.68,
"eventListeners": -14923,
"totalBlockingTimeMs": 92,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 21600.100999999995,
"styleRecalcs": 160,
"styleRecalcDurationMs": 19.681000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21425.967999999997,
"heapDeltaBytes": -71074260,
"heapUsedBytes": 169010192,
"domNodes": -8049,
"jsHeapTotalBytes": -17694720,
"scriptDurationMs": 937.129,
"eventListeners": -14923,
"totalBlockingTimeMs": 128,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6557.778999999982,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.99099999999999,
"layouts": 20,
"layoutDurationMs": 24.83800000000001,
"taskDurationMs": 6507.312000000001,
"heapDeltaBytes": -45172240,
"heapUsedBytes": 173179532,
"domNodes": -8049,
"jsHeapTotalBytes": 12574720,
"scriptDurationMs": 119.92099999999999,
"eventListeners": -14923,
"totalBlockingTimeMs": 514,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4989.708000000064,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.51899999999998,
"layouts": 20,
"layoutDurationMs": 26.02599999999998,
"taskDurationMs": 4910.369000000001,
"heapDeltaBytes": -50078036,
"heapUsedBytes": 190742248,
"domNodes": -8049,
"jsHeapTotalBytes": 8585216,
"scriptDurationMs": 89.39999999999999,
"eventListeners": -14923,
"totalBlockingTimeMs": 282,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8754.091000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8501.019999999999,
"heapDeltaBytes": 26250584,
"heapUsedBytes": 185005008,
"domNodes": 0,
"jsHeapTotalBytes": -8126464,
"scriptDurationMs": 135.4280000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.33666666666674,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8823.01300000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8598.596,
"heapDeltaBytes": 5418820,
"heapUsedBytes": 197286064,
"domNodes": 0,
"jsHeapTotalBytes": -22020096,
"scriptDurationMs": 133.417,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 117.28100000004815,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.59,
"layouts": 2,
"layoutDurationMs": 0.781,
"taskDurationMs": 86.54699999999998,
"heapDeltaBytes": 3221068,
"heapUsedBytes": 65439512,
"domNodes": 97,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.451999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 445.91000000002623,
"styleRecalcs": 13,
"styleRecalcDurationMs": 14.422,
"layouts": 3,
"layoutDurationMs": 0.992,
"taskDurationMs": 97.68300000000002,
"heapDeltaBytes": 4799288,
"heapUsedBytes": 66599144,
"domNodes": 99,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.481000000000002,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (11 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0ba399c212af8cbdd95ac2d347e1030474baf291
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #18093 +/- ##
==========================================
+ Coverage 84.07% 84.94% +0.87%
==========================================
Files 3161 2313 -848
Lines 154612 133800 -20812
Branches 41985 34306 -7679
==========================================
- Hits 129989 113660 -16329
+ Misses 23019 19822 -3197
+ Partials 1604 318 -1286
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 867 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Not trivial — the fix would break an existing, deliberately-pinned testI read the diff, the two new failing unit tests, and the shared measured-size cache ( The conflicting test
node.size = [100, 50]
layoutStore.reportContentSize(graph.rootGraph.id, node.id, { width: 225, height: 80 })
expect([...node.size]).toEqual([100, 50]) // requested size is untouched by content
node.setSize([node.size[0] + 90, node.size[1] + 100]) // explicit resize to [190, 150]
expect([...node.renderingSize]).toEqual([225, 150]) // width still floored by the OLD content measurement (225 > 190)This asserts, on purpose, that Why this blocks PM-1304's fix
Both tests exercise the same code path (
In other words, "explicit resize should always be able to override a stale content measurement" and "a content measurement, once reported, keeps flooring rendered size independent of later explicit resizes" are the same mechanism asked to do both jobs. Reconciling them needs a real design change (e.g., invalidating/re-deriving the content floor specifically off a fresh remeasurement tied to the node's current content, not the last one reported) rather than a small tweak to The PM-1312 tab-switch-spread symptom rides on the same mechanism: No code changes made. Leaving the Generated by Claude Code |
…pread A Vue-rendered node whose autogrow content (e.g. Flux2ImageNode's reference image slots) has grown past its explicit size can only be resized larger from then on: refreshNodeGeometry renders Math.max(explicitSize, contentSize), a floor that never decreases. Switching browser tabs away and back force-remeasures every node sharing the module-level ResizeObserver singleton in useVueNodeResizeTracking.ts in one batch, spreading the same ratchet to nodes the user never touched. Adds failing regression coverage only, annotated with test.fail() / it.fails() so CI stays green now and flips to an unexpected-pass alert once a real fix lands. No fix code included.
f132798 to
7f2296b
Compare
This comment has been minimized.
This comment has been minimized.
|
@coderabbitai review |
|
Follow-up at |
|
1 similar comment
|
…#19081) Manual backport of #18093 to core/1.54. The release conflict was limited to slot-offset cleanup introduced after this branch; the resize/content-size fix and exact regression coverage are retained while preserving the release branch cleanup contract. Justification: verified PM-1304 / PM-1312 regression fix. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
#19082) Manual completion of the clean #18093 cherry-pick to cloud/1.54 after the combined automation rolled the branch back when core conflicted. Justification: verified PM-1304 / PM-1312 regression fix with exact browser coverage. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
…8093) ## Summary - Let an explicit node resize override a stale content-size measurement so an auto-grown Flux2ImageNode can shrink again. - Preserve ResizeObserver measurements across hidden/visible tab transitions; genuinely changed nodes re-report, unchanged siblings do not. - Convert the existing PM-1304 / PM-1312 expected-failure unit, observer, and real-browser regressions into passing assertions. Linear: PM-1304, PM-1312 ## Test plan - `pnpm exec vitest run src/renderer/core/layout/operations/graphLayoutAttachment.test.ts src/renderer/extensions/vueNodes/composables/useVueNodeResizeTracking.test.ts` (18 passed) - Full app and browser typechecks via pre-commit - ESLint, oxlint, and oxfmt via pre-commit - CI runs the two real Flux2ImageNode Playwright cases against cloud Justification: confirmed fix for the two linked resize regressions, with red-before/green-after coverage already present on this PR. --------- Co-authored-by: bymyself <cbyrne@comfy.org> (cherry picked from commit 0e8b66a) (cherry picked from commit d6de74a)
## Summary Consolidates the verified fixes that landed on `cloud/1.54` but were absent from `cloud/1.55`: - #17486 keeps promoted dynamic-combo child links when loading workflows. - #18599 gives unified-remint retries a fresh timeout window. - #18093 allows nodes to shrink after content growth and tab switches. - #18155 resolves stale Agent bindings when workflows share a name. - #18693 keeps the Agent target aligned with the visible workflow until send or node reference. - #18619 waits for open dialogs before showing Agent consent. - #18061 deselects a node when its composer reference is removed. - #18392 marks video reply assets correctly. - #18664 records Agent panel visibility and page-hide teardown correctly. - #18911 restores Agent onboarding focus, navigation, and replay behavior. - #18911 remains deliberately excluded: its activation-telemetry substrate is cloud/1.54-only, and the original backport records that scope. This is the consolidated `cloud/1.55` carrier from the 1.54→1.55 release audit. The already-open saved-workflow backport remains in #19732 and is intentionally not duplicated here. ## Validation - Release-branch conflicts were resolved against the current cloud/1.55 Agent targeting, consent, and onboarding implementations. - CI is the authoritative full suite. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: dante01yoon <bunggl@naver.com> Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: Hunter <huntcsg@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
…8093) ## Summary - Let an explicit node resize override a stale content-size measurement so an auto-grown Flux2ImageNode can shrink again. - Preserve ResizeObserver measurements across hidden/visible tab transitions; genuinely changed nodes re-report, unchanged siblings do not. - Convert the existing PM-1304 / PM-1312 expected-failure unit, observer, and real-browser regressions into passing assertions. Linear: PM-1304, PM-1312 ## Test plan - `pnpm exec vitest run src/renderer/core/layout/operations/graphLayoutAttachment.test.ts src/renderer/extensions/vueNodes/composables/useVueNodeResizeTracking.test.ts` (18 passed) - Full app and browser typechecks via pre-commit - ESLint, oxlint, and oxfmt via pre-commit - CI runs the two real Flux2ImageNode Playwright cases against cloud Justification: confirmed fix for the two linked resize regressions, with red-before/green-after coverage already present on this PR. --------- Co-authored-by: bymyself <cbyrne@comfy.org> (cherry picked from commit 0e8b66a)
## Summary Carries the fixes that landed on `core/1.54` but were absent from `core/1.55`: - #17486 keeps promoted dynamic-combo child links when loading workflows. - #18599 gives unified-remint retries a fresh timeout window. - #18093 allows nodes to shrink after content growth and tab switches. - #18155 resolves stale Agent bindings when workflows share a name. - #18693 keeps the Agent target aligned with the visible workflow until send or node reference. - #18619 waits for open dialogs before showing Agent consent. - #18061 deselects a node when its composer reference is removed. - #18392 marks video reply assets correctly. This is the consolidated `core/1.55` carrier from the 1.54→1.55 release audit. ## Validation - Cherry-picks applied cleanly except for release-branch adaptations in Agent consent and workflow targeting. - Local typecheck is running; CI is the authoritative full suite. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: dante01yoon <bunggl@naver.com> Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: GitHub Action <action@github.com>
Summary
Linear: PM-1304, PM-1312
Test plan
pnpm exec vitest run src/renderer/core/layout/operations/graphLayoutAttachment.test.ts src/renderer/extensions/vueNodes/composables/useVueNodeResizeTracking.test.ts(18 passed)Justification: confirmed fix for the two linked resize regressions, with red-before/green-after coverage already present on this PR.