Repository navigation
[backport cloud/1.54] fix: reject malformed subgraph links before unpacking - #18056
CodeJuggernaut wants to merge 2 commits into
Conversation
…kport) (#17406) Backport of #17330 to the 1.53 release line. - Rejects malformed subgraph links before unpacking instead of throwing mid-conversion. - Last remaining item from the ECS follow-up list; needed on 1.53 before GA. - Cherry-pick resolved by hand; details below. <details><summary>Full context for agent readers</summary> Source: #17330 (merged to main as c8ddb60). Conflict resolution on this branch: - `useSubgraphOperations.ts`: kept the 1.53 `let changed` / `if (changed) workflowStore.activeWorkflow?.changeTracker.captureCanvasState()` structure; only the malformed-link guard was ported. - `SubgraphConversion.test.ts`: kept the 1.53-only `useWidgetValueStore` import. The new assertion uses `toBeUndefined()` rather than `toBeNull()` because `LGraph.getNodeById` returns `undefined` on 1.53 (main returns `null`). No change to `getNodeById` itself on this branch. Verification: `pnpm typecheck` clean; `SubgraphConversion.test.ts` 25/25 passing in the worktree. <!-- authored-by:agent supreme-operator w3-w41 --> </details> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎭 Playwright: ✅ 1922 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-19T01:37:02.012Z",
"gitSha": "5a7bc3d8a5bed863aeb669f15fcdc24d836b98c3",
"branch": "backport-17406-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.2090000000221,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.697,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.19599999999997,
"heapDeltaBytes": -8650968,
"heapUsedBytes": 60759736,
"domNodes": -278,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 5.9300000000000015,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2016.933999999992,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.387,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 287.682,
"heapDeltaBytes": -9357628,
"heapUsedBytes": 60007948,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 5.324000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1704.8690000000022,
"styleRecalcs": 74,
"styleRecalcDurationMs": 25.431,
"layouts": 14,
"layoutDurationMs": 4.069,
"taskDurationMs": 518.501,
"heapDeltaBytes": 8330592,
"heapUsedBytes": 77723708,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 93.247,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1745.1859999999897,
"styleRecalcs": 74,
"styleRecalcDurationMs": 25.65,
"layouts": 14,
"layoutDurationMs": 3.922,
"taskDurationMs": 554.299,
"heapDeltaBytes": -2223680,
"heapUsedBytes": 67949280,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 99.806,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1671.2640000000079,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.981,
"layouts": 6,
"layoutDurationMs": 0.8579999999999999,
"taskDurationMs": 230.61200000000002,
"heapDeltaBytes": 4404404,
"heapUsedBytes": 74884704,
"domNodes": 80,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6.944000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1659.008999999969,
"styleRecalcs": 29,
"styleRecalcDurationMs": 11.826999999999998,
"layouts": 6,
"layoutDurationMs": 1.0219999999999998,
"taskDurationMs": 208.51100000000002,
"heapDeltaBytes": 5124656,
"heapUsedBytes": 76133196,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 6.695000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 399.879999999996,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.9830000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 276.671,
"heapDeltaBytes": -7756336,
"heapUsedBytes": 62965356,
"domNodes": 18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 99.867,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 427.08399999997937,
"styleRecalcs": 14,
"styleRecalcDurationMs": 6.976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 279.21299999999997,
"heapDeltaBytes": -7866156,
"heapUsedBytes": 62792112,
"domNodes": 22,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 95.641,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2014.095000000026,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.563,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 320.44100000000003,
"heapDeltaBytes": 11000840,
"heapUsedBytes": 87394924,
"domNodes": -264,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 18.538,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2010.6930000000034,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.103000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.049,
"heapDeltaBytes": 22223136,
"heapUsedBytes": 87308452,
"domNodes": -266,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 18.325,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2076.1629999999795,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.728000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 959.071,
"heapDeltaBytes": 23185432,
"heapUsedBytes": 89306376,
"domNodes": -264,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 500.24,
"eventListeners": -140,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2097.1150000000307,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.319999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 984.3729999999999,
"heapDeltaBytes": 22067616,
"heapUsedBytes": 87360008,
"domNodes": -269,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 509.363,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3079.3760000000248,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.481,
"layouts": 60,
"layoutDurationMs": 11.893999999999998,
"taskDurationMs": 1065.8410000000001,
"heapDeltaBytes": -1970956,
"heapUsedBytes": 76777312,
"domNodes": -270,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 485.82900000000006,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3065.4690000000073,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.47,
"layouts": 60,
"layoutDurationMs": 11.861,
"taskDurationMs": 1050.192,
"heapDeltaBytes": 12026440,
"heapUsedBytes": 80323060,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 485.39400000000006,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2271.1950000000343,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.710999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1233.8749999999998,
"heapDeltaBytes": 14962748,
"heapUsedBytes": 82155148,
"domNodes": 8,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 624.993,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2167.488999999989,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.807,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1156.4010000000003,
"heapDeltaBytes": 18804172,
"heapUsedBytes": 86026864,
"domNodes": 6,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 574.295,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2010.8269999999493,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.3889999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 320.22200000000004,
"heapDeltaBytes": 10884580,
"heapUsedBytes": 87989748,
"domNodes": -264,
"jsHeapTotalBytes": -2985984,
"scriptDurationMs": 17.643,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2053.982000000019,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.991999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.89000000000004,
"heapDeltaBytes": 8455400,
"heapUsedBytes": 85804716,
"domNodes": -262,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 26.072000000000006,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 411.58799999999474,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.252,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 259.277,
"heapDeltaBytes": 13645216,
"heapUsedBytes": 86206780,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 89.084,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 413.0749999999921,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.684,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 259.559,
"heapDeltaBytes": 14294816,
"heapUsedBytes": 86266220,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 90.885,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1992.2289999999805,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.792,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 284.18,
"heapDeltaBytes": -2495424,
"heapUsedBytes": 69796000,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 4.733,
"eventListeners": -218,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.2460000000465,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.289,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 290.115,
"heapDeltaBytes": -878804,
"heapUsedBytes": 71468528,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 4.678,
"eventListeners": -218,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.1400000000008,
"styleRecalcs": 79,
"styleRecalcDurationMs": 25.939000000000004,
"layouts": 18,
"layoutDurationMs": 4.448,
"taskDurationMs": 516.5419999999999,
"heapDeltaBytes": 270180,
"heapUsedBytes": 72981080,
"domNodes": -293,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 72.811,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.6269999999645,
"styleRecalcs": 81,
"styleRecalcDurationMs": 33.761,
"layouts": 18,
"layoutDurationMs": 5.877999999999999,
"taskDurationMs": 566.1350000000001,
"heapDeltaBytes": -1804776,
"heapUsedBytes": 70244264,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 81.79400000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 783.6409999999887,
"styleRecalcs": 20,
"styleRecalcDurationMs": 20.168999999999993,
"layouts": 16,
"layoutDurationMs": 9.764,
"taskDurationMs": 535.0950000000001,
"heapDeltaBytes": -7241480,
"heapUsedBytes": 82758640,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 17.703000000000003,
"eventListeners": 2385,
"totalBlockingTimeMs": 58,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8165.341000000012,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.867,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3565.553,
"heapDeltaBytes": 5194940,
"heapUsedBytes": 81462588,
"domNodes": -266,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 1758.2220000000002,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8221.674000000006,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.656,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3561.803,
"heapDeltaBytes": 9580404,
"heapUsedBytes": 85731452,
"domNodes": -265,
"jsHeapTotalBytes": 1171456,
"scriptDurationMs": 1735.0240000000001,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10796.32799999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10020.244,
"heapDeltaBytes": -21219188,
"heapUsedBytes": 182599472,
"domNodes": -6548,
"jsHeapTotalBytes": 9396224,
"scriptDurationMs": 139.202,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10519.920000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9671.281,
"heapDeltaBytes": -14803692,
"heapUsedBytes": 174524652,
"domNodes": -6548,
"jsHeapTotalBytes": -2371584,
"scriptDurationMs": 151.13199999999998,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13833.022999999968,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.267,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13244.544999999998,
"heapDeltaBytes": -32867312,
"heapUsedBytes": 171107524,
"domNodes": -6548,
"jsHeapTotalBytes": 12046336,
"scriptDurationMs": 570.077,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13954.216999999971,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.239,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13454.999000000002,
"heapDeltaBytes": -43742452,
"heapUsedBytes": 164353288,
"domNodes": -6548,
"jsHeapTotalBytes": -2981888,
"scriptDurationMs": 560.476,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3899.766999999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.24399999999998,
"layouts": 20,
"layoutDurationMs": 17.607,
"taskDurationMs": 3749.6860000000006,
"heapDeltaBytes": -32970476,
"heapUsedBytes": 182160060,
"domNodes": -6548,
"jsHeapTotalBytes": 3104768,
"scriptDurationMs": 60.26699999999999,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3972.221999999988,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.57900000000001,
"layouts": 20,
"layoutDurationMs": 17.560000000000006,
"taskDurationMs": 3798.975,
"heapDeltaBytes": -26194648,
"heapUsedBytes": 184016200,
"domNodes": -6548,
"jsHeapTotalBytes": 9760768,
"scriptDurationMs": 58.882000000000005,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5325.910000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4984.291000000001,
"heapDeltaBytes": 4955164,
"heapUsedBytes": 189289716,
"domNodes": 0,
"jsHeapTotalBytes": -12582912,
"scriptDurationMs": 68.573,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5253.66600000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4829.049999999999,
"heapDeltaBytes": -659496,
"heapUsedBytes": 174706680,
"domNodes": 0,
"jsHeapTotalBytes": -8650752,
"scriptDurationMs": 77.93100000000003,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 84.14300000004005,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.076000000000002,
"layouts": 3,
"layoutDurationMs": 1.5810000000000002,
"taskDurationMs": 57.518,
"heapDeltaBytes": 3325636,
"heapUsedBytes": 71141552,
"domNodes": 142,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.758,
"eventListeners": 38,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 425.1289999999699,
"styleRecalcs": 15,
"styleRecalcDurationMs": 16.24,
"layouts": 3,
"layoutDurationMs": 0.8250000000000001,
"taskDurationMs": 70.22200000000001,
"heapDeltaBytes": 4805708,
"heapUsedBytes": 73986644,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.904,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #18056 +/- ##
=============================================
Coverage ? 83.06%
=============================================
Files ? 2057
Lines ? 120466
Branches ? 31389
=============================================
Hits ? 100060
Misses ? 20230
Partials ? 176
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
cloud/1.54 normalises a missing id to null in getNodeById via `?? null` while cloud/1.53 returns undefined, so the backported toBeUndefined() assertion fails on this line. toBeFalsy() is this branch's own convention for the same call in LGraph.compoundUndo.test.ts and LGraphCanvas.ghost.test.ts, and it holds on both release lines.
6c012df to
3a4b7e6
Compare
dante01yoon
left a comment
There was a problem hiding this comment.
Approving. I verified the backport mechanically rather than by eye, since the interesting question for a cherry-pick is what came along with the fix.
Diff fidelity. I diffed this PR's full patch against #17406 (the cloud/1.53 carrier) with index and hunk headers stripped. They are identical except for exactly the two lines the description names:
useSubgraphOperations.ts: the removed line differs (changeTracker?.captureCanvasState()on 1.53 vschangeTracker.captureCanvasState()on 1.54). The addedif (changed) { ... }block is byte-identical, so the conflict resolution really did take only the incoming deletion.SubgraphConversion.test.ts:354:toBeUndefined()->toBeFalsy().
Nothing else drifted, so the fix itself — findUnresolvableSubgraphLink, the boolean return from LGraph.unpackSubgraph, the changed gate, and the revokeSubgraphPreviews(node, graph) signature — arrives unmodified.
What else rode along. Diffing against #17330 (the original on main) shows useSubgraphOperations.test.ts carries a whole-file mocking-style rewrite that was not part of #17330: main had already moved off the vi.hoisted + per-store vi.mock block, so the original only appended two tests, while this branch still had the old style and the cherry-pick brings the conversion with it. That rewrite depends on branch test infrastructure the fix does not (global store auto-mocking so vi.mocked(useSubgraphStore().publishSubgraph) works, @total-typescript/shoehorn, and the vi.mock(import(...)) literal form). The test and lint-and-format jobs are green on this head, so that infrastructure does exist on cloud/1.54 and the four pre-existing addSubgraphToLibrary assertions survive the rewrite intact. Worth knowing it is in there, but it does not change what is covered.
Call sites. revokeSubgraphPreviews has no callers outside nodeOutputStore.ts and useSubgraphOperations.*, so the one-arg -> two-arg change has no unmigrated consumer.
One non-blocking inline note on the adapted assertion.
| assert(innerNode1.connect(0, innerNode2, 0)) | ||
|
|
||
| expect(graph.unpackSubgraph(subgraphNode)).toBe(true) | ||
| expect(graph.getNodeById(subgraphNode.id)).toBeFalsy() |
There was a problem hiding this comment.
suggestion: I think toBeNull() is available here, and it is what the original wrote.
The description reasons from the cloud/1.53 carrier, where this line arrived as toBeUndefined(). But #17330 on main wrote toBeNull(), and LGraph.getNodeById on cloud/1.54 is id != null && id !== UNASSIGNED_NODE_ID ? (this._nodes_by_id[id] ?? null) : null (LGraph.ts:1586-1590) — the ?? null you cite is exactly what makes this branch agree with main rather than with 1.53. So toBeNull() passes here and keeps the backport identical to the original on this line, instead of introducing a third variant.
Practically this is cosmetic: toBeFalsy() still fails if the node survives the unpack, which is what the test guards. It is just that toBeNull() is both stricter and the smaller diff against main, which is usually what you want a backport to be. The compoundUndo/ghost convention argument is fair if you would rather keep the branch internally consistent — happy either way, flagging mainly because the premise that null forced the relaxation is not quite right.
|
this carrier is superseded by the merged catalogue-wide cloud/1.54 backport, whose integration records this carrier as the provenance for source PR 17330 and carries its target-native integration as commit |
Backport of #17330 to
cloud/1.54, cherry-picked from the cloud/1.53 backport #17406.Conflict, one file.
src/composables/graph/useSubgraphOperations.ts: cloud/1.54 still carried the unconditionalcaptureCanvasState()that this fix replaces with thechanged-gated call. Took the incoming deletion, so the resulting diff is the fix and nothing else.One test assertion adapted to this line.
SubgraphConversion.test.ts:354came over astoBeUndefined()and failed here. cloud/1.54 normalises a missing id tonullinLGraph.getNodeByIdvia?? null, while cloud/1.53 returnsundefined. Changed totoBeFalsy(), which is this branch's own convention for the same call inLGraph.compoundUndo.test.tsandLGraphCanvas.ghost.test.ts, and which holds on both release lines.getNodeByIditself is untouched by this backport.🤖 Generated with Claude Code