Skip to content

[backport cloud/1.54] fix(telemetry): preserve assertion diagnostic fidelity - #18057

Closed
CodeJuggernaut wants to merge 1 commit into
cloud/1.54from
backport-15671-to-cloud-1.54
Closed

CodeJuggernaut wants to merge 1 commit into
cloud/1.54from
backport-15671-to-cloud-1.54

Conversation

@CodeJuggernaut

Copy link
Copy Markdown
Contributor

Backport of #15671 to cloud/1.54. The cloud/1.53 carrier for this fix is #17427, but that PR bundles 21 files beyond the fix, so this is cherry-picked from #15671's own squash instead.

Three conflicts, all because cloud/1.54 does not carry the logToConsole console-echo option that main and cloud/1.53 have:

  • assertFailureReporter.ts and its test: kept context: { ...context, occurrenceCount }, dropped logToConsole: false. On cloud/1.54 reportError writes no caller-facing console line and the option is not in ReportErrorOptions, so the flag has nothing to suppress.
  • reportError.test.ts: kept this branch's tests and added only the three cloud-delivery tests fix(telemetry): preserve assertion diagnostic fidelity #15671 introduces. The four console-echo tests inside the conflict are pre-existing on main, not part of this fix.

11 of the 13 files match #15671's own +/- tallies exactly. The two that differ are the logToConsole lines above.

🤖 Generated with Claude Code

Preserve actionable diagnostics for assertion failures across Sentry and
Datadog, completing the review follow-up from #16333 without changing
assertion message grouping.

- **Structured diagnostics**: `assert()` accepts optional context and
forwards `found`, `specName`, node ID, and root graph ID from the
reviewed invariant sites.
- **Recurrence signal**: repeated assertions emit at coarse counts 1,
10, 100, and 1000 while retaining the 20-distinct-message bound.
- **Cloud delivery**: when Sentry initializes before Datadog RUM,
`reportError` still queues the RUM leg without sending a duplicate
Sentry event.
- **Privacy boundary**: this does not automatically restore
`workflowPath`; that remains deliberately excluded pending a separate
privacy decision.

Please review sink-specific delivery state in `reportError` and the
structured context emitted by graph/schema assertions.

Follow-up to #16333.

- `pnpm vitest run src/base/assert.test.ts
src/platform/telemetry/assertFailureReporter.test.ts
src/platform/telemetry/reportError.test.ts
src/schemas/nodeDef/inputSpecUtil.test.ts
src/workbench/extensions/agent/crdt/schemaGuard.test.ts
src/core/graph/nodeShell/nodeShellState.test.ts` — 6 files, 42 tests
passed.
- `pnpm vitest run src/base/assert.test.ts
src/platform/telemetry/assertFailureReporter.test.ts
src/platform/telemetry/reportError.test.ts` — repeat run: 3 files, 22
tests passed.
- `pnpm typecheck` — passed.
- Targeted ESLint and oxfmt checks over all 13 changed files — passed.
- Pre-commit hooks: lint-staged formatting, full lint, typecheck, and
knip passed.
- `git diff --check origin/main` — passed.

<!-- authored-by:agent lane-act-fe-16333-followup -->

---------

Co-authored-by: Glary Bot <bot@comfy.org>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Amp <amp@ampcode.com>
@CodeJuggernaut CodeJuggernaut added the backport Backporting a PR onto a release candidate label Sep 19, 2026
@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 19, 2026 12:54am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 7dc15da3-bd80-43a4-9a4c-e2200cf1343c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1922 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1901 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/19/2026, 12:55:49 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 141ms TBT · 80.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.6 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 86ms TBT · 182.8 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 478ms TBT · 171.7 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.3 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 497ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 58.7 MB
canvas-idle: DOM nodes -279
canvas-idle: event listeners -159
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 40ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 957ms
canvas-mouse-sweep: script duration 168ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 66.1 MB
canvas-mouse-sweep: DOM nodes -277
canvas-mouse-sweep: event listeners -159
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 349ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.5 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 451ms
dom-widget-clipping: script duration 161ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.2 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 616ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 84.0 MB
large-graph-idle: DOM nodes -278
large-graph-idle: event listeners -159
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 8ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 63
large-graph-pan: task duration 1623ms
large-graph-pan: script duration 832ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 83.9 MB
large-graph-pan: DOM nodes -138
large-graph-pan: event listeners 6
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 9ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1685ms
large-graph-zoom: script duration 779ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.1 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1951ms
legacy-node-drag: script duration 985ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 87.0 MB
legacy-node-drag: DOM nodes 1
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 566ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.2 MB
minimap-idle: DOM nodes -269
minimap-idle: event listeners -174
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 411ms
subgraph-dom-widget-clipping: script duration 142ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.2 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 487ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 65.8 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -220
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 37ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 817ms
subgraph-mouse-sweep: script duration 106ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 73.7 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -221
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 915ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 141ms
subgraph-transition-enter: heap used 80.1 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5830ms
viewport-pan-sweep: script duration 2727ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.3 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -157
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16194ms
vue-large-graph-idle: script duration 278ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 167.6 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7475
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 172
vue-large-graph-pan: task duration 20913ms
vue-large-graph-pan: script duration 997ms
vue-large-graph-pan: TBT 86ms
vue-large-graph-pan: heap used 182.8 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7468
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 84ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6045ms
vue-node-resize-workload: script duration 111ms
vue-node-resize-workload: TBT 478ms
vue-node-resize-workload: heap used 171.7 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7471
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8306ms
vue-zoom-out-idle: script duration 137ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 172.3 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -13
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 14ms
workflow-execution: layout count 2
workflow-execution: style recalc count 8
workflow-execution: task duration 81ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.7 MB
workflow-execution: DOM nodes 118
workflow-execution: event listeners 25
Raw data
{
  "timestamp": "2026-09-19T01:05:08.653Z",
  "gitSha": "b814d00f2cc20443ea8962a3a758ae94edafc9a7",
  "branch": "backport-15671-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2021.7369999999732,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.405000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 508.065,
      "heapDeltaBytes": -5283176,
      "heapUsedBytes": 63944988,
      "domNodes": -279,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 8.360999999999997,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2038.6589999999956,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.802999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 485.38499999999993,
      "heapDeltaBytes": -11633712,
      "heapUsedBytes": 59225456,
      "domNodes": -278,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.628999999999997,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2058.232999999973,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 45.299,
      "layouts": 14,
      "layoutDurationMs": 4.536999999999999,
      "taskDurationMs": 1046.037,
      "heapDeltaBytes": 6205512,
      "heapUsedBytes": 76899328,
      "domNodes": -275,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 181.97,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1842.7329999999529,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 35.437000000000005,
      "layouts": 14,
      "layoutDurationMs": 4.16,
      "taskDurationMs": 868.192,
      "heapDeltaBytes": -8996740,
      "heapUsedBytes": 61797828,
      "domNodes": -279,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 154.567,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1706.6930000000298,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.488,
      "layouts": 6,
      "layoutDurationMs": 0.9400000000000001,
      "taskDurationMs": 346.951,
      "heapDeltaBytes": 5017508,
      "heapUsedBytes": 75919428,
      "domNodes": 75,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 10.304999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.9970000001013,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.323999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.9959999999999999,
      "taskDurationMs": 351.84999999999997,
      "heapDeltaBytes": 4952584,
      "heapUsedBytes": 76042988,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 9.889,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 678.0600000000163,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.363999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 463.86699999999996,
      "heapDeltaBytes": -8181160,
      "heapUsedBytes": 62727636,
      "domNodes": 18,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 162.03900000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 660.6199999999944,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.19,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 438.338,
      "heapDeltaBytes": 18506552,
      "heapUsedBytes": 88670360,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 159.37699999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2053.634000000045,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.925999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 619.4940000000001,
      "heapDeltaBytes": 9277656,
      "heapUsedBytes": 85327728,
      "domNodes": -273,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 35.35400000000001,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2032.1900000000142,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.086,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 612.962,
      "heapDeltaBytes": -4880568,
      "heapUsedBytes": 90902400,
      "domNodes": -282,
      "jsHeapTotalBytes": 3080192,
      "scriptDurationMs": 33.927,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2222.200999999984,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 7.523999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1598.5510000000002,
      "heapDeltaBytes": 22640824,
      "heapUsedBytes": 88686580,
      "domNodes": -278,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 812.84,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2258.762000000047,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 8.498999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1647.73,
      "heapDeltaBytes": 20784452,
      "heapUsedBytes": 87295516,
      "domNodes": 2,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 851.715,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3522.890000000018,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.489000000000004,
      "layouts": 60,
      "layoutDurationMs": 12.031,
      "taskDurationMs": 1697.1540000000002,
      "heapDeltaBytes": 8610696,
      "heapUsedBytes": 75464208,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 781.0859999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3576.4919999999165,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.384,
      "layouts": 60,
      "layoutDurationMs": 11.559999999999999,
      "taskDurationMs": 1673.4329999999998,
      "heapDeltaBytes": 8125052,
      "heapUsedBytes": 75670292,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 776.9350000000001,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3126.8329999999764,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.395999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1937.2029999999997,
      "heapDeltaBytes": 24714408,
      "heapUsedBytes": 92601964,
      "domNodes": 2,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 968.9859999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3146.6279999999642,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.698999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1965.626,
      "heapDeltaBytes": 22123680,
      "heapUsedBytes": 89947324,
      "domNodes": 0,
      "jsHeapTotalBytes": 1990656,
      "scriptDurationMs": 1001.686,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2010.5849999999919,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 6.097999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 545.6419999999999,
      "heapDeltaBytes": 21147300,
      "heapUsedBytes": 86924356,
      "domNodes": -271,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 34.60200000000001,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2041.5570000000116,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.608000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 586.467,
      "heapDeltaBytes": 10603068,
      "heapUsedBytes": 87557360,
      "domNodes": -267,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 31.51899999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 620.2590000000328,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.414000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 416.17799999999994,
      "heapDeltaBytes": 15151352,
      "heapUsedBytes": 88059248,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 142.90699999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 595.470999999975,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.361,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 405.794,
      "heapDeltaBytes": 14315824,
      "heapUsedBytes": 86358336,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 141.475,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2015.5080000000112,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.457999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 484.86899999999997,
      "heapDeltaBytes": -3284184,
      "heapUsedBytes": 69017056,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.365999999999998,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.387999999978,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.139999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 489.308,
      "heapDeltaBytes": -3275056,
      "heapUsedBytes": 69028068,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.768999999999998,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1725.6479999999783,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 37.494,
      "layouts": 18,
      "layoutDurationMs": 5.734,
      "taskDurationMs": 819.082,
      "heapDeltaBytes": 11136092,
      "heapUsedBytes": 82847300,
      "domNodes": -294,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 107.57900000000001,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1718.4270000000197,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 35.69700000000001,
      "layouts": 18,
      "layoutDurationMs": 4.829,
      "taskDurationMs": 814.3770000000001,
      "heapDeltaBytes": -669196,
      "heapUsedBytes": 71673868,
      "domNodes": -295,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 105.087,
      "eventListeners": -222,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1383.655000000033,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 31.912000000000003,
      "layouts": 16,
      "layoutDurationMs": 15.605999999999998,
      "taskDurationMs": 914.9260000000002,
      "heapDeltaBytes": -9214788,
      "heapUsedBytes": 83999140,
      "domNodes": 13751,
      "jsHeapTotalBytes": 12845056,
      "scriptDurationMs": 29.41,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 141,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8402.694999999994,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 34.194,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5864.033,
      "heapDeltaBytes": 9053880,
      "heapUsedBytes": 85390560,
      "domNodes": -269,
      "jsHeapTotalBytes": -1187840,
      "scriptDurationMs": 2756.0559999999996,
      "eventListeners": -158,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8450.554000000011,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 36.472,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5796.378,
      "heapDeltaBytes": 13088896,
      "heapUsedBytes": 89233392,
      "domNodes": -270,
      "jsHeapTotalBytes": -925696,
      "scriptDurationMs": 2698.375,
      "eventListeners": -156,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16751.52300000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16234.124000000002,
      "heapDeltaBytes": -35753648,
      "heapUsedBytes": 174807048,
      "domNodes": -6548,
      "jsHeapTotalBytes": -7778304,
      "scriptDurationMs": 289.194,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16721.720000000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16154.692999999997,
      "heapDeltaBytes": -40129728,
      "heapUsedBytes": 176727216,
      "domNodes": -6548,
      "jsHeapTotalBytes": 4706304,
      "scriptDurationMs": 267.12399999999997,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21251.54900000001,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 19.572000000000035,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20910.687,
      "heapDeltaBytes": -19132216,
      "heapUsedBytes": 191657284,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3653632,
      "scriptDurationMs": 946.663,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 68,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21320.66099999997,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 18.97099999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20916.043,
      "heapDeltaBytes": -17038440,
      "heapUsedBytes": 191666760,
      "domNodes": -6548,
      "jsHeapTotalBytes": -1847296,
      "scriptDurationMs": 1046.5420000000001,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 104,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6159.066999999994,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 87.55000000000001,
      "layouts": 20,
      "layoutDurationMs": 24.770999999999987,
      "taskDurationMs": 6046.177999999999,
      "heapDeltaBytes": -22976992,
      "heapUsedBytes": 179914536,
      "domNodes": -6548,
      "jsHeapTotalBytes": 12570624,
      "scriptDurationMs": 115.201,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 530,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6165.576999999985,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.83999999999996,
      "layouts": 20,
      "layoutDurationMs": 22.863000000000007,
      "taskDurationMs": 6042.859000000001,
      "heapDeltaBytes": -25260184,
      "heapUsedBytes": 180182812,
      "domNodes": -6548,
      "jsHeapTotalBytes": 13619200,
      "scriptDurationMs": 106.85499999999999,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 426,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8547.215999999991,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8276.173000000003,
      "heapDeltaBytes": 19903600,
      "heapUsedBytes": 180338744,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 144.69699999999997,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8632.875000000013,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8335.418000000001,
      "heapDeltaBytes": 25795472,
      "heapUsedBytes": 181022688,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 130.04099999999997,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 106.20399999999108,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 13.972999999999999,
      "layouts": 3,
      "layoutDurationMs": 0.9780000000000001,
      "taskDurationMs": 80.597,
      "heapDeltaBytes": 3130156,
      "heapUsedBytes": 72057860,
      "domNodes": 109,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 6.653999999999998,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 114.90900000001147,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 14.385,
      "layouts": 1,
      "layoutDurationMs": 1.0010000000000001,
      "taskDurationMs": 82.20500000000001,
      "heapDeltaBytes": 2973864,
      "heapUsedBytes": 72020468,
      "domNodes": 127,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.850999999999999,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 49906 74639 66.9% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1159
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.1% 305
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.6% 261
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.8% 251
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 19, 2026
@codecov

codecov Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.72727% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/main.ts 0.00% 3 Missing ⚠️
src/platform/telemetry/reportError.ts 97.22% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #18057   +/-   ##
=============================================
  Coverage              ?   83.05%           
=============================================
  Files                 ?     2057           
  Lines                 ?   120472           
  Branches              ?    33199           
=============================================
  Hits                  ?   100054           
  Misses                ?    20242           
  Partials              ?      176           
Flag Coverage Δ
e2e 66.87% <51.61%> (?)
unit 77.69% <92.45%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/base/assert.ts 100.00% <100.00%> (ø)
src/core/graph/nodeShell/nodeShellState.ts 100.00% <100.00%> (ø)
src/platform/telemetry/assertFailureReporter.ts 100.00% <100.00%> (ø)
src/schemas/nodeDef/inputSpecUtil.ts 100.00% <ø> (ø)
src/workbench/extensions/agent/crdt/schemaGuard.ts 100.00% <ø> (ø)
src/platform/telemetry/reportError.ts 94.73% <97.22%> (ø)
src/main.ts 47.36% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the backport mechanically against #15671 and then looked at the telemetry surface on its own.

Backport fidelity — verified, and the description's numbers are exactly right. I tallied per-file +/- against #15671: 11 of 13 files match precisely, and the two that do not are assertFailureReporter.ts (21/8 here vs 20/7) and assertFailureReporter.test.ts (20/8 vs 21/8) — both accounted for by dropping logToConsole: false, plus a comma moving onto errorType because it was the last property on this branch. Diffing the full patches with index/hunk headers stripped, every other difference is a context line where the base files diverge, not a changed line: vi.mock('@sentry/vue', ...) vs the import-literal form, the writes the failure to the console so callers need no second sink block that only exists on main, and a doc comment above ReportErrorOptions. So reportError.ts, assert.ts, nodeShellState.ts, main.ts, inputSpecUtil.ts and schemaGuard.ts arrive byte-for-byte as merged.

Dropping logToConsole: false is the right call rather than a shortcut: ReportErrorOptions has no such field on this branch and reportError writes no caller-facing console line, so there is nothing to suppress. The message still reaches the console via assert's own unconditional console.error(formatted), which this PR does not touch.

No collision with #18056. That backport also targets cloud/1.54 and calls reportError(err, { errorType, context }) from LGraph.unpackSubgraph. ReportErrorOptions is unchanged here (only the internal PendingReport gains fields) and the two PRs share no files, so merge order does not matter.

Telemetry behaviour. The dedupe change is bounded in the right way: occurrenceCounts only accepts new keys below MAX_REPORTS_PER_SESSION, so the Map caps at 20 entries, and REPORTABLE_OCCURRENCE_COUNTS caps each message at 4 reports — worst case 80 per session against the previous 20, not a render-loop flood. The per-sink try/catch in dispatch is a real improvement: a throwing sink can no longer take out the other one or escape into the caller. On the cloud re-queue path, dispatch's sentryAlreadyDelivered / datadogAlreadyDelivered guards mean a re-flushed report is never double-sent to a sink that already took it, and enqueuePendingReport keeps the buffer at 25.

One inline question about the docblock change, which is the only thing I could not settle from the diff.

test and lint-and-format are green on 0fd0b75.

Comment thread src/base/assert.ts
* Reporters forward `message` to external telemetry, so it must be a static
* description of the invariant. Never interpolate user data (workflow names,
* paths, prompts) into it.
* description of the invariant. Put diagnostic values in `context` so they do

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: This rewrite drops the only written guard rail against user data reaching telemetry, and I would like to know whether that was deliberate.

The previous wording was Never interpolate user data (workflow names, paths, prompts) into it. The replacement keeps must be a static description of the invariant but reframes the reason as grouping/dedup hygiene, and says to put diagnostic values in context — without saying anything about what may go in context. The new test at assert.test.ts:60 then uses { workflowPath: 'a/b.json' } as the worked example, which is one of the exact value classes the removed sentence named as forbidden.

That matters because context is not inert: reportError forwards it to Sentry as extra and splats it into datadogRum.addError's attributes, so a workflow path would land in both sinks. Nothing in this diff actually does that — the four production call sites pass nodeId, previousRootGraphId / nextRootGraphId / rootGraphId, specName and found, all non-identifying — so this is about the contract the next caller will read, not a leak you are shipping.

To be clear, I am not asking you to change this PR: a backport should match main, and diverging here would be worse. The question is whether the context channel got the same privacy review the message channel had, and if not, whether it is worth restoring a sentence on main (something like "context reaches Sentry and Datadog — no prompts, paths, or user-authored names") and letting it flow down on the next backport. If that was already considered and workflowPath is accepted, then this is answered and I am happy.

@christian-byrne

Copy link
Copy Markdown
Contributor

this carrier is superseded by the merged catalogue-wide cloud/1.54 backport, whose integration records this carrier as the provenance for source PR 15671 and carries the same patch as integration commit d5bce0349093c896da5e1b2b441cbeace925e70d. Closing this duplicate avoids carrying the source twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants