Repository navigation
[backport cloud/1.54] fix(telemetry): preserve assertion diagnostic fidelity - #18057
CodeJuggernaut wants to merge 1 commit into
Conversation
Preserve actionable diagnostics for assertion failures across Sentry and Datadog, completing the review follow-up from #16333 without changing assertion message grouping. - **Structured diagnostics**: `assert()` accepts optional context and forwards `found`, `specName`, node ID, and root graph ID from the reviewed invariant sites. - **Recurrence signal**: repeated assertions emit at coarse counts 1, 10, 100, and 1000 while retaining the 20-distinct-message bound. - **Cloud delivery**: when Sentry initializes before Datadog RUM, `reportError` still queues the RUM leg without sending a duplicate Sentry event. - **Privacy boundary**: this does not automatically restore `workflowPath`; that remains deliberately excluded pending a separate privacy decision. Please review sink-specific delivery state in `reportError` and the structured context emitted by graph/schema assertions. Follow-up to #16333. - `pnpm vitest run src/base/assert.test.ts src/platform/telemetry/assertFailureReporter.test.ts src/platform/telemetry/reportError.test.ts src/schemas/nodeDef/inputSpecUtil.test.ts src/workbench/extensions/agent/crdt/schemaGuard.test.ts src/core/graph/nodeShell/nodeShellState.test.ts` — 6 files, 42 tests passed. - `pnpm vitest run src/base/assert.test.ts src/platform/telemetry/assertFailureReporter.test.ts src/platform/telemetry/reportError.test.ts` — repeat run: 3 files, 22 tests passed. - `pnpm typecheck` — passed. - Targeted ESLint and oxfmt checks over all 13 changed files — passed. - Pre-commit hooks: lint-staged formatting, full lint, typecheck, and knip passed. - `git diff --check origin/main` — passed. <!-- authored-by:agent lane-act-fe-16333-followup --> --------- Co-authored-by: Glary Bot <bot@comfy.org> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1922 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-19T01:05:08.653Z",
"gitSha": "b814d00f2cc20443ea8962a3a758ae94edafc9a7",
"branch": "backport-15671-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.7369999999732,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.405000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.065,
"heapDeltaBytes": -5283176,
"heapUsedBytes": 63944988,
"domNodes": -279,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.360999999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.6589999999956,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.802999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.38499999999993,
"heapDeltaBytes": -11633712,
"heapUsedBytes": 59225456,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.628999999999997,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2058.232999999973,
"styleRecalcs": 80,
"styleRecalcDurationMs": 45.299,
"layouts": 14,
"layoutDurationMs": 4.536999999999999,
"taskDurationMs": 1046.037,
"heapDeltaBytes": 6205512,
"heapUsedBytes": 76899328,
"domNodes": -275,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 181.97,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1842.7329999999529,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.437000000000005,
"layouts": 14,
"layoutDurationMs": 4.16,
"taskDurationMs": 868.192,
"heapDeltaBytes": -8996740,
"heapUsedBytes": 61797828,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 154.567,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.6930000000298,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.488,
"layouts": 6,
"layoutDurationMs": 0.9400000000000001,
"taskDurationMs": 346.951,
"heapDeltaBytes": 5017508,
"heapUsedBytes": 75919428,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.304999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.9970000001013,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.323999999999998,
"layouts": 6,
"layoutDurationMs": 0.9959999999999999,
"taskDurationMs": 351.84999999999997,
"heapDeltaBytes": 4952584,
"heapUsedBytes": 76042988,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.889,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 678.0600000000163,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.363999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.86699999999996,
"heapDeltaBytes": -8181160,
"heapUsedBytes": 62727636,
"domNodes": 18,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 162.03900000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 660.6199999999944,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.19,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.338,
"heapDeltaBytes": 18506552,
"heapUsedBytes": 88670360,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 159.37699999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2053.634000000045,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.925999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 619.4940000000001,
"heapDeltaBytes": 9277656,
"heapUsedBytes": 85327728,
"domNodes": -273,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 35.35400000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2032.1900000000142,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.086,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.962,
"heapDeltaBytes": -4880568,
"heapUsedBytes": 90902400,
"domNodes": -282,
"jsHeapTotalBytes": 3080192,
"scriptDurationMs": 33.927,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2222.200999999984,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.523999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1598.5510000000002,
"heapDeltaBytes": 22640824,
"heapUsedBytes": 88686580,
"domNodes": -278,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 812.84,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2258.762000000047,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.498999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1647.73,
"heapDeltaBytes": 20784452,
"heapUsedBytes": 87295516,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 851.715,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3522.890000000018,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.489000000000004,
"layouts": 60,
"layoutDurationMs": 12.031,
"taskDurationMs": 1697.1540000000002,
"heapDeltaBytes": 8610696,
"heapUsedBytes": 75464208,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 781.0859999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3576.4919999999165,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.384,
"layouts": 60,
"layoutDurationMs": 11.559999999999999,
"taskDurationMs": 1673.4329999999998,
"heapDeltaBytes": 8125052,
"heapUsedBytes": 75670292,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 776.9350000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3126.8329999999764,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.395999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1937.2029999999997,
"heapDeltaBytes": 24714408,
"heapUsedBytes": 92601964,
"domNodes": 2,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 968.9859999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3146.6279999999642,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.698999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1965.626,
"heapDeltaBytes": 22123680,
"heapUsedBytes": 89947324,
"domNodes": 0,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 1001.686,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2010.5849999999919,
"styleRecalcs": 4,
"styleRecalcDurationMs": 6.097999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.6419999999999,
"heapDeltaBytes": 21147300,
"heapUsedBytes": 86924356,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.60200000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2041.5570000000116,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.608000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.467,
"heapDeltaBytes": 10603068,
"heapUsedBytes": 87557360,
"domNodes": -267,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 31.51899999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 620.2590000000328,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.414000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.17799999999994,
"heapDeltaBytes": 15151352,
"heapUsedBytes": 88059248,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 142.90699999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.470999999975,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.361,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.794,
"heapDeltaBytes": 14315824,
"heapUsedBytes": 86358336,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 141.475,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2015.5080000000112,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.457999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.86899999999997,
"heapDeltaBytes": -3284184,
"heapUsedBytes": 69017056,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.365999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.387999999978,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.139999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.308,
"heapDeltaBytes": -3275056,
"heapUsedBytes": 69028068,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.768999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.6479999999783,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.494,
"layouts": 18,
"layoutDurationMs": 5.734,
"taskDurationMs": 819.082,
"heapDeltaBytes": 11136092,
"heapUsedBytes": 82847300,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 107.57900000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1718.4270000000197,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.69700000000001,
"layouts": 18,
"layoutDurationMs": 4.829,
"taskDurationMs": 814.3770000000001,
"heapDeltaBytes": -669196,
"heapUsedBytes": 71673868,
"domNodes": -295,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 105.087,
"eventListeners": -222,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.655000000033,
"styleRecalcs": 20,
"styleRecalcDurationMs": 31.912000000000003,
"layouts": 16,
"layoutDurationMs": 15.605999999999998,
"taskDurationMs": 914.9260000000002,
"heapDeltaBytes": -9214788,
"heapUsedBytes": 83999140,
"domNodes": 13751,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 29.41,
"eventListeners": 2385,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8402.694999999994,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.194,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5864.033,
"heapDeltaBytes": 9053880,
"heapUsedBytes": 85390560,
"domNodes": -269,
"jsHeapTotalBytes": -1187840,
"scriptDurationMs": 2756.0559999999996,
"eventListeners": -158,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8450.554000000011,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.472,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5796.378,
"heapDeltaBytes": 13088896,
"heapUsedBytes": 89233392,
"domNodes": -270,
"jsHeapTotalBytes": -925696,
"scriptDurationMs": 2698.375,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16751.52300000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16234.124000000002,
"heapDeltaBytes": -35753648,
"heapUsedBytes": 174807048,
"domNodes": -6548,
"jsHeapTotalBytes": -7778304,
"scriptDurationMs": 289.194,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16721.720000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16154.692999999997,
"heapDeltaBytes": -40129728,
"heapUsedBytes": 176727216,
"domNodes": -6548,
"jsHeapTotalBytes": 4706304,
"scriptDurationMs": 267.12399999999997,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21251.54900000001,
"styleRecalcs": 170,
"styleRecalcDurationMs": 19.572000000000035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20910.687,
"heapDeltaBytes": -19132216,
"heapUsedBytes": 191657284,
"domNodes": -6548,
"jsHeapTotalBytes": -3653632,
"scriptDurationMs": 946.663,
"eventListeners": -7469,
"totalBlockingTimeMs": 68,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21320.66099999997,
"styleRecalcs": 173,
"styleRecalcDurationMs": 18.97099999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20916.043,
"heapDeltaBytes": -17038440,
"heapUsedBytes": 191666760,
"domNodes": -6548,
"jsHeapTotalBytes": -1847296,
"scriptDurationMs": 1046.5420000000001,
"eventListeners": -7467,
"totalBlockingTimeMs": 104,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6159.066999999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.55000000000001,
"layouts": 20,
"layoutDurationMs": 24.770999999999987,
"taskDurationMs": 6046.177999999999,
"heapDeltaBytes": -22976992,
"heapUsedBytes": 179914536,
"domNodes": -6548,
"jsHeapTotalBytes": 12570624,
"scriptDurationMs": 115.201,
"eventListeners": -7471,
"totalBlockingTimeMs": 530,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6165.576999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.83999999999996,
"layouts": 20,
"layoutDurationMs": 22.863000000000007,
"taskDurationMs": 6042.859000000001,
"heapDeltaBytes": -25260184,
"heapUsedBytes": 180182812,
"domNodes": -6548,
"jsHeapTotalBytes": 13619200,
"scriptDurationMs": 106.85499999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 426,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8547.215999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8276.173000000003,
"heapDeltaBytes": 19903600,
"heapUsedBytes": 180338744,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 144.69699999999997,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8632.875000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8335.418000000001,
"heapDeltaBytes": 25795472,
"heapUsedBytes": 181022688,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 130.04099999999997,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 106.20399999999108,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.972999999999999,
"layouts": 3,
"layoutDurationMs": 0.9780000000000001,
"taskDurationMs": 80.597,
"heapDeltaBytes": 3130156,
"heapUsedBytes": 72057860,
"domNodes": 109,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 6.653999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 114.90900000001147,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.385,
"layouts": 1,
"layoutDurationMs": 1.0010000000000001,
"taskDurationMs": 82.20500000000001,
"heapDeltaBytes": 2973864,
"heapUsedBytes": 72020468,
"domNodes": 127,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.850999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #18057 +/- ##
=============================================
Coverage ? 83.05%
=============================================
Files ? 2057
Lines ? 120472
Branches ? 33199
=============================================
Hits ? 100054
Misses ? 20242
Partials ? 176
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed the backport mechanically against #15671 and then looked at the telemetry surface on its own.
Backport fidelity — verified, and the description's numbers are exactly right. I tallied per-file +/- against #15671: 11 of 13 files match precisely, and the two that do not are assertFailureReporter.ts (21/8 here vs 20/7) and assertFailureReporter.test.ts (20/8 vs 21/8) — both accounted for by dropping logToConsole: false, plus a comma moving onto errorType because it was the last property on this branch. Diffing the full patches with index/hunk headers stripped, every other difference is a context line where the base files diverge, not a changed line: vi.mock('@sentry/vue', ...) vs the import-literal form, the writes the failure to the console so callers need no second sink block that only exists on main, and a doc comment above ReportErrorOptions. So reportError.ts, assert.ts, nodeShellState.ts, main.ts, inputSpecUtil.ts and schemaGuard.ts arrive byte-for-byte as merged.
Dropping logToConsole: false is the right call rather than a shortcut: ReportErrorOptions has no such field on this branch and reportError writes no caller-facing console line, so there is nothing to suppress. The message still reaches the console via assert's own unconditional console.error(formatted), which this PR does not touch.
No collision with #18056. That backport also targets cloud/1.54 and calls reportError(err, { errorType, context }) from LGraph.unpackSubgraph. ReportErrorOptions is unchanged here (only the internal PendingReport gains fields) and the two PRs share no files, so merge order does not matter.
Telemetry behaviour. The dedupe change is bounded in the right way: occurrenceCounts only accepts new keys below MAX_REPORTS_PER_SESSION, so the Map caps at 20 entries, and REPORTABLE_OCCURRENCE_COUNTS caps each message at 4 reports — worst case 80 per session against the previous 20, not a render-loop flood. The per-sink try/catch in dispatch is a real improvement: a throwing sink can no longer take out the other one or escape into the caller. On the cloud re-queue path, dispatch's sentryAlreadyDelivered / datadogAlreadyDelivered guards mean a re-flushed report is never double-sent to a sink that already took it, and enqueuePendingReport keeps the buffer at 25.
One inline question about the docblock change, which is the only thing I could not settle from the diff.
test and lint-and-format are green on 0fd0b75.
| * Reporters forward `message` to external telemetry, so it must be a static | ||
| * description of the invariant. Never interpolate user data (workflow names, | ||
| * paths, prompts) into it. | ||
| * description of the invariant. Put diagnostic values in `context` so they do |
There was a problem hiding this comment.
question: This rewrite drops the only written guard rail against user data reaching telemetry, and I would like to know whether that was deliberate.
The previous wording was Never interpolate user data (workflow names, paths, prompts) into it. The replacement keeps must be a static description of the invariant but reframes the reason as grouping/dedup hygiene, and says to put diagnostic values in context — without saying anything about what may go in context. The new test at assert.test.ts:60 then uses { workflowPath: 'a/b.json' } as the worked example, which is one of the exact value classes the removed sentence named as forbidden.
That matters because context is not inert: reportError forwards it to Sentry as extra and splats it into datadogRum.addError's attributes, so a workflow path would land in both sinks. Nothing in this diff actually does that — the four production call sites pass nodeId, previousRootGraphId / nextRootGraphId / rootGraphId, specName and found, all non-identifying — so this is about the contract the next caller will read, not a leak you are shipping.
To be clear, I am not asking you to change this PR: a backport should match main, and diverging here would be worse. The question is whether the context channel got the same privacy review the message channel had, and if not, whether it is worth restoring a sentence on main (something like "context reaches Sentry and Datadog — no prompts, paths, or user-authored names") and letting it flow down on the next backport. If that was already considered and workflowPath is accepted, then this is answered and I am happy.
|
this carrier is superseded by the merged catalogue-wide cloud/1.54 backport, whose integration records this carrier as the provenance for source PR 15671 and carries the same patch as integration commit |
Backport of #15671 to
cloud/1.54. The cloud/1.53 carrier for this fix is #17427, but that PR bundles 21 files beyond the fix, so this is cherry-picked from #15671's own squash instead.Three conflicts, all because cloud/1.54 does not carry the
logToConsoleconsole-echo option that main and cloud/1.53 have:assertFailureReporter.tsand its test: keptcontext: { ...context, occurrenceCount }, droppedlogToConsole: false. On cloud/1.54reportErrorwrites no caller-facing console line and the option is not inReportErrorOptions, so the flag has nothing to suppress.reportError.test.ts: kept this branch's tests and added only the three cloud-delivery tests fix(telemetry): preserve assertion diagnostic fidelity #15671 introduces. The four console-echo tests inside the conflict are pre-existing on main, not part of this fix.11 of the 13 files match #15671's own +/- tallies exactly. The two that differ are the
logToConsolelines above.🤖 Generated with Claude Code