Skip to content

backport cloud/1.54: preserve promoted subgraph edits and links (#17202) - #17913

Merged
DrJKL merged 1 commit into
cloud/1.54from
backport/cloud-1.54-promoted-widget-follow-17202-v2
Sep 17, 2026
Merged

DrJKL merged 1 commit into
cloud/1.54from
backport/cloud-1.54-promoted-widget-follow-17202-v2

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backports Frontend 17202 to cloud/1.54 after dependency Frontend 17889. Patch-identical; cloud pins unchanged.

Full context for agent readers

Summary

  • Preserves promoted widget edits on existing subgraph hosts.
  • Resolves Agent-created connections by declared promoted-slot identity.
  • Carries the source definition, follower, host-slot, graph-mutation, and store regressions unchanged.

Linear

Verification

  • Exact target base: 4270d4e81db31768625a04be1b259fc1c552f7b6.
  • Source commit: d0dc978a1a4cf670b0a992d8c57381bd56fa9dcf.
  • Backport head: 04468979520e49ff2331ee6801c5a6b44ffd659c.
  • Stable source/backport patch ID: 73b75978da72d485df7cb054bd44045cecc79ccf.
  • Six focused graph, store, definition, follower, host-slot, and ECS suites: 113 passed.
  • Full Agent CRDT suite: 36 files, 532 tests passed.
  • ESLint, type-aware Oxlint, Oxfmt, Knip, typecheck, browser typecheck, diff check, and production cloud build passed.
  • Production-preview browser acceptance on isolated port 6200: promoted host materialization, declared slot connection, promoted widget edit, Agent flag-off persistence, and flag-on open/close pressed state all passed (3 Playwright tests).
  • Frontend remains 1.54.10; @comfyorg/comfy-multi-player remains 0.2.1; no package or lockfile changed.

Justification: DrJKL approved exact source head 8d0a074428264406fae7189053a5806b95dcdf42; this release PR carries the identical stable patch plus target-specific unit, static, production-build, and browser acceptance evidence.

…n existing subgraph hosts (#17202)

Short-term fix so the agent can edit promoted widgets (S1) and connect
slots (S2) on existing subgraph hosts without the follower wiping the
host or mis-wiring the link. Creation/promotion (S3/S4),
`insert_workflow`, forking and blueprints stay in the long-term plan:
[TDD — Agent Subgraph
Lifecycle](https://www.notion.so/3d16d73d365081719b85ed515af98276) (V1 =
this PR; V1.5 `insert_workflow` cmp op; V2 promote/demote +
`fork_definition`; V3 `define_subgraph` + scoped interior ops; V4
blueprints/doc updates).

- Promoted `set_widget` on a host no longer wipes its widgets (host
storage flips to opaque in one cmp tx; follower now lets the opaque loop
own it).
- `connect` to a grown host input resolves the slot by name from the
subgraph definition (nested definitions included); an undeclared or
duplicate name skips the link and reports
`error_reconciling_agent_subgraph_host_slot` instead of landing on a
random input.
- Follower tests RED→GREEN for S1/S2 plus a helper module with its own
tests. Includes the scalar-only `nodeDataStore` update path and shared
LiteGraph promoted-widget traversal. Browser spec is follow-up #17224.

<details><summary>Full context for agent readers</summary>

### Scope

Linear [BE-10305](https://linear.app/comfyorg/issue/BE-10305) / FE-2033:
S1 promoted-widget edits and S2 slot connects on existing subgraphs are
the immediate scope for FE 1.54. S3 promotion, S4 creation,
`insert_workflow` as a cmp op (decided 2026-09-08, TDD ADR-T8, phase
V1.5), and definition-change tracking are V2+ in the
[TDD](https://www.notion.so/3d16d73d365081719b85ed515af98276). Program
tracking: [blocked-on-christian
#393](christian-byrne/blocked-on-christian#393);
DQ-63 (`insert_workflow`) in
[#417](christian-byrne/blocked-on-christian#417).

Related: #16922 (S4 materializer fix, merged), #16932 (deferred S4
review findings), #16957 (S4 review debt, blocked on #16644), #17224
(Playwright spec for this PR's S1/S2 paths).

### Root causes (verified against cmp `src/applier.ts`)

1. `applyPromotedHostWrite` does `mdel(target,"widgets")` and
`mset(target,"__widgets_opaque",next)` in the same transaction. The
follower put the host in both `replacedWidgetMaps` and
`replacedOpaqueWidgets`, ran `reconcileNode` (positional names, promoted
widgets gone) and skipped the opaque loop.
2. cmp writes only the grown slot into the host's doc `inputs`;
`target_slot` indexes that doc-local list, while the live host orders
inputs by the subgraph definition. Positional wiring hit the wrong slot.
3. `claimPromotedInput` does not validate `grow.name` against the
definition. A bogus name used to fall back to the doc index.

### Changes

- `agentSubgraphHostSlots.ts`: `indexSubgraphDefinitions` (top-level +
nested `definitions.subgraphs`), `promotedWidgetNames(definition,
index)` (memoized per `(definition.id, inputIndex)`, active-set cycle
detection → cyclic reference is unpromoted, depth cap 32 with
cap-truncated answers left unmemoized), `hostInputs`, `hostSlotIndex` —
derive host slot order and promoted widget names from
`subgraph_definitions`. Duplicate declared names resolve to no slot.
- `agentSubgraphDefinitions.ts`: definition projection rejects unsafe
collection shapes before consumers traverse them and ignores a top-level
definitions root with the wrong Yjs shared type.
- `ecsFollowerAdapter.ts`: `hostTarget` resolves target slot/inputs by
name and returns `null` on undeclared/duplicate names → link skipped +
`reportError('error_reconciling_agent_subgraph_host_slot')`; a changed
link that becomes unreadable is disconnected rather than left live;
`applyQueuedFrame` opaque loop owns hosts and sets promoted widgets by
name; `replacedWidgetMaps` loop skips nodes also in
`replacedOpaqueWidgets`; malformed host input entries are ignored;
opaque array length mismatch against the promoted list is skipped and
reported as `error_reconciling_agent_subgraph_host_widgets`; in-place
`Y.Array` edits to opaque host widgets are observed (defensive path for
foreign writers; cmp writes plain arrays); drift errors are deduped per
session (`TargetSession.reportedErrors`); a failed/rejected batch
re-arms `reconcileNextFrame`; live-host scalar resync includes
`resizable` and `showAdvanced`.
- Tests: `agentSubgraphFollower.test.ts` S1–S1q (promoted write, empty
named map, opaque longer/shorter/malformed, non-host fallback, promoted
names across load/re-arm/map replace/storage flip, live-field resync
incl. `resizable`/`showAdvanced`, in-place Y.Array edit, per-session
error dedupe, failed-batch re-arm, plain→host and host→plain type flips)
and S2–S2f (declared connect, slot-less doc host, malformed inputs,
undeclared name, same-id retarget onto undeclared slot, omitted doc slot
keeps live link, slot error dedupe); `agentSubgraphHostSlots.test.ts`
(nested definition index, first-wins on repeated id, duplicate names,
depth cap, cyclic fan-out resolves in <50 index lookups).

### Verification

Current head: `pnpm vitest run src/workbench/extensions/agent/crdt` 36
files / 543 tests green; `pnpm typecheck`, `pnpm lint`, `pnpm
format:check`, `pnpm knip`, and changed-scope Fallow green. Blind
reviewer thread independently reproduced both P1s (same-id retarget,
nested lookup); both fixed in follow-up commits with regression tests.

### Not verified / follow-ups

- No Playwright coverage in this PR. Feasible via
`browser_tests/tests/agent/agentPanelMocks.ts` +
`browser_tests/fixtures/ws.ts`; needs a subgraph workflow fixture →
#17224.
- No live agent.comfy.org run in this PR.

### Adversarial review (cross-model, Codex) — deferred or rejected

- Definition edits not tracked mid-session: S3/S4, TDD V2.
- Reuse `SubgraphNode._resolveInputWidget`: follower reads the Y.Doc,
not a live node; needs the ECS lookup the TDD introduces.
- Promoted names assumed unique: serializer enforces; follower now also
treats duplicates as undeclared.

### Decisions made without explicit sign-off

- Host owns the promoted value (ADR-SUBGRAPH-PROMOTION-0009); S1 no
longer asserts the interior node value.
- Opaque array length mismatch → skip + report, not partial apply.
- Omitted doc slots keep their live link; nested definitions index
first-wins.
- Host-origin positional resolution (host as link source) deferred to
V2.
- `reconcileNode` fallback kept only for non-subgraph opaque nodes.

</details>

---------

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
Co-authored-by: Amp <amp@ampcode.com>
(cherry picked from commit d0dc978)
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 7fecac31-8b3a-45c1-a54f-5bdf4f905fe2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 17, 2026 6:30am UTC

Request Review

@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1922 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1901 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/17/2026, 06:32:01 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.2 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 130ms TBT · 95.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.4 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.3 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 132ms TBT · 175.4 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 481ms TBT · 167.7 MB heap
vue-zoom-out-idle: · 54.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.3 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 498ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 71.0 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -159
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 36ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 872ms
canvas-mouse-sweep: script duration 143ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 63.4 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -160
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 349ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.4 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 490ms
dom-widget-clipping: script duration 173ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.5 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 3
large-graph-idle: task duration 594ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.2 MB
large-graph-idle: DOM nodes -274
large-graph-idle: event listeners -173
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1554ms
large-graph-pan: script duration 754ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 83.2 MB
large-graph-pan: DOM nodes -270
large-graph-pan: event listeners -157
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1676ms
large-graph-zoom: script duration 760ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.6 MB
large-graph-zoom: DOM nodes -138
large-graph-zoom: event listeners -65
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1886ms
legacy-node-drag: script duration 943ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 83.6 MB
legacy-node-drag: DOM nodes -6
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 606ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.7 MB
minimap-idle: DOM nodes -269
minimap-idle: event listeners -159
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 408ms
subgraph-dom-widget-clipping: script duration 143ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.2 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 484ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 69.3 MB
subgraph-idle: DOM nodes -293
subgraph-idle: event listeners -222
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 36ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 798ms
subgraph-mouse-sweep: script duration 99ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 61.2 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -206
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 926ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 130ms
subgraph-transition-enter: heap used 95.2 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5656ms
viewport-pan-sweep: script duration 2576ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 85.4 MB
viewport-pan-sweep: DOM nodes -271
viewport-pan-sweep: event listeners -158
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17119ms
vue-large-graph-idle: script duration 307ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 167.3 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7473
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 176
vue-large-graph-pan: task duration 21535ms
vue-large-graph-pan: script duration 908ms
vue-large-graph-pan: TBT 132ms
vue-large-graph-pan: heap used 175.4 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7470
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 73ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6214ms
vue-node-resize-workload: script duration 119ms
vue-node-resize-workload: TBT 481ms
vue-node-resize-workload: heap used 167.7 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7472
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8581ms
vue-zoom-out-idle: script duration 143ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 168.3 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -13
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 3
workflow-execution: style recalc count 19
workflow-execution: task duration 108ms
workflow-execution: script duration 11ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.0 MB
workflow-execution: DOM nodes 148
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-09-17T06:41:20.093Z",
  "gitSha": "1fcc1cebf96d417fbbb21234ac59eab25eaa0e25",
  "branch": "backport/cloud-1.54-promoted-widget-follow-17202-v2",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2070.2310000000352,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.4780000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 502.259,
      "heapDeltaBytes": -1670576,
      "heapUsedBytes": 68984104,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.311000000000003,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2036.9849999999587,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.569999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 494.43899999999996,
      "heapDeltaBytes": 9254404,
      "heapUsedBytes": 79870180,
      "domNodes": -281,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 8.427999999999997,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1862.9450000000247,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 36.224,
      "layouts": 14,
      "layoutDurationMs": 4.887,
      "taskDurationMs": 877.7539999999999,
      "heapDeltaBytes": 1196096,
      "heapUsedBytes": 71227080,
      "domNodes": -282,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 145.281,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1817.4109999999928,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 35.007999999999996,
      "layouts": 14,
      "layoutDurationMs": 4.411,
      "taskDurationMs": 866.059,
      "heapDeltaBytes": -8765876,
      "heapUsedBytes": 61677524,
      "domNodes": -279,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 140.27100000000002,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1720.2449999999772,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.264000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.2600000000000002,
      "taskDurationMs": 354.448,
      "heapDeltaBytes": 5039720,
      "heapUsedBytes": 75873952,
      "domNodes": 79,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.723,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1656.7649999999503,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.184999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.1939999999999997,
      "taskDurationMs": 343.98400000000004,
      "heapDeltaBytes": 5081504,
      "heapUsedBytes": 75980884,
      "domNodes": 76,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.435,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 780.3319999999871,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.935999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 529.3520000000001,
      "heapDeltaBytes": 18820444,
      "heapUsedBytes": 88551404,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 186.616,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 650.4939999999806,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.822000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 450.678,
      "heapDeltaBytes": 18476092,
      "heapUsedBytes": 88574204,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 158.65699999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2028.4729999999627,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 567.087,
      "heapDeltaBytes": 11448388,
      "heapUsedBytes": 87780012,
      "domNodes": -278,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 33.12799999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.565000000015,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.624999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 620.882,
      "heapDeltaBytes": 10359432,
      "heapUsedBytes": 86766536,
      "domNodes": -269,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 34.778000000000006,
      "eventListeners": -172,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2137.647999999956,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 14.527999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1536.927,
      "heapDeltaBytes": 19084440,
      "heapUsedBytes": 85250360,
      "domNodes": -268,
      "jsHeapTotalBytes": 1798144,
      "scriptDurationMs": 754.361,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2198.4410000000025,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.860999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1571.74,
      "heapDeltaBytes": 12852484,
      "heapUsedBytes": 89210444,
      "domNodes": -271,
      "jsHeapTotalBytes": -663552,
      "scriptDurationMs": 754.516,
      "eventListeners": -172,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3529.218999999955,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 12.802999999999999,
      "layouts": 60,
      "layoutDurationMs": 13.241999999999999,
      "taskDurationMs": 1694.413,
      "heapDeltaBytes": -1516160,
      "heapUsedBytes": 76409128,
      "domNodes": -276,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 757.479,
      "eventListeners": -138,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3533.9539999999943,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.327000000000004,
      "layouts": 60,
      "layoutDurationMs": 12.895,
      "taskDurationMs": 1657.975,
      "heapDeltaBytes": 11967228,
      "heapUsedBytes": 80048260,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 762.4089999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3061.800000000005,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.292999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1886.022,
      "heapDeltaBytes": 22263564,
      "heapUsedBytes": 89865408,
      "domNodes": -11,
      "jsHeapTotalBytes": 1204224,
      "scriptDurationMs": 937.6859999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3108.345999999983,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.453999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1884.998,
      "heapDeltaBytes": 17240060,
      "heapUsedBytes": 85393568,
      "domNodes": 0,
      "jsHeapTotalBytes": 2252800,
      "scriptDurationMs": 948.7550000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2047.3799999999756,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.812999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 601.481,
      "heapDeltaBytes": 10696836,
      "heapUsedBytes": 87742736,
      "domNodes": -271,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 33.249,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2053.0880000000025,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.7839999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 610.8240000000001,
      "heapDeltaBytes": 10621256,
      "heapUsedBytes": 87848000,
      "domNodes": -267,
      "jsHeapTotalBytes": -2985984,
      "scriptDurationMs": 35.067,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 581.0539999999946,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.639999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 396.529,
      "heapDeltaBytes": 14252124,
      "heapUsedBytes": 86582208,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 140.702,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 608.9829999999665,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.574,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 418.619,
      "heapDeltaBytes": 15276088,
      "heapUsedBytes": 87942128,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 146.04699999999997,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.6229999999769,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.973,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 484.8539999999999,
      "heapDeltaBytes": -2716796,
      "heapUsedBytes": 70633388,
      "domNodes": -293,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 7.6830000000000025,
      "eventListeners": -224,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.373000000016,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.545,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 483.08699999999993,
      "heapDeltaBytes": 1699936,
      "heapUsedBytes": 74718964,
      "domNodes": -293,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.922999999999999,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.915999999988,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 37.262,
      "layouts": 18,
      "layoutDurationMs": 5.3309999999999995,
      "taskDurationMs": 800.166,
      "heapDeltaBytes": -13201656,
      "heapUsedBytes": 58451672,
      "domNodes": -293,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 100.26299999999999,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1733.0130000000281,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 35.034,
      "layouts": 18,
      "layoutDurationMs": 5.072,
      "taskDurationMs": 795.882,
      "heapDeltaBytes": -2395388,
      "heapUsedBytes": 69832764,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 98.21400000000001,
      "eventListeners": -222,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.1659999999893,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 30.298999999999992,
      "layouts": 15,
      "layoutDurationMs": 14.123000000000003,
      "taskDurationMs": 926.339,
      "heapDeltaBytes": 2004212,
      "heapUsedBytes": 99801452,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11796480,
      "scriptDurationMs": 28.897000000000006,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 130,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8321.054000000004,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 37.449999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5659.956999999999,
      "heapDeltaBytes": 13455532,
      "heapUsedBytes": 89840316,
      "domNodes": -273,
      "jsHeapTotalBytes": -401408,
      "scriptDurationMs": 2574.97,
      "eventListeners": -158,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8322.479999999927,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 38.61000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5652.353,
      "heapDeltaBytes": 13180096,
      "heapUsedBytes": 89184512,
      "domNodes": -269,
      "jsHeapTotalBytes": -1187840,
      "scriptDurationMs": 2576.411,
      "eventListeners": -158,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18037.982999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17126.241,
      "heapDeltaBytes": -34911728,
      "heapUsedBytes": 176200412,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2596864,
      "scriptDurationMs": 294.096,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17801.170999999955,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17110.942,
      "heapDeltaBytes": -36466120,
      "heapUsedBytes": 174644992,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1286144,
      "scriptDurationMs": 320.71000000000004,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21931.78499999999,
      "styleRecalcs": 177,
      "styleRecalcDurationMs": 20.344999999999946,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21515.885000000002,
      "heapDeltaBytes": -12235108,
      "heapUsedBytes": 191206820,
      "domNodes": -6548,
      "jsHeapTotalBytes": -606208,
      "scriptDurationMs": 921.6440000000001,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 172,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21932.798000000046,
      "styleRecalcs": 175,
      "styleRecalcDurationMs": 20.339999999999968,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21554.140999999996,
      "heapDeltaBytes": -26381500,
      "heapUsedBytes": 176658720,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1822720,
      "scriptDurationMs": 895.048,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 91,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6364.446000000044,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.09499999999997,
      "layouts": 20,
      "layoutDurationMs": 24.580000000000005,
      "taskDurationMs": 6279.256000000001,
      "heapDeltaBytes": -31093456,
      "heapUsedBytes": 175604052,
      "domNodes": -6548,
      "jsHeapTotalBytes": 15269888,
      "scriptDurationMs": 117.71999999999998,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 521,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6241.2369999999555,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 72.625,
      "layouts": 20,
      "layoutDurationMs": 23.57899999999999,
      "taskDurationMs": 6149.017,
      "heapDeltaBytes": -27655756,
      "heapUsedBytes": 176175536,
      "domNodes": -6548,
      "jsHeapTotalBytes": 10567680,
      "scriptDurationMs": 120.78,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 440,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9042.122000000007,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8607.948,
      "heapDeltaBytes": 14671560,
      "heapUsedBytes": 176338408,
      "domNodes": 0,
      "jsHeapTotalBytes": -8126464,
      "scriptDurationMs": 143.05999999999997,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9070.936999999958,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8553.735,
      "heapDeltaBytes": 10872624,
      "heapUsedBytes": 176643764,
      "domNodes": 0,
      "jsHeapTotalBytes": -12058624,
      "scriptDurationMs": 142.382,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.890000000000025,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 472.2659999999905,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 22.767999999999997,
      "layouts": 3,
      "layoutDurationMs": 1.4829999999999999,
      "taskDurationMs": 113.779,
      "heapDeltaBytes": 5065500,
      "heapUsedBytes": 74005348,
      "domNodes": 151,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 13.279,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 463.0489999999554,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 19.733,
      "layouts": 2,
      "layoutDurationMs": 1.1209999999999998,
      "taskDurationMs": 102.97699999999999,
      "heapDeltaBytes": 4954468,
      "heapUsedBytes": 72842132,
      "domNodes": 144,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 8.731000000000002,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact cloud/1.54 head verified. Local target gates and browser acceptance are green; hosted checks remain the next gate.

Full context for agent readers

Reviewed exact head 04468979520e49ff2331ee6801c5a6b44ffd659c against target base 4270d4e81db31768625a04be1b259fc1c552f7b6. Source and backport stable patch IDs match. Six focused suites passed 113 tests; the full Agent CRDT suite passed 36 files / 532 tests. ESLint, type-aware Oxlint, Oxfmt, Knip, typecheck, browser typecheck, diff check, and the production cloud build passed. Production-preview Playwright acceptance passed promoted host materialization, declared slot connection, promoted widget mutation, and Agent flag off/on behavior on isolated port 6200. Frontend and multiplayer pins are unchanged. This is a COMMENT review because GitHub identity must not self-approve. Merge still requires terminal acceptable hosted checks, no unresolved human objection or freeze, and the target-aware exact-head merge guard.

@DrJKL
DrJKL enabled auto-merge (squash) September 17, 2026 06:33
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 17, 2026
@DrJKL
DrJKL merged commit 5b5ab10 into cloud/1.54 Sep 17, 2026
93 checks passed
@DrJKL
DrJKL deleted the backport/cloud-1.54-promoted-widget-follow-17202-v2 branch September 17, 2026 06:46
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.01478% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/core/graph/graphMutations.ts 97.05% 3 Missing ⚠️
...kbench/extensions/agent/crdt/ecsFollowerAdapter.ts 99.14% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #17913   +/-   ##
=============================================
  Coverage              ?   82.98%           
=============================================
  Files                 ?     2055           
  Lines                 ?   120043           
  Branches              ?    32916           
=============================================
  Hits                  ?    99618           
  Misses                ?    20245           
  Partials              ?      180           
Flag Coverage Δ
unit 77.62% <99.01%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/core/graph/subgraph/hasPromotedWidgetTarget.ts 100.00% <100.00%> (ø)
...re/graph/subgraph/resolveConcretePromotedWidget.ts 98.66% <100.00%> (ø)
src/stores/nodeDataStore.ts 95.69% <100.00%> (ø)
...nch/extensions/agent/crdt/agentNodeMaterializer.ts 100.00% <100.00%> (ø)
.../extensions/agent/crdt/agentSubgraphDefinitions.ts 98.23% <100.00%> (ø)
...ch/extensions/agent/crdt/agentSubgraphHostSlots.ts 100.00% <100.00%> (ø)
...kbench/extensions/agent/crdt/ecsFollowerAdapter.ts 96.70% <99.14%> (ø)
src/core/graph/graphMutations.ts 92.43% <97.05%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants