Repository navigation
[backport core/1.54] Prevent insertion into a replaced canvas - #17885
Conversation
## Summary Prevent an asynchronously loaded workflow from being inserted after its target canvas has been replaced. ## Changes - **What**: Capture the target canvas before loading and abort if `app.canvas` changes; add a permanent regression test covering both the old and replacement canvases. ## Review Focus Please verify that aborting the stale insertion is preferable to redirecting it into the newly active canvas. This extracts only the canvas-identity race fix from frozen PR #16448 and deliberately excludes its rejected selection-mode blocking. ## Screenshots (if applicable) Not applicable; behavior is covered by the focused unit test. Justification: Christian approved the proposed merge path in blocked-on-christian #330 and explicitly authorized ignoring the newly introduced feature-flag-policy failure for this previously approved fix. --------- Co-authored-by: Pipeline Agent <agent@pipeline.local> (cherry picked from commit eefcc56)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1923 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-17T01:42:04.696Z",
"gitSha": "a2460bba90a24adccc5b1f93a169b48a4e34ace6",
"branch": "christian-byrne/backport-16478-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.1280000000525,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.223000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.7659999999999,
"heapDeltaBytes": -4021032,
"heapUsedBytes": 65142536,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.284000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2033.726999999999,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.397,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.8419999999999,
"heapDeltaBytes": -12595716,
"heapUsedBytes": 57293196,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.072,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2044.3179999999757,
"styleRecalcs": 79,
"styleRecalcDurationMs": 42.611,
"layouts": 14,
"layoutDurationMs": 4.653,
"taskDurationMs": 1010.3789999999999,
"heapDeltaBytes": 1445560,
"heapUsedBytes": 72432052,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 165.63,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1858.6880000000292,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.636,
"layouts": 14,
"layoutDurationMs": 4.623,
"taskDurationMs": 883.775,
"heapDeltaBytes": -755416,
"heapUsedBytes": 68425560,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 144.983,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.6250000000227,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.129,
"layouts": 6,
"layoutDurationMs": 1.187,
"taskDurationMs": 349.865,
"heapDeltaBytes": 5070780,
"heapUsedBytes": 75790532,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.716,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.4860000000426,
"styleRecalcs": 32,
"styleRecalcDurationMs": 27.867000000000004,
"layouts": 6,
"layoutDurationMs": 1.234,
"taskDurationMs": 383.363,
"heapDeltaBytes": 4455384,
"heapUsedBytes": 74210600,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.758000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 664.1490000000658,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.491999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.937,
"heapDeltaBytes": -7871952,
"heapUsedBytes": 62797244,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 160.318,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 694.9240000000145,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.027999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.3349999999999,
"heapDeltaBytes": 18520332,
"heapUsedBytes": 88587832,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 166.683,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2036.6169999999784,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.892000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.8140000000001,
"heapDeltaBytes": -14543940,
"heapUsedBytes": 88100900,
"domNodes": -267,
"jsHeapTotalBytes": -851968,
"scriptDurationMs": 30.340000000000007,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2040.5130000000327,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.184,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.076,
"heapDeltaBytes": 22329884,
"heapUsedBytes": 87756300,
"domNodes": -268,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.71099999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2160.0550000000567,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.973999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1574.821,
"heapDeltaBytes": 8335256,
"heapUsedBytes": 84848768,
"domNodes": -273,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 757.2220000000001,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2176.343999999972,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.081000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1548.343,
"heapDeltaBytes": 8360376,
"heapUsedBytes": 85147280,
"domNodes": -276,
"jsHeapTotalBytes": 909312,
"scriptDurationMs": 744.345,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3471.237999999971,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.625000000000002,
"layouts": 60,
"layoutDurationMs": 12.975999999999997,
"taskDurationMs": 1638.413,
"heapDeltaBytes": 7783396,
"heapUsedBytes": 75922460,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 747.101,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3500.823999999966,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.63,
"layouts": 60,
"layoutDurationMs": 12.93,
"taskDurationMs": 1656.5030000000004,
"heapDeltaBytes": 9938592,
"heapUsedBytes": 76069780,
"domNodes": -278,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 753.694,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3045.573999999988,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.305999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1875.404,
"heapDeltaBytes": 22131556,
"heapUsedBytes": 90275272,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 929.097,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3118.058000000019,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.378000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1953.698,
"heapDeltaBytes": 26026524,
"heapUsedBytes": 93331692,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 982.5500000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.4879999999112,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.449,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.7109999999999,
"heapDeltaBytes": 10919312,
"heapUsedBytes": 88034436,
"domNodes": -272,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 30.331999999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2015.0610000000597,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.7090000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.9020000000002,
"heapDeltaBytes": 22106044,
"heapUsedBytes": 87968580,
"domNodes": -279,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.586999999999996,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.7889999999861,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.697999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.95899999999995,
"heapDeltaBytes": 15136980,
"heapUsedBytes": 87684888,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 141.46200000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.1489999999303,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.509,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.25100000000003,
"heapDeltaBytes": 15133856,
"heapUsedBytes": 88262180,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 139.25500000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2039.0469999999823,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.488999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.2,
"heapDeltaBytes": -3399164,
"heapUsedBytes": 67957728,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.646,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.0959999999432,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.415000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.511,
"heapDeltaBytes": -2013724,
"heapUsedBytes": 69339456,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.999999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.5959999999295,
"styleRecalcs": 78,
"styleRecalcDurationMs": 34.482,
"layouts": 18,
"layoutDurationMs": 5.567,
"taskDurationMs": 787.938,
"heapDeltaBytes": 889464,
"heapUsedBytes": 66381464,
"domNodes": -295,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 99.81200000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1767.62999999994,
"styleRecalcs": 79,
"styleRecalcDurationMs": 36.69,
"layouts": 18,
"layoutDurationMs": 5.359999999999999,
"taskDurationMs": 818.396,
"heapDeltaBytes": 4891352,
"heapUsedBytes": 77525044,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 106.335,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.021999999959,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.827999999999996,
"layouts": 14,
"layoutDurationMs": 14.370999999999999,
"taskDurationMs": 901.7260000000002,
"heapDeltaBytes": 20042920,
"heapUsedBytes": 104336024,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 28.352999999999998,
"eventListeners": 2387,
"totalBlockingTimeMs": 133,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8278.419999999984,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.223,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5683.6140000000005,
"heapDeltaBytes": -16400032,
"heapUsedBytes": 86389408,
"domNodes": -267,
"jsHeapTotalBytes": -1183744,
"scriptDurationMs": 2642.786,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8289.097999999967,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.86299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5670.309,
"heapDeltaBytes": 13040380,
"heapUsedBytes": 89490876,
"domNodes": -269,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 2605.238,
"eventListeners": -158,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17836.822999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17065.581000000002,
"heapDeltaBytes": -35083500,
"heapUsedBytes": 174709924,
"domNodes": -6548,
"jsHeapTotalBytes": -5967872,
"scriptDurationMs": 310.214,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17913.365999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17175.283,
"heapDeltaBytes": -30602832,
"heapUsedBytes": 175975884,
"domNodes": -6548,
"jsHeapTotalBytes": -6193152,
"scriptDurationMs": 289.285,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.33666666666674,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22283.682999999997,
"styleRecalcs": 173,
"styleRecalcDurationMs": 21.266000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21860.979,
"heapDeltaBytes": -44442212,
"heapUsedBytes": 167171392,
"domNodes": -6548,
"jsHeapTotalBytes": -6217728,
"scriptDurationMs": 918.7,
"eventListeners": -7469,
"totalBlockingTimeMs": 118,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22022.079000000078,
"styleRecalcs": 179,
"styleRecalcDurationMs": 19.899,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21595.297000000002,
"heapDeltaBytes": -36204872,
"heapUsedBytes": 166850400,
"domNodes": -6548,
"jsHeapTotalBytes": 237568,
"scriptDurationMs": 916.319,
"eventListeners": -7467,
"totalBlockingTimeMs": 151,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6344.981000000075,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.99600000000001,
"layouts": 20,
"layoutDurationMs": 23.708000000000006,
"taskDurationMs": 6233.485,
"heapDeltaBytes": -24443136,
"heapUsedBytes": 180957328,
"domNodes": -6548,
"jsHeapTotalBytes": 13881344,
"scriptDurationMs": 113.87199999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 433,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6384.185000000116,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.83199999999997,
"layouts": 20,
"layoutDurationMs": 31.55300000000001,
"taskDurationMs": 6295.911,
"heapDeltaBytes": -21923080,
"heapUsedBytes": 190678844,
"domNodes": -6548,
"jsHeapTotalBytes": 2506752,
"scriptDurationMs": 172.80199999999996,
"eventListeners": -7471,
"totalBlockingTimeMs": 454,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9112.78900000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8644.752999999999,
"heapDeltaBytes": 17738412,
"heapUsedBytes": 174631148,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.66400000000004,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9218.345,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8776.846000000001,
"heapDeltaBytes": 6685224,
"heapUsedBytes": 176790388,
"domNodes": 0,
"jsHeapTotalBytes": -8650752,
"scriptDurationMs": 146.00200000000007,
"eventListeners": 22,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 499.9329999999418,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.761999999999997,
"layouts": 3,
"layoutDurationMs": 2.066,
"taskDurationMs": 128.459,
"heapDeltaBytes": 4948972,
"heapUsedBytes": 73240680,
"domNodes": 145,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.918000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 94.05700000002071,
"styleRecalcs": 5,
"styleRecalcDurationMs": 11.892,
"layouts": 2,
"layoutDurationMs": 1.2659999999999998,
"taskDurationMs": 63.971000000000004,
"heapDeltaBytes": 3003924,
"heapUsedBytes": 71213104,
"domNodes": 122,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.425000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head review at dabc6e41f9f9b54c2d524ffeac8e16bebf427dd4: no blocking findings.
Full context for agent readers
- Base is
core/1.54; the production and unit-test commit has the same stable patch ID as merged source PR 16478. - Target-specific browser coverage reproduces the stale insertion on the exact release parent and passes on this head after entering a subgraph while source loading is held.
- Focused unit tests (109), ESLint, typecheck, browser typecheck, formatter, and diff checks passed locally.
- This COMMENT records review evidence only; it is not an approval of my own PR. Merge remains gated on terminal acceptable CI, unchanged head/base, target-aware guard, lease/ownership, and no human objection or freeze.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #17885 +/- ##
============================================
Coverage 83.02% 83.02%
============================================
Files 2054 2054
Lines 120040 120044 +4
Branches 30025 31854 +1829
============================================
+ Hits 99658 99664 +6
+ Misses 20202 20200 -2
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backports [source PR 17593](#17593) to `core/1.54` after prerequisite [PR 17885](#17885). - Reports both existing stale-insertion abort paths through the shared telemetry fan-out. - Preserves insertion behavior and exact frontend/multiplayer pins. - Updates the release-only browser regression to assert the user-visible no-insertion outcome rather than the removed console warning. <details><summary>Full context for agent readers</summary> ## Provenance - Target parent: `d39c656f0dd4318299a4bd0910a6b044c5ebe6fd` - Merged source: `01e69f3ab9bf39598c28e8b76a9adc13edbfd32e` - Source-carrying commit: `e086be201a9ee51b5f278cc26690098003b91082` - Exact PR head: `c3ac56790f87af6e4d7d9fe1dec02c2418b198fa` - Source/backport stable patch ID: `28c9c6ce1c67074398c681a353424da9ec6b8a56` ## Verification - Focused unit suite: 106/106 passed, including normal insertion and both canvas/graph replacement telemetry cases. - Parent red proof: the same tests against the pre-backport production file failed exactly the two telemetry assertions while 104 tests passed. - Core browser acceptance: the workflows-sidebar insertion race passed on Chromium and visibly preserved the entered subgraph's node count. - `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm knip`, focused ESLint/Oxlint/formatting, and `git diff --check`: passed. - `package.json` and `pnpm-lock.yaml` are unchanged; frontend remains 1.54.10 and `@comfyorg/comfy-multi-player` remains 0.2.1. ## Review focus Confirm canvas-over-graph precedence, exact telemetry tags/context, and that the release-only browser adjustment preserves behavioral coverage after `console.warn` became structured telemetry. </details> Justification: scoped Agent release backport authorized by the published 1.54 backport grant; source behavior is a stable-patch match and target-specific unit, static, parent-red, and browser acceptance passed before publication. <!-- authored-by:agent release-backport-core -->
Backports source PR 16478 to
core/1.54.Full context for agent readers
Summary
Captures the active canvas and graph before loading workflow JSON, then aborts if either identity changes before deserialization. The added Playwright case starts Insert from the Workflows sidebar, holds the source request, enters a subgraph through the real canvas path, and verifies no source nodes appear in that subgraph.
Provenance
f9096c1a61836b290e5ab5f28118594c402b07b0eefcc56d5d56cacbd6177463abe9080c917ab5ff132dfb5f1ddabc6e41f9f9b54c2d524ffeac8e16bebf427dd4e5ac5964e44454c54e971c6d97df3e313c86b5afVerification
pnpm typecheckandpnpm typecheck:browser: passed.git diff --check: passed.Dependency order
This is canonical core mapping
relmap-5. Source PR 17593 follows asrelmap-6because it replaces this guard's warning with structured abort telemetry.Review focus
Confirm stale insertion should abort rather than redirect into the newly active graph, and that the browser regression accurately exercises sidebar insertion racing subgraph entry.
Justification: scoped Agent release backport authorized by the published 1.54 backport grant; production code is an exact stable-patch match to merged source PR 16478, and target-specific unit, type, lint, and red/green browser acceptance passed before publication.