Repository navigation
[backport core/1.54] Report insert abort telemetry - #17935
Conversation
## Summary `insertWorkflow` aborts silently when `app.canvas` or `app.canvas.graph` is replaced while the workflow JSON is loading (for example the user opened another tab mid-insert). The abort is correct behaviour, but it left no trace: the caller sees nothing inserted and telemetry sees nothing at all. This PR keeps the early return and reports it through `reportError` as a soft-assert warning so the case is countable in Sentry: - `error_type=workflow_insert_aborted_canvas_changed` - tags `failure_kind=degraded`, `feature_area=workflow`, `operation=insert`, `outcome=degraded`, `assert_mode=soft` - context `replacement_kind` = `canvas` (canvas object swapped) or `graph` (same canvas, graph swapped). Canvas takes precedence when both changed. No behavioural change to insertion itself. ## Evidence - Local: `pnpm vitest run src/platform/workflow/core/services/workflowService.test.ts` -> 1 file passed, 106/106 tests passed (5.85s). The two existing race tests (`canvas replaced`, `graph changed`) now also assert exactly one `reportError` call with the tags above and the matching `replacement_kind`; the positive-control test still asserts zero calls. - `oxlint` on the two touched files: clean. - Branch head: `9df88742c6415ec528800b73e28b56e7442316f0` on `c4afd4750b8c63d59d914db962e1f73a11167064` (origin/main). ## Notes for reviewers Tag values `operation=insert` and `outcome=degraded` are new to the agent telemetry taxonomy (program ADR-029); the registry amendment is landing in the program repo alongside this PR. Veto points: canvas-over-graph precedence for `replacement_kind`, and the exact Error message text. Program row: tele-22. <!-- authored-by:agent role-hard-problem --> (cherry picked from commit 01e69f3)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1923 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-17T16:39:42.452Z",
"gitSha": "30228c27be152ffb4baeea30e625fd9eb2ba4d19",
"branch": "christian-byrne/backport-17593-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2031.059999999968,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.925,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.125,
"heapDeltaBytes": -3432808,
"heapUsedBytes": 67297204,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.215000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2034.3510000000151,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.745000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 521.5889999999999,
"heapDeltaBytes": -6501540,
"heapUsedBytes": 63632468,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.096999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1948.6160000000154,
"styleRecalcs": 80,
"styleRecalcDurationMs": 42.978,
"layouts": 14,
"layoutDurationMs": 4.642,
"taskDurationMs": 951.471,
"heapDeltaBytes": 4095956,
"heapUsedBytes": 74577532,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 170.63500000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1832.2339999999713,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.997,
"layouts": 14,
"layoutDurationMs": 4.529,
"taskDurationMs": 906.943,
"heapDeltaBytes": 8062928,
"heapUsedBytes": 79124880,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 161.15,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.3230000000076,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.625999999999998,
"layouts": 6,
"layoutDurationMs": 1.0380000000000003,
"taskDurationMs": 378.88100000000003,
"heapDeltaBytes": 4988284,
"heapUsedBytes": 75952800,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.233000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1684.788000000026,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.279,
"layouts": 6,
"layoutDurationMs": 1.047,
"taskDurationMs": 377.85900000000004,
"heapDeltaBytes": 5032120,
"heapUsedBytes": 75904752,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.035999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 801.0489999999777,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.8759999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.927,
"heapDeltaBytes": -7792064,
"heapUsedBytes": 62742380,
"domNodes": 18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 183.163,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 722.4889999999959,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.836,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.08099999999996,
"heapDeltaBytes": 18862244,
"heapUsedBytes": 88330724,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 163.446,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2071.101999999996,
"styleRecalcs": 5,
"styleRecalcDurationMs": 6.474,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 632.0110000000001,
"heapDeltaBytes": 11111320,
"heapUsedBytes": 87312096,
"domNodes": -268,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 35.507999999999996,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2046.2629999999535,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.68,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 675.8029999999999,
"heapDeltaBytes": 11397164,
"heapUsedBytes": 87749816,
"domNodes": -269,
"jsHeapTotalBytes": -2723840,
"scriptDurationMs": 37.48499999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2293.633,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.828999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1685.812,
"heapDeltaBytes": 7652508,
"heapUsedBytes": 84875880,
"domNodes": -274,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 828.8689999999999,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2268.9719999999625,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.971999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1646.8480000000004,
"heapDeltaBytes": 23082600,
"heapUsedBytes": 89377804,
"domNodes": -274,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 813.578,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3569.254000000001,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.31,
"layouts": 60,
"layoutDurationMs": 12.388,
"taskDurationMs": 1707.1450000000002,
"heapDeltaBytes": 11789320,
"heapUsedBytes": 79746588,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 778.5949999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3593.593999999939,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.050000000000004,
"layouts": 60,
"layoutDurationMs": 12.462000000000002,
"taskDurationMs": 1739.9769999999999,
"heapDeltaBytes": 8514568,
"heapUsedBytes": 76229816,
"domNodes": -277,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 772.482,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3131.7359999999894,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.046000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1932.704,
"heapDeltaBytes": 17661992,
"heapUsedBytes": 85390700,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 950.053,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3103.7390000000187,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.152999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2001.728,
"heapDeltaBytes": 25987108,
"heapUsedBytes": 93574804,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 981.2639999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2006.889000000001,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.797,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.4909999999999,
"heapDeltaBytes": 22261348,
"heapUsedBytes": 88049184,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.742,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2022.683000000029,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.7410000000000037,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.3299999999999,
"heapDeltaBytes": 10824152,
"heapUsedBytes": 88023272,
"domNodes": -274,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 33.055,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 603.5860000000071,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.093000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.99399999999997,
"heapDeltaBytes": 13977192,
"heapUsedBytes": 86221312,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 145.74,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.5250000000387,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.381999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.87100000000004,
"heapDeltaBytes": 15066508,
"heapUsedBytes": 87872648,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 147.517,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2019.4319999999948,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.3790000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.994,
"heapDeltaBytes": 1912484,
"heapUsedBytes": 74651088,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.566999999999998,
"eventListeners": -224,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2022.57800000001,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.139000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.419,
"heapDeltaBytes": -10114412,
"heapUsedBytes": 62915544,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.270000000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.2280000000255,
"styleRecalcs": 79,
"styleRecalcDurationMs": 39.629999999999995,
"layouts": 18,
"layoutDurationMs": 4.948,
"taskDurationMs": 880.367,
"heapDeltaBytes": -518344,
"heapUsedBytes": 72627624,
"domNodes": -293,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 117.22399999999999,
"eventListeners": -222,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.4760000000952,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.91,
"layouts": 18,
"layoutDurationMs": 5.863,
"taskDurationMs": 859.9720000000001,
"heapDeltaBytes": 457700,
"heapUsedBytes": 73467964,
"domNodes": -291,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 115.282,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.3360000000148,
"styleRecalcs": 20,
"styleRecalcDurationMs": 33.93300000000001,
"layouts": 16,
"layoutDurationMs": 16.355,
"taskDurationMs": 953.3190000000001,
"heapDeltaBytes": -5604904,
"heapUsedBytes": 87186748,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 32.306000000000004,
"eventListeners": 2385,
"totalBlockingTimeMs": 149,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9445.099000000027,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.48,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6371.593,
"heapDeltaBytes": 18795860,
"heapUsedBytes": 95140304,
"domNodes": -270,
"jsHeapTotalBytes": 352256,
"scriptDurationMs": 2932.776,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8679.139999999961,
"styleRecalcs": 245,
"styleRecalcDurationMs": 34,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6058.179,
"heapDeltaBytes": 23879004,
"heapUsedBytes": 89403692,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2798.3199999999997,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17916.762000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17165.275,
"heapDeltaBytes": -32670636,
"heapUsedBytes": 176661172,
"domNodes": -6548,
"jsHeapTotalBytes": -2846720,
"scriptDurationMs": 296.633,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18080.247999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17338.040999999997,
"heapDeltaBytes": -27561844,
"heapUsedBytes": 176338640,
"domNodes": -6548,
"jsHeapTotalBytes": 5230592,
"scriptDurationMs": 309.112,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22044.265999999992,
"styleRecalcs": 166,
"styleRecalcDurationMs": 20.818999999999978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21698.837,
"heapDeltaBytes": -28036060,
"heapUsedBytes": 176918636,
"domNodes": -6548,
"jsHeapTotalBytes": -7778304,
"scriptDurationMs": 982.8070000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 70,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22233.517000000007,
"styleRecalcs": 168,
"styleRecalcDurationMs": 22.33299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21967.618000000002,
"heapDeltaBytes": -18647500,
"heapUsedBytes": 186966660,
"domNodes": -6548,
"jsHeapTotalBytes": 1708032,
"scriptDurationMs": 988.7779999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 108,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6325.591000000031,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.29999999999998,
"layouts": 20,
"layoutDurationMs": 24.459999999999997,
"taskDurationMs": 6202.821,
"heapDeltaBytes": -26250112,
"heapUsedBytes": 177896632,
"domNodes": -6548,
"jsHeapTotalBytes": 14610432,
"scriptDurationMs": 113.316,
"eventListeners": -7471,
"totalBlockingTimeMs": 476,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6499.465999999984,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.44400000000002,
"layouts": 20,
"layoutDurationMs": 24.810999999999986,
"taskDurationMs": 6403.206,
"heapDeltaBytes": -22386252,
"heapUsedBytes": 180835228,
"domNodes": -6552,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 122.72000000000001,
"eventListeners": -7473,
"totalBlockingTimeMs": 423,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9277.26899999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8721.324999999999,
"heapDeltaBytes": 20220072,
"heapUsedBytes": 178072580,
"domNodes": 0,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 153.82299999999992,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9218.647000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8873.394,
"heapDeltaBytes": 7196876,
"heapUsedBytes": 175973192,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 204.99199999999996,
"eventListeners": -10,
"totalBlockingTimeMs": 3,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 145.38299999998117,
"styleRecalcs": 11,
"styleRecalcDurationMs": 18.844,
"layouts": 2,
"layoutDurationMs": 1.4539999999999997,
"taskDurationMs": 97.08999999999999,
"heapDeltaBytes": 3080356,
"heapUsedBytes": 71881084,
"domNodes": 133,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.615,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 460.92799999996714,
"styleRecalcs": 13,
"styleRecalcDurationMs": 19.628,
"layouts": 3,
"layoutDurationMs": 0.7290000000000001,
"taskDurationMs": 104.64299999999999,
"heapDeltaBytes": 4808832,
"heapUsedBytes": 73869680,
"domNodes": 119,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.543000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
christian-byrne
left a comment
There was a problem hiding this comment.
Exact head reviewed; no blocking findings. Waiting for hosted checks.
Full context for agent readers
Reviewed c3ac56790f87af6e4d7d9fe1dec02c2418b198fa against core/1.54 parent d39c656f0dd4318299a4bd0910a6b044c5ebe6fd. Source behavior is a stable-patch match for merged PR 17593. The release-only browser adjustment correctly removes reliance on the replaced console warning while retaining the no-insertion assertion. Focused unit tests, parent-red proof, static checks, and Chromium acceptance passed locally. This is an honest COMMENT, not self-approval; the target-aware merge guard remains closed while checks are pending.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #17935 +/- ##
============================================
Coverage 83.04% 83.04%
============================================
Files 2056 2056
Lines 120387 120389 +2
Branches 30152 31979 +1827
============================================
+ Hits 99970 99976 +6
+ Misses 20237 20233 -4
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backports source PR 17593 to
core/1.54after prerequisite PR 17885.Full context for agent readers
Provenance
d39c656f0dd4318299a4bd0910a6b044c5ebe6fd01e69f3ab9bf39598c28e8b76a9adc13edbfd32ee086be201a9ee51b5f278cc26690098003b91082c3ac56790f87af6e4d7d9fe1dec02c2418b198fa28c9c6ce1c67074398c681a353424da9ec6b8a56Verification
pnpm typecheck,pnpm typecheck:browser,pnpm knip, focused ESLint/Oxlint/formatting, andgit diff --check: passed.package.jsonandpnpm-lock.yamlare unchanged; frontend remains 1.54.10 and@comfyorg/comfy-multi-playerremains 0.2.1.Review focus
Confirm canvas-over-graph precedence, exact telemetry tags/context, and that the release-only browser adjustment preserves behavioral coverage after
console.warnbecame structured telemetry.Justification: scoped Agent release backport authorized by the published 1.54 backport grant; source behavior is a stable-patch match and target-specific unit, static, parent-red, and browser acceptance passed before publication.