Repository navigation
[backport core/1.54] fix(agent): follow promoted widget edits and slot connects - #17877
Conversation
…n existing subgraph hosts (#17202) Short-term fix so the agent can edit promoted widgets (S1) and connect slots (S2) on existing subgraph hosts without the follower wiping the host or mis-wiring the link. Creation/promotion (S3/S4), `insert_workflow`, forking and blueprints stay in the long-term plan: [TDD — Agent Subgraph Lifecycle](https://www.notion.so/3d16d73d365081719b85ed515af98276) (V1 = this PR; V1.5 `insert_workflow` cmp op; V2 promote/demote + `fork_definition`; V3 `define_subgraph` + scoped interior ops; V4 blueprints/doc updates). - Promoted `set_widget` on a host no longer wipes its widgets (host storage flips to opaque in one cmp tx; follower now lets the opaque loop own it). - `connect` to a grown host input resolves the slot by name from the subgraph definition (nested definitions included); an undeclared or duplicate name skips the link and reports `error_reconciling_agent_subgraph_host_slot` instead of landing on a random input. - Follower tests RED→GREEN for S1/S2 plus a helper module with its own tests. Includes the scalar-only `nodeDataStore` update path and shared LiteGraph promoted-widget traversal. Browser spec is follow-up #17224. <details><summary>Full context for agent readers</summary> ### Scope Linear [BE-10305](https://linear.app/comfyorg/issue/BE-10305) / FE-2033: S1 promoted-widget edits and S2 slot connects on existing subgraphs are the immediate scope for FE 1.54. S3 promotion, S4 creation, `insert_workflow` as a cmp op (decided 2026-09-08, TDD ADR-T8, phase V1.5), and definition-change tracking are V2+ in the [TDD](https://www.notion.so/3d16d73d365081719b85ed515af98276). Program tracking: [blocked-on-christian #393](christian-byrne/blocked-on-christian#393); DQ-63 (`insert_workflow`) in [#417](christian-byrne/blocked-on-christian#417). Related: #16922 (S4 materializer fix, merged), #16932 (deferred S4 review findings), #16957 (S4 review debt, blocked on #16644), #17224 (Playwright spec for this PR's S1/S2 paths). ### Root causes (verified against cmp `src/applier.ts`) 1. `applyPromotedHostWrite` does `mdel(target,"widgets")` and `mset(target,"__widgets_opaque",next)` in the same transaction. The follower put the host in both `replacedWidgetMaps` and `replacedOpaqueWidgets`, ran `reconcileNode` (positional names, promoted widgets gone) and skipped the opaque loop. 2. cmp writes only the grown slot into the host's doc `inputs`; `target_slot` indexes that doc-local list, while the live host orders inputs by the subgraph definition. Positional wiring hit the wrong slot. 3. `claimPromotedInput` does not validate `grow.name` against the definition. A bogus name used to fall back to the doc index. ### Changes - `agentSubgraphHostSlots.ts`: `indexSubgraphDefinitions` (top-level + nested `definitions.subgraphs`), `promotedWidgetNames(definition, index)` (memoized per `(definition.id, inputIndex)`, active-set cycle detection → cyclic reference is unpromoted, depth cap 32 with cap-truncated answers left unmemoized), `hostInputs`, `hostSlotIndex` — derive host slot order and promoted widget names from `subgraph_definitions`. Duplicate declared names resolve to no slot. - `agentSubgraphDefinitions.ts`: definition projection rejects unsafe collection shapes before consumers traverse them and ignores a top-level definitions root with the wrong Yjs shared type. - `ecsFollowerAdapter.ts`: `hostTarget` resolves target slot/inputs by name and returns `null` on undeclared/duplicate names → link skipped + `reportError('error_reconciling_agent_subgraph_host_slot')`; a changed link that becomes unreadable is disconnected rather than left live; `applyQueuedFrame` opaque loop owns hosts and sets promoted widgets by name; `replacedWidgetMaps` loop skips nodes also in `replacedOpaqueWidgets`; malformed host input entries are ignored; opaque array length mismatch against the promoted list is skipped and reported as `error_reconciling_agent_subgraph_host_widgets`; in-place `Y.Array` edits to opaque host widgets are observed (defensive path for foreign writers; cmp writes plain arrays); drift errors are deduped per session (`TargetSession.reportedErrors`); a failed/rejected batch re-arms `reconcileNextFrame`; live-host scalar resync includes `resizable` and `showAdvanced`. - Tests: `agentSubgraphFollower.test.ts` S1–S1q (promoted write, empty named map, opaque longer/shorter/malformed, non-host fallback, promoted names across load/re-arm/map replace/storage flip, live-field resync incl. `resizable`/`showAdvanced`, in-place Y.Array edit, per-session error dedupe, failed-batch re-arm, plain→host and host→plain type flips) and S2–S2f (declared connect, slot-less doc host, malformed inputs, undeclared name, same-id retarget onto undeclared slot, omitted doc slot keeps live link, slot error dedupe); `agentSubgraphHostSlots.test.ts` (nested definition index, first-wins on repeated id, duplicate names, depth cap, cyclic fan-out resolves in <50 index lookups). ### Verification Current head: `pnpm vitest run src/workbench/extensions/agent/crdt` 36 files / 543 tests green; `pnpm typecheck`, `pnpm lint`, `pnpm format:check`, `pnpm knip`, and changed-scope Fallow green. Blind reviewer thread independently reproduced both P1s (same-id retarget, nested lookup); both fixed in follow-up commits with regression tests. ### Not verified / follow-ups - No Playwright coverage in this PR. Feasible via `browser_tests/tests/agent/agentPanelMocks.ts` + `browser_tests/fixtures/ws.ts`; needs a subgraph workflow fixture → #17224. - No live agent.comfy.org run in this PR. ### Adversarial review (cross-model, Codex) — deferred or rejected - Definition edits not tracked mid-session: S3/S4, TDD V2. - Reuse `SubgraphNode._resolveInputWidget`: follower reads the Y.Doc, not a live node; needs the ECS lookup the TDD introduces. - Promoted names assumed unique: serializer enforces; follower now also treats duplicates as undeclared. ### Decisions made without explicit sign-off - Host owns the promoted value (ADR-SUBGRAPH-PROMOTION-0009); S1 no longer asserts the interior node value. - Opaque array length mismatch → skip + report, not partial apply. - Omitted doc slots keep their live link; nested definitions index first-wins. - Host-origin positional resolution (host as link source) deferred to V2. - `reconcileNode` fallback kept only for non-subgraph opaque nodes. </details> --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit d0dc978)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1922 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-17T00:06:13.492Z",
"gitSha": "e2255737490d1e0582ecbea6b550dd58a778d336",
"branch": "christian-byrne/backport-core-1.54-17202",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2061.5080000000034,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.811000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 600.446,
"heapDeltaBytes": -6601524,
"heapUsedBytes": 62692748,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.564999999999998,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2071.2989999999536,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.899999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 640.1439999999999,
"heapDeltaBytes": -507412,
"heapUsedBytes": 70420120,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 12.728,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1931.7220000000361,
"styleRecalcs": 78,
"styleRecalcDurationMs": 42.668,
"layouts": 14,
"layoutDurationMs": 5.0280000000000005,
"taskDurationMs": 949.245,
"heapDeltaBytes": 7227340,
"heapUsedBytes": 78218200,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 157.005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2028.7590000000364,
"styleRecalcs": 84,
"styleRecalcDurationMs": 54.254000000000005,
"layouts": 14,
"layoutDurationMs": 5.202,
"taskDurationMs": 1054.4660000000001,
"heapDeltaBytes": 810244,
"heapUsedBytes": 70454044,
"domNodes": -278,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 178.297,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.8579999999602,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.975999999999996,
"layouts": 6,
"layoutDurationMs": 1.3110000000000002,
"taskDurationMs": 404.95399999999995,
"heapDeltaBytes": 5093664,
"heapUsedBytes": 76074672,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.682,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.1080000000347,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.641999999999996,
"layouts": 6,
"layoutDurationMs": 1.3820000000000001,
"taskDurationMs": 415.52600000000007,
"heapDeltaBytes": 5125664,
"heapUsedBytes": 75692580,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 14.480000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 694.0859999999702,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.779,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.974,
"heapDeltaBytes": -7847396,
"heapUsedBytes": 62877900,
"domNodes": 16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 162.78199999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 719.3080000000691,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.465,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.001,
"heapDeltaBytes": -7588352,
"heapUsedBytes": 62947988,
"domNodes": 16,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 158.985,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.595999999965,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.229999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.064,
"heapDeltaBytes": -15301444,
"heapUsedBytes": 87234440,
"domNodes": -269,
"jsHeapTotalBytes": -589824,
"scriptDurationMs": 36.699,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2052.622999999926,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.690000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 717.0060000000001,
"heapDeltaBytes": 11797552,
"heapUsedBytes": 87508400,
"domNodes": -274,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 42.431,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2222.04499999998,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.094000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1623.5130000000001,
"heapDeltaBytes": 22303092,
"heapUsedBytes": 88322360,
"domNodes": -276,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 793.935,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2327.2989999999254,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.422999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1712.681,
"heapDeltaBytes": 13089452,
"heapUsedBytes": 89740168,
"domNodes": -272,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 816.4159999999999,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3634.9309999999377,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.478999999999996,
"layouts": 60,
"layoutDurationMs": 13.790000000000001,
"taskDurationMs": 1798.704,
"heapDeltaBytes": 10582620,
"heapUsedBytes": 77028196,
"domNodes": -281,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 808.402,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3586.8689999999788,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.403,
"layouts": 60,
"layoutDurationMs": 13.979000000000001,
"taskDurationMs": 1752.802,
"heapDeltaBytes": 8540776,
"heapUsedBytes": 76001792,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 788.767,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3212.68699999996,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.755,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2016.444,
"heapDeltaBytes": 425084,
"heapUsedBytes": 68115668,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 1002.0760000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3133.7030000000823,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.846999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2006.6280000000002,
"heapDeltaBytes": 25092472,
"heapUsedBytes": 92911356,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 991.9080000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 1998.6999999999853,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.042,
"heapDeltaBytes": 21823144,
"heapUsedBytes": 88033396,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.242999999999995,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2041.0029999999324,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.5349999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 680.9770000000001,
"heapDeltaBytes": 10838000,
"heapUsedBytes": 87226836,
"domNodes": -276,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 39.105,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.9939999999624,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.280000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.053,
"heapDeltaBytes": 13983120,
"heapUsedBytes": 86195868,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 146.013,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.6770000000197,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.592,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.5359999999999,
"heapDeltaBytes": 14535628,
"heapUsedBytes": 86593556,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 145.09900000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2017.0170000000098,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.727000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.2769999999999,
"heapDeltaBytes": -10313076,
"heapUsedBytes": 61793268,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.864,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.5270000000055,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.338999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.78899999999993,
"heapDeltaBytes": -7504616,
"heapUsedBytes": 65465452,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.162000000000003,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1771.6850000000477,
"styleRecalcs": 79,
"styleRecalcDurationMs": 40.806000000000004,
"layouts": 18,
"layoutDurationMs": 5.774,
"taskDurationMs": 869.691,
"heapDeltaBytes": 1552920,
"heapUsedBytes": 74486332,
"domNodes": -293,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 116.89099999999999,
"eventListeners": -222,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1769.5830000000115,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.513999999999996,
"layouts": 18,
"layoutDurationMs": 5.96,
"taskDurationMs": 899.0800000000002,
"heapDeltaBytes": -201476,
"heapUsedBytes": 71310680,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 116.21199999999999,
"eventListeners": -222,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.3299999999317,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.864999999999995,
"layouts": 15,
"layoutDurationMs": 15.818000000000001,
"taskDurationMs": 1074.331,
"heapDeltaBytes": -5375868,
"heapUsedBytes": 87572848,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 36.362,
"eventListeners": 2385,
"totalBlockingTimeMs": 135,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8559.112000000026,
"styleRecalcs": 248,
"styleRecalcDurationMs": 45.253,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6019.457,
"heapDeltaBytes": 9377308,
"heapUsedBytes": 85017704,
"domNodes": -269,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 2693.572,
"eventListeners": -158,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8437.553999999978,
"styleRecalcs": 246,
"styleRecalcDurationMs": 41.031000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5882.308,
"heapDeltaBytes": -13015368,
"heapUsedBytes": 89470256,
"domNodes": -269,
"jsHeapTotalBytes": -102400,
"scriptDurationMs": 2646.921,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18547.34300000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18250.83,
"heapDeltaBytes": -33381248,
"heapUsedBytes": 177949508,
"domNodes": -6548,
"jsHeapTotalBytes": 3133440,
"scriptDurationMs": 319.287,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18533.57200000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18235.602,
"heapDeltaBytes": -12692716,
"heapUsedBytes": 197645560,
"domNodes": -6548,
"jsHeapTotalBytes": 1372160,
"scriptDurationMs": 315.924,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23296.192000000017,
"styleRecalcs": 173,
"styleRecalcDurationMs": 25.411000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23042.983,
"heapDeltaBytes": -17675248,
"heapUsedBytes": 190740768,
"domNodes": -6548,
"jsHeapTotalBytes": -2596864,
"scriptDurationMs": 1014.98,
"eventListeners": -7467,
"totalBlockingTimeMs": 219,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 23994.628000000033,
"styleRecalcs": 178,
"styleRecalcDurationMs": 28.60499999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23877.923,
"heapDeltaBytes": -18845920,
"heapUsedBytes": 191206776,
"domNodes": -6548,
"jsHeapTotalBytes": -5226496,
"scriptDurationMs": 997.1410000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 156,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-node-resize-workload",
"durationMs": 6836.357000000021,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.515,
"layouts": 20,
"layoutDurationMs": 28.845999999999997,
"taskDurationMs": 6786.287999999999,
"heapDeltaBytes": -28425840,
"heapUsedBytes": 176658928,
"domNodes": -6548,
"jsHeapTotalBytes": 6615040,
"scriptDurationMs": 131.757,
"eventListeners": -7471,
"totalBlockingTimeMs": 526,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 7123.90599999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.158,
"layouts": 20,
"layoutDurationMs": 27.867000000000015,
"taskDurationMs": 7068.587999999999,
"heapDeltaBytes": -31316940,
"heapUsedBytes": 179544672,
"domNodes": -6548,
"jsHeapTotalBytes": 6090752,
"scriptDurationMs": 136.18800000000002,
"eventListeners": -7471,
"totalBlockingTimeMs": 570,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9339.323000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9207.873000000001,
"heapDeltaBytes": 7858240,
"heapUsedBytes": 179552708,
"domNodes": 0,
"jsHeapTotalBytes": -7340032,
"scriptDurationMs": 164.03900000000004,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9529.536000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9403.578999999998,
"heapDeltaBytes": -5990972,
"heapUsedBytes": 164349480,
"domNodes": 0,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 168.18,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 596.149999999966,
"styleRecalcs": 11,
"styleRecalcDurationMs": 40.609,
"layouts": 5,
"layoutDurationMs": 5.557,
"taskDurationMs": 202.652,
"heapDeltaBytes": 5125592,
"heapUsedBytes": 74217660,
"domNodes": 139,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 26.497999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 110.52000000006501,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.897000000000002,
"layouts": 2,
"layoutDurationMs": 1.476,
"taskDurationMs": 75.75000000000001,
"heapDeltaBytes": 2956240,
"heapUsedBytes": 71884984,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.26,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333326,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head backport review: no blockers found.
Full context for agent readers
Reviewed production head 97f0b44c94564d7f18a35f8d0fd4dd61d15fafea against core/1.54. Its stable patch ID exactly matches the merged source change. Focused unit tests, lint, typecheck, diff validation, and the cloud Playwright promoted-widget acceptance all pass on the target baseline. Package pins are unchanged. GitHub does not permit approving one's own pull request, so this is an honest comment review rather than an approval. Remote checks and any later human objections remain binding.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.54 #17877 +/- ##
=============================================
+ Coverage 82.98% 83.01% +0.03%
=============================================
Files 2052 2054 +2
Lines 119742 120039 +297
Branches 32803 32914 +111
=============================================
+ Hits 99369 99652 +283
- Misses 20193 20207 +14
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Backports #17202 to
core/1.54after dependency #17871.Changes
Evidence
Target base:
5ad19ef346c247da19a16a42890c23725a1235cdSource commit:
d0dc978a1a4cf670b0a992d8c57381bd56fa9dcfBackport head:
97f0b44c94564d7f18a35f8d0fd4dd61d15fafea73b75978da72d485df7cb054bd44045cecc79ccfpnpm typecheck: passedgit diff --check: passedJustification: OSS maintainer-reviewed contribution — DrJKL approved source change #17202 at exact source head
8d0a074428264406fae7189053a5806b95dcdf42; the source and backport stable patch IDs match and no production code changed in transit.