Skip to content

[backport cloud/1.54] Prevent insertion into a replaced canvas - #17857

Merged
christian-byrne merged 1 commit into
cloud/1.54from
christian-byrne/backport-cloud-1.54-16478
Sep 17, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
christian-byrne/backport-cloud-1.54-16478

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backports source PR 16478 to cloud/1.54.

  • Prevents stale async insertion after the active canvas or graph changes.
  • Leaves frontend 1.54.10 and multiplayer 0.2.1 pins unchanged.
  • PR 17593 is the next mapped dependency and must follow this backport.
Full context for agent readers

Summary

Captures the insertion target before loading workflow JSON, then aborts if either the canvas identity or its graph identity changes before deserialization.

Changes

  • What: Cherry-picks merged source commit eefcc56d5d56cacbd6177463abe9080c917ab5ff with -x.
  • Dependencies: No package, lockfile, distribution, backend, CRDT, or catalog changes.

Verification

  • workflowService.test.ts: 106/106 passed, including unchanged success, canvas replacement, and same-canvas graph replacement.
  • pnpm typecheck, pnpm knip, scoped formatter, ESLint, and Oxlint: passed.
  • Source/backport stable patch ID: e5ac5964e44454c54e971c6d97df3e313c86b5af.
  • Agent flag on/off: this service and both insertion call sites have no agent-in-app-experience or distribution conditional, so the stale-target guard is identical in both states.
  • Pins: package and lockfile blobs are byte-identical before/after; frontend remains 1.54.10, @comfyorg/comfy-multi-player remains exact 0.2.1.

Browser limitation

A cloud-distribution replay was attempted against the local test backend. The harness remained on the loading splash because cloud settings and workflow API bootstrap returned 401/500 before the insertion path rendered. The recording was inspected; this PR does not claim browser-path verification.

Review focus

Confirm stale insertion should abort rather than redirect into the newly active canvas. After this merges, backport PR 17593 to restore telemetry for the abort path.

## Summary

Prevent an asynchronously loaded workflow from being inserted after its
target canvas has been replaced.

## Changes

- **What**: Capture the target canvas before loading and abort if
`app.canvas` changes; add a permanent regression test covering both the
old and replacement canvases.

## Review Focus

Please verify that aborting the stale insertion is preferable to
redirecting it into the newly active canvas. This extracts only the
canvas-identity race fix from frozen PR #16448 and deliberately excludes
its rejected selection-mode blocking.

## Screenshots (if applicable)

Not applicable; behavior is covered by the focused unit test.

Justification: Christian approved the proposed merge path in
blocked-on-christian #330 and explicitly authorized ignoring the newly
introduced feature-flag-policy failure for this previously approved fix.

---------

Co-authored-by: Pipeline Agent <agent@pipeline.local>
(cherry picked from commit eefcc56)
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 067c69ec-6a17-4411-bb41-dfef8edf1a85

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 16, 2026 8:28pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1920 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1899 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/16/2026, 08:31:45 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 148ms TBT · 83.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.1 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 107ms TBT · 175.7 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 472ms TBT · 177.0 MB heap
vue-zoom-out-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 500ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 55.6 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -145
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 47ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 82
canvas-mouse-sweep: task duration 1010ms
canvas-mouse-sweep: script duration 180ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.1 MB
canvas-mouse-sweep: DOM nodes -276
canvas-mouse-sweep: event listeners -146
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 370ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.7 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 455ms
dom-widget-clipping: script duration 164ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.1 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 637ms
large-graph-idle: script duration 39ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.5 MB
large-graph-idle: DOM nodes -269
large-graph-idle: event listeners -157
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1695ms
large-graph-pan: script duration 842ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 80.4 MB
large-graph-pan: DOM nodes -273
large-graph-pan: event listeners -83
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1701ms
large-graph-zoom: script duration 777ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.8 MB
large-graph-zoom: DOM nodes -139
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1955ms
legacy-node-drag: script duration 970ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 85.8 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 599ms
minimap-idle: script duration 37ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.5 MB
minimap-idle: DOM nodes -272
minimap-idle: event listeners -157
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 13ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 434ms
subgraph-dom-widget-clipping: script duration 148ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.9 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 8
subgraph-idle: task duration 491ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 74.4 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -220
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 39ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 857ms
subgraph-mouse-sweep: script duration 115ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 71.8 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -206
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 975ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 148ms
subgraph-transition-enter: heap used 83.4 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 34ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 246
viewport-pan-sweep: task duration 6028ms
viewport-pan-sweep: script duration 2742ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.2 MB
viewport-pan-sweep: DOM nodes -271
viewport-pan-sweep: event listeners -141
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16715ms
vue-large-graph-idle: script duration 282ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.1 MB
vue-large-graph-idle: DOM nodes -6550
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 169
vue-large-graph-pan: task duration 20939ms
vue-large-graph-pan: script duration 956ms
vue-large-graph-pan: TBT 107ms
vue-large-graph-pan: heap used 175.7 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7469
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 84ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6122ms
vue-node-resize-workload: script duration 115ms
vue-node-resize-workload: TBT 472ms
vue-node-resize-workload: heap used 177.0 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7472
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8490ms
vue-zoom-out-idle: script duration 142ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 168.1 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -10
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 20ms
workflow-execution: layout count 3
workflow-execution: style recalc count 14
workflow-execution: task duration 100ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.5 MB
workflow-execution: DOM nodes 128
workflow-execution: event listeners 49
Raw data
{
  "timestamp": "2026-09-16T20:40:01.870Z",
  "gitSha": "637a895cc02293148c897cdfe720de1515d3e84a",
  "branch": "christian-byrne/backport-cloud-1.54-16478",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2054.0299999999547,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.417,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 505.33399999999995,
      "heapDeltaBytes": -11972852,
      "heapUsedBytes": 58998048,
      "domNodes": -277,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.173,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2043.9849999999637,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.335000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 494.66299999999995,
      "heapDeltaBytes": -5859916,
      "heapUsedBytes": 57507224,
      "domNodes": -282,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 8.738,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2131.553999999994,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 48.344,
      "layouts": 14,
      "layoutDurationMs": 4.8790000000000004,
      "taskDurationMs": 1082.085,
      "heapDeltaBytes": 7598116,
      "heapUsedBytes": 78294284,
      "domNodes": -277,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 183.941,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1921.8740000000025,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 44.743,
      "layouts": 14,
      "layoutDurationMs": 4.829,
      "taskDurationMs": 937.5159999999998,
      "heapDeltaBytes": -8420172,
      "heapUsedBytes": 62509204,
      "domNodes": -275,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 175.733,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1677.5759999999877,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.694,
      "layouts": 6,
      "layoutDurationMs": 1.084,
      "taskDurationMs": 362.065,
      "heapDeltaBytes": 4985124,
      "heapUsedBytes": 75906660,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.18,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1753.3580000000484,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 18.769000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.1400000000000001,
      "taskDurationMs": 377.44199999999995,
      "heapDeltaBytes": 4732800,
      "heapUsedBytes": 74544076,
      "domNodes": 78,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 11.385,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 684.6289999999726,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.033000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 454.56299999999993,
      "heapDeltaBytes": 18147064,
      "heapUsedBytes": 88025424,
      "domNodes": 16,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 164.963,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 648.5199999999622,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.111,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 455.2630000000001,
      "heapDeltaBytes": 18136332,
      "heapUsedBytes": 88243084,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 162.736,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2052.331000000038,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.837999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 650.954,
      "heapDeltaBytes": 10655884,
      "heapUsedBytes": 87408168,
      "domNodes": -271,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 40.048,
      "eventListeners": -172,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2056.3680000000204,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.689999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 623.3549999999999,
      "heapDeltaBytes": 11586276,
      "heapUsedBytes": 87720784,
      "domNodes": -266,
      "jsHeapTotalBytes": -888832,
      "scriptDurationMs": 37.154,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2378.3520000000067,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.654999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1708.611,
      "heapDeltaBytes": 6974672,
      "heapUsedBytes": 83509316,
      "domNodes": -275,
      "jsHeapTotalBytes": 122880,
      "scriptDurationMs": 830.932,
      "eventListeners": -172,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2394.4529999999986,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.118999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1681.9810000000002,
      "heapDeltaBytes": 18652484,
      "heapUsedBytes": 85002552,
      "domNodes": -271,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 853.049,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3555.917000000022,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.680000000000001,
      "layouts": 60,
      "layoutDurationMs": 11.713999999999999,
      "taskDurationMs": 1720.081,
      "heapDeltaBytes": 12042280,
      "heapUsedBytes": 80022828,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 789.525,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3601.3209999999845,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.686999999999998,
      "layouts": 60,
      "layoutDurationMs": 11.823,
      "taskDurationMs": 1681.0029999999997,
      "heapDeltaBytes": 9943940,
      "heapUsedBytes": 76760736,
      "domNodes": -278,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 763.563,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3153.4980000000132,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.051,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1963.1180000000002,
      "heapDeltaBytes": 22674848,
      "heapUsedBytes": 89693372,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 969.54,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3070.312000000058,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.853999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1946.611,
      "heapDeltaBytes": 22125228,
      "heapUsedBytes": 90347052,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 969.505,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2045.8130000000097,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 8.013000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 598.9739999999999,
      "heapDeltaBytes": 10379548,
      "heapUsedBytes": 87682612,
      "domNodes": -273,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 38.032,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2034.2540000000326,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 5.502,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 598.4580000000002,
      "heapDeltaBytes": 10681300,
      "heapUsedBytes": 87475308,
      "domNodes": -270,
      "jsHeapTotalBytes": -2461696,
      "scriptDurationMs": 35.11500000000001,
      "eventListeners": -172,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 640.8369999999763,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 13.203999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 439.30199999999996,
      "heapDeltaBytes": 14721152,
      "heapUsedBytes": 87863812,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 149.367,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 588.6929999999211,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 12.051999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 428.893,
      "heapDeltaBytes": 15185692,
      "heapUsedBytes": 88187332,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 145.84999999999997,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.376000000013,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.602999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 487.40199999999993,
      "heapDeltaBytes": 5444672,
      "heapUsedBytes": 77671904,
      "domNodes": -299,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.925999999999999,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.373000000016,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.190000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 495.081,
      "heapDeltaBytes": 6613744,
      "heapUsedBytes": 78285544,
      "domNodes": -294,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.689999999999999,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1755.5100000000152,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 40.162000000000006,
      "layouts": 18,
      "layoutDurationMs": 6.014,
      "taskDurationMs": 859.6170000000001,
      "heapDeltaBytes": 7206920,
      "heapUsedBytes": 79451000,
      "domNodes": -294,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 114.133,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1707.3019999999701,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 38.66,
      "layouts": 18,
      "layoutDurationMs": 6.026,
      "taskDurationMs": 854.1089999999999,
      "heapDeltaBytes": -987372,
      "heapUsedBytes": 71156704,
      "domNodes": -296,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 116.425,
      "eventListeners": -222,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1417.599999999993,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 33.278,
      "layouts": 15,
      "layoutDurationMs": 15.853,
      "taskDurationMs": 975.465,
      "heapDeltaBytes": -5581616,
      "heapUsedBytes": 87399188,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 33.38,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 148,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8965.238999999998,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 36.142999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6131.812,
      "heapDeltaBytes": -17001884,
      "heapUsedBytes": 85406124,
      "domNodes": -267,
      "jsHeapTotalBytes": -921600,
      "scriptDurationMs": 2771.9020000000005,
      "eventListeners": -126,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8543.079000000034,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 32.366,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5924.963,
      "heapDeltaBytes": 13115780,
      "heapUsedBytes": 89012548,
      "domNodes": -274,
      "jsHeapTotalBytes": -925696,
      "scriptDurationMs": 2712.5370000000003,
      "eventListeners": -156,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17380.57200000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16815.668999999998,
      "heapDeltaBytes": -33283084,
      "heapUsedBytes": 177190788,
      "domNodes": -6548,
      "jsHeapTotalBytes": -2838528,
      "scriptDurationMs": 290.827,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17044.783999999934,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16614.049,
      "heapDeltaBytes": -33006132,
      "heapUsedBytes": 177381188,
      "domNodes": -6552,
      "jsHeapTotalBytes": -2207744,
      "scriptDurationMs": 273.32800000000003,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21167.72800000001,
      "styleRecalcs": 164,
      "styleRecalcDurationMs": 19.284999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20823.966,
      "heapDeltaBytes": -21436640,
      "heapUsedBytes": 182745672,
      "domNodes": -6548,
      "jsHeapTotalBytes": 4968448,
      "scriptDurationMs": 951.6560000000001,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 120,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21330.857000000036,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 20.03100000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21054.949,
      "heapDeltaBytes": -25287600,
      "heapUsedBytes": 185744884,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5226496,
      "scriptDurationMs": 960.773,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 93,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6198.921999999982,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 87.90999999999998,
      "layouts": 20,
      "layoutDurationMs": 23.594000000000005,
      "taskDurationMs": 6090.946000000001,
      "heapDeltaBytes": -23310964,
      "heapUsedBytes": 180210828,
      "domNodes": -6548,
      "jsHeapTotalBytes": 16072704,
      "scriptDurationMs": 113.49,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 494,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6247.16699999999,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.47099999999996,
      "layouts": 20,
      "layoutDurationMs": 22.757999999999985,
      "taskDurationMs": 6153.522000000001,
      "heapDeltaBytes": -11777440,
      "heapUsedBytes": 191028904,
      "domNodes": -6548,
      "jsHeapTotalBytes": 18337792,
      "scriptDurationMs": 116.03999999999999,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 449,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8891.338000000018,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8537.054,
      "heapDeltaBytes": 4255168,
      "heapUsedBytes": 176188256,
      "domNodes": 0,
      "jsHeapTotalBytes": -2359296,
      "scriptDurationMs": 148.20299999999997,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8699.34999999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8443.637,
      "heapDeltaBytes": 12223228,
      "heapUsedBytes": 176269876,
      "domNodes": 0,
      "jsHeapTotalBytes": -10485760,
      "scriptDurationMs": 135.67400000000006,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 476.8139999999903,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 24.568999999999996,
      "layouts": 4,
      "layoutDurationMs": 2.172,
      "taskDurationMs": 127.11699999999998,
      "heapDeltaBytes": 5039004,
      "heapUsedBytes": 73726820,
      "domNodes": 147,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 11.978,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 105.09100000001581,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 15.762000000000002,
      "layouts": 2,
      "layoutDurationMs": 0.7719999999999999,
      "taskDurationMs": 73.024,
      "heapDeltaBytes": 3034612,
      "heapUsedBytes": 71938400,
      "domNodes": 108,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.803,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 49884 74426 67.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1159
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.2% 303
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.6% 261
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.8% 251
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 16, 2026
@codecov

codecov Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #17857   +/-   ##
=============================================
  Coverage              ?   82.98%           
=============================================
  Files                 ?     2052           
  Lines                 ?   119721           
  Branches              ?    30971           
=============================================
  Hits                  ?    99353           
  Misses                ?    20188           
  Partials              ?      180           
Flag Coverage Δ
e2e 67.05% <66.66%> (?)
unit 77.55% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...platform/workflow/core/services/workflowService.ts 96.98% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit 8dedeb8 into cloud/1.54 Sep 17, 2026
94 checks passed
@christian-byrne
christian-byrne deleted the christian-byrne/backport-cloud-1.54-16478 branch September 17, 2026 00:24
DrJKL pushed a commit that referenced this pull request Sep 17, 2026
Backports [source PR
17593](#17593) to
`cloud/1.54` after prerequisite [PR
17857](#17857).

- Reports both existing stale-insertion abort paths through the shared
telemetry fan-out.
- Preserves insertion behavior and exact frontend/multiplayer pins.
- Exact-target browser acceptance passed with the Agent flag off and on.

<details><summary>Full context for agent readers</summary>

## Summary

Replaces the abort-path console warning with a soft `reportError` event
carrying stable tags and `replacement_kind=canvas|graph`. The
stale-target guard and normal insertion behavior are unchanged.

## Changes

- **What**: Cherry-picks merged source commit
`01e69f3ab9bf39598c28e8b76a9adc13edbfd32e` with `-x`; source and
backport stable patch IDs are both
`28c9c6ce1c67074398c681a353424da9ec6b8a56`.
- **Dependencies**: Requires the stale-target guard already merged
through PR 17857. No package, lockfile, backend, catalog, CRDT, or
distribution changes.

## Verification

- `workflowService.test.ts`: 106/106 passed.
- `pnpm typecheck`, `pnpm knip`, scoped Oxlint, and scoped formatter:
passed.
- Temporary browser acceptance: 6/6 passed against this exact
head—normal insertion, whole-canvas replacement, and same-canvas graph
replacement with Agent flag off/on. Both abort cases emitted exactly one
`workflow_insert_aborted_canvas_changed` warning with the required tags
and replacement context; normal insertion emitted none.
- Parent red proof: all four replacement cases failed because the prior
target emitted no telemetry.
- Temporary acceptance spec passed browser typecheck, ESLint, Oxlint,
and formatting, then was removed.
- Pins: `package.json` and `pnpm-lock.yaml` are byte-identical
before/after; frontend remains `1.54.10` and
`@comfyorg/comfy-multi-player` remains exact `0.2.1`.

## Linear

Exempt: release-only backport of already-merged source PR 17593; no new
product scope.

## Review Focus

Confirm canvas-over-graph precedence and exact telemetry tags/context.
The replacement guard itself is carried by prerequisite PR 17857.

</details>

<!-- authored-by:agent release-backport-cloud -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants