Repository navigation
[backport cloud/1.54] Report insert abort telemetry - #17883
Conversation
## Summary `insertWorkflow` aborts silently when `app.canvas` or `app.canvas.graph` is replaced while the workflow JSON is loading (for example the user opened another tab mid-insert). The abort is correct behaviour, but it left no trace: the caller sees nothing inserted and telemetry sees nothing at all. This PR keeps the early return and reports it through `reportError` as a soft-assert warning so the case is countable in Sentry: - `error_type=workflow_insert_aborted_canvas_changed` - tags `failure_kind=degraded`, `feature_area=workflow`, `operation=insert`, `outcome=degraded`, `assert_mode=soft` - context `replacement_kind` = `canvas` (canvas object swapped) or `graph` (same canvas, graph swapped). Canvas takes precedence when both changed. No behavioural change to insertion itself. ## Evidence - Local: `pnpm vitest run src/platform/workflow/core/services/workflowService.test.ts` -> 1 file passed, 106/106 tests passed (5.85s). The two existing race tests (`canvas replaced`, `graph changed`) now also assert exactly one `reportError` call with the tags above and the matching `replacement_kind`; the positive-control test still asserts zero calls. - `oxlint` on the two touched files: clean. - Branch head: `9df88742c6415ec528800b73e28b56e7442316f0` on `c4afd4750b8c63d59d914db962e1f73a11167064` (origin/main). ## Notes for reviewers Tag values `operation=insert` and `outcome=degraded` are new to the agent telemetry taxonomy (program ADR-029); the registry amendment is landing in the program repo alongside this PR. Veto points: canvas-over-graph precedence for `replacement_kind`, and the exact Error message text. Program row: tele-22. <!-- authored-by:agent role-hard-problem --> (cherry picked from commit 01e69f3)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1920 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-17T01:06:16.958Z",
"gitSha": "538a40896d5f35d51883fa88dc5dc962b18127ff",
"branch": "backport/cloud-1.54-workflow-insert-abort-telemetry",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2108.5310000000277,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.724,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.8169999999999,
"heapDeltaBytes": -11714788,
"heapUsedBytes": 58998168,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.661999999999999,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2024.2769999999837,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.856000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.55000000000007,
"heapDeltaBytes": -13325716,
"heapUsedBytes": 57158008,
"domNodes": -277,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.748000000000001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1746.4879999999994,
"styleRecalcs": 75,
"styleRecalcDurationMs": 26.339999999999996,
"layouts": 14,
"layoutDurationMs": 3.4790000000000005,
"taskDurationMs": 716.1919999999999,
"heapDeltaBytes": 1211424,
"heapUsedBytes": 71389556,
"domNodes": -279,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 112.26299999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1734.6229999999423,
"styleRecalcs": 74,
"styleRecalcDurationMs": 26.177,
"layouts": 14,
"layoutDurationMs": 3.483,
"taskDurationMs": 720.1840000000001,
"heapDeltaBytes": 1571772,
"heapUsedBytes": 72273856,
"domNodes": -277,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 115.14000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.346000000009,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.234,
"layouts": 6,
"layoutDurationMs": 1.1209999999999998,
"taskDurationMs": 328.122,
"heapDeltaBytes": 4717676,
"heapUsedBytes": 74842456,
"domNodes": 79,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.809,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1658.5380000000214,
"styleRecalcs": 29,
"styleRecalcDurationMs": 12.343000000000002,
"layouts": 6,
"layoutDurationMs": 0.907,
"taskDurationMs": 285.735,
"heapDeltaBytes": 4404852,
"heapUsedBytes": 74279548,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8.946000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 550.5309999999781,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.9079999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.838,
"heapDeltaBytes": 18478596,
"heapUsedBytes": 88599940,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 132.13000000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 527.3339999999962,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.743000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.202,
"heapDeltaBytes": 18439796,
"heapUsedBytes": 88587892,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 122.031,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2022.196000000008,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.422999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.284,
"heapDeltaBytes": 11291952,
"heapUsedBytes": 87732664,
"domNodes": -267,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 35.772,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2028.4659999999803,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.213999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.697,
"heapDeltaBytes": 10687176,
"heapUsedBytes": 87141584,
"domNodes": -269,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 29.959999999999994,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2131.8789999999694,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.557000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1399.2689999999998,
"heapDeltaBytes": 4155432,
"heapUsedBytes": 80837668,
"domNodes": -268,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 664.037,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2112.86599999994,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.471999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1203.1670000000001,
"heapDeltaBytes": 22721440,
"heapUsedBytes": 89041676,
"domNodes": -268,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 578.545,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3329.5409999999492,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.029000000000002,
"layouts": 60,
"layoutDurationMs": 13.187000000000001,
"taskDurationMs": 1465.6219999999998,
"heapDeltaBytes": 8423372,
"heapUsedBytes": 76012220,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 637.926,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3182.961999999975,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.061000000000002,
"layouts": 60,
"layoutDurationMs": 11.453999999999999,
"taskDurationMs": 1351.8349999999998,
"heapDeltaBytes": -2002396,
"heapUsedBytes": 76506984,
"domNodes": -272,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 574.8350000000002,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2380.800000000022,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.476999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1547.4050000000002,
"heapDeltaBytes": 18344772,
"heapUsedBytes": 85029932,
"domNodes": -9,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 744.049,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2250.599999999963,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.825,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1435.352,
"heapDeltaBytes": 14225284,
"heapUsedBytes": 81804052,
"domNodes": -274,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 687.925,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2039.420000000007,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.460000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.50399999999996,
"heapDeltaBytes": 10226652,
"heapUsedBytes": 87581112,
"domNodes": -266,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 31.456999999999997,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2050.092999999947,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.045,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.3789999999999,
"heapDeltaBytes": 10261648,
"heapUsedBytes": 86527316,
"domNodes": -269,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 29.741000000000003,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 553.4260000000017,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.352,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.92500000000007,
"heapDeltaBytes": 14334476,
"heapUsedBytes": 86559696,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 114.926,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 512.1629999999868,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.621,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 309.21,
"heapDeltaBytes": 14282732,
"heapUsedBytes": 79798468,
"domNodes": 18,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 102.19,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.941000000007,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.244999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.172,
"heapDeltaBytes": -12211880,
"heapUsedBytes": 60783220,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.062999999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1996.6849999999567,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.839999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.576,
"heapDeltaBytes": 141560,
"heapUsedBytes": 64485796,
"domNodes": 22,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7.5180000000000025,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.2680000000423,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.860999999999997,
"layouts": 18,
"layoutDurationMs": 4.2170000000000005,
"taskDurationMs": 725.506,
"heapDeltaBytes": -827532,
"heapUsedBytes": 71355600,
"domNodes": -293,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 85.372,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.012000000048,
"styleRecalcs": 79,
"styleRecalcDurationMs": 27.388999999999996,
"layouts": 18,
"layoutDurationMs": 3.86,
"taskDurationMs": 680.491,
"heapDeltaBytes": -1744436,
"heapUsedBytes": 70532360,
"domNodes": -291,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 78.31600000000002,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 899.2350000000329,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.076999999999995,
"layouts": 16,
"layoutDurationMs": 10.477,
"taskDurationMs": 712.8839999999999,
"heapDeltaBytes": 21850392,
"heapUsedBytes": 106170792,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 22.037000000000003,
"eventListeners": 2385,
"totalBlockingTimeMs": 110,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8148.454000000015,
"styleRecalcs": 249,
"styleRecalcDurationMs": 34.292,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4737.648,
"heapDeltaBytes": 13589760,
"heapUsedBytes": 89689552,
"domNodes": -258,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 2105.333,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8133.718000000044,
"styleRecalcs": 248,
"styleRecalcDurationMs": 27.981999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4488.784,
"heapDeltaBytes": 10716856,
"heapUsedBytes": 86429356,
"domNodes": -266,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 1975.4260000000002,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13747.76099999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12887.616999999998,
"heapDeltaBytes": -36216396,
"heapUsedBytes": 174769572,
"domNodes": -6548,
"jsHeapTotalBytes": -6205440,
"scriptDurationMs": 217.14899999999997,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 12679.269999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12136.561,
"heapDeltaBytes": -45519036,
"heapUsedBytes": 175926248,
"domNodes": -6548,
"jsHeapTotalBytes": -4136960,
"scriptDurationMs": 187.677,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17227.84100000001,
"styleRecalcs": 138,
"styleRecalcDurationMs": 17.541999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16805.41,
"heapDeltaBytes": -27280484,
"heapUsedBytes": 181177680,
"domNodes": -6548,
"jsHeapTotalBytes": -2740224,
"scriptDurationMs": 857.101,
"eventListeners": -7471,
"totalBlockingTimeMs": 14,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 16554.426000000036,
"styleRecalcs": 118,
"styleRecalcDurationMs": 16.167000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15993.027999999998,
"heapDeltaBytes": -22304824,
"heapUsedBytes": 187668892,
"domNodes": -6548,
"jsHeapTotalBytes": -2301952,
"scriptDurationMs": 785.5419999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 15,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4788.429000000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.40500000000002,
"layouts": 20,
"layoutDurationMs": 24.155999999999995,
"taskDurationMs": 4682.529,
"heapDeltaBytes": -25346060,
"heapUsedBytes": 177862708,
"domNodes": -6548,
"jsHeapTotalBytes": 13602816,
"scriptDurationMs": 86.306,
"eventListeners": -7473,
"totalBlockingTimeMs": 183,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4868.003000000044,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.34200000000001,
"layouts": 20,
"layoutDurationMs": 22.611000000000008,
"taskDurationMs": 4717.5869999999995,
"heapDeltaBytes": -36686256,
"heapUsedBytes": 180447792,
"domNodes": -6548,
"jsHeapTotalBytes": 12513280,
"scriptDurationMs": 89.027,
"eventListeners": -7473,
"totalBlockingTimeMs": 103,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6935.146999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6519.053,
"heapDeltaBytes": 9300600,
"heapUsedBytes": 174749088,
"domNodes": -2,
"jsHeapTotalBytes": -11272192,
"scriptDurationMs": 155.26200000000006,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6851.233999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6432.495999999998,
"heapDeltaBytes": 488952,
"heapUsedBytes": 175236328,
"domNodes": 0,
"jsHeapTotalBytes": -9437184,
"scriptDurationMs": 108.82799999999997,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 474.51599999999416,
"styleRecalcs": 17,
"styleRecalcDurationMs": 18.273999999999997,
"layouts": 4,
"layoutDurationMs": 1.652,
"taskDurationMs": 105.281,
"heapDeltaBytes": 5054224,
"heapUsedBytes": 73912036,
"domNodes": 147,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.094,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 447.544999999991,
"styleRecalcs": 16,
"styleRecalcDurationMs": 16.281999999999996,
"layouts": 3,
"layoutDurationMs": 1.223,
"taskDurationMs": 83.75399999999999,
"heapDeltaBytes": 4832796,
"heapUsedBytes": 73062256,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.501999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #17883 +/- ##
=============================================
Coverage ? 82.97%
=============================================
Files ? 2052
Lines ? 119722
Branches ? 32795
=============================================
Hits ? 99345
Misses ? 20197
Partials ? 180
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backports source PR 17593 to
cloud/1.54after prerequisite PR 17857.Full context for agent readers
Summary
Replaces the abort-path console warning with a soft
reportErrorevent carrying stable tags andreplacement_kind=canvas|graph. The stale-target guard and normal insertion behavior are unchanged.Changes
01e69f3ab9bf39598c28e8b76a9adc13edbfd32ewith-x; source and backport stable patch IDs are both28c9c6ce1c67074398c681a353424da9ec6b8a56.Verification
workflowService.test.ts: 106/106 passed.pnpm typecheck,pnpm knip, scoped Oxlint, and scoped formatter: passed.workflow_insert_aborted_canvas_changedwarning with the required tags and replacement context; normal insertion emitted none.package.jsonandpnpm-lock.yamlare byte-identical before/after; frontend remains1.54.10and@comfyorg/comfy-multi-playerremains exact0.2.1.Linear
Exempt: release-only backport of already-merged source PR 17593; no new product scope.
Review Focus
Confirm canvas-over-graph precedence and exact telemetry tags/context. The replacement guard itself is carried by prerequisite PR 17857.