Skip to content

[backport cloud/1.54] Report insert abort telemetry - #17883

Merged
DrJKL merged 1 commit into
cloud/1.54from
backport/cloud-1.54-workflow-insert-abort-telemetry
Sep 17, 2026
Merged

DrJKL merged 1 commit into
cloud/1.54from
backport/cloud-1.54-workflow-insert-abort-telemetry

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backports source PR 17593 to cloud/1.54 after prerequisite PR 17857.

  • Reports both existing stale-insertion abort paths through the shared telemetry fan-out.
  • Preserves insertion behavior and exact frontend/multiplayer pins.
  • Exact-target browser acceptance passed with the Agent flag off and on.
Full context for agent readers

Summary

Replaces the abort-path console warning with a soft reportError event carrying stable tags and replacement_kind=canvas|graph. The stale-target guard and normal insertion behavior are unchanged.

Changes

  • What: Cherry-picks merged source commit 01e69f3ab9bf39598c28e8b76a9adc13edbfd32e with -x; source and backport stable patch IDs are both 28c9c6ce1c67074398c681a353424da9ec6b8a56.
  • Dependencies: Requires the stale-target guard already merged through PR 17857. No package, lockfile, backend, catalog, CRDT, or distribution changes.

Verification

  • workflowService.test.ts: 106/106 passed.
  • pnpm typecheck, pnpm knip, scoped Oxlint, and scoped formatter: passed.
  • Temporary browser acceptance: 6/6 passed against this exact head—normal insertion, whole-canvas replacement, and same-canvas graph replacement with Agent flag off/on. Both abort cases emitted exactly one workflow_insert_aborted_canvas_changed warning with the required tags and replacement context; normal insertion emitted none.
  • Parent red proof: all four replacement cases failed because the prior target emitted no telemetry.
  • Temporary acceptance spec passed browser typecheck, ESLint, Oxlint, and formatting, then was removed.
  • Pins: package.json and pnpm-lock.yaml are byte-identical before/after; frontend remains 1.54.10 and @comfyorg/comfy-multi-player remains exact 0.2.1.

Linear

Exempt: release-only backport of already-merged source PR 17593; no new product scope.

Review Focus

Confirm canvas-over-graph precedence and exact telemetry tags/context. The replacement guard itself is carried by prerequisite PR 17857.

## Summary

`insertWorkflow` aborts silently when `app.canvas` or `app.canvas.graph`
is replaced while the workflow JSON is loading (for example the user
opened another tab mid-insert). The abort is correct behaviour, but it
left no trace: the caller sees nothing inserted and telemetry sees
nothing at all.

This PR keeps the early return and reports it through `reportError` as a
soft-assert warning so the case is countable in Sentry:

- `error_type=workflow_insert_aborted_canvas_changed`
- tags `failure_kind=degraded`, `feature_area=workflow`,
`operation=insert`, `outcome=degraded`, `assert_mode=soft`
- context `replacement_kind` = `canvas` (canvas object swapped) or
`graph` (same canvas, graph swapped). Canvas takes precedence when both
changed.

No behavioural change to insertion itself.

## Evidence

- Local: `pnpm vitest run
src/platform/workflow/core/services/workflowService.test.ts` -> 1 file
passed, 106/106 tests passed (5.85s). The two existing race tests
(`canvas replaced`, `graph changed`) now also assert exactly one
`reportError` call with the tags above and the matching
`replacement_kind`; the positive-control test still asserts zero calls.
- `oxlint` on the two touched files: clean.
- Branch head: `9df88742c6415ec528800b73e28b56e7442316f0` on
`c4afd4750b8c63d59d914db962e1f73a11167064` (origin/main).

## Notes for reviewers

Tag values `operation=insert` and `outcome=degraded` are new to the
agent telemetry taxonomy (program ADR-029); the registry amendment is
landing in the program repo alongside this PR. Veto points:
canvas-over-graph precedence for `replacement_kind`, and the exact Error
message text.

Program row: tele-22.

<!-- authored-by:agent role-hard-problem -->

(cherry picked from commit 01e69f3)
@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 17, 2026 12:55am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: dbbd8b4c-7208-4505-93dc-566dd9e1c714

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1920 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1899 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/17/2026, 12:57:00 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 110ms TBT · 101.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
vue-large-graph-idle: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.2 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 15ms TBT · 175.9 MB heap
vue-node-resize-workload: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 143ms TBT · 170.9 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 166.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 483ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 55.4 MB
canvas-idle: DOM nodes -278
canvas-idle: event listeners -145
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 26ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 718ms
canvas-mouse-sweep: script duration 114ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 68.5 MB
canvas-mouse-sweep: DOM nodes -278
canvas-mouse-sweep: event listeners -175
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 307ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.1 MB
canvas-zoom-sweep: DOM nodes 79
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 5ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 366ms
dom-widget-clipping: script duration 127ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.5 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 537ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.4 MB
large-graph-idle: DOM nodes -268
large-graph-idle: event listeners -172
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1301ms
large-graph-pan: script duration 621ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 81.0 MB
large-graph-pan: DOM nodes -268
large-graph-pan: event listeners -84
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1409ms
large-graph-zoom: script duration 606ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.7 MB
large-graph-zoom: DOM nodes -134
large-graph-zoom: event listeners -80
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1491ms
legacy-node-drag: script duration 716ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 79.6 MB
legacy-node-drag: DOM nodes -142
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 506ms
minimap-idle: script duration 31ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.0 MB
minimap-idle: DOM nodes -268
minimap-idle: event listeners -170
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 7ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 329ms
subgraph-dom-widget-clipping: script duration 109ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 79.3 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 405ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 59.7 MB
subgraph-idle: DOM nodes -137
subgraph-idle: event listeners -93
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 28ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 703ms
subgraph-mouse-sweep: script duration 82ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 67.7 MB
subgraph-mouse-sweep: DOM nodes -292
subgraph-mouse-sweep: event listeners -220
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 24ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 713ms
subgraph-transition-enter: script duration 22ms
subgraph-transition-enter: TBT 110ms
subgraph-transition-enter: heap used 101.3 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 31ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4613ms
viewport-pan-sweep: script duration 2040ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 84.0 MB
viewport-pan-sweep: DOM nodes -262
viewport-pan-sweep: event listeners -155
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 12512ms
vue-large-graph-idle: script duration 202ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 167.2 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7475
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 128
vue-large-graph-pan: task duration 16399ms
vue-large-graph-pan: script duration 821ms
vue-large-graph-pan: TBT 15ms
vue-large-graph-pan: heap used 175.9 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7471
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 65ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4700ms
vue-node-resize-workload: script duration 88ms
vue-node-resize-workload: TBT 143ms
vue-node-resize-workload: heap used 170.9 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7473
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6476ms
vue-zoom-out-idle: script duration 132ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 166.9 MB
vue-zoom-out-idle: DOM nodes -1
vue-zoom-out-idle: event listeners -10
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 4
workflow-execution: style recalc count 17
workflow-execution: task duration 95ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.1 MB
workflow-execution: DOM nodes 134
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-09-17T01:06:16.958Z",
  "gitSha": "538a40896d5f35d51883fa88dc5dc962b18127ff",
  "branch": "backport/cloud-1.54-workflow-insert-abort-telemetry",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2108.5310000000277,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.724,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 526.8169999999999,
      "heapDeltaBytes": -11714788,
      "heapUsedBytes": 58998168,
      "domNodes": -279,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.661999999999999,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2024.2769999999837,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.856000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 439.55000000000007,
      "heapDeltaBytes": -13325716,
      "heapUsedBytes": 57158008,
      "domNodes": -277,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.748000000000001,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1746.4879999999994,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 26.339999999999996,
      "layouts": 14,
      "layoutDurationMs": 3.4790000000000005,
      "taskDurationMs": 716.1919999999999,
      "heapDeltaBytes": 1211424,
      "heapUsedBytes": 71389556,
      "domNodes": -279,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 112.26299999999999,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1734.6229999999423,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 26.177,
      "layouts": 14,
      "layoutDurationMs": 3.483,
      "taskDurationMs": 720.1840000000001,
      "heapDeltaBytes": 1571772,
      "heapUsedBytes": 72273856,
      "domNodes": -277,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 115.14000000000001,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1667.346000000009,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 15.234,
      "layouts": 6,
      "layoutDurationMs": 1.1209999999999998,
      "taskDurationMs": 328.122,
      "heapDeltaBytes": 4717676,
      "heapUsedBytes": 74842456,
      "domNodes": 79,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 10.809,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1658.5380000000214,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 12.343000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.907,
      "taskDurationMs": 285.735,
      "heapDeltaBytes": 4404852,
      "heapUsedBytes": 74279548,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 8.946000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 550.5309999999781,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.9079999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 371.838,
      "heapDeltaBytes": 18478596,
      "heapUsedBytes": 88599940,
      "domNodes": 16,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 132.13000000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 527.3339999999962,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.743000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 359.202,
      "heapDeltaBytes": 18439796,
      "heapUsedBytes": 88587892,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 122.031,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2022.196000000008,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.422999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 543.284,
      "heapDeltaBytes": 11291952,
      "heapUsedBytes": 87732664,
      "domNodes": -267,
      "jsHeapTotalBytes": -2461696,
      "scriptDurationMs": 35.772,
      "eventListeners": -170,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2028.4659999999803,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.213999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 531.697,
      "heapDeltaBytes": 10687176,
      "heapUsedBytes": 87141584,
      "domNodes": -269,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 29.959999999999994,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2131.8789999999694,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.557000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1399.2689999999998,
      "heapDeltaBytes": 4155432,
      "heapUsedBytes": 80837668,
      "domNodes": -268,
      "jsHeapTotalBytes": -401408,
      "scriptDurationMs": 664.037,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2112.86599999994,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 9.471999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1203.1670000000001,
      "heapDeltaBytes": 22721440,
      "heapUsedBytes": 89041676,
      "domNodes": -268,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 578.545,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3329.5409999999492,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 12.029000000000002,
      "layouts": 60,
      "layoutDurationMs": 13.187000000000001,
      "taskDurationMs": 1465.6219999999998,
      "heapDeltaBytes": 8423372,
      "heapUsedBytes": 76012220,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 637.926,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3182.961999999975,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 11.061000000000002,
      "layouts": 60,
      "layoutDurationMs": 11.453999999999999,
      "taskDurationMs": 1351.8349999999998,
      "heapDeltaBytes": -2002396,
      "heapUsedBytes": 76506984,
      "domNodes": -272,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 574.8350000000002,
      "eventListeners": -168,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2380.800000000022,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.476999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1547.4050000000002,
      "heapDeltaBytes": 18344772,
      "heapUsedBytes": 85029932,
      "domNodes": -9,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 744.049,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2250.599999999963,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 5.825,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1435.352,
      "heapDeltaBytes": 14225284,
      "heapUsedBytes": 81804052,
      "domNodes": -274,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 687.925,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2039.420000000007,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.460000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 508.50399999999996,
      "heapDeltaBytes": 10226652,
      "heapUsedBytes": 87581112,
      "domNodes": -266,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 31.456999999999997,
      "eventListeners": -170,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2050.092999999947,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.045,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 504.3789999999999,
      "heapDeltaBytes": 10261648,
      "heapUsedBytes": 86527316,
      "domNodes": -269,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 29.741000000000003,
      "eventListeners": -170,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 553.4260000000017,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.352,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 347.92500000000007,
      "heapDeltaBytes": 14334476,
      "heapUsedBytes": 86559696,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 114.926,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 512.1629999999868,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 6.621,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 309.21,
      "heapDeltaBytes": 14282732,
      "heapUsedBytes": 79798468,
      "domNodes": 18,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 102.19,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.941000000007,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.244999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 436.172,
      "heapDeltaBytes": -12211880,
      "heapUsedBytes": 60783220,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.062999999999999,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1996.6849999999567,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.839999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 373.576,
      "heapDeltaBytes": 141560,
      "heapUsedBytes": 64485796,
      "domNodes": 22,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 7.5180000000000025,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1722.2680000000423,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 28.860999999999997,
      "layouts": 18,
      "layoutDurationMs": 4.2170000000000005,
      "taskDurationMs": 725.506,
      "heapDeltaBytes": -827532,
      "heapUsedBytes": 71355600,
      "domNodes": -293,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 85.372,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1689.012000000048,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 27.388999999999996,
      "layouts": 18,
      "layoutDurationMs": 3.86,
      "taskDurationMs": 680.491,
      "heapDeltaBytes": -1744436,
      "heapUsedBytes": 70532360,
      "domNodes": -291,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 78.31600000000002,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 899.2350000000329,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 24.076999999999995,
      "layouts": 16,
      "layoutDurationMs": 10.477,
      "taskDurationMs": 712.8839999999999,
      "heapDeltaBytes": 21850392,
      "heapUsedBytes": 106170792,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 22.037000000000003,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 110,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8148.454000000015,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 34.292,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4737.648,
      "heapDeltaBytes": 13589760,
      "heapUsedBytes": 89689552,
      "domNodes": -258,
      "jsHeapTotalBytes": -401408,
      "scriptDurationMs": 2105.333,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8133.718000000044,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 27.981999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4488.784,
      "heapDeltaBytes": 10716856,
      "heapUsedBytes": 86429356,
      "domNodes": -266,
      "jsHeapTotalBytes": -401408,
      "scriptDurationMs": 1975.4260000000002,
      "eventListeners": -156,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13747.76099999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12887.616999999998,
      "heapDeltaBytes": -36216396,
      "heapUsedBytes": 174769572,
      "domNodes": -6548,
      "jsHeapTotalBytes": -6205440,
      "scriptDurationMs": 217.14899999999997,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12679.269999999975,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12136.561,
      "heapDeltaBytes": -45519036,
      "heapUsedBytes": 175926248,
      "domNodes": -6548,
      "jsHeapTotalBytes": -4136960,
      "scriptDurationMs": 187.677,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17227.84100000001,
      "styleRecalcs": 138,
      "styleRecalcDurationMs": 17.541999999999973,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16805.41,
      "heapDeltaBytes": -27280484,
      "heapUsedBytes": 181177680,
      "domNodes": -6548,
      "jsHeapTotalBytes": -2740224,
      "scriptDurationMs": 857.101,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 14,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16554.426000000036,
      "styleRecalcs": 118,
      "styleRecalcDurationMs": 16.167000000000016,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15993.027999999998,
      "heapDeltaBytes": -22304824,
      "heapUsedBytes": 187668892,
      "domNodes": -6548,
      "jsHeapTotalBytes": -2301952,
      "scriptDurationMs": 785.5419999999999,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 15,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4788.429000000007,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 67.40500000000002,
      "layouts": 20,
      "layoutDurationMs": 24.155999999999995,
      "taskDurationMs": 4682.529,
      "heapDeltaBytes": -25346060,
      "heapUsedBytes": 177862708,
      "domNodes": -6548,
      "jsHeapTotalBytes": 13602816,
      "scriptDurationMs": 86.306,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 183,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4868.003000000044,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 63.34200000000001,
      "layouts": 20,
      "layoutDurationMs": 22.611000000000008,
      "taskDurationMs": 4717.5869999999995,
      "heapDeltaBytes": -36686256,
      "heapUsedBytes": 180447792,
      "domNodes": -6548,
      "jsHeapTotalBytes": 12513280,
      "scriptDurationMs": 89.027,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 103,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6935.146999999972,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6519.053,
      "heapDeltaBytes": 9300600,
      "heapUsedBytes": 174749088,
      "domNodes": -2,
      "jsHeapTotalBytes": -11272192,
      "scriptDurationMs": 155.26200000000006,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6851.233999999977,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6432.495999999998,
      "heapDeltaBytes": 488952,
      "heapUsedBytes": 175236328,
      "domNodes": 0,
      "jsHeapTotalBytes": -9437184,
      "scriptDurationMs": 108.82799999999997,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 474.51599999999416,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 18.273999999999997,
      "layouts": 4,
      "layoutDurationMs": 1.652,
      "taskDurationMs": 105.281,
      "heapDeltaBytes": 5054224,
      "heapUsedBytes": 73912036,
      "domNodes": 147,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 13.094,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 447.544999999991,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 16.281999999999996,
      "layouts": 3,
      "layoutDurationMs": 1.223,
      "taskDurationMs": 83.75399999999999,
      "heapDeltaBytes": 4832796,
      "heapUsedBytes": 73062256,
      "domNodes": 121,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.501999999999999,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 49873 74427 67.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1159
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.2% 303
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.6% 261
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.8% 251
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 17, 2026
@codecov

codecov Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #17883   +/-   ##
=============================================
  Coverage              ?   82.97%           
=============================================
  Files                 ?     2052           
  Lines                 ?   119722           
  Branches              ?    32795           
=============================================
  Hits                  ?    99345           
  Misses                ?    20197           
  Partials              ?      180           
Flag Coverage Δ
e2e 67.04% <0.00%> (?)
unit 77.55% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...platform/workflow/core/services/workflowService.ts 96.99% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CodeJuggernaut CodeJuggernaut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line-for-line the #17593 merge on both files, on top of #17857, required checks green on this branch.

@DrJKL
DrJKL merged commit 985f3f2 into cloud/1.54 Sep 17, 2026
94 checks passed
@DrJKL
DrJKL deleted the backport/cloud-1.54-workflow-insert-abort-telemetry branch September 17, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants