Repository navigation
chore: add code owners for the billing and account boundary - #17757
Conversation
ADR-AUTH-BILLING-0032 records that CODEOWNERS has no entry for the billing surfaces, so domain-owner review has nothing to resolve against and the ADR's no-new-local-copies rule is convention rather than a gate. Lists the billing half; the account layer's session and identity paths stay unlisted until their owner claims them.
🎭 Playwright: ✅ 2018 passed, 0 failed📊 Browser Reports
📦 Bundle: 10 MB gzip 🔴 +135 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 26.2 kB (baseline 26.2 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 123 kB (baseline 123 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.73 MB (baseline 3.73 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 18 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.5 MB (baseline 17.5 MB) • 🟢 -74 BBundles that do not match a named category
Status: 72 added / 72 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-15T18:44:49.911Z",
"gitSha": "fe5cba8c5a53326d614915e727e4ffad708b7ed7",
"branch": "jaewon/codeowners-billing-boundary",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.6099999999997,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.738999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.294,
"heapDeltaBytes": 2469200,
"heapUsedBytes": 63632288,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.228,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2008.0079999999612,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.211000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.97700000000003,
"heapDeltaBytes": 5806628,
"heapUsedBytes": 68097020,
"domNodes": -263,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.789,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2044.6469999999977,
"styleRecalcs": 81,
"styleRecalcDurationMs": 34.76500000000001,
"layouts": 14,
"layoutDurationMs": 4.9350000000000005,
"taskDurationMs": 1040.74,
"heapDeltaBytes": -1031904,
"heapUsedBytes": 61350784,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 193.372,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1892.6159999999754,
"styleRecalcs": 79,
"styleRecalcDurationMs": 32.184000000000005,
"layouts": 14,
"layoutDurationMs": 4.286,
"taskDurationMs": 899.3580000000001,
"heapDeltaBytes": 184520,
"heapUsedBytes": 62361360,
"domNodes": -261,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 171.672,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.696000000009,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.94,
"layouts": 6,
"layoutDurationMs": 1.176,
"taskDurationMs": 332.58400000000006,
"heapDeltaBytes": 2162828,
"heapUsedBytes": 64218464,
"domNodes": 74,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.097,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.0609999999024,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.98,
"layouts": 6,
"layoutDurationMs": 1.138,
"taskDurationMs": 339.025,
"heapDeltaBytes": 1763564,
"heapUsedBytes": 64200468,
"domNodes": 76,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 10.581,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 640.5070000000137,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.809000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.844,
"heapDeltaBytes": 17856120,
"heapUsedBytes": 80013680,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 166.42200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 694.9100000000499,
"styleRecalcs": 13,
"styleRecalcDurationMs": 11.03,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.06800000000004,
"heapDeltaBytes": 18003444,
"heapUsedBytes": 79851780,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 171.44799999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2014.8340000000076,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.7769999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.4499999999999,
"heapDeltaBytes": 4249452,
"heapUsedBytes": 83503184,
"domNodes": -248,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 32.47499999999999,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 1998.5050000000228,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.9250000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.8149999999999,
"heapDeltaBytes": 19677068,
"heapUsedBytes": 83595680,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.163,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2290.0900000000206,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.516,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1660.7339999999997,
"heapDeltaBytes": 15164892,
"heapUsedBytes": 79343636,
"domNodes": 4,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 878.962,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2568.263999999999,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.085999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1746.9289999999999,
"heapDeltaBytes": 15219960,
"heapUsedBytes": 79347564,
"domNodes": -251,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 884.464,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3552.1009999999933,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.565999999999999,
"layouts": 60,
"layoutDurationMs": 13.146,
"taskDurationMs": 1695.6740000000002,
"heapDeltaBytes": 8022248,
"heapUsedBytes": 74240896,
"domNodes": -9,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 792.293,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3814.2990000000054,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.809000000000001,
"layouts": 60,
"layoutDurationMs": 14.006,
"taskDurationMs": 1857.151,
"heapDeltaBytes": 11188672,
"heapUsedBytes": 75096364,
"domNodes": -258,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 857.677,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3010.951000000034,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.800000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1840.0349999999999,
"heapDeltaBytes": -1738312,
"heapUsedBytes": 81544544,
"domNodes": -229,
"jsHeapTotalBytes": 1982464,
"scriptDurationMs": 1000.4559999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3126.0310000000118,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.045000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2002.388,
"heapDeltaBytes": 25777160,
"heapUsedBytes": 91801888,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 1023.3149999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1999.623999999983,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.2130000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.92400000000004,
"heapDeltaBytes": 19321068,
"heapUsedBytes": 83832892,
"domNodes": -251,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.007,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.7989999999354,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.787,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 645.85,
"heapDeltaBytes": -3421832,
"heapUsedBytes": 83996828,
"domNodes": -250,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 38.51599999999999,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.4890000000141,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.026000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.10100000000006,
"heapDeltaBytes": 13288316,
"heapUsedBytes": 76709324,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 142.953,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.8899999999921,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.804999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.6770000000001,
"heapDeltaBytes": 13539736,
"heapUsedBytes": 77034880,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 143.88400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.363999999986,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.407,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.35,
"heapDeltaBytes": -3259076,
"heapUsedBytes": 60204200,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.563000000000002,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2003.4890000000587,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.44,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.49399999999997,
"heapDeltaBytes": -2639384,
"heapUsedBytes": 60824024,
"domNodes": -277,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.750999999999998,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.5239999999876,
"styleRecalcs": 76,
"styleRecalcDurationMs": 25.461,
"layouts": 18,
"layoutDurationMs": 5.388000000000001,
"taskDurationMs": 684.6419999999999,
"heapDeltaBytes": 6576224,
"heapUsedBytes": 69604968,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 112.02900000000001,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.5809999999956,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.032999999999998,
"layouts": 18,
"layoutDurationMs": 5.288,
"taskDurationMs": 799.527,
"heapDeltaBytes": 9852376,
"heapUsedBytes": 73028100,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 110.57600000000001,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.5340000000501,
"styleRecalcs": 17,
"styleRecalcDurationMs": 31.896,
"layouts": 5,
"layoutDurationMs": 13.152999999999999,
"taskDurationMs": 933.3259999999999,
"heapDeltaBytes": 20078852,
"heapUsedBytes": 103338016,
"domNodes": 13587,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 34.967,
"eventListeners": 2387,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8382.034000000032,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.74,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5775.667,
"heapDeltaBytes": -12355752,
"heapUsedBytes": 66755068,
"domNodes": -245,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 2773.961,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8503.157000000101,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.07,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5860.042,
"heapDeltaBytes": -3114116,
"heapUsedBytes": 76930100,
"domNodes": -222,
"jsHeapTotalBytes": 1527808,
"scriptDurationMs": 2813.301,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16815.495999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16355.805,
"heapDeltaBytes": -15256524,
"heapUsedBytes": 174324040,
"domNodes": -6542,
"jsHeapTotalBytes": 675840,
"scriptDurationMs": 274.606,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17254.969000000074,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16795.318,
"heapDeltaBytes": -27045464,
"heapUsedBytes": 174248816,
"domNodes": -6542,
"jsHeapTotalBytes": 2564096,
"scriptDurationMs": 279.305,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20474.829999999998,
"styleRecalcs": 168,
"styleRecalcDurationMs": 17.642999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20180.807999999997,
"heapDeltaBytes": -18157884,
"heapUsedBytes": 176605024,
"domNodes": -6542,
"jsHeapTotalBytes": 991232,
"scriptDurationMs": 876.084,
"eventListeners": -7474,
"totalBlockingTimeMs": 82,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16367.735999999923,
"styleRecalcs": 93,
"styleRecalcDurationMs": 14.607999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16111.213,
"heapDeltaBytes": -39140292,
"heapUsedBytes": 174932728,
"domNodes": -6542,
"jsHeapTotalBytes": -4919296,
"scriptDurationMs": 906.6759999999999,
"eventListeners": -7478,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6020.1150000000325,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.18300000000004,
"layouts": 20,
"layoutDurationMs": 23.384,
"taskDurationMs": 5926.77,
"heapDeltaBytes": -25035324,
"heapUsedBytes": 193579640,
"domNodes": -6542,
"jsHeapTotalBytes": 14843904,
"scriptDurationMs": 101.56800000000001,
"eventListeners": -7476,
"totalBlockingTimeMs": 344,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4786.656999999991,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.64399999999996,
"layouts": 20,
"layoutDurationMs": 24.962999999999997,
"taskDurationMs": 4650.099,
"heapDeltaBytes": -18230864,
"heapUsedBytes": 176659736,
"domNodes": -6542,
"jsHeapTotalBytes": 24322048,
"scriptDurationMs": 99.516,
"eventListeners": -7478,
"totalBlockingTimeMs": 98,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6388.146000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6124.149000000001,
"heapDeltaBytes": 10129768,
"heapUsedBytes": 193303536,
"domNodes": 0,
"jsHeapTotalBytes": -13369344,
"scriptDurationMs": 100.35799999999995,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8401.847999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8242.939,
"heapDeltaBytes": -3762632,
"heapUsedBytes": 159711792,
"domNodes": 0,
"jsHeapTotalBytes": -6815744,
"scriptDurationMs": 151.23100000000005,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 497.66199999999117,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.023,
"layouts": 5,
"layoutDurationMs": 3.129,
"taskDurationMs": 147.58999999999997,
"heapDeltaBytes": 5335628,
"heapUsedBytes": 67029156,
"domNodes": 149,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 18.204000000000004,
"eventListeners": 83,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 109.0199999999868,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.840000000000002,
"layouts": 3,
"layoutDurationMs": 1.74,
"taskDurationMs": 78.16499999999998,
"heapDeltaBytes": 3019156,
"heapUsedBytes": 64926024,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.984000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe CODEOWNERS file now includes reviewer assignments for billing core, billing web, and workshop-related website paths. ChangesCODEOWNERS ownership rules
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to No concrete merge-blocking issue is identified in the ownership-rule update. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17757 +/- ##
==========================================
+ Coverage 82.52% 83.55% +1.02%
==========================================
Files 2801 2151 -650
Lines 140641 124816 -15825
Branches 37749 33349 -4400
==========================================
- Hits 116066 104286 -11780
+ Misses 23386 20248 -3138
+ Partials 1189 282 -907
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| /apps/website/src/lib/workshop/ @dante01yoon @Comfy-Org/comfy_website_devs | ||
| /apps/website/src/config/workshop-account.ts @dante01yoon @Comfy-Org/comfy_website_devs | ||
| /apps/website/src/config/workshop-balance.ts @dante01yoon @Comfy-Org/comfy_website_devs | ||
| /apps/website/src/config/workshop-credits.ts @dante01yoon @Comfy-Org/comfy_website_devs |
There was a problem hiding this comment.
are these necessary for this PR?
There was a problem hiding this comment.
Checked all four against ADR-AUTH-BILLING-0032 and what's on main. Short answer: two are named by the ADR, one is deliberate, one is a fair hit — and I missed a fifth.
workshop-balance.ts / workshop-credits.ts — yes. The ADR's Context names exactly these two as the only place the V1 boundary was recorded before the write-up ("recorded only in two source-file header comments"), and both still carry the billing stays outside @comfyorg/account in V1 header. Rule 3 also singles out workshop-balance.ts's reader as the one comparing token instead of workspace, and defers the fix to "a separate change against a hardened path" — a deferral like that is the thing that needs an owner to come back to.
/apps/website/src/lib/workshop/ — a directory on purpose. The two modules rule 4 authorizes (buy-credits.ts, workspaces.ts) live there. Listing just those two wouldn't catch a new subscriptions.ts dropped next to them, which is precisely the rule-4 violation the entry exists to gate. The cost is real: 29 files, and most are labels and copy (initials.ts, use-case-label.ts, model-docs.ts), so a string change routes here too. Say the word and I'll narrow it to the two files, accepting that a new sibling then lands unowned.
workshop-account.ts — you're right to poke at this one. It exports the session client and the sessionStorage credential cache, i.e. the identity half this block's own comment says it is deliberately not claiming. It also exports workshopBalanceReader, so it straddles rather than sits cleanly on one side. I'd rather drop it than have the file contradict its own comment.
And one I should have caught: workshop-billing-sdk.ts isn't listed and belongs more than workshop-account.ts does — it's the site's single composition of @comfyorg/account/billing (transport, readers, lifecycle, top-up command), which is the exact surface rule 5's convergence lands on.
Proposed: swap workshop-account.ts → workshop-billing-sdk.ts, leave the other three. Want that, or the narrower file-level version of line 78 as well?
Summary
Gives the billing surfaces a required reviewer, so the boundary recorded in ADR-AUTH-BILLING-0032 has something to resolve against.
Changes
CODEOWNERSentries coveringpackages/account/src/core/billing/,apps/billing-web/,apps/website/src/lib/workshop/, and the threeworkshop-account/balance/creditsconfig modules. Every path was checked to exist onmain.Review Focus
CODEOWNERScurrently has no entry forpackages/account/,apps/website/, or either billing surface. That is why #17736 has to describe its own rule 4 as convention rather than a gate: "domain-owner review" has no owner to route to, and the PR risk workflow is advisory by construction (ci-pr-risk.ymlcalls itself a shadow check). These entries are the smallest thing that turns that rule into a real gate.This lists the billing half only, on purpose. The account layer's session and identity paths —
packages/account/src/core/session.ts,packages/account/src/firebase/, and whatever else you consider yours — are deliberately unlisted, because naming an owner for them is not mine to do. Tell me which paths you want and I will add them here rather than opening a second PR. Until then a change crossing that side of the boundary still has no required reviewer, which is worth being explicit about rather than papering over; the comment in the file says so.Two things worth checking:
billing-webroute to@Comfy-Org/comfy_frontend_devs, the Workshop site paths to@Comfy-Org/comfy_website_devs. If the site paths should carry frontend-devs too, say so.src/platform/workspace/billing/is not listed because it does not exist onmainyet — feat(billing): route top-up through the account billing SDK behind a flag (FE-2216) #17665 creates it. It should be added when that lands, not pre-emptively.Companion to #17736; neither blocks the other.