Repository navigation
test: audit and remove 56 untyped mock escapes - #17682
Conversation
🎭 Playwright: ✅ 1996 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 10 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 26.2 kB (baseline 26.2 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 123 kB (baseline 123 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.72 MB (baseline 3.72 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 37 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.5 MB (baseline 17.5 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-15T00:14:28.702Z",
"gitSha": "e8e88a904a0c159b9663af5c29d3af5f5f7dc930",
"branch": "drjkl/fe-2343-trivial-mock-factories",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2046.6350000000375,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.729000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.397,
"heapDeltaBytes": 4353332,
"heapUsedBytes": 66098892,
"domNodes": -262,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.384000000000002,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1991.7440000000397,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.482,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.295,
"heapDeltaBytes": 6757056,
"heapUsedBytes": 68660820,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.851999999999998,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1834.7929999999906,
"styleRecalcs": 75,
"styleRecalcDurationMs": 25.265000000000004,
"layouts": 14,
"layoutDurationMs": 4.2170000000000005,
"taskDurationMs": 813.79,
"heapDeltaBytes": 11575120,
"heapUsedBytes": 72429968,
"domNodes": -262,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 163.861,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1810.295999999994,
"styleRecalcs": 75,
"styleRecalcDurationMs": 26.724,
"layouts": 14,
"layoutDurationMs": 4.278,
"taskDurationMs": 736.84,
"heapDeltaBytes": 15966488,
"heapUsedBytes": 78046416,
"domNodes": -263,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 164.52800000000002,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.7889999999707,
"styleRecalcs": 29,
"styleRecalcDurationMs": 15.662000000000003,
"layouts": 6,
"layoutDurationMs": 1.161,
"taskDurationMs": 333.623,
"heapDeltaBytes": 2211772,
"heapUsedBytes": 64296872,
"domNodes": 74,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.096999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.9800000000305,
"styleRecalcs": 33,
"styleRecalcDurationMs": 14.932999999999998,
"layouts": 6,
"layoutDurationMs": 1.269,
"taskDurationMs": 326.727,
"heapDeltaBytes": 2067744,
"heapUsedBytes": 64338608,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.359,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 646.2099999999964,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.026,
"heapDeltaBytes": 17950364,
"heapUsedBytes": 79985928,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 170.488,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 614.4359999999551,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.032000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.075,
"heapDeltaBytes": 18077116,
"heapUsedBytes": 79886220,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 161.95700000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2031.1510000000226,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.025000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 622.194,
"heapDeltaBytes": 3976896,
"heapUsedBytes": 83119008,
"domNodes": -245,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 33.9,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2031.8190000000413,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.375999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 603.655,
"heapDeltaBytes": 4126384,
"heapUsedBytes": 83453964,
"domNodes": -249,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 34.50399999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2239.3390000000863,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.196999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1646.3330000000003,
"heapDeltaBytes": 18539416,
"heapUsedBytes": 82974860,
"domNodes": -253,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 830.7679999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2301.969999999983,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.277000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1629.0580000000002,
"heapDeltaBytes": 19567836,
"heapUsedBytes": 84353096,
"domNodes": 0,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 872.199,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3498.342999999977,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.933999999999997,
"layouts": 60,
"layoutDurationMs": 12.437,
"taskDurationMs": 1682.625,
"heapDeltaBytes": -12007952,
"heapUsedBytes": 69366312,
"domNodes": -257,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 774.543,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3490.545999999995,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.179999999999998,
"layouts": 60,
"layoutDurationMs": 12.558,
"taskDurationMs": 1649.3449999999998,
"heapDeltaBytes": 8423716,
"heapUsedBytes": 74426604,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 772.753,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3083.1779999999753,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.380000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1981.349,
"heapDeltaBytes": 1172344,
"heapUsedBytes": 84705056,
"domNodes": -257,
"jsHeapTotalBytes": 1720320,
"scriptDurationMs": 1007.57,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3042.291000000091,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.866000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1892.0759999999998,
"heapDeltaBytes": 18369592,
"heapUsedBytes": 84634612,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 967.029,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.7660000000287,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.574,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.3160000000001,
"heapDeltaBytes": -3586032,
"heapUsedBytes": 83721940,
"domNodes": -246,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 33.660999999999994,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.0710000000308,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.211,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.849,
"heapDeltaBytes": -8173420,
"heapUsedBytes": 79120012,
"domNodes": -251,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 32.844000000000015,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 540.1630000000068,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.291,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.68100000000004,
"heapDeltaBytes": 13701136,
"heapUsedBytes": 76556908,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 142.605,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.8029999999981,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.214,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.92400000000004,
"heapDeltaBytes": 13856940,
"heapUsedBytes": 77003800,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.06,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.4989999999862,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.306999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.64799999999997,
"heapDeltaBytes": 16973404,
"heapUsedBytes": 80136560,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.898,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.6890000000376,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.788000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.16999999999996,
"heapDeltaBytes": -5818056,
"heapUsedBytes": 57812116,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.7860000000000005,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.4740000000102,
"styleRecalcs": 78,
"styleRecalcDurationMs": 29.590999999999998,
"layouts": 18,
"layoutDurationMs": 5.7540000000000004,
"taskDurationMs": 855.615,
"heapDeltaBytes": 715992,
"heapUsedBytes": 64155772,
"domNodes": -276,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 119.81899999999999,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1716.7210000000068,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.302000000000003,
"layouts": 18,
"layoutDurationMs": 4.958,
"taskDurationMs": 765.0250000000001,
"heapDeltaBytes": 9375220,
"heapUsedBytes": 72903772,
"domNodes": -277,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 104.894,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.1209999999892,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.444999999999993,
"layouts": 5,
"layoutDurationMs": 13.721999999999998,
"taskDurationMs": 955.7889999999998,
"heapDeltaBytes": 20072284,
"heapUsedBytes": 103104532,
"domNodes": 13587,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 31.867000000000008,
"eventListeners": 2387,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8590.102000000003,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.919000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6031.445000000001,
"heapDeltaBytes": 1140668,
"heapUsedBytes": 81272488,
"domNodes": -248,
"jsHeapTotalBytes": 1003520,
"scriptDurationMs": 2966.968,
"eventListeners": -136,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8313.001999999982,
"styleRecalcs": 245,
"styleRecalcDurationMs": 31.364000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5661.018999999999,
"heapDeltaBytes": 10984628,
"heapUsedBytes": 74880548,
"domNodes": -251,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 2737.0989999999997,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16866.508000000067,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16420.381,
"heapDeltaBytes": -23304200,
"heapUsedBytes": 178322772,
"domNodes": -6542,
"jsHeapTotalBytes": -319488,
"scriptDurationMs": 266.478,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16800.57199999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16260.95,
"heapDeltaBytes": -27703652,
"heapUsedBytes": 181804900,
"domNodes": -6540,
"jsHeapTotalBytes": -3117056,
"scriptDurationMs": 253.859,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20400.633000000085,
"styleRecalcs": 155,
"styleRecalcDurationMs": 16.58599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20142.164999999997,
"heapDeltaBytes": -24644108,
"heapUsedBytes": 176596588,
"domNodes": -6542,
"jsHeapTotalBytes": 204800,
"scriptDurationMs": 855.0559999999999,
"eventListeners": -7474,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20293.76000000002,
"styleRecalcs": 166,
"styleRecalcDurationMs": 16.004999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19900.782,
"heapDeltaBytes": -6822852,
"heapUsedBytes": 188014736,
"domNodes": -6542,
"jsHeapTotalBytes": -913408,
"scriptDurationMs": 859.0439999999999,
"eventListeners": -7472,
"totalBlockingTimeMs": 73,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6174.049999999966,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.37399999999997,
"layouts": 20,
"layoutDurationMs": 23.360000000000007,
"taskDurationMs": 6081.516,
"heapDeltaBytes": -26633504,
"heapUsedBytes": 174923400,
"domNodes": -6542,
"jsHeapTotalBytes": 11214848,
"scriptDurationMs": 108.009,
"eventListeners": -7472,
"totalBlockingTimeMs": 409,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6112.83299999991,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.63499999999998,
"layouts": 20,
"layoutDurationMs": 22.85699999999999,
"taskDurationMs": 6049.42,
"heapDeltaBytes": -38177984,
"heapUsedBytes": 180464312,
"domNodes": -6542,
"jsHeapTotalBytes": 13533184,
"scriptDurationMs": 117.248,
"eventListeners": -7474,
"totalBlockingTimeMs": 394,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8313.848000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7798.816999999998,
"heapDeltaBytes": 4455880,
"heapUsedBytes": 188692728,
"domNodes": 0,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 128.29200000000003,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8699.103000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8368.45,
"heapDeltaBytes": 21969124,
"heapUsedBytes": 174811628,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 141.77200000000002,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 121.45500000008269,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.19,
"layouts": 3,
"layoutDurationMs": 0.851,
"taskDurationMs": 94.14500000000001,
"heapDeltaBytes": 3177076,
"heapUsedBytes": 64836708,
"domNodes": 111,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.212000000000002,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 106.24099999995451,
"styleRecalcs": 8,
"styleRecalcDurationMs": 18.520000000000003,
"layouts": 4,
"layoutDurationMs": 2.02,
"taskDurationMs": 85.98599999999998,
"heapDeltaBytes": 3191884,
"heapUsedBytes": 64886856,
"domNodes": 132,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.761999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates Vitest mocks across test files. It removes explicit ChangesVitest mock cleanup
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~10 minutes Change: Refactor Possibly related PRs
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The changes are limited to test mock typing and the reported validation preserves behavior; the PR is mergeable. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17682 +/- ##
==========================================
+ Coverage 82.61% 83.72% +1.11%
==========================================
Files 2776 2130 -646
Lines 139684 124160 -15524
Branches 35878 31580 -4298
==========================================
- Hits 115395 103954 -11441
+ Misses 23185 20024 -3161
+ Partials 1104 182 -922
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
## Summary Remove five more `vi.mock<unknown>` escapes for [FE-2343](https://linear.app/comfyorg/issue/FE-2343/audit-and-remove-remaining-vimockunknown-partial-factories-1313-sites). Stacked on Comfy-Org#17682; review this diff against that branch. ## Changes - Use `as const` for literal results, `Set<string>` for graph IDs, and the existing `SecretErrorCode` type for error doubles. - Remove the survey fixture's copied type declaration. No new mock members, runtime imports, or test assertions. - Remaining inventory: 1,211 escapes in 512 files, down from 1,216 in 515. Audit and compiler-probe scripts stay in ignored `temp/`. ## Review Focus All five factories now pass module-type inference. Emitted JavaScript tokens match the parent tip, ignoring whitespace and comments. Validation: 141 tests across five files pass; full typecheck, scoped Oxlint/ESLint/format checks, and Knip pass. No production or UI changes. --------- Co-authored-by: Amp <amp@ampcode.com>
Summary
Restore module type checking at 56
vi.mock<unknown>sites without changing runtime behavior. Partial progress on FE-2343.Changes
as constin four distribution mocks and one animation-preview constant mock. No namespace imports or explicit partial-module return annotations are needed.temp/. No suppression comments, mock helpers, or production changes.Review Focus
The checkout started with 1,272 sites in 524 files, versus the issue's older 1,313-site count. Removing every escape exposed 1,221
TS2769diagnostics. Five more factories compile when their literals are preserved; 1,216 sites in 515 files remain and need fixture or signature repairs.Largest remaining modules:
@/scripts/app(101),@/scripts/api(88),@/platform/telemetry(78),useBillingContext(49), anduseFeatureFlags(37). These partial instance and composable mocks need a separate repair pass; this PR does not claim they are impossible to type.Validation:
pnpm typecheck,pnpm knip, and changed-file Oxlint, ESLint, and formatting checks pass. Repository-wide lint passed before the review revision.pass.